From nobody Sat Oct 4 00:21:57 2025 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89DA72F6198 for ; Fri, 22 Aug 2025 09:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755855634; cv=none; b=V3JyFVDvOuPz9CAyleQSbx0hEFp1KBmLYFdrg8jYn2fSXw2Fq0ZPmldubrwKcmcVdBuYFjceiUXLZnKEghRDWw43bYKpLK+rLXPgStRD9NaIyfWduCQ1w5a/YHm9htpOJslqZwMfnzCQVHKwFjd1SE/xYfM9k7fWYahgqDbhXsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755855634; c=relaxed/simple; bh=Mfh6IznOBaQuafYVuPQLNT0TvqF/soo23QMczzfIN7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eCsY2lF+5/bozW6qXJx3BDMUkXL3Mu8DeB4T9eFEOP2AXsxIclEW9pbuBjSKIYtQ16U7Kw6qqNKDIVMtvo4/ltiR4UA3IvwBUX5621NJKCraeqc5wQAmSKM0MpxEHOemYNOVKeuC9n/Azr371HvGYWaZZQXBSxud5ePG3lWDrQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DEF4921D7D; Fri, 22 Aug 2025 09:35:10 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D323C13A31; Fri, 22 Aug 2025 09:35:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oOxBMc05qGihMAAAD6G6ig (envelope-from ); Fri, 22 Aug 2025 09:35:09 +0000 From: Stanimir Varbanov To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Broadcom internal kernel review list Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Andrea della Porta , Nicolas Ferre , Claudiu Beznea , Phil Elwell , Jonathan Bell , Dave Stevenson , Stanimir Varbanov , stable@vger.kernel.org, Andrew Lunn Subject: [PATCH v2 1/5] net: cadence: macb: Set upper 32bits of DMA ring buffer Date: Fri, 22 Aug 2025 12:34:36 +0300 Message-ID: <20250822093440.53941-2-svarbanov@suse.de> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250822093440.53941-1-svarbanov@suse.de> References: <20250822093440.53941-1-svarbanov@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[dt,netdev] X-Rspamd-Queue-Id: DEF4921D7D X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.00 Content-Type: text/plain; charset="utf-8" In case of rx queue reset and 64bit capable hardware, set the upper 32bits of DMA ring buffer address. Cc: stable@vger.kernel.org # v4.6+ Fixes: 9ba723b081a2 ("net: macb: remove BUG_ON() and reset the queue to han= dle RX errors") Credits-to: Phil Elwell Credits-to: Jonathan Bell Signed-off-by: Stanimir Varbanov Reviewed-by: Andrew Lunn Acked-by: Nicolas Ferre Reviewed-by: Claudiu Beznea --- v1 -> v2:=20 - Added credits. - Use lower_32_bits() for RBQP register writes for consistency (Nicolas). - Added Fixes tag. drivers/net/ethernet/cadence/macb_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c index ce95fad8cedd..36717e7e5811 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -1634,7 +1634,11 @@ static int macb_rx(struct macb_queue *queue, struct = napi_struct *napi, macb_writel(bp, NCR, ctrl & ~MACB_BIT(RE)); =20 macb_init_rx_ring(queue); - queue_writel(queue, RBQP, queue->rx_ring_dma); + queue_writel(queue, RBQP, lower_32_bits(queue->rx_ring_dma)); +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT + if (bp->hw_dma_cap & HW_DMA_CAP_64B) + macb_writel(bp, RBQPH, upper_32_bits(queue->rx_ring_dma)); +#endif =20 macb_writel(bp, NCR, ctrl | MACB_BIT(RE)); =20 --=20 2.47.0