From nobody Sat Oct 4 00:20:05 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B861F2475C7; Fri, 22 Aug 2025 08:23:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755850993; cv=none; b=DsgbtxNAscFnEHxr/QYOP4qajb8qsP9dHxJnc97ELukVxmmLmJVs2tF1Zmus7ajQJpkBxdieg/xncp0Y4ee75ehInGUiRZdQk3Oe/TeJd+DTpXQnu9BoChVTO7h8bgejb6mLppb9DuVulwJdsL46HpbqX4tK3U/OZdcM5PYFiOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755850993; c=relaxed/simple; bh=aHdKM33fPfvODogG5EIfl2ZQHN+nSUZVsocpGCSr2PI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LoIkyZeF2vQlw2uDylYqYLjDEb6W2Q28d1ZxXNbcVeZLPFJcPVVEcGZ2Pz6EL5pccsLgF1BlmUNysKc/LW2aj7FaES1XksPjwdRhwzQ+znPsbgewCwKaRTxdDOpWpA15GLg51t8Q+YimWjFqpLuLQOef9yEoz4+XwXnPV/pbdSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=OGkNfH2+; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="OGkNfH2+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1755850990; bh=aHdKM33fPfvODogG5EIfl2ZQHN+nSUZVsocpGCSr2PI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OGkNfH2+jOKoqsx4XZqdfcwgt5aP8gbPPl82/usiD/mSerW8TBt/XWrm8vxI1zLpK eqcr1/i/34b4xZc0sJCqCeN9WAVRV28rq+MnTzIFG95wrWT8p2l16Nom1XVGvbRMkU /XfZMJLkH4q/k3giOG1XhtkdHJUte8XcUlb4m3GG1+vS++hxw0RDLbu67zL0pWxBp9 Y0fe+ERCypRn+qaBnXtNXTwGEfvJmiG6AnmA9QIziJ59Ql4CoOWW/skcucNYUfH3nz 2Y+8tIu4BinYPStQB/I8QnEondQp1YOhBDz76oVxE6fLq0URfGaLnzH5UM4IOS9m1d MfHrw+RQE2ltA== Received: from mt.tail9873f4.ts.net (unknown [103.151.43.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by bali.collaboradmins.com (Postfix) with ESMTPSA id D0F1817E137E; Fri, 22 Aug 2025 10:23:04 +0200 (CEST) From: Muhammad Usama Anjum To: Shuah Khan , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, kevin.brodsky@arm.com Cc: Muhammad Usama Anjum , kernel@collabora.com, Sidhartha Kumar Subject: [PATCH v3 2/8] selftests/mm: protection_keys: Fix dead code Date: Fri, 22 Aug 2025 13:20:59 +0500 Message-ID: <20250822082145.4145617-3-usama.anjum@collabora.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250822082145.4145617-1-usama.anjum@collabora.com> References: <20250822082145.4145617-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The while loop doesn't execute and following warning gets generated: protection_keys.c:561:15: warning: code will never be executed [-Wunreachable-code] int rpkey =3D alloc_random_pkey(); Let's enable the while loop such that it gets executed nr_iterations times. Simplify the code a bit as well. Reviewed-by: Sidhartha Kumar Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/protection_keys.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/protection_keys.c b/tools/testing/s= elftests/mm/protection_keys.c index 23ebec367015f..6281d4c61b50e 100644 --- a/tools/testing/selftests/mm/protection_keys.c +++ b/tools/testing/selftests/mm/protection_keys.c @@ -557,13 +557,11 @@ int mprotect_pkey(void *ptr, size_t size, unsigned lo= ng orig_prot, int nr_iterations =3D random() % 100; int ret; =20 - while (0) { + while (nr_iterations-- >=3D 0) { int rpkey =3D alloc_random_pkey(); ret =3D sys_mprotect_pkey(ptr, size, orig_prot, pkey); dprintf1("sys_mprotect_pkey(%p, %zx, prot=3D0x%lx, pkey=3D%ld) ret: %d\n= ", ptr, size, orig_prot, pkey, ret); - if (nr_iterations-- < 0) - break; =20 dprintf1("%s()::%d, ret: %d pkey_reg: 0x%016llx" " shadow: 0x%016llx\n", --=20 2.47.2