From nobody Sat Oct 4 01:41:10 2025 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 969932F0685; Thu, 21 Aug 2025 09:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755769104; cv=none; b=cR4xQAPgP5J7riJDRuapnTKLHPTqDZ60s683pgNyCQQACztEHS6JNs0R+ehkPOwHQ8Mo20Ug6QmaDrB7CFseGVgSVOn3NVRfvQEnt59CHDDK6Nb1lL4s+4eoX5kD0dMadVyEmmNoouiRv+Q++14bSTYSqHvjyAofJmVwoVkoPaY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755769104; c=relaxed/simple; bh=H3nbbMh6DFmUXspQhhndw/hL2Ne9GOlz0qBRkIv+PXk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V9nt9jPuleFDXWf8UlU1xJaxi2gz53PTK9/BJGOnAECc3D1IQRIE20+f/U+4wOQQUfVEqNbF98lwBtxvaTkuBaXh3gAiRA+mISyic4s6zrKy9p5tFVJRu8zEseVZOCtAbRVLCHw2Ke4+Bw2N4vv/Mdti/qUIwEbdI8AgDmNPPiM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BGeURLtZ; arc=none smtp.client-ip=209.85.215.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BGeURLtZ" Received: by mail-pg1-f195.google.com with SMTP id 41be03b00d2f7-b471738daabso675701a12.1; Thu, 21 Aug 2025 02:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755769102; x=1756373902; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yWBLnMnjRe/tJ9Xuvh/nd9/uV5uIZZike6HE1ZIhSY0=; b=BGeURLtZyuBPwy2hH8cDqDAlIQQXcqHTN//hhGs6JwOCU0dOrhJS9GQLlhXjr+fo7d Di5VBhSxzPAcm7MSRbmrHMoFaXzSw0A9fXdj54ow5QXUX/Vsyj85heJtQ4AUtdHlmYJx vuz4YXV/fhf/1tYg58LrNT2jTFwFKyqt+2C7ga17i4vv9A1JMqvB+rXs4WqaFwqUWBx6 DA2Wp2GiBD+glCwz8Yx/j0BNhVEo1lKXXhIlyO7TrbxmSKeoi2iUAOzQcwKDqvVUkG0M awYT9ny2T+q5Frxwuol4NtbpB+LIBusqFy4Uu3SyQp76+Uem+LRD00a/6gJGEqCidhts afng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755769102; x=1756373902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yWBLnMnjRe/tJ9Xuvh/nd9/uV5uIZZike6HE1ZIhSY0=; b=kAFCkXvwG2yvaz2INQMt5MVSs00NYlqQEre79xP9LocTyU1EU7+yWJZ+MKGwLLejsi AyaW/4oGddK8McPkLTCguRcX05LNKJljvQeAe69kFxqNDVSMDzhjHGnrhg0Mb1UP5Sg/ /VkIWxQLSqM9DWtCAjUmkai4Xj0KQavBtODGuCfWr9nMRSymUu/R8sqjvSIZe7ikP/LK iDlZ7acCfa9C5o5EXQgMirTc6ktnF1W8RE4LlSx9qZyImzTZEr3wDDVLXMr8RMJcx2OC ARN8OU8NfhyhWZ4xv/LJk2Y6FdxRnii/+3wzluTuCZP9Nh304WUZnCVmU3hMLUeOKBBt 0o4Q== X-Forwarded-Encrypted: i=1; AJvYcCUAYZjPh9k4dssET7NeX1McNtB/aK0AUXW8byOzdryAUihxhg2ugDWaJlG4dbXTVbiXA76NXJXIsDCu/3nV@vger.kernel.org, AJvYcCUHW/hbkrD/pX61UxKxxd7kzxiBOMpZtvYnneXhfzxaRQ4bEmjZhCDTCgv9mhsIx07LTHU=@vger.kernel.org X-Gm-Message-State: AOJu0YxsMkQMOY64iViYhN+Z6QewWiBmdfkOlrIMZ1gnPAn7H2ChTVGy LdunUFBASTqvGxFYM61hGoY+l1cEGWAuIvD6k6i94tuqtCI8+xmPmPwy X-Gm-Gg: ASbGncuA7qs6W8fzpD3fCymdHZcAgjbfI7lAhkisO9epO1or3bi9/W3ZGhJ75mNKkIB YpSbLcedUTG8POwufKpCNiZyINOknF+I4u/YHezGwWZ1baakQhvM283VP1+wdRPi6A3vlH99oBj Dkxgpxt5FP+697sjZKxkGXyvsj52u8pRrMIdJg36FzwQ1TzH2j2pU07CyuDYPOBeZXHBjh4t4sm 0Tl724EHrrvTujYIwIlI9UDclag0rsDcoUD3OH2npaiBdmdwaI5znxNZkQYxS28YhiSdtZva2c6 61xqEK9prje3MogIkmTR5qm0oFXcqYMvwAA4yXbEGlBW3kNu55x7ecxiNMDwtV/ZcnocwpHrBiK V8TPoiHvVCtR9KkJTtRFKEBY8ujU6965TaQ== X-Google-Smtp-Source: AGHT+IFDhZ+fp3uwzS50g/aI7i9nB/QIv2irpccgJ204DPlbXL7yPv538SW+ob5fmOqxEDHqkgAGQA== X-Received: by 2002:a17:902:e88a:b0:246:1f24:5f56 with SMTP id d9443c01a7336-2461f248979mr1309275ad.7.1755769101843; Thu, 21 Aug 2025 02:38:21 -0700 (PDT) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed540040sm49652085ad.163.2025.08.21.02.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 02:38:21 -0700 (PDT) From: Menglong Dong X-Google-Original-From: Menglong Dong To: peterz@infradead.org Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, tzimmermann@suse.de, simona.vetter@ffwll.ch, jani.nikula@intel.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH v3 1/3] arch: add the macro COMPILE_OFFSETS to all the asm-offsets.c Date: Thu, 21 Aug 2025 17:38:05 +0800 Message-ID: <20250821093807.49750-2-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821093807.49750-1-dongml2@chinatelecom.cn> References: <20250821093807.49750-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The include/generated/asm-offsets.h is generated in Kbuild during compiling from arch/SRCARCH/kernel/asm-offsets.c. When we want to generate another similar offset header file, circular dependency can happen. For example, we want to generate a offset file include/generated/test.h, which is included in include/sched/sched.h. If we generate asm-offsets.h first, it will fail, as include/sched/sched.h is included in asm-offsets.c and include/generated/test.h doesn't exist; If we generate test.h first, it can't success neither, as include/generated/asm-offsets.h is included by it. In x86_64, the macro COMPILE_OFFSETS is used to avoid such circular dependency. We can generate asm-offsets.h first, and if the COMPILE_OFFSETS is defined, we don't include the "generated/test.h". And we define the macro COMPILE_OFFSETS for all the asm-offsets.c for this purpose. Signed-off-by: Menglong Dong --- arch/alpha/kernel/asm-offsets.c | 1 + arch/arc/kernel/asm-offsets.c | 1 + arch/arm/kernel/asm-offsets.c | 2 ++ arch/arm64/kernel/asm-offsets.c | 1 + arch/csky/kernel/asm-offsets.c | 1 + arch/hexagon/kernel/asm-offsets.c | 1 + arch/loongarch/kernel/asm-offsets.c | 2 ++ arch/m68k/kernel/asm-offsets.c | 1 + arch/microblaze/kernel/asm-offsets.c | 1 + arch/mips/kernel/asm-offsets.c | 2 ++ arch/nios2/kernel/asm-offsets.c | 1 + arch/openrisc/kernel/asm-offsets.c | 1 + arch/parisc/kernel/asm-offsets.c | 1 + arch/powerpc/kernel/asm-offsets.c | 1 + arch/riscv/kernel/asm-offsets.c | 1 + arch/s390/kernel/asm-offsets.c | 1 + arch/sh/kernel/asm-offsets.c | 1 + arch/sparc/kernel/asm-offsets.c | 1 + arch/um/kernel/asm-offsets.c | 2 ++ arch/xtensa/kernel/asm-offsets.c | 1 + 20 files changed, 24 insertions(+) diff --git a/arch/alpha/kernel/asm-offsets.c b/arch/alpha/kernel/asm-offset= s.c index e9dad60b147f..1ebb05890499 100644 --- a/arch/alpha/kernel/asm-offsets.c +++ b/arch/alpha/kernel/asm-offsets.c @@ -4,6 +4,7 @@ * This code generates raw asm output which is post-processed to extract * and format the required data. */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/arc/kernel/asm-offsets.c b/arch/arc/kernel/asm-offsets.c index f77deb799175..2978da85fcb6 100644 --- a/arch/arc/kernel/asm-offsets.c +++ b/arch/arc/kernel/asm-offsets.c @@ -2,6 +2,7 @@ /* * Copyright (C) 2004, 2007-2010, 2011-2012 Synopsys, Inc. (www.synopsys.c= om) */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/arm/kernel/asm-offsets.c b/arch/arm/kernel/asm-offsets.c index 123f4a8ef446..2101938d27fc 100644 --- a/arch/arm/kernel/asm-offsets.c +++ b/arch/arm/kernel/asm-offsets.c @@ -7,6 +7,8 @@ * This code generates raw asm output which is post-processed to extract * and format the required data. */ +#define COMPILE_OFFSETS + #include #include #include diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offset= s.c index 30d4bbe68661..b6367ff3a49c 100644 --- a/arch/arm64/kernel/asm-offsets.c +++ b/arch/arm64/kernel/asm-offsets.c @@ -6,6 +6,7 @@ * 2001-2002 Keith Owens * Copyright (C) 2012 ARM Ltd. */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/csky/kernel/asm-offsets.c b/arch/csky/kernel/asm-offsets.c index d1e903579473..5525c8e7e1d9 100644 --- a/arch/csky/kernel/asm-offsets.c +++ b/arch/csky/kernel/asm-offsets.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/hexagon/kernel/asm-offsets.c b/arch/hexagon/kernel/asm-of= fsets.c index 03a7063f9456..50eea9fa6f13 100644 --- a/arch/hexagon/kernel/asm-offsets.c +++ b/arch/hexagon/kernel/asm-offsets.c @@ -8,6 +8,7 @@ * * Copyright (c) 2010-2012, The Linux Foundation. All rights reserved. */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/loongarch/kernel/asm-offsets.c b/arch/loongarch/kernel/as= m-offsets.c index db1e4bb26b6a..3017c7157600 100644 --- a/arch/loongarch/kernel/asm-offsets.c +++ b/arch/loongarch/kernel/asm-offsets.c @@ -4,6 +4,8 @@ * * Copyright (C) 2020-2022 Loongson Technology Corporation Limited */ +#define COMPILE_OFFSETS + #include #include #include diff --git a/arch/m68k/kernel/asm-offsets.c b/arch/m68k/kernel/asm-offsets.c index 906d73230537..67a1990f9d74 100644 --- a/arch/m68k/kernel/asm-offsets.c +++ b/arch/m68k/kernel/asm-offsets.c @@ -9,6 +9,7 @@ * #defines from the assembly-language output. */ =20 +#define COMPILE_OFFSETS #define ASM_OFFSETS_C =20 #include diff --git a/arch/microblaze/kernel/asm-offsets.c b/arch/microblaze/kernel/= asm-offsets.c index 104c3ac5f30c..b4b67d58e7f6 100644 --- a/arch/microblaze/kernel/asm-offsets.c +++ b/arch/microblaze/kernel/asm-offsets.c @@ -7,6 +7,7 @@ * License. See the file "COPYING" in the main directory of this archive * for more details. */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/mips/kernel/asm-offsets.c b/arch/mips/kernel/asm-offsets.c index 1e29efcba46e..5debd9a3854a 100644 --- a/arch/mips/kernel/asm-offsets.c +++ b/arch/mips/kernel/asm-offsets.c @@ -9,6 +9,8 @@ * Kevin Kissell, kevink@mips.com and Carsten Langgaard, carstenl@mips.com * Copyright (C) 2000 MIPS Technologies, Inc. */ +#define COMPILE_OFFSETS + #include #include #include diff --git a/arch/nios2/kernel/asm-offsets.c b/arch/nios2/kernel/asm-offset= s.c index e3d9b7b6fb48..88190b503ce5 100644 --- a/arch/nios2/kernel/asm-offsets.c +++ b/arch/nios2/kernel/asm-offsets.c @@ -2,6 +2,7 @@ /* * Copyright (C) 2011 Tobias Klauser */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/openrisc/kernel/asm-offsets.c b/arch/openrisc/kernel/asm-= offsets.c index 710651d5aaae..3cc826f2216b 100644 --- a/arch/openrisc/kernel/asm-offsets.c +++ b/arch/openrisc/kernel/asm-offsets.c @@ -18,6 +18,7 @@ * compile this file to assembler, and then extract the * #defines from the assembly-language output. */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/parisc/kernel/asm-offsets.c b/arch/parisc/kernel/asm-offs= ets.c index 757816a7bd4b..9abfe65492c6 100644 --- a/arch/parisc/kernel/asm-offsets.c +++ b/arch/parisc/kernel/asm-offsets.c @@ -13,6 +13,7 @@ * Copyright (C) 2002 Randolph Chung * Copyright (C) 2003 James Bottomley */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-of= fsets.c index b3048f6d3822..a4bc80b30410 100644 --- a/arch/powerpc/kernel/asm-offsets.c +++ b/arch/powerpc/kernel/asm-offsets.c @@ -8,6 +8,7 @@ * compile this file to assembler, and then extract the * #defines from the assembly-language output. */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/riscv/kernel/asm-offsets.c b/arch/riscv/kernel/asm-offset= s.c index 6e8c0d6feae9..7d42d3b8a32a 100644 --- a/arch/riscv/kernel/asm-offsets.c +++ b/arch/riscv/kernel/asm-offsets.c @@ -3,6 +3,7 @@ * Copyright (C) 2012 Regents of the University of California * Copyright (C) 2017 SiFive */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/s390/kernel/asm-offsets.c b/arch/s390/kernel/asm-offsets.c index 95ecad9c7d7d..a8915663e917 100644 --- a/arch/s390/kernel/asm-offsets.c +++ b/arch/s390/kernel/asm-offsets.c @@ -4,6 +4,7 @@ * This code generates raw asm output which is post-processed to extract * and format the required data. */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/sh/kernel/asm-offsets.c b/arch/sh/kernel/asm-offsets.c index a0322e832845..429b6a763146 100644 --- a/arch/sh/kernel/asm-offsets.c +++ b/arch/sh/kernel/asm-offsets.c @@ -8,6 +8,7 @@ * compile this file to assembler, and then extract the * #defines from the assembly-language output. */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/sparc/kernel/asm-offsets.c b/arch/sparc/kernel/asm-offset= s.c index 3d9b9855dce9..6e660bde48dd 100644 --- a/arch/sparc/kernel/asm-offsets.c +++ b/arch/sparc/kernel/asm-offsets.c @@ -10,6 +10,7 @@ * * On sparc, thread_info data is static and TI_XXX offsets are computed by= hand. */ +#define COMPILE_OFFSETS =20 #include #include diff --git a/arch/um/kernel/asm-offsets.c b/arch/um/kernel/asm-offsets.c index 1fb12235ab9c..a69873aa697f 100644 --- a/arch/um/kernel/asm-offsets.c +++ b/arch/um/kernel/asm-offsets.c @@ -1 +1,3 @@ +#define COMPILE_OFFSETS + #include diff --git a/arch/xtensa/kernel/asm-offsets.c b/arch/xtensa/kernel/asm-offs= ets.c index da38de20ae59..cfbced95e944 100644 --- a/arch/xtensa/kernel/asm-offsets.c +++ b/arch/xtensa/kernel/asm-offsets.c @@ -11,6 +11,7 @@ * * Chris Zankel */ +#define COMPILE_OFFSETS =20 #include #include --=20 2.50.1 From nobody Sat Oct 4 01:41:10 2025 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAFE62F28FD; Thu, 21 Aug 2025 09:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755769110; cv=none; b=hlz9Ug1aiHwsJkaFzwB4whkxUraXlGHfyfElFHVh3WPNagslCohkRDmgxm7g6uP2j0gqrtEHEag4k5Ft0wQi4WcZ+Pv3kRT54LR/Xp25EmiuVs8ARU8NTOHtmM+89MjIg+7qRuKuf4Tkxpx4k472qTe/B4ngPJmppPWWvURZkoE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755769110; c=relaxed/simple; bh=jK5dymyj55hiHpvgBZZ8z0X/9RjUBkzOLYoPvDIC2w4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IbXwqrSgEK6RIuRWuO2Eg8ZAOUp8HSEvIA7iyYlUntk/HHH/6w8mmbhhCxosWgrO9T4cXwl2DWt5ynrtghAqCCvgVfAeLnfWljPzPHbmzNqtkxbTEoqEonhBzpQMG+l+EQNvE78Iu8JMbd5DBXtdxW0uA9LgXutDySbZA4kQYrE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PgPGgx7N; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PgPGgx7N" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-24457f5b692so8298635ad.0; Thu, 21 Aug 2025 02:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755769108; x=1756373908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XmGrkGg7Imifx3s5HIBsV5ipuLOW5PNOIFjJsbhXigw=; b=PgPGgx7Nm7Oe1ZArLX1ojF5Vqx3py0I46rad65rc6dGRSoVsCER0Gp6C2wvs11XvNi 1FU8ght2TO1BhY9piz2bM5l96DmEapec6X+Pv/zs+nPvB4mw6KHGgaFiDnfS40N/gEKG kYbjUHQkAj5YsCM2uHes3d81boxJ7C1ra5aRJHIObai7RLy+8yjL1wymaHolapuEHu2t prG51Me180FuBnhcA4Q5LfgBW1CGa2yFbdWEALLxEyrftVSWB5oX728fnSoBHX7wSlP6 Q2fPBfZ0v2f8cD+DY/h+G1NY0yu1biJ5K5gwTteVD8ISIgryi8QIFPMQ2/53+DjEC/sN gSVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755769108; x=1756373908; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XmGrkGg7Imifx3s5HIBsV5ipuLOW5PNOIFjJsbhXigw=; b=P8nuacxtpa2pHgGWkfvxzM2B6c/J7Q5R5uLpLBEbWs6dYpZPvc3Q6lHsNsQsU+x606 /aFxGivkGXyCxzIyUgee9TbbHgEVLWyrKLGHBlpVr1gJnxMo/4m7ekB1CnOE6tP5wLlV z8aURAcPCXvzLle+rJed5dj7qlqdpC4JfxBmMbmffSqvjt8Hfu0FWKi8l2qx8MTAVSSX mWyJZY+AAfd0v2fL14iXUv5eqUGDbUFssv6ce2v0F5yr+MJVNGprQMdMcq4kwSYYkihM h7Vnj7bsWjgJeatT7BV0UEd/akfg61IcXDIic3VnLMC8OfZAvmmdgWCGqlRUeIYsNECS Vx0w== X-Forwarded-Encrypted: i=1; AJvYcCVAEZ4yfX0ROi8nd39HVq3UGncAG+jxjn0odA+Rbs0dy5H/w4EKw2qAOKeuIJwHXQP8uHm/1B5ax/iA0sHr@vger.kernel.org, AJvYcCVyW7MxFNoxkQgqrZMZLMSNwv4lbHUgaKjGugqn6AMRcSwMxZpMTGGY+x3On3mmRpdkfpI=@vger.kernel.org X-Gm-Message-State: AOJu0YyV5E52OKYCRX7U/rzih9imdPz/hFCqN9HePq5e0Q8981+RUe6B JNYmOVcZShFMOMGMxuyz9Y/FcvWpXgT6IBO+nnSAs0RJHBhFhmrPiNZo X-Gm-Gg: ASbGncs+fjTtn936JpVX6bpM8PL7rmhpBiRzsgY32sHpXU8gnaVJqGPYQSg34iUUN0g CDj3cRMA/1sbrqvAtic2k4R/9HF7x3uHJkSZJPE45Y4SYa4JzJuBweptKO4zhC43s0T0ko6Y6p/ vJ0WB8W7fW4p6BwHgRquRtBhXv2M7yUaAOwGbBJrB7JDWDkWTD1FAEvLOBkYQkh86jpC4bI0NZw nju6Nn3pCLpIf1DSsh6YNSgTbCW0Ihqk6oQlSCsdmYfDydrz//4FM0AcRp4BvZydi3lN330iFa1 EIRNzTC6M2JRlWauK3fI/WO9Iw0ie5OlbZAas6yBdJ9U+BHee6QpKODBlSM+XdqTkFpL0IkGJf1 GpuJRd2sxzKYEMGvY4UzCuAY= X-Google-Smtp-Source: AGHT+IGjFqc8W/vRwu7zAeJb+hA0JH7xTTFSX/hIvMlRCDxMstvxsEvJsnggV0TobfPzMcZnc3Gxng== X-Received: by 2002:a17:903:f90:b0:240:5c38:7544 with SMTP id d9443c01a7336-245fedbb9dfmr25709975ad.50.1755769107857; Thu, 21 Aug 2025 02:38:27 -0700 (PDT) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed540040sm49652085ad.163.2025.08.21.02.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 02:38:27 -0700 (PDT) From: Menglong Dong X-Google-Original-From: Menglong Dong To: peterz@infradead.org Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, tzimmermann@suse.de, simona.vetter@ffwll.ch, jani.nikula@intel.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH v3 2/3] sched: make migrate_enable/migrate_disable inline Date: Thu, 21 Aug 2025 17:38:06 +0800 Message-ID: <20250821093807.49750-3-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821093807.49750-1-dongml2@chinatelecom.cn> References: <20250821093807.49750-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable For now, migrate_enable and migrate_disable are global, which makes them become hotspots in some case. Take BPF for example, the function calling to migrate_enable and migrate_disable in BPF trampoline can introduce significant overhead, and following is the 'perf top' of FENTRY's benchmark (./tools/testing/selftests/bpf/bench trig-fentry): 54.63% bpf_prog_2dcccf652aac1793_bench_trigger_fentry [k] bpf_prog_2dcccf652aac1793_bench_trigger_fentry 10.43% [kernel] [k] migrate_enable 10.07% bpf_trampoline_6442517037 [k] bpf_trampoline_6442517037 8.06% [kernel] [k] __bpf_prog_exit_recur 4.11% libc.so.6 [.] syscall 2.15% [kernel] [k] entry_SYSCALL_64 1.48% [kernel] [k] memchr_inv 1.32% [kernel] [k] fput 1.16% [kernel] [k] _copy_to_user 0.73% [kernel] [k] bpf_prog_test_run_raw_tp So in this commit, we make migrate_enable/migrate_disable inline to obtain better performance. The struct rq is defined internally in kernel/sched/sched.h, and the field "nr_pinned" is accessed in migrate_enable/migrate_disable, which makes it hard to make them inline. Alexei Starovoitov suggests to generate the offset of "nr_pinned" in [1], so we can define the migrate_enable/migrate_disable in include/linux/sched.h and access "this_rq()->nr_pinned" with "(void *)this_rq() + RQ_nr_pinned". The offset of "nr_pinned" is generated in include/generated/rq-offsets.h by kernel/sched/rq-offsets.c. Generally speaking, we move the definition of migrate_enable and migrate_disable to include/linux/sched.h from kernel/sched/core.c. The calling to __set_cpus_allowed_ptr() is leaved in ___migrate_enable(). The "struct rq" is not available in include/linux/sched.h, so we can't access the "runqueues" with this_cpu_ptr(), as the compilation will fail in this_cpu_ptr() -> raw_cpu_ptr() -> __verify_pcpu_ptr(): typeof((ptr) + 0) So we introduce the this_rq_raw() and access the runqueues with arch_raw_cpu_ptr/PERCPU_PTR directly. The variable "runqueues" is not visible in the kernel modules, and export it is not a good idea. As Peter Zijlstra advised in [2], we define and export migrate_enable/migrate_disable in kernel/sched/core.c too, and use them for the modules. Before this patch, the performance of BPF FENTRY is: fentry : 113.030 =C2=B1 0.149M/s fentry : 112.501 =C2=B1 0.187M/s fentry : 112.828 =C2=B1 0.267M/s fentry : 115.287 =C2=B1 0.241M/s After this patch, the performance of BPF FENTRY increases to: fentry : 143.644 =C2=B1 0.670M/s fentry : 149.764 =C2=B1 0.362M/s fentry : 149.642 =C2=B1 0.156M/s fentry : 145.263 =C2=B1 0.221M/s Link: https://lore.kernel.org/bpf/CAADnVQ+5sEDKHdsJY5ZsfGDO_1SEhhQWHrt2SMBG= 5SYyQ+jt7w@mail.gmail.com/ [1] Link: https://lore.kernel.org/all/20250819123214.GH4067720@noisy.programmin= g.kicks-ass.net/ [2] Signed-off-by: Menglong Dong --- v3: - don't export runqueues, define migrate_enable and migrate_disable in kernel/sched/core.c and use them for kernel modules instead - define the macro this_rq_pinned() - add some comment for this_rq_raw() v2: - use PERCPU_PTR() for this_rq_raw() if !CONFIG_SMP --- Kbuild | 13 ++++- include/linux/preempt.h | 3 -- include/linux/sched.h | 106 ++++++++++++++++++++++++++++++++++++++ kernel/bpf/verifier.c | 1 + kernel/sched/core.c | 63 +++++----------------- kernel/sched/rq-offsets.c | 12 +++++ 6 files changed, 145 insertions(+), 53 deletions(-) create mode 100644 kernel/sched/rq-offsets.c diff --git a/Kbuild b/Kbuild index f327ca86990c..13324b4bbe23 100644 --- a/Kbuild +++ b/Kbuild @@ -34,13 +34,24 @@ arch/$(SRCARCH)/kernel/asm-offsets.s: $(timeconst-file)= $(bounds-file) $(offsets-file): arch/$(SRCARCH)/kernel/asm-offsets.s FORCE $(call filechk,offsets,__ASM_OFFSETS_H__) =20 +# Generate rq-offsets.h + +rq-offsets-file :=3D include/generated/rq-offsets.h + +targets +=3D kernel/sched/rq-offsets.s + +kernel/sched/rq-offsets.s: $(offsets-file) + +$(rq-offsets-file): kernel/sched/rq-offsets.s FORCE + $(call filechk,offsets,__RQ_OFFSETS_H__) + # Check for missing system calls =20 quiet_cmd_syscalls =3D CALL $< cmd_syscalls =3D $(CONFIG_SHELL) $< $(CC) $(c_flags) $(missing_sysca= lls_flags) =20 PHONY +=3D missing-syscalls -missing-syscalls: scripts/checksyscalls.sh $(offsets-file) +missing-syscalls: scripts/checksyscalls.sh $(rq-offsets-file) $(call cmd,syscalls) =20 # Check the manual modification of atomic headers diff --git a/include/linux/preempt.h b/include/linux/preempt.h index 1fad1c8a4c76..92237c319035 100644 --- a/include/linux/preempt.h +++ b/include/linux/preempt.h @@ -424,8 +424,6 @@ static inline void preempt_notifier_init(struct preempt= _notifier *notifier, * work-conserving schedulers. * */ -extern void migrate_disable(void); -extern void migrate_enable(void); =20 /** * preempt_disable_nested - Disable preemption inside a normally preempt d= isabled section @@ -471,7 +469,6 @@ static __always_inline void preempt_enable_nested(void) =20 DEFINE_LOCK_GUARD_0(preempt, preempt_disable(), preempt_enable()) DEFINE_LOCK_GUARD_0(preempt_notrace, preempt_disable_notrace(), preempt_en= able_notrace()) -DEFINE_LOCK_GUARD_0(migrate, migrate_disable(), migrate_enable()) =20 #ifdef CONFIG_PREEMPT_DYNAMIC =20 diff --git a/include/linux/sched.h b/include/linux/sched.h index f8188b833350..ae73fb70cc05 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -49,6 +49,9 @@ #include #include #include +#ifndef COMPILE_OFFSETS +#include +#endif =20 /* task_struct member predeclarations (sorted alphabetically): */ struct audit_context; @@ -2312,4 +2315,107 @@ static __always_inline void alloc_tag_restore(struc= t alloc_tag *tag, struct allo #define alloc_tag_restore(_tag, _old) do {} while (0) #endif =20 +#ifndef MODULE +#ifndef COMPILE_OFFSETS + +extern void ___migrate_enable(void); + +struct rq; +DECLARE_PER_CPU_SHARED_ALIGNED(struct rq, runqueues); + +/* The "struct rq" is not available here, so we can't access the + * "runqueues" with this_cpu_ptr(), as the compilation will fail in + * this_cpu_ptr() -> raw_cpu_ptr() -> __verify_pcpu_ptr(): + * typeof((ptr) + 0) + * + * So use arch_raw_cpu_ptr()/PERCPU_PTR() directly here. + */ +#ifdef CONFIG_SMP +#define this_rq_raw() arch_raw_cpu_ptr(&runqueues) +#else +#define this_rq_raw() PERCPU_PTR(&runqueues) +#endif +#define this_rq_pinned() (*(unsigned int *)((void *)this_rq_raw() + RQ_nr_= pinned)) + +static inline void __migrate_enable(void) +{ + struct task_struct *p =3D current; + +#ifdef CONFIG_DEBUG_PREEMPT + /* + * Check both overflow from migrate_disable() and superfluous + * migrate_enable(). + */ + if (WARN_ON_ONCE((s16)p->migration_disabled <=3D 0)) + return; +#endif + + if (p->migration_disabled > 1) { + p->migration_disabled--; + return; + } + + /* + * Ensure stop_task runs either before or after this, and that + * __set_cpus_allowed_ptr(SCA_MIGRATE_ENABLE) doesn't schedule(). + */ + guard(preempt)(); + if (unlikely(p->cpus_ptr !=3D &p->cpus_mask)) + ___migrate_enable(); + /* + * Mustn't clear migration_disabled() until cpus_ptr points back at the + * regular cpus_mask, otherwise things that race (eg. + * select_fallback_rq) get confused. + */ + barrier(); + p->migration_disabled =3D 0; + this_rq_pinned()--; +} + +static inline void __migrate_disable(void) +{ + struct task_struct *p =3D current; + + if (p->migration_disabled) { +#ifdef CONFIG_DEBUG_PREEMPT + /* + *Warn about overflow half-way through the range. + */ + WARN_ON_ONCE((s16)p->migration_disabled < 0); +#endif + p->migration_disabled++; + return; + } + + guard(preempt)(); + this_rq_pinned()++; + p->migration_disabled =3D 1; +} +#else /* !COMPILE_OFFSETS */ +static inline void __migrate_disable(void) { } +static inline void __migrate_enable(void) { } +#endif /* !COMPILE_OFFSETS */ + +#ifndef CREATE_MIGRATE_DISABLE +static inline void migrate_disable(void) +{ + __migrate_disable(); +} + +static inline void migrate_enable(void) +{ + __migrate_enable(); +} +#else /* CREATE_MIGRATE_DISABLE */ +extern void migrate_disable(void); +extern void migrate_enable(void); +#endif /* CREATE_MIGRATE_DISABLE */ + +#else /* MODULE */ +extern void migrate_disable(void); +extern void migrate_enable(void); +#endif /* MODULE */ + +DEFINE_LOCK_GUARD_0(migrate, migrate_disable(), migrate_enable()) + #endif diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index c4f69a9e9af6..de9078a9df3a 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -23855,6 +23855,7 @@ int bpf_check_attach_target(struct bpf_verifier_log= *log, BTF_SET_START(btf_id_deny) BTF_ID_UNUSED #ifdef CONFIG_SMP +BTF_ID(func, ___migrate_enable) BTF_ID(func, migrate_disable) BTF_ID(func, migrate_enable) #endif diff --git a/kernel/sched/core.c b/kernel/sched/core.c index be00629f0ba4..58164a69449d 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7,6 +7,8 @@ * Copyright (C) 1991-2002 Linus Torvalds * Copyright (C) 1998-2024 Ingo Molnar, Red Hat */ +#define CREATE_MIGRATE_DISABLE +#include #include #include #include @@ -2381,28 +2383,7 @@ static void migrate_disable_switch(struct rq *rq, st= ruct task_struct *p) __do_set_cpus_allowed(p, &ac); } =20 -void migrate_disable(void) -{ - struct task_struct *p =3D current; - - if (p->migration_disabled) { -#ifdef CONFIG_DEBUG_PREEMPT - /* - *Warn about overflow half-way through the range. - */ - WARN_ON_ONCE((s16)p->migration_disabled < 0); -#endif - p->migration_disabled++; - return; - } - - guard(preempt)(); - this_rq()->nr_pinned++; - p->migration_disabled =3D 1; -} -EXPORT_SYMBOL_GPL(migrate_disable); - -void migrate_enable(void) +void ___migrate_enable(void) { struct task_struct *p =3D current; struct affinity_context ac =3D { @@ -2410,35 +2391,19 @@ void migrate_enable(void) .flags =3D SCA_MIGRATE_ENABLE, }; =20 -#ifdef CONFIG_DEBUG_PREEMPT - /* - * Check both overflow from migrate_disable() and superfluous - * migrate_enable(). - */ - if (WARN_ON_ONCE((s16)p->migration_disabled <=3D 0)) - return; -#endif + __set_cpus_allowed_ptr(p, &ac); +} +EXPORT_SYMBOL_GPL(___migrate_enable); =20 - if (p->migration_disabled > 1) { - p->migration_disabled--; - return; - } +void migrate_disable(void) +{ + __migrate_disable(); +} +EXPORT_SYMBOL_GPL(migrate_disable); =20 - /* - * Ensure stop_task runs either before or after this, and that - * __set_cpus_allowed_ptr(SCA_MIGRATE_ENABLE) doesn't schedule(). - */ - guard(preempt)(); - if (p->cpus_ptr !=3D &p->cpus_mask) - __set_cpus_allowed_ptr(p, &ac); - /* - * Mustn't clear migration_disabled() until cpus_ptr points back at the - * regular cpus_mask, otherwise things that race (eg. - * select_fallback_rq) get confused. - */ - barrier(); - p->migration_disabled =3D 0; - this_rq()->nr_pinned--; +void migrate_enable(void) +{ + __migrate_enable(); } EXPORT_SYMBOL_GPL(migrate_enable); =20 diff --git a/kernel/sched/rq-offsets.c b/kernel/sched/rq-offsets.c new file mode 100644 index 000000000000..a23747bbe25b --- /dev/null +++ b/kernel/sched/rq-offsets.c @@ -0,0 +1,12 @@ +// SPDX-License-Identifier: GPL-2.0 +#define COMPILE_OFFSETS +#include +#include +#include "sched.h" + +int main(void) +{ + DEFINE(RQ_nr_pinned, offsetof(struct rq, nr_pinned)); + + return 0; +} --=20 2.50.1 From nobody Sat Oct 4 01:41:10 2025 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B369D2F4A14; Thu, 21 Aug 2025 09:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755769116; cv=none; b=mAu4L5jmqUwG840rvtz156aCkI8YakxjfWVgJnSXFiQ6QcF07WmOeWpIUtmmCsGZmBRkqGngkzcEv+pupGnRDw+2aXQ+YZIceami01eT3GcRQoZgO+SeHbf+9nwDn+GHZ5Wn7FB36DN0IJplaIhDlSC6ey8y1Pqm+eWObfKjQIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755769116; c=relaxed/simple; bh=kVXO32XWFGFryq+9u4jMGw/2BQMQgJzRVyV+Y/D478Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fTmQkq25fnPTU+QBN5QaJIs4wrGojXZtoSPCGNCD8+H93exbp1bp8yFY3iYTpTUn0chKtfg4UAE0TsoJEPOJ4+ZLmknsQrk1fAKqs7O2JKmP5E0DVgzGKMhaJrG2MMiZaDaRkFpXXdeLm4oSvShbDhlESof3/gWcgbDiJhLnVmE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IZDaSrq5; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IZDaSrq5" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-244581caca6so6379715ad.2; Thu, 21 Aug 2025 02:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755769114; x=1756373914; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z/lWdjE3fEvYN7U+VU8qdCr2mZquMa68Yf5oLPz/zjM=; b=IZDaSrq5FFVvx+rCVrIhJRPy+2ZkwD+o75EmZ+6hZeo8uHUFNOO5h3InsuSpmE0bLQ oxpGneq/V01b1b65sEfLdinpOwlO2N9kBkdoLFTZ5bFxPKDrdkAMSoDIhsI1H+pGaWdw AyGQmhnEQF70BSEX/+Ikf5dHJebJq+AD0H7aUeZ0t3Rk+AfOu60pQr9ppeBGj6rRwjhj qGh2dAUNVSD9cJHxqyL6rUsUeTUTnIItAHWMxtmKtmMAl2EswWOiGeF1J/UXSLcK4OKA vT31mID+hjmeSb1G6gwXA5pAxS5mYnBBP/IzI067C2xB+I/ugMvCWxV4rRybN8KxYrDv PZdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755769114; x=1756373914; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z/lWdjE3fEvYN7U+VU8qdCr2mZquMa68Yf5oLPz/zjM=; b=mlgRN7/GtofK/NqghkwjCT7v3+BS96IiSh4jmhlhTgIbsqO+hMbR5MNNNgNnEi+Nne ztvsOwRmVcJBjideNssfPThaOOo2AG0ggpIiWyhzhjw6BofGAO3J93cbno6YIIbuCZUs E02aEqEflBGGy2QH5WjsUe1axj1eALbshChW5cg2k02ZXw1x3DggUwsRfC0+W5zDrdQ+ XMonAd6JmWSSM2qzdk6X3WJVvBzYlmjmcOoPyvhCFk1Fxip0B4F9DQ1l9HtYASvZ78fU zn654FUloniMBOX6wU5n+RBGbR+p89PsczECmsEzlcRp2RHI8UN6fmBx1AoULrUuFh+h OppA== X-Forwarded-Encrypted: i=1; AJvYcCV4sCa+fWFIZSU/qixf1ZczR4HN8FAPpMxQ5YnKyV3hJGBlkBFaTCYe9tmTGWQujhkiQMg=@vger.kernel.org, AJvYcCVJeFP+zUUa9Xyw23cTvp8kvR0MICQO59xceGd2pg0yAsgDi4iuujwJJ79hVebAHaPCTctEVcBxRNMec4p+@vger.kernel.org X-Gm-Message-State: AOJu0Yxly9lLEIL9SHgLwwhHOVFvNOXCdAdqU0PBzaXSOBSENeyDVjqI 6Y1E63I6NhCjnqjsH6wlPTanbzk6ZCvdGpTzwEOxMagzrpG0eUXcFAGuWpwibFGi X-Gm-Gg: ASbGncsfvzzX1jRs+y0+DB0gKGfYi6/iacKBLN+CVlEVPetPe+KeD2jo6TfNlcbeaDc 2/u5eehqM6HW7ZdMNzeACJT3wHO6a9sVopl2CacDmkifYBfiUJLDKJ8MsEhd9pqC9zOrXJhw2u/ 7LAFgFfSr2LYdC485julXRByiF2Bfq/45QHl/iSQnUrCz2AtqnfGn40MyrLQvlT2Y3vAOdaaEa0 3MML01ptKxC3DnUGC/ebazFGiDrRWRRkLvfMgan2bsn1FJw6Vywk7GIqsww5U9b7GmmNKi/3UU1 kGyuTfCjaaYsczQmkmpp92N1RAuH/n8FCRV4rXIoMLva3W47euWH80pStplngrrR3ps3kcDP0Ke COEzLMoz38BGPcb25r4LKd74= X-Google-Smtp-Source: AGHT+IFg5WiwDVY+YqJgz3hCr/DxdpPlyKu+8s5WFfAqsg+aZ9RaMMCbOibd0/vf98BiHnos1oXBoQ== X-Received: by 2002:a17:902:f605:b0:246:570:2d9c with SMTP id d9443c01a7336-24605703291mr21256755ad.61.1755769113885; Thu, 21 Aug 2025 02:38:33 -0700 (PDT) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed540040sm49652085ad.163.2025.08.21.02.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 02:38:33 -0700 (PDT) From: Menglong Dong X-Google-Original-From: Menglong Dong To: peterz@infradead.org Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, tzimmermann@suse.de, simona.vetter@ffwll.ch, jani.nikula@intel.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH v3 3/3] sched: fix some typos in include/linux/preempt.h Date: Thu, 21 Aug 2025 17:38:07 +0800 Message-ID: <20250821093807.49750-4-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821093807.49750-1-dongml2@chinatelecom.cn> References: <20250821093807.49750-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are some typos in the comments of migrate in include/linux/preempt.h: elegible -> eligible it's -> its migirate_disable -> migrate_disable abritrary -> arbitrary Just fix them. Signed-off-by: Menglong Dong --- include/linux/preempt.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/preempt.h b/include/linux/preempt.h index 92237c319035..102202185d7a 100644 --- a/include/linux/preempt.h +++ b/include/linux/preempt.h @@ -372,7 +372,7 @@ static inline void preempt_notifier_init(struct preempt= _notifier *notifier, /* * Migrate-Disable and why it is undesired. * - * When a preempted task becomes elegible to run under the ideal model (IO= W it + * When a preempted task becomes eligible to run under the ideal model (IO= W it * becomes one of the M highest priority tasks), it might still have to wa= it * for the preemptee's migrate_disable() section to complete. Thereby suff= ering * a reduction in bandwidth in the exact duration of the migrate_disable() @@ -387,7 +387,7 @@ static inline void preempt_notifier_init(struct preempt= _notifier *notifier, * - a lower priority tasks; which under preempt_disable() could've instan= tly * migrated away when another CPU becomes available, is now constrained * by the ability to push the higher priority task away, which might its= elf be - * in a migrate_disable() section, reducing it's available bandwidth. + * in a migrate_disable() section, reducing its available bandwidth. * * IOW it trades latency / moves the interference term, but it stays in the * system, and as long as it remains unbounded, the system is not fully @@ -399,7 +399,7 @@ static inline void preempt_notifier_init(struct preempt= _notifier *notifier, * PREEMPT_RT breaks a number of assumptions traditionally held. By forcin= g a * number of primitives into becoming preemptible, they would also allow * migration. This turns out to break a bunch of per-cpu usage. To this en= d, - * all these primitives employ migirate_disable() to restore this implicit + * all these primitives employ migrate_disable() to restore this implicit * assumption. * * This is a 'temporary' work-around at best. The correct solution is gett= ing @@ -407,7 +407,7 @@ static inline void preempt_notifier_init(struct preempt= _notifier *notifier, * per-cpu locking or short preempt-disable regions. * * The end goal must be to get rid of migrate_disable(), alternatively we = need - * a schedulability theory that does not depend on abritrary migration. + * a schedulability theory that does not depend on arbitrary migration. * * * Notes on the implementation. --=20 2.50.1