From nobody Sat Oct 4 03:15:45 2025 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4453B1E515; Thu, 21 Aug 2025 03:45:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755747929; cv=none; b=QuL1rT8skbGOFNYYV8wdTKx7gCixQfds+QphX8GIKwNwJIy4Snz5Q2+oOkURXwUhPZSXCUsTIdQZx4aS81d3x6tKH7Fe5bfdTIBFJQlqPs61rXkeVQerSO/FiRNND7u1A3gB9asuEqisumr8Z1/cgAczTTjbey4xmr4GWDqKX3o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755747929; c=relaxed/simple; bh=v5s76WnsbuJ9cg6yUVZLfCAa/WCAVb7oOP2MvNqhpus=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OvhthIe+tCeILAJ9S+w/24xECtH6ilO7J9TMbum3HMrDDcr6gyFvOndL1fLsLH9Ud7AirmoSpeW5JQdYx2ijGyNxLfulRxiN2JOGoMp907fnEk+ozfJBDt/1iS9wwgimVOIX7pBBt25LByW8rVLRAwAy8z2AEssNAoMfHdwtmUE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fHst2UdP; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHst2UdP" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-244581caca6so4376085ad.2; Wed, 20 Aug 2025 20:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755747927; x=1756352727; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zLl3mzRnbVoD6mdEcJJgJVvFz4R0gVIec6mQrjfS8wk=; b=fHst2UdPU1LzRTvhGMjdMK2TI1T9Gik8xx6hmg2kjNgzLv75GCJByHGLK6ZHHLnEIx eU63H3ksMKe29wF1ininVmoIEs6mNCLk2vlXCVD8a70zuDmp54Uoq8OR3tITYQhs0Q6m 6ajBQgr8ohBwZpvKQtcxAA/6IRcwx3aaE80gzcDUgwwbsCqpVA8d9L6/WghMWl0VQnxG ooTitHgCYhsGsX+1k3KHkGyX0H0gYIaYpjgzR8DvoWLCUvITT2/B+xaNwuw3VZd5IT7Z hZtLk2C8WfEN3+cer0gyCcYY0QmaCVEHj3ecMzVlwx/u8H0AJfCrIBNzQb8377IiEn6M 2N4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755747927; x=1756352727; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zLl3mzRnbVoD6mdEcJJgJVvFz4R0gVIec6mQrjfS8wk=; b=BkASEYxPiMbe4Fn06zUO87DbtMWupGIJEOoXF5Xm04POI5dixp7X2/2zb65DUPo7yl t7NDM3ZmIWk9V6BogyA1RW/8SrXag3Z6F4yu6I91hHgZUMHb+/wlJJPnZm0b3N68s7Ow rn1BmaPw7/LF348L6oGy4MPQ3OEch16vhc2temUIzQvdNN8ZNvaz92HDHchPHQKlw/nq Zw/VTjoABEEesvzTIm47IqttXRrjYHEYx6zJru0yGaori5JIXu/uqiiPKgzwET41qwTu +hSHmWEn4u5kIfF3ivYb+M59QiRmFiEbnZ8D2WuLwwqeue5ZY9pwJRkAJHFKeYcu+nFn 6R8Q== X-Forwarded-Encrypted: i=1; AJvYcCXgraJaYbE1+2geEdc/x++tSp5txzO+3WzKBA5Sgq1qNKSr421g51qW6VSLCPykp0ApsUCptZFcq3aRlyM=@vger.kernel.org X-Gm-Message-State: AOJu0YwaEIU84Ep1D2QgtbAvVvPXrQKhZ1CSB4VL9FkHq2Rm+0wSGWQU l1CIbnDJ1TeDNk+Vu8XEXBjHw/XFS3uA3p3TDALYl+miMAYrgPSDhezv8oX1TQ== X-Gm-Gg: ASbGncsidv9Lekm47mbNo9DRtkXwt+tVljkFCzkq4oXFaq+K+xOIHXh0aEAr1LK9oJk cmrzwwqi0NfBTR1o6Q6mOVRQnjZLAYpizwiuz9rDF/akeoYSFuiAsNgra+p9FMJHH2Tsw2pqM7W 6JpHHq2U+lWqikwaRBYMvOw57oONBTTWy4wB81qDHTS2B6SJenhw8lcryhwaJBzBMceW6pCFbI0 PgNPo5g5/lX9NH6ZMNjVjJzfyscyHso3fdKPnm6mprooDL+rXrtNjY+xMsk328MppTbp2d0yJBn RSpifR+N9lNoxRIzx9a0jc6LxIGm2MxbtsmNX622BsodoV8U4sZSsBSPFHcDM7wO3zZYII/2ZuY oBC1YN2ZnIJ6eejw= X-Google-Smtp-Source: AGHT+IHfbRF9UmMgXD55WGYe26OOaOjjKzhbDId5APji1BWvZx5t24lfhxY9exDIj8cWfSc7gTpe2g== X-Received: by 2002:a17:903:2341:b0:240:719c:65a7 with SMTP id d9443c01a7336-245febe5c8fmr14825275ad.4.1755747927339; Wed, 20 Aug 2025 20:45:27 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:acc7::1f6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-324f2402c9asm504932a91.11.2025.08.20.20.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 20:45:26 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 1/3] dmaengine: mv_xor: use devm_platform_ioremap_resource Date: Wed, 20 Aug 2025 20:45:23 -0700 Message-ID: <20250821034525.642664-2-rosenp@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821034525.642664-1-rosenp@gmail.com> References: <20250821034525.642664-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplifies probe slightly by removing explicit struct resource pointers and platform_get_resource calls. Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 1fdcb0f5c9e7..d56fd130173b 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1309,7 +1309,6 @@ static int mv_xor_probe(struct platform_device *pdev) const struct mbus_dram_target_info *dram; struct mv_xor_device *xordev; struct mv_xor_platform_data *pdata =3D dev_get_platdata(&pdev->dev); - struct resource *res; unsigned int max_engines, max_channels; int i, ret; =20 @@ -1319,23 +1318,13 @@ static int mv_xor_probe(struct platform_device *pde= v) if (!xordev) return -ENOMEM; =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; + xordev->xor_base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(xordev->xor_base)) + return PTR_ERR(xordev->xor_base); =20 - xordev->xor_base =3D devm_ioremap(&pdev->dev, res->start, - resource_size(res)); - if (!xordev->xor_base) - return -EBUSY; - - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (!res) - return -ENODEV; - - xordev->xor_high_base =3D devm_ioremap(&pdev->dev, res->start, - resource_size(res)); - if (!xordev->xor_high_base) - return -EBUSY; + xordev->xor_high_base =3D devm_platform_ioremap_resource(pdev, 1); + if (IS_ERR(xordev->xor_high_base)) + return PTR_ERR(xordev->xor_high_base); =20 platform_set_drvdata(pdev, xordev); =20 --=20 2.50.1 From nobody Sat Oct 4 03:15:45 2025 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 495BE2E427A; Thu, 21 Aug 2025 03:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755747930; cv=none; b=GKHXqx9YhL4hRIdDQ/SwXWoRBk5aArJ2czbvOAtj35XsWTp9GVLAOhplGI18VrWnXQ/DSA7C0H+PV9s9e3PtMyft86d8qVgL6Dfi61twbvtAj4v8tcfFCxpvceK01t/0sqm43STCLYbzyuhkr6AZi62cWbOV3N567TCd0j0N/ek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755747930; c=relaxed/simple; bh=bSZ/6A9ca22KIdWF880fraUW1VKu75WPdtOWX65e+wQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VMqOjmhMMLxNk0FvJjwqBZ8hDkcGo9EMKj+fjdXSV9n/sZvAGIPTSkqd4ZfbtGbHitvk+NjyWi0/Kx65LgGNK57q5xg00YeWz2AwzC3jIVoh1yKfn4ZYoMM8cMiqLe1WZInSTyNRUFvUaqek/TnhdsdErCZ74KL3X5wIQvO5rg8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OOp9sIaz; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OOp9sIaz" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-76e2e88c6a6so532999b3a.1; Wed, 20 Aug 2025 20:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755747928; x=1756352728; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6AY1pxYngEaSnRiBwXk1Rg1ZCKUm8lNc//QGnhj66Ts=; b=OOp9sIazPTUdvddC4ClzdcBSvtV/rwk4+LIwSbdtEhJ923hn7kBJdFXb5eXFbJaoCZ vkGJpkGXv99z6vCBguvAFS4q5kSPUzxYnwPu34gB6H1veMJsr41qKZriwAOynHth0ofv QMEyv/SHlnD3YPVwJwbObt2fWj/ss5ehCfW6mA+opoC07G3ZSYvuszq/WjsD8Cxvof1q xFz0H9Yvq8ipTL0BO82iOtUr6sDqDSYYs+4YrtABTahnjrKdgwNnw+IHhoZZ9EZbtak/ LrbVVTInSXdJGBs30u47G+uQTkm0plwuwc8IQsVZo9DkJRxeUYdkQ4HpjUYiDF6bW+Dx cx0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755747928; x=1756352728; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6AY1pxYngEaSnRiBwXk1Rg1ZCKUm8lNc//QGnhj66Ts=; b=FG1qsM0omiG1/cFsrVqs0eSIZrV/yT4a4WljqQOp5iqvDRVN2oUwaZ5R18y8t9AfGv 02GgXTK+ptknD61mYzlDH2CPStlrG4HVw8gdLKQvD/thTfmVMMvlyASgCEVGYVHOAbXB sKOb9yu5H8l+zUCYWgyEPizkZIMiVmR0kthJPgGo+/k61KVc/S1JQnQUSShKCB0TvZkW Z7QUMPwO/fyHzLeqInOItuGTfr8rU08UXbcWTdBJo8clxACSRBJeM1e1Oy7YNLwFcGIh V22aFsR9bQ6eBzEb9Ieel2wlqfCAZ5Z9KLozxjAw70UaLid89R/+LYbLdGlQ5gZ7DEnL uvJA== X-Forwarded-Encrypted: i=1; AJvYcCWUNPyZHSW/6h+I0+cPGYw9DhHA+KfoudUlH25NiePa/7/WRMW/QGQ/RwXlwhWfPzpMRlVoIZ71YBrXdcU=@vger.kernel.org X-Gm-Message-State: AOJu0YzM7QZUVmECk29XT88cXDEPOJgOJYzsuJVo/OeNfM5bItfCvCFz MM8B7mEpU+L4KnAiX7vqegu9qJQ5hkGX/uIjdkkoKN6ccrBlj3pENneRaimy8A== X-Gm-Gg: ASbGncs0ssju3RJ40lzHODfulpWbGoeb3TSogQi4bMeuRB4GDNd3/raAV+f/Wcp99BC mPhCkgnaYIcqLLvyjGBj6LKSBb4VapL45NH6Nu233WN8bBZ/4n96YgEGRL1q1CtiBElgnykwC6q j1K3kg+kE6dZKrpLNIo1M8Dlv4gBwxy7qUI/cOzHNYHVC4Dq5AGDcCdc5mwIgbNcSHK2Y0T0rgp p8MU4quCfeNSmFk3w0SsCesz2dls3L6GbpeRGIRYKC5GMuHM//WWuEORY8Ci5W/eQztIeho4bP6 3XVwUpHNnVycCdS+YCNZMDpBbZmYwA9ZM16XDg8H+zyWbdaISfcgKBcp/vKNESKPvf5pHPs/qb0 tSDnX X-Google-Smtp-Source: AGHT+IFKgIzh1zLe2D4revW/YG3riHbKMNnktZ6vhnEoDL0LTZJuxxm2guN2TwQfNTffUvaV3NlN9w== X-Received: by 2002:a05:6a20:3942:b0:240:30c:274a with SMTP id adf61e73a8af0-243307c1df3mr1330784637.18.1755747928377; Wed, 20 Aug 2025 20:45:28 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:acc7::1f6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-324f2402c9asm504932a91.11.2025.08.20.20.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 20:45:27 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 2/3] dmaengine: mv_xor: use devm_clk_get_optional_enabled Date: Wed, 20 Aug 2025 20:45:24 -0700 Message-ID: <20250821034525.642664-3-rosenp@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821034525.642664-1-rosenp@gmail.com> References: <20250821034525.642664-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver was written before this was available. Simplifies code slightly. Actually also a bugfix. clk_disable_unprepare is missing in _remove, which is also missing. Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index d56fd130173b..8f0c3bfc60cb 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1351,9 +1351,7 @@ static int mv_xor_probe(struct platform_device *pdev) /* Not all platforms can gate the clock, so it is not * an error if the clock does not exists. */ - xordev->clk =3D clk_get(&pdev->dev, NULL); - if (!IS_ERR(xordev->clk)) - clk_prepare_enable(xordev->clk); + xordev->clk =3D devm_clk_get_optional_enabled(&pdev->dev, NULL); =20 /* * We don't want to have more than one channel per CPU in @@ -1441,11 +1439,6 @@ static int mv_xor_probe(struct platform_device *pdev) irq_dispose_mapping(xordev->channels[i]->irq); } =20 - if (!IS_ERR(xordev->clk)) { - clk_disable_unprepare(xordev->clk); - clk_put(xordev->clk); - } - return ret; } =20 --=20 2.50.1 From nobody Sat Oct 4 03:15:45 2025 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B6AF2E7F11; Thu, 21 Aug 2025 03:45:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755747931; cv=none; b=hKzPfBLKKtXEkoXzLwN0dmeQmdVeFFs9l5Jl93ZkArugY+eiylj5biONE/3YcnUvaVkWLdFSUeGMnCjbjU68vBqIHYaDrOlp5YKzu6rIjC3CtO88OJXHMJFQQ2EENjwfMrzqQD/d3qKgvDkCLXlbx+XFQA2VJN40gvAO2ah+Xm0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755747931; c=relaxed/simple; bh=duHJrcuN+a6VGbHHRUXM6AyyXv7mjDeSL3MEGJah8SU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YqDVZcprFzUCMsn9NJQc0+EZ/4kmZWjjvRLpnU8UcidQgzNb6jGFHWvxgwAK+BhWKRcJZEy2VTl8PUcCWiQ42id6ztZnFf78iKxjRir+NpUuGCCBnyN21DHknzZaTXVruldCRsPUYdHRq/3pzSzL2SY8YNL7hSiLb+kJuAYe8u8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=neGSrA/P; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="neGSrA/P" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-323267bc2eeso495837a91.1; Wed, 20 Aug 2025 20:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755747929; x=1756352729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=crrUsFCfq3k63xR/frZMkp0dE+IOgUMhJSDZs9vTaEM=; b=neGSrA/PATE+pnnl/y7b8YnjW7f5v/BC7wicIxyGDkK4gb2Al13yeB//n4VHqSDSHd Bqg4Fl4VjKmXksjew/yoamnmCVyLc7IsGWtQHYRhAeyj3Vasc2yC4p7JKwq3RhSno+Yz SXqmNZk6c7Hf3O8PtqopQrk6Nefdtobj8wOYzm34sh8t2ChFzSWQteDxjliiRglQpSLl Zv1CVh98so/V6Xs6sz9yE9NRcGoSYrV8BAXrVFDWlyH6/8NhV+blwQZaB+O+iS1KVmx/ Dg9dMcNdNZmrYwBtvyeJa7uwwsHX4H2BX9M4goDemMvvqgCwCBf2ks10QHv0RWcOzPXr 9WzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755747929; x=1756352729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=crrUsFCfq3k63xR/frZMkp0dE+IOgUMhJSDZs9vTaEM=; b=JyTfUAqY0UM492gM+djASpHxR3uFyfwAUplnvM1NvtYzyJxqBgnqJwnPcpk3ypfB3P LpAFLrGyeQ/DKGEnoyjgEdsVIc29q1Qm8acY2XAlK9NAi8Cq0kXYJnp9nLyU4gaQEjpG CSW4Zx6rtgbG4QHD8rWFkVN1f3hv+PvGWJElkEacrAeEaBKwGd+HLsloKouSeRq1Hdnv K3MjFNu+Ld8b2JHk1OOvM+/6X+uF8SGdBhn4upGxErujO5OzQVJtnNiKdWuaO83khNSf WKRL57Ne60wCTwMEYnPgUfQb7/1Wmi5G/ae2GWDZJPeQss9THp2KTHWMUUDcYtZweDC3 Pn/Q== X-Forwarded-Encrypted: i=1; AJvYcCV7AzCZ7OPSeBJf1b0FwIdCOt3ywAn9Ke8K8Yn6zKaZHi/sRrAs/NhmqQc+FNaBJKgHTvR2g8a/mOhIA5Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwSo9KKxPXb3lrOwCZ3p4QYRY71mpWI8GqfQ0tn3oG8Tk/ZRtAk HWq4FnTFAQy09mIZZB4zqSN3eYnsiscnnp+HSOGb8Dqfrx1bOQyG+CSOFStamA== X-Gm-Gg: ASbGncu+GWpq3LLcEbL0/yTOZFDmt+EtA02Hem5MPxHzwB4OdhkZuVDpLgOB0u5N1Rj P0Jf7YGw+LmgXg2MQMxp+1BJrmluBGoMyf1eslbS+isjEj01dUY1HEpPz4MXtDSRCFiBeesm15I iqvUifRqE/MfNoP4ZOTf0LMApJJFnR464wSdVjzvMQquNDpTxW2BAP6c7DtgfCYfVH4WjYOquds S2wtIoSQ0HNk2+ilAUYiF0V2YazwxAaevEPrk4/1KDyq79Tpfb29Fq0VbDR3Nxl/sBUq++1BuQF lBuwfq8VmlykrV2CVUz9IdpqQsg7ZWJNZ1GBo7pv2a4MstZTP/rcloK/id6DX2e5yOC4WgaUM4Q J5Esb X-Google-Smtp-Source: AGHT+IHsDt928GDuTpULjuqdN4JrTIOvzBlZyIvUuOn1oUNZJCHPP0ghkkaFnemIKVtwYzrvotnhEg== X-Received: by 2002:a17:90b:3d08:b0:321:c37e:e325 with SMTP id 98e67ed59e1d1-324ed0f1999mr1656032a91.12.1755747929361; Wed, 20 Aug 2025 20:45:29 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:acc7::1f6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-324f2402c9asm504932a91.11.2025.08.20.20.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 20:45:28 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 3/3] dmaengine: mv_xor: use devm for request_irq Date: Wed, 20 Aug 2025 20:45:25 -0700 Message-ID: <20250821034525.642664-4-rosenp@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821034525.642664-1-rosenp@gmail.com> References: <20250821034525.642664-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is only called in _probe. Removes the need to manually free_irq. Same with irq_dispose_mapping. Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 8f0c3bfc60cb..18ddbff38abc 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1025,8 +1025,6 @@ static int mv_xor_channel_remove(struct mv_xor_chan *= mv_chan) list_del(&chan->device_node); } =20 - free_irq(mv_chan->irq, mv_chan); - return 0; } =20 @@ -1112,8 +1110,9 @@ mv_xor_channel_add(struct mv_xor_device *xordev, /* clear errors before enabling interrupts */ mv_chan_clear_err_status(mv_chan); =20 - ret =3D request_irq(mv_chan->irq, mv_xor_interrupt_handler, - 0, dev_name(&pdev->dev), mv_chan); + ret =3D devm_request_irq(&pdev->dev, mv_chan->irq, + mv_xor_interrupt_handler, 0, + dev_name(&pdev->dev), mv_chan); if (ret) goto err_free_dma; =20 @@ -1138,14 +1137,14 @@ mv_xor_channel_add(struct mv_xor_device *xordev, ret =3D mv_chan_memcpy_self_test(mv_chan); dev_dbg(&pdev->dev, "memcpy self test returned %d\n", ret); if (ret) - goto err_free_irq; + goto err_free_dma; } =20 if (dma_has_cap(DMA_XOR, dma_dev->cap_mask)) { ret =3D mv_chan_xor_self_test(mv_chan); dev_dbg(&pdev->dev, "xor self test returned %d\n", ret); if (ret) - goto err_free_irq; + goto err_free_dma; } =20 dev_info(&pdev->dev, "Marvell XOR (%s): ( %s%s%s)\n", @@ -1156,12 +1155,10 @@ mv_xor_channel_add(struct mv_xor_device *xordev, =20 ret =3D dma_async_device_register(dma_dev); if (ret) - goto err_free_irq; + goto err_free_dma; =20 return mv_chan; =20 -err_free_irq: - free_irq(mv_chan->irq, mv_chan); err_free_dma: dma_free_coherent(&pdev->dev, MV_XOR_POOL_SIZE, mv_chan->dma_desc_pool_virt, mv_chan->dma_desc_pool); @@ -1398,7 +1395,6 @@ static int mv_xor_probe(struct platform_device *pdev) cap_mask, irq); if (IS_ERR(chan)) { ret =3D PTR_ERR(chan); - irq_dispose_mapping(irq); goto err_channel_add; } =20 @@ -1433,11 +1429,8 @@ static int mv_xor_probe(struct platform_device *pdev) =20 err_channel_add: for (i =3D 0; i < MV_XOR_MAX_CHANNELS; i++) - if (xordev->channels[i]) { + if (xordev->channels[i]) mv_xor_channel_remove(xordev->channels[i]); - if (pdev->dev.of_node) - irq_dispose_mapping(xordev->channels[i]->irq); - } =20 return ret; } --=20 2.50.1