From nobody Sat Oct 4 03:18:37 2025 Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60A6246447 for ; Thu, 21 Aug 2025 00:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.150 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755736227; cv=none; b=FDujp16KqKthF2ZhIaiHLxFZ6lI5HMlKt6RT3zVZvHZZzmF/GZoqz0Io8GIJI/Nj4EFan1CZYwW5ej7W6X48MvOmzRIiuA2bzTnGMr1jmtsTPVuc9mpcOtEI7YxsR5Cs948KhjDuzgs14HddTa8so+DT5P5WteaYhSDSJo5J1Lg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755736227; c=relaxed/simple; bh=nsWmaCHgXjoyO3s7DHSgGWeJKpmrr1gkOMqUOatFJ4E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tLqy1lPMNFvhdvQAgPTJeizu4AoYnPqOLEdkQwTuSfwgXDa8Uu2zm7ws1V0S6TVGGWUSRrg70oCjBLiGp5dOWGUklwLGHXlraW981dFiq8JCL1ha/rVj1Jx+Mwpw8eXOZNQrbNZlD298gE7bRpbvqjUlCXy39UnS847HXhK341Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=PgGioA74; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Sj0OllW5; arc=none smtp.client-ip=103.168.172.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="PgGioA74"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Sj0OllW5" Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id 5F9DDEC012D; Wed, 20 Aug 2025 20:30:23 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Wed, 20 Aug 2025 20:30:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1755736223; x= 1755822623; bh=q8zu4VWXyIevjukySC25gkI6lGHvLvrvS0El5rB82bQ=; b=P gGioA746gOHDK6lr7f9AxhREk2c0WjEBv2uVmfoX3ytkRxeQ4IcqNz+57DvXJjlE ucIiNOHLt+vBWvXvLxdc4ImtnHPS/rSuFsz9nmheGEDnfHPnHSEizP4kn8ElarCf uvsKUZ3lgRFVVD/En/ZwV8Xgb5h2qRzWQ23R3Vn5Xgwva190rWGeRcAN/muc0LvH kIa/iQe+zDbFHfs+9k2TAJE/CgzqtQosWQ4Ihvfb09kxAl9l4FoJfQE2EpyG6i85 7tR3Uvdx2dB4v7sNiWmTZalkEdqbfcNIT7NTXp+xDEMIQsH5nI59raoPqNSXayDH brQSFlztfmayazfqnhQBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1755736223; x=1755822623; bh=q 8zu4VWXyIevjukySC25gkI6lGHvLvrvS0El5rB82bQ=; b=Sj0OllW5zy9N6GScC 2QUxt9BQy60pk5+aCSHpn21QTJKbDftSk1YxZmcmTiPbDU1PS7jPRm67LL4Ff9od 4fZj+ExdHrII6zKY/qhnlYu3Mk59epXsHes3Tc1S6Sr9p7bXmj04Mx/4u+BoaqJ7 AaO4fV5yAIvA/yDEpChy+cwFagj1XME8nYTdedgqCMCbY3DbuHahR0OFir7LsnDc X821dkIOBmx1bmjtuRwwUZOCNEeQdT6kexFzc3rqXyPmmLKqRFA405WiUGl/sFQP /RVuZRKTZkknvGEplRpKHxmAFI2LBDDs+dZMK0cu9PernNEaiCunwQKG6MPoKP50 DFdPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduheelkedtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertd ertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpedvjefgjeeuvd fguddukeelveetgfdtvefhtdfffeeigfevueetffeivdffkedvtdenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrg hkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlsehlihhsthhsrdhsohhurh gtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgv rhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Aug 2025 20:30:22 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 1/4] firewire: ohci: remove obsolete debug logging for IRQ events Date: Thu, 21 Aug 2025 09:30:14 +0900 Message-ID: <20250821003017.186752-2-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250821003017.186752-1-o-takashi@sakamocchi.jp> References: <20250821003017.186752-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A commit 0d8914165dd1 ("firewire: ohci: add tracepoints event for hardIRQ event") added "firewire_ohci:irqs" event in v6.11, which can provide equivalent information to the existing debug logging. This commit removes the logging. Signed-off-by: Takashi Sakamoto --- drivers/firewire/ohci.c | 34 +--------------------------------- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index 5d8301b0f3aa..d3ed43f4d0c3 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -395,50 +395,18 @@ MODULE_PARM_DESC(quirks, "Chip quirks (default =3D 0" =20 #define OHCI_PARAM_DEBUG_AT_AR 1 #define OHCI_PARAM_DEBUG_SELFIDS 2 -#define OHCI_PARAM_DEBUG_IRQS 4 =20 static int param_debug; module_param_named(debug, param_debug, int, 0644); MODULE_PARM_DESC(debug, "Verbose logging, deprecated in v6.11 kernel or la= ter. (default =3D 0" ", AT/AR events =3D " __stringify(OHCI_PARAM_DEBUG_AT_AR) ", self-IDs =3D " __stringify(OHCI_PARAM_DEBUG_SELFIDS) - ", IRQs =3D " __stringify(OHCI_PARAM_DEBUG_IRQS) ", or a combination, or all =3D -1)"); =20 static bool param_remote_dma; module_param_named(remote_dma, param_remote_dma, bool, 0444); MODULE_PARM_DESC(remote_dma, "Enable unfiltered remote DMA (default =3D N)= "); =20 -static void log_irqs(struct fw_ohci *ohci, u32 evt) -{ - if (likely(!(param_debug & OHCI_PARAM_DEBUG_IRQS))) - return; - - ohci_notice(ohci, "IRQ %08x%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s\n", evt, - evt & OHCI1394_selfIDComplete ? " selfID" : "", - evt & OHCI1394_RQPkt ? " AR_req" : "", - evt & OHCI1394_RSPkt ? " AR_resp" : "", - evt & OHCI1394_reqTxComplete ? " AT_req" : "", - evt & OHCI1394_respTxComplete ? " AT_resp" : "", - evt & OHCI1394_isochRx ? " IR" : "", - evt & OHCI1394_isochTx ? " IT" : "", - evt & OHCI1394_postedWriteErr ? " postedWriteErr" : "", - evt & OHCI1394_cycleTooLong ? " cycleTooLong" : "", - evt & OHCI1394_cycle64Seconds ? " cycle64Seconds" : "", - evt & OHCI1394_cycleInconsistent ? " cycleInconsistent" : "", - evt & OHCI1394_regAccessFail ? " regAccessFail" : "", - evt & OHCI1394_unrecoverableError ? " unrecoverableError" : "", - evt & OHCI1394_busReset ? " busReset" : "", - evt & ~(OHCI1394_selfIDComplete | OHCI1394_RQPkt | - OHCI1394_RSPkt | OHCI1394_reqTxComplete | - OHCI1394_respTxComplete | OHCI1394_isochRx | - OHCI1394_isochTx | OHCI1394_postedWriteErr | - OHCI1394_cycleTooLong | OHCI1394_cycle64Seconds | - OHCI1394_cycleInconsistent | - OHCI1394_regAccessFail | OHCI1394_busReset) - ? " ?" : ""); -} - static void log_selfids(struct fw_ohci *ohci, int generation, int self_id_= count) { static const char *const speed[] =3D { @@ -2226,7 +2194,7 @@ static irqreturn_t irq_handler(int irq, void *data) reg_write(ohci, OHCI1394_IntEventClear, event & ~(OHCI1394_busReset | OHCI1394_postedWriteErr)); trace_irqs(ohci->card.index, event); - log_irqs(ohci, event); + // The flag is masked again at bus_reset_work() scheduled by selfID event. if (event & OHCI1394_busReset) reg_write(ohci, OHCI1394_IntMaskClear, OHCI1394_busReset); --=20 2.48.1 From nobody Sat Oct 4 03:18:37 2025 Received: from fhigh-a6-smtp.messagingengine.com (fhigh-a6-smtp.messagingengine.com [103.168.172.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 990BB48CFC for ; Thu, 21 Aug 2025 00:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755736227; cv=none; b=KJvRleIb1LpzwcRBOzPczGUzfXKlJop8BANzEF+JSyIVJcJkD4rSK7HixUsrWVf3oiJw1jWpRCtmc/Drb86p9XIY33HYU/P04ROAyiPk7pPjNTk3dZ3pmp5bKhT+R8YqgYgwMs/oSsF2EF2Z6VeSNjSRo8x6TGprS4M2FA3QX+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755736227; c=relaxed/simple; bh=Jjb+/I/riqTI++d23gGdifrki43WM2j+z0kj5MRMPgw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K70lRwtxVieOpkhRH7U7y+7LObIX8gVJnikcyBGQfYmiZSQrV0v9RWGWr23NRDdgNA7OQT4ZWZdWcxZDEJCVbV/zGpeq615E4D0zvrBiKX86NJqgEum0bs7HVgMox/azIUef7QWPDi/EHg6hJ8HjdywH2yH6tK9aZD9gjoI/B/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=q2D3eIPI; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Kchenfq+; arc=none smtp.client-ip=103.168.172.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="q2D3eIPI"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Kchenfq+" Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id C451F14000B7; Wed, 20 Aug 2025 20:30:24 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Wed, 20 Aug 2025 20:30:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1755736224; x= 1755822624; bh=MJhbiDHxyLrwI3F474o+zyXCEkS3G232mRdv3WRIJMk=; b=q 2D3eIPIvlLHx34rzFZKsBk5A09NOgI4vF6vgLTE4jcb7fI0cGLtNprkNdpZomdtR oN+RXbaOFecv6Cg/cIf9ZU3EEQtRtRAVum/7YHCN+qJFvI24CYwJTx7rExcARzx+ 9HNr+2IJ8/SB/C5RvpUXoKwsppwfa508Z1KDek2nxv4eDZ6oqhaUIVA43xfleTJp zLyI+N+uwK0azfg0M0lJRM7T/15+515jRV+SLmzsScNI/0nAPBNUqP9N00NqSTe6 yfxDYWRlqm7QXlQOUuLkHF9hW6aaPUNx+duMtzZ49A5aAqWfowWkOitfOAY+OFif BaWT5OvNd3FQwNbqnAlyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1755736224; x=1755822624; bh=M JhbiDHxyLrwI3F474o+zyXCEkS3G232mRdv3WRIJMk=; b=Kchenfq+JPrn/393P Ee/3nP1BrOjKwIO3BU1bf0gr+ZajN2gWjQuhk4n8KhZYeFeSmJ9bRHt/WgnZSSYr lDA48v79T3TCPUYC0iGUAmnY/SaNkdv8PV4MAqUF7FXJ88Ff8lxhbpALyYT2wFx7 LDyaK72WUbuENW65geuvBkr7Xx3c4K4esUWQK1a9rvIUS0UVLUNsioZH522AMEAm YPoVnCuvbo5kOU+NMdqU0nVvIsG43KH/E7eYxfSPCIUYQlk96f5l4wYkS57lcnyW Q3v70DqK9ag3022nX6mCjVswoPNZFPbZYKkIM2uG9XzgwmWebZ2LorHh5E8tUGaI MmTAw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduheelkeduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertd ertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpedvjefgjeeuvd fguddukeelveetgfdtvefhtdfffeeigfevueetffeivdffkedvtdenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrg hkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlsehlihhsthhsrdhsohhurh gtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgv rhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Aug 2025 20:30:23 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/4] firewire: ohci: remove obsolete debug logging for selfID sequence Date: Thu, 21 Aug 2025 09:30:15 +0900 Message-ID: <20250821003017.186752-3-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250821003017.186752-1-o-takashi@sakamocchi.jp> References: <20250821003017.186752-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A commit 677ceae19073 ("firewire: core: add tracepoints event for self_id_sequence") added the "firewire:self_id_sequence" event in v6.11. A commit 526e21a2aa6f ("firewire: ohci: add tracepoints event for data of Self-ID DMA") added the "firewire_ohci:self_id_complete" event in v6.12. These tracepoints replace the equivalent debug logging. This commit removes the logging. Signed-off-by: Takashi Sakamoto --- drivers/firewire/ohci.c | 72 ----------------------------------------- 1 file changed, 72 deletions(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index d3ed43f4d0c3..8cecdf4c6572 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -394,87 +394,17 @@ MODULE_PARM_DESC(quirks, "Chip quirks (default =3D 0" ")"); =20 #define OHCI_PARAM_DEBUG_AT_AR 1 -#define OHCI_PARAM_DEBUG_SELFIDS 2 =20 static int param_debug; module_param_named(debug, param_debug, int, 0644); MODULE_PARM_DESC(debug, "Verbose logging, deprecated in v6.11 kernel or la= ter. (default =3D 0" ", AT/AR events =3D " __stringify(OHCI_PARAM_DEBUG_AT_AR) - ", self-IDs =3D " __stringify(OHCI_PARAM_DEBUG_SELFIDS) ", or a combination, or all =3D -1)"); =20 static bool param_remote_dma; module_param_named(remote_dma, param_remote_dma, bool, 0444); MODULE_PARM_DESC(remote_dma, "Enable unfiltered remote DMA (default =3D N)= "); =20 -static void log_selfids(struct fw_ohci *ohci, int generation, int self_id_= count) -{ - static const char *const speed[] =3D { - [0] =3D "S100", [1] =3D "S200", [2] =3D "S400", [3] =3D "beta", - }; - static const char *const power[] =3D { - [0] =3D "+0W", [1] =3D "+15W", [2] =3D "+30W", [3] =3D "+45W", - [4] =3D "-3W", [5] =3D " ?W", [6] =3D "-3..-6W", [7] =3D "-3..-10W", - }; - static const char port[] =3D { - [PHY_PACKET_SELF_ID_PORT_STATUS_NONE] =3D '.', - [PHY_PACKET_SELF_ID_PORT_STATUS_NCONN] =3D '-', - [PHY_PACKET_SELF_ID_PORT_STATUS_PARENT] =3D 'p', - [PHY_PACKET_SELF_ID_PORT_STATUS_CHILD] =3D 'c', - }; - struct self_id_sequence_enumerator enumerator =3D { - .cursor =3D ohci->self_id_buffer, - .quadlet_count =3D self_id_count, - }; - - if (likely(!(param_debug & OHCI_PARAM_DEBUG_SELFIDS))) - return; - - ohci_notice(ohci, "%d selfIDs, generation %d, local node ID %04x\n", - self_id_count, generation, ohci->node_id); - - while (enumerator.quadlet_count > 0) { - unsigned int quadlet_count; - unsigned int port_index; - const u32 *s; - int i; - - s =3D self_id_sequence_enumerator_next(&enumerator, &quadlet_count); - if (IS_ERR(s)) - break; - - ohci_notice(ohci, - "selfID 0: %08x, phy %d [%c%c%c] %s gc=3D%d %s %s%s%s\n", - *s, - phy_packet_self_id_get_phy_id(*s), - port[self_id_sequence_get_port_status(s, quadlet_count, 0)], - port[self_id_sequence_get_port_status(s, quadlet_count, 1)], - port[self_id_sequence_get_port_status(s, quadlet_count, 2)], - speed[*s >> 14 & 3], *s >> 16 & 63, - power[*s >> 8 & 7], *s >> 22 & 1 ? "L" : "", - *s >> 11 & 1 ? "c" : "", *s & 2 ? "i" : ""); - - port_index =3D 3; - for (i =3D 1; i < quadlet_count; ++i) { - ohci_notice(ohci, - "selfID n: %08x, phy %d [%c%c%c%c%c%c%c%c]\n", - s[i], - phy_packet_self_id_get_phy_id(s[i]), - port[self_id_sequence_get_port_status(s, quadlet_count, port_index)= ], - port[self_id_sequence_get_port_status(s, quadlet_count, port_index = + 1)], - port[self_id_sequence_get_port_status(s, quadlet_count, port_index = + 2)], - port[self_id_sequence_get_port_status(s, quadlet_count, port_index = + 3)], - port[self_id_sequence_get_port_status(s, quadlet_count, port_index = + 4)], - port[self_id_sequence_get_port_status(s, quadlet_count, port_index = + 5)], - port[self_id_sequence_get_port_status(s, quadlet_count, port_index = + 6)], - port[self_id_sequence_get_port_status(s, quadlet_count, port_index = + 7)] - ); - - port_index +=3D 8; - } - } -} - static const char *evts[] =3D { [0x00] =3D "evt_no_status", [0x01] =3D "-reserved-", [0x02] =3D "evt_long_packet", [0x03] =3D "evt_missing_ack", @@ -2163,8 +2093,6 @@ static void bus_reset_work(struct work_struct *work) if (free_rom) dmam_free_coherent(ohci->card.device, CONFIG_ROM_SIZE, free_rom, free_ro= m_bus); =20 - log_selfids(ohci, generation, self_id_count); - fw_core_handle_bus_reset(&ohci->card, ohci->node_id, generation, self_id_count, ohci->self_id_buffer, ohci->csr_state_setclear_abdicate); --=20 2.48.1 From nobody Sat Oct 4 03:18:37 2025 Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEBCF194124 for ; Thu, 21 Aug 2025 00:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.150 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755736228; cv=none; b=ux414K6zf4echVLg/dA59vzTLhtgeDRJy3c/D3eN472dnBChP/NZFo5lelx8xplJBkN83dnm0HFAXTy/JyRpPb3SWZAN1QpKmnQ8FqIg7mBCqCHIpu2wmMXUGokEpvrvzzXx4FaoF/0cAtv2UZ23GqQIP6ZZrBwUQV9YBkNtzm0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755736228; c=relaxed/simple; bh=2M8Pr8xDAr4TbfIPkRer5rjJ50HISmBmmTM5F2CrbVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nmRfXdX52sYV+Lk64s5fxiAX8VPuxpVZGFQ9DeTUi09NYpAn1PSxDEjVBSZB7XkQhIwPnEjmk4/mVD8eRZbPoV1oERPmBQ1n4K4tst3h67W0htimCy62/XjQtzU0zJ2U2SfEoLcAPeP4HNsUmM+0OfFSXwt3CJVDzgrVwCcgnFM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=kUqp0Jnr; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=KRPGF3NK; arc=none smtp.client-ip=103.168.172.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="kUqp0Jnr"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="KRPGF3NK" Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id 27C06EC0143; Wed, 20 Aug 2025 20:30:26 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Wed, 20 Aug 2025 20:30:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1755736226; x= 1755822626; bh=nyWOmltExSU1DHt6R0TL8wUd6e6chXbsFXoPGfEB9CA=; b=k Uqp0JnrT4ES9WeUengP8OGEX7ZI/pwjqdDBcjiZS1iBHdUJtMmqZ3MzwI9vAPJ7U a1pg/avj3yyYaMCv9LJqNZpJfsNGvTnPj/+P+oohjfAJjLt5buD8UeSjA4PrKoBR sMzeJrk2Nr0QCAIO2f++g24rRYUZ/94ujVm2JIMMGeXrkum1HMn4ESqhfjekHPVw 0qnop2DU5uXE8915+c1xnh6/WqlQq8PitZImfCzVt2e4OOV1WL/nawlZIVwhvNEg 1Ip7t0f1Ku2xeQqwlW68Sb6TTROor5+L6fCUX8NgS3tAXXIr/tfpT1dY5fh5dhrL U+oZAfV6KCJRRr7MDK5qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1755736226; x=1755822626; bh=n yWOmltExSU1DHt6R0TL8wUd6e6chXbsFXoPGfEB9CA=; b=KRPGF3NKdIZpZ1H5n JL678SjVaqDGuAW3A6rnnBqdUv0pG9IlBnxEzgOoh4qgoSP5wA91JMjEOF15CwFP x8OBLri/cv7oMfhcbLtuesdMBJsvLrFOM1C4oNo8ZhK7fFtNfNn8UUAwemW/Dwuz Q9hhrbtH+NfJrosGSFZW3cbdiEEzVBSAt5yfIJsw+JzQ97YT4GLoo48zYF8Ak2Ji uvi6WEvKgO6vx4tj/s3QNwaZZRpHiX3rbuFPz+SrpZ8GSzwvg511ydBX+nt4z97t S5sSk1VzSKWEktY5qMlC32Pl8n8uaj8vJB9V8/uYNhrz0ZEo9ZWokTtlUDG+qR37 6MLyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduheelkeduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertd ertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpedvjefgjeeuvd fguddukeelveetgfdtvefhtdfffeeigfevueetffeivdffkedvtdenucevlhhushhtvghr ufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrg hkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlsehlihhsthhsrdhsohhurh gtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgv rhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Aug 2025 20:30:24 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 3/4] firewire: ohci: remove obsolete debug logging for AT/AR results Date: Thu, 21 Aug 2025 09:30:16 +0900 Message-ID: <20250821003017.186752-4-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250821003017.186752-1-o-takashi@sakamocchi.jp> References: <20250821003017.186752-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Between v6.11 and v6.12, a set of tracepoints was added to record asynchronous communication events: - firewire:async_phy_inbound - firewire:async_phy_outbound_initiate - firewire:async_phy_outbound_complete - firewire:async_response_inbound - firewire:async_response_outbound_initiate - firewire:async_response_outbound_complete - firewire:async_request_inbound - firewire:async_request_outbound_initiate - firewire:async_request_outbound_complete These tracepoints cover the functionality of the existing debug logging. This commit removes the logging. Signed-off-by: Takashi Sakamoto --- drivers/firewire/ohci.c | 132 ++++++---------------------------------- 1 file changed, 19 insertions(+), 113 deletions(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index 8cecdf4c6572..ae7f75fade8d 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -393,123 +393,15 @@ MODULE_PARM_DESC(quirks, "Chip quirks (default =3D 0" ", IR wake unreliable =3D " __stringify(QUIRK_IR_WAKE) ")"); =20 -#define OHCI_PARAM_DEBUG_AT_AR 1 - static int param_debug; module_param_named(debug, param_debug, int, 0644); MODULE_PARM_DESC(debug, "Verbose logging, deprecated in v6.11 kernel or la= ter. (default =3D 0" - ", AT/AR events =3D " __stringify(OHCI_PARAM_DEBUG_AT_AR) ", or a combination, or all =3D -1)"); =20 static bool param_remote_dma; module_param_named(remote_dma, param_remote_dma, bool, 0444); MODULE_PARM_DESC(remote_dma, "Enable unfiltered remote DMA (default =3D N)= "); =20 -static const char *evts[] =3D { - [0x00] =3D "evt_no_status", [0x01] =3D "-reserved-", - [0x02] =3D "evt_long_packet", [0x03] =3D "evt_missing_ack", - [0x04] =3D "evt_underrun", [0x05] =3D "evt_overrun", - [0x06] =3D "evt_descriptor_read", [0x07] =3D "evt_data_read", - [0x08] =3D "evt_data_write", [0x09] =3D "evt_bus_reset", - [0x0a] =3D "evt_timeout", [0x0b] =3D "evt_tcode_err", - [0x0c] =3D "-reserved-", [0x0d] =3D "-reserved-", - [0x0e] =3D "evt_unknown", [0x0f] =3D "evt_flushed", - [0x10] =3D "-reserved-", [0x11] =3D "ack_complete", - [0x12] =3D "ack_pending ", [0x13] =3D "-reserved-", - [0x14] =3D "ack_busy_X", [0x15] =3D "ack_busy_A", - [0x16] =3D "ack_busy_B", [0x17] =3D "-reserved-", - [0x18] =3D "-reserved-", [0x19] =3D "-reserved-", - [0x1a] =3D "-reserved-", [0x1b] =3D "ack_tardy", - [0x1c] =3D "-reserved-", [0x1d] =3D "ack_data_error", - [0x1e] =3D "ack_type_error", [0x1f] =3D "-reserved-", - [0x20] =3D "pending/cancelled", -}; - -static void log_ar_at_event(struct fw_ohci *ohci, - char dir, int speed, u32 *header, int evt) -{ - static const char *const tcodes[] =3D { - [TCODE_WRITE_QUADLET_REQUEST] =3D "QW req", - [TCODE_WRITE_BLOCK_REQUEST] =3D "BW req", - [TCODE_WRITE_RESPONSE] =3D "W resp", - [0x3] =3D "-reserved-", - [TCODE_READ_QUADLET_REQUEST] =3D "QR req", - [TCODE_READ_BLOCK_REQUEST] =3D "BR req", - [TCODE_READ_QUADLET_RESPONSE] =3D "QR resp", - [TCODE_READ_BLOCK_RESPONSE] =3D "BR resp", - [TCODE_CYCLE_START] =3D "cycle start", - [TCODE_LOCK_REQUEST] =3D "Lk req", - [TCODE_STREAM_DATA] =3D "async stream packet", - [TCODE_LOCK_RESPONSE] =3D "Lk resp", - [0xc] =3D "-reserved-", - [0xd] =3D "-reserved-", - [TCODE_LINK_INTERNAL] =3D "link internal", - [0xf] =3D "-reserved-", - }; - int tcode =3D async_header_get_tcode(header); - char specific[12]; - - if (likely(!(param_debug & OHCI_PARAM_DEBUG_AT_AR))) - return; - - if (unlikely(evt >=3D ARRAY_SIZE(evts))) - evt =3D 0x1f; - - if (evt =3D=3D OHCI1394_evt_bus_reset) { - ohci_notice(ohci, "A%c evt_bus_reset, generation %d\n", - dir, (header[2] >> 16) & 0xff); - return; - } - - switch (tcode) { - case TCODE_WRITE_QUADLET_REQUEST: - case TCODE_READ_QUADLET_RESPONSE: - case TCODE_CYCLE_START: - snprintf(specific, sizeof(specific), " =3D %08x", - be32_to_cpu((__force __be32)header[3])); - break; - case TCODE_WRITE_BLOCK_REQUEST: - case TCODE_READ_BLOCK_REQUEST: - case TCODE_READ_BLOCK_RESPONSE: - case TCODE_LOCK_REQUEST: - case TCODE_LOCK_RESPONSE: - snprintf(specific, sizeof(specific), " %x,%x", - async_header_get_data_length(header), - async_header_get_extended_tcode(header)); - break; - default: - specific[0] =3D '\0'; - } - - switch (tcode) { - case TCODE_STREAM_DATA: - ohci_notice(ohci, "A%c %s, %s\n", - dir, evts[evt], tcodes[tcode]); - break; - case TCODE_LINK_INTERNAL: - ohci_notice(ohci, "A%c %s, PHY %08x %08x\n", - dir, evts[evt], header[1], header[2]); - break; - case TCODE_WRITE_QUADLET_REQUEST: - case TCODE_WRITE_BLOCK_REQUEST: - case TCODE_READ_QUADLET_REQUEST: - case TCODE_READ_BLOCK_REQUEST: - case TCODE_LOCK_REQUEST: - ohci_notice(ohci, - "A%c spd %x tl %02x, %04x -> %04x, %s, %s, %012llx%s\n", - dir, speed, async_header_get_tlabel(header), - async_header_get_source(header), async_header_get_destination(heade= r), - evts[evt], tcodes[tcode], async_header_get_offset(header), specific= ); - break; - default: - ohci_notice(ohci, - "A%c spd %x tl %02x, %04x -> %04x, %s, %s%s\n", - dir, speed, async_header_get_tlabel(header), - async_header_get_source(header), async_header_get_destination(heade= r), - evts[evt], tcodes[tcode], specific); - } -} - static inline void reg_write(const struct fw_ohci *ohci, int offset, u32 d= ata) { writel(data, ohci->registers + offset); @@ -855,8 +747,6 @@ static __le32 *handle_ar_packet(struct ar_context *ctx,= __le32 *buffer) p.timestamp =3D status & 0xffff; p.generation =3D ohci->request_generation; =20 - log_ar_at_event(ohci, 'R', p.speed, p.header, evt); - /* * Several controllers, notably from NEC and VIA, forget to * write ack_complete status at PHY packet reception. @@ -1464,8 +1354,6 @@ static int handle_at_packet(struct context *context, evt =3D le16_to_cpu(last->transfer_status) & 0x1f; packet->timestamp =3D le16_to_cpu(last->res_count); =20 - log_ar_at_event(ohci, 'T', packet->speed, packet->header, evt); - switch (evt) { case OHCI1394_evt_timeout: /* Async response transmit timed out. */ @@ -1670,6 +1558,25 @@ static void at_context_transmit(struct at_context *c= tx, struct fw_packet *packet static void detect_dead_context(struct fw_ohci *ohci, const char *name, unsigned int regs) { + static const char *const evts[] =3D { + [0x00] =3D "evt_no_status", [0x01] =3D "-reserved-", + [0x02] =3D "evt_long_packet", [0x03] =3D "evt_missing_ack", + [0x04] =3D "evt_underrun", [0x05] =3D "evt_overrun", + [0x06] =3D "evt_descriptor_read", [0x07] =3D "evt_data_read", + [0x08] =3D "evt_data_write", [0x09] =3D "evt_bus_reset", + [0x0a] =3D "evt_timeout", [0x0b] =3D "evt_tcode_err", + [0x0c] =3D "-reserved-", [0x0d] =3D "-reserved-", + [0x0e] =3D "evt_unknown", [0x0f] =3D "evt_flushed", + [0x10] =3D "-reserved-", [0x11] =3D "ack_complete", + [0x12] =3D "ack_pending ", [0x13] =3D "-reserved-", + [0x14] =3D "ack_busy_X", [0x15] =3D "ack_busy_A", + [0x16] =3D "ack_busy_B", [0x17] =3D "-reserved-", + [0x18] =3D "-reserved-", [0x19] =3D "-reserved-", + [0x1a] =3D "-reserved-", [0x1b] =3D "ack_tardy", + [0x1c] =3D "-reserved-", [0x1d] =3D "ack_data_error", + [0x1e] =3D "ack_type_error", [0x1f] =3D "-reserved-", + [0x20] =3D "pending/cancelled", + }; u32 ctl; =20 ctl =3D reg_read(ohci, CONTROL_SET(regs)); @@ -2601,7 +2508,6 @@ static int ohci_cancel_packet(struct fw_card *card, s= truct fw_packet *packet) dma_unmap_single(ohci->card.device, packet->payload_bus, packet->payload_length, DMA_TO_DEVICE); =20 - log_ar_at_event(ohci, 'T', packet->speed, packet->header, 0x20); driver_data->packet =3D NULL; packet->ack =3D RCODE_CANCELLED; =20 --=20 2.48.1 From nobody Sat Oct 4 03:18:37 2025 Received: from fhigh-a6-smtp.messagingengine.com (fhigh-a6-smtp.messagingengine.com [103.168.172.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 667E01D516C for ; Thu, 21 Aug 2025 00:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755736230; cv=none; b=ndSNj3W4hqevOJH2ZSfpyhhGITkUweQZAl5G+3BljZNIncrtdO58tqVAkKWomxTm9nYz+Yy/U0VT2/D1Q/KZMS8J9/zdgPTAYGkqtTH0Ze8xvCtnzuZV6FURtyxjuu+cN+VaEOQblbKswRuDRLuCYoUOWyB6N3/TuImQluwToAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755736230; c=relaxed/simple; bh=7/52hrzDnwKKHNOyhvLcGtSWxHlP5P1EZdABet1qIRU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HblYtneenxZYhZKXz8/+OUUG3BIEVlaI+BlKUYfQkNyboKoahCyLW7nU5nBa2GlWynNAffyO9tWNMfJhlSNTX+QLR8len+6mJIUZ9FDQBGONFLCL7IZw2ylF7XLiVBdxLeIL67IiKKi1NbWRvPy76iESb16X59vqfEBGnMUv8Z8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=ZatSAQS9; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=BOASutjh; arc=none smtp.client-ip=103.168.172.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="ZatSAQS9"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="BOASutjh" Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id 7F0FD14000BE; Wed, 20 Aug 2025 20:30:27 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Wed, 20 Aug 2025 20:30:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1755736227; x= 1755822627; bh=Y3gqU4SmbBblagmxLkKgp6Bptdbd0oMAoCphalQECBI=; b=Z atSAQS9CSedBqwhF/YHndWSgZj5FaOHiGmKFGR703WQekQUKt7wEhZPXD6geUX9y kefKFQ9cv0rS4SZ3g4rJRlofDEcn8VyZ9bSmjztftREhes+0wACXbRArqj1S4VCd DijW3hFPb1IPT2+7/6VA+rcBMhlc9vv0HuUEGxPiFULmXUEQzINVNRhqYVpTNHgc 9Vt3id3ydr+v03Mey4LKA2OX24etg0Qd6AJYacLaHCdT+of8hDRhYXLiaqU+QX6g CBluBw/nhTxPlFIFvQ9nPcST3uT69UKJY2tonRb5TzyOSa969pnFmFVxqRcHcTmO pEAHTUJB/8WmfhEpsoJ4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1755736227; x=1755822627; bh=Y 3gqU4SmbBblagmxLkKgp6Bptdbd0oMAoCphalQECBI=; b=BOASutjhosW6V0JB0 /00WsVVgy6RJVt4CPgnsXjNMXEPMH8N5T6CZYOlUR9ciQDd+s/MzaSAACIuE4IQM 8dIFeZTplcUVbE8mxX56S2P5zg++raog0Xo+IBFjIXhk8fHcT2RW9H0HU4F/GAXJ rwBZzJ7s8MgYvQKtv1tmQwCvhA3t5+Knqt+DGQiy5iNStTKaWvCGM3LSJ5Tpt3tA Zk0uxSlzuGWTAREJGUO5+2CyWeg2yoenXCMvVrMRQrygqbuDXWnJTlj69CXrNhv8 pS5bM/AqENooMiDqU8iomt6JmOJhpjYq1cB3IaWQRlr3xZr05EAb/ZkP7Jlo97j2 b2z4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduheelkeduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertd ertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpedvjefgjeeuvd fguddukeelveetgfdtvefhtdfffeeigfevueetffeivdffkedvtdenucevlhhushhtvghr ufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrg hkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlsehlihhsthhsrdhsohhurh gtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgv rhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Aug 2025 20:30:26 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 4/4] firewire: ohci: remove obsolete module-level debug parameter Date: Thu, 21 Aug 2025 09:30:17 +0900 Message-ID: <20250821003017.186752-5-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250821003017.186752-1-o-takashi@sakamocchi.jp> References: <20250821003017.186752-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The module-level debug parameter was added in v2.6.26 by a commit ad3c0fe8b8d16 ("firewire: debug interrupt events"). Its functionality has long been superseded by tracepoints. This commit removes the module parameter, bye. Signed-off-by: Takashi Sakamoto --- drivers/firewire/ohci.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index ae7f75fade8d..c8c5d598e3c8 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -393,11 +393,6 @@ MODULE_PARM_DESC(quirks, "Chip quirks (default =3D 0" ", IR wake unreliable =3D " __stringify(QUIRK_IR_WAKE) ")"); =20 -static int param_debug; -module_param_named(debug, param_debug, int, 0644); -MODULE_PARM_DESC(debug, "Verbose logging, deprecated in v6.11 kernel or la= ter. (default =3D 0" - ", or a combination, or all =3D -1)"); - static bool param_remote_dma; module_param_named(remote_dma, param_remote_dma, bool, 0444); MODULE_PARM_DESC(remote_dma, "Enable unfiltered remote DMA (default =3D N)= "); @@ -2017,11 +2012,6 @@ static irqreturn_t irq_handler(int irq, void *data) if (!event || !~event) return IRQ_NONE; =20 - if (unlikely(param_debug > 0)) { - dev_notice_ratelimited(ohci->card.device, - "The debug parameter is superseded by tracepoints events, and d= eprecated."); - } - /* * busReset and postedWriteErr events must not be cleared yet * (OHCI 1.1 clauses 7.2.3.2 and 13.2.8.1) --=20 2.48.1