From nobody Sat Oct 4 04:56:47 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92615265CA0 for ; Thu, 21 Aug 2025 00:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755734411; cv=none; b=Rl76nHUr/LzGUJPaAEwP4aoV33klO5ufw3jJJGA7b/sOFdCVSg2RUtAgIglvhpO+vHy7iY+uXtPfW21kjCwXf8FfY8yHYGlYozswtdbLXYbhZjfRpT3Co8F05iDODsagbh+UXBKI70fmZVb9sU9JZSyB4uk3GKkXASu1nfo8J84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755734411; c=relaxed/simple; bh=rynmEzABuR7PsOH6QIS1a/CfJFN+KjviQjXtNvTrDQw=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=diRpOmWOFpWe+5lXnRo4UirmdHp7tXvzR8OW7diYb7vbzXfZUPQaUsQJ97MT33MoxgxRYfY7vpbZPVc2+B3KNfMbyZDkO1kCp411LjUVl9lz4pFTfD1lxsKp2De/MFoQV6unOEVgoTsKkldWbs3EubhZqYAlrveZyyDly4ArHGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GrYHFYdd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GrYHFYdd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38E24C113D0; Thu, 21 Aug 2025 00:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755734411; bh=rynmEzABuR7PsOH6QIS1a/CfJFN+KjviQjXtNvTrDQw=; h=Date:From:To:Cc:Subject:References:From; b=GrYHFYdd/pnlJ8pPy6ITA3MhokVtsJO7Oe4jhP3gX6LF20j8ZwVPEHs/zs870gOu5 Ttz/QVgwPBZU8D9qttyywsWnMd3Y2bChd+iKL3s+wXHHuYbOtU/5CmbhGxc0Vpyyyl gA/eNwXx59u/JWC+4r9XHnbjb/40O7wEIfwhIe+Z3YgmE/qoGCgVPu8Xe49/lm4wal f14PUvN8V6VhOvnXLcpx+GgjjYrGj2AsMoyJgMKtnUke/5vI7xKqA9XQ5aLROKJg1F Z3myZotourYtZdExrqXwW6Wgez6pQ9rFy7r6rJd0V/sECJYpsEX51OloL0AoIiBACp eSOiGG09wTtxg== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uosj0-000000013dF-2d6M; Wed, 20 Aug 2025 20:00:14 -0400 Message-ID: <20250821000014.480414046@kernel.org> User-Agent: quilt/0.68 Date: Wed, 20 Aug 2025 20:00:02 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Tao Chen Subject: [for-linus][PATCH 2/6] rtla: Check pkg-config install References: <20250821000000.210778097@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tao Chen The tool pkg-config used to check libtraceevent and libtracefs, if not installed, it will report the libs not found, even though they have already been installed. Before: libtraceevent is missing. Please install libtraceevent-dev/libtraceevent-de= vel libtracefs is missing. Please install libtracefs-dev/libtracefs-devel After: Makefile.config:10: *** Error: pkg-config needed by libtraceevent/libtracef= s is missing on this system, please install it. Link: https://lore.kernel.org/20250808040527.2036023-2-chen.dylane@linux.dev Fixes: 01474dc706ca ("tools/rtla: Use tools/build makefiles to build rtla") Signed-off-by: Tao Chen Signed-off-by: Steven Rostedt (Google) --- tools/tracing/rtla/Makefile.config | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/tracing/rtla/Makefile.config b/tools/tracing/rtla/Makefi= le.config index 5f2231d8d626..07ff5e8f3006 100644 --- a/tools/tracing/rtla/Makefile.config +++ b/tools/tracing/rtla/Makefile.config @@ -1,10 +1,18 @@ # SPDX-License-Identifier: GPL-2.0-only =20 +include $(srctree)/tools/scripts/utilities.mak + STOP_ERROR :=3D =20 LIBTRACEEVENT_MIN_VERSION =3D 1.5 LIBTRACEFS_MIN_VERSION =3D 1.6 =20 +ifndef ($(NO_LIBTRACEEVENT),1) + ifeq ($(call get-executable,$(PKG_CONFIG)),) + $(error Error: $(PKG_CONFIG) needed by libtraceevent/libtracefs is mis= sing on this system, please install it) + endif +endif + define lib_setup $(eval LIB_INCLUDES +=3D $(shell sh -c "$(PKG_CONFIG) --cflags lib$(1)")) $(eval LDFLAGS +=3D $(shell sh -c "$(PKG_CONFIG) --libs-only-L lib$(1)")) --=20 2.50.1