From nobody Sat Oct 4 01:44:53 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 380E62D0C73 for ; Thu, 21 Aug 2025 17:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755797212; cv=none; b=C1Z/WXZeG/mjTXnXvFiXEgsHMoMy767vE2xF4TI6u27J3+cVqybO0q7g9S2gDjfb3vMby3cN/Kpb763ZK2iVdypBfiQ6qx+SzV+ymOb0Ree9ESwVM0L1srWBQjYYbHLEsE0d2XuoPxxC0NJy9vAI6k+N/76+ivwJm3hJyBHw/yg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755797212; c=relaxed/simple; bh=tu6X+letYmWAKyHgSsIJheEiaxj569v4emLeSYXBn9c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LISDl7Ku35tCopY5W0U9VWqka1SpeMANdYv2BzPJtHxmEiWxkChJym3dMoYaAhYyvF8JrJV82+ofA7UD1AvHk/I7n2W2imM7fMD7NZJYbcRP0YfsohN58tYbdlXNle9iBnY//gCBIAuUQuOg308HoUc96wcDPV2TIeke/Yczemc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1up93e-0002Ta-Jz; Thu, 21 Aug 2025 19:26:38 +0200 From: Marco Felsch Date: Thu, 21 Aug 2025 19:26:36 +0200 Subject: [PATCH v3 1/4] firmware_loader: expand firmware error codes with up-to-date error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250821-v6-10-topic-touchscreen-axiom-v3-1-940ccee6dba3@pengutronix.de> References: <20250821-v6-10-topic-touchscreen-axiom-v3-0-940ccee6dba3@pengutronix.de> In-Reply-To: <20250821-v6-10-topic-touchscreen-axiom-v3-0-940ccee6dba3@pengutronix.de> To: Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Kamel Bouhara , Marco Felsch , Henrik Rydberg , Danilo Krummrich , Danilo Krummrich Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, kernel@pengutronix.de, Marco Felsch X-Mailer: b4 0.14.2 X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::28 X-SA-Exim-Mail-From: m.felsch@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Add FW_UPLOAD_ERR_DUPLICATE to allow drivers to inform the firmware_loader framework that the update is not required. This can be the case if the user provided firmware matches the current running firmware. Sync lib/test_firmware.c accordingly. Signed-off-by: Marco Felsch Reviewed-by: Luis Chamberlain Reviewed-by: Russ Weight --- drivers/base/firmware_loader/sysfs_upload.c | 1 + include/linux/firmware.h | 2 ++ lib/test_firmware.c | 1 + 3 files changed, 4 insertions(+) diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/fir= mware_loader/sysfs_upload.c index 829270067d1632f92656859fb9143e3fa9635670..0a583a1b3f4fde563257566426d= 523fbf839b13f 100644 --- a/drivers/base/firmware_loader/sysfs_upload.c +++ b/drivers/base/firmware_loader/sysfs_upload.c @@ -28,6 +28,7 @@ static const char * const fw_upload_err_str[] =3D { [FW_UPLOAD_ERR_RW_ERROR] =3D "read-write-error", [FW_UPLOAD_ERR_WEAROUT] =3D "flash-wearout", [FW_UPLOAD_ERR_FW_INVALID] =3D "firmware-invalid", + [FW_UPLOAD_ERR_DUPLICATE] =3D "firmware-duplicate", }; =20 static const char *fw_upload_progress(struct device *dev, diff --git a/include/linux/firmware.h b/include/linux/firmware.h index aae1b85ffc10e20e9c3c9b6009d26b83efd8cb24..fe7797be4c08cd62cdad9617b8f= 70095d5e0af2f 100644 --- a/include/linux/firmware.h +++ b/include/linux/firmware.h @@ -29,6 +29,7 @@ struct firmware { * @FW_UPLOAD_ERR_RW_ERROR: read or write to HW failed, see kernel log * @FW_UPLOAD_ERR_WEAROUT: FLASH device is approaching wear-out, wait & re= try * @FW_UPLOAD_ERR_FW_INVALID: invalid firmware file + * @FW_UPLOAD_ERR_DUPLICATE: firmware is already up to date (duplicate) * @FW_UPLOAD_ERR_MAX: Maximum error code marker */ enum fw_upload_err { @@ -41,6 +42,7 @@ enum fw_upload_err { FW_UPLOAD_ERR_RW_ERROR, FW_UPLOAD_ERR_WEAROUT, FW_UPLOAD_ERR_FW_INVALID, + FW_UPLOAD_ERR_DUPLICATE, FW_UPLOAD_ERR_MAX }; =20 diff --git a/lib/test_firmware.c b/lib/test_firmware.c index 211222e63328f970228920f5662ee80cc7f51215..603c3a4b385c849944a695849a1= 894693234b5eb 100644 --- a/lib/test_firmware.c +++ b/lib/test_firmware.c @@ -1133,6 +1133,7 @@ static const char * const fw_upload_err_str[] =3D { [FW_UPLOAD_ERR_RW_ERROR] =3D "read-write-error", [FW_UPLOAD_ERR_WEAROUT] =3D "flash-wearout", [FW_UPLOAD_ERR_FW_INVALID] =3D "firmware-invalid", + [FW_UPLOAD_ERR_DUPLICATE] =3D "firmware-duplicate", }; =20 static void upload_err_inject_error(struct test_firmware_upload *tst, --=20 2.39.5