From nobody Sat Oct 4 01:39:24 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D8192367AE for ; Thu, 21 Aug 2025 11:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755775665; cv=none; b=S43S8qE9/TeMSt5FPIfQ2t29Gnu3jlb7+vHPc7XV3KH8Z7Ll3sGEIdCeU7hn28vNAQ8UkTCNc+I9FeRD+ada+lWW8Yqs1z7RBBhGW8shJY7xRMUqu5PlRYU075I9ZV+JWuaBEXrU9IJC68ugPAXdlO/vzGCuhLoOXULRRgvLavI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755775665; c=relaxed/simple; bh=1M9j+PL0n2Y6NH2XjNF7fuQwEwS11EOrVMi3fRSifwo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KxO6o+WP6b4zIGcGZ8l7T0bCi6LnhPw1evcJ0mV1C1ItWVfNOxzl/yT66FPXWAgb+/96wt+ogvorywuuLm1kXTGjFH+F8OvyGws8pji6L4gBmOJBDppg7Q5KajM1iXGItFeHdtkDCjuf17OD50g/BfQkHXUMLjSRspyT6H1V45s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N2fFVzfk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N2fFVzfk" Received: by smtp.kernel.org (Postfix) with ESMTPS id 20A16C4CEED; Thu, 21 Aug 2025 11:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755775665; bh=1M9j+PL0n2Y6NH2XjNF7fuQwEwS11EOrVMi3fRSifwo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=N2fFVzfkdDB7GMIspdbWMZpvAcU3dGmdaTj3qgZjchgPgc7MOdWR66qfxpyBUFtIv WeJeOURS2BKBKpwbv/wsi8sDD8adH+9QDYfKgF0gLfk8K0AOLYAofZaCWrAdopQfnH F1SKnzqV4xr//+T+3MDtIHQ73Tj7DW/QaKCtOjqdotBsBfIUGmfeiSg7qeBGloF5bF Qqwac79x3Sw693koPMtmL9i5TME7cQA8fAtkD4GVsCwon1z0Rcezt8ibjUgyilblna tzHbmh9HyLlPBhL7aK5xEn9ofyGWqBoNncOfB2uNwojLVJ333lO/l4N5ucUqVJpU9D 7RaCAwyOReXvQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C5BCCA0EFF; Thu, 21 Aug 2025 11:27:45 +0000 (UTC) From: Simon Schuster via B4 Relay Date: Thu, 21 Aug 2025 13:27:37 +0200 Subject: [PATCH 1/2] copy_process: Handle architectures where sizeof(unsigned long) < sizeof(u64) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250821-nios2-implement-clone3-v1-1-1bb24017376a@siemens-energy.com> References: <20250821-nios2-implement-clone3-v1-0-1bb24017376a@siemens-energy.com> In-Reply-To: <20250821-nios2-implement-clone3-v1-0-1bb24017376a@siemens-energy.com> To: Dinh Nguyen , Christian Brauner , Arnd Bergmann , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Kees Cook Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Simon Schuster X-Mailer: b4 0.14.3-dev-2ce6c X-Developer-Signature: v=1; a=ed25519-sha256; t=1755775663; l=2756; i=schuster.simon@siemens-energy.com; s=20250818; h=from:subject:message-id; bh=fATaBcMTm8PaXx+wvHRntwDrs2IKs0+IzRTpuUxyYa4=; b=y7/IgnYV/3SkSNwCoqgDE/+S2MUsRejhrdpl2L+U7VnPzMzgttiqeo7QuevGlQKo7aBzvBcQ5 485HV4aRh6JBpSGlbRD35ZZAmT8+Yb7t7dbqgXJf0B1MkEE0oKL4n0t X-Developer-Key: i=schuster.simon@siemens-energy.com; a=ed25519; pk=PUhOMiSp43aSeRE1H41KApxYOluamBFFiMfKlBjocvo= X-Endpoint-Received: by B4 Relay for schuster.simon@siemens-energy.com/20250818 with auth_id=495 X-Original-From: Simon Schuster Reply-To: schuster.simon@siemens-energy.com From: Simon Schuster With the introduction of clone3 in commit 7f192e3cd316 ("fork: add clone3") the effective bit width of clone_flags on all architectures was increased from 32bit to 64bit. However, the signature of the copy_* helper functions (e.g., copy_sighand) used by copy_process was not adapted, as such, they potentially truncate the flags on architectures such as nios2, where unsigned long is a 32bit unsigned integer type. This can, for instance, be observed via failures of kernel selftest clone3_clear_sighand, which attempts to trigger the conditional if (clone_flags & CLONE_CLEAR_SIGHAND) in function copy_sighand within fork.c that will always fail given: unsigned long /* =3D=3D uint32_t */ clone_flags #define CLONE_CLEAR_SIGHAND 0x100000000ULL This commit fixes the bug by always passing clone_flags via their declared u64 type, invariant of architecture-dependent integer sizes. Signed-off-by: Simon Schuster Reviewed-by: Lorenzo Stoakes --- kernel/fork.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/fork.c b/kernel/fork.c index 5115be549234..0e9b2dd6c365 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1510,7 +1510,7 @@ static struct mm_struct *dup_mm(struct task_struct *t= sk, return NULL; } =20 -static int copy_mm(unsigned long clone_flags, struct task_struct *tsk) +static int copy_mm(u64 clone_flags, struct task_struct *tsk) { struct mm_struct *mm, *oldmm; =20 @@ -1548,7 +1548,7 @@ static int copy_mm(unsigned long clone_flags, struct = task_struct *tsk) return 0; } =20 -static int copy_fs(unsigned long clone_flags, struct task_struct *tsk) +static int copy_fs(u64 clone_flags, struct task_struct *tsk) { struct fs_struct *fs =3D current->fs; if (clone_flags & CLONE_FS) { @@ -1569,7 +1569,7 @@ static int copy_fs(unsigned long clone_flags, struct = task_struct *tsk) return 0; } =20 -static int copy_files(unsigned long clone_flags, struct task_struct *tsk, +static int copy_files(u64 clone_flags, struct task_struct *tsk, int no_files) { struct files_struct *oldf, *newf; @@ -1599,7 +1599,7 @@ static int copy_files(unsigned long clone_flags, stru= ct task_struct *tsk, return 0; } =20 -static int copy_sighand(unsigned long clone_flags, struct task_struct *tsk) +static int copy_sighand(u64 clone_flags, struct task_struct *tsk) { struct sighand_struct *sig; =20 @@ -1648,7 +1648,7 @@ static void posix_cpu_timers_init_group(struct signal= _struct *sig) posix_cputimers_group_init(pct, cpu_limit); } =20 -static int copy_signal(unsigned long clone_flags, struct task_struct *tsk) +static int copy_signal(u64 clone_flags, struct task_struct *tsk) { struct signal_struct *sig; =20 --=20 2.39.5 From nobody Sat Oct 4 01:39:24 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94DE33054E0 for ; Thu, 21 Aug 2025 11:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755775665; cv=none; b=cr2Y2xQBcFpaAkw1U++oTNCMh747CiprQyo/MoDV0DnKhMIYsVkpi0VkPeLfh/3rdab2gs8wJfh6as2wXciWERIQucWkORBXzn6OTJAdNfmRIUM2t397IEMLmFfDVNfm+gtGdzAznvtL66NDBBk5w82XMkjILrPj/rqSU2F9gUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755775665; c=relaxed/simple; bh=TeLiY9rWYgwluzznmA5sBvokJ7kYB4xX6yAp004tkOU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WIA6O9+buFE7quN6a9vkaXyNVxxl8oMgTzrbgeRb6SvhjPiLGBm6g1/HKjHtest3G8K0QUP5RI3Wyulst59Xz3OrLnqqqBVmjgG8RlGlHirvi2RDoXBlLseyNZlFiFdaw7ts3Le6BrPc/d65YNC28pWCG+4PlxZdnDfi2Ww6Q/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uaHLmxt2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uaHLmxt2" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3263AC4AF0D; Thu, 21 Aug 2025 11:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755775665; bh=TeLiY9rWYgwluzznmA5sBvokJ7kYB4xX6yAp004tkOU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=uaHLmxt2ngLqc4XdyTaJFkv9X9g0lcA5Z9u5bJc2CKTFebgLtws/IxWUVYTB4/he7 KwHF8rvP2jP7Cszdmgi0gpDM0++ZDDp2wv3LAZ8X1Bf2O3/8yDbPNg7xpCYsA49fC2 yJ+TFi4wXMdPFswab+cKObwNqr/QBh/LBi73aYWIoxAQ29Giyw1b1I/aN2rdCYyjK4 mEcrKGwlrqCgGTqQnZkS9GVJ1yF7awn2q6FB2HEFtDboM/pQgj959x8aZRXyPSvOc2 V//jTV3J5SdSAiwWV/w4IK5NZ86BduJ2huSiJ3wsVCmjkykQ8pmWKRyeztfGpCP5/Z nlaOOZwUWPtpQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A42CA0EF8; Thu, 21 Aug 2025 11:27:45 +0000 (UTC) From: Simon Schuster via B4 Relay Date: Thu, 21 Aug 2025 13:27:38 +0200 Subject: [PATCH 2/2] nios2: implement architecture-specific portion of sys_clone3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250821-nios2-implement-clone3-v1-2-1bb24017376a@siemens-energy.com> References: <20250821-nios2-implement-clone3-v1-0-1bb24017376a@siemens-energy.com> In-Reply-To: <20250821-nios2-implement-clone3-v1-0-1bb24017376a@siemens-energy.com> To: Dinh Nguyen , Christian Brauner , Arnd Bergmann , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Kees Cook Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Simon Schuster X-Mailer: b4 0.14.3-dev-2ce6c X-Developer-Signature: v=1; a=ed25519-sha256; t=1755775663; l=2259; i=schuster.simon@siemens-energy.com; s=20250818; h=from:subject:message-id; bh=ZGFd7PEXdNZQ3XvGm96hBqrgf0z3Sn12r48TmNzThTY=; b=F2nKl2igsmfyyDF/eUV0oYb5mlZJyimIpk0NXRJVrpnKfItiOUjRR+lvhtzDMtKjVJKvuPs+u 3hz69QALEOGCg5dAKDF1klwR3WkvjnC1lV0TyZQ2blO79aj8xnAMWyK X-Developer-Key: i=schuster.simon@siemens-energy.com; a=ed25519; pk=PUhOMiSp43aSeRE1H41KApxYOluamBFFiMfKlBjocvo= X-Endpoint-Received: by B4 Relay for schuster.simon@siemens-energy.com/20250818 with auth_id=495 X-Original-From: Simon Schuster Reply-To: schuster.simon@siemens-energy.com From: Simon Schuster This commit adds the sys_clone3 entrypoint for nios2. An architecture-specific wrapper (__sys_clone3) is required to save and restore additional registers to the kernel stack via SAVE_SWITCH_STACK and RESTORE_SWITCH_STACK. Signed-off-by: Simon Schuster --- arch/nios2/include/asm/syscalls.h | 1 + arch/nios2/include/asm/unistd.h | 2 -- arch/nios2/kernel/entry.S | 6 ++++++ arch/nios2/kernel/syscall_table.c | 1 + 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/nios2/include/asm/syscalls.h b/arch/nios2/include/asm/sys= calls.h index b4d4ed3bf9c8..0e214b0a0ac8 100644 --- a/arch/nios2/include/asm/syscalls.h +++ b/arch/nios2/include/asm/syscalls.h @@ -7,6 +7,7 @@ =20 int sys_cacheflush(unsigned long addr, unsigned long len, unsigned int op); +asmlinkage long __sys_clone3(struct clone_args __user *uargs, size_t size); =20 #include =20 diff --git a/arch/nios2/include/asm/unistd.h b/arch/nios2/include/asm/unist= d.h index 1146e56473c5..213f6de3cf7b 100644 --- a/arch/nios2/include/asm/unistd.h +++ b/arch/nios2/include/asm/unistd.h @@ -7,6 +7,4 @@ #define __ARCH_WANT_STAT64 #define __ARCH_WANT_SET_GET_RLIMIT =20 -#define __ARCH_BROKEN_SYS_CLONE3 - #endif diff --git a/arch/nios2/kernel/entry.S b/arch/nios2/kernel/entry.S index 99f0a65e6234..dd40dfd908e5 100644 --- a/arch/nios2/kernel/entry.S +++ b/arch/nios2/kernel/entry.S @@ -403,6 +403,12 @@ ENTRY(sys_clone) addi sp, sp, 4 RESTORE_SWITCH_STACK ret +/* long syscall(SYS_clone3, struct clone_args *cl_args, size_t size); */ +ENTRY(__sys_clone3) + SAVE_SWITCH_STACK + call sys_clone3 + RESTORE_SWITCH_STACK + ret =20 ENTRY(sys_rt_sigreturn) SAVE_SWITCH_STACK diff --git a/arch/nios2/kernel/syscall_table.c b/arch/nios2/kernel/syscall_= table.c index 434694067d8f..c99818aac9e1 100644 --- a/arch/nios2/kernel/syscall_table.c +++ b/arch/nios2/kernel/syscall_table.c @@ -13,6 +13,7 @@ #define __SYSCALL_WITH_COMPAT(nr, native, compat) __SYSCALL(nr, nat= ive) =20 #define sys_mmap2 sys_mmap_pgoff +#define sys_clone3 __sys_clone3 =20 void *sys_call_table[__NR_syscalls] =3D { [0 ... __NR_syscalls-1] =3D sys_ni_syscall, --=20 2.39.5