From nobody Sat Oct 4 03:18:41 2025 Received: from sonic312-24.consmr.mail.gq1.yahoo.com (sonic312-24.consmr.mail.gq1.yahoo.com [98.137.69.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 643B225F7A4 for ; Wed, 20 Aug 2025 21:36:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=98.137.69.205 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755725783; cv=none; b=d7Hk9MsYDS2IQR9Jniaw2iT7JL0JFOtxgnAV/cU+KZre6N4odUUVxrrUrn1n4J8HLzvR61DmmJ8iYmETduXeHLOjE6LJ6CZuju67NvJaitTDD0N7klqZ3mu6S0kYBd5q0VshRbzch7Gfe04IGYUl2S6fkpiG+QjIF76ySbjD788= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755725783; c=relaxed/simple; bh=gwR2FTEW5Fl+CistKipt66N88Og5m+2NbbVMb3I7buA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:References; b=MnjocAQFz8Af/cG3XQG15B36ZtynJ0fnyZTP8qn/zv2CMtdzWgxRP+778vUbCme+FsYuhMjpCAodFt2E3arvp4AfW88sIIeH3FPZ+kO8GAcZKnlWR/JTbCj30aj852M2zTF0K6cqCG4fUbyJevww6taf1rniDPKYvyuUJlghrQM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com; spf=pass smtp.mailfrom=yahoo.com; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b=CAcJtvs+; arc=none smtp.client-ip=98.137.69.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yahoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="CAcJtvs+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1755725774; bh=3Fkp55TcdyCCGAxGMXGItyF3dgrGUPFEBcgRKkVdDgE=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=CAcJtvs+1dhyICMDdCUUh/dxvFruP6gNeQ5Q1t+nDMVHMu0QzBeZie4HBAmvTIJYtch4Tm0J2hSupSh78EwtCAKgGjsHjbDNJUDKt8g31l4kLzVRsjq5RDssqRCePPLzcHUFNte38p4jJLD6JLZOGqwIpquKjX0FbOCGq6ez0PR4mv7WdADN6sI2mopE8fjJ1FNeq384unc8esbcjqmJHQOGy2gXrseMLkG6dT1rKeorHarCgK83/WHvyB23AE3PMSxAu+RLiHUfq0+nh8/xm4jUm1dgQ4DcwYBhmCDW3DIKizmTTEZ8UI+jcTG7daSQzUhq1rgqnakpkUdF6kUb9A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1755725774; bh=cZpCvLDS0kSkhDCeTTnvFWteZISH7r32xT4bZKmyVQj=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Vluq78PJZKVO52Fj9g9qB0sTZDI4hYYhx32z5TkB0kwfzRsJyWsSWm5DYEOlWbqsvQWMIj0+U3CiVfRppgPlW0NlFk9ikPMF6tfdvP0+LUVB2vYBX9Uic/bjsT752mrQLaEgdx4J+SLqCXb0HVq94WoqbjYBnsZbSIYeNGYqa3TcAt9of2WSOE176nAW0ePVO+OZLohXaE5IN1CCLk5aE/wvuN1XGav7EYYSzM3OnXIAT/4UxNcVkHMFj2BJLk82r25fu6Xr6BiHZSN8lt+XN6rQ4B1ht/ohsJp1CC9qzHlGsek+o0dHzCSyFn9P28INQMrIipKUo5CzGaGjhyLXbg== X-YMail-OSG: THNFN20VM1kvTbz64hEFQa_JFTAARrN17H7gNVQ02lWpZs5UHhiTWyig9hysVHT i6iYLefYj0TDYgVPETvxMXj0mgzIZXJfGegpsKfQBU4rlbU68rftAP9bSbbgpCZDH_8EehqjbSxD 8lDiEEyjslG0_rsSQl2yXwyp5aTVeaYhEaqanO8tWLHe5SZV5omxd9f0iQ3XOyw5ffSdhXpW01a_ MmV6dIdWXHpUUaQiYJGkQoo6NFDLLhcwIua7MEjkIcgavZ48VWRl5CYJpUAanlExXDDNGiWB3Pi4 ygkhM3ln3PJhobbtaw0sDcqDm_jTO4yJ0w9v20BX0naEs0OZdGAOBSFNopgT1RnQtrw7OhavIsEw EMBMHA.MKuyljgXx7VVTckO8F3OwALLIQP6mPJ4rDYOTKAZHCjS0SBgLCcf6kh8sRX9nfGsQtZqm dHHkom0tv1ImMQ4trC_kin8F8MHn7nds1oOYU7PI6uFbpnUquZOTrRc6x7r2k5qQLJ1Y5mvpj9iV JmjZqCxw5Z5coTtwUNDTVHVnKCDXQuC9s_igof9aLACtbaQ5v0584AkD4FzvI.6Ha5aHVkV1aUAR i4GDT8QKRaiaY4ucFmkWThCAMMPDfrsvP2iEWq7c7CYTZDlmDnhxq.5xFVvKfmMLI8Zgi4qyUjlB JcG4qBg7etYIR5PMveumH.DaJeDPBlxLcbVXzOQN2MaLr7Z3R_Dsdzohf2Al9bs95sFmRh9xrbDc iOJ5KyWapsG7mla5eU5yVEQcQEQS6_Fwii4xmUQ6ojZ4XKvFc4kysRMXjTK_Wg41xXMW80FvxfRr hYEzGu3Pb8MFpmTUvpgzgEJ4HAV9OR6EztNUGkqFAxcQcA.XJfqhDsm00u8rNX.3Q27_8Mv.SRYJ KJAWAJJ4I9COpDM_uesWQFfZ9zAJIqb9y60oRNcXtwsTQQ5Es7NLZjK6Wr3HZKOJ68Z_n7apBcle jz79mQsoE24rZS9rWc3SpbyT4U03UB1Hfvyh3cvVYXDRFI.I4LCKu73SEjM5HPk2X_GLZVlyXZpa EX3AYCU3NfV0VRHRetPjXPgUmG1vtSuTJWzsVEr3fepzZ1e9m2ho7rzZac9CToBOmp5XXd2OXsuX xpb3Id2ZmNpaBVDMmqZwS8dt3zajUtQXsWsUESwAGm2py.FIQUkwWZfLqDFZK.j.rJCuA8dpc08u GcZN2sYr.fAWS8hDfbQAtFR7WnsZXcRDkIPCg8r8WpaepGBYgSJFhWz7PJ49S89hRsiDe37wdMnr hNEzkfmPjrofiANXuUAPM6Wl86VLLlDLHdQC0szVGdaoqYrRrBoykLFBTkqM2Pm6qBQxvGjs.M3y .ufYvEdBGKsYB3klNKPoZ6pp8m9p8xfnmZbrXYIW_s5bbh5ZkWFFUoursZCx2eHF7OMommMBqrCy rRz5uPbpH9eZl1w9_NPGvOtJXdP7DgoE66AdrcWNjKtRQrX__M3.uBv.xFMnazcuC6MNLZ7Iz2es 0i2ILPlaWPviNEmrTmGubiAOB_7Rg63yA6VvqcBD9u7NWFDIE7BN7JyJeLGOpRsllrhe.t5GGPH6 j61H4FuGYlfvwuDk5GylQ5GZRAafdLimlMrtc985TZrkZan6gf5tT0oig83R8TVlKNkTVDtuMnps LYWnQJ_A.U8btsjvK5S0P1iT5pgcTUbLCpi91_Y3Yeir640DQe7qruHSKA6D.H_SURm2Q9IrP.NJ 2ebZz1C5LN2DLd7B32urtPzexxIBTr_11Cn57fMeT3GtjbQMjUbeXocGiaZOOdWmdG8ZygdTzsif e7NoDE2BcZFTqTIpivlBTNM4TG3q3phcYNTxzS8xvH.jaabLj63ulPeMRQzEMrPdpbFm9JRK4d1z kYUQQ5Dc_Bz6vy2vVnv.vNB8VmD7.Eux3OGvCqGCbDvrOo19Kb0oBQQGxEuqn_quGzF750fOBfBQ kw4RU3Nhi2zUawREx8niq2PW5Yy4QvqGVoTF45dLmG_f3R3sFXv.Y2.o_rIE2OILMZKl9TSDE_Fw bm5e.QSDMJLSYfNkQqgaA9TNjQUlh6v29rB8zhisDjhTRmlAAIjboX8B5BZK_o9QtE5cvUnPgWWe yY6iUBkqNEh5tJzm0mJ7QUEQ3p4TRYvxljQ45rFsvyLEs6kfX_H7NFHCiUDAvoJkXa7Ik9icr5V2 WrwSauFSAPTRoeQsxMcSNoVLpXuXUhi3.rAvjtNAFw4riKcIOCWUYQQPvEe8w1gpMap36Cb16Rdb A8dGROgQVbhvF_e7lm4lyGTkjtWaLk6a44dgOzMNEuUTxTw_8_3OtgTaemHdtdCNSb5nB4vlEl4k mnd23KhPPgmke_VOT X-Sonic-MF: X-Sonic-ID: a6242ee9-af46-49d0-b7d0-387b522a8096 Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Wed, 20 Aug 2025 21:36:14 +0000 Received: by hermes--production-bf1-689c4795f-ct644 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 61dac405d5ece461a95959028efdd9e8; Wed, 20 Aug 2025 20:55:47 +0000 (UTC) From: Sunday Adelodun To: shuah@kernel.org Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, surenb@google.com, Sunday Adelodun Subject: [PATCH] selftests/proc: Fix spelling in comments and improve error message Date: Wed, 20 Aug 2025 21:55:13 +0100 Message-ID: <20250820205513.103548-1-adelodunolaoluwa@yahoo.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <20250820205513.103548-1-adelodunolaoluwa.ref@yahoo.com> Content-Type: text/plain; charset="utf-8" This patch corrects minor spelling mistake and adjusts comment style, such as capitalizing the first letter for consistency. In addition, "error: failed to find available memory address for mapping\n" message replaces a not-quite-suitable one:"error: mmap doesn't like you\n". No functional changes are introduced Signed-off-by: Sunday Adelodun --- tools/testing/selftests/proc/fd-001-lookup.c | 4 ++-- tools/testing/selftests/proc/proc-maps-race.c | 22 +++++++++---------- .../selftests/proc/proc-self-map-files-002.c | 2 +- tools/testing/selftests/proc/read.c | 2 +- tools/testing/selftests/proc/setns-dcache.c | 2 +- tools/testing/selftests/proc/setns-sysvipc.c | 2 +- 6 files changed, 17 insertions(+), 17 deletions(-) diff --git a/tools/testing/selftests/proc/fd-001-lookup.c b/tools/testing/s= elftests/proc/fd-001-lookup.c index 60d7948e7124..2f5949593ad4 100644 --- a/tools/testing/selftests/proc/fd-001-lookup.c +++ b/tools/testing/selftests/proc/fd-001-lookup.c @@ -60,7 +60,7 @@ static void test_lookup(unsigned int fd) snprintf(buf, sizeof(buf), "/proc/self/fd/%u", fd); test_lookup_pass(buf); =20 - /* leading junk */ + /* Leading junk */ for (c =3D 1; c <=3D 255; c++) { if (c =3D=3D '/') continue; @@ -68,7 +68,7 @@ static void test_lookup(unsigned int fd) test_lookup_fail(buf); } =20 - /* trailing junk */ + /* Trailing junk */ for (c =3D 1; c <=3D 255; c++) { if (c =3D=3D '/') continue; diff --git a/tools/testing/selftests/proc/proc-maps-race.c b/tools/testing/= selftests/proc/proc-maps-race.c index 94bba4553130..2e730b70b171 100644 --- a/tools/testing/selftests/proc/proc-maps-race.c +++ b/tools/testing/selftests/proc/proc-maps-race.c @@ -138,10 +138,10 @@ static void copy_last_line(struct page_content *page,= char *last_line) { /* Get the last line in the first page */ const char *end =3D page->data + page->size - 1; - /* skip last newline */ + /* Skip last newline */ const char *pos =3D end - 1; =20 - /* search previous newline */ + /* Search previous newline */ while (pos[-1] !=3D '\n') pos--; strncpy(last_line, pos, end - pos); @@ -412,7 +412,7 @@ FIXTURE_SETUP(proc_maps_race) self->vma_count =3D self->page_size / 32 + 1; self->shared_mem_size =3D sizeof(struct vma_modifier_info) + self->vma_co= unt * sizeof(void *); =20 - /* map shared memory for communication with the child process */ + /* Map shared memory for communication with the child process */ self->mod_info =3D (struct vma_modifier_info *)mmap(NULL, self->shared_me= m_size, PROT_READ | PROT_WRITE, MAP_SHARED | MAP_ANONYMOUS, -1, 0); ASSERT_NE(self->mod_info, MAP_FAILED); @@ -439,7 +439,7 @@ FIXTURE_SETUP(proc_maps_race) mod_info->child_mapped_addr[i] =3D mmap(NULL, self->page_size * 3, prot, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); ASSERT_NE(mod_info->child_mapped_addr[i], MAP_FAILED); - /* change protection in adjacent maps to prevent merging */ + /* Change protection in adjacent maps to prevent merging */ prot ^=3D PROT_WRITE; } signal_state(mod_info, CHILD_READY); @@ -536,7 +536,7 @@ TEST_F(proc_maps_race, test_maps_tearing_from_split) =20 wait_for_state(mod_info, SETUP_READY); =20 - /* re-read the file to avoid using stale data from previous test */ + /* Re-read the file to avoid using stale data from previous test */ ASSERT_TRUE(read_boundary_lines(self, &self->last_line, &self->first_line= )); =20 mod_info->vma_modify =3D split_vma; @@ -600,7 +600,7 @@ TEST_F(proc_maps_race, test_maps_tearing_from_split) } while (end_ts.tv_sec - start_ts.tv_sec < self->duration_sec); end_test_loop(self->verbose); =20 - /* Signal the modifyer thread to stop and wait until it exits */ + /* Signal the modifier thread to stop and wait until it exits */ signal_state(mod_info, TEST_DONE); } =20 @@ -615,7 +615,7 @@ TEST_F(proc_maps_race, test_maps_tearing_from_resize) =20 wait_for_state(mod_info, SETUP_READY); =20 - /* re-read the file to avoid using stale data from previous test */ + /* Re-read the file to avoid using stale data from previous test */ ASSERT_TRUE(read_boundary_lines(self, &self->last_line, &self->first_line= )); =20 mod_info->vma_modify =3D shrink_vma; @@ -653,7 +653,7 @@ TEST_F(proc_maps_race, test_maps_tearing_from_resize) strcmp(new_first_line.text, restored_last_line.text), "Shrink result invalid", self)); } else { - /* The vmas should be consistent with the original/resored state */ + /* The vmas should be consistent with the original/restored state */ ASSERT_FALSE(print_boundaries_on( strcmp(new_last_line.text, restored_last_line.text), "Expand result invalid", self)); @@ -667,7 +667,7 @@ TEST_F(proc_maps_race, test_maps_tearing_from_resize) } while (end_ts.tv_sec - start_ts.tv_sec < self->duration_sec); end_test_loop(self->verbose); =20 - /* Signal the modifyer thread to stop and wait until it exits */ + /* Signal the modifier thread to stop and wait until it exits */ signal_state(mod_info, TEST_DONE); } =20 @@ -682,7 +682,7 @@ TEST_F(proc_maps_race, test_maps_tearing_from_remap) =20 wait_for_state(mod_info, SETUP_READY); =20 - /* re-read the file to avoid using stale data from previous test */ + /* Re-read the file to avoid using stale data from previous test */ ASSERT_TRUE(read_boundary_lines(self, &self->last_line, &self->first_line= )); =20 mod_info->vma_modify =3D remap_vma; @@ -734,7 +734,7 @@ TEST_F(proc_maps_race, test_maps_tearing_from_remap) } while (end_ts.tv_sec - start_ts.tv_sec < self->duration_sec); end_test_loop(self->verbose); =20 - /* Signal the modifyer thread to stop and wait until it exits */ + /* Signal the modifier thread to stop and wait until it exits */ signal_state(mod_info, TEST_DONE); } =20 diff --git a/tools/testing/selftests/proc/proc-self-map-files-002.c b/tools= /testing/selftests/proc/proc-self-map-files-002.c index e6aa00a183bc..ac05b0b127cd 100644 --- a/tools/testing/selftests/proc/proc-self-map-files-002.c +++ b/tools/testing/selftests/proc/proc-self-map-files-002.c @@ -67,7 +67,7 @@ int main(void) break; } if (va =3D=3D va_max) { - fprintf(stderr, "error: mmap doesn't like you\n"); + fprintf(stderr, "error: failed to find available memory address for mapp= ing\n"); return 1; } =20 diff --git a/tools/testing/selftests/proc/read.c b/tools/testing/selftests/= proc/read.c index 35ee78dff144..84f6f2e01150 100644 --- a/tools/testing/selftests/proc/read.c +++ b/tools/testing/selftests/proc/read.c @@ -41,7 +41,7 @@ static void f_reg(DIR *d, const char *filename) int fd; ssize_t rv; =20 - /* read from /proc/kmsg can block */ + /* Read from /proc/kmsg can block */ fd =3D openat(dirfd(d), filename, O_RDONLY|O_NONBLOCK); if (fd =3D=3D -1) return; diff --git a/tools/testing/selftests/proc/setns-dcache.c b/tools/testing/se= lftests/proc/setns-dcache.c index 60ab197a73fc..70389832dd22 100644 --- a/tools/testing/selftests/proc/setns-dcache.c +++ b/tools/testing/selftests/proc/setns-dcache.c @@ -50,7 +50,7 @@ int main(void) =20 atexit(f); =20 - /* Check for priviledges and syscall availability straight away. */ + /* Check for privileges and syscall availability straight away. */ if (unshare(CLONE_NEWNET) =3D=3D -1) { if (errno =3D=3D ENOSYS || errno =3D=3D EPERM) { return 4; diff --git a/tools/testing/selftests/proc/setns-sysvipc.c b/tools/testing/s= elftests/proc/setns-sysvipc.c index 903890c5e587..d03aa4838f0f 100644 --- a/tools/testing/selftests/proc/setns-sysvipc.c +++ b/tools/testing/selftests/proc/setns-sysvipc.c @@ -49,7 +49,7 @@ int main(void) =20 atexit(f); =20 - /* Check for priviledges and syscall availability straight away. */ + /* Check for privileges and syscall availability straight away. */ if (unshare(CLONE_NEWIPC) =3D=3D -1) { if (errno =3D=3D ENOSYS || errno =3D=3D EPERM) { return 4; --=20 2.43.0