From nobody Sat Oct 4 03:17:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 389618F49; Wed, 20 Aug 2025 19:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755719253; cv=none; b=vCMXYA5vZlfuqqn++zgxSsE4lO5h5asaFnKgnT29PvZf8LvZIVlZ5BnU+EeAZGiw7jX4zlBH2Myh2QndYWRTYfoqcbiCO3LSphUelrvayyLFHsIXr7zBabg3VcJdvZMFHAoZALmCAYcXEiNIhlIZkXef8TtVbEbj7RZowH8e9/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755719253; c=relaxed/simple; bh=LXuu2Cje6OHE3XwS/50xEtHZHzM3gOFhHiFVE5g8TAE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hgp/GFqNgXXfbABoi5OrL6AKjIrjjh9N/3z8MlknipkKTrfKQ7TGenYVyGvSc1xPYv50boMw68IP0gVDrEHLzY8Sz5tKEUB4INExExC2a50aGaLFKMu3OO0q/cXfBP7JNJQ5SmThh9s+7MOF4dNvLsTSq1YsqqTwU8Bd/fbMIQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E33BEC4CEE7; Wed, 20 Aug 2025 19:47:31 +0000 (UTC) From: Dave Jiang To: linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, dave@stgolabs.net, jonathan.cameron@huawei.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com, marc.herbert@linux.intel.com, akpm@linux-foundation.org, david@redhat.com Subject: [PATCH v2 1/4] mm/memory_hotplug: Update comment for hotplug memory callback priorities Date: Wed, 20 Aug 2025 12:47:01 -0700 Message-ID: <20250820194704.4130565-2-dave.jiang@intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820194704.4130565-1-dave.jiang@intel.com> References: <20250820194704.4130565-1-dave.jiang@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add clarification to comment for memory hotplug callback ordering as the current comment does not provide clear language on which callback happens first. Acked-by: David Hildenbrand Signed-off-by: Dave Jiang Reviewed-by: Jonathan Cameron --- v2: - Clearer comment suggestion from DavidH. --- include/linux/memory.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/memory.h b/include/linux/memory.h index 40eb70ccb09d..de5c0d8e8925 100644 --- a/include/linux/memory.h +++ b/include/linux/memory.h @@ -115,8 +115,8 @@ struct notifier_block; struct mem_section; =20 /* - * Priorities for the hotplug memory callback routines (stored in decreasi= ng - * order in the callback chain) + * Priorities for the hotplug memory callback routines. Invoked from + * high to low. Higher priorities corresponds to higher numbers. */ #define DEFAULT_CALLBACK_PRI 0 #define SLAB_CALLBACK_PRI 1 --=20 2.50.1 From nobody Sat Oct 4 03:17:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDA358F49; Wed, 20 Aug 2025 19:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755719261; cv=none; b=ZkhaIWymHFCgpXIcwR8WaSZq29zeqGbEG/pNd3whLqR+dZkXTjtBErzIzsWyMF9TErsOXbZYb2fnEuZwwtazlZg8La37RLcLyUNMcDo7lje81UTJlQaIqahkp6+9XMkyycC3oxmznzRiOt7Gd0x0gOOfqlZKQmQKQjp+kwaiFuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755719261; c=relaxed/simple; bh=8kkyZB7qpuq+05eWZeiIsTCmvBgqNZoodEK7xw33fFM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V7JT86ni9VIQquOz4sq3940pXH7Meiu8iXiuVWTnMl66qT+M3Zz4scM+3RDhCP6rclAMxE/TKa/VxBQHrF21t3QEsUzr+d1C6pvUmyVLWKcNl5yX7bYRuPDgjpCC9YzKV5oW4098icgJL4tbMizUxT8FO9vLZWcWOgZWITFd6og= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A68D0C4CEE7; Wed, 20 Aug 2025 19:47:39 +0000 (UTC) From: Dave Jiang To: linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, dave@stgolabs.net, jonathan.cameron@huawei.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com, marc.herbert@linux.intel.com, akpm@linux-foundation.org, david@redhat.com Subject: [PATCH v2 2/4] drivers/base/node: Add a helper function node_update_perf_attrs() Date: Wed, 20 Aug 2025 12:47:02 -0700 Message-ID: <20250820194704.4130565-3-dave.jiang@intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820194704.4130565-1-dave.jiang@intel.com> References: <20250820194704.4130565-1-dave.jiang@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add helper function node_update_perf_attrs() to allow update of node access coordinates computed by an external agent such as CXL. The helper allows updating of coordinates after the attribute being created by HMAT. Acked-by: David Hildenbrand Reviewed-by: Jonathan Cameron Signed-off-by: Dave Jiang --- v2: - Remove extra word in comment. (DavidH) - Streamline code branching. (DavidH) --- drivers/base/node.c | 38 ++++++++++++++++++++++++++++++++++++++ include/linux/node.h | 8 ++++++++ 2 files changed, 46 insertions(+) diff --git a/drivers/base/node.c b/drivers/base/node.c index 3399594136b2..db18a1c32637 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -248,6 +248,44 @@ void node_set_perf_attrs(unsigned int nid, struct acce= ss_coordinate *coord, } EXPORT_SYMBOL_GPL(node_set_perf_attrs); =20 +/** + * node_update_perf_attrs - Update the performance values for given access= class + * @nid: Node identifier to be updated + * @coord: Heterogeneous memory performance coordinates + * @access: The access class for the given attributes + */ +void node_update_perf_attrs(unsigned int nid, struct access_coordinate *co= ord, + enum access_coordinate_class access) +{ + struct node_access_nodes *access_node; + struct node *node; + int i; + + if (WARN_ON_ONCE(!node_online(nid))) + return; + + node =3D node_devices[nid]; + list_for_each_entry(access_node, &node->access_list, list_node) { + if (access_node->access !=3D access) + continue; + + access_node->coord =3D *coord; + for (i =3D 0; access_attrs[i]; i++) { + sysfs_notify(&access_node->dev.kobj, + NULL, access_attrs[i]->name); + } + break; + } + + /* When setting CPU access coordinates, update mempolicy */ + if (access !=3D ACCESS_COORDINATE_CPU) + return; + + if (mempolicy_set_node_perf(nid, coord)) + pr_info("failed to set mempolicy attrs for node %d\n", nid); +} +EXPORT_SYMBOL_GPL(node_update_perf_attrs); + /** * struct node_cache_info - Internal tracking for memory node caches * @dev: Device represeting the cache level diff --git a/include/linux/node.h b/include/linux/node.h index 2c7529335b21..866e3323f1fd 100644 --- a/include/linux/node.h +++ b/include/linux/node.h @@ -85,6 +85,8 @@ struct node_cache_attrs { void node_add_cache(unsigned int nid, struct node_cache_attrs *cache_attrs= ); void node_set_perf_attrs(unsigned int nid, struct access_coordinate *coord, enum access_coordinate_class access); +void node_update_perf_attrs(unsigned int nid, struct access_coordinate *co= ord, + enum access_coordinate_class access); #else static inline void node_add_cache(unsigned int nid, struct node_cache_attrs *cache_attrs) @@ -96,6 +98,12 @@ static inline void node_set_perf_attrs(unsigned int nid, enum access_coordinate_class access) { } + +static inline void node_update_perf_attrs(unsigned int nid, + struct access_coordinate *coord, + enum access_coordinate_class access) +{ +} #endif =20 struct node { --=20 2.50.1 From nobody Sat Oct 4 03:17:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEB3F8F49; Wed, 20 Aug 2025 19:47:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755719267; cv=none; b=GTeP9Iou85eCEhD+DWPrVwoD8Xu6YCNGnyE4TgPhVFrohGwu1/CbMkQsjykEhC1TTqvfHFLIlSt/VutvAe5tlulMNvyAbsYkvAHUrMnYGprGUgV+PaJRWZnBR4ANn0zk1SZklR3A3E59X3+OGeNNRleA9iOwgAVGqAiC/NGNDas= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755719267; c=relaxed/simple; bh=qDv0CfcsR9Lk4J1yuBka5j8xNyD7XtADzFxaX2la9DY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mzN5a9iV6fBrkoRBwnIH0Zjmya17dvoNpEAWS3u7nTxCagNHIdRSC6yBEu58HN/w6TagHkB5lTU7+SDhTfm07sBU5+QLCjAK3Rtz61l39CuFC8px4KB3vbMcJU5aaM6NL5pTXrn0ESLFIuE4wdaD2ec+dAAv53u0urTWRq908kI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58445C4CEE7; Wed, 20 Aug 2025 19:47:45 +0000 (UTC) From: Dave Jiang To: linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, dave@stgolabs.net, jonathan.cameron@huawei.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com, marc.herbert@linux.intel.com, akpm@linux-foundation.org, david@redhat.com, stable@vger.kernel.org Subject: [PATCH v2 3/4] cxl, acpi/hmat: Update CXL access coordinates directly instead of through HMAT Date: Wed, 20 Aug 2025 12:47:03 -0700 Message-ID: <20250820194704.4130565-4-dave.jiang@intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820194704.4130565-1-dave.jiang@intel.com> References: <20250820194704.4130565-1-dave.jiang@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current implementation of CXL memory hotplug notifier gets called before the HMAT memory hotplug notifier. The CXL driver calculates the access coordinates (bandwidth and latency values) for the CXL end to end path (i.e. CPU to endpoint). When the CXL region is onlined, the CXL memory hotplug notifier writes the access coordinates to the HMAT target structs. Then the HMAT memory hotplug notifier is called and it creates the access coordinates for the node sysfs attributes. During testing on an Intel platform, it was found that although the newly calculated coordinates were pushed to sysfs, the sysfs attributes for the access coordinates showed up with the wrong initiator. The system has 4 nodes (0, 1, 2, 3) where node 0 and 1 are CPU nodes and node 2 and 3 are CXL nodes. The expectation is that node 2 would show up as a target to node 0: /sys/devices/system/node/node2/access0/initiators/node0 However it was observed that node 2 showed up as a target under node 1: /sys/devices/system/node/node2/access0/initiators/node1 The original intent of the 'ext_updated' flag in HMAT handling code was to stop HMAT memory hotplug callback from clobbering the access coordinates after CXL has injected its calculated coordinates and replaced the generic target access coordinates provided by the HMAT table in the HMAT target structs. However the flag is hacky at best and blocks the updates from other CXL regions that are onlined in the same node later on. Remove the 'ext_updated' flag usage and just update the access coordinates for the nodes directly without touching HMAT target data. The hotplug memory callback ordering is changed. Instead of changing CXL, move HMAT back so there's room for the levels rather than have CXL share the same level as SLAB_CALLBACK_PRI. The change will resulting in the CXL callback to be executed after the HMAT callback. With the change, the CXL hotplug memory notifier runs after the HMAT callback. The HMAT callback will create the node sysfs attributes for access coordinates. The CXL callback will write the access coordinates to the now created node sysfs attributes directly and will not pollute the HMAT target values. Fixes: 067353a46d8c ("cxl/region: Add memory hotplug notifier for cxl regio= n") Cc: stable@vger.kernel.org Tested-by: Marc Herbert Reviewed-by: Dan Williams Signed-off-by: Dave Jiang --- v2: - Add description to what was observed for the issue. (Dan) - Use the correct Fixes tag. (Dan) - Add Cc to stable. (Dan) - Add support to only update on first region appearance. (Jonathan) --- drivers/acpi/numa/hmat.c | 6 ------ drivers/cxl/core/cdat.c | 5 ----- drivers/cxl/core/core.h | 1 - drivers/cxl/core/region.c | 21 +++++++++++++-------- include/linux/memory.h | 2 +- 5 files changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c index 4958301f5417..5d32490dc4ab 100644 --- a/drivers/acpi/numa/hmat.c +++ b/drivers/acpi/numa/hmat.c @@ -74,7 +74,6 @@ struct memory_target { struct node_cache_attrs cache_attrs; u8 gen_port_device_handle[ACPI_SRAT_DEVICE_HANDLE_SIZE]; bool registered; - bool ext_updated; /* externally updated */ }; =20 struct memory_initiator { @@ -391,7 +390,6 @@ int hmat_update_target_coordinates(int nid, struct acce= ss_coordinate *coord, coord->read_bandwidth, access); hmat_update_target_access(target, ACPI_HMAT_WRITE_BANDWIDTH, coord->write_bandwidth, access); - target->ext_updated =3D true; =20 return 0; } @@ -773,10 +771,6 @@ static void hmat_update_target_attrs(struct memory_tar= get *target, u32 best =3D 0; int i; =20 - /* Don't update if an external agent has changed the data. */ - if (target->ext_updated) - return; - /* Don't update for generic port if there's no device handle */ if ((access =3D=3D NODE_ACCESS_CLASS_GENPORT_SINK_LOCAL || access =3D=3D NODE_ACCESS_CLASS_GENPORT_SINK_CPU) && diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c index c0af645425f4..c891fd618cfd 100644 --- a/drivers/cxl/core/cdat.c +++ b/drivers/cxl/core/cdat.c @@ -1081,8 +1081,3 @@ int cxl_update_hmat_access_coordinates(int nid, struc= t cxl_region *cxlr, { return hmat_update_target_coordinates(nid, &cxlr->coord[access], access); } - -bool cxl_need_node_perf_attrs_update(int nid) -{ - return !acpi_node_backed_by_real_pxm(nid); -} diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h index 2669f251d677..a253d308f3c9 100644 --- a/drivers/cxl/core/core.h +++ b/drivers/cxl/core/core.h @@ -139,7 +139,6 @@ long cxl_pci_get_latency(struct pci_dev *pdev); int cxl_pci_get_bandwidth(struct pci_dev *pdev, struct access_coordinate *= c); int cxl_update_hmat_access_coordinates(int nid, struct cxl_region *cxlr, enum access_coordinate_class access); -bool cxl_need_node_perf_attrs_update(int nid); int cxl_port_get_switch_dport_bandwidth(struct cxl_port *port, struct access_coordinate *c); =20 diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index 71cc42d05248..371873fc43eb 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -30,6 +31,9 @@ * 3. Decoder targets */ =20 +/* xarray that stores the reference count per node for regions */ +static DEFINE_XARRAY(node_regions_xa); + static struct cxl_region *to_cxl_region(struct device *dev); =20 #define __ACCESS_ATTR_RO(_level, _name) { \ @@ -2442,14 +2446,8 @@ static bool cxl_region_update_coordinates(struct cxl= _region *cxlr, int nid) =20 for (int i =3D 0; i < ACCESS_COORDINATE_MAX; i++) { if (cxlr->coord[i].read_bandwidth) { - rc =3D 0; - if (cxl_need_node_perf_attrs_update(nid)) - node_set_perf_attrs(nid, &cxlr->coord[i], i); - else - rc =3D cxl_update_hmat_access_coordinates(nid, cxlr, i); - - if (rc =3D=3D 0) - cset++; + node_update_perf_attrs(nid, &cxlr->coord[i], i); + cset++; } } =20 @@ -2475,6 +2473,7 @@ static int cxl_region_perf_attrs_callback(struct noti= fier_block *nb, struct node_notify *nn =3D arg; int nid =3D nn->nid; int region_nid; + int rc; =20 if (action !=3D NODE_ADDED_FIRST_MEMORY) return NOTIFY_DONE; @@ -2487,6 +2486,11 @@ static int cxl_region_perf_attrs_callback(struct not= ifier_block *nb, if (nid !=3D region_nid) return NOTIFY_DONE; =20 + /* No action needed if there's existing entry */ + rc =3D xa_insert(&node_regions_xa, nid, NULL, GFP_KERNEL); + if (rc < 0) + return NOTIFY_DONE; + if (!cxl_region_update_coordinates(cxlr, nid)) return NOTIFY_DONE; =20 @@ -3638,6 +3642,7 @@ int cxl_region_init(void) =20 void cxl_region_exit(void) { + xa_destroy(&node_regions_xa); cxl_driver_unregister(&cxl_region_driver); } =20 diff --git a/include/linux/memory.h b/include/linux/memory.h index de5c0d8e8925..684fd641f2f0 100644 --- a/include/linux/memory.h +++ b/include/linux/memory.h @@ -120,8 +120,8 @@ struct mem_section; */ #define DEFAULT_CALLBACK_PRI 0 #define SLAB_CALLBACK_PRI 1 -#define HMAT_CALLBACK_PRI 2 #define CXL_CALLBACK_PRI 5 +#define HMAT_CALLBACK_PRI 6 #define MM_COMPUTE_BATCH_PRI 10 #define CPUSET_CALLBACK_PRI 10 #define MEMTIER_HOTPLUG_PRI 100 --=20 2.50.1 From nobody Sat Oct 4 03:17:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51205285CAE; Wed, 20 Aug 2025 19:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755719274; cv=none; b=X5L7gpFjwSDZUoZItRxYYjAiUq1RCTTV7/KrRzd3d1yQWZZgwHF+XSv1fi456pwio8+jYHufWootGGQMSnmBfVxhAjlBEOAN6BLGGB3jxVKuqNlCfMHB0a+5udyKdxXTPOI8vi3gCh5ghrFB52NQcxozIvM+fFEunY5P0JpXTWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755719274; c=relaxed/simple; bh=/DQq03KGSTjhQvFJPs2txX2xLrZURgkekgphV6n/h6o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nhz2IpRPkNbAjDi4N/QDuG6Lzxe5uPG1TLRKFektQJNqsjg+mP5bvm7ZdBVEaaDA6w666S04iZuD8x2vMTm3jiq0nmMBK7jC/UujRlfHhnfU2M5oGHiMQO+auuutBSVmdDXWKJdZDXXDGo42/6Q3E0y4rpZ4Ur5r7skEpYyj1fU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08A7DC4CEE7; Wed, 20 Aug 2025 19:47:52 +0000 (UTC) From: Dave Jiang To: linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, dave@stgolabs.net, jonathan.cameron@huawei.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com, marc.herbert@linux.intel.com, akpm@linux-foundation.org, david@redhat.com Subject: [PATCH v2 4/4] acpi/hmat: Remove now unused hmat_update_target_coordinates() Date: Wed, 20 Aug 2025 12:47:04 -0700 Message-ID: <20250820194704.4130565-5-dave.jiang@intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820194704.4130565-1-dave.jiang@intel.com> References: <20250820194704.4130565-1-dave.jiang@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove deadcode since CXL no longer calls hmat_update_target_coordinates(). Reviewed-by: Jonathan Cameron Signed-off-by: Dave Jiang --- drivers/acpi/numa/hmat.c | 28 ---------------------------- drivers/cxl/core/cdat.c | 6 ------ drivers/cxl/core/core.h | 2 -- include/linux/acpi.h | 12 ------------ 4 files changed, 48 deletions(-) diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c index 5d32490dc4ab..5a36d57289b4 100644 --- a/drivers/acpi/numa/hmat.c +++ b/drivers/acpi/numa/hmat.c @@ -367,34 +367,6 @@ static void hmat_update_target_access(struct memory_ta= rget *target, } } =20 -int hmat_update_target_coordinates(int nid, struct access_coordinate *coor= d, - enum access_coordinate_class access) -{ - struct memory_target *target; - int pxm; - - if (nid =3D=3D NUMA_NO_NODE) - return -EINVAL; - - pxm =3D node_to_pxm(nid); - guard(mutex)(&target_lock); - target =3D find_mem_target(pxm); - if (!target) - return -ENODEV; - - hmat_update_target_access(target, ACPI_HMAT_READ_LATENCY, - coord->read_latency, access); - hmat_update_target_access(target, ACPI_HMAT_WRITE_LATENCY, - coord->write_latency, access); - hmat_update_target_access(target, ACPI_HMAT_READ_BANDWIDTH, - coord->read_bandwidth, access); - hmat_update_target_access(target, ACPI_HMAT_WRITE_BANDWIDTH, - coord->write_bandwidth, access); - - return 0; -} -EXPORT_SYMBOL_GPL(hmat_update_target_coordinates); - static __init void hmat_add_locality(struct acpi_hmat_locality *hmat_loc) { struct memory_locality *loc; diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c index c891fd618cfd..bca1ec279651 100644 --- a/drivers/cxl/core/cdat.c +++ b/drivers/cxl/core/cdat.c @@ -1075,9 +1075,3 @@ void cxl_region_perf_data_calculate(struct cxl_region= *cxlr, cxlr->coord[i].write_bandwidth +=3D perf->coord[i].write_bandwidth; } } - -int cxl_update_hmat_access_coordinates(int nid, struct cxl_region *cxlr, - enum access_coordinate_class access) -{ - return hmat_update_target_coordinates(nid, &cxlr->coord[access], access); -} diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h index a253d308f3c9..0476c3b648de 100644 --- a/drivers/cxl/core/core.h +++ b/drivers/cxl/core/core.h @@ -137,8 +137,6 @@ enum cxl_poison_trace_type { =20 long cxl_pci_get_latency(struct pci_dev *pdev); int cxl_pci_get_bandwidth(struct pci_dev *pdev, struct access_coordinate *= c); -int cxl_update_hmat_access_coordinates(int nid, struct cxl_region *cxlr, - enum access_coordinate_class access); int cxl_port_get_switch_dport_bandwidth(struct cxl_port *port, struct access_coordinate *c); =20 diff --git a/include/linux/acpi.h b/include/linux/acpi.h index 1c5bb1e887cd..5ff5d99f6ead 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -1595,18 +1595,6 @@ static inline void acpi_use_parent_companion(struct = device *dev) ACPI_COMPANION_SET(dev, ACPI_COMPANION(dev->parent)); } =20 -#ifdef CONFIG_ACPI_HMAT -int hmat_update_target_coordinates(int nid, struct access_coordinate *coor= d, - enum access_coordinate_class access); -#else -static inline int hmat_update_target_coordinates(int nid, - struct access_coordinate *coord, - enum access_coordinate_class access) -{ - return -EOPNOTSUPP; -} -#endif - #ifdef CONFIG_ACPI_NUMA bool acpi_node_backed_by_real_pxm(int nid); #else --=20 2.50.1