From nobody Sat Oct 4 03:17:19 2025 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ACEA280308; Wed, 20 Aug 2025 17:56:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755712599; cv=none; b=Arf5NkiItf+0xL1vTbwcn6wiuXbhaHL755A8GL4vpNQ6obW6lALbvbGk8RLPLw7n3kJGrbpnQGdAh/GcclpRAa2iR2Do5oaWROUGEOmuzCBI5QSUCRVshDIE3rbdcySulgOZ2Wp3h8PhyrM5zS95bRZ5WsmKRddb7jR65CIufaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755712599; c=relaxed/simple; bh=lLfmta+h4SkyENDhCMnpdr51VJu3AKvH01fLUD8umjs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lIWIhf1YKpQnCJ2ijKwFr4S5q5/4R2wgq0+MAajD3ahBgSAbS9P8MbtpJ0GSIwFlxIJ2ZDBOmO62QZbpkJCsHLNeojkQfFd1ju8OaP26MH31cKoscaikfHGmV79gqj3IkLUakXOPEH64w5tB29GHs0aSPnoO8pOS47o0WX9HPsA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QlCEfWwV; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QlCEfWwV" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-244580523a0so1281515ad.1; Wed, 20 Aug 2025 10:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755712597; x=1756317397; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H+38vPXKcE2XwH0KgIp2x58rU9vDQLzRiLzmYeUQXBI=; b=QlCEfWwV++Oz0XpjNI5BhGkCyyWDx+gjVjcahTt018CN4ASsiUgKf+8422U9Ey2t8f wawhCj0Z3chx/82zEQh3QEcJLUMlHxtsXuJN4oMBw7c8H+vRgibI718aNJsLkYCfcDdS lJyUt6VIJywwOMs7o+yTG2uUHKyMnMVs8ZQDO0u8rfDIi9J5P1j477hgF2XD9YrZBoB5 EgBSZMmt9YESS7aKFDjbxjZ52NEZtLY7PLD4e+B8NXGsRrYYT2nXiG6zY2M23x7JWiOj rAKLjm2Q5e9jCoogSgUCHAI+QlEukxQ3V/b08sixe9Y28pzbVizVm7uvEBelIDizW6/e ysRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755712597; x=1756317397; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H+38vPXKcE2XwH0KgIp2x58rU9vDQLzRiLzmYeUQXBI=; b=d0DZuJDYnqMQzbOqDYgR+E2Kov7h/2eBlTZHKIpBypMKd28440nqKgEnvXszfqaVwC LrgdQP12KsWkJlzplpAKO4dDN9Y2QnNAO25ingZgPPQvbhDJO3nFT0oStkOdSa3DaYim VSrGDVD9WwCz3gMFbj4HikyrITDvrupeMZoBnx33ZqWv/jskb4YkXCLwwIy34LIcAIeu Y4F6d/nFmIfRCBdcoIjXWFF18REZwi+8Fuk/+7p/kNtxVwbpszmReowcj92Q2us1cMEd YHetF4olO9ra5Wvh5u+UwOS9IBTFytF28sdVnuA1gPG1A1rBIt2e9TvAoVmrLHaLIxG2 g8kQ== X-Forwarded-Encrypted: i=1; AJvYcCW9tYjS+YgvVqd39JQd3uGLCGBuQgwsyo2GLQIjXrEaAsDsN67xFNz62aqcXPQOwnWfU9KUYNrwTdDGbbY=@vger.kernel.org, AJvYcCWH+jAXAsMhwnYlwZEZNg42IwqRXw3PeDD6kgc5oMO9mT5r7Y+lbzSFUvfVQ94CZUzoLU8Sc9HHQ3X1Hw==@vger.kernel.org X-Gm-Message-State: AOJu0YxYEQ28sHDJr8CZAdbeVzplnFBJvUqO+eL5O+Ouj5p3kSdGlzIB yoQau1Kj9FFOx9+vXPaG2Jd2CULTtB0q+c/HuOzPvo5+NczrCeQTra8= X-Gm-Gg: ASbGnctqrXajTHSjwfFR4WBt+Njkrov3Vj+Xo458CNrVBOxcTmZxO/+mJB4mPG0LP0U bF8X2gr3awa1ZQexFnHhEfkdIumBIVu24BusYAVEYAY3IfSbnZ4BVlMAza1KQYFfRJCH79czSWv In8nfXLUY3glg0v8CPi+po5rjVb3dz0oMCtLqx8/5ViPW4m1td2waz+U3DDIXpoPow32VFa2unC XUYa08Jn7k2cLzCbWbu09T1D/xMTf0SfGoz6cLCmYhKURxXsq/LiV5RBKIJk8mXDFgBVL1cBxuo /kPyr5GmSAdlYCb+K0OGTOqEf24dfF69pK7JxDvBVotqoxpU9cWfkLoY7O0Jcb4hXl5g8tRds9J UFkbJmh0XuKxED1Xs3vuq5YdD3q0FkoZZ X-Google-Smtp-Source: AGHT+IGOFAhBd7MGUiftUnl9fbiq5WDVmusdQ49YdOIXSr9FdK2a+VkS31ZeJvULUj4TqUOJvUU3zw== X-Received: by 2002:a17:902:e80b:b0:237:e696:3d56 with SMTP id d9443c01a7336-245ef22f57amr59998195ad.32.1755712597270; Wed, 20 Aug 2025 10:56:37 -0700 (PDT) Received: from debian.ujwal.com ([223.185.130.96]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed4ccaa9sm32553815ad.86.2025.08.20.10.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 10:56:36 -0700 (PDT) From: Ujwal Kundur To: allison.henderson@oracle.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Ujwal Kundur Subject: [PATCH net-next v2 1/4] rds: Replace POLLERR with EPOLLERR Date: Wed, 20 Aug 2025 23:25:47 +0530 Message-Id: <20250820175550.498-2-ujwal.kundur@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20250820175550.498-1-ujwal.kundur@gmail.com> References: <20250820175550.498-1-ujwal.kundur@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both constants are 1<<3, but EPOLLERR uses the correct annotations. Flagged by Sparse. Signed-off-by: Ujwal Kundur Reviewed-by: Allison Henderson --- net/rds/af_rds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/af_rds.c b/net/rds/af_rds.c index 086a13170e09..4a7217fbeab6 100644 --- a/net/rds/af_rds.c +++ b/net/rds/af_rds.c @@ -242,7 +242,7 @@ static __poll_t rds_poll(struct file *file, struct sock= et *sock, if (rs->rs_snd_bytes < rds_sk_sndbuf(rs)) mask |=3D (EPOLLOUT | EPOLLWRNORM); if (sk->sk_err || !skb_queue_empty(&sk->sk_error_queue)) - mask |=3D POLLERR; + mask |=3D EPOLLERR; read_unlock_irqrestore(&rs->rs_recv_lock, flags); =20 /* clear state any time we wake a seen-congested socket */ --=20 2.30.2 From nobody Sat Oct 4 03:17:19 2025 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0BC7277038; Wed, 20 Aug 2025 17:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755712606; cv=none; b=RlTpfGSf/izRgySxA8StwEfzpHnLgPelnsC2W6GIkRYaMMA/gV+j2/yfZ70xFbR8CqFsBUYn0TD41VosZ1q5aFSHUmkC45pBBg9FHxAe6Mlr1lT/br7fSvW2UX0I96ddNCU2HPxCpNbVDjP6773YhYZNPxKqLAWSBkYEfQJbQ24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755712606; c=relaxed/simple; bh=/0gzM+3hdedGfBPxBtBaiKUwTX9q1lzp1I1KRqZW8+s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ogsSn/VElfu99PCu0/HXx/5JzmNeR2ScSpa4bBD8q9gSQYjZe+SEW1LvT9OY/NMDQ89ctUZ2eweR0H54sOiexG29mr1ZGzzYnGIWE1tVSHZOc3GC5UiStaVNe6TzjCupITIeoZdbghANqX/Uob8qIRDEs09Gf0SVejqCQnkzqWo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QPuvGeFZ; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QPuvGeFZ" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-24458195495so724805ad.2; Wed, 20 Aug 2025 10:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755712604; x=1756317404; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sGLb0vaI51LWFzVBHuMu+Aqd/KzmZTAIpd9FpNIGaCw=; b=QPuvGeFZEbOe4sQxozPYoEtqAOxuz/3IAR7CgEvglrLTaE9EzWqBBcTx+daDdToW9o /k29qr3h+ZTHxYJ34XsRDlxqk8wkIJodmEw6w4dT8MviYhkIZb5hfJmU9O9rFybCHSmG g/neDS5+XcQDiENfVeliDTY54j2EluJ8bSwdtqhlcVJ9WKd/NB2zuyKQb9UhfQ5aiytI 4g4Srxrn89KMZIyZQHict6DoUj9I8mcvlMYKsbwPPjNo4i6m5A5774qa0pi69U4t3mLt eXYXAnfGsbyYKWnpE3IUlcSNIIfkugFnMDk90w5CNUduBWw6qXQjsUgmHbTM7CQXbTrv pMEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755712604; x=1756317404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sGLb0vaI51LWFzVBHuMu+Aqd/KzmZTAIpd9FpNIGaCw=; b=mREiixgBh+T4rEwSofv531ZaHNxCx/3eNrBa0zX7Jz+kWTp+XkV6mXnoj8yo/DJt5d kSzMH8mBUwkgl7CBo26uFrAOaCB/16SLhPxfQYUv2AHmvNpKXm5QKC95e1XwHBVmRDgR 3DeHsxqTfJ+dHgbw7izLwR6A6INm0C+7x+PdFnQnLypeFdj/ztIU2/B5gbabVwtWnIwI qCdj+QOiPVOPbx+2OkCvef7Qs2RT+3oxonqy5KYKufkEAaiOog16DFgM3iORXT89E0/H RlhedQT/xNWDipB1zu4v2MWS9ZH5r44Z6aiNRkI/dbPxwvVCxbcGaPBJcfkMbrnX2Kt+ A0ug== X-Forwarded-Encrypted: i=1; AJvYcCVbzzsEt44x9GYCO/uwMa1JhD1XC8HKMwy3xYiFvwywomGdRQe0rEnktEjacmm6krGNpnqIdFpY4jd2MHE=@vger.kernel.org, AJvYcCXVxj+GcFkMBua8GLtzFZtkoijG9UItVb7VDElYBm8vKzpCXnuze261xUJ/LZGMdpDELBuGqZXHqqlj+g==@vger.kernel.org X-Gm-Message-State: AOJu0YwbsyEfbQC3V4Ah0JhjnId6H1kAN+hH5Z+HyumyUk1E/n4tBTHW ySSbeYEN6IAjKXsmrYjcQNn/lTBSx+L2jKzxKbJ0ibLMc1d98gMRBh0= X-Gm-Gg: ASbGnct8YEr1UsYmvqyuF5zDvDeKjT7s49dOD8uu465zqkGAdFBCfy2xHx8gRY8TK3Y 17CODtxTNFPHadiU4u6Xlaq1B1h1I/CNIs7lPZrK+MKFVmlkSp9Up0HLzuDRYZ8Em1NabIJbq6b HA9QNxL2U7YKlUHdkZ9Ltf7gapx/QisjwsG/uewBM9rR9F2fUgqRlOPqxIG+3S49o38OV0zNyzh UqCq5KQdE82kCdzgJLOVTX4fE6Mk66AGvRlHzQRWit29TkHcqa0mPPIbe77NGa1RoHyLROxBCUd ZU0ddrQ+1NbbHAySENc0qGIrNJDOUMWhN4Bx5ieuJ1PCXZPVGq4mRq8fPt9PCWkV8EgsiS1M/4B 4IpGKeWJKr/8biKV0sm3NQBygX4iRoKCaxiU/m1fzbXE= X-Google-Smtp-Source: AGHT+IGPtz2x4V8T24dPaoqPFFBquGmZtrJlTAYRsxhSzc2q+oMKFmBMq/AEpCOimnGu2SqlqkG7cA== X-Received: by 2002:a17:902:ef45:b0:245:fbf8:dd0b with SMTP id d9443c01a7336-245fbf8ddefmr8250265ad.57.1755712604073; Wed, 20 Aug 2025 10:56:44 -0700 (PDT) Received: from debian.ujwal.com ([223.185.130.96]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed4ccaa9sm32553815ad.86.2025.08.20.10.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 10:56:43 -0700 (PDT) From: Ujwal Kundur To: allison.henderson@oracle.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Ujwal Kundur Subject: [PATCH net-next v2 2/4] rds: Fix endianness annotation of jhash wrappers Date: Wed, 20 Aug 2025 23:25:48 +0530 Message-Id: <20250820175550.498-3-ujwal.kundur@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20250820175550.498-1-ujwal.kundur@gmail.com> References: <20250820175550.498-1-ujwal.kundur@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" __ipv6_addr_jhash (wrapper around jhash2()) and __inet_ehashfn (wrapper around jhash_3words()) work with u32 (host endian) values but accept big endian inputs. Declare the local variables as big endian to avoid unnecessary casts. Flagged by Sparse. Signed-off-by: Ujwal Kundur Reviewed-by: Allison Henderson --- net/rds/connection.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/rds/connection.c b/net/rds/connection.c index d62f486ab29f..ba6fb87647ac 100644 --- a/net/rds/connection.c +++ b/net/rds/connection.c @@ -57,16 +57,17 @@ static struct hlist_head *rds_conn_bucket(const struct = in6_addr *laddr, static u32 rds6_hash_secret __read_mostly; static u32 rds_hash_secret __read_mostly; =20 - u32 lhash, fhash, hash; + u32 hash; + __be32 lhash, fhash; =20 net_get_random_once(&rds_hash_secret, sizeof(rds_hash_secret)); net_get_random_once(&rds6_hash_secret, sizeof(rds6_hash_secret)); =20 - lhash =3D (__force u32)laddr->s6_addr32[3]; + lhash =3D laddr->s6_addr32[3]; #if IS_ENABLED(CONFIG_IPV6) - fhash =3D __ipv6_addr_jhash(faddr, rds6_hash_secret); + fhash =3D (__force __be32)__ipv6_addr_jhash(faddr, rds6_hash_secret); #else - fhash =3D (__force u32)faddr->s6_addr32[3]; + fhash =3D faddr->s6_addr32[3]; #endif hash =3D __inet_ehashfn(lhash, 0, fhash, 0, rds_hash_secret); =20 --=20 2.30.2 From nobody Sat Oct 4 03:17:19 2025 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22905261B70; Wed, 20 Aug 2025 17:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755712611; cv=none; b=o4//ormQSlnh51rkHFeFElrRNw7iYDkTo8e1egEnx1eW/Q9zvixCu/teceEdJCbEGgzZhefi1Uwc6vvU/qbAL9egCehWOmYJgVzG6+z4UPsLRw4A48QrydtR1Jz1ITqJbn9Rfdd1vVSSCRtIXfta+SuNknUC+x2yn7Sl3W95RAs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755712611; c=relaxed/simple; bh=ASApH1GWUpHTi/efhNeufdCGm2pBUW9xZ1TNT+zrDPc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ImGkwRffwwL3bFXIUB9KVu59DcoHQf0RQQR96FtSyyYw/CuxG+2eGFYMOTDkUeQrMWeYRMTog6myUptHO7a2rpQLuNhAuBZtGuzGZO6IjQQOJF75gzcOOcbrC5BdgXPUfKSxsS7VAhZPR/vUmWrjdCl/q260F4WRRQ5TFNrhZdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fudrG+BL; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fudrG+BL" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-24458195495so725255ad.2; Wed, 20 Aug 2025 10:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755712609; x=1756317409; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XUfPAIBLOMuv3VuEzD+BlKAXrUdUMjGmT3eWyIb7YrQ=; b=fudrG+BLfM30J8jSoQvjo3mDUG+mkIIBYeh3uyoK2LkIr0KBUxkR4QOluNr0vTwBPT HvYZ2cwX+KMq3bO8VV4BclXB9HQ1w/hWqpLw7uybFTVMXtik+DStQLcQA5Zn7tBfRIO7 Caub3kUe6c4TPMGzDjiuBdACZRf2tpOMAPpaD3vPFtyeTyxIVaFsK10kR3hJ7QdFViYY BVobW1mncfLGzfv5MmlrusfWpPdadyPqJxYngKGS3j6P4bDZLwZ993YTnU76shAnhWMY SW8lnnPh+WrqU0vrjCv/hKF90EuqBVuX138EYzljlSV8BbVzIVESjI0jmOCAs7EZIvEN IeuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755712609; x=1756317409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XUfPAIBLOMuv3VuEzD+BlKAXrUdUMjGmT3eWyIb7YrQ=; b=qlbPnHBIQ5EsWuRvH6Vxa4irUhHjh2h2AqTYB/z3A+8+pbEHRHiUB1pceabzlyeNns G2/auJ6eqjD6UfUO8P1R3NjKyDIsib++egZeYvmicmF0NsxLCPbL8prSMO7JbhlRn9OE 2R8PB4pc9Iky/+AyCr27pBVNXyatraHFJAC6YxeyzlVAt+Ta8wZBNaTuWfqs3G8SxKfc RgUaXo2agQ4kzM7tCZzy3/u6tGnIhQ4P4+OjT+IsGJywBnhDCx/yiqM0wfQ0enk9v7vt cX0o3415MY+Qj1uLC3W849T3dAFi1Nav8H8nleEt6+cRNPsjOnKGCPE0AEBUKi4b7PqA SdeA== X-Forwarded-Encrypted: i=1; AJvYcCVhzxzWDmnZAWT7w1JherCQPNOONpUhbp6H0/9tZO4Fl+O1LonknC3TkuZdbC7HDQVm/wZsx7AyZy/6r7U=@vger.kernel.org, AJvYcCVtXcjQtIeB4aPAZnz5RFsVPqF0UzfxDuJ8fvKddDsFxjUcAIRv8d3g8F7x7YpJejdcBDB6T6kS6B+3Jg==@vger.kernel.org X-Gm-Message-State: AOJu0YxVKWbTTbViKJA9gB/aS/kMDOyxTUKI92C9pFpM4iZ/pYU3Ho9g GTH5wztyNazE1GX8nA3T+FZQ3LVPYHX/1ILQviPY+KhImVxMdZ0dC8RiQ4BNlxM= X-Gm-Gg: ASbGncsxpM1/rwlBuwJM6t+fAjwFB8ikoQHaA+3sJqY4/vgiyikRDKv5miUa58G4A5i 3otSE0V7fXDetBQ0RM7y6aalYlGfhieo7942XgAKWvMf7vIm4MsZqbiBH8QrE20/Q7+dy5bttfG AcYdW5wvFr9qHQTncvtw/5kl7y58Nqj44epuSMIJm8v052DYFwUt/Q3SnkG7wYRPzPJBgC1Xb/v VcdNIyBkky8AH4o/nHkgrva9N/dBdjC6kcpYJ5svaUjJXpTeKYohOrO2UDZj59gcNxJBjDO58VS Jg4Qhc6omaH0Q/ShGmRhTx9ggNhEUfhhD6l98vliGNzYdMLZqouamYI50PnnBSri+7Vp7of2IO6 BF00V26RzE4+k6PuGwZjNr3hATgW8pjqa X-Google-Smtp-Source: AGHT+IEDVXH0aHRP4SIohfgYz+4Li9LSRgAHXtAKcAoRQGYgXrgbGMLKosDU57OSqL4UBlnHPODbkg== X-Received: by 2002:a17:903:1112:b0:237:d734:5642 with SMTP id d9443c01a7336-245ef236c61mr43136695ad.41.1755712609326; Wed, 20 Aug 2025 10:56:49 -0700 (PDT) Received: from debian.ujwal.com ([223.185.130.96]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed4ccaa9sm32553815ad.86.2025.08.20.10.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 10:56:48 -0700 (PDT) From: Ujwal Kundur To: allison.henderson@oracle.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Ujwal Kundur Subject: [PATCH net-next v2 3/4] rds: Fix endianness annotation for RDS_MPATH_HASH Date: Wed, 20 Aug 2025 23:25:49 +0530 Message-Id: <20250820175550.498-4-ujwal.kundur@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20250820175550.498-1-ujwal.kundur@gmail.com> References: <20250820175550.498-1-ujwal.kundur@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" jhash_1word accepts host endian inputs while rs_bound_port is a be16 value (sockaddr_in6.sin6_port). Use ntohs() for consistency. Flagged by Sparse. Signed-off-by: Ujwal Kundur Reviewed-by: Allison Henderson --- net/rds/rds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/rds.h b/net/rds/rds.h index dc360252c515..5b1c072e2e7f 100644 --- a/net/rds/rds.h +++ b/net/rds/rds.h @@ -93,7 +93,7 @@ enum { =20 /* Max number of multipaths per RDS connection. Must be a power of 2 */ #define RDS_MPATH_WORKERS 8 -#define RDS_MPATH_HASH(rs, n) (jhash_1word((rs)->rs_bound_port, \ +#define RDS_MPATH_HASH(rs, n) (jhash_1word(ntohs((rs)->rs_bound_port), \ (rs)->rs_hash_initval) & ((n) - 1)) =20 #define IS_CANONICAL(laddr, faddr) (htonl(laddr) < htonl(faddr)) --=20 2.30.2 From nobody Sat Oct 4 03:17:19 2025 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24CEE261B70; Wed, 20 Aug 2025 17:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755712616; cv=none; b=KgBBeQyUkfRm9mqA6ex2ppgcgtDiOQAI3UqPpmrOL++lv5euoZpsrOCj+oJRN9jJBnv5Hs5kFTWm/VZNWGoHAT/H5ubq7PZNm+k6tpdDwWWqHg9gbWhvQJuGL4vmjiiHzjmaC6EVw2MFcuasyR6jC/+A+jfyI76st+HKbSRU7gE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755712616; c=relaxed/simple; bh=aTVe6zIx9eeEkQY2Ki1hCOn4/af5y00QBLtcbdjCizk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pf49sOZnoacJ++q5aiYgJT0FsJ1thhE7fG0kJ5GoXVRp0OobuaAEFiDYGIegMv8RABLfK8zzWSX3wd0tMwrpB7Ctsmr84fgE7TnisaWVWeaNqbl1sc+E6DjsCLtvE9CD7xWu7ILGASAGNvlphTLHmZ5ACNszjlQ/PaVPlCYahTY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S7xEiV2q; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S7xEiV2q" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-b471738daabso78190a12.1; Wed, 20 Aug 2025 10:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755712614; x=1756317414; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h15eIxqdIwCof1MRCBcz3fgygqELtVuk+XlaIGTeo3U=; b=S7xEiV2qBMEc2bcKEAmB6MBjhZjhIrvT0ByINR3cU0dpUsDb787PTi99lt2M0ATSA/ 8ak7Cuiby7847hWr+sy9t+9RZf6XRfFpAU7PguAXki6EV0PzihaJ1pMTANfye4b17d6m 0XjmVgqi6R/GoGTJrAohdEXxlOWw+5InDK+BkMZZPcg96Xjq4ucEwshCwhoZpTYadwYn ch02zgPUWPWMafzZGtCkCfa2uNTsGhMHN9S3d1KYGY1OXuFHTg6x/zlV+L5W9+JphR2k jVRikL9LhVLDETmvjVlDuUrzlG0PEyCm/Pgt2xhtxFVPEYVaE3FzaN8rGd1m+t6OqNgi oRAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755712614; x=1756317414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h15eIxqdIwCof1MRCBcz3fgygqELtVuk+XlaIGTeo3U=; b=Xi6jQipHQKYaAkzBqEIrX8b7ndYVEOYMSfdeQ67KUd/5OfrijF3MgbZsUCNb0e6F7d Mkr3H8ooZuMtkUZKJP709P6H5MavwgFAueyBb+WGGs0EWX7RF2x7xqGOXCXzdv/RERQF 0CzkI64frcy12NzXnFvurJBc/odm2N5aPSftGclVUbYeDQBRM5xR10rW7VH0+c7bHVzP WdT+SnPllSyKsrCpEfPnKXh7g2m3FbahWaxvK3rBxZvOJ8BWirdzpS/EPQQG+dL3BCgJ QuARRoFccjUb0BP7rcZRH5qtRLp3YzqzXA6KEphZaQmmUfw5X7JMHKpqbMHJf1kkJp+Y Altw== X-Forwarded-Encrypted: i=1; AJvYcCUrkDUNZgPmz/Q07L2qesycpdkNymCpGFWtiCwvR3oqnpHfQnIlYk+YWuLuDtrOVh6acYRnc3z7Y6KQsDM=@vger.kernel.org, AJvYcCVQX6odNSShV2CzON8N4H7JkF2wsz7sPDJJCVyj3IeouY8EpHy+afzHs25L+HKhmggj9YF9Ojs2RzCx3g==@vger.kernel.org X-Gm-Message-State: AOJu0YxTPRY6o9k58wa/MQ0J8ZQ93lsKQIgZ81x2Eda+oDyE1oSeFdAL mjeyp8tU/BsI4TvRI814UTVjDn9i0dud14XGqgaGuUMhRMLYHNov32g= X-Gm-Gg: ASbGncvWr6suprcwvy0kbcPxyTGMN+Wc/LkJYrt09+ogrDeG3SbqkodJdic2CkZefSf Jkc0S4bGr+cMBKrWt+SRpdQLJmZvORu0Ok90+PgsBB5vhxI9p/8w6dL+8hSs/VFqQwt5rwItu6J /9Y0EqOkd+40ObqHO02FHaaymXh7NTKS7t42gxTjHnYCnul8hmnzmpIHSZEVxtw+Rc3pZ96pbe5 NNaQhKLkzSJtelqhY+ORZU/w3lmaRW47+8qH3GPJsFBWGWHLDt214nqklkH21BKbAnCnCDAtGjr MmKwUxVdbX3OV0f9YOBOFj94a/R+a6EqhkWD3yxTTdsnA+ADQ9sfu6C40O6bEwgRZijGDH0msfk MsmZVkyfYNmf5/mb9bc8ffkGtUHPgrZZe X-Google-Smtp-Source: AGHT+IGgy/Kot7C/NrIwHPLLQwSrbwouelo5AZzvdNv+3H683amHQAwYeqAU87DjfEX2ZQIbjOCjtQ== X-Received: by 2002:a17:902:ce01:b0:235:f078:4746 with SMTP id d9443c01a7336-245ef25bb33mr44825635ad.42.1755712614298; Wed, 20 Aug 2025 10:56:54 -0700 (PDT) Received: from debian.ujwal.com ([223.185.130.96]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed4ccaa9sm32553815ad.86.2025.08.20.10.56.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 10:56:53 -0700 (PDT) From: Ujwal Kundur To: allison.henderson@oracle.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Ujwal Kundur Subject: [PATCH net-next v2 4/4] rds: Fix endianness annotations for RDS extension headers Date: Wed, 20 Aug 2025 23:25:50 +0530 Message-Id: <20250820175550.498-5-ujwal.kundur@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20250820175550.498-1-ujwal.kundur@gmail.com> References: <20250820175550.498-1-ujwal.kundur@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Per the RDS 3.1 spec [1], RDS extension headers EXTHDR_NPATHS and EXTHDR_GEN_NUM are be16 and be32 values respectively, exchanged during normal operations over-the-wire (RDS Ping/Pong). This contrasts their declarations as host endian unsigned ints. Fix the annotations across occurrences. Flagged by Sparse. [1] https://oss.oracle.com/projects/rds/dist/documentation/rds-3.1-spec.html Signed-off-by: Ujwal Kundur Reviewed-by: Allison Henderson --- net/rds/message.c | 4 ++-- net/rds/recv.c | 4 ++-- net/rds/send.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/net/rds/message.c b/net/rds/message.c index 7af59d2443e5..199a899a43e9 100644 --- a/net/rds/message.c +++ b/net/rds/message.c @@ -44,8 +44,8 @@ static unsigned int rds_exthdr_size[__RDS_EXTHDR_MAX] =3D= { [RDS_EXTHDR_VERSION] =3D sizeof(struct rds_ext_header_version), [RDS_EXTHDR_RDMA] =3D sizeof(struct rds_ext_header_rdma), [RDS_EXTHDR_RDMA_DEST] =3D sizeof(struct rds_ext_header_rdma_dest), -[RDS_EXTHDR_NPATHS] =3D sizeof(u16), -[RDS_EXTHDR_GEN_NUM] =3D sizeof(u32), +[RDS_EXTHDR_NPATHS] =3D sizeof(__be16), +[RDS_EXTHDR_GEN_NUM] =3D sizeof(__be32), }; =20 void rds_message_addref(struct rds_message *rm) diff --git a/net/rds/recv.c b/net/rds/recv.c index 5627f80013f8..66205d6924bf 100644 --- a/net/rds/recv.c +++ b/net/rds/recv.c @@ -202,8 +202,8 @@ static void rds_recv_hs_exthdrs(struct rds_header *hdr, unsigned int pos =3D 0, type, len; union { struct rds_ext_header_version version; - u16 rds_npaths; - u32 rds_gen_num; + __be16 rds_npaths; + __be32 rds_gen_num; } buffer; u32 new_peer_gen_num =3D 0; =20 diff --git a/net/rds/send.c b/net/rds/send.c index 42d991bc8543..0b3d0ef2f008 100644 --- a/net/rds/send.c +++ b/net/rds/send.c @@ -1454,8 +1454,8 @@ rds_send_probe(struct rds_conn_path *cp, __be16 sport, =20 if (RDS_HS_PROBE(be16_to_cpu(sport), be16_to_cpu(dport)) && cp->cp_conn->c_trans->t_mp_capable) { - u16 npaths =3D cpu_to_be16(RDS_MPATH_WORKERS); - u32 my_gen_num =3D cpu_to_be32(cp->cp_conn->c_my_gen_num); + __be16 npaths =3D cpu_to_be16(RDS_MPATH_WORKERS); + __be32 my_gen_num =3D cpu_to_be32(cp->cp_conn->c_my_gen_num); =20 rds_message_add_extension(&rm->m_inc.i_hdr, RDS_EXTHDR_NPATHS, &npaths, --=20 2.30.2