From nobody Sat Oct 4 03:17:19 2025 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B62D42749DC; Wed, 20 Aug 2025 14:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755699758; cv=fail; b=TZzStOSMfH2Px/S70dJx5gmStZB7mfJpUfyLVqEEqlNvmJHJFI8SaIh8Pt7xzN0MheYtXG4f+zc+5o2QcwWJZEwq0yxwCbi4sBU7vcKbQBfBrsA41oC8dUf3YoizcUq7HMnCwqDR2IPHldsvnboZJLhDkLNREzqIA7+WXQVjTQM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755699758; c=relaxed/simple; bh=GS029dBGkUJ5wcU+SMmuG1dTaS7p3HGmvJXmbGYxgAU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=COWLvqHcML4x3NcHhbDpIggUbpNvQqP87zGd2daVheaxab81ev1e91F4520o+muyf6bBXpiuH6ON+QmHmyk4/T/J5bQWqBMfxvrKwgsPWXm9kWtVwkqiYgLPuTXwxfOBIQRibPl20EOpZlHYLQOSVFLa2UZtfhzuxUq8P7jEL9I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=HSvSH+Sv; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=do4AONlN; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="HSvSH+Sv"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="do4AONlN" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57JJZ5mq732100; Wed, 20 Aug 2025 09:22:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=e9NS5kNU27Tt7turoCZde94e0Hvdmv+pGQEiOI3SXMc=; b= HSvSH+SvkVhAEks4eiMWlSR0gAK3aTbRjkmkLpJUPo+v5tlAD6sf+uWdBfEQVKje 0h/dR58/5NHspH+iXcVBwcz5HUZIFr7nF+hFPzKKQeri6QsjUfCnubBmGoaEzEGo YJp35noxPcPPM4BvNeitaabj+TlhDq1LUdrP8AvIn2DCyWtEJj8QqG+rV+GtYdMd 2U9CnXkVV26PyomDBOyLp8WTIMTSYdlTZ0mD5Ay4e66N4wid61GUMVKH77mxf4Nv uLlIwpFLVP/iXXQFwwqYeq5gEVnyG63zZaSRQbluMjwjKGkvrdl0PGBf3xrltQ5+ scjhz1/xv8zMNNvkBlpNPQ== Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10on2117.outbound.protection.outlook.com [40.107.93.117]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 48myd59c7r-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 20 Aug 2025 09:22:33 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UFkKL9vPgefe+s3AGQlGcd1MkpPfyDMo1vhRpkTrdPvLtW39OoyoGsaGMO3NtsPpPqJeU6Kz0CfNye5SC9XS2XW4O3UZIYwMUNk8cBzZV2TS8/4ZtGF42ZSYFztgQK/xfUvnS8+A3fadyey7RRTD9FvXvO65rNytHSfIfi/Q/4aPOFS9Nr8IEdeYGFutSAebDbbXh1d05LGHHIuGpVHhUmj8tIqHK9kmGDmE7jo86o4z6N9gMMYu/WMWcsqNitSdkLYgmiGlGk+pxHgc7OVlqWn5RkfSvqXEG9vbTO5B5BQiPHyAW9IBZ2WrIw7x2E1pSiOIAXVkJbklBCx/ZN0Xdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e9NS5kNU27Tt7turoCZde94e0Hvdmv+pGQEiOI3SXMc=; b=FgF1Tx/qgVaDfz9efLdycCBlrwWZAyrJHwdvHGXwNXtYNnqml2/T69J3djD6806ks6yr+80kL9DYNPv2vknRhoNLvQWJdaZK1MJVIHbrGLSjdFxiJz+NvO+arJApZo5z9wSbhYoCio5MSXYbo646RsY6yxFg2xpBv4Iqi6b38v+YK7Miyxo1ndnLydIxPuJwyVg+Gyo72bULIvHSnpp0d3xlpaOC2vfYz3NQNI5R3gkIA5dItzi2ij5AYtPQ521+oiS1HGdskraRNH8LLq4rPmJDG/4LF1E8Yts0O5O/MirnhYmYUGQV7GEnGhcsPoflhK/qIfstG+fETkCmeHnvvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e9NS5kNU27Tt7turoCZde94e0Hvdmv+pGQEiOI3SXMc=; b=do4AONlN3wVxtpf0Hy8eBDrjRq7VRaD/imGeakOk1T5+qf8uPOtLwLmbzmKe2DFHZQJWgA9FjYlO1G0mOxkZVRQ6wb8JEueyTyzVFujNqSJ17QX2fm1HCWyqL5ibgBk5isYIniCGOFC1rTyKST2IPKOn07SgSjyA19cVO2bExjI= Received: from BYAPR01CA0013.prod.exchangelabs.com (2603:10b6:a02:80::26) by DM8PR19MB5318.namprd19.prod.outlook.com (2603:10b6:8:9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.13; Wed, 20 Aug 2025 14:22:30 +0000 Received: from SJ1PEPF000023D5.namprd21.prod.outlook.com (2603:10b6:a02:80:cafe::a3) by BYAPR01CA0013.outlook.office365.com (2603:10b6:a02:80::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.14 via Frontend Transport; Wed, 20 Aug 2025 14:22:13 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ1PEPF000023D5.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.0 via Frontend Transport; Wed, 20 Aug 2025 14:22:29 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id B68A140654B; Wed, 20 Aug 2025 14:22:27 +0000 (UTC) Received: from lonswws02.ad.cirrus.com (lonswws02.ad.cirrus.com [198.90.188.42]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 8EC3382024B; Wed, 20 Aug 2025 14:22:27 +0000 (UTC) From: Stefan Binding To: Mark Brown Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Stefan Binding Subject: [PATCH v3 1/3] ASoC: cs35l56: Update Firmware Addresses for CS35L63 for production silicon Date: Wed, 20 Aug 2025 15:22:00 +0100 Message-ID: <20250820142209.127575-2-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250820142209.127575-1-sbinding@opensource.cirrus.com> References: <20250820142209.127575-1-sbinding@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D5:EE_|DM8PR19MB5318:EE_ X-MS-Office365-Filtering-Correlation-Id: 52924fac-1db2-435d-66e2-08dddff4fefb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?u6WG3YpSmr8WXVXjL9NhJrp4wL104Rnt+Ur4x54kfwIbl5qdzIGvaSLmOLl+?= =?us-ascii?Q?7lLlMLpJB0TmyNwPfsmmLaLbxSBG7vnbrqgZyJYUEzGcix7Zf1+/vP/A97cT?= =?us-ascii?Q?Z/P7Kqv+b1skhpelI6i+5s9eKQBl5uHc3Ki3Sgn+4pzP3jDMqoJsvklm3F8U?= =?us-ascii?Q?RaEF0A2P1kDmq3dbTTdctpjWY5fbMr1aXt4cdo4YdDt1OKQsHQknN/glv/fL?= =?us-ascii?Q?LAt88KkGwN9l7g6r8Fl2L7gfsQILxF3HKXBNYZOzmoX+DyZY4IVT+ySkQh4y?= =?us-ascii?Q?8f/KE9zJJxMoFmn/QsX3ByxrlNWwi7LKsA0tNYBw85pqxU6CadySYR1aJZfj?= =?us-ascii?Q?DXkC7wmdSXIZfn7/LA+8rrJVMb3IqmGwlRPI1JpRGydIL0TewSoraWJ1983E?= =?us-ascii?Q?/vb5JGZ/hbkns810h8gR4V7QV5saVTBTLQtzhBFw0DZtbKNgYsHF7LCE9r/P?= =?us-ascii?Q?DvOXDV8QnBoxeut1NTOaJzoiPWGQoMaTHaxLGu/orU8TM6oqKWw5kS3tDE+S?= =?us-ascii?Q?w6NMz+5jQbBn7CWeDjXG7CnflUsuPpEJ51WZL1S65lCJp+DYz9jwXLRvq6R3?= =?us-ascii?Q?YN4RZ3FJ4sXuRLm7WuROxIHT8pe3ZZ5YHN+AAHtgsnU+tlVOZ0k+OGFqyFhn?= =?us-ascii?Q?+gNLdqQkXqWcV0X1gmyHZleNWuVlSrP0aU3Qiiq8vTtbNff1+dUyAJCVU81B?= =?us-ascii?Q?njUxguylHsH9rA1ktf2kaL24zsFpPghEldktXDkTXcaigDMkaF7XSh7KznTF?= =?us-ascii?Q?wOX4ChEs3U8JXv6bU0aXXneHc9uNBgqnAPZ0OX40BTkMbxSB7vk7Exa15l3a?= =?us-ascii?Q?MjXExgekK6tVsz6oCRV8yPEyH4y2hvQDPH1xZri90XKU3VkdZnGNBTmR8z8z?= =?us-ascii?Q?oMUYrfGro42BUkK1J9JFVAPyH822+Z0AFAgLCY2+WL8nyK1ZNNV4SONi2aMs?= =?us-ascii?Q?xHcdcVpiF+8qlFWfo7I1b2ugR59c/AWgmna58mlbToZ39NURQBVVMlE9zasw?= =?us-ascii?Q?ND8hZbxUggYfSdNHygt10F4jIfSZF+HjTUkDf1Ls0nTIh0zci71NHk+YbiJt?= =?us-ascii?Q?KHsXLWKs3ScMauPS8UQEx9mwg7ebcjCfQw4MEjNik1txUOzBVRz9MNY6f3dB?= =?us-ascii?Q?fnBpcYgJKsfqH7uC0FxMh0RilxpreWl6k6+p+s3PBQdTffKOJA/5SiQb9FEZ?= =?us-ascii?Q?SURlp0Arn/goBly+096Zx6LS9IzpfryZtecXeGtn5UgaIbW7gz/Eh01auogg?= =?us-ascii?Q?UW8KgM/Nm+rmuNxECajSLfhrdun5IBfL3XjcFUzBZbyDPgiaPkunK6vUw70l?= =?us-ascii?Q?xE+lYgd36nJB6gO7+O/7E0dN3vFxix7ENqN1G/ASPYGNbMVhnpsNqHZJciOX?= =?us-ascii?Q?gDXmlZsd70W5KT4oXXoKij1B7wMs43iAVhflJNXZSIcJ95hqmwJJOyv6BvRG?= =?us-ascii?Q?bbhBY4zxdHWg3j3owsr7WWjMW4BG8j9TliqH1R+56r5eP0fH/hB7XihSzRnk?= =?us-ascii?Q?7v36ltJphtHW+WKY8vrIJ4NVyhKBoGD9ypbJ?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(82310400026)(36860700013)(376014);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 14:22:29.6037 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52924fac-1db2-435d-66e2-08dddff4fefb X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D5.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR19MB5318 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIwMDEyNyBTYWx0ZWRfX2gB6X40ni9tx kXefR5nCLAuHOKVsxKji64Kb/0WXytnQ8Xsm8CE+wf66YibgVvOoVTHJFsacX3P5YEUf7vKn1IM cy3ZLfo091QL+cji31QaSPi1m7IxpN5i7R+6SFi7NxwMRvZPIgYqj2wPWxbv1tu9EZEV8Qx3mKR nUYWeT8zFl/ckRoqy9RbWbtS9+w05eAr/kooQ8xGMZtQ0XMqfZ0oqVmSmIBrxaASb9b3Cu72lkT DhZspo6mjZnQvXLhDhDPxDJh675jOqhdPk+KUBz6OC0SpffxF6+F0AmREAke9TR3HDcz/uZF6uD LDdQA4MnHeXlFBjsGybxDydrHV1y9LnC3IMCUTI6EHDCunxVTr9FJ/Oc8zOYSpej4W0ylYfZdu7 m5X+kr+Hr765Cm747bmZRMjibx5NTA== X-Proofpoint-ORIG-GUID: k8VMv5mjsDTfGWXjHS5cvQtUeHzl7km7 X-Authority-Analysis: v=2.4 cv=EpWLbScA c=1 sm=1 tr=0 ts=68a5da29 cx=c_pps a=V5ewXRdnxiNdZ1vyn/l0PA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=2OwXVqhp2XgA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=x4YA3FrS6Vl5HCi3FGUA:9 X-Proofpoint-GUID: k8VMv5mjsDTfGWXjHS5cvQtUeHzl7km7 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Production silicon for CS36L63 has some small differences compared to pre-production silicon. Update firmware addresses, which are different. No product was ever released with pre-production silicon so there is no need for the driver to include support for it. Fixes: 978858791ced ("ASoC: cs35l56: Add initial support for CS35L63 for I2= C and SoundWire") Signed-off-by: Stefan Binding --- include/sound/cs35l56.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sound/cs35l56.h b/include/sound/cs35l56.h index e17c4cadd04d..f44aabde805e 100644 --- a/include/sound/cs35l56.h +++ b/include/sound/cs35l56.h @@ -107,8 +107,8 @@ #define CS35L56_DSP1_PMEM_5114 0x3804FE8 =20 #define CS35L63_DSP1_FW_VER CS35L56_DSP1_FW_VER -#define CS35L63_DSP1_HALO_STATE 0x280396C -#define CS35L63_DSP1_PM_CUR_STATE 0x28042C8 +#define CS35L63_DSP1_HALO_STATE 0x2803C04 +#define CS35L63_DSP1_PM_CUR_STATE 0x2804518 #define CS35L63_PROTECTION_STATUS 0x340009C #define CS35L63_TRANSDUCER_ACTUAL_PS 0x34000F4 #define CS35L63_MAIN_RENDER_USER_MUTE 0x3400020 --=20 2.43.0 From nobody Sat Oct 4 03:17:19 2025 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A93A2741AC; Wed, 20 Aug 2025 14:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755699766; cv=fail; b=N5mK1liFkaZAa7yTpDPxa4VkNcj0Xafoff9BnlFMgOosb5cwXfeFZqri3YdD/jHItlhtXB6GSIyzKw1SA+bzmF5iq0c51gVocVwgyuaSjaTJo+k11yc18EQZlRsSk7TLJ/Wz0Ll9McM0ojrfQN7KbjYdWN0btptwf/hqMG48lFQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755699766; c=relaxed/simple; bh=1aF04LqeDYhade4IlSElf4Kbs6qc2PrKpWaN4Ufv+Fg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G72BqehKRgI+jKbwS52YcNDCImHWEBkBU2DGCmZdSvVoKk/7TeyA+dLGDdQ8O95TfMWyCq1c2BMPsoXLi6fpZ0i/HHWXm7ex1S1lEnX0dcAJww1FjDeNzRe+X0bw3xpg3l7M15wTGnixZmrfpzF4Zl1RB4PEGMuVMAUnim1r9+0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=e6FLPsV9; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=Ujz3a1ZI; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="e6FLPsV9"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="Ujz3a1ZI" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57JJZ5ms732100; Wed, 20 Aug 2025 09:22:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=fXRsSiCzZMCsTmzpE4I1P9xAb5YwzDqs62e33loq6nc=; b= e6FLPsV9pg9bk4FXfSK0N44HfdfsHIqjO+JmHsIpyHzVeiDNa4j2HlzLDg32P2cd NiHR2cXWmZqFneZM2kiCx4mRm8rY+LAhkXik7AKeGqurPMr8VrO0wA5zzhqGKifa qwqlt9jHjlcRvbzXgem7zUoHpDBaUGxOzBlHkf/tAMJ33H/yF/jY8+BwwMJksRbg 6EIhhgVkUTZDkj9WQ0mH/lKzQtlsvpVqsKALt3uuKLkExUi66ntPL3cmPG+4nFj9 +9EUTFcrEfe2rUsHHawNfe805qP/rwshs7KPsjrk03IfLk8sSY+laAkFKD80+gES gU9TqgG0ijGphTHmulkD+g== Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10on2125.outbound.protection.outlook.com [40.107.94.125]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 48myd59c7w-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 20 Aug 2025 09:22:41 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EYRKSOn80bk7iM5tQH0jsoqOg0/1Boed4aoXGDDjUstFKlc4zhXYg15hUNww23zjlZ92wsPL4CRj9ABKpIEY2DTAl8nwFjPjVDWouHs1AiPF0Qo9yBMSuI3ruxICwjhufb4IMCcnnn2E6hzT0TM08l5qDIxof7y67JhlSv7HGcIxZ2D6ottEwnAPZp5zP0U8TYkVtT37fHweIzoxLJEtFa86agzTgvH4Te/Hm9TScr6kwhP9wpD1gS3ltVdQdgFe3TifACO00m9iTgr4nQVFLgtPkT+e8D3DMSzRtQZQ3/4SAAA1XgYTNKyfUMmh9EB3zu2PCEuddSFQzoMokbfE/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fXRsSiCzZMCsTmzpE4I1P9xAb5YwzDqs62e33loq6nc=; b=Q/aoHvtRMvFOYvenwQGGLA6OZFbEtRBr1NhIi0d66HJNkEO9klYUKuV8YfqztfPfETqKQWLgbFSUbVM27GqlxUf+e1WFpY4fc7OyJu+nfg3ZJgIWjvxX6tjJEd/vbrJQN/uDSr7eO5aCUJdJNUXErT6WGzMiEG0TmfSXrogQihASGJrj6q8xlNzW/vd4W7NLuCfOdWg3AluC8h5+zf6WKEe+kb7VV8XhDitFvH/n2qfKmLKEb4yjpLCO2tKP2WE/X/4LyBhep8MTN5ij/hXgHz+c50Iu0EVg1bhgEBMmVq4DO4gv6YRkLna0RcJfpM4O+AzF+9BMgoSSIPk5qha/iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fXRsSiCzZMCsTmzpE4I1P9xAb5YwzDqs62e33loq6nc=; b=Ujz3a1ZIpojRkZmoyAOGOeNvNMLDVbWk2PLNRM/wGv0oQXggY9A7jHUtuv0JY8gAX4yPT2OboRa96prSrJ7fWxGW3ukcGUN6h6Kx6dGWETKQwCOBdurD3eKiF/G41OcWxyUQpW0hdDbop786UyxcMBQt2k/SlhmxsDoiYrcJqko= Received: from BYAPR03CA0020.namprd03.prod.outlook.com (2603:10b6:a02:a8::33) by DM4PR19MB7882.namprd19.prod.outlook.com (2603:10b6:8:18f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 14:22:31 +0000 Received: from SJ1PEPF000023D3.namprd21.prod.outlook.com (2603:10b6:a02:a8:cafe::f0) by BYAPR03CA0020.outlook.office365.com (2603:10b6:a02:a8::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.14 via Frontend Transport; Wed, 20 Aug 2025 14:22:30 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ1PEPF000023D3.mail.protection.outlook.com (10.167.244.68) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.0 via Frontend Transport; Wed, 20 Aug 2025 14:22:29 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id E3FF3406553; Wed, 20 Aug 2025 14:22:27 +0000 (UTC) Received: from lonswws02.ad.cirrus.com (lonswws02.ad.cirrus.com [198.90.188.42]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id B922482024A; Wed, 20 Aug 2025 14:22:27 +0000 (UTC) From: Stefan Binding To: Mark Brown Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Richard Fitzgerald , Stefan Binding Subject: [PATCH v3 2/3] ASoC: cs35l56: Handle new algorithms IDs for CS35L63 Date: Wed, 20 Aug 2025 15:22:01 +0100 Message-ID: <20250820142209.127575-3-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250820142209.127575-1-sbinding@opensource.cirrus.com> References: <20250820142209.127575-1-sbinding@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D3:EE_|DM4PR19MB7882:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d558659-08b8-45b2-a58d-08dddff4fef5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?uSbIgbUMr92KhZbAhwW2Fkxy9dPanTA1vDMV6xmPFtuZ8Am0Cb0MLKzUSCNL?= =?us-ascii?Q?SqrDX7SNE1k9s1H9QMrUU2kDfs477HkRIxb02k87tAshTcI/G7DpJUEO8uiP?= =?us-ascii?Q?Hm9NZSjgErT6LcvO4IYOsFw9bZgnXOwj/L03L2TEv5wiE65o+uc/mM+MskU3?= =?us-ascii?Q?8uTawLRLNw0rAS8Yv0CDYd7NTs+6XlmVHBA9UKC8jIcpo8crQrRlnbAb26rq?= =?us-ascii?Q?v9CkCdI0f/Sjlk46SQiWNBmWJmVJ12mN4uQzTZbhBdth8pajmYrlvIw7mv4O?= =?us-ascii?Q?1AjaOvv6wp1aCJAVezv2IPIIWXT1hLLieBDwFtYKmHe5/U1YkFe50k/FQR33?= =?us-ascii?Q?QMcMlO9/y8Fr8HWrnEAevbi4axy6g249qKXWWg+rqmreQgZ5vDUHVzyztxBh?= =?us-ascii?Q?g4jPke/XnCMHWjbbDZsZI0CoOTF8Fve5hiFXqKj44GE53QZamywGf9Gb6UjH?= =?us-ascii?Q?FBpEI6r/jjF/PKRB34FczrwnMOTEANDNwEziSVMXRFGl/FWbUK3lbazmszf8?= =?us-ascii?Q?M6p4Z4O9q0InOAJ732hWDSU+23PuMC+pfWxWyHO5suEYjyr3DJZqP5AuqcL8?= =?us-ascii?Q?KuN++OeFXDPZr2THSd5ebhpg4yWDUxO1YLbBtCPwj5wBrVzTa2/IIWdn+Toe?= =?us-ascii?Q?PxIi+17b78GLwaBeufwZOKS5TXFgsGBU+WZnhjlKv/awwfXkQwhNxEMZqlKv?= =?us-ascii?Q?Gn9AUzukwjGTTBg+Cv9tR5AcDOgFUMUTZ6+WJrBGjaWDo2vEKd5VxNFyV7yV?= =?us-ascii?Q?R2tOV+TBIUQDJflw5mKuiDMnWElBwjgSmInb/KI2z+0tzoDjKganG9pykLiy?= =?us-ascii?Q?aUqNDJM67ZqphPTHecbwbHfSSgHp6XxAUJ0B2P0rdx79ISKlBkfU3ifWftMC?= =?us-ascii?Q?elmej7xVM4O48ZtK7ekjxeynJAgiBTfrWxgXtJiU5DQNpMoib9ilLjsDJO2H?= =?us-ascii?Q?IQzltVOvfzNL9GjwDks48E0UYcq12dZnq/77c3/2wux6notkJby9dZqeb6DC?= =?us-ascii?Q?812cUMeruSW5eMe0g5//q4+kZ5082x775I/sdfhbr6nawMrWYleOh+GYmxC/?= =?us-ascii?Q?fQM6XMN7FlEB74oA8pkarSd6Dr05mBGe6L95jAOWF2UWdq9ou4aWFpGoyX4X?= =?us-ascii?Q?mkMBX6p223ZqlYCn2rBcT97ekGsgxVvlLF4t7z+cW0NAYW1D1wNHZj03wVic?= =?us-ascii?Q?IZWyq4KakOLq4QAw372Y0DJftV1U0LW1vyVRTVk2cpSo9UIdaLxUl9aU5TVz?= =?us-ascii?Q?/o+Eqn4EDa9igvQJA42L2yIocI0UkPE5PX18UbwQeSwRu1qCy25Q2i1jGexc?= =?us-ascii?Q?i+VzhuGCyDwK4Bb9qndTnVJxr+x9ioERw1pdp96W+qEOXSj+IEa8Pj9n08W5?= =?us-ascii?Q?uWW2ikScEmF6QmXZI27NbudEK9fA7VYzw3olTEowlr7+tUg+RkEEfgtVu1xq?= =?us-ascii?Q?sBVhzzm0QImfRmi3TbAYDJPyHKjUsxjJgdirBC2Xe1qMxmUfOcScdCw2tycI?= =?us-ascii?Q?HeK7etj8Kk7xBV0fCd6X0GfVaRF45xqyC7lr?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(82310400026)(376014)(36860700013);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 14:22:29.5654 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d558659-08b8-45b2-a58d-08dddff4fef5 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D3.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR19MB7882 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIwMDEyNyBTYWx0ZWRfX7rjNjqhfGsMc 9al8u/0LT8bvcymN4JpynUGo7MqVkXkbDF49txmfxTagh4/Asgg4ojCPsV0OLLxxgnp9ah/0Cjb YYxhY3O15KqIUcpt4wKgyYzD+311yZcIglnMP+XBcHMA9m+WPyNnxR0D6CLqL9nPD7FdSPIO4wf SGpuHcl6V85bC5oWDwa7jY3NEzFzV2C+/8XmLy99dpgy8p2FZUvghYC54RqEhzugzqrG00ooelR PNrAXuYaAfA3YLWUMFHJ6Wb3M6uIwncdSzMitVbGzkCre2yTihvCaObWpLEJEVJY/1X4otlpnOE G1Nmc0MdLFlvTx0tjhQPMUa0kX+v6jPfKzSkWOBB586xccUN1utmmwKq1JIJiaJhwcSNQQTCHzA Vjldy1OpmuVSbIUG9jt1KMozOsiaGQ== X-Proofpoint-ORIG-GUID: 6M5HEYea7Pkp6wMrZhjdRW14AlunKI58 X-Authority-Analysis: v=2.4 cv=EpWLbScA c=1 sm=1 tr=0 ts=68a5da31 cx=c_pps a=BIp6kkfJeZTrem3KMu6imA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=2OwXVqhp2XgA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=rSAZ-gJm6b_PRif3JyQA:9 X-Proofpoint-GUID: 6M5HEYea7Pkp6wMrZhjdRW14AlunKI58 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" From: Richard Fitzgerald CS35L63 uses different algorithm IDs from CS35L56. Add a new mechanism to handle different alg IDs between parts in the CS35L56 driver. Fixes: 978858791ced ("ASoC: cs35l56: Add initial support for CS35L63 for I2= C and SoundWire") Signed-off-by: Richard Fitzgerald Signed-off-by: Stefan Binding --- include/sound/cs35l56.h | 1 + sound/soc/codecs/cs35l56-shared.c | 29 ++++++++++++++++++++++++++--- sound/soc/codecs/cs35l56.c | 2 +- 3 files changed, 28 insertions(+), 4 deletions(-) diff --git a/include/sound/cs35l56.h b/include/sound/cs35l56.h index f44aabde805e..7c8bbe8ad1e2 100644 --- a/include/sound/cs35l56.h +++ b/include/sound/cs35l56.h @@ -306,6 +306,7 @@ struct cs35l56_base { struct gpio_desc *reset_gpio; struct cs35l56_spi_payload *spi_payload_buf; const struct cs35l56_fw_reg *fw_reg; + const struct cirrus_amp_cal_controls *calibration_controls; }; =20 static inline bool cs35l56_is_otp_register(unsigned int reg) diff --git a/sound/soc/codecs/cs35l56-shared.c b/sound/soc/codecs/cs35l56-s= hared.c index ba653f6ccfae..850fcf385996 100644 --- a/sound/soc/codecs/cs35l56-shared.c +++ b/sound/soc/codecs/cs35l56-shared.c @@ -838,6 +838,15 @@ const struct cirrus_amp_cal_controls cs35l56_calibrati= on_controls =3D { }; EXPORT_SYMBOL_NS_GPL(cs35l56_calibration_controls, "SND_SOC_CS35L56_SHARED= "); =20 +static const struct cirrus_amp_cal_controls cs35l63_calibration_controls = =3D { + .alg_id =3D 0xbf210, + .mem_region =3D WMFW_ADSP2_YM, + .ambient =3D "CAL_AMBIENT", + .calr =3D "CAL_R", + .status =3D "CAL_STATUS", + .checksum =3D "CAL_CHECKSUM", +}; + int cs35l56_get_calibration(struct cs35l56_base *cs35l56_base) { u64 silicon_uid =3D 0; @@ -912,19 +921,31 @@ EXPORT_SYMBOL_NS_GPL(cs35l56_read_prot_status, "SND_S= OC_CS35L56_SHARED"); void cs35l56_log_tuning(struct cs35l56_base *cs35l56_base, struct cs_dsp *= cs_dsp) { __be32 pid, sid, tid; + unsigned int alg_id; int ret; =20 + switch (cs35l56_base->type) { + case 0x54: + case 0x56: + case 0x57: + alg_id =3D 0x9f212; + break; + default: + alg_id =3D 0xbf212; + break; + } + scoped_guard(mutex, &cs_dsp->pwr_lock) { ret =3D cs_dsp_coeff_read_ctrl(cs_dsp_get_ctl(cs_dsp, "AS_PRJCT_ID", - WMFW_ADSP2_XM, 0x9f212), + WMFW_ADSP2_XM, alg_id), 0, &pid, sizeof(pid)); if (!ret) ret =3D cs_dsp_coeff_read_ctrl(cs_dsp_get_ctl(cs_dsp, "AS_CHNNL_ID", - WMFW_ADSP2_XM, 0x9f212), + WMFW_ADSP2_XM, alg_id), 0, &sid, sizeof(sid)); if (!ret) ret =3D cs_dsp_coeff_read_ctrl(cs_dsp_get_ctl(cs_dsp, "AS_SNPSHT_ID", - WMFW_ADSP2_XM, 0x9f212), + WMFW_ADSP2_XM, alg_id), 0, &tid, sizeof(tid)); } =20 @@ -974,8 +995,10 @@ int cs35l56_hw_init(struct cs35l56_base *cs35l56_base) case 0x35A54: case 0x35A56: case 0x35A57: + cs35l56_base->calibration_controls =3D &cs35l56_calibration_controls; break; case 0x35A630: + cs35l56_base->calibration_controls =3D &cs35l63_calibration_controls; devid =3D devid >> 4; break; default: diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c index b1c65d8331e7..2c1edbd636ef 100644 --- a/sound/soc/codecs/cs35l56.c +++ b/sound/soc/codecs/cs35l56.c @@ -695,7 +695,7 @@ static int cs35l56_write_cal(struct cs35l56_private *cs= 35l56) return ret; =20 ret =3D cs_amp_write_cal_coeffs(&cs35l56->dsp.cs_dsp, - &cs35l56_calibration_controls, + cs35l56->base.calibration_controls, &cs35l56->base.cal_data); =20 wm_adsp_stop(&cs35l56->dsp); --=20 2.43.0 From nobody Sat Oct 4 03:17:19 2025 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AFD6274B5D; Wed, 20 Aug 2025 14:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755699759; cv=fail; b=qgbDskka6gnL1YaAEzXYBpml5O54XSHh8OVsrp0bJJE5Rh7IY4sdhQMas1R2PLtul6qhsBbipgwFhzkrMBeWHlXW0LjukmzC7M/nBeH4Q9dIWbTRf0hm84vyO+OIo2l6MCoj7u7jXgafDLOu4K9QAfUk4nr7U2ru93LkUO4fCVg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755699759; c=relaxed/simple; bh=Jz4kPbAM2cqTulyAzHZyqdLH6CakcHrhfouNj+x6Y90=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qp9LyZeaFieytEonEPuQqiKicox/3TeuQvCrRuyhkydjnJ5sz2iFM8JbIZIS9kmafMDbi/K4uDoLm2dpi2CH5itFP42htBUjt5qHoKrBZUCnnZNbsb77lJKZH/yupQvGgadchs7WkYR8VQ28ahin1XtgmXWQrd7jrH7+0Qi17pA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=cGHetTcO; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=JCNRRK9I; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="cGHetTcO"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="JCNRRK9I" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57JJZ6QL368910; Wed, 20 Aug 2025 09:22:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=jwkwWlQ71XUBtFwKKZwtyD94AbT+R3s1KXhcNLtp7jY=; b= cGHetTcOVTOaNDHOsS76kjAlbbHNMKzLSopfrFz3NB8Op3GHmE12nZ4OduvIMId8 sq1UwziDR3XvsfbS50RxAg/YY+gDjIy4e8VfQxf4xsgCby+FXUmUzhOzyvor2tQu +Z5PCD03Ig+zQyODvbpp2NuZw3EjSUgKOl0XA38z8L7BKk+cD9hB6VA0G8CZV2wE tmhEmAkw0T4z1VxqjkLw6Xb2oyOfwKVltkelqNDcQJNPHNThCagWleyjbrI8oi0i uVPtNOmf3ocIctMuL0niHzMSEGAyye5MVwxU/64bSD5/OGBEYKruHmYcUpsjBaI1 HvQsBgQqxOwJ9yXkfFQzRQ== Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2107.outbound.protection.outlook.com [40.107.223.107]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 48myd99bs4-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 20 Aug 2025 09:22:35 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JNaFBEmf74PtlMM3fx0PuNXtSiyDm/Mx9QLJ0dTbaS4jUA990byjcBfCU308GVi28q2miY+x07rTLZEC+U/J97dOeOs7KkAdZvt9EDC4fL0ot8q2QUcESyEdRhhtWMFZp5lN1R5MBMuMjg7iCR3mtDZUSQHDfe6Ryt15StCiRgSIT9JFCwH8mXAlfKFZ0YWMozVHKvkj4gvGGgoYes45ennxpOBAfibtTrTc69KDMEgHQeMgVonS9j2KRS7GJU5gdi4O1f888bvgRfKFMB09VL2gjQmANa11sLqiGlONBnHXFGxY1cpTg2x879vo1steBqcGoxpI5Aln0YMKqdgHGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jwkwWlQ71XUBtFwKKZwtyD94AbT+R3s1KXhcNLtp7jY=; b=FddfvUyC+j7ik2rQ9PFh31e7S6OmH7cBsrTqy/gJfxdihOZ47DPD/0JWW8hn8+ql9ZugEi/0jmaAyRKyJ52T53IFxVJdZlyI3jMyCIwznhlRCij8qXQ5ZqF1nV3BshCt3/AF2JWiw4gmgAygYCQGFvo0mfgFC1hle9T6uIb6C7rpT4aljcvciMJX/Jch31RM0mlwniGcUGg6YUrNrwj3ZlQjaEjzlqMPkDCnw4+RQ/42cN1smWQpuoFr9pPVD2pPauUGzaQxRDBdXNxaBOp2Jicp/VOVfFH9/Nr3HzrLu9rI7lQSx7fn+UixTZ1cRdfAEQjBpHqZuqZTpv7e+PxKFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jwkwWlQ71XUBtFwKKZwtyD94AbT+R3s1KXhcNLtp7jY=; b=JCNRRK9ItGBugLU2DHLs6DK+q3EqDoKbypiZFWBdsoomGFb+ChifVLjxhh18aniymX33v6gohkMC1fsHcoUmJPfrSWZUc6EhjGTOkRGjoWPb4lPCYu0a5u9jHQ3LZLVtoSy08klBbvOiWP+5pDr9rDG/biJjeCDXBiYEM5Dd5mA= Received: from BN9PR03CA0096.namprd03.prod.outlook.com (2603:10b6:408:fd::11) by SN7PR19MB7817.namprd19.prod.outlook.com (2603:10b6:806:2ee::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 14:22:30 +0000 Received: from BL02EPF0001A100.namprd03.prod.outlook.com (2603:10b6:408:fd:cafe::9c) by BN9PR03CA0096.outlook.office365.com (2603:10b6:408:fd::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.14 via Frontend Transport; Wed, 20 Aug 2025 14:22:29 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BL02EPF0001A100.mail.protection.outlook.com (10.167.242.107) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.8 via Frontend Transport; Wed, 20 Aug 2025 14:22:29 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 1AEEA406555; Wed, 20 Aug 2025 14:22:28 +0000 (UTC) Received: from lonswws02.ad.cirrus.com (lonswws02.ad.cirrus.com [198.90.188.42]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id E900082024A; Wed, 20 Aug 2025 14:22:27 +0000 (UTC) From: Stefan Binding To: Mark Brown Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Stefan Binding Subject: [PATCH v3 3/3] ASoC: cs35l56: Remove SoundWire Clock Divider workaround for CS35L63 Date: Wed, 20 Aug 2025 15:22:02 +0100 Message-ID: <20250820142209.127575-4-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250820142209.127575-1-sbinding@opensource.cirrus.com> References: <20250820142209.127575-1-sbinding@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A100:EE_|SN7PR19MB7817:EE_ X-MS-Office365-Filtering-Correlation-Id: 29afbab0-5a8a-41a9-9a85-08dddff4fec1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|61400799027|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?jPDWHLA6HpNZ83esLo+CmgcZOcjKgdKFcgKVc5dR9kpDTvTw20s4m8YIESP6?= =?us-ascii?Q?CGl8WfNUzWn1rmt6VIJHk4PsVbwYGXs9q4HbsgSuzq8U5eK9AXLTikw9gG3O?= =?us-ascii?Q?wD7Zano49ryM5I/7FzUyHP6pDdS7u/Jw2aCQOdAvHrSmwlblo0zIaRCVYSKN?= =?us-ascii?Q?9++eIigzP02O8j+jewepi5TvE1UX7oHTl2BgQBTV4fXP22/vmBDl52vKK1hn?= =?us-ascii?Q?nB/ahPSRowprYD+o/Tz5/mlyntb45zidRHjvw/DAoINscmXP56oyzt5AapP2?= =?us-ascii?Q?FhtB3UTCHREsBWiZt3dV5fuKop6qhb4etIGGQqsZA2HC+Ra7itj1ZdB3SNyt?= =?us-ascii?Q?z2FxO0qgLloMLTqLTqWs3glmzd3fZ7k/XtDoiKkNyH1UnIh+s9vYJhE2RL0R?= =?us-ascii?Q?9FIfApmVQmYABJJYfMmvvXBiaSGBzkDKLNYK+ngO5KSgL9yj2fvKoc8WI5zz?= =?us-ascii?Q?aqq7LQ2frM6mZbutG7UsbBgrFLr0lFgz/nCqtRpkcK+WK2Apa1DFud7i0/8i?= =?us-ascii?Q?s9tauorL7tINhKLfAZEwAWwE+13kipZvZNG/JnOQBhPmidaSx5jNWFy6EpOi?= =?us-ascii?Q?N9UU2wY4/hBeCXc5GsWTmgZphdGj+R5LzIquOfAuOIL3zyQ72ipVIbL/JT8n?= =?us-ascii?Q?xxH+Kwt7Tr4QvOhzCnB/eU7E8c6pBdBk8Is9WPpHweZhByB6SfnY3O9kntTY?= =?us-ascii?Q?7f+qwmCJwKkTiZxnXioL9knXLCWcVM44rs/3kb+JJ82r2ERNqX8pksHkGEh4?= =?us-ascii?Q?v1sIz/MmmqSZvuHxE/fL6z7azSqFZTklz/2VmFu5OEnrHeWppZ5S0rfwrYWn?= =?us-ascii?Q?siJ3+Bt5DjFTlkHngQ6nl0WvGgCaUuUx6R5Nw4CRp7E+jWQBgeMKN+mKWXip?= =?us-ascii?Q?XlrUn2vs6JhVOl1F1CAb70mgXXxdGEc6UAKVO2guhVSuie1UyJkSrcY1S4VI?= =?us-ascii?Q?mWagOKckZUJgJVHJZmXGFA40b+j0Vmx8WHe2c1577ULpiB58Y7/D5Yr3liFK?= =?us-ascii?Q?/61KpbaeSjcobgbotudu7l1nZw1I+spia2Dw7sPwWWn0APWNBSrh6CPx6oQD?= =?us-ascii?Q?zA59I4O4aIGqh/oW7DRXFDcE4F7GsNJi+u38RlgULtz72cRTn4AUdotwAwDl?= =?us-ascii?Q?vBN9orJRDDSsYBLOiOCzECJuSAP6TRj6hooXvw7ScEf8++CMKPX8ia1SMfdK?= =?us-ascii?Q?9NwFwimOyk9RTaYFuaKcWw/DILtOo8JsJGEhs/hpAY0oIX5DQBnWnem30sK0?= =?us-ascii?Q?tWmf1FLE4cb2J5wVCY/AHpn4dBEY2xnlX0mQyN5O7C6KY7S85uWQmypoU4+c?= =?us-ascii?Q?OWK5llSqTdJNc1nJVVAB/KhCUTTPQER8HpyTGnCRXyg9kdqI8kj4tHwtE1S8?= =?us-ascii?Q?SRbHWMJpC1sq9HG9uL4mKBKpJS8NPLn6X1o7xiVdF4rEFM0NSPYYtJcAYw07?= =?us-ascii?Q?0gm3ikhH/QkPVWrfQMMQ43KMSdEuB7bzvY2G7ZLdhLQ1VDYstOemDKjyDVPX?= =?us-ascii?Q?yBMHZfGKy3IOXPCdRqb39+n/korsRzuVHjoV?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(61400799027)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 14:22:29.3526 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 29afbab0-5a8a-41a9-9a85-08dddff4fec1 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A100.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR19MB7817 X-Proofpoint-ORIG-GUID: ApXKrvtnNA4De-JpL5KUgLxR7azbbWpx X-Proofpoint-GUID: ApXKrvtnNA4De-JpL5KUgLxR7azbbWpx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIwMDEyNyBTYWx0ZWRfXwvf7ZUBF00Kw x6r0hKmGglaQEs3REguWwDV0poPwZqbLLX20AJFx5TuqxzEHCZw/iuC5K/AYh4bTFSdQHs8Gl+V hTqxT5UaS4CQnIaXQwujTtychSDAdhYOY0GnkKz94KDA8+XnRkQuOvmW2oPmelTY/SRi7lkXxGQ TDLci+Jmhfd1DEpCxY1J9WrXNzsSN5Unb2YcgMWByQX5ZwEIHaQW+8jjvmQhgHGs6J5Uxp3Fr3t SDUj9sOs4W6GeoxjBWTrAcxoA9zoQCOpL4toflSzZpkOuRVAlIDK8DLTnlncxd8KQJsnrOFT9FB /JAqsIltD4bA/BcF3PTxq1ZySIdqF3ueaFzzUgg9uEEUk/U52U+UAPq0tVMtsjw1maaet1DratF fANKQ/i8lUXQdta81Ick3ctVtfG4aA== X-Authority-Analysis: v=2.4 cv=WIwmnnsR c=1 sm=1 tr=0 ts=68a5da2b cx=c_pps a=aVHjp9ag5SOPUVfpuEL+cA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=2OwXVqhp2XgA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=Eqq7O2SyaTNHdlpsiP4A:9 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Production silicon for CS36L63 has some small differences compared to pre-production silicon. Remove soundwire clock workaround as no longer necessary. We don't want to do tricks with low-level clocking controls if we don't need to. Fixes: 978858791ced ("ASoC: cs35l56: Add initial support for CS35L63 for I2= C and SoundWire") Signed-off-by: Stefan Binding --- sound/soc/codecs/cs35l56-sdw.c | 69 ---------------------------------- sound/soc/codecs/cs35l56.h | 3 -- 2 files changed, 72 deletions(-) diff --git a/sound/soc/codecs/cs35l56-sdw.c b/sound/soc/codecs/cs35l56-sdw.c index ee14031695a1..3905c9cb188a 100644 --- a/sound/soc/codecs/cs35l56-sdw.c +++ b/sound/soc/codecs/cs35l56-sdw.c @@ -393,74 +393,6 @@ static int cs35l56_sdw_update_status(struct sdw_slave = *peripheral, return 0; } =20 -static int cs35l63_sdw_kick_divider(struct cs35l56_private *cs35l56, - struct sdw_slave *peripheral) -{ - unsigned int curr_scale_reg, next_scale_reg; - int curr_scale, next_scale, ret; - - if (!cs35l56->base.init_done) - return 0; - - if (peripheral->bus->params.curr_bank) { - curr_scale_reg =3D SDW_SCP_BUSCLOCK_SCALE_B1; - next_scale_reg =3D SDW_SCP_BUSCLOCK_SCALE_B0; - } else { - curr_scale_reg =3D SDW_SCP_BUSCLOCK_SCALE_B0; - next_scale_reg =3D SDW_SCP_BUSCLOCK_SCALE_B1; - } - - /* - * Current clock scale value must be different to new value. - * Modify current to guarantee this. If next still has the dummy - * value we wrote when it was current, the core code has not set - * a new scale so restore its original good value - */ - curr_scale =3D sdw_read_no_pm(peripheral, curr_scale_reg); - if (curr_scale < 0) { - dev_err(cs35l56->base.dev, "Failed to read current clock scale: %d\n", c= urr_scale); - return curr_scale; - } - - next_scale =3D sdw_read_no_pm(peripheral, next_scale_reg); - if (next_scale < 0) { - dev_err(cs35l56->base.dev, "Failed to read next clock scale: %d\n", next= _scale); - return next_scale; - } - - if (next_scale =3D=3D CS35L56_SDW_INVALID_BUS_SCALE) { - next_scale =3D cs35l56->old_sdw_clock_scale; - ret =3D sdw_write_no_pm(peripheral, next_scale_reg, next_scale); - if (ret < 0) { - dev_err(cs35l56->base.dev, "Failed to modify current clock scale: %d\n", - ret); - return ret; - } - } - - cs35l56->old_sdw_clock_scale =3D curr_scale; - ret =3D sdw_write_no_pm(peripheral, curr_scale_reg, CS35L56_SDW_INVALID_B= US_SCALE); - if (ret < 0) { - dev_err(cs35l56->base.dev, "Failed to modify current clock scale: %d\n",= ret); - return ret; - } - - dev_dbg(cs35l56->base.dev, "Next bus scale: %#x\n", next_scale); - - return 0; -} - -static int cs35l56_sdw_bus_config(struct sdw_slave *peripheral, - struct sdw_bus_params *params) -{ - struct cs35l56_private *cs35l56 =3D dev_get_drvdata(&peripheral->dev); - - if ((cs35l56->base.type =3D=3D 0x63) && (cs35l56->base.rev < 0xa1)) - return cs35l63_sdw_kick_divider(cs35l56, peripheral); - - return 0; -} - static int __maybe_unused cs35l56_sdw_clk_stop(struct sdw_slave *periphera= l, enum sdw_clk_stop_mode mode, enum sdw_clk_stop_type type) @@ -476,7 +408,6 @@ static const struct sdw_slave_ops cs35l56_sdw_ops =3D { .read_prop =3D cs35l56_sdw_read_prop, .interrupt_callback =3D cs35l56_sdw_interrupt, .update_status =3D cs35l56_sdw_update_status, - .bus_config =3D cs35l56_sdw_bus_config, #ifdef DEBUG .clk_stop =3D cs35l56_sdw_clk_stop, #endif diff --git a/sound/soc/codecs/cs35l56.h b/sound/soc/codecs/cs35l56.h index bd77a57249d7..40a1800a4585 100644 --- a/sound/soc/codecs/cs35l56.h +++ b/sound/soc/codecs/cs35l56.h @@ -20,8 +20,6 @@ #define CS35L56_SDW_GEN_INT_MASK_1 0xc1 #define CS35L56_SDW_INT_MASK_CODEC_IRQ BIT(0) =20 -#define CS35L56_SDW_INVALID_BUS_SCALE 0xf - #define CS35L56_RX_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24= _LE) #define CS35L56_TX_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24= _LE \ | SNDRV_PCM_FMTBIT_S32_LE) @@ -52,7 +50,6 @@ struct cs35l56_private { u8 asp_slot_count; bool tdm_mode; bool sysclk_set; - u8 old_sdw_clock_scale; u8 sdw_link_num; u8 sdw_unique_id; }; --=20 2.43.0