From nobody Sat Oct 4 03:17:21 2025 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE8232DCF58; Wed, 20 Aug 2025 12:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755694270; cv=fail; b=oeVUvtOZSzisPKRt6mAb1PSb8ki3Pg5cKzugW5n/5bpfOM2oD5SLsAHcZadkUxFyXVR9ukCrNigWFBELoxOUCNoVeFgtH3qPyIiIzOG26m9IQJ05rkmZ9Lwaxvrl4RQcad0hCBYc5lu4Fa+IFz4546N+rHOo5NWDWmhJ55s27Ls= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755694270; c=relaxed/simple; bh=QyXRQTJKX34qST6LzG0fQ9Zz/YLCCESzUMmwqEf8KfU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G+BBCdoISfmoJBx3cL8U/+SwL94viszYiKBw0LEHvlmiGNL7pANpLQheUVdvbENmfT5p1r/VVssoeZPgCGXNBH38AjIYJ53LtuqIpjxyet04lXTQY6IfDpfsq/zhohhEEOLNYK/f4k/hFGNE8FRE56k89gk9cyHYq50V8OPYuH4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=iZz+eu1c; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=C9VvIZDq; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="iZz+eu1c"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="C9VvIZDq" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57JJYrkN368685; Wed, 20 Aug 2025 07:51:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=PC1hlDwTO7bYoMTBOUfRP66TGLX4O1chZ3G9U4nw8BU=; b= iZz+eu1cayQdJyTZE5WRQkWNOfptY5bKrC2M+JBuq8s1oFyWUP42LSbMiqp/1tw1 PehyNNeqtCvYH/PRjTqFLEcfr0PMV7AmVtiRg5a13XWp5SJa8z7yT9cps+gWAspF xnXwURtvv5vyxovkz4hkP2eG6pI1tVxuFOY/VLoUR/OHOcMrXtd/qsevw8N2nebB WFlus7gtkq/T1FMjYJfBYFY9Mnv+WmgkbFA0xai1syfz+y1OrVIe1zDAZ9qcuk2Z qSTXNtmAdtlmS3ZSTmqSF6lCUuyk3xPAhhz1Dai8821ENvo78sGfGjtpXBxEsE6V xtNyypDvZauY5xW5MofCaw== Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2120.outbound.protection.outlook.com [40.107.223.120]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 48myd9971n-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 20 Aug 2025 07:51:04 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Eqhq5Et6jqgH1yYZkbVtC0iTIKfDkLoRVcgeu9NqQ19tTzhHiYXde7OIpEKrnY5VR1Xw3rF+oP8JdQWtNKsyRVPg8CEsOHZj0xRwkiW2GuBgbA4kPNrqdxV9YQ+l17Ujn2pa8UlAWf7YLQyMcu61xGHAtDk+eWwURNK/zuUY+3XvuHWfi7sA70x/kbHYZxdb1I7cXsENIj5ZpQNrPlbBJGq/f5d+u4ljj+ZtHCOSkFyOnFhwIfMPlIV1CpS6r63FYUXIhhWIGshHVQlImPxDbXtDHz5NYL6mkFNmRL1iOue5mbAiC9ZTprK1aeys1e6lpejVTuLVY2bOKg/sHLiT/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PC1hlDwTO7bYoMTBOUfRP66TGLX4O1chZ3G9U4nw8BU=; b=DB9Rbqu1AeQ3nKdvP4skTHNbrn3IUaa4Bi7rkIJHX9Ns5W7IM7Q7aZc76y2LtO73NabArEfX/BBG7xBKF21fZQg4v4PWglE+tGIOOyDzzodN+drG2fm/TQ7g450EOL43EMziSEFcAkBsKVkOvW4GoK8LDXyh8DPcqr6VVde0yYfpgG8yNIJd3WHYRqCzJealMj2kJmRx6ajZe6j+aUxMSNdZWHZtYpezXubyBoeImXbij+7JfK1XHaDWFZQ/OUU+X2QPzWwuSMrm7w3xaIkhaSD8Wud+7tW5gHM2Mq5wBHdNrMcvwrwfThrcyfVv/YzqBLPLeYcyug3MVHlUdRN9QA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PC1hlDwTO7bYoMTBOUfRP66TGLX4O1chZ3G9U4nw8BU=; b=C9VvIZDqObSPxGlCjHMS0itV+zJenvG2QBSkj38Zkvspsxwys4lnVXpCYtaBmokhJge7SkfCsHv7Z42Jh604xJjzumYH31FjAKKr8BtsH24SF1rzZ9tZMJb/ovRY0C7dcT6BqZgxeE09UXN+aeIB4W6Ts9A9oFq9RR12FKPsCgQ= Received: from BN9PR03CA0196.namprd03.prod.outlook.com (2603:10b6:408:f9::21) by PH7PR19MB8236.namprd19.prod.outlook.com (2603:10b6:510:2e7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.25; Wed, 20 Aug 2025 12:51:01 +0000 Received: from BL02EPF0001A107.namprd05.prod.outlook.com (2603:10b6:408:f9:cafe::ef) by BN9PR03CA0196.outlook.office365.com (2603:10b6:408:f9::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.14 via Frontend Transport; Wed, 20 Aug 2025 12:51:01 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BL02EPF0001A107.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.8 via Frontend Transport; Wed, 20 Aug 2025 12:51:00 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id EA3DA40654B; Wed, 20 Aug 2025 12:50:58 +0000 (UTC) Received: from lonswws02.ad.cirrus.com (lonswws02.ad.cirrus.com [198.90.188.42]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id C2C1C82024B; Wed, 20 Aug 2025 12:50:58 +0000 (UTC) From: Stefan Binding To: Mark Brown Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Stefan Binding Subject: [PATCH v2 1/3] ASoC: cs35l56: Update Firmware Addresses for CS35L63 for production silicon Date: Wed, 20 Aug 2025 13:50:34 +0100 Message-ID: <20250820125045.117740-2-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250820125045.117740-1-sbinding@opensource.cirrus.com> References: <20250820125045.117740-1-sbinding@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A107:EE_|PH7PR19MB8236:EE_ X-MS-Office365-Filtering-Correlation-Id: ba3ad119-4ed9-4d2d-4f0e-08dddfe83720 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|61400799027; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DX3W194dchjKjen2rIrzNp1NfKSH2eCI4oUSKfsm2/So+K+TvgnSgStptG9N?= =?us-ascii?Q?zws3/mUEKqnKJ/ZT8kkECtGYXx11pJ4FMd6USIOBiIKn5910CN6Ubg0bcdYY?= =?us-ascii?Q?umCqgX4jhbWUVZr84MqMMosl1jitCo7QNRKZK7XN1kT6cq1srtID/dlnx+dI?= =?us-ascii?Q?tTRE49JUBMAWnRYHsN8AN4g4Wn5nuFUDQ4t3DdLcdjy8JlaQTgJEhvgC3BQS?= =?us-ascii?Q?Dv6Q3QIaoUsCBAM3zGtRYGBERlRiQGi+VVGKOZSL+Saa/a3I5stwNOIhpAha?= =?us-ascii?Q?iz6K9BQU5UJ0xd2KaQlNcIpBYXEFlkrbH0UnuOqbz1+Zv3DRWIumzDn3xs2n?= =?us-ascii?Q?J3csiA22AdvLN6fH6CGgqco8f3e//TD0aJS12tR3tCqqVsRhjxxgbd2/4VgZ?= =?us-ascii?Q?6H5YKJ0yy5HD40fDQ+GJWEKxsWQ8frEZnbzyoeR85BynNHGM7+4asuL0cDi6?= =?us-ascii?Q?vVkvAyv8MPXLRePQvcJDp/WXHhCDIGdkA4wh7V3Q/2bkB0Tgeu5JPQPsqYiD?= =?us-ascii?Q?KXe80/KBBOUxynp3Yj74xCgMuYFqjedyzE7Mlpn5eO1Ty4BOFImTVOwyddQL?= =?us-ascii?Q?9I5Ec+zg1zEcLr40TCHOPg/vovMFFjjKkIbT//wqI4UCC5bxIuK1fcvaXKau?= =?us-ascii?Q?2DvDSJCVizEGsqrOlypbBaJt0sZthS73i9WixrNmoEASloIMdvF3tB0uYjqS?= =?us-ascii?Q?onbNG7pjusDvWouX02NXeTnJVA+7skkwXroQfYtFoxiLdkGjthSXZtBV1yty?= =?us-ascii?Q?G8sPfY07H16fJZQrI9fRNOgcQW2OTTovkZ+sgW0vZJvCk29Dt2VDWukl/oC3?= =?us-ascii?Q?NPEuYRXgpOjKgwu7bYttO9lovijPZvtlFQBIj1gPDhBPqXQkpHp2E6ki28/I?= =?us-ascii?Q?n1W72mkmJ5/Ucm/gmbIinP9BUtp9I34pVMRZqQEDgIdjdkr8ABbHWKSRVIi1?= =?us-ascii?Q?8yV/Dfb6qRGLV0k5o5qPpKHGh28eA7Y+g/MH0WC/d4fFirMIplpGtZX2Nnze?= =?us-ascii?Q?VRQiRT9Z4//McpmDTVZzCpdoJJe068f3H0esjael7DMx9NeTGlOGH/1FD5RY?= =?us-ascii?Q?qXHfv3GFgqPW0AHa8MFkSEAk5ptQyWiRAyf5xsjH714n1bfN4ejCK43EdhDG?= =?us-ascii?Q?tR49zmX1M5QcX9EaWOlVAbcKP7Qb+hQybXUtKvrLYzO1BZDN2iDu5VYNSXRn?= =?us-ascii?Q?wpRXcg3VZnlsbwDfzEMRZytp7uhVlo7h/uSOeYZFbmUq/16BqpzukegGaxdB?= =?us-ascii?Q?x/M/zsPdEFORtF0c/hjO6E2i17a4k8kOmvmOcyHbnKhncK68zNXOCihh1Q0t?= =?us-ascii?Q?DeXfs1j3XoEQJ8f07HGrog414ln95FHochfJflDJcWw5vK7hyqWiLstFTBFD?= =?us-ascii?Q?qDaQujhDguQ5cz7/rcsRbLs6F+M1KmtEt4/ECHuf4RJD6ye2RBxqhrEzj6Kx?= =?us-ascii?Q?1kwIEbo7PZugHSl27PHz6zkvgfwom/j1rz67LxAlRPfQvzZS8GViaplX8Sw2?= =?us-ascii?Q?7wGHb+TGE+Q+HwESvy9UUFPyoroH3+K7DU7N?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(61400799027);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:51:00.4660 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba3ad119-4ed9-4d2d-4f0e-08dddfe83720 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A107.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR19MB8236 X-Proofpoint-ORIG-GUID: cu-952eQmczE71hkipot_wqNupNo5lw4 X-Proofpoint-GUID: cu-952eQmczE71hkipot_wqNupNo5lw4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIwMDExMyBTYWx0ZWRfX3H62Ma4Zc0aS qlaC6oKJzA/8vnJ+BgDlYSZaazK2//bsW7QwMqQDuaz5JJEjcjQx6HM39TZDke3uGRbyEuyWyEL G+pkTvSfxS1pvUB3FCrxx4rxlmYJde82jk8ZTM6utPA2meEAlaPtzW5LBRglE1tB8J8poifiZFH BsYoMGDfxR7qul+dMev2VQgS9p1zjgZ/CksL2JVEJLkRmGBvXoGgaSTYKHtUULhoj1R/k1pJE98 R9lBgs0tRFofuzX/gu/zPhlul30/gIv/UIaOEM+hsOIvh+ymaswTPeVaQQx4UQbpY22dhNXRTTK PAIDzBjCqAVXLYM3hvHieVtgd1XC2k1PLMZsCLmCD773TpiY27hhWm3UpML+HzsB/uMzC+OgXSO ta5g6YtHVVos/+W9TBJulXuKzdSp5Q== X-Authority-Analysis: v=2.4 cv=WIwmnnsR c=1 sm=1 tr=0 ts=68a5c4b8 cx=c_pps a=GIPfV4OF57JdyPKrRApGaw==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=2OwXVqhp2XgA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=x4YA3FrS6Vl5HCi3FGUA:9 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Production silicon for CS36L63 has some small differences compared to pre-production silicon. Update firmware addresses, which are different. No product was ever released with pre-production silicon so there is no need for the driver to include support for it. Fixes: d3197a09a117 ("ASoC: cs35l56: Add initial support for CS35L63 for I2= C and SoundWire") Signed-off-by: Stefan Binding --- include/sound/cs35l56.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sound/cs35l56.h b/include/sound/cs35l56.h index e17c4cadd04d..f44aabde805e 100644 --- a/include/sound/cs35l56.h +++ b/include/sound/cs35l56.h @@ -107,8 +107,8 @@ #define CS35L56_DSP1_PMEM_5114 0x3804FE8 =20 #define CS35L63_DSP1_FW_VER CS35L56_DSP1_FW_VER -#define CS35L63_DSP1_HALO_STATE 0x280396C -#define CS35L63_DSP1_PM_CUR_STATE 0x28042C8 +#define CS35L63_DSP1_HALO_STATE 0x2803C04 +#define CS35L63_DSP1_PM_CUR_STATE 0x2804518 #define CS35L63_PROTECTION_STATUS 0x340009C #define CS35L63_TRANSDUCER_ACTUAL_PS 0x34000F4 #define CS35L63_MAIN_RENDER_USER_MUTE 0x3400020 --=20 2.43.0 From nobody Sat Oct 4 03:17:21 2025 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D111B31AF38; Wed, 20 Aug 2025 12:51:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755694276; cv=fail; b=My+m9UNBlVV6P3+8taTvtRwxJaqkRlADfdH+I020NB8mI67xyVn/fkiM0h23IaceF6G/sv1YKclhswRsrDenVEnKAtUkwhiTWpYkOBn/euppuu4mhW+bbos62IS0aYqr6iE4jb+KhrMoyheVKfdN8RORNFjxFruAALyOfyqsJz4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755694276; c=relaxed/simple; bh=KkvmobLrvGiN5HSRfhFLn0nhYtkYCtq/T8YtCBPmNGg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WcOWEDekbDxryOWVDfo6BATaelUHyppnFUfma+9XaBurOUtLdXW4+v7IAoQ7AHVuvRl6/tWW9RlCC7UxjchTYLyNTM88K3BxTtLLHUtKce8u74LXlgWyItvbRmcxr1qMjDRYhos8p0ID+s40T8qiToQJdPkZnl8YFpAsLbSeSFo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=m13545sE; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=Ur7Jw7FW; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="m13545sE"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="Ur7Jw7FW" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57JJZ8QU732167; Wed, 20 Aug 2025 07:51:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=Xg8qHdTvTBOJbyT063CTm+3q3zhkzcpQJKZrpMeWnNA=; b= m13545sE+7KGayItDWJEQm2yNaqLDtP3+MuF6fyEBo1vCplmV28Sg4uId3KyMsum +Bq0Zb78oLwCwUEHCaIO6YZcVK/gcxF+/F61Q8vNhwrp5I99SngVNp33Ae8o/SQ7 Pj/+6icNldQYXrUYZ/IHGibqUqHAHg/9A7vetYLLjmwAr/h546P4BAPUAc2kZ6Z6 QCIsm35t7QFL7pRywv5YH0nVynzlqgWorj2Ke5zN8DO9R5EwAWX+b3927PyrWdgC shqUNtoZdb8FEw9aNDdRnZ0YqQF53Q6N7QQrlBq6HKet0ESuwKUYbAfoUeuWPV9I 0tuFUXQFHAreew/qdTd1fA== Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12on2131.outbound.protection.outlook.com [40.107.244.131]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 48myd597dj-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 20 Aug 2025 07:51:05 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yaMyLbgWz54TOl64kjALPrQ7v1T43aU3Cry4pTH/GKXhkX6/+Nf6HiWCPpFgnRuHHPXstaji2LN3k5yTPie7U0kIrCpZHjV2XWKqgfvqk6G0X1quZlLPWbjZybcORngH9FOCFz5kgSAhtbeSDqAdK1pc0kyOt3KY4GQxyalwLQbiObYS1jdNJHi3fzvf9/GfiHyV/Z2NLQAflFhZygkxo9AF65lywmSSteW3BkNxpc/zffBGFqlGa3qLxUrrOnh01pXSeWUu7vRJ/ERqJMU6EYvrS5Vy+S1fHo5zge9Pd2c74uKazgZkJJiQxKcxLVRlmp87xEHosiBwiMcVDBfIGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xg8qHdTvTBOJbyT063CTm+3q3zhkzcpQJKZrpMeWnNA=; b=hlff4g7XaDmWW+JkcAMfMg6QblfwrHQNak4v6ZeyQh/S3cOhXa9fbLLqmlfcwdGEjA+ow+Ia95RRL74kiWKZe/Cs4Lkz4HhHRFPdzWYrMHG2qUqaSNnOOTJUylU7osiihEI8cN8Jtf3bCO19sEhapIB82fi9EvzfkjK9zzUUMYtqkKAWUQJForTG/JMyGtaHjbCzLkqUKO0p6/Qo6wBJuI1NiWKisQnomNghUzongMwckIotW0bquU+sFlNPahTdvSSW3JE9bhi2FN3gGz3SLNYogApDioQz7OVNEWgIM0UF3ANzPg8GWENx41ZNEFrEZK+rp6rT0JCgWKZdPgsT9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xg8qHdTvTBOJbyT063CTm+3q3zhkzcpQJKZrpMeWnNA=; b=Ur7Jw7FW4AFyq+lfFkQS4UZ1qS8Sf2OXtQgWxgRldFMTfQWhvFcAxIPJaSZw4R2dpl74XgBYyyrO/Y5Zc68+NMtMzacWoYW2Zk+fnBJ348g0vda/Tgaa4L+Coi+gy1evzANrnisinfY1drSp32ocQz7J2RYqCEgP1inHfpui4jQ= Received: from MW4PR04CA0304.namprd04.prod.outlook.com (2603:10b6:303:82::9) by DM3PPFC1DE74F70.namprd19.prod.outlook.com (2603:10b6:f:fc00::757) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.14; Wed, 20 Aug 2025 12:51:02 +0000 Received: from CO1PEPF000044FC.namprd21.prod.outlook.com (2603:10b6:303:82:cafe::11) by MW4PR04CA0304.outlook.office365.com (2603:10b6:303:82::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.14 via Frontend Transport; Wed, 20 Aug 2025 12:51:01 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CO1PEPF000044FC.mail.protection.outlook.com (10.167.241.202) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.0 via Frontend Transport; Wed, 20 Aug 2025 12:51:00 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 25CB3406552; Wed, 20 Aug 2025 12:50:59 +0000 (UTC) Received: from lonswws02.ad.cirrus.com (lonswws02.ad.cirrus.com [198.90.188.42]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id ED61382024A; Wed, 20 Aug 2025 12:50:58 +0000 (UTC) From: Stefan Binding To: Mark Brown Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Richard Fitzgerald , Stefan Binding Subject: [PATCH v2 2/3] ASoC: cs35l56: Handle new algorithms IDs for CS35L63 Date: Wed, 20 Aug 2025 13:50:35 +0100 Message-ID: <20250820125045.117740-3-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250820125045.117740-1-sbinding@opensource.cirrus.com> References: <20250820125045.117740-1-sbinding@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044FC:EE_|DM3PPFC1DE74F70:EE_ X-MS-Office365-Filtering-Correlation-Id: 79ebaa90-07e2-41b2-9ab8-08dddfe83731 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|61400799027|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Yl0CYHwr7azuMSnI3GcqGHAZFrF1KljX7koN9QjLIXPMutCRWTmMq+avOjSs?= =?us-ascii?Q?h6WQp/gIHNSR7cAolhHT6b7ulAYT4MuQcA+WA0jlVgDrugMkpLEbG9JYOuIU?= =?us-ascii?Q?H8LuaNsfs+tRzYDQ5tAaep9NV4uqkGjrbztFtOwf5s7uSLtra+8dJ75yQkx+?= =?us-ascii?Q?noC35NfuPf/te7Smig8DJgk5Noe0OftZ8GGZginM9raEVPNRvP5LKXq0Z/iL?= =?us-ascii?Q?+5jsmAaBrlztbB43CodQJ39Ei27aEEXLGTJAiZuWGPtHiENnv4n99eOrScxk?= =?us-ascii?Q?qtsl+07rvdB3i6qiNVaOvo3tbUTqGBUxLpM8K1f1hgDBs7DGRNMB5Kt3cAJB?= =?us-ascii?Q?lgyuvrq+UFNU2WKplw6j8+GZpDThGIT7Sn8VmhWxNzWf4zWzaLkN/RkOTOjb?= =?us-ascii?Q?Sv6ZVpvna6sGxOWt9uj4Z3+FpDG33p9+3xGImK7IfQOnpFBfi+FkA1qhmuY4?= =?us-ascii?Q?kd8K4oJmFC5tL6gjSVgIyUYhISlvHTfbsYmPUidh6Bkff+bgIa55XcpxLX6x?= =?us-ascii?Q?c643DzstGsI+YwPcfli4BN9NByZHl8PC0dfhpzrnRhNrMhsxXHUpSgTBnFxp?= =?us-ascii?Q?pYzrq4ex5kSj7Yvw6vUlGCvRCVPEavCuZV45XOr6GcBJnL1EKvmjB2Ln+K3L?= =?us-ascii?Q?4aZwYQkRzsTCgr7Acjv9iKlrawI6iUOY+XFHMNEZNoWvSQB3IPtwTVi2hT2+?= =?us-ascii?Q?38xUukU6GWaI4nHn8cHdiz/M55dNVzcodDl6PspUb3BeL0ZhX1jao5M4yKW4?= =?us-ascii?Q?xjuQFQA9JrXr23OEYkG8Mvppuf5l9GWatD2eTBc3K8HOFRuS6IQ5pVHK2r1U?= =?us-ascii?Q?sZZzxSmIz0qfbC68TZtGqE5eH2amveH4awiGrX+oHVx1b1ak0hH1dzIy3VaE?= =?us-ascii?Q?SEA1wGzQg9WchbK1PL8aZtI0qP7n/KIt/niw0k7fTudi2jG3ITx/ptUcV3vm?= =?us-ascii?Q?1AUrHjOvNqrgxbz07Fmw5w4SF/W5LH/O6xSNJLDPSh2+06eubzN5lOTQNiA2?= =?us-ascii?Q?bloAtNi05fuz2BVBj5a+O7nqsBSZtLHtFh+qIVplN8uB2phIhM9LZkP29sR4?= =?us-ascii?Q?wdknsYGETJCBJyHVmPEHVpqHr8TsOzXXPQ00jWb8T2HsNYjmDsxPozHkSmjv?= =?us-ascii?Q?b9lghodPxYZzrdFoqGLvVUGj3VntOWyhqG5HlaDsoIuutnAi/PVFFftKY7rG?= =?us-ascii?Q?n7iy4PXlmov70FC8DUC7lqNGXfB+WgUJs7nI/ajpWv5UYKFT9caLfYP9ZjHB?= =?us-ascii?Q?xB1ttzeAOBysUThmnx6RP23ylzbqu+3bxs7EREoGQiXNV4M66cyFji+hB+75?= =?us-ascii?Q?+KoKEgj//ho60uioe/B16kfkQ+VhVhb+yb7LLZupf90MEcgGTTejEBZnVVT/?= =?us-ascii?Q?zbUINa/B0NiBPy9lnMr1flTrW83qD1fFyBjww0TgGQ/MlPXiSCpH4hWjJ9V6?= =?us-ascii?Q?xMjEOum7RIMH4ogD7m58P9OBjwAOSWZXmOtUQzqk9xmPj4R+rs8qucPXa5xG?= =?us-ascii?Q?IJpvwjwvehXcgcY9Tos0A3Itt/UFixj93TNg?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(61400799027)(36860700013)(376014);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:51:00.4603 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79ebaa90-07e2-41b2-9ab8-08dddfe83731 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044FC.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPFC1DE74F70 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIwMDExMyBTYWx0ZWRfX3v8YOw0pfN1i DejZVFVBNaC7Pg6YXzFqbRUVw7AJ1OZB7629nG8kffATWbi2Hb+I+5+lrryQZTW1vL39AimLwmU q0fB0PdEfuKBW/cAEaZ21XbLa+WP22SWOmbHFkh5oOefafv9Ytdcq6GALlawbuIa+8oaiywgVvM ULTDEMOlh/3WxEwnel8g265773R2dgf2slsKOLUPzJLzsuIMmE+EPTXxDzllb9RtdEqQgbmrsDK kZCP13Jx4e2gHWnFqibzHF75QTENUg0lkKgcugW0jIWdNZWrsDktVUqgDi/EI5TcFdA5nzZSNvU jlSM6WqFf6HISAWrc9Lh6GJLtBFqhK6DvJGEVR/Q6+X66HWCv/LHZdtoDnax1FCAesq7lAoQGBy CUBkCV+8LO7eJS7TPqToOXcW0CT78Q== X-Proofpoint-ORIG-GUID: OTsYJ62HL5MWLvCGf3T3GMQIqMyHqVfe X-Authority-Analysis: v=2.4 cv=EpWLbScA c=1 sm=1 tr=0 ts=68a5c4b9 cx=c_pps a=OlAd6myHLz+OteJZ2xboiA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=2OwXVqhp2XgA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=rSAZ-gJm6b_PRif3JyQA:9 X-Proofpoint-GUID: OTsYJ62HL5MWLvCGf3T3GMQIqMyHqVfe X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" From: Richard Fitzgerald CS35L63 uses different algorithm IDs from CS35L56. Add a new mechanism to handle different alg IDs between parts in the CS35L56 driver. Fixes: d3197a09a117 ("ASoC: cs35l56: Add initial support for CS35L63 for I2= C and SoundWire") Signed-off-by: Richard Fitzgerald Signed-off-by: Stefan Binding --- include/sound/cs35l56.h | 1 + sound/soc/codecs/cs35l56-shared.c | 29 ++++++++++++++++++++++++++--- sound/soc/codecs/cs35l56.c | 2 +- 3 files changed, 28 insertions(+), 4 deletions(-) diff --git a/include/sound/cs35l56.h b/include/sound/cs35l56.h index f44aabde805e..7c8bbe8ad1e2 100644 --- a/include/sound/cs35l56.h +++ b/include/sound/cs35l56.h @@ -306,6 +306,7 @@ struct cs35l56_base { struct gpio_desc *reset_gpio; struct cs35l56_spi_payload *spi_payload_buf; const struct cs35l56_fw_reg *fw_reg; + const struct cirrus_amp_cal_controls *calibration_controls; }; =20 static inline bool cs35l56_is_otp_register(unsigned int reg) diff --git a/sound/soc/codecs/cs35l56-shared.c b/sound/soc/codecs/cs35l56-s= hared.c index ba653f6ccfae..850fcf385996 100644 --- a/sound/soc/codecs/cs35l56-shared.c +++ b/sound/soc/codecs/cs35l56-shared.c @@ -838,6 +838,15 @@ const struct cirrus_amp_cal_controls cs35l56_calibrati= on_controls =3D { }; EXPORT_SYMBOL_NS_GPL(cs35l56_calibration_controls, "SND_SOC_CS35L56_SHARED= "); =20 +static const struct cirrus_amp_cal_controls cs35l63_calibration_controls = =3D { + .alg_id =3D 0xbf210, + .mem_region =3D WMFW_ADSP2_YM, + .ambient =3D "CAL_AMBIENT", + .calr =3D "CAL_R", + .status =3D "CAL_STATUS", + .checksum =3D "CAL_CHECKSUM", +}; + int cs35l56_get_calibration(struct cs35l56_base *cs35l56_base) { u64 silicon_uid =3D 0; @@ -912,19 +921,31 @@ EXPORT_SYMBOL_NS_GPL(cs35l56_read_prot_status, "SND_S= OC_CS35L56_SHARED"); void cs35l56_log_tuning(struct cs35l56_base *cs35l56_base, struct cs_dsp *= cs_dsp) { __be32 pid, sid, tid; + unsigned int alg_id; int ret; =20 + switch (cs35l56_base->type) { + case 0x54: + case 0x56: + case 0x57: + alg_id =3D 0x9f212; + break; + default: + alg_id =3D 0xbf212; + break; + } + scoped_guard(mutex, &cs_dsp->pwr_lock) { ret =3D cs_dsp_coeff_read_ctrl(cs_dsp_get_ctl(cs_dsp, "AS_PRJCT_ID", - WMFW_ADSP2_XM, 0x9f212), + WMFW_ADSP2_XM, alg_id), 0, &pid, sizeof(pid)); if (!ret) ret =3D cs_dsp_coeff_read_ctrl(cs_dsp_get_ctl(cs_dsp, "AS_CHNNL_ID", - WMFW_ADSP2_XM, 0x9f212), + WMFW_ADSP2_XM, alg_id), 0, &sid, sizeof(sid)); if (!ret) ret =3D cs_dsp_coeff_read_ctrl(cs_dsp_get_ctl(cs_dsp, "AS_SNPSHT_ID", - WMFW_ADSP2_XM, 0x9f212), + WMFW_ADSP2_XM, alg_id), 0, &tid, sizeof(tid)); } =20 @@ -974,8 +995,10 @@ int cs35l56_hw_init(struct cs35l56_base *cs35l56_base) case 0x35A54: case 0x35A56: case 0x35A57: + cs35l56_base->calibration_controls =3D &cs35l56_calibration_controls; break; case 0x35A630: + cs35l56_base->calibration_controls =3D &cs35l63_calibration_controls; devid =3D devid >> 4; break; default: diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c index b1c65d8331e7..2c1edbd636ef 100644 --- a/sound/soc/codecs/cs35l56.c +++ b/sound/soc/codecs/cs35l56.c @@ -695,7 +695,7 @@ static int cs35l56_write_cal(struct cs35l56_private *cs= 35l56) return ret; =20 ret =3D cs_amp_write_cal_coeffs(&cs35l56->dsp.cs_dsp, - &cs35l56_calibration_controls, + cs35l56->base.calibration_controls, &cs35l56->base.cal_data); =20 wm_adsp_stop(&cs35l56->dsp); --=20 2.43.0 From nobody Sat Oct 4 03:17:21 2025 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B45D62DECA3; Wed, 20 Aug 2025 12:51:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755694270; cv=fail; b=RueFTIzokfVvN0fsW7MIdALXpf4ytX4G4lMSk/TFw5e2ayyTWzd1kz9GpfUh+AxhbpPDDW66bGPXwZd8ZxVLMfosjDrx8HL5OUs9tzp1wImhv/g7G1xSnHR4loAU9zQUjbAUwMoWnQ00S69qq/fU7rg17h7XiHpzcTJvkUQ9Yio= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755694270; c=relaxed/simple; bh=x8+NFzRjeMUsMak6480YA1PqMX8+coWLV2hT+2+3xFk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hqFkZt/Pr1Otz2TjWDT5wyZ7ncXoOnOHxVs2iqzKPelomO6W1wyo0bpybb3tgc93cdWuJWIxpFXXCe/9Hl3PlrnHp2zKENHcIcN1e2HHSD5CsVFphMmnz2EULrI1097tgqs3DJ0QDZvabF0CT3ZqCqHoB7xBK+2SfaeTzBrzglA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=KfLcNyEk; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=XuLlHFoV; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="KfLcNyEk"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="XuLlHFoV" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57JJYrkO368685; Wed, 20 Aug 2025 07:51:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=yozTj0/f1c5jh3L8zj9gvJya937f6IUR9XK0PekjSX8=; b= KfLcNyEknDEDb+AWQcdq+ggew41YmL9vJ+ObktBM+O9zl4s6XLyYvYGHTttDdAXG dyMGSXs7uS/Ep4qTy/M6e7py/TvCVxnkqkOE0OnEa6Id7Jkwe6YygQR1sJwlWDUe 41mSLjyURTObg/zsS9HR7XiOTNtfSZ9QGFfAkuvuEQflVRJ5ykGuvXddKqDwI2mx 4JPnms/07j2eUDcy6dzxim4e/NzlXRyBOBjkgr7CyvVvpvnMWJVH0uUFXKWc0Qjv Vg6xP8WUCZSHs6n/964ALWQh3TpC13PD0GMx+pTM5d1xwFTWgl0jg7CbCn9L2Xhh oJ8ncuAFfdkzwMF3IZHRBA== Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04on2136.outbound.protection.outlook.com [40.107.100.136]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 48myd9971q-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 20 Aug 2025 07:51:05 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pEeVHtPleSuJ0EfNBSNH8IrRVu/DIcpaAm5MNXXvm9w/Q+9LWYWa/WDKWaAvYySsaO1H6f6+lZZHUPUJxnWYTimptO4aABnDcX0Wq6tedUuZpwGXoh1TdLDw+jtQfLxUyWawmZbBJzV4oAgKZalInkh5O77FjBISxG9AyCu0hXYBS2wswjnEmGOx0qjtEAW0S3FDImcqjvyY1f+DzqXpYF8PtfzIAZlJADNWZsAS/ND2MULPJjgazeebT1K6+zP/VcyQKeTRyQd/itjrTPy5bE4RWm8oZcq7fAjw/z1A5f5q0JzCG3Wd51pEXY1SFDFgbUKhKMOVKS7Hhsqt8qvMvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yozTj0/f1c5jh3L8zj9gvJya937f6IUR9XK0PekjSX8=; b=aB5gM3tjttBeohEBov3Mk2TvM9CINw5gyZJjTTtuThMSIQXGS0JBFNlud90rbgJ8uKKmtNOVBHTr5SdQO7ckNH0piKvrHN8C/tXCml49R7Q6oXYMnyziLkyynM6PEKmwnhMtsCu92JTT1aIShPM02kLrDgN5J+xON1w4YTBks6lvV2MDtOZ8AFbcM5uzU57lIqN8ic4JgmtGlvDo6yDQ42+BahLSTaIuaYRVwOquW+RdGHazDrX4dSEJDEIItx3nVi1HVxGq0T5mzmTSRY1GBmioD7tkp6FfQYbqvIatx1t9ffxl6tTjWEuWc5wB0yFyWU3Su14FWGHAv9kR2XUmIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yozTj0/f1c5jh3L8zj9gvJya937f6IUR9XK0PekjSX8=; b=XuLlHFoVbhR5F+Qk5zAZotD7DqZPcQRcUGs1beuA/cOr71wI6EsVIJS6PIlk6OcwyU8sGo20EXVoJfK0eqYyEoX656zENZ9Q/Rg0cngmC/VfEQ7BtIiZoZlqSM1h+EJjAHFjYK1rAsr4h5rwy4NoGm6tlwjeBxk/A60hGA9hss0= Received: from MW4PR04CA0317.namprd04.prod.outlook.com (2603:10b6:303:82::22) by DS0PR19MB8776.namprd19.prod.outlook.com (2603:10b6:8:203::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:51:01 +0000 Received: from CO1PEPF000044F6.namprd21.prod.outlook.com (2603:10b6:303:82:cafe::36) by MW4PR04CA0317.outlook.office365.com (2603:10b6:303:82::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9031.24 via Frontend Transport; Wed, 20 Aug 2025 12:51:01 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CO1PEPF000044F6.mail.protection.outlook.com (10.167.241.196) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.0 via Frontend Transport; Wed, 20 Aug 2025 12:51:00 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 50AAA406553; Wed, 20 Aug 2025 12:50:59 +0000 (UTC) Received: from lonswws02.ad.cirrus.com (lonswws02.ad.cirrus.com [198.90.188.42]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 2977E82024A; Wed, 20 Aug 2025 12:50:59 +0000 (UTC) From: Stefan Binding To: Mark Brown Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Stefan Binding Subject: [PATCH v2 3/3] ASoC: cs35l56: Remove SoundWire Clock Divider workaround for CS35L63 Date: Wed, 20 Aug 2025 13:50:36 +0100 Message-ID: <20250820125045.117740-4-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250820125045.117740-1-sbinding@opensource.cirrus.com> References: <20250820125045.117740-1-sbinding@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F6:EE_|DS0PR19MB8776:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e8b6870-94be-42e0-706f-08dddfe8374e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|376014|61400799027; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Km5lHT6WOwIZ3pslVLfYrOpQpWPY5ch5TxBHRb5ghBJomtM3VWowVKv0rWYC?= =?us-ascii?Q?xF8UuG2vwORy3iQizLEPV8qCXGpE/G6X2DfhAgC9dhJsI6lxzTw8pmTEPb+M?= =?us-ascii?Q?1U9pXNjvGTklHnpmlNjYfgp4AbOduILocs14HqTKrWNjcAcoH+ZUQc3kRXMV?= =?us-ascii?Q?GFaBzK9FhZybul162kql1zJbJS6n+tYpepoNlq6ccZATPPIrzEPZZEBQlboG?= =?us-ascii?Q?pXpkTJWUaT1cFrark/eq/l+ou1xpj5Oa/VFgBe+EF1IbU0mSE/nHr/M3VG3N?= =?us-ascii?Q?aAKmWxyWOBDEdh97GAidg1ccoOxd1rB3SmX/yZqE4ap9OByVPknsLwDz1DZF?= =?us-ascii?Q?O/2sxPwmQxV8cwqJnIQGIaR0wRiUNR63fqp2LcXr+wE6ZNxG/jzie0b1gAiG?= =?us-ascii?Q?DY3/GCu38ff3ceD6SgJLYJ/KdTGNNB+vA8E94GZIwm4KTazuKOxF7V+jmhtd?= =?us-ascii?Q?HeBBmwv0xBhTaD95zRKY3wEwV9UgUp3OIwIl6jC3G7KWcsdlPn4ILZxhdk4O?= =?us-ascii?Q?d0z2Ah+B0R8dlLVcaxOUIquL11VLlJPF+XIobm2HHe2K3PjU8uwgEKfC1m+H?= =?us-ascii?Q?vLp5dfj7HvH1PkEoBsM9gjRvFgvLQsRl/eCVmL9OlPUaT4DXqp697Ism/e8U?= =?us-ascii?Q?5fiCe7fmlhAFPO0iajQI6xkyDbA3ufiIwWihlv4Jlk4qjwiG8kqnUrv71R5t?= =?us-ascii?Q?ZIx3loRe4rSmklkhlqD2nlZ/XqsFeJEIGoIrq6xzIcSMN4fEoZRGQJay8Y9r?= =?us-ascii?Q?jjhNZGw21PtwgIkihEz3NDfttJPc09NCr9b5LNXIe7fYFLy1fPc0ZQ2G+637?= =?us-ascii?Q?yJwrtBs1TpSpLEArLB4T0i7eKVg2p7jwHff5rOBhrEPc9klywtCCQC+g+MT6?= =?us-ascii?Q?D3fL6vkR8WMX3YF1wSc2VamGkj8tePIlPYSME5RlXs23Fq76+yS/+YpfjSlq?= =?us-ascii?Q?Q3sj2JZXsfloNniulnxiEWQnHPTuNfNSrin8eo1yztnlhGDyZIFjKjWtYVEd?= =?us-ascii?Q?NCD0U//odODmcspetTgzqlPkxz0qbtAzUOv47CzjOUKhNSkbfRQNBL2f4CZ3?= =?us-ascii?Q?PVauXMHdZLvJBLLr/QvVFm/Q59+17a7Kx5faYPMhqoXq1kjWDez6w+KGHbU0?= =?us-ascii?Q?iDqfLBHcb0B67phpOo9D/6TWMwXmbDsC1/aPGFgPKa7ziGvwNirwIFNQSuts?= =?us-ascii?Q?vJZH6C3yFg76H/g3g7Yqq99ZTSJ4KSniD/jhwrlH4v3G8hFpwMO/n8edx4ht?= =?us-ascii?Q?1c2hqZH2ZpfFQUcXaLCwMuBhhH3upGX/Ft3zKP+tU27uXL0Uh4edzVIMSHAq?= =?us-ascii?Q?8jis9C+r8ESuwQ1WyiugPgr/Ks8eO/4DknNHDyjwUDaf9fv6xDr/IIJSdq0/?= =?us-ascii?Q?0ebSB3jIwTGQi/9LWQM5P0dGC8TBQJpDFJUiZ43T529DLCWRuVZ3+gfK9XoQ?= =?us-ascii?Q?qiBJDck49WmBV3GNiaP67g4g5A+DTzEf826K0XOUZRO9+7pG0H1nsyDqC98f?= =?us-ascii?Q?ML1K6bTs4HLHMxXoNY8GRAPKliAPdzuzVzLB?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(376014)(61400799027);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:51:00.6502 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e8b6870-94be-42e0-706f-08dddfe8374e X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F6.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR19MB8776 X-Proofpoint-ORIG-GUID: 4ytZwmh2TZqd90Gt86I8TH_SEjMvLI47 X-Proofpoint-GUID: 4ytZwmh2TZqd90Gt86I8TH_SEjMvLI47 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIwMDExMyBTYWx0ZWRfX9xMQLqgipOms gt0XkNUK5lql0zzXHZGwghDUwDP1DtVGZDaJxhxrjhR6iYTTY5NUs/Bzjtypos+c/g7eZ8PnYCI lxfK1OBqe0KCAwImZu3PEdQEipqRKBQxoEO0AjwBciTIq5Myab23Lbmpbvd79gccp9RR7KhXxPE bWjTCKGKuaJnuW/UZtAanRFYNzJAqrnR+BMSp1mjoyX2S2ia6qZbV8pXKRSLzrc3B9WLgYasE1k zDXLScEJQLHfZ0VzNi5rz2aGVwjMyi4gO0McBQzDQQh/dT2AoDLBvLFApSiVIz3FgnPfd68gMQP drXruSnu7ZTgVTIlzPkTZSiQaOLpN2jDUeTWJnKrPUw/+mVbZepf+tTkyDRNJuKm7eYEp+LT1jb o95bz7uHyZkIFZYCg9v6egUNzRCXVg== X-Authority-Analysis: v=2.4 cv=WIwmnnsR c=1 sm=1 tr=0 ts=68a5c4b9 cx=c_pps a=D0xTqnO8G3g1I/JDCPG9pA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=2OwXVqhp2XgA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=w1d2syhTAAAA:8 a=Eqq7O2SyaTNHdlpsiP4A:9 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Production silicon for CS36L63 has some small differences compared to pre-production silicon. Remove soundwire clock workaround as no longer necessary. We don't want to do tricks with low-level clocking controls if we don't need to. Fixes: d3197a09a117 ("ASoC: cs35l56: Add initial support for CS35L63 for I2= C and SoundWire") Signed-off-by: Stefan Binding --- sound/soc/codecs/cs35l56-sdw.c | 69 ---------------------------------- sound/soc/codecs/cs35l56.h | 3 -- 2 files changed, 72 deletions(-) diff --git a/sound/soc/codecs/cs35l56-sdw.c b/sound/soc/codecs/cs35l56-sdw.c index ee14031695a1..3905c9cb188a 100644 --- a/sound/soc/codecs/cs35l56-sdw.c +++ b/sound/soc/codecs/cs35l56-sdw.c @@ -393,74 +393,6 @@ static int cs35l56_sdw_update_status(struct sdw_slave = *peripheral, return 0; } =20 -static int cs35l63_sdw_kick_divider(struct cs35l56_private *cs35l56, - struct sdw_slave *peripheral) -{ - unsigned int curr_scale_reg, next_scale_reg; - int curr_scale, next_scale, ret; - - if (!cs35l56->base.init_done) - return 0; - - if (peripheral->bus->params.curr_bank) { - curr_scale_reg =3D SDW_SCP_BUSCLOCK_SCALE_B1; - next_scale_reg =3D SDW_SCP_BUSCLOCK_SCALE_B0; - } else { - curr_scale_reg =3D SDW_SCP_BUSCLOCK_SCALE_B0; - next_scale_reg =3D SDW_SCP_BUSCLOCK_SCALE_B1; - } - - /* - * Current clock scale value must be different to new value. - * Modify current to guarantee this. If next still has the dummy - * value we wrote when it was current, the core code has not set - * a new scale so restore its original good value - */ - curr_scale =3D sdw_read_no_pm(peripheral, curr_scale_reg); - if (curr_scale < 0) { - dev_err(cs35l56->base.dev, "Failed to read current clock scale: %d\n", c= urr_scale); - return curr_scale; - } - - next_scale =3D sdw_read_no_pm(peripheral, next_scale_reg); - if (next_scale < 0) { - dev_err(cs35l56->base.dev, "Failed to read next clock scale: %d\n", next= _scale); - return next_scale; - } - - if (next_scale =3D=3D CS35L56_SDW_INVALID_BUS_SCALE) { - next_scale =3D cs35l56->old_sdw_clock_scale; - ret =3D sdw_write_no_pm(peripheral, next_scale_reg, next_scale); - if (ret < 0) { - dev_err(cs35l56->base.dev, "Failed to modify current clock scale: %d\n", - ret); - return ret; - } - } - - cs35l56->old_sdw_clock_scale =3D curr_scale; - ret =3D sdw_write_no_pm(peripheral, curr_scale_reg, CS35L56_SDW_INVALID_B= US_SCALE); - if (ret < 0) { - dev_err(cs35l56->base.dev, "Failed to modify current clock scale: %d\n",= ret); - return ret; - } - - dev_dbg(cs35l56->base.dev, "Next bus scale: %#x\n", next_scale); - - return 0; -} - -static int cs35l56_sdw_bus_config(struct sdw_slave *peripheral, - struct sdw_bus_params *params) -{ - struct cs35l56_private *cs35l56 =3D dev_get_drvdata(&peripheral->dev); - - if ((cs35l56->base.type =3D=3D 0x63) && (cs35l56->base.rev < 0xa1)) - return cs35l63_sdw_kick_divider(cs35l56, peripheral); - - return 0; -} - static int __maybe_unused cs35l56_sdw_clk_stop(struct sdw_slave *periphera= l, enum sdw_clk_stop_mode mode, enum sdw_clk_stop_type type) @@ -476,7 +408,6 @@ static const struct sdw_slave_ops cs35l56_sdw_ops =3D { .read_prop =3D cs35l56_sdw_read_prop, .interrupt_callback =3D cs35l56_sdw_interrupt, .update_status =3D cs35l56_sdw_update_status, - .bus_config =3D cs35l56_sdw_bus_config, #ifdef DEBUG .clk_stop =3D cs35l56_sdw_clk_stop, #endif diff --git a/sound/soc/codecs/cs35l56.h b/sound/soc/codecs/cs35l56.h index bd77a57249d7..40a1800a4585 100644 --- a/sound/soc/codecs/cs35l56.h +++ b/sound/soc/codecs/cs35l56.h @@ -20,8 +20,6 @@ #define CS35L56_SDW_GEN_INT_MASK_1 0xc1 #define CS35L56_SDW_INT_MASK_CODEC_IRQ BIT(0) =20 -#define CS35L56_SDW_INVALID_BUS_SCALE 0xf - #define CS35L56_RX_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24= _LE) #define CS35L56_TX_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24= _LE \ | SNDRV_PCM_FMTBIT_S32_LE) @@ -52,7 +50,6 @@ struct cs35l56_private { u8 asp_slot_count; bool tdm_mode; bool sysclk_set; - u8 old_sdw_clock_scale; u8 sdw_link_num; u8 sdw_unique_id; }; --=20 2.43.0