From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020141.outbound.protection.outlook.com [52.101.84.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 069AF30AAA9; Wed, 20 Aug 2025 12:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.141 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693209; cv=fail; b=t4RW1qEYZ9D6DJ9SNf7GOeflg0ri7B+ajrovknthIymIqt7iVWq7OFlWsj85jxoTNBw/h9pUXXqFlj40L+Y1fsn1mRnDqqTeZLuN0lHTDxWFrPA3ySeMF0jAZWSeMK24K+zI3TnPMcLmqSpzqGZJnJ8S7JOUvJILcuVlSGxl7/E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693209; c=relaxed/simple; bh=yfVgRyVAlRoU3SzK1GEy9nQvaGLglKASwFFrlb9QsS4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=LpVowofSKCnI5+3lyKlc6Hkksp+CI7ZFjI5FB1eM7X6eIMDtRb0rzQ7D5mx4GoBJvTQYHJ+0lNv9tqp4VzbRbV2Wfucjvl2ekU7McCMRySCPyLZ3YfoPsEX7nOs+buPtD2UoUZbl6e0WN0N5YfK3eQ7UIxgMA8ZIno6NcGnaLQk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=F6n/zuCR; arc=fail smtp.client-ip=52.101.84.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="F6n/zuCR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mtsGUmiUHAqZguWd0EptVGQ116ybLqvyZT4qiBRseHFcc36VO9FwTpUaW//C7ZL5EBKROYkCtjIuIPCEiCxcpjv6mMqqXr1myQnY38JCQOSZ0Wl3Tm06ZP8Tp051WUPw/r4zuv2UNzaYn9BI+dA96OBjiQrKPk2M5NndgJkkwaJE+Bj8T9I6wU6TlX/lHlbbqsUcWB1+RDWgdb9EkBJopEsX/K1kiPMxKdHdhAOnIzKooVj5uI20X5WHE9zmYcUSgojDawt5CH4CV2lr1t07/3m+UwwlGvpdhhtjTr3b0pGcttS/5ES/izI82RWpwkuzX+GRtFfF4hFMNBtx5GD25g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=afEq9bHX/2s3KBTTklyPlyvAIAF9EeHEPeuOYA/bDc0=; b=m6CO6nRIdrUpH7MB6GQbIPc4pjsxiTCh3QYn8YwDBK3zXhXp2LBkYRZ0YKLAeB6XeJz9whb9td5Q6VdVbWXwXXKpk0CXS3DI/LQSI0Otg/g0fD/IIYNE7cBRFo5wpqydvOo3sPR6r1wfaFNuIAjkdMO8tQtAKkoiqZE69qS7X/M6knai8nU4T6Vkb/uqLfPkLp4OvkB27FOZ1ZkINZ4mV/I830dgz3iXhf6Amxs34Z/rgAUisLU1CKTdKvuL9dyLKvLdrBfJ5zJNaVciSjxC2SBoH/irV/u7IBkIJ32PRXpCrJyFhohnPltQVX4hqEWNoLWVR4rbNPkBRUlJPfoqmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afEq9bHX/2s3KBTTklyPlyvAIAF9EeHEPeuOYA/bDc0=; b=F6n/zuCRaI1UV5bM6AfTDUsqV1RQxitFOWUjIeTcKxHGbLJyxaPqeFRuVmw0JVqoahLXV6/1K2Uv4uRsHeh8w3ZxYTSg/KHvzXP6vsUZPUcdmAmKlLZQsFFS0bOfZkAyJySXg7HP3mNqhQMCrYVzMcBC4TBeFvCjV+auA5WuDS83Iwi0/5PWJgbNo2SuwqEDap0yfwv5NOk2yFN6xVVSEFokecfdXoUi8J+f2V+pcpJdTlCwL0r0ntVpL49NE3C4nxLlZkHb3rDzozFCWb+oFQnkYvtA54hjxxW4LxGT9rlcCNpPFEyDX1TD1pqD7KvnROrj9oCEAvK96weBls1+Zg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by AM8PR08MB6355.eurprd08.prod.outlook.com (2603:10a6:20b:363::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:25 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:25 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 01/14] spi: airoha: return an error for continuous mode dirmap creation cases Date: Wed, 20 Aug 2025 15:33:04 +0300 Message-ID: <20250820123317.728148-2-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|AM8PR08MB6355:EE_ X-MS-Office365-Filtering-Correlation-Id: 6187583d-3b27-4d6e-5ff4-08dddfe5c1e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PSKCpeNNL41cUq64A+k4tlgi1LX7ETSlbvue/vau+DxcEkXvoWrEavGiDlQC?= =?us-ascii?Q?EDqbwI7Qfi6/bephpwWCr/lvggHCMtrZzd8nTC+aPrC40+DatDBpr/Ej57bG?= =?us-ascii?Q?vxbwMXPbg+aBcxk91OMALH5cr3+F53YtKrD7aA2wpht41ig8cDYY0hg2/b4g?= =?us-ascii?Q?OjQ9S/My5keeKn7OQWAtEXQDDIy9Avg8B/gs9q3ZXXBl//90B7z5uoLetgZA?= =?us-ascii?Q?hoC3iqKZ5b/l8X7N+JYaJLSAQMtm8qMgEf0JCmMkapRj9Np8wIEFATXGmZ9L?= =?us-ascii?Q?1+wP/WGHXJ4Rnuam9Rth2GkPuap5ElMIWBB6nGbGmpGSZcum4U+Hc6hP8KTH?= =?us-ascii?Q?zgrWUHD0vD2Fu6S66KZjjR/5TzKWTYRMwBQrnmol9VlkEwxbOyAAPp5XGJAM?= =?us-ascii?Q?F5h/98Nla7266Q4Yz1+hIOzjAmIHL2t7Hevz7hCg0MMBzBnuBhlDKHxhhLnF?= =?us-ascii?Q?A1khCs7/rmeyMoncy77nDZ5CuVKe6Z1T+qkRx1eOCmI4RIOLyxk/cL5Hglb4?= =?us-ascii?Q?DUe2vtxOMtmh8A0eYBvvbOobqMmuTinuInGqW14PQrQjoENlIQ2Gr7LB89Zd?= =?us-ascii?Q?Arn/cGG75YSbBQule3o+8vJ3JGMd4Dingbv4/63kERUe++EIsM8L46qttPDR?= =?us-ascii?Q?G7HqdqB0nFaLuLTK1hn8ydzB+XQvumVJNIVbiJ1ehsZBCxLSBfMXylaZwefA?= =?us-ascii?Q?z6jqUXqn0Fkr+qV1CKUHjyebmMvOPG87lT0duy8RDGFx9OxIpoZ4oB4efp2s?= =?us-ascii?Q?Gi6wu7PQqoi404lW8AzTsaI+1h42XxoqJCPGScK4MbXfaNDSs0AeXuFRQbuN?= =?us-ascii?Q?u0mTFumBQAIp0tBG+icLxyu3r5d9Cyp7cBSbqjZ+QfVfVFjNJnd6dn1PtgEa?= =?us-ascii?Q?3aJn9MCcuznRMT6O7v6Zkgz6ZA9fGF5XQIJSS1mbnP4jWJE0MreFjQ2ePAEG?= =?us-ascii?Q?s0JsIFb8ETKuZ2vZMnjlE7PC4Qo/6GNLkaMN0iGmf09zaq7ANOxjpYH/Wx6x?= =?us-ascii?Q?VAZqm4XxXyRW55t9GOiBd8kAFJ2C+IlMKjRvU/m6N2z2BJlFfOaU/lScWkPv?= =?us-ascii?Q?4kNWIlwt2CE8thTy+/+KWcYYY3dGhD94Ff0lFEG44LHWuZIyaNgOQ3PiP4jx?= =?us-ascii?Q?39qU0wMUJil+LPNCsRWEsEqhmOVB5sRA11CMT7qdNjVdcfaTSmlZhGAcsnPl?= =?us-ascii?Q?oZDP/th6ePkA+PyMPMwjubvutorPctWBTlXgF1yKdRYWPxhDLbCckFqVHzHg?= =?us-ascii?Q?szo+k5xpQtzsvgLHJXz6rFys66LJOFdRzRTPTw+2VtPpCwjyd6VddrGyX3UD?= =?us-ascii?Q?foH2gOy5AXToq5zK1g1T2fTSOpPszGlRDFEm6ZVHeSPUJYpVK8qnb/Y+o/uZ?= =?us-ascii?Q?meEQ+yhvkRm79N1sTGbDDpmVXtD3tkbFF1RMrazfbetPXaCWmnubH6itg8k0?= =?us-ascii?Q?XuoO5CTkPbGtZIt3Usbz5NW3qgw3nPrUO/uN00DKEwvlAyoazOQxYA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gc9A8skn4uob7+Gyy6kJvlcLZeOi8wPPk+2DQTPJ0w1RsqrHS76v1a22f6We?= =?us-ascii?Q?sr9xylY1d84Si1uzmvB+EVhVEK7eFgk9YjVoNT8N12+CxqAciSO1ZxI6+mFT?= =?us-ascii?Q?bSxDy3pPnHy8WIhH/tjFn563yzWnc9+wOhLrQrawiBA5/Povuvn0IfqZz77y?= =?us-ascii?Q?rynv0l//67Z02+za7JVc2Sp3tZqLBmzGH62jxTObJMusQdGfEBl2Mu6kJSRO?= =?us-ascii?Q?wi3V5jDcOXkCfs3ktYHLZwAafZhNz0r/SDEircjCsTRJbDn8abpd8twb/mM0?= =?us-ascii?Q?6YjENjHtodEVYS/52sGHGR3xC37m8OmWkMiHlpnHSlJC7Q5UG5jbm5zH7EsC?= =?us-ascii?Q?wgoIpPjYa/CIjJedADcVKSJdsap2jCn3IQ8pejtdH7VOnahEt5BNgZTaNjwZ?= =?us-ascii?Q?4UjXHuQo8S6XEEetRfUZWvljVyysKZB/4tkonCWHGWi7ok3KsQD1Y+nWanV9?= =?us-ascii?Q?jDk48knx//sv5sRabApqfDdscTdUzgDIzQylhCfiPzmBY02K4bvDEfIFPHQm?= =?us-ascii?Q?N0jrNpkzYRBsS6SQXlqVoIHOdLQczVW+B2JutIiBnYVdX2gtpAECMYB1R+lW?= =?us-ascii?Q?4oNujlKl3qGlvT5zIo4tg3uOZ5dlv78e/8oRHvx8cEHvjWPJGgFyZQ1RrQZm?= =?us-ascii?Q?IRvOGGIamb5FUXFcBptmkKuD2PyPjtcK4pi/lUHDzwk5pbBWoIj54PerLIZP?= =?us-ascii?Q?RJKPemRpsGnPpwpj3jBbVX5KSXWjW16Ht8kNcc1WJzKRs2JXicDJafoyVgJP?= =?us-ascii?Q?qOcHTOoW64hF7KTvJiHMnCq5B8IPWcGoXFHc0RInaXWORGrbH6AgLs6hb5ZA?= =?us-ascii?Q?2O1wba72l8Yobnk1Q4ga78Et6UfmK6XQhC1eTZBmfhJ+7cKbnXjHWp6lGX36?= =?us-ascii?Q?pnsUCT3gWoPYfi+zNp+kt+DMM1Z9Hz/Li57P2c4Cc8eVUQmUA6CTpxNe3BpG?= =?us-ascii?Q?zQ4tRj/1u+FLkZssvO5hDHAsH5q41U6mOcHT3Q7/9Nd+TKlYfD8tVZGM7t5l?= =?us-ascii?Q?nn/2iqQa3XIDUDwpw9Hg5mrXFSiO+V8l78tIzrNksKC6+jshQ829dFYB726T?= =?us-ascii?Q?pJcGj+DQAOcMRpWNzxobZZg+MNRHW4ZokJjyGl1hssI7qL1PaxHBvcSLSLEG?= =?us-ascii?Q?VKUqRDzrQ7odSFa8NIkte24TApfLP+JvKAu4S9OADpbkfchlnOMS5/vgxiAe?= =?us-ascii?Q?6CD2q8WNS/mfShuqcYcSEhJ0mndC5iDksOE4/SdpdzOi+cZ+0X8B/suIHLgd?= =?us-ascii?Q?0rAfWhcBlbJ4sHFlrpKQj3mdTJBKUeSm+AnfMRvhtKsWLuF7Wpe5L79CSb5L?= =?us-ascii?Q?NCT8OZbkigrojWvmp6jeaF8CMdYfHta/shDiSfMrIeCH+4cZszCFeGEZpJae?= =?us-ascii?Q?Fc9ERFvnuURYgFexSz4NEkYmOltpqsVqE1WOLJRrRpEh7UJWl5IcmRR8/HeL?= =?us-ascii?Q?mkMeL/NdhHQBs6mJUEDnf/yfLeX3/h5Fzft81N7tO8pPIA85u/8PC/t0DM/E?= =?us-ascii?Q?zS53GqRtTRAtPWzewTbuqK7jBIvgOaUhLyLzbROjtrecra4DEGzZVCMoZIhI?= =?us-ascii?Q?uaoa1s2O/7Q9TnKfwCcTIsNrB0oKA271lEYC40rok0uPw6ywTP0iVFMZXOwc?= =?us-ascii?Q?dCoq8lHG3omdFtrgT6ywRZY=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 6187583d-3b27-4d6e-5ff4-08dddfe5c1e9 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:25.2245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Exl4e2KlfRx4BO+not1DsLOZjijtcpjpY1yLlqLhMOGrLvKmH8TYX0ubV+zvwsrE6+9hr+ppXh7zApMkIn2AxCVJ0FTg/951Dpx3lb6oc1o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6355 Content-Type: text/plain; charset="utf-8" This driver can accelerate single page operations only, thus continuous reading mode should not be used. Continuous reading will use sizes up to the size of one erase block. This size is much larger than the size of single flash page. Use this difference to identify continuous reading and return an error. Signed-off-by: Mikhail Kshevetskiy Reviewed-by: Frieder Schrempf --- drivers/spi/spi-airoha-snfi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index dbe640986825..043a03cd90a1 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -618,6 +618,10 @@ static int airoha_snand_dirmap_create(struct spi_mem_d= irmap_desc *desc) if (desc->info.offset + desc->info.length > U32_MAX) return -EINVAL; =20 + /* continuous reading is not supported */ + if (desc->info.length > SPI_NAND_CACHE_SIZE) + return -E2BIG; + if (!airoha_snand_supports_op(desc->mem, &desc->info.op_tmpl)) return -EOPNOTSUPP; =20 --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020141.outbound.protection.outlook.com [52.101.84.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB734311C21; Wed, 20 Aug 2025 12:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.141 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693213; cv=fail; b=gWRHPY2HYtw0icT8hfaRLbciFu3ogjC7MJYKDOrpgjtIeUg60tXP+OVEoRvzD75xVnd0kXP7dWLL7peDFkws+2H60qwqIiR42/KkWFvf5xDO24QK/yyvByzl3nUvW3Egp4/wuL15torPuYr4hcWvqd0jIcp9clKZChjgjoWfQVI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693213; c=relaxed/simple; bh=6wRPZ3JsQPvCRfH1SlYXJi0fdIPN3xQwBEBeQgxM1Pw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=KvPXAaQbCyuiRp0VFMBXe2CT4u5ZUwnOE7AWckOMJIaQqx/MUK0Yw8uFqDj0uLAcSmLiH+81bLPpmnFlgdf739W1fWq05veDXZM5WIWZhvWeJJm8CZvrZRKic52iJvEHC+Pa9vbih4KxFrb3cdTG2yxoyhPcgzNyNYZefd/7LL4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=s6edJEqe; arc=fail smtp.client-ip=52.101.84.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="s6edJEqe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Bth/NFN7SeJ9Mr20yIIARrtXB2N2bQRP3jmVBzzsPCvHRU22oLIltb1jBnC+irG+KiYxPZVkyWJFK9apiow8EEJjwm/8fKYQarlTcHbkS6Q+crLvVJqhTOu/XYf7p7h8OBCOjj6SYBkRlJLmh2KLyHUnsnXc1dDPzQH4ZIIcPq5QHp36C69Ibp7np888C6KIhsKNoyPoPu09rww8ZtzlAPbFoduLRS1fIVP5L+RR/694SWa93zIxhysNlLxKZ4GthKWP/vK737mftPmR00SGqvKdMna8RW7RcKdtopSCSz/c7+OdtoEk0CNO5p9zZZ0Xj9ebLrqUIOeniuj/y793uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dARcHoCM4HyMpVSyowxjeXYn0ojHi6T9vKH/YSmCFB4=; b=Cmu9pmfC5xMdW9a0y/dkkMPv8+6u4COuu7L9szidchkFblMRN3NPX4ipRY8icJm8xD6ReMyKOSGHoRUkOP6GRU+7Mzi3QgNtlPIPNbof3rErxbMrajkUzarfYm/EJeG/fmNPJt/7rrCVIfR830eZRBY4bDdwLfdhDcHgev6qLyDw5oeqMTiC5YpBfutZX7YQnVFgvQdKnX0eoWxKlYG5TAp1NLEyFCPIkGvYDjbNxs+YIpgwAMbouYbi6ARVPwi39VGJFQrf9p7CUoanq0jfym9jIQePL0Nu/LHf+X3Rm3ZBuoEqgrFw3LHuTCL/jsjq4MIzL8hqlvUwj+qjRhnhJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dARcHoCM4HyMpVSyowxjeXYn0ojHi6T9vKH/YSmCFB4=; b=s6edJEqeGK7Mf9+jOGypBtNKtFOmWLUWffImjUDT46Xyhe6y6nPXYmcjsoEA/sFL2QdqWzBt+gkaSfe5zE8DWzI/ASKjAP59KE8edIvy3LEKI6B5ZnhjZBxlvOgSGceJ67T0rqbP4Cq4IMIXz0WYIPOwNRF+zCIpZe1tJ4dYYsmoEj5+TB4/mXQzRgeYGERs1JyKQTdswyfcGTggzstqwbrItrSNvEdq0Nm3i7zvhPHC0XdklcFoHfw7Xu131wOTje0LkI6PuXer6DDZPGNaSJT1tVUj3bhgTQZcml6IhlHdeOLGiXSERNnrhP11hik1cFEMonZCwzAneubRgZvP5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by AM8PR08MB6355.eurprd08.prod.outlook.com (2603:10a6:20b:363::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:26 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:26 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 02/14] spi: airoha: remove unnecessary restriction length Date: Wed, 20 Aug 2025 15:33:05 +0300 Message-ID: <20250820123317.728148-3-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|AM8PR08MB6355:EE_ X-MS-Office365-Filtering-Correlation-Id: 60694f2b-d791-438b-19b3-08dddfe5c276 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IINP82Msrn5rFhUV8ayoc3YA+F+OkF9h4+W6I6S5BWxqaycoG6yeNL0M/mVv?= =?us-ascii?Q?Dq+8qcR3Y7WLRi47Jfa8V+jt7xVPsOU4d5lVeVP5TXPFsl//vvVX1QEY1sTm?= =?us-ascii?Q?BW1AfBTvIko89g91EF12An5cgrKvqekAl3U6juJumif+mAYqF36kVaZPTLE2?= =?us-ascii?Q?3/9RxEYRUWJhfo4B/PDPFvNOSKcQa3lIMeElfXbV52qcC+yxzC6YzgAgkYTi?= =?us-ascii?Q?UbG9QIw5vh9hhAqVPrMBC5JCu2i48joDB06bVTQAtc134NZHB1ED9PiUo8Zz?= =?us-ascii?Q?9Fb6Irxy0TpdJP6jPq5q2hy5PdVI1NnLguSjOD4LOgISrdF0aufRE5+lGfL4?= =?us-ascii?Q?m+gU3LyjGhFbDLq9uJtvAx3G3ESAhe+H/pqrErSiZZRk+oEPfjmW03hGdWyQ?= =?us-ascii?Q?kXq704pSm72BVH8Wi/Ahq55aPf9+u7M2OMCot/qRq0fJ+RY8p2AmXSRJCPCS?= =?us-ascii?Q?lHlRy59jJvtkwhLJw/k9LZsszCoqae+JRdxr3xNDK5Bou9kqrJ2lsFPCQrbe?= =?us-ascii?Q?Mir0X0TMmOj4Seal9UM6iRt0SBlHvrQOxujZK5Ul5kWKoAJdc/WHfhsaPJMM?= =?us-ascii?Q?+s1+9SblN3gorUeVejYeJtp7Vi8xQHxcJExgP5LyaDylYzLyVy7vSdeMsK2+?= =?us-ascii?Q?fI1430E+QaD8uubxeIYbGJ27A9TwdfqtJlwdg0D8WYIDQm3sTV0Q9q3atrTU?= =?us-ascii?Q?ErqEO2aHG3DE6FyHFhXY5pedmwq3BFdDOoEO4sSkRJy3zt+X8FptJO7c3tdc?= =?us-ascii?Q?05b/hNcdVBuvLIqQeBdxzdKolEKZUYhydy90LqEYwa3y7VvqLEhc2Zpphsnc?= =?us-ascii?Q?6OJarMMwAgTmrr8cbTVJ0FSVf0kWjiFl+OimSXzKvCG724n1y7VTRBPbytzH?= =?us-ascii?Q?GCgKGoNpEPpa0ZA3I803lFRfn2ncPuYRZOTljWJYRrQdr2k9A900NoYf8QI3?= =?us-ascii?Q?zWYuD1uLSrsrTiOPBRXDUO/PszMuifkbD12l7ae0RrONUlRz83gw66MT0CP9?= =?us-ascii?Q?aDIwwlRJuMFp0qtT7e1UPEH3GyAbaFGbLM+pqY0SzvOegwyKlr2hbal0zm6c?= =?us-ascii?Q?nJUvAU0W0VqEQDQilO+NjkDaOA+hk5sHc7sEuCmoES7WAOuA5J9XiY6VJkWY?= =?us-ascii?Q?vsHKbGKvvmpbgkaVb3qkMtdQWJvCCNulf6vxoiF+2OxrO9OtNnkhszviS3K6?= =?us-ascii?Q?tJFQYaiziprn36Ro7hzf4LpF74Bgn502wjpWqxMPb3gerogz+n75pZEA+ejT?= =?us-ascii?Q?MFa/gNshbBlvUkZSvZDzqPofufdPMK+49z8WQyEG1f9ceKoS0qlP/aXXaL74?= =?us-ascii?Q?Yu871schPy7xxycswpMSYSrFP6Lo9y1/6wogA4xd61Tz1DsUKgKUPDf6QUHe?= =?us-ascii?Q?XEmut3r3+duc2qOpdvAno4m+L9O+AKzEnm/gIUYwXzLNFNUOUfA4oyTBiljN?= =?us-ascii?Q?SeZUMvDzQB3wtdH4U7mO419T4hRbyuZAGG+sHh/cJTKRtXIU1v9EKg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DyOeS8LkqM07fgpdnrrCQGgYe5ar37kyYLGTHc7sdeFI4fadJ93TYUwRq6rX?= =?us-ascii?Q?G5fCokug4fIHWe1qb6/PEnojR2KdyEl4bBdkJVH8endr7KSufhzVtYWQ3wKx?= =?us-ascii?Q?vu1sGOZ7wOMfCkGr7+WWV8QjMbjoKGOQTkaBnWl2y/auluWdpl6lh7uGmylT?= =?us-ascii?Q?l4LijOhLXUO1r1t6obpoNoedA32I01wuTaa3BaRiLKvCeq6wtRYvtWrdC5SR?= =?us-ascii?Q?YfOGe+EBq7NWy8wWuS7E7nmUUHFpwK5y2ARiJ+48tp9xTCMVNSki2xBHwljv?= =?us-ascii?Q?pH/WLfQuaIru05YWVp7y6w1NyRoU6G3o9m491rqRyBZ377RUAT9oVYQQ5THa?= =?us-ascii?Q?fyoQPZKz5j1FOVr65t882nzS7IIEAHnGgFulKicc3Xdm95n+rPuwUXTLvKor?= =?us-ascii?Q?dVcuyr9vvXhzBHZsNeylh14HekaK5NVB3RyYS6rzhyM0sPJaDvH5vjesdmyo?= =?us-ascii?Q?pH2j0TOsfoav/PWS/iYPm+37iWD3ZGh+PygLvXNderd+QRHq+wa0Y7+CCicD?= =?us-ascii?Q?LoVV2i3tRqlOOSB6ittE/LTDKladln08czoyLsVDxl7X/ofpyIR4xTIlmxjA?= =?us-ascii?Q?n9H8riJ/ElutxszKYLDxJBCOS7k5oyXesLHlZbVhPicBcQdhdU6woFkNpPnp?= =?us-ascii?Q?pbrttNBjQRFy2Q+OWqFNgUUL9Cw/JrSdCtgUMCeYj3tDBMNLeiSiVrIbkNge?= =?us-ascii?Q?k8QEpWKymv5cdbyTcvMed38HVZQHUF/C+nalRBxCN5V7o5A+1II/uneovg5T?= =?us-ascii?Q?gY84IS9E9Q0Pa8ujnfD8H/jYQUpCUXh0qcgAY8rR+v4L6wykkzdC6MCv8i8W?= =?us-ascii?Q?GWSO7djBpCxIuG8b9gToiI3YJnfMsJiDgzHCPfNbE+r2Swf9nJxDtw2+xUVB?= =?us-ascii?Q?mbUbJXTn/NwIXhLj9MXN+MnfLtyRnj5h0vArCrrfnV641lb+YtbIclR72ECi?= =?us-ascii?Q?VwfYbkevkE+O32mywlzAgOjm8Mkebby4yUnMSi7LR6AAH1CMZ0NnBHGSLS/S?= =?us-ascii?Q?LnkcqGswzKOpXOiyMMDifhumvevNscfouQBvvhMNl66JnxBZwlVjcZmOSJRl?= =?us-ascii?Q?aoLLTdrM2L67wY+RXucDzWbqPRuFdqSQvGTWdOAms/cBkLKfYI3/j6ZzJp9P?= =?us-ascii?Q?Jxv/YzanCOe6vDgtcjoWHgABbQH/1Y6PGTCCq3KL+ykKJQtYXV5S9XlAA2YN?= =?us-ascii?Q?5quvGr9fp7/4nQN1SXgArZpboi3kZ8ALVKCJLKWZ+6IyJueeacfOJakXBDAX?= =?us-ascii?Q?OgHk6rMZ6SJVub1ZN1Jp6DMcTHPzhcFnxDYCOSIM0sQF9lLWUjAUmhiFOoiO?= =?us-ascii?Q?BOVCkwyfAJSbEKb1lEY4eRVrvcDW3OakWcq6SiKFAH1TtrFLdlpMEgx+2/0s?= =?us-ascii?Q?lPkuS5ssJ7spDX/u10k4QZVNYQv/Be2TR65QmB2MKMSRtkWs35ac8FtlYUS7?= =?us-ascii?Q?z+cksK8UK8ujYao8VP8X4iRioiVbgi4WriKxvUKBh2cYdWdAsgNZdKbtvJ5w?= =?us-ascii?Q?SjPThNzXDhGhT9lU883tEJSIWwor5bfD5SItqk1JxoKfrB7hZrVgYFcE9Qk/?= =?us-ascii?Q?5vkiYlX+o5fILv1wvmY4h6zMRCmLKNK0F5FK7hAiaByF1hM4QqI5La/pD34Y?= =?us-ascii?Q?ehKgIJZBMI1FTxtnYL9VOxk=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 60694f2b-d791-438b-19b3-08dddfe5c276 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:26.1246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K7FmKjJVoeHSVBtDRhO9CqOt7gmCc1DI3HInaBUMZCr4Dvq9oAjIrGhR/PyVpYOGOicfhDRR3tJKKHj5XFXCdsATbfveMEZncNGsCxvz5SQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6355 Content-Type: text/plain; charset="utf-8" The "length < 160" restriction is not needed because airoha_snand_write_dat= a() and airoha_snand_read_data() will properly handle data transfers above SPI_MAX_TRANSFER_SIZE. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 043a03cd90a1..bcc464ec9c61 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -579,13 +579,6 @@ static int airoha_snand_adjust_op_size(struct spi_mem = *mem, =20 if (op->data.nbytes > max_len) op->data.nbytes =3D max_len; - } else { - max_len =3D 1 + op->addr.nbytes + op->dummy.nbytes; - if (max_len >=3D 160) - return -EOPNOTSUPP; - - if (op->data.nbytes > 160 - max_len) - op->data.nbytes =3D 160 - max_len; } =20 return 0; --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020141.outbound.protection.outlook.com [52.101.84.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC7E331770C; Wed, 20 Aug 2025 12:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.141 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693215; cv=fail; b=p3mqziFhe4wd+dP92YvWzxKyq2v/B54rGy3sNNICQbuPHOzUuUFIdFX57t+9Aiv186jyDkal/C0WbO/KZmcEQzt1XKPHK6OPwiEYxrkwDgZF9l3z2M8f5B/MA4iC98rC0RN5cfRnXP7IlKazzV1uQ5++6XocLxydmgkJiOVEImk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693215; c=relaxed/simple; bh=W86g0NsD3OJESLhX+5yXzFIXGL8/TKJdzM92z0+boHo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=c2zX35MoVjtaO5iFIpxOT5sIHtJHg8f8tPbAM538iH3Ak7trCv6yilLFHM6ZFChm5cFh4x4DnBDtuGNnIcSHH4BF/SQ+++IOx/nJ+KBQPT/Y8AhoTBCMjHw+0nAMcbjzD4aXrt06s0YD8XtGWv49Wh1A3bZ6b7V+2BODvZC1g3c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=H2ora7Ne; arc=fail smtp.client-ip=52.101.84.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="H2ora7Ne" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HJA88jHye7riFhH3vCr5a2bgDGQD2oigJ7kD/fExytMZLNbI1AUVjx7DALpW1fxVkApljb4aYMSaVOb6o6f2pjEmwpmmuu3dxhWxtGpQvl1ef2luvmv96mFS0jA4Icisy5sPUAhTdaqfBvqKvWMO60RDchIeOvdxmYCKHXGHcKDcHlEFw+uXaD7KOka8e6fJphugMJLH+DVd6vwbo8a9Uhx3vu4kvi0fNk1JffrCTqJ1a0b2dwjdGqfdOZd9Fb01tFRpmv7n2L7JakRANC2UGKRMGxam9utlfbItYbZGI8UUodzcMxF2zVGHyXkEQojiPFyW9E/kKKxT8X9MXg7vjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QZuFdupbcTec0eDGrzQ/n0GGOEGBWkYNKuTsFdVsv/A=; b=tX6G2tRXQ34V7AKReEnc9IF8CN5sH72AIKKmVmt3wVM+cKFp2pOKQ9VALtGnwYjhIhl1OA2MjMhd/1JWLAiWVpKRV/5tXyAKT2fb5GbfKs0urYIh6NEAyq3ENZGYtZW1Xg0SpAuyEgPPtvQz43SZpGIT8xozfktrYjZzkMVdOMNw9Tf2+a05feKNjACVpooIwYv0FaL0Iumb+N6H3ZjrL/BLRqMhxLQxPjofahBjqCqV971RPe0OWF5k8PJK+UjKPKP7nN7kVNvFZx2T/qDwgW5uKuaBrTQ5rBasbFRdLCqmz3bcM+gJsWlRkiDZmWL8K75ZD/thtJLU0EEn3enUdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QZuFdupbcTec0eDGrzQ/n0GGOEGBWkYNKuTsFdVsv/A=; b=H2ora7Nel7f4AExvqwBZ4JR54aCCKQ6gYKfaRGNzbXsZqCl37jn5SOsRu2CZTBIJkIeUBZPQJedz/9bdLKO+JPjOih+u6R+jCGPmHK/Ru9fSX3ey/UFQhrIbRte10uvjwmVQ5bFfd5OYxc32n4WrYPWKp4TXgJvZC9c+ifTaZJxhhwEmeBQmI4Hn8vlfZOXRvMHHZTzKGyKobNzE85n2RGiLZl2kZ8e7boKs3C7fiwf+dBr2WQ8fBx0U+Z3XDlDKlpd7l1jLBiIJARim8asVG+aLWHLW/IwjJ6NRiO47ihZb348lNEw96PLaoc+cxvV2EtqjZX0k0dkNQrXe0wTBxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by AM8PR08MB6355.eurprd08.prod.outlook.com (2603:10a6:20b:363::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:27 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:27 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 03/14] spi: airoha: add support of dual/quad wires spi modes Date: Wed, 20 Aug 2025 15:33:06 +0300 Message-ID: <20250820123317.728148-4-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|AM8PR08MB6355:EE_ X-MS-Office365-Filtering-Correlation-Id: f3691a32-88c7-4a2e-ce8a-08dddfe5c2fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?RPY8Bzt3UBCaFqDmVGfnqZ88OZEinwKpGW8c3JIHvD/5klfuPnj0z/GfUGFI?= =?us-ascii?Q?dMg1/v9jfnx6GQFDE1TG6cu0dtGnbk+Vut6z8e1nXXTtsP+6KJSZ5I8vblcL?= =?us-ascii?Q?uuQ/F68AQdiAy6yPnTuDLwPRGj8DUt/QLfYAFRmJuUfN4is5PIN/5imN1FZH?= =?us-ascii?Q?eR87PwJjrXdAGrsQwaD6ZZAGsP1PHfDRxvmAAVoI+wOJgsJZal8ksdDAcO7+?= =?us-ascii?Q?FnLBhj69EVhqp6XDRHiEYYnHlHBd5Vl2ZlrF6bSaybK027J1c2Bh6moCYCcL?= =?us-ascii?Q?kD4riFp/H36yA+iJxFKwCLDvWdPzE0N53NdAaKJAKYwf1duorpeGz/R/E+x0?= =?us-ascii?Q?sC0O5hVRAmpDe8bDe7Y6qp+8h3t2VsIGJa2YcFrJZ8TF8Rko5jdR2kNFv09H?= =?us-ascii?Q?Qlun2kFBaDmV9W2/Tt8i8qXCwPyLncv1+E1imvFP2bF6W/FO5xNcYUBLAZTX?= =?us-ascii?Q?7zXhXExtmvfq6fTmfL0w4Kmvia3ZA6Xo/Ah19+8xQiI+ElZ6FzqlaPdK1Gxx?= =?us-ascii?Q?ia1++DtIDm1ZWqgm9z7LZ0pKC8sjVaN2L1Q2mu9rJfx0UdUz7Iwfu0fWypM1?= =?us-ascii?Q?OKpI7tRaVm+efix4I2Uejfw7/2M2QF9fjSq9AyZNQvGClH8I4uUG2lIc+h3X?= =?us-ascii?Q?rP6iHio7dvt5xoVk2Mx6T2h0DmBwXf3tHcjHKAUQzRig9btxyTNjcrB1VC66?= =?us-ascii?Q?jx2lvjQlgHcYugARksw9PjQttwnMUlouAPjZom0E4tpbldt/RYMeQ/J5LgOC?= =?us-ascii?Q?NiQzqiup85AfYtlK97m9ZDEe0XZ5FO6rfKZrGQmp4sAl3GPFIBEQHqzAcpU+?= =?us-ascii?Q?MgC5kLv/YDUZGuQJt69Kqi/+NyvG+HQ3mD8RIqs9YCSes/19s/gA6ygnDvnz?= =?us-ascii?Q?+8CApCBMYVun0ll5GGPuxeCOP877tQafuZWbw/Rpjk0UqOLUsyA+hoLoOXgt?= =?us-ascii?Q?mpPU0b+YroOl0+kxduAbRoFywrvPr1wb5yMsOvimo5Xkp15c2UXS4Oo70o0v?= =?us-ascii?Q?i8MSBPwp0tQh0gM49iJ9k7B9bGo+PE67kVG3jVFEWeVwNSN+eVZUoWJVwIpu?= =?us-ascii?Q?1Z1uV3rfZv2/DlSLrHfakPOpTSvojyg6OGTulJQ+bF6bgXxBq7R+x9c9ct3z?= =?us-ascii?Q?c9iZvAq7U8zPYaDcgUa4RqM7kdWRyUzbgog4+rJQO+ntCSfoXRXMJpeMp/cb?= =?us-ascii?Q?hTMBKJvs/DONLU4ewIy5IygRDpyRCYH9+kE8ZrNTn3iXxGCHmvAX/JWvjLdF?= =?us-ascii?Q?NYNw2qlJkzmZXldRN7SHW5lVLDzYG3kxCQluz8MAHQ8Cp/GH2RItVpPpPyAu?= =?us-ascii?Q?RPX1aSHM41B2bag7WmChNIF3S+0sawnkjgVrLTBQNS4D7cvsn+EY+Ve1MIkK?= =?us-ascii?Q?h44CuNv5Xwbas5a/O73/f4Whd9bN7aZIBGGWxBcBONDlbIeTzjtcdYdNgOJY?= =?us-ascii?Q?Zp2BYmaZDq0joZL8/Ywe3Y8X0uMXpPAC6/o+0dJo2ErHFJzeAcEgrQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ejaDHIEQVS8xzsIi2quh/04BdfiD1PYvgQYUPfm+JXnKne0cxblFYfUnf/zY?= =?us-ascii?Q?UlrwXY/DTTe8VVNTAv6B3Pd7sAyjbNj1pP6Q+Xja2BnsklDwoUs51DXBnCR+?= =?us-ascii?Q?QGx+TuhXiZfMIFbicRuOqKOBN2fMNnDmPXll/s9+bHTTFQp/BYRHy9NKz8Yu?= =?us-ascii?Q?oDUNuxrgYZs+qVwYRG8zcNPgA0sd7gvrb0TI9Bs8RBM9nDIzUGQxkDHi7MaF?= =?us-ascii?Q?nuc1Owcmxv9WBRKfgl0exMQjb/ov25Ds7rWqx5g3EPdpH2+db49n9NLndFuv?= =?us-ascii?Q?W/Z7uBxXNUrvrCRTMMl68ug14TX2zzfUg67M8eyiCdOk8B5+kNn9haupFTJm?= =?us-ascii?Q?lY0YeWdKxHcdL9lFq22os6sb+mlT3RGZJhtV4vi4f6a7sHQ7oRZdSMEGP2PA?= =?us-ascii?Q?t8DktqIWTvBIAmyqkg2gLef51JYk7vX+3ecc+ifFakTyKx94vDBlGofgkFMC?= =?us-ascii?Q?lrN23Ob0KhtX2wwlfhJNKRaZKz9Pk3WF8YWDJZ4QQu3cJGwV/o5chDwhXI6c?= =?us-ascii?Q?4QKcdRwkq32j6IK31dsqL+0BJ36GFR+8cXExidU1JI8YkRpT8rS+352zuXnF?= =?us-ascii?Q?atwBbqrIF3vVAh5VXwyis4wcjlAkwzN4Y8FyHlnPRRCnaL7JkUQr2iht3BQG?= =?us-ascii?Q?WHC/MfGL4QY0++nq09Mq7DKYbNuoNhTutRKquUe6dABJ+41z2gcOohmU4NWG?= =?us-ascii?Q?0Ty+2DAOPVAPYcDDbqVFaYy+LUJ04rcDKYzGJ/H1eL369zCWsouUYQmzi+AG?= =?us-ascii?Q?evs5qOXPbJt+B7OdELUEq8deRB5mK7YXlBMFJ+uHysI9w1si5Vh0BshoEKII?= =?us-ascii?Q?Lgwm0xPTEtm1UdBY7s4t8OLALz+vw8kqrgBFVvsiDKQWbyhmz4Qxe92foIZF?= =?us-ascii?Q?bBhDPuJqJyo0C+gGbkDVj6PPH/OBI4mC6NWRoLd9fl4WpUzjCkvXp7HNNFEn?= =?us-ascii?Q?vAQtKjRLT5yda2Q0+PTwvTj8wEwx/FKJ+DYmUNUIkozLxw+VC76jr9vF3o8/?= =?us-ascii?Q?UynoxUaI7g9ttkPaUiNSJEoNexeB9w6xvOe+M11qFK9IQSUQcnMkRBSyr+eU?= =?us-ascii?Q?2/MLOlvIYz5fiN0Q8odam7KWOY2oQSl6U6IWuaCi9bWaAqJzQX7mPKdLRuxy?= =?us-ascii?Q?utQDlcfT5CuylB1yaTBlibrTKIwBvw2pvrZ3pabdzJ+mQnBoDWiWe5XJwmOw?= =?us-ascii?Q?Lmih8xMIg5w5EbZNk+1NVsNu374Ml+EM68VOEnXiYxseEVyNQiOy5Rzs50f4?= =?us-ascii?Q?YgvPcurO3KLcQk1fC/V99HHaDyMpsb5HVNqhctI/Su37JkD6NVJHCt/0wQAg?= =?us-ascii?Q?mDY2tj1CiKSQVIEmed/Nr281HxcLntkI8e7T6v3UwUh9GURvrDBzUN6yWScJ?= =?us-ascii?Q?jlW4nQLRYkh+cEAPDi50SWvIPLeaPylZq+twcWKapvtlVV7Tz0Rjb9wZnCXD?= =?us-ascii?Q?LgweHSrsEA+ynCJbo/ZKxd5jJAYq9wDbCY9ipx39olnsH7SgCOJZlyNvv9yC?= =?us-ascii?Q?3W1lgZVHsG9jH0FxtplcsYv1Im4fYHres1SEExepqJ/bxPcyJU7yyZ2qX23n?= =?us-ascii?Q?DL4g0912ktpwg7b5iXlAe9z5MYRlQF6d6j2leFoqLkFTN98HynEQ9jecBj7b?= =?us-ascii?Q?sRMrIpkSoq2U4fu9PefXXKM=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: f3691a32-88c7-4a2e-ce8a-08dddfe5c2fd X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:26.9847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: naIQrSYIq75rbfy4bLXjrEjmE5nIqUnnwwlDkOaHKmxR2H7DxkGMeTJ8aHccAee17D6X6jqRKfU4W1zWVbMon3AbTmM1DAb19U2P0qYFRus= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6355 Content-Type: text/plain; charset="utf-8" This patch adds support of dual and quad wires spi modes. It will speed up flash operations on the hardware with corresponding hardware support. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 107 +++++++++++++++++++++++++--------- 1 file changed, 80 insertions(+), 27 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index bcc464ec9c61..7aab3506834a 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -192,6 +192,14 @@ #define SPI_NAND_OP_RESET 0xff #define SPI_NAND_OP_DIE_SELECT 0xc2 =20 +/* SNAND FIFO commands */ +#define SNAND_FIFO_TX_BUSWIDTH_SINGLE 0x08 +#define SNAND_FIFO_TX_BUSWIDTH_DUAL 0x09 +#define SNAND_FIFO_TX_BUSWIDTH_QUAD 0x0a +#define SNAND_FIFO_RX_BUSWIDTH_SINGLE 0x0c +#define SNAND_FIFO_RX_BUSWIDTH_DUAL 0x0e +#define SNAND_FIFO_RX_BUSWIDTH_QUAD 0x0f + #define SPI_NAND_CACHE_SIZE (SZ_4K + SZ_256) #define SPI_MAX_TRANSFER_SIZE 511 =20 @@ -387,10 +395,25 @@ static int airoha_snand_set_mode(struct airoha_snand_= ctrl *as_ctrl, return regmap_write(as_ctrl->regmap_ctrl, REG_SPI_CTRL_DUMMY, 0); } =20 -static int airoha_snand_write_data(struct airoha_snand_ctrl *as_ctrl, u8 c= md, - const u8 *data, int len) +static int airoha_snand_write_data(struct airoha_snand_ctrl *as_ctrl, + const u8 *data, int len, int buswidth) { int i, data_len; + u8 cmd; + + switch (buswidth) { + case 1: + cmd =3D SNAND_FIFO_TX_BUSWIDTH_SINGLE; + break; + case 2: + cmd =3D SNAND_FIFO_TX_BUSWIDTH_DUAL; + break; + case 4: + cmd =3D SNAND_FIFO_TX_BUSWIDTH_QUAD; + break; + default: + return -EINVAL; + } =20 for (i =3D 0; i < len; i +=3D data_len) { int err; @@ -409,16 +432,31 @@ static int airoha_snand_write_data(struct airoha_snan= d_ctrl *as_ctrl, u8 cmd, return 0; } =20 -static int airoha_snand_read_data(struct airoha_snand_ctrl *as_ctrl, u8 *d= ata, - int len) +static int airoha_snand_read_data(struct airoha_snand_ctrl *as_ctrl, + u8 *data, int len, int buswidth) { int i, data_len; + u8 cmd; + + switch (buswidth) { + case 1: + cmd =3D SNAND_FIFO_RX_BUSWIDTH_SINGLE; + break; + case 2: + cmd =3D SNAND_FIFO_RX_BUSWIDTH_DUAL; + break; + case 4: + cmd =3D SNAND_FIFO_RX_BUSWIDTH_QUAD; + break; + default: + return -EINVAL; + } =20 for (i =3D 0; i < len; i +=3D data_len) { int err; =20 data_len =3D min(len - i, SPI_MAX_TRANSFER_SIZE); - err =3D airoha_snand_set_fifo_op(as_ctrl, 0xc, data_len); + err =3D airoha_snand_set_fifo_op(as_ctrl, cmd, data_len); if (err) return err; =20 @@ -895,12 +933,27 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, static int airoha_snand_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) { - u8 data[8], cmd, opcode =3D op->cmd.opcode; struct airoha_snand_ctrl *as_ctrl; - int i, err; + char buf[20], *data; + int i, err, op_len, addr_len, dummy_len; =20 as_ctrl =3D spi_controller_get_devdata(mem->spi->controller); =20 + op_len =3D op->cmd.nbytes; + addr_len =3D op->addr.nbytes; + dummy_len =3D op->dummy.nbytes; + + if (op_len + dummy_len + addr_len > sizeof(buf)) + return -EIO; + + data =3D buf; + for (i =3D 0; i < op_len; i++) + *data++ =3D op->cmd.opcode >> (8 * (op_len - i - 1)); + for (i =3D 0; i < addr_len; i++) + *data++ =3D op->addr.val >> (8 * (addr_len - i - 1)); + for (i =3D 0; i < dummy_len; i++) + *data++ =3D 0xff; + /* switch to manual mode */ err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_MANUAL); if (err < 0) @@ -911,40 +964,40 @@ static int airoha_snand_exec_op(struct spi_mem *mem, return err; =20 /* opcode */ - err =3D airoha_snand_write_data(as_ctrl, 0x8, &opcode, sizeof(opcode)); + data =3D buf; + err =3D airoha_snand_write_data(as_ctrl, data, op_len, + op->cmd.buswidth); if (err) return err; =20 /* addr part */ - cmd =3D opcode =3D=3D SPI_NAND_OP_GET_FEATURE ? 0x11 : 0x8; - put_unaligned_be64(op->addr.val, data); - - for (i =3D ARRAY_SIZE(data) - op->addr.nbytes; - i < ARRAY_SIZE(data); i++) { - err =3D airoha_snand_write_data(as_ctrl, cmd, &data[i], - sizeof(data[0])); + data +=3D op_len; + if (addr_len) { + err =3D airoha_snand_write_data(as_ctrl, data, addr_len, + op->addr.buswidth); if (err) return err; } =20 /* dummy */ - data[0] =3D 0xff; - for (i =3D 0; i < op->dummy.nbytes; i++) { - err =3D airoha_snand_write_data(as_ctrl, 0x8, &data[0], - sizeof(data[0])); + data +=3D addr_len; + if (dummy_len) { + err =3D airoha_snand_write_data(as_ctrl, data, dummy_len, + op->dummy.buswidth); if (err) return err; } =20 /* data */ - if (op->data.dir =3D=3D SPI_MEM_DATA_IN) { - err =3D airoha_snand_read_data(as_ctrl, op->data.buf.in, - op->data.nbytes); - if (err) - return err; - } else { - err =3D airoha_snand_write_data(as_ctrl, 0x8, op->data.buf.out, - op->data.nbytes); + if (op->data.nbytes) { + if (op->data.dir =3D=3D SPI_MEM_DATA_IN) + err =3D airoha_snand_read_data(as_ctrl, op->data.buf.in, + op->data.nbytes, + op->data.buswidth); + else + err =3D airoha_snand_write_data(as_ctrl, op->data.buf.out, + op->data.nbytes, + op->data.buswidth); if (err) return err; } --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020141.outbound.protection.outlook.com [52.101.84.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAF0131A064; Wed, 20 Aug 2025 12:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.141 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693217; cv=fail; b=ApEZVwz9TCAzPa6bzD72vIoTGL0QxyYxV4nk6hnwHceatC2Hg5dnrAJq7MslItPt68AGlj4Ozt80cAL1qHCynwqAYHENCP/xavTpxplpvLXsPEk8+KeMuNwQHEHo2WKeGS4tJ2jmYLUToo0ErAq/2TFS6YiznORgV+2yybYShfY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693217; c=relaxed/simple; bh=bswb54Ci7TjUUf5sDcCikDKpsKAnCrL/5XuH2C4W7Ig=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=CCvDSi6GMwtAkjjYm3I1qQu4S22bbq/OYCjWRRT84ppQITBXddHm+dvl8rGJ8oqr+1Pr5ilJQbPqghmNsmAoLXzTq4zFEjmYbYjjSJDAFXZoDtDhQEoRC0rT2k1HUD1vEmPGovn6MOLfdK/DPNhrMH9S5Kk8dlaVBtR6osmHW9k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=Q7h7ReIX; arc=fail smtp.client-ip=52.101.84.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="Q7h7ReIX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sixIxYmEB/0lEPnzCLOP9HdQ1RivAVEDvOci13N8/r/ZQ7CF8vwIa85gqnA6MT2fGspQMGgFwqSlUBJIon+144AWFuno7XWfiwB0KTwyaPio+gq+OOcENt+c2HRaIdOQIvFgGx9WpvdCo5PJXC8fFBsQzYVzZvOK6Fb6CW3qAKJDom2OB5gFsGn5SRwSNJtYUgGw+Vj1oLiUT/S331Uq5Sovs1re4/h1XtEl25T6v5/l5/2Oks0ca/wnQhVq5ZS7kL5OgaEfve/CzC6d1A2E+IUWvVi612bqIfLfj2Qt8awz5VG2Uvj4TmQ6MwKo9RjbahrjqI0lqzBfWHQXYfxBkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1FlPP13HNVDKeJqRNHZ9Eriu2kBJ9szbA6aAncjtVCA=; b=ILOzAip0qO0JidHgwSg98UOXxKL1oUlTAMb7TFemHS8ZXGw+zR9y5bvomqVVgaGyz9cqM9B4DvzquoxQkE5qtyRSMWavjDnTZ+oUo7QvfzraQaroSuLHxJJkNPneulwjjYisotvZ2Kw3dqcaFJjxIaHaGyGe8TjMe+sRgdKcppIou6M7+b5gkd7f67KZphXNAM2UPbf1k9fJlGRqOMOPYpfl2JR7c8qRcwECZoaTABQ3G0RfDhwxXTsRclrEjHEpi4wrY0PBNhS5ufjkmLA9zwDEX35XetkBzrk7nB/GLOxGdFVET1NyB+L94/P6e7HFkOysFopU9lmiFiPfm3uiVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1FlPP13HNVDKeJqRNHZ9Eriu2kBJ9szbA6aAncjtVCA=; b=Q7h7ReIX4DA2ATKcKzNv2+M1xXZFwKyNpAuAge13oLNLL49Qk6mvNvDAEHr+iGrjAxu/bVXyb+Ioz7PabPMOvTLf9gnRM/W+nDutXAhCuF/eEjYKVGSr+hC1S3hXbVzjKqEtmkrfQEm1/nNxMufOXeQG/MEvQ0PKskS8gMM86hVPv7n5twVF1JgbgbVRKwdI8ngUIpx/NtF+xOs4a9lZNyrUibFKhTjmdpkzWe3jjHVBH3dKE+Yzd3R6PwtwFH+COsaozUKBe1Hx2Qzhlg6RhPSrnaArN5Jtx38FtfCMUhJJwxMLX6pZMo8Y8jyHjtYrKyQ20FciNzKYheKArOanwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by AM8PR08MB6355.eurprd08.prod.outlook.com (2603:10a6:20b:363::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:28 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:28 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 04/14] spi: airoha: remove unnecessary switch to non-dma mode Date: Wed, 20 Aug 2025 15:33:07 +0300 Message-ID: <20250820123317.728148-5-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|AM8PR08MB6355:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ec6bb68-fe64-4dd9-511c-08dddfe5c384 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Xbd3YxcVHwcQ0pylDxRxcBll3hqXp/6CbEcn6GuDJ6K6VqDdhIWSObnzu5Bp?= =?us-ascii?Q?vgHbzyREt0geFy+XV1QFoGzfekf4mksLiJPnUkDtry8hHT29Ww86fwjLEY38?= =?us-ascii?Q?eE0NdnYUGtdYBBELy5u0EoQ6QXV1yLfEKDzwOpC3PfmCEG229XhCipdpOS1H?= =?us-ascii?Q?nkRgLAZFGBN7vq/BMb0O/WblNtk1nt1pTnMCFJHYiaHmGI5P3U7qM05LUkQl?= =?us-ascii?Q?VRm4f3oxG85wRpl2MfZhSYiKNjajSA0cZez2AJDOWuh75I8APQHwsJQ+c62p?= =?us-ascii?Q?8/brPLyoOU3ecKIMFz243D/syk0sbIzK1btsRi/8B9unMJVnvD+4Ko8z2qzh?= =?us-ascii?Q?3W68g/eQ+IAs7V+LtAgQM7vCi3yJB+o7FTWX2KzqajphUI1W5eC7iDhbF5bz?= =?us-ascii?Q?NKvUz+65cQicXup7hhK6uGwvUkiyF6FWW+0QH1OpM990jOayiyqPvE72ZB5X?= =?us-ascii?Q?szLI2Bu76TTjaI//8OKihX+cMWOpC9vhyRgvJW7tvXb+FIRVyRy5R0MO0yvm?= =?us-ascii?Q?h+HjP9leoJhcAd2bjqUDxUauQjgwcyAQlUTnCrqfWHm2+po746UTndAzUGyW?= =?us-ascii?Q?U7SnXGgnlePIeBlwxLUL9mOg+UZStUBiVLeGo92L70UUXmnPMq45qHDG68Ui?= =?us-ascii?Q?sSRjABZVFhOtWAZ9Z0YdFasA67ouN7TwRTrBvpbwnRJX4Rqz+dmp3P+wP02W?= =?us-ascii?Q?tREy1idIOj02e6yUBU3szzJqTQvVXI/iITndlJW4MxV7C16KuH3EW/x+nMH+?= =?us-ascii?Q?b+DmSaYK4M5L/2dtELUeQpIBJhC6NNM4dXY1Wdqho6pvVhod574yaFwvGOYA?= =?us-ascii?Q?DbuF8nOZXbfneE2fxZ0nrNyezJVfggpNcjfvQQ85ACta/DQd6pw82Zcblexi?= =?us-ascii?Q?4ZlEUw17GkAFvdzS9t7i4sEZbXWT9Ow+3h4gvjEsNActiD/GgHQ+dYJP4Fmb?= =?us-ascii?Q?MtK0lpDMR+3p+Q7X3P5mVf7NX5vix841921gZS0sX2pQXZGabXWFfo3hRggi?= =?us-ascii?Q?Spei2I/2AdjeFQYcNiWKW1p/RpqE4N6YDZhjxsnYY4AUyYT12YZQzrogIx6L?= =?us-ascii?Q?Hdn42tTOSzQUBbjZJNzfHnxisFMhCbxNnfKGxQeEptLB4P5vPPacQjYoJkUk?= =?us-ascii?Q?JR1r/vpqvjDy29YowBD64NSidZ+/PSw6J4ltn0SKti3ZdV5MVc9L+wHE1H78?= =?us-ascii?Q?BcAGYwNX9O+IEO8fAna2pLfkCX4qZwLGUPWvSiIlIx9AF+Y1LDYHAM5pYoMu?= =?us-ascii?Q?SwpBu1gQO480SZ86Pak6tI2NBor+s5MSZR3GkEv2+jawLHp7EzkIBy0r4MbJ?= =?us-ascii?Q?Jdczc+c6IUekPHn0KxMkMHDvaytqPHoe0ALmhz9o/jbCXzv0G34iKxtYWwB1?= =?us-ascii?Q?75DYDBpaXDSCbXAKk3ry5qthfMlAySLcC1rdEZfiFAVXDaMnwxeGhUHXAdDr?= =?us-ascii?Q?C+41B/23YSnNgrr5nfzWONooU3QmDTaEV2038niT8Z5OHPdhrBeH7Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ok6AJv7ZaI69pE2rIn23QF0kXZiE4RBnOBZx+z/H5Au2/w5KfZO1lNPdyn8H?= =?us-ascii?Q?UFQRPpH5rw5ZdVLnXFJnMl914ZA+gKcPrrx3uAKequP4GhC5SLNBxV/mhuvR?= =?us-ascii?Q?IX4TXj2d3FGEDvEZwwbvw2xLIpmJABhRrkiR8aLy/8AuYyBz4VtEXD7gqBEv?= =?us-ascii?Q?CfqPanocLds5JPt1Hyg7Bsrrx8G9P+g8Eh+3dmBc8lAIn2M1KphQrayPXnbG?= =?us-ascii?Q?8YaaPKCbrr1PYe+PuvZvOfjslcbg/uuz89jcsxQvxLlHku6cjnZXqtttz0v/?= =?us-ascii?Q?vjk3wdwU5YLVVQjbJQtGDX5N1y4XE0x8TWU8NcPLhpqk3SS+xLQd07K6IpOV?= =?us-ascii?Q?DH8gRALTdagqQ0gamCaXr3iPZSQb3B4ChUh9oEw5uRcyggyH9vCT6pas34Bm?= =?us-ascii?Q?TWiJotdo2NeZaDa8zbnO6VTpqFDSFPjSPWeJJ7rifSKXQLLYYy6hfGkDcIML?= =?us-ascii?Q?46M42GmYiIS3T4bhkkp7J/c1YegG2c1Fpo5h41lTngkRXY2el4UbIUWrVsA5?= =?us-ascii?Q?pY8AnvToKgtqxh0suSPi9FZJdTIGTfxYXdpTyZUvMwf4eekBI7qIdkdOVeT8?= =?us-ascii?Q?7DtNKHsUXxTsx2BcJkkXJOndm7YMLJFQ5u8WRA9kh88tKasKVHs1+qgV6Uf2?= =?us-ascii?Q?1RDjpFhQgtIjG8jMI9wf+MtAsC5MqTTAf58tiB3roppSRccjOPqH1O7HfxI9?= =?us-ascii?Q?cZjdeHKTqsKrp1JzSriXLn2bPJURyvvTPZ+uoE20WlL2qIcyP7VleZ7YuBX7?= =?us-ascii?Q?EKWAg+eXfK/hOZcjHrr2ocoUUT+KZfDPa+IBX2kfaw/h5M9NnGAngFx9d/YL?= =?us-ascii?Q?GRalHT3BuN1feI/Q8ym6rM3ichAQ8EQyUJwfHOqWzd3GaD1MxH5+hByLF7rP?= =?us-ascii?Q?0A2kcqyQm7Zi27sgHX/4kUhF7f7PGFu/I8Sf3pxgzkY4y1drUV+kreInM+ig?= =?us-ascii?Q?2YrIxDE0/pJDyNxtKSyRxCCmeDm2BbeKff2VaQmrfj1gDOjXEDGxYBQ4MHTC?= =?us-ascii?Q?Tx/cSWvAduk1iXD2+1z+UMiQb0+BT2qW0HcgJvLzJZL4zkM9Vcs1WessuqFj?= =?us-ascii?Q?nAcAjAUPVn3WGLiwJFLOs9d4MCc0J3pdpRqRI7nfPpiyUYAyY7vY6fzP7Fxp?= =?us-ascii?Q?xaamF9B7vsJtjnNr6x08ujMqCXqXcIjBmDv41xUJaue8PDoPqve71Rt+5Q9q?= =?us-ascii?Q?9nTG+g0hGDCQ7YgB5FADKe+G7JkpeBIoauWEpKigZU19keoObzj5hQJl7W9V?= =?us-ascii?Q?rPxE+svD0j6B/Ti0sdnQImTtP0Kx1HgHvjMPotPbcUfyRoYshgOwX+okD5GT?= =?us-ascii?Q?SqTalF+huFtlBoQ4Z0CIUVH582U2eboXgaspfiPgfRrNIsIETYeFT6llHvel?= =?us-ascii?Q?K1Mf0B7AcVwtu+yfmeW+9EHod8KDE0NVtAUymBWGCkvJfgdu5lBGdSKmCP/+?= =?us-ascii?Q?H5SO9kTRqFXeV6Y7QCui0kW4Edcl784eb/uc4GYqy112fjUBmbZFcgU4bMT7?= =?us-ascii?Q?V3WWsp/X34mWqrhHwA/Gi3FVyUEfPcJyuZLIq1LRfR4hFUg5N0WyHgbVi+WI?= =?us-ascii?Q?PFKBCRUCarYiS4mSX8BRAcUjKMHoo9L1rmBeWb3tNE8GWZoKLuyASRBD+Msy?= =?us-ascii?Q?B2wXIZ8ucuyf6aQzQrCmtnU=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 9ec6bb68-fe64-4dd9-511c-08dddfe5c384 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:27.9287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GSSYOLHImswO6hXcCaVZXGNhJLVlTwCOtcCH656whC+wOykAfRa+ADLgIZAiUiVi5Cp6+jbjBJ1GHIWgwmCQM7jrzYHLGvZXNa3BrbNIphg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6355 Content-Type: text/plain; charset="utf-8" The code switches to dma at the start of dirmap operation and returns to non-dma at the end of dirmap operation, so an additional switch to non-dma at the start of dirmap write is not required. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 7aab3506834a..7f33131fb6ee 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -810,9 +810,6 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, int err; =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); - err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_MANUAL); - if (err < 0) - return err; =20 memcpy(txrx_buf + offs, buf, len); dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SIZE, --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020141.outbound.protection.outlook.com [52.101.84.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3F7E31B13C; Wed, 20 Aug 2025 12:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.141 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693219; cv=fail; b=LPUmEAsd5WlSK5Hc/P/Ku0Gegvo8xCojotn6DrlYc0qNYTKIALWDGLzCUMJmVYHKkoVUL0e+AOxbtKWY80clppwkvB6mWCG1SFOS01yMAUsbSMgwEGZS4nIxo/KM+H7D8M191JUAm+0h7BCI4u8sP6JQ2JjmAMQ7fIiQSTtWEDY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693219; c=relaxed/simple; bh=B4mwrvksUNF8Cjo4NWZ842jeo6iVEjmVFq5+95mp/JY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Aas+6g6vTJrvrGG7LGcLPDeRqdrCXyPnjZL7vbHseZA2wD6I7VIiDTnVRO/AWpWxW4yMKBJOakcW+w94FqBR+xpYkPJp+vN5IPFXUcVUkV9BjRI9oTGAKfY3X52VHDDWCJ+7om3HwKyjMAPdhP8jQgurXs7OlMFnyrEyyg6m2lE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=xJS7GzT4; arc=fail smtp.client-ip=52.101.84.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="xJS7GzT4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DrSNSsKVLYbYA6S9Qlk8qUzlMpY8YUx33GsX2ZEUiKjf/GXKnMOcrERiiQqFjgzLYac35STWyR+tDxhRVogTMcChoO148MhPOhOl1rw8ru/roggaPgNLeId0D1PbzCDse3sQMrTs/MUOIuP9qhLvIgD9ZwBK0PEMUuZp2ZDFmtYz+atDvVuoMIiiSGT0ZZxO6yZigELIaqwasBcwlxhPEmxl00D6+76HxUkWPZ8Fso2If8mAWLEKIOprjChuznYUB2kUan2kyuAozEuF9/ELgBgBxUgTknB2MOP0E6++bk/NmT0YLiow7nEPm9K0YUubPfJ9yV3i060Psved3YH4Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zRiUtcHsQ6yiSkGpm2e/VasBHVzYFUftnsAiGFE6nbs=; b=UtAuVvNI6us7ogoqU482krwf6XE1DqO3hYgHChOXSRjxKAr0RolWyHzL9TQ/EX2KIv0N0o4G+YsS8rI2WJ3E1tH+JAVO4LwuGDSEHPCl6b/VilvhUuOFRa2ZNYAsRTUqQdE3bvv6qnUDTV+54Cs/oUXQ939eeUL4jeRX6bwKJ+69yvgjQ4izeYkxfc/GVa/hIMAhmRE34vVWBbSti1YPuPsLSHT+0ByUYtS2EP0Oy9cJBNICx2XlmEXwIKISc/EDLe0thcabZ/r40QeozGe3UPJGy0vKqhXScjJONyJjm7UkUi63QixAexzBGjUfi/OgHal7ATWUIi0tHyYnFH7wLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zRiUtcHsQ6yiSkGpm2e/VasBHVzYFUftnsAiGFE6nbs=; b=xJS7GzT4O5ArJ7iF6o7z5mdKA8PSIhl1YOh1RFFC+CuU9EbLBdUpzMa75W0thyN7BcwOx6AXuPW/kkYrtSMvpg4/SHewaSxaWS7kxrnHRA30DXKPXoj7MjxzGp4qlM/bRoGXlRRHhLFYuEoMBa1mjcecoGZCA8yAtUO8bYIiJYh+ZLEgwWq+1cZgzNilKHRuNGqQlfPr+DehQm5/ktdkXHEBUYEliLvhiCYGrrGywhO33Uwdxzep99nHkr7UoWQ3a67sb7Mxy1j7Nz+YjeTEO9xz9fy4xBJEzFtslKd7e6KkPr1IFLHROS3EOjhwNQEBGuMVPCaqdxoea6HPE7jMVg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by AM8PR08MB6355.eurprd08.prod.outlook.com (2603:10a6:20b:363::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:28 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:28 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 05/14] spi: airoha: unify dirmap read/write code Date: Wed, 20 Aug 2025 15:33:08 +0300 Message-ID: <20250820123317.728148-6-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|AM8PR08MB6355:EE_ X-MS-Office365-Filtering-Correlation-Id: 0851c434-06d8-476e-a6c6-08dddfe5c411 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?umIhFv6IElzA+6gsM74ibdChjp/8aNZ6q/DSIABR2+pwgvsBXeZ7ygFOIkwA?= =?us-ascii?Q?hPYoKmyFGAZkDsrOj8Y2ozwuqYO17sMrvMPB4kFYHjkQFNwAC3Qw8bUsZNKg?= =?us-ascii?Q?8hudwPtY31Je3SX8SGQXdd60Ab40m/yRL57+BwYvYOO2Fx8/T1voiwJczvrs?= =?us-ascii?Q?P7uemLR0vMOxsKcsKfUMinT7d/mLQr3ncB8pERQkUGbN9pjAOMRbykXP4nvU?= =?us-ascii?Q?lnXtGaZWARwI9oAOfmGWogtuKJa6VbvQTCmW8VKxS5tjyhP5Vmk496Uihga5?= =?us-ascii?Q?O0JqxjiY+kwhPIF8wbKw3vwLmjgZeBPZw0BNDCXqgIXVgTRY3x5Ee0KRajFL?= =?us-ascii?Q?CV/3A7ReSUb/U3LdWnJKbADSmU8JB7ul16Q5GWYC1Ulf7Bu3xroNk5ql+WpY?= =?us-ascii?Q?KE3DxM++huI1WnB2VAJANK88Q4g2wiG2f3SP3Q3XGOQb7Ts4u7p/Mr8yAxXI?= =?us-ascii?Q?51R7Dmjz73M6aEBvtiCH5UPNJpIqK3lNqHXBIH1VyMi4MOLcp5gX5OmS7wus?= =?us-ascii?Q?2Jq4ffalzvBXOGXnRk/TEgyPy/wcYjEuYsfZWMeAeycgl+Ju4yMZOscxoFHj?= =?us-ascii?Q?vCMEj5pcpqCLDjyDYTeJYEfdBkm8hLryKs2Ye9qVMf89Ml0cIXTeJ5VnDYiL?= =?us-ascii?Q?GkvD9pj7QN9Yx76KosAD04scRtbonuIseMcvfGvWBtLRZ/Tb1CFpD0E3/t34?= =?us-ascii?Q?BB7hsJ3XLh+Y6DiPtxT7P5nydiOtEx0Ef7VjGqGm/UKK2u8x7DvwQUw4kGpp?= =?us-ascii?Q?an59CfsGjQysnLUMtsDlS+zUcEsVHRi35FCCR375Gtf0IZPYCiF2BP7LoUbA?= =?us-ascii?Q?a8nbWU4fCmkbpR4YIxhhdj2qHpqUtVbVRJqcvg50LmsomT2V10BzVorSV7/L?= =?us-ascii?Q?kdF6OJLeS5NeqDNEAPnF8LM72Zp8/trktolO1H51rGurXRQNY4cIor6MLDcT?= =?us-ascii?Q?Lf4AOaQqLCpkU1uVlrwkl4dCSA5KMKRRkpcg4I/CNnw8GtIq2p4X8gATMkq8?= =?us-ascii?Q?sqBqSNNFRbsLrQvm3pJTuQnZaD4nrFffAcp3BpS/Hs0V2ip0vgglyj53CY6u?= =?us-ascii?Q?nBBYquKxhTKLBDwedK36ccmPOI7wxJCmyEN5Nd7jYRcW3j7tJ/y9qlTSNyKs?= =?us-ascii?Q?ebmFmP7MxTQmfP/zm+6N6RblnaHX/cM2Exul+B5ajEXFfLJkHVC99DIHLcwC?= =?us-ascii?Q?oWiQfxTLSbJ2w6rBSkdei0Nf9Bd8sCk/a93ZdqocpFVz+EJEQBkausLHawp3?= =?us-ascii?Q?hxjBT5mPaUSqR/i0INzXsGE3smGAESTbchO3/eGutZmd6p0QC6pPDkwEb3pB?= =?us-ascii?Q?I/yFeDLJyvDy5dW5JMaOgsz/l5iqjYcU+XMk1saJBnEMUh2MJiTy+q2D+FSE?= =?us-ascii?Q?lBaCXvZnZ0VZnfvC0Vg0G4IHOYbE6iPsWeYHAtB80UAl6BTtwIPAaKO7yWnO?= =?us-ascii?Q?/TFFiku5eOiNzBmtB11MJLK9pDdTs7uvok4VKmS0rZXJMiQLEwobFQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+G+C4BIXrR9hycp4TJUHJEHGV5n+bYKDTzMAfq36Jz1Rw3qBtLygPCuPUNwu?= =?us-ascii?Q?nCcZE+1spFMVvEwTjGj7l5NhKuS5KXQSta0y4iTEFnMWcwmreWgrQJWj7If2?= =?us-ascii?Q?tTb8IUHGX6X5hjYDZCA4ta+taeaZAMIUMZq9OSas/yAdK9o5wEk+GQc5YkxU?= =?us-ascii?Q?1iOQJrns6NVi+zlbJkZNpLeDM5fpc1nLa4vL4eGntqriZrfO6KOp56sPQVly?= =?us-ascii?Q?WA97sVmDxj3lj311jj9S3WoUM7s/ll1G6lZ9sz4vw/0jFeCy1B4dmvlbrAjo?= =?us-ascii?Q?4ypf9lJy5YlIpH+Up/vSjYDbgx9JY5EvOQfU15F56aPJhiuzp44ZYxx5Uege?= =?us-ascii?Q?HfZxs2p1CLcH/tdyrSTElCy1cF3JcULmXSpAb2GXczbArCZ+hHUvYYpvRrfZ?= =?us-ascii?Q?AwKhb9zRtrTRzXmBZ+99Nz0u/RkJRrwZeFUrjrBp6L9O5IE7OObYu7oD57yS?= =?us-ascii?Q?F7ZY9xxhgE64FksDyi6HFjZenC+aceCkR22FWBdBcozYzLGryWHwfsx1Djpx?= =?us-ascii?Q?vE4JKTMStMLK426SDcXkps7Rcqafo198x7wHQgIgA5rAUgU+P3zpWfmbGdoz?= =?us-ascii?Q?zOBwh//+uGlC+eKGZsk+ie32LNZbFPaiKQiDsOPr0F15pK/0aAc0rX0Ekrxy?= =?us-ascii?Q?FgW1n9Eni7xS3ytlDWsZUH+IotO78W1YlDMUrg4DKzOUXYML558e2JrR2Gn1?= =?us-ascii?Q?6Yg2kL+A/HcNOPAcdsDZd/3/ivhgYfnqpM+ZZoQH+4tcI01V2jbIIt+23nt8?= =?us-ascii?Q?WAAu1DY+Ad34aVsKSQ/iKLteDziEyclWEuptOvtBxAkO7NmnzT6fHKIQMj4s?= =?us-ascii?Q?mgwJ5LrzFgml/0Z96tJEwIlWbIGkY1ZQHSx4nH/DG3WFy2KHcx8Kdfu2OMOf?= =?us-ascii?Q?3N33nt6VhA++2h0EeVUHc5BrvTsmQHdz/E+VUBPZy9UL5FYVSOCbOzEr9zRE?= =?us-ascii?Q?zVHPbMGHfA66RRLvSYdP7eri916VHlaclR8TMgnswVBgjfHkj0grdMAHhr+S?= =?us-ascii?Q?J4iLYnKbG1h85/9i98io8rpVreu74pI4zZUQfYYvqOM/02OujiiqN8RjbxhU?= =?us-ascii?Q?htIIlsgMhtVr5mW6l1QzQ17px3/KIzZ5LxeiNIRsYGUX/1czJ8nlnmt17N95?= =?us-ascii?Q?fES+r9QivAnHMk2yZG94xW2XgeJnCkoCbZ4jto1+kxTg28RAgRiyrEcBMcbV?= =?us-ascii?Q?zkJye8LM6Iyf2A6d7XzPpBSrsX2RZs8CxJOzSl+O60fjkUbmAAFQC1pOLZoy?= =?us-ascii?Q?6/EgIEJX6QdK3sYGFw6n4dOtzLzfPojfLxKf/Wk9pykMMJHov5cKl+8sBYCU?= =?us-ascii?Q?8s2hyWpxGpulnkwzmv4lVhRdX6fqZUk4EVzo8dNKQgsaOpeOcwtB65YQA0qp?= =?us-ascii?Q?VZCMLod1Y4Mg6YSML5nxu0I5jktsmgufUN2Qsx2H9mlprn13uES84IFnqB26?= =?us-ascii?Q?xw/S8GJxefbQsXS7SzbOdRoFvpqTcUkFon41JJS/yLPhLQvGiLw52tvl93B2?= =?us-ascii?Q?F5kWaHDKO2VmWf5+DbuEcynvvuQx7bXoXEBqrZF0rfgP7I5nQCcn7re72wXA?= =?us-ascii?Q?g/oleonmOWuYwRPm/g8cB6XnUFZy4Uc+OHhqxhg2DbO+EEaXcsv2Hjk7Xz6R?= =?us-ascii?Q?/xS9XjZbMYAn4MGtj31XtHk=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 0851c434-06d8-476e-a6c6-08dddfe5c411 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:28.7924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eFlK89cD4G7sCeTWmPBdOFG8PseW5uyVjkOPjlRyFPpBtNl73QFoQe4HMPLzI3i/U7gxL6JGX7konAzDFFtU2TCp2Fd942zxdIs/nUxg4TI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6355 Content-Type: text/plain; charset="utf-8" Makes dirmap writing looks similar to dirmap reading. Just a minor refactoring, no behavior change is expected. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 49 ++++++++++++++++++++++------------- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 7f33131fb6ee..cd0fd5c2bc98 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -670,6 +670,8 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, u32 val, rd_mode; int err; =20 + as_ctrl =3D spi_controller_get_devdata(spi->controller); + switch (op->cmd.opcode) { case SPI_NAND_OP_READ_FROM_CACHE_DUAL: rd_mode =3D 1; @@ -682,7 +684,6 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, break; } =20 - as_ctrl =3D spi_controller_get_devdata(spi->controller); err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_DMA); if (err < 0) return err; @@ -745,7 +746,7 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - /* trigger dma start read */ + /* trigger dma reading */ err =3D regmap_clear_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, SPI_NFI_RD_TRIG); if (err) @@ -801,37 +802,47 @@ static ssize_t airoha_snand_dirmap_read(struct spi_me= m_dirmap_desc *desc, static ssize_t airoha_snand_dirmap_write(struct spi_mem_dirmap_desc *desc, u64 offs, size_t len, const void *buf) { - struct spi_mem_op *op =3D &desc->info.op_tmpl; struct spi_device *spi =3D desc->mem->spi; u8 *txrx_buf =3D spi_get_ctldata(spi); struct airoha_snand_ctrl *as_ctrl; dma_addr_t dma_addr; - u32 wr_mode, val; + u32 wr_mode, val, opcode; int err; =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 + opcode =3D desc->info.op_tmpl.cmd.opcode; + switch (opcode) { + case SPI_NAND_OP_PROGRAM_LOAD_SINGLE: + case SPI_NAND_OP_PROGRAM_LOAD_RAMDOM_SINGLE: + wr_mode =3D 0; + break; + case SPI_NAND_OP_PROGRAM_LOAD_QUAD: + case SPI_NAND_OP_PROGRAM_LOAD_RAMDON_QUAD: + wr_mode =3D 2; + break; + default: + /* unknown opcode */ + return -EOPNOTSUPP; + } + memcpy(txrx_buf + offs, buf, len); - dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SIZE, - DMA_TO_DEVICE); - err =3D dma_mapping_error(as_ctrl->dev, dma_addr); - if (err) - return err; =20 err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_DMA); if (err < 0) - goto error_dma_unmap; + return err; =20 err =3D airoha_snand_nfi_config(as_ctrl); if (err) - goto error_dma_unmap; + return err; =20 - if (op->cmd.opcode =3D=3D SPI_NAND_OP_PROGRAM_LOAD_QUAD || - op->cmd.opcode =3D=3D SPI_NAND_OP_PROGRAM_LOAD_RAMDON_QUAD) - wr_mode =3D BIT(1); - else - wr_mode =3D 0; + dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SIZE, + DMA_TO_DEVICE); + err =3D dma_mapping_error(as_ctrl->dev, dma_addr); + if (err) + return err; =20 + /* set dma addr */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_STRADDR, dma_addr); if (err) @@ -845,12 +856,13 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, if (err) goto error_dma_unmap; =20 + /* set write command */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_PG_CTL1, - FIELD_PREP(SPI_NFI_PG_LOAD_CMD, - op->cmd.opcode)); + FIELD_PREP(SPI_NFI_PG_LOAD_CMD, opcode)); if (err) goto error_dma_unmap; =20 + /* set write mode */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL, FIELD_PREP(SPI_NFI_DATA_READ_WR_MODE, wr_mode)); if (err) @@ -880,6 +892,7 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, if (err) goto error_dma_unmap; =20 + /* trigger dma writing */ err =3D regmap_clear_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, SPI_NFI_WR_TRIG); if (err) --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020095.outbound.protection.outlook.com [52.101.84.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32B2B315767; Wed, 20 Aug 2025 12:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.95 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693214; cv=fail; b=klJdqnS8fpY6pFVtfa8evKbXIkAUzQBrlX59PjhASkEhQYb9g/5W/2j/kgIxIfboshpGimsHMc9Dvv3e9Yl3nXepR2CkTDO7s3Ew/f7RZdnu739QCVNAR66G1WZcIjh2K2xgjFGpyCV+sIZTiNwKRVub10lbKilvH3V+/+JXiHg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693214; c=relaxed/simple; bh=MTYnODeYhTsX3YY7hITJgT/n91zn3cUfIZ98jwBeoSg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=lQ/rCaT5FtcY6QgfjJpFbXVkBs6oTm1XKU1S5IRTbiTOEKlJtwAKq32U888rNvDIw0Wam7mmjNDDr7lG+jnYnUFiYHsX8miTc3pgkiecLWpLaVqjzHplh3xEOTwqDzNt+uQ0MaTWBSoJo3/2vetboKQxDhyk/CWHmpmwHCoqdnQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=GxQ0D80b; arc=fail smtp.client-ip=52.101.84.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="GxQ0D80b" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vS8glANghkJEi9NMUCBbQ3RwVnpTd3F6O9byFmDLNVcIHYM8652/lHRGE9qrX+FeusfV8JVD7MX/ShStKoNdqDY+Zb+NvdpOC8+JOY4b4p/HuepM+t10t/uTycoYO/Ur+m5vWbzNaHluwpnmgz1HVWUdG+sNZ6E/XBONk4X/H1b6QWd1VNC6/qxETKGe2U4C4EAXPQEtO5gPw47VrS89c0l8wPKIfuBqhxXUT8/rRiHacOdN4oAIeTSKHa9lUUVD3To6qeD9LpYBl8+zL7J3AAqoIm0GUHTEzuBq7qEjQHi0iEcOhTd5nws/Uz1X6aC5SPcbbu4V7C2f+mTUxSlAdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dpihme5mzGLcLLMNadXpFzHnxAv2SpPQgzsKExxfH70=; b=BhzNt1jLP7Bv92mnFU6lXLkA+YnA1hyZXWEoG4ZHWQwR7JgO1cfzNMpEhEUqCoUD/1Zd2xXFqUtcAP+AtTnibiC1EPAB0a2lVh46yy+kc4n0rOTPcWu3BHpq0fAlRFzX/ksPG+9+mrOr3XQspg5Oisp9FzxYHOqkrYwaE1yTFrSszaM9KNjN5RfMylrQPhc+8vgFTGoyba9eFvgjKSKSVUItiZBJHmwm8SAkuIhWqgCrLhmunClLn6tJDb3MMEm8plEIKLEpnh8d/aKV6wsADON2bkctvpzl2ZTzbPYAxHgg06HFUxWzoR/1ws6iVYXeKH9X8uF8r9psRmFJA7IaLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dpihme5mzGLcLLMNadXpFzHnxAv2SpPQgzsKExxfH70=; b=GxQ0D80bpxsKdDWojVIgq0MYLiLiSTv6B0NUK8EsTuw39F9hGNmxGMuc7I26ljpIhrTb/Khll8P+hGG3Vdj62c+4ZBI1tHYtuhQtTwO1xM0gdoaHFJ5/bsPzhuRPu1ERb2+vD0hA6HOE3C+DsnH7QfmXb6KH2pnT5fv6vj8vs1RoOtF4C9CS9SjWaaALMrtEh8WdPEO21k8ToiRycymtC3mXKNXs2jZqqglEu9+ob0V+bH/tSO59b/QvDoQtoj2OO074H6Pb7kRcusSJNY7tF+WGf15530PQgdCBeSj2qR/9PhRaIxkGCfjJiTj9B6QdrszrFfNRhGPzFz5y0mPIKA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:30 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:29 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 06/14] spi: airoha: switch back to non-dma mode in the case of error Date: Wed, 20 Aug 2025 15:33:09 +0300 Message-ID: <20250820123317.728148-7-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|DU0PR08MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: cabfe00a-4e54-4d68-5b06-08dddfe5c495 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?jdvEdfc+RXa3kh7vdszXV/ZATE3ed9bShEcmlwGtCe9wDJXjU2VNCrq35d1B?= =?us-ascii?Q?JQhqKA2vvcDO5YdBoy0vZcQxyarhfcHiIBIBqTUQTGkpOg9avtLnvoo4IQXj?= =?us-ascii?Q?RSPg6Uy2JtVqXBdJjg4QgHb5BfAbNDq5IhzBoyDbxuBK3GllL6HUqXT2cSlH?= =?us-ascii?Q?sZ6kyuH/xIOYzUQIfD32jpwr2zWV/kkVr7Em/2zpSVBtTEQWdBwgokfjWLyb?= =?us-ascii?Q?xMU/l3y44pzpMewB0bwiQcJ+BbPd8QsQwutYLpHtkGrjEACCVz0NUOI41ECs?= =?us-ascii?Q?wH4pYbETgahRFncADooOvRnbH0PxrUTu6pl/VEQlaLQWk1hoke9ftcKGS2uP?= =?us-ascii?Q?F1MiO+cVwCt2/YXeaHgkBqBJbPS6iX4YVFwzu8f5XVJXKG78uWBeYhXQnwIk?= =?us-ascii?Q?ieEy9tDov39+txunjMw2fzID0+jPfJBJKL4k04xoETXORnsLMVXsrOlppHUD?= =?us-ascii?Q?138NTwenG4Ru5zHR3XmgEmcwldG0EWV4z+0VUmKHo0X1lPVL1EQauS946q6I?= =?us-ascii?Q?IktbxLtZKLuOB/l3XCLw1pMbGkNzUi0ectXO3vb4HlmRB0liJ1BsqM2AoHD9?= =?us-ascii?Q?3P6JBBTXhyX7jwiBYaNe7BB+EjxO6W7g/FNRtOKoFwEDcR6BT+jsmmLu0EdD?= =?us-ascii?Q?Jferxma0QTiSQQmpVz10POXmjP+oeM7rBRghgK/bIlGzkXSbjMZRd4Qm7/m4?= =?us-ascii?Q?oz/L6D8+zboQCR3NFQLMYh7z1EzKDI950Qg3HfEf6oYdGB4IvmTqhtU2YZeJ?= =?us-ascii?Q?TvjIr7D02vGqUcprin/waTZBHLgsdetK+t10hIP5u84olk4bUgReqg5E9Ct3?= =?us-ascii?Q?5QEB6yzvWmpKKxZnyozapq4/466DQQ6WobLUz0yi3n0cFKI8h7fDLTY0+Iae?= =?us-ascii?Q?Yt4LBvx7gLN5B0GUXIOCKWSi2c+jrycRO2kkqLyJnUYh0G1fX07W6MXhy1vB?= =?us-ascii?Q?R+SYMDqko2G3b274/GL286vIB05M71vC3RIfsLUnvyJPz/RJmpL4r6c2EUmU?= =?us-ascii?Q?JW52TYhMNzXRpF+Gvnd46vcQBNGv+baBsoUR1FZk/LQeqe1JhXcbkJ+X0PMF?= =?us-ascii?Q?ECkf0lNoQ9vX7TdvPS6wXtGV5GIc9VMdrgKxUk5gcrqDjF2OJPs/Q7mD/6LL?= =?us-ascii?Q?ZcEuds9F6l3Q8/Ilo6qRdWLMpoyW8ezt4m1L7vidIYu12GGsb13XfW15esR3?= =?us-ascii?Q?PlgzYEBzF4TcWjOyjwymIQE95fjeWxw9qRo3uJYzjC746E9/GhX9/h+1n71J?= =?us-ascii?Q?Gxw4sz8Ui0+1ZyxrEiBp5FrycQOTy6eLv0SLXLHvfG+kswqH6ABl7WQCPFpl?= =?us-ascii?Q?etRJ8PM4/w2yZg7BLNZuFQ8IQ3ZLZn7VGr+tFPgE9ab1/8FR3kXY3bDZWqCX?= =?us-ascii?Q?jU785PvhBwG6HSsVSLemca6PqW2X56l7I3zSx4b7X1vn3gnrszzgQVRNZaI+?= =?us-ascii?Q?NVNpBePlCyqKyEvAWp9EmhhJHjetr32sTa4vsuh76WHsm8FKs+5ZiA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5Y9mkS0vF+d3TOHoirUYlbasrN4/nUHVu9vivUBqG+CTBTvCCunT7thP7WCT?= =?us-ascii?Q?nvZGbglsKRwtPxqrAsX2FQE9tDo0ZaNS49FW+ZAwTM603BjrQcMaruwNV1We?= =?us-ascii?Q?NWue57qLFE3xtQdrP4f/+qHzISsQicSMvU6bc3JjlBdIB4+VRo4aCogU4fhk?= =?us-ascii?Q?p51OPc/tqU8LCa+A459gAMMXngkGaqgrymybsuOd9eN/L/bCOqwUoEjQMxeH?= =?us-ascii?Q?eBjj6+QsyR4xdGYsyRPmXWMrdkQuJn+Jwomn4kdtwUi/ETpMQRnuxXprpUBo?= =?us-ascii?Q?CLV9rtjRfOqFYSG3cEoiwnBZgSWPOOHwiGw7YKrbfYsnbveYQ/49+CHc8h5w?= =?us-ascii?Q?YMnkCpwVeiLzdw3vzTHRZBU2S/DiDCgONxTooEQzyErzRsqqV4foLtZ4OtWf?= =?us-ascii?Q?PTkrhWsL/pebzxaX/eawu9Yc21adPqbYzrB/NNxo825D7d3OSIcMB5dBUsXx?= =?us-ascii?Q?An4fJJfzJeVUK+HtIjMEl0NlWR26NcV//LrVFPL4cDi2Dv7cAt4wX6DT1weY?= =?us-ascii?Q?9zOr1PilG9gvGZRnVYs8CNtBH4/7Uq0l4HVapwYVKDYUw1vYKI67Xmb6/a4F?= =?us-ascii?Q?plHk2bc8Xzw/dTB8QQpXiAY2rWwUZQoXxkicMCHaJNXN6gwPEBR63VDVLH9p?= =?us-ascii?Q?qXo2ftfC52e0KgQDEKBoRtyG7SwgbF/aCV7MCVIddpYKNpbuZfcuxce5IjWR?= =?us-ascii?Q?7NcmHEG6lAA5LBjEFYQpJ8beMBjH0anmfZsfaENn1EOkRJ8rFLSL6NOUjJwm?= =?us-ascii?Q?wttCn3OuPaRu5jerC6c2HfPt/zWOuRp+HpwlbtR9RG0Xhgh7AWN+qsgL6e6V?= =?us-ascii?Q?yRrYS57OfFuEUkGWKtsz8Kr1gp4xnXTZNVgapLn+N3of1wv4GnmL8xtKRJWJ?= =?us-ascii?Q?lUIGGW8dl/jCxQk1iZcQrBQkk4xbfHaTPwmAym+Tk3YDrkisL3fbYOz40WmW?= =?us-ascii?Q?VONNLlKowPassikJqKUrzdzGDc3hNjkIs7o8NvqF1RG6FwcfAuX16DUMVg1Y?= =?us-ascii?Q?E02VBSOkXxcd+jTP0XM0/WBPuPdyPtIrLuhJz8elMOHNAm7YQeNoZFvTZS6k?= =?us-ascii?Q?pADKTsCB5mzrro1YOXNOeZt48GSFqnqfCkaM3RsK6VQzlaHcrZSlHPu0kFMq?= =?us-ascii?Q?Wf92BMr0Ojl0OsV+5XLC8TzQXYRhVgiyPmqUYWH9d8dxf9LkNZyyiLiuGx6g?= =?us-ascii?Q?l+vaQmfSwLPSJTyeYeHD3iRETmPNqWKYDcMXndgtz//k5V5PRILavBkEtjoR?= =?us-ascii?Q?Pl7kxbzxW6PeHBY2PN9aTo7VvslPI6HYZQ21DMZkEJsfsgmNkEBZI5fddOZ6?= =?us-ascii?Q?WlwDNxW1csIDmvDdXG50sVuZC8JslhHJUQuXITyv7uZGv7AdowO7ecX1Jjsv?= =?us-ascii?Q?WGubi2yiBgGtxzk/RH7ZJxrY4Oft1oC6VA7CNDP6AbrLHwKcp18cAKy/+bUK?= =?us-ascii?Q?YdU1gWrlWWDL31PT33+3SkCzhMiQxRLDU6XCHKtZ9zE9Hl+kFnE+0E7XvPJH?= =?us-ascii?Q?QA/Au8VyyblB3pfk6u+bNN5oT2jE5g8Zn3fptXmsLLDHs4ogLh2mGyxHPa7z?= =?us-ascii?Q?yVcFEZpnsTu+3uqF72siRyw2fHy8K3J6mOIeSpn5jj9WBLkxbcUHSDoGNgWr?= =?us-ascii?Q?3Foj0mJzHfkvaDxYvTxRV60=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: cabfe00a-4e54-4d68-5b06-08dddfe5c495 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:29.6509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KSCgnMhUqdBhHNGmc9jwRb7dNXx4D31ZZ26meXYZ2sCLbLYw0J84TyoiGSpcpT0TPcFuU0oXgjKZ4Fl6RIb7tCCsgs828kogY7bKBkjvkeo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 Content-Type: text/plain; charset="utf-8" Current dirmap code does not switch back to non-dma mode in the case of error. This is wrong. This patch fixes dirmap read/write error path. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index cd0fd5c2bc98..3f15c26a467d 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -690,13 +690,13 @@ static ssize_t airoha_snand_dirmap_read(struct spi_me= m_dirmap_desc *desc, =20 err =3D airoha_snand_nfi_config(as_ctrl); if (err) - return err; + goto error_dma_mode_off; =20 dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SIZE, DMA_FROM_DEVICE); err =3D dma_mapping_error(as_ctrl->dev, dma_addr); if (err) - return err; + goto error_dma_mode_off; =20 /* set dma addr */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_STRADDR, @@ -796,6 +796,8 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, error_dma_unmap: dma_unmap_single(as_ctrl->dev, dma_addr, SPI_NAND_CACHE_SIZE, DMA_FROM_DEVICE); +error_dma_mode_off: + airoha_snand_set_mode(as_ctrl, SPI_MODE_MANUAL); return err; } =20 @@ -834,13 +836,13 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, =20 err =3D airoha_snand_nfi_config(as_ctrl); if (err) - return err; + goto error_dma_mode_off; =20 dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SIZE, DMA_TO_DEVICE); err =3D dma_mapping_error(as_ctrl->dev, dma_addr); if (err) - return err; + goto error_dma_mode_off; =20 /* set dma addr */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_STRADDR, @@ -937,6 +939,8 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, error_dma_unmap: dma_unmap_single(as_ctrl->dev, dma_addr, SPI_NAND_CACHE_SIZE, DMA_TO_DEVICE); +error_dma_mode_off: + airoha_snand_set_mode(as_ctrl, SPI_MODE_MANUAL); return err; } =20 --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020095.outbound.protection.outlook.com [52.101.84.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 278DE31A043; Wed, 20 Aug 2025 12:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.95 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693216; cv=fail; b=Nu7XBeOorDRvl4lyFqqLRiI5Ex2trEZ4D6D/tjflssfF7xjHcK9LeOBQxBgHNpL2udmGEHPLWSCUtNJR/gDsE0Sfhc+yORdQ5G52Fzb3Gokm26tZcraLnOm/NdtRp3RAZKAw85i+i37Q3RPRW6tyjqAHC6KVtw7wLd0Fzhl/r88= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693216; c=relaxed/simple; bh=pvuHC0j5KpuNTPRSIwTzuJq0wL4Cmht5scP5T+ro5rM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=m7oFheDPpkQkNnpUCEnWdWdmE9KsPYxhi/SIgrqJLuck2409CXc2gUP+M3fNNI09iMbqnd0yCC7qNBQ99aJg4IhZO7Oe/JFLWmR++aoK6TFlOLSxOoQiMQRULMi93PGkSaOsLEMn0wLa9Nt0G2J53gnXa1A/Yn/Fms/T+YN1vPY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=XrotUB6V; arc=fail smtp.client-ip=52.101.84.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="XrotUB6V" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c921xMrXMDtQLWY7/1+oT8r0sPC7hhKBsUaTzXbtqgtuHvcQC7fMnt3ITQL+eLv/ax6mH4k9h+fAWXPJzZlBEdUhAkhSFa8VQ5AclBafKqIsmznH/0JZFDy/EC1+OssK2O6DTk2O4HQR8cc9bmuBvzDsFNh35brOoyMiTu2D3GHYtyr4KI+v7Kq7EH2N1qc5AcG5hH4xMaHyfyRTi77WncbX8FMt0Vx9P0zw9f/mj3J43l3XTxJVMNjYlXY3IG8YRPX6tgHOA+ZfK7Ybqg4zACsQnfkqHc54ZfMpgZkvKxhlhd96JJz5wH/vmSlmdegVbtAmpdMDfK95j1l+XKkEEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x7LR9hp67UNwyO2xROSKxtkceXfRdbNTlh+jBsVvWUM=; b=CCQMee4Bcp9wP9IJwEsSL4ZKecSz0BTY1EmCkWDV8/XnIqPiWBLOyY2BTzQuLEOHSArHOLh+ysuwX4iOkBCo2mKKWI2K0SH0WvXCGUdqccPhM8vXNaZQfCVOmOtESb3qkkYeKlMD83L3VzDyI7FP4jh9uIFOKZfmp3lXUtK9Or1u1dvO2qHDyfd5iVUbe0ZvgH3deF0BCWMMMX5L7XU4DLEqUZ8eQh36dJGeiMflp7lfwlVnxhTxiJJ7pyKFBMRO8wJ2oXVXYuohVFnkRcJ8eMJcXDwlw/walXWQOEdd3ccY1dck2YXuGZkd7C9bemglsEH8MFaIi4onrLV1k6KRZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x7LR9hp67UNwyO2xROSKxtkceXfRdbNTlh+jBsVvWUM=; b=XrotUB6VovziqZu45lK4/hnMrWpGwx67EYSO/fq1FPVx4Rd5nietlLk8gCXa+RNK7mIP7bjc+JBsmoIqqVCGCkJTQgY3i99fxjNY3Xa0TX5fKhbhNKfGDz89D63HFvyZkmQSJofZRp8llyZ5Z5beTfu4s/YFmop8J1t1i+S56/IFxkuX9W8jlO/eE6cUshSX0SC5O4fY4XSvLoEDs6ehWGl2seUyveEC+04IceUyXN3usbOIzUopnjjNY+I+jpk5UtH6VsmgB1H9+pW/8UPvU3vF7K1rkCjUVmlLHbL90k4xzBiYirGTBi3ZyvDSqz0nJ3Mw+8W7jFmL2dNHbatbfg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:30 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:30 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 07/14] spi: airoha: fix reading/writing of flashes with more than one plane per lun Date: Wed, 20 Aug 2025 15:33:10 +0300 Message-ID: <20250820123317.728148-8-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|DU0PR08MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c7871cf-e085-4782-9b6d-08dddfe5c518 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?pR7oQ1S80wS9BaMPYj6njFOtHUMIY8IFSI3/scTpk5kPgW5hQI/l/p8sUANL?= =?us-ascii?Q?4xvqHN3f8rxSJUQ/rAcwpuj/YnUSSX6oH/CDEWAwFx/E2Sb1xMnscxu3afDI?= =?us-ascii?Q?H0auNt5PNqe5ZSGMM7csCYtZeFcSQ1DSSzWtxEUc8F3yyzIdjjConLJwz51t?= =?us-ascii?Q?mBw869oLF8gXXWqy2l7URdjcuwuwGfjjnm0dUOc8ony41LRs8Jlo9PmLRwJt?= =?us-ascii?Q?9sx2aQAa867PsYS3nu4YgGOhv1Eqs9NjWpNvAw4YucFS/28boYuPu9LSVqUO?= =?us-ascii?Q?X546PFBMK6pKDKBl/a/e6pw6E6PaM7EU6cBiI5unrXCLZNlk5vy9hIgkWXDj?= =?us-ascii?Q?1f2CqYV3c3G3vm4we2ZW5BfD0uGhtX55RnVwc+X8r7Kk7o8FwylW67UHiVSr?= =?us-ascii?Q?DZBlAA7g62O2AneGYknJMaIcIX72k6Jxwsvgjz2OVw/SstDOSi8p82O2gVLs?= =?us-ascii?Q?9u57a9kEUrUXKYjw66C1435VUyEJGz8lS6Qq/AGXTovsYd8E+MyPJ95rsRiA?= =?us-ascii?Q?H9oDiJAva5dCXCmi+LVJUn6/1MOgzvf1E3C1XNwpzmVO8z8mD7guWYcmfv6K?= =?us-ascii?Q?Oa6QTsireiD6qaR92tWgtxXZcKOFHyu/EFJNBqkgevN68h/CvubjMe/PvtqN?= =?us-ascii?Q?lxGhgnq+zEY7O0572kCzx+I1yeymS++f6kl/KSyElJ+nnwIa3Lp3hEDbi0Vz?= =?us-ascii?Q?OL3jAdjfH1uPAjADLown+6Gz+WWKnKb2zUeiss7Jiqq7hqE/q+JnSE+6KJrz?= =?us-ascii?Q?dFEMXUej0Dz/URb0/DdHloAX7u4NSqRzqbo9k0AinKTEPYD8+2POJnCqdx/C?= =?us-ascii?Q?sbx+xr8FEtw62ykAsvq6anFNlIBGHiqOlxLZcmFKK6i2FNFiojjIWwa/K4Mo?= =?us-ascii?Q?3FGHwDgp0/PHcTE7xuRKMlku0hN/DBhiR2c9qdKsd7wNxmCrMhGJMiN+MR87?= =?us-ascii?Q?lVGiFAa1izVeeJOENUOm2ITjzLiQ2UQjzyU5FZCPPp09ltf7JrjytN/9jVOb?= =?us-ascii?Q?AP5xizoaaF6qpcL5A29Lw34QvLdRh57ORAv5fGHFLDlyNrHqgfvYtsWbA0/1?= =?us-ascii?Q?YPsmQdjfS2vt4RXvd153CwhwSYHhihYNgYms3nk5WpbwivQKWL0hZLf3basb?= =?us-ascii?Q?YDf+IrttpaXnqWz6LCKCf6WYD0oKs3l/G8tBPhm5tLIZ3nxI4aOjQoZYXl1l?= =?us-ascii?Q?eGDxde7+CjAaE6LfA6Cw/yCD8CczDik7OWJTWP/xxPzDykjzS2EfrnXp/LI7?= =?us-ascii?Q?1uvzPypbp+Q11SR21MHCG2j3X0oIqIrtHkx8QfdKS/QB9f+aPXs2x0poePks?= =?us-ascii?Q?uBLw4ns59A6qQqOy2TCQymd+Im46HwU5ZSRFaGheA5RJEE1OJkJqp2opx6Oq?= =?us-ascii?Q?TBMDsKGV1dAb+t7e2HLlIbtArvWAtcSy/X1u9khqjD2oZzNHEMF94b3yQWn2?= =?us-ascii?Q?ub+bA9b2DMJE6B5cD5EvrM8E3gof1S/GRBb0y3DnInubs5FvmqYqVg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q9nseVgenXCszMh43/V6CNeLwyC5RAZxB5+zptiaxI/vn2AbZQDwXhEkjlkN?= =?us-ascii?Q?T5TlDUTEc5rR8cjd4SGe77n4nfCI57orpYMbKbvjfR30hzJUt0jzY1DdA7Ck?= =?us-ascii?Q?lny0WU8unCJBq0O/fXIYSQUFuS0eowRojwbAup4lJOPVLuWZ2FfvDIEUYdg5?= =?us-ascii?Q?eWAh0Go7+tKh6vxjasVOscQCcVdsnn7CDRa/qJcqAalPYf5e9mLcaMLnnnez?= =?us-ascii?Q?3/vnc2f27YdfrL2XasjyaHG/KLSTQxxVpi9QQfoJG/RMmQL4lT7WjlMy9HqG?= =?us-ascii?Q?VvDTD/V0yiuvNvKp6r2TSxruR0d9QjSrUHN54MmU6RuL2X1YJO4b4l3Ao2yI?= =?us-ascii?Q?qLURelxPpDTej/gjYPhVYaNLC1/VKlPGKKKY1H0LrxccDxEwb6QZuQylg4jc?= =?us-ascii?Q?WeJ9zKeoj9COGymsGihgKYNTGcb4egpL4W09yWSPjgFdfFfPgn4BixUQPWp2?= =?us-ascii?Q?QSGBeP+zZ96X1Sgmf+gTFe4/L/vPaFZUdBf9rn5EkTBEa3O23dhOtGL8AjN0?= =?us-ascii?Q?OFBrnkef0vDtjSSDdRKqk1kAVdOlO6EAGAS/LPSstMiKddm1QdxzH7+91HpR?= =?us-ascii?Q?1it79EpzPK0ftzbWs+j0LJ6dGlbrna98F7qN/mGumgmOTncheHtWBCsKVcwJ?= =?us-ascii?Q?pFIV/X/10zjnaX0YLOWfQhwpY0qFoSrSYWhmDmzZLNA2NGW5DGQkvby4hLWl?= =?us-ascii?Q?mxxNqeh108NIg8deIMsAeV0guZLH5Cuz4duMe2OcCbQkRlIT95qxRPK52paz?= =?us-ascii?Q?4Ye5xF5oaPJNanztC36V21M0HlUg4dSy5Zhk7qQMx1NXb1fy429rlLZNlZej?= =?us-ascii?Q?QOtHApdSyv7D243CGBfEJhZdqUPdPZ50VPeeSc3XQJtK+UpXl+WSr4ROx8IV?= =?us-ascii?Q?cZHb7SMhXJp05JBmWxDpSE2PRh3thZqYPS53hpf1YtsJ74QD2/pTDqVTAUXj?= =?us-ascii?Q?jPIXc6JSR41PmBwxFcs10v9cbWVJfTSSODiRwc5aajH6pZJZMy+FtlEovuty?= =?us-ascii?Q?lZmfnbcO8aNsO4f1x9pr6+p/kO2pDbdqhEx/uO6BjptOshiSyKLE7nIKCBdN?= =?us-ascii?Q?Hou4L1Sim9znj8VzzA9iE/kYQsWX7rG1UcMzyyNpRI78ocX2btZ9GW4HLxHx?= =?us-ascii?Q?3oD9xrXEvUL9y+McOME6I7dwBUoFmijghVTq0IrxIAZvrb9+pa4sxE7jikLz?= =?us-ascii?Q?XFM19IAQKnc3UdUjCOs1AC3j+rjBZTYAAVImQHv0jyXjMJm1de09MqmzPgU+?= =?us-ascii?Q?gvuoXmiFn2fF1O6GgZ4A121cNCLt/GVDU/gl2hBIVr8kBUNCdnkwtcKDMfGR?= =?us-ascii?Q?SanyGmK39WwgHMb2MmeBCU42iA5wD5WaHcY5bkbRP7ZLVx30V/z4YohODyYj?= =?us-ascii?Q?QtZS75NFTx3MzApeu1NYY9hERXESZTvUaiRoCRnFlCwfI/dL95mr9g3mXnIr?= =?us-ascii?Q?nOSKbLAFEdXnfucHW3OJx/yBCzj9lhfY1IEBhDOoS+7xyM8mcofyjNEWMXCm?= =?us-ascii?Q?Dmz9fxpv3HWQC8uOpuXGtUC2fcjv2+Rf/oljHWOzluSTjQfrTjOlNdJNRLpJ?= =?us-ascii?Q?ZtV7CMmIG2B6kH/9w60hyH2a06hTs6B0zK1fgpj8TH1hbuv6a/oZAqt9nvOH?= =?us-ascii?Q?8/xZp2jH6P1IQT6tq8ns6SM=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 0c7871cf-e085-4782-9b6d-08dddfe5c518 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:30.5268 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dXmm4e3LQu+NYy27EY+58Lo7gnS8ZBUZtz3qNfnCDfbr9Mn9WSTLsv61UIVH7l3SmE1PJ++z904M5dzSnNnJrA1SKCIbMbUs28kWS1MQt2s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 Content-Type: text/plain; charset="utf-8" Reading UBI on the flash with more than one plane per lun will lead to the following error: ubi0: default fastmap WL pool size: 50 ubi0: attaching mtd2 ubi0 error: ubi_add_to_av: two LEBs with same sequence number 403 eraseblock attaching information dump: ec 1 pnum 538 lnum 0 scrub 0 sqnum 403 Volume identifier header dump: magic 55424921 version 1 vol_type 1 copy_flag 0 compat 0 vol_id 1 lnum 0 data_size 0 used_ebs 0 data_pad 0 sqnum 403 hdr_crc c8418a31 Volume identifier header hexdump: 00000000: 55 42 49 21 01 01 00 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00= 00 00 00 00 00 00 00 00 00 00 UBI!............................ 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 93 00 00 00 00 00 00= 00 00 00 00 00 00 c8 41 8a 31 .............................A.1 ubi0 error: ubi_attach_mtd_dev: failed to attach mtd2, error -22 UBI error: cannot attach mtd2 UBI error: cannot initialize UBI, error -22 UBI init error 22 looking to spi_mem_no_dirmap_read() code we'll see: static ssize_t spi_mem_no_dirmap_read(struct spi_mem_dirmap_desc *desc, u64 offs, size_t len, void *buf) { struct spi_mem_op op =3D desc->info.op_tmpl; int ret; // --- see here --- op.addr.val =3D desc->info.offset + offs; //----------------- op.data.buf.in =3D buf; op.data.nbytes =3D len; ret =3D spi_mem_adjust_op_size(desc->mem, &op); if (ret) return ret; ret =3D spi_mem_exec_op(desc->mem, &op); if (ret) return ret; return op.data.nbytes; } The similar happens for spi_mem_no_dirmap_write(). Thus spi read address sh= ould take in the account the desc->info.offset. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 3f15c26a467d..7e1381c8f44b 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -725,8 +725,9 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - /* set read addr */ - err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_RD_CTL3, 0x0); + /* set read addr: zero page offset + descriptor read offset */ + err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_RD_CTL3, + desc->info.offset); if (err) goto error_dma_unmap; =20 @@ -870,7 +871,9 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_PG_CTL2, 0x0); + /* set write addr: zero page offset + descriptor write offset */ + err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_PG_CTL2, + desc->info.offset); if (err) goto error_dma_unmap; =20 --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020095.outbound.protection.outlook.com [52.101.84.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 363FD31B10F; Wed, 20 Aug 2025 12:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.95 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693218; cv=fail; b=Ib199sfET06F4bE2SrZloK80pmbYZinjyV5nwMv/Vuz81xnr5sKnplOVbI8D+qhig/bN7jw1b5oIpk7vLULsOWZNRi8E5SRIBTbv9R4HdmuaoXOcTc7JnLVAWu7+Mea8+ax/m46SawUC10/SnQKRTqCcPKVGeAwmtR96dNz8d0o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693218; c=relaxed/simple; bh=pNp22Sh6e9AsqSLN/KzmB+Zok3il72N8/jfIoC68sPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=fxh10I6TPltCDY9XagTqJwwlLUrqFqSXwjPrAkMSwFxzqnbVhF4x5Y3rTn4pX8BAimU4+WWk/51oDYHFQPNVTbReNTxKMVbr4wgho3rrAWolIIA+W6urMcTCDv0GbZDXV8jfLKIB3W0H/K2nWIkPERDTbaejTrIYtlKs4fUh2m8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=rgt2uyCa; arc=fail smtp.client-ip=52.101.84.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="rgt2uyCa" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Iat6zVvw/LVkaH7SDYe+GZ6ePvdlsQR78uGYVw7OxkYon6q/X7STqlsg3x/UEvWfenzcboNRspP3K8kVtgayTEVITkcC6Sw6Az23GpILEjs10EjYsfKmh4hMKsZIJIDS/mTdowiDxKYdjlPkCey7l5jcz2kFwB1siek9yLkuV1jaWZMe5hWn0HUb6rGhRig/FUNVm3Mg3FE411BwGf6qElFBaoqTrTPxDiaX4iggOfvaYR6l7jdthvcUF4piOmrvVWFEWs9aLRb/8XhjPxCfNfG4U/FixXaVVfR9iCd/Lu80iI7W4zUZa4KqeuOwPDW9RupXl1FXUTlFw9TAZAq62g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Es9x+/+9CC1n6oSvune5pmvqNoFIy3LcqCicOnTCaOA=; b=sHH96G7WzlfdaaEmavqVk8cCI3TQnqqJ57AJ0MRwQOppqWPaW5sH72uNgmHdsbVCpmK3y2mkpwfiMMb0sc6LQ4ZS/E5H//IQiEipbzVykYkVkIPZ8HRvZsHVxKWyblIi+SQDw6R3sSKoC1twVMyH6okI7kOmF/ESlpDyycKYIpKxY5/zX0NKXTYGPB9JFuEdFd8rbhbqJws8ZBvRWsM88eTnTdsaLeHlm5VSkQBAq9dvbOYP9rOPzHOUaSoMAfSlNVjezPiojFVV8rB6LdFLgXM4qSJcY6Lt942+u8DIP2Fx5BoB+Mhdx/a5vKzjig7Hkap/mrBVuK0Nz6iK3UqmJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Es9x+/+9CC1n6oSvune5pmvqNoFIy3LcqCicOnTCaOA=; b=rgt2uyCahlqrtdm/2gxgPJbkVtAwYZ4RlVRZLkUZQLGYzMKALFKBocoJPy1AZ4bGHykFxbdEw/ad50Een+0obKpTB9QAjJafACxbBdDk9533ijgNS9guh99g15sMbG9smoSsYIrvCI8VVhHpAoG/aHKdCnKrZ3mmey3hp8DUaAbCGFMFj0vjuaEvb7w+QsdwleeQ/9pNnjuBGUgW6UThpnCyVA7kC/Dg3eb02dKzN+Pw+IT0Y1eyWv6RK3oO5Ct+o2K3xVIy0dqPz2w/KfOYxkqKnGzr4dbVunuWeKDeqU69p30q31ZUYNBdWuc+K0B6bJlh5Jk8yYthu9Lx7ueh8g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:31 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:31 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 08/14] spi: airoha: support of dualio/quadio flash reading commands Date: Wed, 20 Aug 2025 15:33:11 +0300 Message-ID: <20250820123317.728148-9-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|DU0PR08MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: fe189351-b577-46b7-2cfe-08dddfe5c59c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XBqO2CfSebOr5yR2LxBsOq+BwMQj70EcN60/Cka+qBnX6iGENNcOpPAGnE+7?= =?us-ascii?Q?aj6D4p9Pzg8uAD+L+9ELkRVFTTEDyOGVL1lY4gLGvT/G/tm2YYH+R3QGK633?= =?us-ascii?Q?kUx5xPms1XHdxwAhlYLF5hAHOw7Vc6eLEsPU+RulqbnxUA6ReFhL+S//OuMR?= =?us-ascii?Q?0qRbDN62PlA13Eh/Hvm7TXsis3y3r0w37B3DBB+gTS2HFTKWP0e3p9wccdq/?= =?us-ascii?Q?wUluqm5rpDA9s+ne/9NNM7wviai7CEP64H5K3hmvLTQnupFNzmmAJuGx6SNg?= =?us-ascii?Q?2CPFXPTjAK8EwUUb+gBgke8irDpEGTM8hMEAdtHFdmSUs+Pszo+Ym3ctXPKt?= =?us-ascii?Q?2SlzYfDUPe/uyOlCN+NKke51yzgwL7oDEqQyzKTTVU4raeGxsEN2KnfjWuWG?= =?us-ascii?Q?VbHMC5gw4Ywd9yLbX2zQT5VjOhVznGIXtOkCmfIDvQKQ0sMr4X1lVmh6Q2lT?= =?us-ascii?Q?DBZ325xa1+WSwzTAGJgbM69qR1U3bZr7AMV6YypDntxGwvd/hxrczzvOI6hb?= =?us-ascii?Q?zMgY1jYEQvTkjOKO6r5eUfgOHYQAKg9tnovRIcJgr4BvHk6YO2ENWc39Zv+O?= =?us-ascii?Q?ACFeme5kZhMz1exy0ZC2koFGSTETh+aySfDMkxj+v/jwisONWu44LKAqEbsd?= =?us-ascii?Q?TshisHzDhvu5bIn8/nZxaX0+7hEToFDnCIBF5zW+FEJUZIEORYetndRd6YHZ?= =?us-ascii?Q?6jkkgcxv7M9tDBNgJM2nd6T4H5CJXJlOn84ExOTprRlEKcpjbtU51VAwmU0k?= =?us-ascii?Q?3UzebyFRzNVI1cPWw7VkI1Y5wABJtoM5dePiraT8c7twSM/71tSqhiHSnz9R?= =?us-ascii?Q?u+6OkRs9aO7X9DeVdCP3u25mss+Ph97BevtFheRCFhEYRyIu60zZVejEVALp?= =?us-ascii?Q?KFdlspjWuEGSdYlrnOpMWn6xsJm7hr0OfAln7PouoYtaB6PgRT1qQzbUh2rq?= =?us-ascii?Q?TAymeF8WJE8kBJKzmkez32MWtReAJe48TumVCZiIMLQuI/r54w94cJmmjGDq?= =?us-ascii?Q?0Vh2MCFFOQEPEWo8Ior3ZamUjeR/BOUpHdPLqzpEbxyZoh5uO6fhEZMav9Pk?= =?us-ascii?Q?J9W1rKzgYYrJTvHcN+YVVmeg/Xf63nabLIoFuKv8YfaijZVOhV2ldFHi0lgr?= =?us-ascii?Q?otfxshrCS5qAYYnAy7M3PjmZu052GqRvYqARV/YEpxRgialqs0Y373MDJTZk?= =?us-ascii?Q?Ob+g8xJya5Oo8MJyTdP8+xB8dgzTDOKDz3eaC7Mq/arjOkOqFxZlahrFrE5G?= =?us-ascii?Q?wkTfUwkJ0MFvURFjzRIUzqylYxsjBFoOv1gXJ+qS58BKsWv2VO+cfK79Nmhj?= =?us-ascii?Q?V9KFBSKO+V2IooiFidKWlK3esXSjQcIPcbX93NvH6NwHSlHFKTNTmoA/fyAR?= =?us-ascii?Q?uKxdA9mIh8tBlgjHSziOOosutd76oxavRuhV51F4Jqft1n40w7XSPROJiEif?= =?us-ascii?Q?WP+k2H7fQ3VFHg1NigrKC4bd+RTblikFHtuL2LnK7drkzGc8TnOBIQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7DSuFADo9/+KN2je2u87rEfQM0zFGA7rbrzXES39miDO5HYPliw+vnFLAazU?= =?us-ascii?Q?3NhwhQaRFLv3IH7+sIXsSiJdKv1y/ADGtClIGgDadyVckfBw7BdaPGehEADW?= =?us-ascii?Q?5CwdWEMoMyHd9DTZbNxDAVEdBzNCUII6t6GHY8cHZp3KY2zybjzJThZpcZLx?= =?us-ascii?Q?vylfayn39RCw0/AFb1TzR5yKT0niL4RrekDNfg7zXDY75n40eQuMnKwfqg3o?= =?us-ascii?Q?cwhrZDSm9qHq7Kc4wnM+J45N+iTdTFdoBDGC9i0YRFoSC0L3blT01A0Oy3pC?= =?us-ascii?Q?1ZWi8M+A4DMJxY7dM92kDbFNxXEzf8TK+G62m6d28u9XOEQvaaVloR/2V4KJ?= =?us-ascii?Q?A/KP8d208TrMvgnrZ89k2Q/iiDlhaHFmOWONQSXW2iTTsHT4JkRJ6C83Qs7P?= =?us-ascii?Q?Xr4STApLxJVc+tpcklWUzQhTVmWEFwoV8uDCKM6C7Nt5yQmTC31e9mKQ+ol0?= =?us-ascii?Q?SASZzA0Nz4X6qPPka4t4yhq8SjZjU3QZhHQ6gOSTSNveUZHVxP13o6GWs/sM?= =?us-ascii?Q?dimN0FOHY/WBUeaH6lL7g+uhANdrD7F8ptlXLxwflrlxqmsTnwW2eKZPujv+?= =?us-ascii?Q?Ng3Mf4tnyhlUZNZGtAsn+zNYftrhH9SA6B7iLQ2eGlBI2WaJ472MD5yHRo7S?= =?us-ascii?Q?mYHOyKWXeonOXWkFLF3bYREyGwOx2fsK0F7tZBebprhsc7W8f2GIsqYoNZQq?= =?us-ascii?Q?Do1kR7SQpRWp5K0jS0RJfgUCpLu91Z1mRQTDlyZAY7xawYr2AGGUhbe3b3Id?= =?us-ascii?Q?kIhYwgc2G8nZbNvrFE3AyYWK6CdPhj/SJ14DUuRNl1axrK3kX5RW6nXBemMF?= =?us-ascii?Q?pOv4x57zIDeTO6qpkRe5O/K4xscGhiHsEXmrwC0qbi7t1G/Jo/Kfz9ChUfmZ?= =?us-ascii?Q?xrKqHKfVaU7R5XuiaF9NMEaqQl8pVo98BCARcolvC/Xa62ZX/Y5+w7QbOeyV?= =?us-ascii?Q?GW7Zyac0/9Q8U+NNDrbBIjnOeHkIEiK+eNoK69xNuxZn0jkJ2Shynv1+wn6/?= =?us-ascii?Q?wXmmquTDEok9SAC9nIc3H+VqshaB/w1HqYI0mLffhLPav84NkkFnjmdpscgq?= =?us-ascii?Q?kIIRAa3JO0N3vJsNP89ghlfvKoy+e4D02bpDtbXK6BEqq046VcOZwckS7tzL?= =?us-ascii?Q?INCIcv2HDjUfIjd0S6rsfapBTId8M4Ha4uc11FkspYb81Eeyqgb8WZdmnVip?= =?us-ascii?Q?u7BF2r5uh3hasQOoL7ntfymeMsdxpeQzqZolHuCg2LNZJG+D5Sfh52qgRMoj?= =?us-ascii?Q?Kt5jMAp2OWNEI55plj6OjJoOcNYV5AqGJHlEcXCwTcVkXCWMcu8ESZBqIBbG?= =?us-ascii?Q?2UNbTSF0V+k9+4ouzK1HqQ1NVAqM5h8DfjTltZMtUlpQRW38Ar+GRL6+cJlX?= =?us-ascii?Q?w+WOuHyJsvcUOVRcqbp+8rNKz2fOjzu5BUm2lyOEBE+aROhoJU72ihlNF0eq?= =?us-ascii?Q?vQKjA4HS1gNUnb1T+cEIoonCAk3d+jsGKhY0VXoXQS8NAcE2HxjfPJWYSlgK?= =?us-ascii?Q?1FYQxaRL4TF+aXDk0EW1Rtm3wgx49ozGbkau4Z8TtzP4cqZLnEEYjaoqoQ+l?= =?us-ascii?Q?cs8MZ5AqBPgjtNjR7MVmsW95StQtqigSyMP8jYnkHJSvfp+30IORoPmeTm+D?= =?us-ascii?Q?WIRe3Lys0IVARj4vma9yEEw=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: fe189351-b577-46b7-2cfe-08dddfe5c59c X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:31.4118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kUBQboYSfOBRQyMj4pKE5okzenHXXN5lH+8SlCjtPcUTo0KGeva2qM1HTr0kTF+hg4SarvnTt+SfgQGcFQNLtSdsFWd99W+isJE8lZx3OpI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 Content-Type: text/plain; charset="utf-8" Airoha snfi spi controller supports acceleration of DUAL/QUAD operations, but does not supports DUAL_IO/QUAD_IO operations. Luckily DUAL/QUAD operations do the same as DUAL_IO/QUAD_IO ones, so we can issue corresponding DUAL/QUAD operation instead of DUAL_IO/QUAD_IO one. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 7e1381c8f44b..cbdfb9051dfd 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -147,6 +147,8 @@ #define SPI_NFI_CUS_SEC_SIZE_EN BIT(16) =20 #define REG_SPI_NFI_RD_CTL2 0x0510 +#define SPI_NFI_DATA_READ_CMD GENMASK(7, 0) + #define REG_SPI_NFI_RD_CTL3 0x0514 =20 #define REG_SPI_NFI_PG_CTL1 0x0524 @@ -179,7 +181,9 @@ #define SPI_NAND_OP_READ_FROM_CACHE_SINGLE 0x03 #define SPI_NAND_OP_READ_FROM_CACHE_SINGLE_FAST 0x0b #define SPI_NAND_OP_READ_FROM_CACHE_DUAL 0x3b +#define SPI_NAND_OP_READ_FROM_CACHE_DUALIO 0xbb #define SPI_NAND_OP_READ_FROM_CACHE_QUAD 0x6b +#define SPI_NAND_OP_READ_FROM_CACHE_QUADIO 0xeb #define SPI_NAND_OP_WRITE_ENABLE 0x06 #define SPI_NAND_OP_WRITE_DISABLE 0x04 #define SPI_NAND_OP_PROGRAM_LOAD_SINGLE 0x02 @@ -662,26 +666,38 @@ static int airoha_snand_dirmap_create(struct spi_mem_= dirmap_desc *desc) static ssize_t airoha_snand_dirmap_read(struct spi_mem_dirmap_desc *desc, u64 offs, size_t len, void *buf) { - struct spi_mem_op *op =3D &desc->info.op_tmpl; struct spi_device *spi =3D desc->mem->spi; struct airoha_snand_ctrl *as_ctrl; u8 *txrx_buf =3D spi_get_ctldata(spi); dma_addr_t dma_addr; - u32 val, rd_mode; + u32 val, rd_mode, opcode; int err; =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 - switch (op->cmd.opcode) { + /* + * DUALIO and QUADIO opcodes are not supported by the spi controller, + * replace them with supported opcodes. + */ + opcode =3D desc->info.op_tmpl.cmd.opcode; + switch (opcode) { + case SPI_NAND_OP_READ_FROM_CACHE_SINGLE: + case SPI_NAND_OP_READ_FROM_CACHE_SINGLE_FAST: + rd_mode =3D 0; + break; case SPI_NAND_OP_READ_FROM_CACHE_DUAL: + case SPI_NAND_OP_READ_FROM_CACHE_DUALIO: + opcode =3D SPI_NAND_OP_READ_FROM_CACHE_DUAL; rd_mode =3D 1; break; case SPI_NAND_OP_READ_FROM_CACHE_QUAD: + case SPI_NAND_OP_READ_FROM_CACHE_QUADIO: + opcode =3D SPI_NAND_OP_READ_FROM_CACHE_QUAD; rd_mode =3D 2; break; default: - rd_mode =3D 0; - break; + /* unknown opcode */ + return -EOPNOTSUPP; } =20 err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_DMA); @@ -715,7 +731,7 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, =20 /* set read command */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_RD_CTL2, - op->cmd.opcode); + FIELD_PREP(SPI_NFI_DATA_READ_CMD, opcode)); if (err) goto error_dma_unmap; =20 --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020095.outbound.protection.outlook.com [52.101.84.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29C3331DD80; Wed, 20 Aug 2025 12:33:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.95 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693220; cv=fail; b=PEvsiYmIW2LvHH5mA+SPlPk6zh80E9K/O0hLi9uMv4++pTxPgrhKGooY6pUqaRrFxFtnYrt03vDFc5vZcBlYp3X5yyONnN32jrj/7OcveDd1qfJ0Ih7CGOANNx2kr1keuxz/iv9DeuXWE050O++U4CyvaOi4gMV3ddldYntSRI0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693220; c=relaxed/simple; bh=i04+eb8g9SXFr2bTa/+xpfU3fsY7aa+dN9+ztVa3nAs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Tyismydjt2VU97mCdpvE9vgozkOE11gLO5S6uI4L0h22uVg5ln0VtcOI+IDsUDlmR9FUrOMA492NGs7+8THepcIve2Zpz0Uhhj1B+UZxdGOMZmpXpw6U6s0+WfYBz8gIr5U6R/j0oOrxh4+eVTniq4ytOADlf+9MrjLU5uKqU2E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=2ovOcJwf; arc=fail smtp.client-ip=52.101.84.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="2ovOcJwf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vPItSfF6F1ovOh/y00G0J6ozoADGYiNjwO1i85SUCJlkdtLXWdWVyWCvUuO6O2t5EQsLAqRlo0rmGCi3Y8ZZz9sTcnFUkiNrxOh9WgNneyrfQ/0Ti8i8X/VZkXXksrpBQBfxvnOG8tdNsWd7p5vcVWLp+ItFwGdgdmuhgEFvf2yF6yKFbpPzXko658e3JWXQ2yITO13FUXaYYzvOqpNSG3T+qE7FdCO/CfTPMbM/MlRN0tberk35k6F1q7xspFes+ObwSrCCXmf1KG5P3eLW+woZuwqjJIQEDI1isJe6dU/kPiVt61Xbas06KDOSpHAlW9ekbwGBBATyaqTxqeqwTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yQOWKxyFALTFR9dLPY04Nk+oS1W5+W5LD63TH6xOvA0=; b=muVwA1qyxyEcP9u7Vr9Wd6qi6dWrxFI3zaRGMw79wVHDZcFPhAPIScO4k9tYKt2VS3GbiBrsYPfFt5mbItYltxg46z/B3J3QmwQ+fRKJjM2Kb1xa6ooBM6exZgypWZqP/zSWauKJT1K+2I07WCJ/Q6uWUTsGuPLRWkyNFMCZ+cKqdRkq/8r1GXyDQe1azR1BZ6WA7t250Le68urXgDQzmYUx8jKZWDmIC/kzA5r2J8pa9HFYymx/+KIpn5g3qEF19VpAge8BpF+sGvg7d7sPbS2ZuwTzPBcy3aY3FDI5JTMJ8jWC0mi3d+ehciklsZxL5vUnpcmfZA8CIugQbxMVIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yQOWKxyFALTFR9dLPY04Nk+oS1W5+W5LD63TH6xOvA0=; b=2ovOcJwfTxcNH6mtmoaj0FVYJxaOU6OhqbMYLZJe6nN4RxCQYoqTGcVvEsyuH+3uVHuPoFbaP3oPjUfb942TmFEOKCw0uVPU/Z2PcDLJ9tSS1H3d0SwXTkgCN9fssadq7kuyUTuKNCheup2Np3+0XKugFJ8cTjpUp0AdyuDTl5jKWCyotb/qU72N8WkcKniORhFlWntD75YKIc2XeN7kpWKhWqg+Lzh8feGlUwVLOELIP2CiReGzw6lvVJwKQexBjUzNny8Wx57d/tPFnRJNmp2jNEA3/nfWTPE1yvhaMcttlE10TN5X5B5Az9dY/q9ZYYOqkcRftWMSK2H6b7gIWw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:32 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:32 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 09/14] spi: airoha: allow reading/writing of oob area Date: Wed, 20 Aug 2025 15:33:12 +0300 Message-ID: <20250820123317.728148-10-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|DU0PR08MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: 05f1758c-be3c-4ef3-1f11-08dddfe5c624 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lXsVfBq0wkE+EkNnAuTYqmTYFCpq3U/iln1SbxRTqTkZTZVq+ehPCBMuyWhJ?= =?us-ascii?Q?tV9fESEQdEruuq9eE2l3JKDhiGKJtq0wdWt7GBInVOtPE3UQhndpyBKo+4Do?= =?us-ascii?Q?qjskIQC+hJXu9qND9eAmHmxUIf0Bq5izxxSW4MO7lABxJ+cHtQ5RBa9B8mFL?= =?us-ascii?Q?gHSKsDmhiOawV58r3SQmvjZx0rkOvYbwGuYPPDCY9Hmef4esmJjFV5SJmdzl?= =?us-ascii?Q?0fJ+vJRBspt4ijuFLgnmKrvAVsQQB/qM8sGJOASQeHzB7/UEMF9JJE2QDyQd?= =?us-ascii?Q?ENcJbyDM30ySjCb6cvLRfNAvrNcE8+oZxFRgkQ6ikMxM6qLqrPoxLYmRqC64?= =?us-ascii?Q?LcU8tFl/WPPWj103KRwUuhvTsKshMLGUKncPVCGcBOtgm+akaBcDMvslBX6z?= =?us-ascii?Q?36IKom30/HiC6gG3ciruWURdA6aZvPm4Qgq97QSsxtv/tYRc2AZuH2O0e0D7?= =?us-ascii?Q?iF3jjtESFxKGf3c968P51mdNBrRo0nPLg3rVoCbIENx78MynaX/XDjYn0SGB?= =?us-ascii?Q?sI9IxJkk7NSlHyouwGIn7nCQhsGEWbRXbObr1zwN8IW884IrrCVPXD9UFQAi?= =?us-ascii?Q?yKCXkrho8xHSaurDwqa4ZcKdG4WI0brQmEqYcLmweC0vGIkUyEsbaC9mlUR1?= =?us-ascii?Q?9uBp1Kl4ZqyByuknaMB8OSRKjfEeG6Ok1CIa0W2MFUigrSJn0tPbbRizBGd/?= =?us-ascii?Q?F4NkmC3jJF/36FwhzpS8d4E9QETudvjBmznGsHECUyGaZVIL6EUlrB/RVOHT?= =?us-ascii?Q?Yp8qtjZahbEOpt4VCh/A/TjZqBAkZJPMGvVX/9ADlCSynawlf+yit7f89bqg?= =?us-ascii?Q?q6h02WI6QywLcYGniEnD+BEzfM5bm17P9+x4Kn3K3IK+BLmGSIol1SgkgBE8?= =?us-ascii?Q?g3HrTHulcZpz13lxSmWpr8do1CRUt1gfc275TyD81pP/dgdu2xblng/wKI2A?= =?us-ascii?Q?4dYIagY2EAUf1jiS2HqMX9GDrrpCBXmKmvimiBLjw2kcwwdAL9mLU6tXywYQ?= =?us-ascii?Q?VrKYiA5a2ZF4ILi5ZDgTk3D1yAZkloKd8K0k/2IAUxabcWN2835c5wVqz8hH?= =?us-ascii?Q?gO+2XP7swtXsUEtCsAbBsJ0YleHFA/ud3/vN/UM2Pb4sjYcgPEIV+RsFsbQg?= =?us-ascii?Q?ssje+YkmILOjdYDWJDPkOO31DhuEM9eCwo4rZPASlfitGBuGnlutLrPYV5Mt?= =?us-ascii?Q?wQq4NKC7Z3UINdTXmQ6uyOVLVQK0LvrpShbkDb2rQugFlH8LFRxbQt66dsu0?= =?us-ascii?Q?hX/kyTm3GY/ZAgnihTDcVZsWAoJWBRB6QvsYe+tswqyBQA+GHJDMUucOYLdA?= =?us-ascii?Q?0IyYyaQhTHR2jCRxXmnPRUss8gpiyALf/zYfMZJwiiGvlluSzCFYDlrHg+Nq?= =?us-ascii?Q?eE7PH8VJQoDpIE1A+ciEueD5sX/VT5WneUOMNrDp8F7mn/B8S0sO+bZyCbeP?= =?us-ascii?Q?Q1qjcAlesQl/kow6jyeYTqf7WEm58NiuzFHOmji3BC3zoI2F2RsnnA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZBunKhoWui5G7ujXvDX0oqJPsfJC+UzViF+cr6FyYjurfOYeMuHRvIe0JTPx?= =?us-ascii?Q?UIme4jFt6O3b+EP1vxrS+iq1durSe2l5PLT2LobLgAEWJcrI1wi0mujb6etT?= =?us-ascii?Q?d7FqH6ACVGbUcyObdgAMSkIZk7muxeJyeiiOSUn5fOjg8/0FN/95DEl/oPTG?= =?us-ascii?Q?ZoMP+QWSe8cTProlX9JvAXdJR3EzEZR/5E9r3itFZzTg4kuY66qKxZ9d22gd?= =?us-ascii?Q?Oe84/ccAVaxLWG3nIJQnMUB2s5/5FyHkSdk5grZivnDuyc7DlqX9/jaKIYuY?= =?us-ascii?Q?nIOomhgWYME63AbDq65U7UZtVwYxNiroV4ZbGpOTsiYnOAt2VMsFjpKviTjZ?= =?us-ascii?Q?NeEmOp9FTTmPJS6zXj3ZYQyrOYHJU+vpmBYyhHj8WP663LzpwmbNnLZ037xu?= =?us-ascii?Q?SPwrpxnnqGyUL75h6Nk8yC1AiAi6ev3DTyexQ2aceeLTGqeOblHj4AWgF9gj?= =?us-ascii?Q?J82qqWe0eFdIzJb1nWMxnnLRA+fwYepWp2oqIZMfwq8/B9ohS85GUJwId5uP?= =?us-ascii?Q?aIf9oBqfutc9EHKlC006989oFx5U4iexavouUQRgQDCLimgqKP0tkdMt1Tio?= =?us-ascii?Q?otQG5tfPyIK6NTgwlvwLYDTj7soEB0Pt6nSyfUGO68QNE0mShTARNwbLhQfS?= =?us-ascii?Q?oPthvBXqR6krIvTmAw189zU/tCSF8jR7Z/wK0NJ7qO/n5oF0Ag92oIAPQtEs?= =?us-ascii?Q?m984RwyNfVNJSgyn7jwd5EaGMBuhXzf3trpZs9lVD780KN90KCuRG2IGvnjF?= =?us-ascii?Q?bSSVMBFItR2P9g8ov77JlPeRfczCS6wt0vw5Vidvtl+zotKuUlkZ9qXkQLG1?= =?us-ascii?Q?oGU1LzxTEnaqeuPlUDbRrLc6vWPRduCvIrf0c6D5JDGPRH2LLB7qknRZbtjs?= =?us-ascii?Q?/pwP0vy3xNi0bBiV2UDnyVmxq4qHApHCQ4pugRDjY5F5m4gi8vWz1VQ49a0Q?= =?us-ascii?Q?39ffeUN/DU1bdzk0ydwjoZu77OAnaS675zHG9yX23WwVbz1lLLANBRex211+?= =?us-ascii?Q?G30c4OzDHhDQC0AcFxX+dXU1Zbq1qhhNOegEQXxlwsdfe0w80VtAM/cpK0wW?= =?us-ascii?Q?bBCwqy4FPMtby+44PTXc7Qh79hI+Lyd0LMgYSPy3txt9l0iSy7kWA2k5esfs?= =?us-ascii?Q?sUqDhsF5aqHnUYv3xIvD1XFPA3ufoDNswGOIkVCURIdX23TP0tMQ+yA9qu99?= =?us-ascii?Q?JX64dE1fEI/g2PcJoV8L1EGzx3lSLXKlcEKrzQlkwIcoSHWd+06V/evCas6e?= =?us-ascii?Q?CDZ1NgrEkg4M0bZo1q7N409o0wc5FU3TZRmKDm27K7UUwe9jQ5Ifb9T0cqeX?= =?us-ascii?Q?qDPb6a3wQUy5GfwK8ppcRiVLZZEJLV/r/RDi2dD2HLhBDQgq0X/pIV3ikdQg?= =?us-ascii?Q?2+ELFxGUDQDpA+bTHQ2r5Y6pKmms/bJI3QSstMDSmZSKFi6T+RmAhmmHyrIA?= =?us-ascii?Q?XwV7HAu/TfSJJsg8M/LVkekGikgvQNPdWSyG7G+aTM5CU/3cMs64KHXWZe8X?= =?us-ascii?Q?tl4fr5NigEtDxrYt4hZZszbWOCD2THRm7U6s7zxBa/A2zr2QhSCtbd8QzMey?= =?us-ascii?Q?JhfaKkE196OVCJa0vU8CRR+54RxTzUMqA0EmPQpRqdPBoVr1xcjdsZwiD4Yq?= =?us-ascii?Q?Xuiw6S0GmdY3AUIq8o0AZ1M=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 05f1758c-be3c-4ef3-1f11-08dddfe5c624 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:32.2914 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pdbx3WaVX3BqP2Kvy228Lw+63ZSX0/ewdLJGDliTLC6sDF+NVx11If4aaBhMSuXm5D10fpLM3XfkuCguEdEewzQzNjZyQvobKR9kdIi4e9g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 Content-Type: text/plain; charset="utf-8" Current code does not support reading/writing of oob area. Thus raw reading/writing and bad block support is broken. This patch fix custom sector size, so oob area will be included to reading/writing operations. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index cbdfb9051dfd..c3348ef4fc08 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -568,7 +568,9 @@ static int airoha_snand_nfi_config(struct airoha_snand_= ctrl *as_ctrl) return err; =20 /* set cust sec size */ - val =3D FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, as_ctrl->nfi_cfg.sec_size); + val =3D FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, + as_ctrl->nfi_cfg.sec_size + + as_ctrl->nfi_cfg.spare_size); return regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, SPI_NFI_CUS_SEC_SIZE, val); @@ -720,8 +722,9 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - /* set cust sec size */ - val =3D as_ctrl->nfi_cfg.sec_size * as_ctrl->nfi_cfg.sec_num; + /* number of bytes to read via dma (whole flash page + oob) */ + val =3D (as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size) * + as_ctrl->nfi_cfg.sec_num; val =3D FIELD_PREP(SPI_NFI_READ_DATA_BYTE_NUM, val); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL2, @@ -867,8 +870,10 @@ static ssize_t airoha_snand_dirmap_write(struct spi_me= m_dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - val =3D FIELD_PREP(SPI_NFI_PROG_LOAD_BYTE_NUM, - as_ctrl->nfi_cfg.sec_size * as_ctrl->nfi_cfg.sec_num); + /* number of bytes to write via dma (whole flash page + oob) */ + val =3D (as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size) * + as_ctrl->nfi_cfg.sec_num; + val =3D FIELD_PREP(SPI_NFI_PROG_LOAD_BYTE_NUM, val); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL2, SPI_NFI_PROG_LOAD_BYTE_NUM, val); --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021135.outbound.protection.outlook.com [52.101.70.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30A8A31E10A; Wed, 20 Aug 2025 12:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.135 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693223; cv=fail; b=Td52MfD0jZqHTrLY/rtVvp4kL/S20d3mFS7oVINST92RxwhdWY4jY+Xu5G8xKIUoTlETUN0uTt4QeSLJVDVmklxyA3F/FULdY93sUoUtQDi05o1kGzYWBNbBlIL77H7n2uDfk/lie/wmVA8/Lflb8pzOJmi7cRpIAxIvoRLE4gA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693223; c=relaxed/simple; bh=y7UPrBO4XnnIa8IYyLSwLNIqtz7XJoM+1OR6Vk1zKzA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=GFtALg5bmk9GoUPwm/cpnMxTRlHJ5pal02JL8u362dAqoB3GaNEezsQ1BD13Sd0kRmtZnWZ3lQGa+UCHWwnlZSNYnaM5c94LEzDOazBy3zepC4wgwDw5oGH0ce34PvDxodnHDvpCYE1GMXWqeZQijZFLFQAz6PzJZSfuqlPAVzE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=KpKtPDf0; arc=fail smtp.client-ip=52.101.70.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="KpKtPDf0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=td25lOXFVim6PCE5Txk+N4jh4A7lIbj36Eds2pfX+Fsa0AjGITV3ZNzFMmHSTj5uHEEzSyc16qYVt3Z9Wd5ci6BTeM9zj/zdyMKuEOMvagXscqpo5BsB4ttNNlDVP1jDK2OyqsxMmUQ/49h5QnVMESVGYc6OGmTO/7HCZwklral3agK8HwX37edkEDIwdBq2Rfqt9RwG6z4e/27c3CqgVNHSSDUv7x3UIMuE2AyNYDcUweqJYxJhVLgBy0m7ks8xtfZi0gUZjaH4VeQFLqb37i8vapCH9DLIY830B7tne7xgjDEnDb1NFOb+PqLw/fECt2FwanAfU+NC9IXf4BWf2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T/LxhQuVL3Cl1NRvv4uAxK1hzZqlvNRLbG3I1eHfwbQ=; b=pldd4EX9JPozqOG7WihllhSkAzStKMuzscFvPGiyg8TK1bXoK8MwOJe/9ZjFN8f2zCZOuUyvCD313V+LeSd7Bfs7PPAwOpJcXMT20Hui8RalCA6H37PEGyuCcMLIGpyeB2ov+IbIIGdMYLg46Y1iI6dhSk17AH7rV3zQnz4rg1NdIp697+bNbNVUUFkIw9wiFhnaLF4V9MudgdX0iGe8Od7Dy7PaR2euFWj1bB9fAMQCqwB61c8hVvEcNikA7c5ziX++S6Os/nl8cHB2xumVQHwnGN7aWfMf0YKN+Lx9C00BEKA8tM7MVPs5i2A56vXXKeWZ08D6kv6w1Dzu4Y2J7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T/LxhQuVL3Cl1NRvv4uAxK1hzZqlvNRLbG3I1eHfwbQ=; b=KpKtPDf0EnN2+5cI+CcL3YboDEuxocLAq+tapINhp1Mgoq/TxmNrsATT9gh5GOB16QJ9G8u0Vtk1M7ELLyFHF1LhDMNNG6ZvwoV/T+MnaCJQiqmjn/hDFPpSKYxmxS46Aze63Fx+dy7d6eJB08DSpeOvp6fxH4R8R/SYFa4t4dbpac5T+guKP15mK5foTeam0D4bBclLLLIdgmnrN21J1D/MzopACdsCCPm8LjglFcOrpYdGF3HsoFCiLzdUWdpA+GwxYx/qVWQGxAv5FjEWNpVvG7mJIuR7t8vzg07mWyMeATGQ0dGmd5l5wIPkfDrNL3R+Qsq65HC6DL0DIDR2iA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:33 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:33 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 10/14] spi: airoha: buffer must be 0xff-ed before writing Date: Wed, 20 Aug 2025 15:33:13 +0300 Message-ID: <20250820123317.728148-11-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|DU0PR08MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b25e5f2-8386-4850-d3e6-08dddfe5c6ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KuMdLMLXEiBZG7/gh/nb3HB+Wt3NatYYCldt96viTgJn7uo3BstJDw00+E1D?= =?us-ascii?Q?ZUkTucJns1NV1TKLsA+0S5SPmATctS82L2knvosBeDhlcLfsvCCFw/zl59pc?= =?us-ascii?Q?JXCb1INB8XvxLOMLHeAmw698SmabW5BWRAmBG7z/cakGRp1iuMa3wtb5pPp+?= =?us-ascii?Q?9gS0HyMlktIAIId5Eobdjz4uha9wCyYtrRoX0wm9s2VPZHHPUvhXD5NIIt8n?= =?us-ascii?Q?seJsO6BOLcLfaNaW/Mi/GnhTOAhB+e6BBA5AqjVX7kIpLIH1ori3EZ4ItT1S?= =?us-ascii?Q?zRCPL7FrofLhMdF4ioa5XSjQvABCvDECMtxdZ7YGJU1Do9SspJuCiKNO5mHG?= =?us-ascii?Q?ls1zExFdhXAYN0wCMuDhKK8DAYiAWxJYc4YCU/bv9m51PrkdCW2baaH5LDGg?= =?us-ascii?Q?W7lW5i2GSzsvYcA60Txx7eZgNazpSPqZBW0L3i33JQbc5/OiQhTTI2iplUDa?= =?us-ascii?Q?6+nqWBKwGOP0wEE/91z/wf5nLUV5G3ja/IBiTgVBAmWMsanzpXC7L4bzSMRi?= =?us-ascii?Q?7x9uVseshOV1yQ01mxL4/fuXEehZxqJt+htA++5PpTWGWXfX+1d6tYcMuMLx?= =?us-ascii?Q?I9NHunipylFUZiH6A29jM4iDh3TInqisJFWeky8gv/nPXqMYOzIPQCIk+8yg?= =?us-ascii?Q?uEPonKwgPD/mlY3m8FFVUzjxZyPKQ77Y0bBicFsI8XGTDOERKmcNyzSTc+bB?= =?us-ascii?Q?38leZngWHN+/hNrvFMcOqIPd0tzgvFYqh1l9m78HwR90+jbcCJhL8EcJMuoW?= =?us-ascii?Q?CZIA73G8aR6IaRbmuWSJd5paIRtsN75ya0r3gTEoJwMEpXphCJp/CSjePggB?= =?us-ascii?Q?u0PuOhu89Q22KZypZ/1gHTq/0EAw5lVNRYcEbD17HiAUgfnpOPjNsuQTzPSk?= =?us-ascii?Q?UGIOI06pVCt7agKNVLoOtG5x3m88oAVqB9sZccSE2XL42csBcfNXw7+btK+g?= =?us-ascii?Q?u5y9xq6Ab7XwlC7QWUizBgcyynU39ION8Qd0MBk1BVube8PPpZmP8Re7njEL?= =?us-ascii?Q?1Ye1XBbpJ8IMyqPFcAQM03TPzk/q5bi6sFSBsY10TNsMDTHx2NQQkpFgVHGu?= =?us-ascii?Q?t7ZWowjmuBjXFYacUd6+hzzCFkd7XwTVVRLzyPI04hx3+hJo4GHqx7HcopJc?= =?us-ascii?Q?5SpoyT47znWUaHijq3Vn7FoXE0eFI3e8D/gGo8R2oOQe+mM26DUgnTjA+3dt?= =?us-ascii?Q?vRJfb2DTKBPBfEeLkYkkPv94DGGn5xBiWuEpsjuYmpdFFDxyNB7Nh03oE/7L?= =?us-ascii?Q?2+lPepdR81NSRtvXzjtcJLUUZ+liWZMxTSy7PA9UuzgtdsOgailFj+ERaprA?= =?us-ascii?Q?vSEIJoPgK5PtoM9JO/l4vc1kZHLVGYAlPVj4kXmZGVbTAuNxIFM9Q/9KocyE?= =?us-ascii?Q?A0raMybptRzuuvr5t7rUI0TJTNY8ajDv3QRGtXGS/JVcRGizAnZZ9o79FJYs?= =?us-ascii?Q?0ZPXaaI1RMo33nLeW48sGEyY7yPJ9LCQLuwDZUxphY2RWmP2nJzE7w=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7fk43SLQ55YqnszF9kGer0xDpoZYsiLQ96MjpsUOlzQ53JA1VCwDQ5udzhSz?= =?us-ascii?Q?/RLU/yVnR9lIkasxlNRGYEgbGh34L8WyeR0Nk1+yLSTZ//MNM1IwT6gqv5dt?= =?us-ascii?Q?lICTS6hWLfWtlnJyIbTXtDSxJXZsiNVzlhqDxFUl2zo8pmcg5ar4hU3PELiw?= =?us-ascii?Q?ksRV+QeXlMeV/lwItjW3vqE7KD0DsKSGd0bwZWuf0p0g8y7vxSZbkg+csIw9?= =?us-ascii?Q?r5xkF4kRi/Nn2X0UlB+sXQdPvJkrg1lkt6GZYSYWYOHVNeK3MwFZlYgR8tdw?= =?us-ascii?Q?j6YyhbJS4u3VRjDoUYIl+EaDw31hjixHuJ+oEC4w5fRqs3+jIUCe3qL9TRvY?= =?us-ascii?Q?G3/QIiwLQSg/2h4hE8CYj5RcgB9v1/J9NjCKLW7W1b8WNc8eAOYbHdJj+8/A?= =?us-ascii?Q?Zvv1L+42fVqqoIT4nsh7ZBp63Q+3gtQmu2xi+QvuUMkYG4ZX3/7iubmbc13l?= =?us-ascii?Q?BcEKlivJTS+K5dpv6npEXRYdDDizoRUzgsVk+yTOPOdTBFG/aIkENSGZe/7j?= =?us-ascii?Q?OdLhqduoaeNFJdbS0xr/3qzX4uL9KsOWOrEurar1mEUlKn3oaSBa2hlxKrat?= =?us-ascii?Q?5AUMKZX9SQf3+pHMdVtXtBDkHUDIWAYh4aFPOlrxrJTKmSVZpuUHcszCcr6B?= =?us-ascii?Q?wBN3pURGSQhcHgkMvvb3C5DmOwgfwfLoO7UGSUaTXIItv7oOORsXbrPbNf6J?= =?us-ascii?Q?oDBsftPF1qlS7yi4LeQDvJbwhiJ4LT3mC5YOp7FXa4K2k9w5U8PqZQwbo+zi?= =?us-ascii?Q?DcxNWyLgGRCqLaCJJk5txdwXbvG0WMTzuchqQYf29pjkyHjJxy2iJi3so7SU?= =?us-ascii?Q?7wUpOmTGUHLqrOHEJznoTmyfnAX0lrIFKHGgTjjyxLJFSbLrEdeVzj4siPBy?= =?us-ascii?Q?MZgXJX9rKeapm9Yz6SPzn03s6R2/CMiUDwzsK8F6YGn+zSp1a3bgLcCVib7n?= =?us-ascii?Q?epTptJXuq0ZngdvGErzJs/bgffzLWr0tGquOF8aa3AFHjoicVUZMBRB5q2CL?= =?us-ascii?Q?e/75FgRerQdAkqpXsTUAy1IjZuijed2eN7Dh+O0ix0FrTOZWlaUwhXSfZuZ+?= =?us-ascii?Q?PPda0OtzQS4dX9k4xbn0TiTgGXm0iRLuGZ2zm5HK36u1XgWejc3VcWBGyL4X?= =?us-ascii?Q?PV2SfZQnerfoiJsIIMJ9hSLFwVSq60EcsrOJzDe3fH3OThLCiR0q3ArCnvUb?= =?us-ascii?Q?TzlcQBRDnu27nc+B45CGmK18jdtcknEUJPYR/5GliMD3hc0Z89udbQ3yX03U?= =?us-ascii?Q?BGJKj59y+Nl4jCEuY+pdPueYKwyupz/SEeMBbY17EKwfvNnP8R6pV+Gfc8yP?= =?us-ascii?Q?KhL1OzOP4w21jNOeFn8MXnTNnqp+2EE8dhlqxeCPeVm8O1TbxWbjKmsmkJUj?= =?us-ascii?Q?yvCH3/O9e6PZm0crOUggV4mT7cT1Ow6oBxxFjjA8yoFh026CdLXk6XbTNmIt?= =?us-ascii?Q?B5obLlKoVqN2N4krLWkhqC36+YrdZcEoJsC6e9tc1nJktb18hgsU2IypAwAJ?= =?us-ascii?Q?s8UOggL8LJgeqUWw3kNy3FW3rUQQ8kb9V3BvoQwoMmtUD33WaM4pk1jXj3sB?= =?us-ascii?Q?5yU62WQHKdKJybHSlRi2+PlHN71cOnVlOMYr28KD9ggMV425v67OQIIWvi2r?= =?us-ascii?Q?5SdrSk8eRNgcpoPHOay2nj4=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 7b25e5f2-8386-4850-d3e6-08dddfe5c6ae X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:33.2222 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W7XCnsFnBU99y/pc16A7dog6gEEYgc2J3bw4dFb8UewnryUZXeoOuHNiTUNv1a4ro0BuUljiIWkAU5+h7Q0fNHd5O6QdbCdaM0n2sqBKIM8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 Content-Type: text/plain; charset="utf-8" During writing, the entire flash page (including OOB) will be updated with the values from the temporary buffer, so we need to fill the untouched areas of the buffer with 0xff value to prevent accidental data overwriting. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index c3348ef4fc08..57eee658fb30 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -848,6 +848,9 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, return -EOPNOTSUPP; } =20 + memset(txrx_buf, 0xff, + (as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size) * + as_ctrl->nfi_cfg.sec_num); memcpy(txrx_buf + offs, buf, len); =20 err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_DMA); --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020095.outbound.protection.outlook.com [52.101.84.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E37431DDB6; Wed, 20 Aug 2025 12:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.95 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693222; cv=fail; b=FKd8GIIDC5RhJfd7ScvOjmJSbmBFpphZShzhH4MZkppF2DhVOGz3g5bH+32xo/EGclgZAoNR1zXiwjY3hiR1G7NJS+2p0niBHGwK8w5qWi2FDjG8ERsvsjiPpjlLqTwGeyUoQU/4wtSH8wQ+1tUsEMHDFFlIPVQeACiFg6NAaTA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693222; c=relaxed/simple; bh=FVGm3mceCUZpN95wDP33kES4s9AZm6PF715GAhavuck=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=IElJryaGvMcjYLvro7/Cnc/sJLsHDiRX6t5g9vwFGIwGPtq2DhG6ivA5RgI1Tmw9bW4KIa/yLNMUHaN5gV1TSPQsOvtrPuytJB3v9+AFkXoF8aosZarJuTJusVcNRv25bhonEwvan6Ew1S3Iz2LQ1R4U8r15NS0/4J/9jmFBF9o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=FErfkhWG; arc=fail smtp.client-ip=52.101.84.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="FErfkhWG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iq7O2AORIJ2fQ/cOJNMHZUGoxjLiVWLXvQwwECzaxi/sWUElnBJDXrapPr9aeSPw5+X78sZbaG9WNpx5GYSwjmvDf7mGRZwsVTcm8o0gr33VjEt2t9ooiif9wsQPM4XpJ6x7zFHJc5qcw5rLPVt2Zf8X7HFY+a7nmKsv/DP5aZwgbot/miU5WzvsJA9H5rRe/EKjJBkCV+BJY3d/q9rP+KZhmmukFJET1gDD2wP5rE8a+aTYVVKtBxd+v9GpjYocoAZ45y/Wgkl2tdRhDLBoOTtrPPIPrF8YB5oPYTakl2p/4qoMHv4DO4QQ1tum8O4Ev2BxIW3ZMV4qW/f8AGk2iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=552BNgYXSE2V56qFiRoQA15bstDMAp+x+kpR0uvOljE=; b=tAeQmvDpbsg13D0Vc4g5aR++ngUtYUMIgkrVTUN47NdANCY0J0GjJZE4vUADLbKZPfF0e4YMayL3v2VA/KpwFWPEBdsipvyMwgr1RSJa+ycDGnIpOnzrSOftndkQkE6hSSw8ZRyAmInwaKT05YWvFmzH/ZX9ffrBkM3OZSzBUnAgzwY9JetC+Q+kVOvd24djCUB1pELDk1GCYuFqTZ39AeT4oJbdpoYICJUyz6xv2+BRZ1r1RVcTz/wxb/02YpFqVTwZOQ/6kC+kZVropCixDee1kZ7KKdVv7y+uCaTBoLp+9AuaEgDe2WFfwlR4Dm10h49hRE+OtuefQ3/ow0PB6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=552BNgYXSE2V56qFiRoQA15bstDMAp+x+kpR0uvOljE=; b=FErfkhWGsiZAIMeK+OypsCQrQdbffnEmcmZEAyi+uorfhnkq5NIUVmU53+BwiUOgW0G6R4hKFqC3Rm7CM1g9tXMh+DgJ1vR3Guux2PoQBaNau/xC6npf5mYj9eXQkj9bfZBiXh3sbV1ezdPOT8/bXL1Yydn6d7d1uEcWdJSYmbniWMSskVdYwDdPZXuJVZX2cX0Rz109u4qLBYYDUeNKHavF2DO0f8jmyCx6QAEI7fao00GR3+1v8SULpmzeAKetoOkgUxJEtfYjm72ziHx1+KqKR/WFD4+vocYa+QfwAxbP7n7roYcj8Lfkk+X+pIuVDRIkEOVzJn5tO00uQehr+g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:34 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:34 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 11/14] spi: airoha: avoid setting of page/oob sizes in REG_SPI_NFI_PAGEFMT Date: Wed, 20 Aug 2025 15:33:14 +0300 Message-ID: <20250820123317.728148-12-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|DU0PR08MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: baf069c8-8f01-42eb-9915-08dddfe5c73f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?vMzce9oPx41U3ozJRfyfSZmPTCmjsmSGDO8AMAXQKFgsb1mNQHLVGzi+2E85?= =?us-ascii?Q?EfvhpmMbzHavkWBH+mvoZ2SaNFDXUK8AM1FcU3WI1yY9ic9xpFk9OPmv2GeO?= =?us-ascii?Q?ttB7LM+2u7yMYPm7Ud4BR3zzquGiNkC/YfDN3j5X/YNr8/XtAuQJqWY8DE93?= =?us-ascii?Q?6lYBiYxXZxV1W6OiToxW7wTvVuWGgqJSPLALkoMx1zFTNqlnzWxBEF3TWa/2?= =?us-ascii?Q?A9gZccL8rtcgmdz3tWbu1NdgJLoQwxgAW9X2ONajWt31seVMq1T9B8EqyVSz?= =?us-ascii?Q?0fUZynz9aZOpusN78HrPwfcvmmRDJU8wmxNpeV2Kmei155z/WDXXGBFA2/W/?= =?us-ascii?Q?UPvOVguZda9lzZeaVODYRT2AJCml5Lh8woC5YgAS7aEfdkpoEYse6SuKc+Pb?= =?us-ascii?Q?WB9NHbR0zCpP+NXK6svPL/cM9K+no+Nfv6L661O+smQjx1kzbYWLcJyB49aj?= =?us-ascii?Q?lRqvDWy2ixUUpZqfnTwB8T5yAza3eAnJ9b6+PF76WV6Iy+NR9lD7phI2kif3?= =?us-ascii?Q?ghcRuiU00ZOYOUgp/KrwsvQmIkQA9g7Oh27LfOmt6ccjUEcKWP2wNhGp9RHD?= =?us-ascii?Q?Bu+QZceq4peURpWrIIC1wNOTn05y14H7RRn7icq+bmg4fOlBkO5iBnpcsOsp?= =?us-ascii?Q?/u2EzoR7Vyw1piTgd9SlTmXp7A2p3/uAQu0neIVYWn7saXJjnG/HHov7T9Dj?= =?us-ascii?Q?PEJGijTH3SC99d5Dr9nL5o6lo4KsS0cNSJ1t9Ps6K/nSgCmD2Dd8gIoabGG1?= =?us-ascii?Q?XYWMxMwN13oV92OEAtMww7HCi8OIuphrMSMcSk8J7A/bGhxhV8b3oeAoSfby?= =?us-ascii?Q?NG0XMCg95WLYctduXNsCmxNwEnhz26AwK/qmGJyUStWjdYpbB3t6DvFIkEqh?= =?us-ascii?Q?aBXVDFTvJQKN5ud7yFR3+Ad7csPCdsOeR68W3DNggW4mOx3TKOEXTh25B+Si?= =?us-ascii?Q?qoa/U49iJ8kaHpH7/W9HttUcxDSXw5aeEcbJdLybJQ3RxeojUuSpCZ+8F0iY?= =?us-ascii?Q?T0GVFvuByeXaQuaVm9SfEpu1QnxoThT7xgi6/+z02nk43JwVRpKsLlm5vM0X?= =?us-ascii?Q?xMm+A00lKtUXkzDH/zOr0T9ZZTyCgKruZ5eAXnCAJKPdmvN8GUK/gWUpdHCm?= =?us-ascii?Q?/FVsDCiuX3UkeBfKP+Qc9vvnI+bw282LdOw0Nj1aSG5D9cO5anc87+yD1Tz4?= =?us-ascii?Q?sjlB8MJA3nVJgdoIBvAIAMd6xzY8EC6ttpNC46/rV3umDgJ9AED0FfG6Y1yW?= =?us-ascii?Q?GWNy8OB44ut5P0mIQSLfWLvJI42hqfHxwPqVq+64+rRlW84fz5oZk3J1m0TY?= =?us-ascii?Q?+fb9erc6M84w0wmXuIp8PkFVtMB0jxdBtwyGMVmlfVPHcvZT9BegWKoLd0vx?= =?us-ascii?Q?V/Nvy040486UIrojvwWFOXrrXC/l2OXCZ3N/+ysAhgzRTHLJ7/Wn5bUmB2LG?= =?us-ascii?Q?HVc2DJgQxSxjC0s33jQCT8gZoMnNkvCpsN+eCymyzHrB2M9U91/ytQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VPy3fCIUlpJ5enbS9ruPSI9/aueBoSeo8BLYUq4fdmdcQ4ITQ1jSfSyFHjKF?= =?us-ascii?Q?ceLIOCe4kXhWRX0bg3NgqkFOFf/lCyqnD3gGRfZvPblk/o1M/aBMSRHrVC03?= =?us-ascii?Q?0ygrvGBqHGYt7yjNHKI36PbpF+nTB+8+rMzbk2d4zGAPp4qBb2e6SLH0RkTX?= =?us-ascii?Q?YEzWHmjN31+u9PBO7RAb6/znFiQ54SaD39FvDCnBuP+itgvwwBDvFjtAqF9V?= =?us-ascii?Q?3XDUFCfDWag7nmuDg86v1Dc9EFjxYPs5A+mBA6WUCyvaTueOZOJYlu16/CZy?= =?us-ascii?Q?H29a+8vGsZlM2QxCFql6efvd5Alb99gVxctvAeCBHLiwz9w3Pydi7D/4ui1I?= =?us-ascii?Q?YJ2SBy+c7or4CfFq5NH923cAfGjdUG4eqVyI1QrW0fGOrNDck6cBct4bTz8B?= =?us-ascii?Q?eC2DvT2uaIu++MqBS2iFePR+a2ZiSzu0xQJOTJ/AFXY4jCI10p5ObQTlZEyB?= =?us-ascii?Q?rtb5UrkNf6DS3iGz4nLpzNpFbPadvF3wz1NBf58sJiJS4STurkXV+Ijt1qfz?= =?us-ascii?Q?HVUwKrbYgB/ZvX+Yf/UALiEhXmmv2nT3DeN3yEApXvo/KyAAa+bJgFXvjmNQ?= =?us-ascii?Q?yU7O4aYi/i3+tKW9NH/HuVVXc+g2KvqGzm+TY2DSFLkYrRjUQRMRt1GcX/5T?= =?us-ascii?Q?J1d9FMEy0ya8B6Hd+ksAf0rLVNFBFLM1wvC4YsOKVm3N8xzmV8S0w1gI7aB5?= =?us-ascii?Q?lMQoU9j/6vddGmO5DHMBKWtBA/RfaqNl48tGiFOUy9CfQJEfu8O2qhqUPa5D?= =?us-ascii?Q?9OoELv9Jv1aTVc6eSlpq5VqvRF7wx0mYpEFi1GEbOYLXRymmzUpmX2nCY7oR?= =?us-ascii?Q?fmKkM043Z1l+8AVGC+7PQcjsk8U+HZ+QsOHxQsI0WYh8plXLAO1RnxwPAwM+?= =?us-ascii?Q?UwkovKH5s9ExM0K/aDdyprSLp7/fuxkMfXxe6SZiq805E3Yi0i4q3JfdGhr5?= =?us-ascii?Q?UVzn2A4nmwgsXo55j2HPzUOuauB9hDTHHhtQtAU8gLYntSdf25YQRy37b3bZ?= =?us-ascii?Q?/zb79JP0zbfJvciXAE9kpeMMMYUvnQTAdoPP2mRU1ujj8+UqrGPxTfnTShgc?= =?us-ascii?Q?tp0qJxPS2pw2pFgHeZI0z70dv8P+rNT47KA8u6ROdygyYN/deE+ushypFvUP?= =?us-ascii?Q?C2yWoU/YMpiRkmHNEdpOy7T/Co4YZNi1TEObY79JyT9X/RnIQM/kGZyAg766?= =?us-ascii?Q?ip9rCe1BQOVtVQLdm2y2apSB/xFd7mPDkwv9QtXvLWNAOU6QeC/Dkx/oJbRl?= =?us-ascii?Q?IEnrcAZEbp9O8imyxr/p0SQ5P9f1pt8n2pXMNt189Y/rgOh9AHu7KzObFgAv?= =?us-ascii?Q?BBXidcC+BQNPdqlSolZrjOhGm3NJrVJYcbKT9vITKw8+5mG7KBEeLOxJI6Ff?= =?us-ascii?Q?sAMbMAmr7Mu2hqmzRFjydMXnu8cwimiwaNWoCcKKMOaXh4deoxYf8RKBSu5G?= =?us-ascii?Q?BSeFYxrkcO0QNovcRmWn/Qfm0AClmz8V4QY/g5d1Y4GQpxJHwsYMyYmcckrF?= =?us-ascii?Q?ZAvIcdz9exP4zvbzcwTFFs1q7n/ing/Y2ZZhdgdxayUvPsp0+b4r6+p/IU7C?= =?us-ascii?Q?ViyaKg/7NaB+kUMhnza/jX8EQOci/2lI9mnpOBNEfyE0UvP86eMXxle6tkj4?= =?us-ascii?Q?hHvvWMhZqsB0E7giaDIOqs0=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: baf069c8-8f01-42eb-9915-08dddfe5c73f X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:34.1408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W/T1CHmTR8CtaP0f3VahaqkeTDUNTUSAahjZRX3IAWVJi2qGs/SxCH20aLBf5J7x46+2yEUTdkGJbqrPcZNBdctydpGaLoGxgPX4sP0JEME= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 Content-Type: text/plain; charset="utf-8" spi-airoha-snfi uses custom sector size in REG_SPI_NFI_SECCUS_SIZE register, so setting of page/oob sizes in REG_SPI_NFI_PAGEFMT is not required. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 38 ----------------------------------- 1 file changed, 38 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 57eee658fb30..5d8e1a233d98 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -516,44 +516,6 @@ static int airoha_snand_nfi_config(struct airoha_snand= _ctrl *as_ctrl) if (err) return err; =20 - /* page format */ - switch (as_ctrl->nfi_cfg.spare_size) { - case 26: - val =3D FIELD_PREP(SPI_NFI_SPARE_SIZE, 0x1); - break; - case 27: - val =3D FIELD_PREP(SPI_NFI_SPARE_SIZE, 0x2); - break; - case 28: - val =3D FIELD_PREP(SPI_NFI_SPARE_SIZE, 0x3); - break; - default: - val =3D FIELD_PREP(SPI_NFI_SPARE_SIZE, 0x0); - break; - } - - err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_PAGEFMT, - SPI_NFI_SPARE_SIZE, val); - if (err) - return err; - - switch (as_ctrl->nfi_cfg.page_size) { - case 2048: - val =3D FIELD_PREP(SPI_NFI_PAGE_SIZE, 0x1); - break; - case 4096: - val =3D FIELD_PREP(SPI_NFI_PAGE_SIZE, 0x2); - break; - default: - val =3D FIELD_PREP(SPI_NFI_PAGE_SIZE, 0x0); - break; - } - - err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_PAGEFMT, - SPI_NFI_PAGE_SIZE, val); - if (err) - return err; - /* sec num */ val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020095.outbound.protection.outlook.com [52.101.84.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E5E6320387; Wed, 20 Aug 2025 12:33:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.95 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693224; cv=fail; b=nG0HACUxshGoy7I9zbrc1/cV21LrWsi70oXk+TUrSRqAXyBqWHDxp44hqwsWt1DDBWgVwiExY+XvPPFvlC7LJfcTBmrixLe+gkd0nmxe7DDdK+qzbougjkxmd1mcWbNUX8T+8Uy2uCFjJhTLogN2DP781WZtUBBbDnhKYB38AKw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693224; c=relaxed/simple; bh=6XfGr4khJAJ4WeTkCIjZCUiGAr5orp5/tPEMM/J6V4c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=rtiPvEZypI3ExnQ0zyWg6bSTsiobKd65nl0Ind+AqmodrLuFgugeE0HAVlAd6i9Jj8TrC+ldv+hjDFVe4f89eSmau6nAJQLzF4K5BxbC70s5YU74zomUKIp5rLtssq4RLQYYwjF0N5DLn3e4EDTpl+hKvKPfduKLsYSvfOh4+ug= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=AaVn+SNX; arc=fail smtp.client-ip=52.101.84.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="AaVn+SNX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TLgXZLSpllGz5HZj8hvHYg4XLKCr3AVZo2kR+wASp5uUlNKLQjzFjpIrAqyfG0LLcMOXFEgRCoW3uItD+eNALs2tkDs1T1QZqJrxEtjeaD154CtKLKSxAqPbyDuFrEACaaL2OPj8qVYa0kZA2mUNwakMKbTvFx2iEdjOTBcbEbMwWdQHjsjQhdw/19sXOJhWkzNKF2JFd+yU9Jk2DxAvpcKPQNQiyYd/a0xhDPJvjEda7hiy0nDR9oODopLWqI70kFcu6lwwG7hop+XtYVswNkHjG8xPPJQxaOLtoGq/tOjlPbEbXkGPXt2sl+BoKT3UNCFWYjtX3OMtSFOEwoevwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yp7KV2PrVX71F7CBS7Uy8XANyR/fUklHJmdvOxdudag=; b=WcNBaXQSnI23jEmqZw9CHA7rDm2Q++GhCnJbZGeUAtuyOKdlgUBARaLylbVeeDYY4Rrfv8pOsKWc5/HL25tiPjbRvatQtlipLHUeKoITk5Hw09eGOFBq7B4wrZDNmpNM7m7kdkGUxv7mVZAKYgawbANFwBIcwMb/z36GS3wLfYocrBldmxd+qe1fJrFjiM6uTpqF3FJz1inTwnlU5uNPZrbaAC6WyCg7LhJepuAMPDqLyXrTVwQtzCF2Dq03o0rDKeeISWnWchn6vvRujqskDqZgZxQRKQ+tM3laHHUMpPOTf0rcEO95zJ4lrzGrBGvHQQLrIBzhrWrCQ8/R8DAbBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yp7KV2PrVX71F7CBS7Uy8XANyR/fUklHJmdvOxdudag=; b=AaVn+SNXE97qAmzzYF1dHFsYYJyLjcohoZLO0lkoeHgxIoDBEfgUsg23EO84mqGC2fKiC70HSLbn+DGuxvh9sTdsW6Qgohp6Y/SGd+NZogukHTlX9VxHBImaHPzHGyhjYCAX8mSK12P4QYzOBftRqGQhw/NCn6tvpo1MDn9vCzvaTg5rh4pxevarSM9LA2qTFx1VlwjodbIjXt1Mafz7AR75ZS2pR10lLwfMvrixKvAVXe9EvC9Ez/otrMml1v0NVkjvx9fGq5+Nd5Nexd0ONEjAkZzXzLtZ4laDgESSthvG4B66FsLPvOEgXElMZ1MeJEpP4b5UjBFgT2SLstZvTA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:35 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:35 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 12/14] spi: airoha: reduce the number of modification of REG_SPI_NFI_CNFG and REG_SPI_NFI_SECCUS_SIZE registers Date: Wed, 20 Aug 2025 15:33:15 +0300 Message-ID: <20250820123317.728148-13-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|DU0PR08MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bc935a7-5261-4661-3f21-08dddfe5c7c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?n7O1DcQr03zkYPazuu31/BY/2Fi7lB9jdxj4IX2Ha8oWImkdc0uBgzminFXM?= =?us-ascii?Q?2B0vX7+J8P+LI7DKZ/czRdbJqC+Rm9JBghbj8o+WthXI1vCWiiPsE2jHgvZ+?= =?us-ascii?Q?hlbDljTp93h6XbETkzwYsekgvOo76Ia4R7Oso9NSC09oM2BUCCrGCYCP8Vtj?= =?us-ascii?Q?41CKvuxsEPoC4LKBJIVSvAIaSXxAxzAejBWd2h0Q3Gur/mim0rrXa3hG78pO?= =?us-ascii?Q?bPUn26ummAlJsXPSJ/Zqd2bBfh8zgjTG6pC7JeS7NlLzhfs88UoCA5tQgeUf?= =?us-ascii?Q?eC1IDalHDfqPuxImEPFeTZv+zwPs+hdVe1ztfxVGUnE2DTB40fGoa49K2syn?= =?us-ascii?Q?mzaNRIDXp5fMAF6e3/92wl9ISTqxAH2PXMzmeZHaKPP3ZFjZxFxObKQJ/fym?= =?us-ascii?Q?6fO3RhemG9jrdX388WPMYuveyadnANKbMcFG7jkNNOiq+MoaDtr/68id7u68?= =?us-ascii?Q?e33NTSmd+6krTmwBDx8f9bKOhi+fDRoLlT2RROd8bbeWEfSCbCLsjp1QPoft?= =?us-ascii?Q?wuoIajk3xOGBCfX2MsXE02yUMTmucmHKhr409Dv9Zpddz/jpBMKgFfcAoPtp?= =?us-ascii?Q?b6k9HctQTR39MhqJhopcFx8ksU5jA7+YHJRejgeF7eIPPHy0M1KkQnt4aTvL?= =?us-ascii?Q?82bu9KE43hv9EC+r3rdd88/aE+XEbSLsOptfCE2enOgDV//ydGnzMGYP0L+p?= =?us-ascii?Q?ex8SF4cQGfKmmPP5N3AKm4/V9eVvWFCSzm2h9ncP/S9DW0LfNjL+mfEr6MfY?= =?us-ascii?Q?ikEitOgF3e0wDcz9Wzs+2WhlTjVbCsfStkHKMBAm+5Eflwwq+UJH5c54TbJb?= =?us-ascii?Q?XicfHfcmdEk/gost50kcRiKr07MZFn8zSdUfwjZl9Og2AzuPCFRt7kwY1scb?= =?us-ascii?Q?JFqjfeHlv+HN83eej1B7vu3hzL8TV9D6ICO4fnnLwYU3R4EcwpD0n6cnN808?= =?us-ascii?Q?js6gcGkD+UnOCKus6VtxQBjxtjznH75KQ5RilTp8k/sKOhv34pwM4zVI3P8Z?= =?us-ascii?Q?ELRNlS8RUxFrDgvnm5Yi/8Atx+rqqbaD1AfPbbWH/vqD9JhzV80VhuELLT5h?= =?us-ascii?Q?F4Z+47gAmOV/qZw4RzPyn2dFddnLvyYjWgDlA4zAZc35kmAHJ7KZKLF+iL1x?= =?us-ascii?Q?IioqCnazT9AGnLFWtxMsEA6jNvjw0ZnvwoIq+PyXvc72wwIkJYaLI5pzkJjg?= =?us-ascii?Q?mfSlsKk1dxt5DmjdP8v9QVSJcojjZWNc1E19624rr032PPbYDUsocJ9KMIIE?= =?us-ascii?Q?68W8kOPA30aaZdPRbu6YlHBAhSooNKjh5TitIsCZtIwvE2BnAzjrl9ZE2Va8?= =?us-ascii?Q?koqZqqn6Bc+kKoiRg5LQFqVv7RAZ092BB1kROtztZrX/jT8vSo+HxRSzPMfT?= =?us-ascii?Q?f/gZox9GEj1rNsp6cvKC3DjpmeGfDiiv4iGnVSIyp0QsykSyseznt2+u05CG?= =?us-ascii?Q?M+HKVhVL120XMVAQfpPP23BzHRALSp5F45rYd1uJsuH0rhFnO1/MYg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A+4yvTLKqxvQ0O8n0NR+4XWkC96l/Z/lmUoKfSI0zP+jFZ+BckN5Ke/sPFb2?= =?us-ascii?Q?61yF9T9YBHdtHybwmmqTYfqAwObRnV2gtwAC2uGRhuJgcl3QiAYFRERyDqru?= =?us-ascii?Q?hUovAs4N0y+QI5l3OhAKAoF+FmbQT4O1Sk2jbD8d7TNQK5IAaGHx8Us0Ogid?= =?us-ascii?Q?GrME02zF2VRBUT0bgrJv5Vp1hSoLb6bazgPoiB5qUSP/DLvlis+IG3BrC+iq?= =?us-ascii?Q?0aDty5C3DGpxR6VfOZiJevXpV3jFuLmDsuhnu8TFIA10bJkuhk4X6F+/1INa?= =?us-ascii?Q?W1DECH+2dwrBdcTIL5eim4Dd3TKDc7sET0GQev4JhlLKKNI7EHqrRs7yLdoX?= =?us-ascii?Q?X7tXkrsyn4TslohLcm8up7s7NsrJNkRpnXlzqYCDIQbOCT3/mORfFkjiBBGd?= =?us-ascii?Q?XxscG2mlLrFFnm/fbSnWuUnCCkSMmbxcVt6fAKDqJ+dliNjWhe+yFT9LsIrB?= =?us-ascii?Q?frveznjmTeoWm+Aqrb4/F/uPwMwm58FNzg39TAIJDvcfE3mwTCZGy82f5bAw?= =?us-ascii?Q?/hlitPEBlA1B1j0Sk6AyfpvApodfuX020B8+pzk0yUr1+c9dLOQTMkFNRpt/?= =?us-ascii?Q?yUujwv+G+VtqIQgQnpS/cFEroyi1j+7BM12XVZLRKGXCt2wx2YkSK726s1uS?= =?us-ascii?Q?y0myJO1OXFYROsOUOUmgn1IwFE69nU4AUxBCu0RKPnDbUAK2G4oLp2zoVczU?= =?us-ascii?Q?kXPsZvE8rWHk9IOU/x5pS5Uc9Y/lNg+72l8xaDIQnOAIizOT2PBgBp5Qm70t?= =?us-ascii?Q?kRqD7B8TilGzT0DORr40Cegr1U+3L0sphU3xvGez8HClPZ88ot98cdbcb9JY?= =?us-ascii?Q?qq3f3VdnbV9MC1DDxNNJzu95IPdYG/xCAmAAvDTrcw5ScJSBXCCJjNz84kzV?= =?us-ascii?Q?ZmpYZI7KMJDbAf5ss9BKvMy2EI/HTtSCT06kpvTSprfoMf0fAWejOWzyjP6y?= =?us-ascii?Q?BkCYuKwfNkyLdQ8GwqgKdLtkXSQMjohGosAE78Pxwxl7NYT36cKHJ4mDPWzD?= =?us-ascii?Q?iK8z4zfvL3Q6Nmg2giDMkKKyRqnlLIQ7An5Z3VPdohSkUEZNKEGxBZigmzxM?= =?us-ascii?Q?9UMe7S3Zp9SQrRJOcdQebcIDQtCJ7N4LCIGvvsfR7yq8NgcWZqjYCmy3XA5b?= =?us-ascii?Q?y0RCYvfFC44It/xfMxPlH/KQPR5wae2V8zrO1qQQz9Cnjdx3Jc/rU20Oq6fM?= =?us-ascii?Q?Cw37L14ePYgzI8KNNWwpMfVeg3BNQh9vwTOTfoSgv4cq/1rqYYNAAjmD+jor?= =?us-ascii?Q?2LEJyOeUGdhNc+R58ZoyrH76wqk8jYzD8+AzQ0Dk4Xh16+VbcbwKIyPavndh?= =?us-ascii?Q?WXmLLtPtp0VjFpvjyfN+5s2+/GO+TkEgwLuuPZZd9vHk+/T9A4BWTgD0mMAN?= =?us-ascii?Q?T1VKCyo/10rMYsqzQXFoA2PoOcjQAIYwqlZiu1XvwgnX3whY68mhHpuYzau1?= =?us-ascii?Q?K9g/fPgIGs5Y+IrZ1sHksxfI2nZ1G5sU/mIODG6eX6qq98Xle5SgjK/jEt2F?= =?us-ascii?Q?6zyAOIAg5RtszkBJnRp1lvwX3+/+P8bnYf2B5FLDwrObuNoQieNOCmeGkRFp?= =?us-ascii?Q?r/5a+FehRuh28WiSi8I1Wl3pr+rwD92/9J+u498msN/NH5p8T4gngiXIa5Mo?= =?us-ascii?Q?KI26vJHFxbu/BCIxgQznxds=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc935a7-5261-4661-3f21-08dddfe5c7c5 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:35.0093 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sSKvWUniolPQfh1P8NryHKrWgrNZwvDtSUbCUEsQfKdAatP56TiTVkrpv6u3xx1COii/0QoCAskfFmrqI4Qd2IylG3G/aim28B9fCjcwwvw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 Content-Type: text/plain; charset="utf-8" This just reduce the number of modification of REG_SPI_NFI_CNFG and REG_SPI_NFI_SECCUS_SIZE registers during dirmap operation. This patch is a necessary step to avoid reading flash page settings from SNFI registers during driver startup. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 113 +++++++++++++++++++++++++--------- 1 file changed, 83 insertions(+), 30 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 5d8e1a233d98..10c4081d54cf 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -668,7 +668,47 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem= _dirmap_desc *desc, if (err < 0) return err; =20 - err =3D airoha_snand_nfi_config(as_ctrl); + /* NFI reset */ + err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, + SPI_NFI_FIFO_FLUSH | SPI_NFI_RST); + if (err) + goto error_dma_mode_off; + + /* NFI configure: + * - No AutoFDM (custom sector size (SECCUS) register will be used) + * - No SoC's hardware ECC (flash internal ECC will be used) + * - Use burst mode (faster, but requires 16 byte alignment for address= es) + * - Setup for reading (SPI_NFI_READ_MODE) + * - Setup reading command: FIELD_PREP(SPI_NFI_OPMODE, 6) + * - Use DMA instead of PIO for data reading + * - Use AHB bus for DMA transfer + */ + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, + SPI_NFI_DMA_MODE | + SPI_NFI_READ_MODE | + SPI_NFI_DMA_BURST_EN | + SPI_NFI_HW_ECC_EN | + SPI_NFI_AUTO_FDM_EN | + SPI_NFI_OPMODE, + SPI_NFI_DMA_MODE | + SPI_NFI_READ_MODE | + SPI_NFI_DMA_BURST_EN | + FIELD_PREP(SPI_NFI_OPMODE, 6)); + + /* Set number of sector will be read */ + val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, + SPI_NFI_SEC_NUM, val); + if (err) + goto error_dma_mode_off; + + /* Set custom sector size */ + val =3D as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size; + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, + SPI_NFI_CUS_SEC_SIZE | + SPI_NFI_CUS_SEC_SIZE_EN, + FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, val) | + SPI_NFI_CUS_SEC_SIZE_EN); if (err) goto error_dma_mode_off; =20 @@ -712,18 +752,6 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem= _dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - /* set nfi read */ - err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_OPMODE, - FIELD_PREP(SPI_NFI_OPMODE, 6)); - if (err) - goto error_dma_unmap; - - err =3D regmap_set_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_READ_MODE | SPI_NFI_DMA_MODE); - if (err) - goto error_dma_unmap; - err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_CMD, 0x0); if (err) goto error_dma_unmap; @@ -819,7 +847,48 @@ static ssize_t airoha_snand_dirmap_write(struct spi_me= m_dirmap_desc *desc, if (err < 0) return err; =20 - err =3D airoha_snand_nfi_config(as_ctrl); + /* NFI reset */ + err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, + SPI_NFI_FIFO_FLUSH | SPI_NFI_RST); + if (err) + goto error_dma_mode_off; + + /* + * NFI configure: + * - No AutoFDM (custom sector size (SECCUS) register will be used) + * - No SoC's hardware ECC (flash internal ECC will be used) + * - Use burst mode (faster, but requires 16 byte alignment for address= es) + * - Setup for writing (SPI_NFI_READ_MODE bit is cleared) + * - Setup writing command: FIELD_PREP(SPI_NFI_OPMODE, 3) + * - Use DMA instead of PIO for data writing + */ + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, + SPI_NFI_DMA_MODE | + SPI_NFI_READ_MODE | + SPI_NFI_DMA_BURST_EN | + SPI_NFI_HW_ECC_EN | + SPI_NFI_AUTO_FDM_EN | + SPI_NFI_OPMODE, + SPI_NFI_DMA_MODE | + SPI_NFI_DMA_BURST_EN | + FIELD_PREP(SPI_NFI_OPMODE, 3)); + if (err) + goto error_dma_mode_off; + + /* Set number of sector will be written */ + val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, + SPI_NFI_SEC_NUM, val); + if (err) + goto error_dma_mode_off; + + /* Set custom sector size */ + val =3D as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size; + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, + SPI_NFI_CUS_SEC_SIZE | + SPI_NFI_CUS_SEC_SIZE_EN, + FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, val) | + SPI_NFI_CUS_SEC_SIZE_EN); if (err) goto error_dma_mode_off; =20 @@ -863,22 +932,6 @@ static ssize_t airoha_snand_dirmap_write(struct spi_me= m_dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - err =3D regmap_clear_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_READ_MODE); - if (err) - goto error_dma_unmap; - - err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_OPMODE, - FIELD_PREP(SPI_NFI_OPMODE, 3)); - if (err) - goto error_dma_unmap; - - err =3D regmap_set_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_DMA_MODE); - if (err) - goto error_dma_unmap; - err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_CMD, 0x80); if (err) goto error_dma_unmap; --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021135.outbound.protection.outlook.com [52.101.70.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22BFD315760; Wed, 20 Aug 2025 12:33:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.135 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693225; cv=fail; b=Wy/ACsOAIWYnTPOiXVThttSinYk/czMkEJkdgftdppBEuHWRYr2Scyxdpf0ApmyQVR6/XId5mxsD5gbiv769A277emCqgEBN0JdBQYgFd2or1yk4fIg5lEK8i1q0CdfBUlKdWZXN2oKNOfMlfVlSDP6q5nW0qoWcGJF4U4PTnm0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693225; c=relaxed/simple; bh=1mbsZxjHMop34vX89u+LBaxZtVmPxp3kOOOcTFpwVOo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=dXkrKlDb2G48CChc5eDZW0QMLoJ/6lDWxnUB/aE9WT67UkerJOGouaMbYteYZdrxo53ImXoELjhNfge+uV02cl5PwjLpGaYo49trb2BF0Pb1PLri4qdRO6bZGXQ7jQwvv9vCmBGP2E06yszudNVWt4YsXztkprvHC1a68p+w3BQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=P3NngMQ0; arc=fail smtp.client-ip=52.101.70.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="P3NngMQ0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RY0Bw1s8+jBmLitj6bKbrMy0IHmOS3FI91AZBLP8njjltP/iUuIpblyYmLHuVWtBSo0hfKxwzfzu+Oj1IPcRhCUKOTetat+zHYfv6CreLpQBNVuOYrSMzmCluSE1xF+pitkOJw4RVXly8lUdbtRXusqEvqsJ/WGKfXvVmpmVDXeFdxmqZpjvXzWx02wTckMMZgWilhQEyfNvfhhG8IJIE3Jw//p3F9eL+nF+iadXhpVQzkcK0+EZGU+gFTKQtsOGeMzvpE1NTiHXAgAdiKZN/lqqdU+MQAnwBRT+u96ivcFUjqTnvG8p+0XhYcaVv+0vWrPkeWckSxnNzkuJjQps2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dge+Wohza8VNTmicDnrqIU7ZiQ+jKHAuw30Z0jYAzqM=; b=lrOQV5A8uuSh+ZB66IxNHliWzH7Wl8uoZ1kKiRzrHeRHxurvsPiN9qZW16JM1t35DWTtT6cbtGWcfvPGPY8zlUoBmznyoMrUimIpUHLlVwIPPcouVKuxzmWSA2cbIwcnFo/jGH8U0NW6Vqq1/OmpvvfI5iPWWeXHXhQMMc5fBxE8/WwL4+JCYE5x5FP9rmzIcbv04PAojR8lA/Fl6Dym7TQkAsxidwXNwBF/+QsQPamW3r6P+MFW6q4rgA/dN0DG0sQcmI4ViR/wuIiQIndwfvLSI3shZagTAs2O9PDS+5A+64x5UfoTMcDJ8TerZIRG1NcKHEFQiNyYwADgw5F/+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dge+Wohza8VNTmicDnrqIU7ZiQ+jKHAuw30Z0jYAzqM=; b=P3NngMQ0yFoTsxtEOArL/fPGTSfOtOapdqqBjGX96v6OqFsWaLGFjHPGMZl1VsICDBcrjP+5GXZwGcrj5vq4MbcGUE86n1zL2a7ZVRLsxvN42m5RkNbdEB/7uzwXo5Tcq1o/VBvTg7/nT/0blMJDB3+KjtlKvT4polM3GlVgaowboAPxc+FeanIFdpuSwiRCcKkOBS5Sxn8rrg5UZDQArJwur9dUDnXRjYJgQ7GdnDMXFi2ESOgjXPiwzUYPWKsfDclAScDu6MwMX2u5dARIatHWIXwb6QWVefPDueUDPzY8zEQP96pN6sqVC7Sldc3Odg2diBfLWKnRL8swuSXazg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:36 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:36 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 13/14] spi: airoha: set custom sector size equal to flash page size Date: Wed, 20 Aug 2025 15:33:16 +0300 Message-ID: <20250820123317.728148-14-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|DU0PR08MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: fbd020ad-7cef-4079-6512-08dddfe5c84d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?RdXYi8kBdSy/ZtfHRwgc5IgQA1dSQbF80Og5y574GHzULNwwZBWu/wu7yMIE?= =?us-ascii?Q?PHjk15l9NVv16CmrHPVY6pYqijo2IwU/b/aT/5AAAUEfB+sZWzLkhFGSNu+x?= =?us-ascii?Q?FxWGP7aFeBcJmrJQvRN+oGde85wXab+OtOLneJFN40mfYypXWlnEIMYHL37z?= =?us-ascii?Q?8+jkYhh5b9sYhpggV/s6j035zvvp/MqnOxb9kHUw70avGTa74lFgrkWXf4jq?= =?us-ascii?Q?D6AIGbj2aMhJxz8GDg7o/m0PiTi2PBGsLE2lpJbxy72rJ8HNd5Jd1sWtT+Cc?= =?us-ascii?Q?78CTObOVzqqtVTrnmX1N5S5+iW0Hla3e8bvD8AlRvm3t0q8hI36twuZs9aXZ?= =?us-ascii?Q?00cAlzUyn1MMJaJX44CUyPV9AzEY9Ut2DfW21IRIaNvSeBT1Zf3kTBywrlcG?= =?us-ascii?Q?lGC3UV8GwnJWMERQ89ZwA8J8IlcC9GEEwGlUm4P7TMwx3QCfPHgqEaSHfmGf?= =?us-ascii?Q?N7Py4dRxPGmxX9KmKKgtwK2RUXOl+A2dLyxSRKEoVYbS8uYiatod4UDWhT4t?= =?us-ascii?Q?LKPFxOSuozctwBLk2o8Zls/jT82hCxT32Silo+8UeJkcavvXTw6LOGsGHrna?= =?us-ascii?Q?Dn1IrUxcz7vgWhoxopYo1EgBJimWfXA0Xy2M5Sy6riS5Mv9F8P6+kT8l6YqH?= =?us-ascii?Q?ecj5HP5Zv94F6AVIw3LqABaKi1fCpEsbTds7aTHTw+9eN0KcBbTqfUWIvDQP?= =?us-ascii?Q?tLxrfHAvzxDyw9Ic92yVvPNp83NFBRI1z44SP+gLd0V3rcFBvzjgLnM/AHlj?= =?us-ascii?Q?+b3hAv1AteqEH4weRWxPDdu6uPtWdkqMmwDywaZsoFBfFU52Prz50+01UtX8?= =?us-ascii?Q?a8ns8ga+XDNibA1lvQgDbg1pi2SjohgXLI7CkUsIRxQm3RUeOL6wth4iyR7D?= =?us-ascii?Q?sbEhiogUWzJ9wYTefYsLhIwHNScFJ6krW+p39yWtXZzAOQ814QDSgFzz9cKa?= =?us-ascii?Q?r4S9E40+RkOw3qKe1QepLfxDQywA90Fb+4oCLApkCsfgHe5kDUjb87kE3gf8?= =?us-ascii?Q?h7A3fV1+Q4vhWXVX3Lzgoi5Qxl9zOCJPZaTZqb68L5NHYsm4nSTUF20CFy+i?= =?us-ascii?Q?wEEsuS4jB1vxvWUhljEwvHCtGBt5Nhb6ztk3jIo6FUXtg1y/EvXYjL67IK6X?= =?us-ascii?Q?Wjk3D7MDj8HGjYZnWAeUCjPU12GVY+8eE8olz7oFHEMAliDjRr6pg48dnN52?= =?us-ascii?Q?NKyNEnylFr1nQfNDaeQ4FREWVvwDOJxP3D/72mfg1ojJyj2td4ceiGzlEHnG?= =?us-ascii?Q?NcB+X4nOSKqCEHVL/2KFjVERBxcK1hWxqT+75nqVre38Wv2GHcdaST+Rn3NF?= =?us-ascii?Q?Cpe8yi8Jpk8SoNNJA3bzqA02yb/bLz2uw271yM+2yXaqaBEaqHTYFTC2o3mV?= =?us-ascii?Q?dBPunnMDuAxNwMHKzaCXaouwi14bYyuGWKucFpiF9BlUvbFllH23UDSai9g1?= =?us-ascii?Q?FoPwf/+7OeXhm6UmHdgLEGAwECkIrcYhj3JueAET0I1ogdaMY1uTTQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V9KDAJPVr8qvzNQI+jqEfo39PqRQTzH43qeWl+4zdrtiFsai3Zeh5svuMmeo?= =?us-ascii?Q?MAc9Nl25/WPmRhni/o2vC5xvIohEBBO36Y2QsBm10gHDD4mj2ztFUietMapl?= =?us-ascii?Q?6zqstYRdM5/lndIp/8cWsurJ19BGpt3HRhWWdEG1a8rrN39B9Yp6z0NgAbWY?= =?us-ascii?Q?3lWBALplKG2WWxxtpYs9VqhEjTu1VkGTeWENxBXfdwxEJqCwBHD7Tx0FEt/v?= =?us-ascii?Q?yqGlVauFDw4xSiaCLnHTR5rK2B2xg7OWzPn1Pka24iU48e+8gQV3HLHSuepX?= =?us-ascii?Q?EjglfC3f28XPIjo2mjnmvKDXy+yGmUzjgJL2WwT535158IwPD20LCutUp8d4?= =?us-ascii?Q?zbhaaxu+uN61Hxcrr44YiC9VJnc691n/tDSyAhwpCatDag/dJ5itCBjjpjTc?= =?us-ascii?Q?OzwiiI5ubrfIY2AvRVlxpC7WDleBsth7ZgoazMLGvBGeEFGTluXwHt0Z1aqD?= =?us-ascii?Q?vHINFOv4Uo2rNRUIdG9w0LFiTghk+jsO88aA8yQR/m/pEslTJ/OhdJ7Lm1j8?= =?us-ascii?Q?XajllKzS5Wfx5vlSmA0PlI4JnO6q+RQzmyON2MfPUIY0MSCbpOy7b+77G+Wz?= =?us-ascii?Q?Rbx6Sz5/poRX6ujSpfeGVM7f1dd+SsMVM3nbcz4ZAB1np2K2ef3cC82X8AAj?= =?us-ascii?Q?P5Oyf2C3HpagPXdg3gbDrNxQbN73NT2p4mQX0UE8PpwuI8mFD+fxfXTViU4n?= =?us-ascii?Q?K0+O0xK/N5av+PQZeAKO6AFosQKAjBvDKX4cmhuOMJ2byBDpgsM2pPDAfTSX?= =?us-ascii?Q?OHSPCYWyakKDAP8CCy9mfOHz4AvfSrMuQE2Z4BXT1vR1V5P/OT8FDBPuYDTh?= =?us-ascii?Q?NaOhRFsNG3srTjVdKtbTar6y8K6NEGi1I/QGczows1HgEPtuH33DZ4KzlkU9?= =?us-ascii?Q?IlWZwzgzyNXfvv6qZBXMOCkOP0GrUeyl4Z5Mfa9bw7A4gS4817DmhdhB7u/g?= =?us-ascii?Q?zQJpO4d9ltytHhdoOyIIO7qshBbXY4+uMfUH2ofOP/zTakBTNJ2z3I6HLhdO?= =?us-ascii?Q?BYhyOcXmh5Rjwemn3OTGxhdwxN7c8h/BKVZszqFC7iwG1hlPCKLbpIag/R/N?= =?us-ascii?Q?6vPnmRbpsn3EZixnJLcLmUZc5aGeX7ffbEz1mLA/TlYX/ogbDLFHOHVl8eWS?= =?us-ascii?Q?egoLq85jjRpLBltjMH22tl8YgG+ZofcrZLWU7New9MXyS/++tD27+elMbM7N?= =?us-ascii?Q?cMSQkZks7JFeC/H8zWVvpvgLAdU10crsdLh3ezqCfnYeQxVFaSOxaU70hZ66?= =?us-ascii?Q?Z0zZ4XgyFN+jt/fo9SsIfqkIXldrTVa6aRtIFBpeSahqR1GMl5k7Qrnl38uJ?= =?us-ascii?Q?dIp3mHc2jEtylwyX3pEE+dZZwbMVPH7djXpjram5H3KynkCFeBENXaCpfKT2?= =?us-ascii?Q?oghz8BV3DLgoegnhHhGLGt6UkF8J7q6kki7cnhKj23LS8haXdUTFcoHLMKig?= =?us-ascii?Q?j1mOMLkTvAl+SvxlLab2H3AZeIfNg88dA9mqs191v5Y7oZFa+tKXAuGZwcC5?= =?us-ascii?Q?IZrGLhVzz3IBjNtDk9kd/W7rsAcK2UuczUsdsOiupmfls1+q9L94v8Ui/REy?= =?us-ascii?Q?MsWaiimIQSwCthmZK/US7K1ahqE8lAGXDwJX7ds0/JQVTe8nAH1keCNpCf5A?= =?us-ascii?Q?WAjw0+WKrof091PbLB9IIP8=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: fbd020ad-7cef-4079-6512-08dddfe5c84d X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:35.8967 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9pMMPc7Udm50kkUC7vC/QYwbDYqYZRkLMOLD33HeihRy6g5OoBh324IPdiUvqeflCOWNBPDcBwUl7ujJPEwIxb0i3Ul2yGfah5v36MrnSgk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 Content-Type: text/plain; charset="utf-8" Set custom sector size equal to flash page size including oob. Thus we will always read a single sector. The maximum custom sector size is 8187, so all possible flash sector sizes are supported. This patch is a necessary step to avoid reading flash page settings from SNFI registers during driver startup. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 38 +++++++++++++++++------------------ 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 10c4081d54cf..a02dc6de5406 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -635,10 +635,14 @@ static ssize_t airoha_snand_dirmap_read(struct spi_me= m_dirmap_desc *desc, u8 *txrx_buf =3D spi_get_ctldata(spi); dma_addr_t dma_addr; u32 val, rd_mode, opcode; + size_t bytes; int err; =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 + bytes =3D as_ctrl->nfi_cfg.sec_num * + (as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size); + /* * DUALIO and QUADIO opcodes are not supported by the spi controller, * replace them with supported opcodes. @@ -696,18 +700,17 @@ static ssize_t airoha_snand_dirmap_read(struct spi_me= m_dirmap_desc *desc, FIELD_PREP(SPI_NFI_OPMODE, 6)); =20 /* Set number of sector will be read */ - val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, - SPI_NFI_SEC_NUM, val); + SPI_NFI_SEC_NUM, + FIELD_PREP(SPI_NFI_SEC_NUM, 1)); if (err) goto error_dma_mode_off; =20 /* Set custom sector size */ - val =3D as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size; err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, SPI_NFI_CUS_SEC_SIZE | SPI_NFI_CUS_SEC_SIZE_EN, - FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, val) | + FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, bytes) | SPI_NFI_CUS_SEC_SIZE_EN); if (err) goto error_dma_mode_off; @@ -725,12 +728,10 @@ static ssize_t airoha_snand_dirmap_read(struct spi_me= m_dirmap_desc *desc, goto error_dma_unmap; =20 /* number of bytes to read via dma (whole flash page + oob) */ - val =3D (as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size) * - as_ctrl->nfi_cfg.sec_num; - val =3D FIELD_PREP(SPI_NFI_READ_DATA_BYTE_NUM, val); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL2, - SPI_NFI_READ_DATA_BYTE_NUM, val); + SPI_NFI_READ_DATA_BYTE_NUM, + FIELD_PREP(SPI_NFI_READ_DATA_BYTE_NUM, bytes)); if (err) goto error_dma_unmap; =20 @@ -819,10 +820,14 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, struct airoha_snand_ctrl *as_ctrl; dma_addr_t dma_addr; u32 wr_mode, val, opcode; + size_t bytes; int err; =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 + bytes =3D as_ctrl->nfi_cfg.sec_num * + (as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size); + opcode =3D desc->info.op_tmpl.cmd.opcode; switch (opcode) { case SPI_NAND_OP_PROGRAM_LOAD_SINGLE: @@ -838,9 +843,7 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, return -EOPNOTSUPP; } =20 - memset(txrx_buf, 0xff, - (as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size) * - as_ctrl->nfi_cfg.sec_num); + memset(txrx_buf, 0xff, bytes); memcpy(txrx_buf + offs, buf, len); =20 err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_DMA); @@ -876,18 +879,17 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, goto error_dma_mode_off; =20 /* Set number of sector will be written */ - val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, - SPI_NFI_SEC_NUM, val); + SPI_NFI_SEC_NUM, + FIELD_PREP(SPI_NFI_SEC_NUM, 1)); if (err) goto error_dma_mode_off; =20 /* Set custom sector size */ - val =3D as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size; err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, SPI_NFI_CUS_SEC_SIZE | SPI_NFI_CUS_SEC_SIZE_EN, - FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, val) | + FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, bytes) | SPI_NFI_CUS_SEC_SIZE_EN); if (err) goto error_dma_mode_off; @@ -905,12 +907,10 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, goto error_dma_unmap; =20 /* number of bytes to write via dma (whole flash page + oob) */ - val =3D (as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size) * - as_ctrl->nfi_cfg.sec_num; - val =3D FIELD_PREP(SPI_NFI_PROG_LOAD_BYTE_NUM, val); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL2, - SPI_NFI_PROG_LOAD_BYTE_NUM, val); + SPI_NFI_PROG_LOAD_BYTE_NUM, + FIELD_PREP(SPI_NFI_PROG_LOAD_BYTE_NUM, bytes)); if (err) goto error_dma_unmap; =20 --=20 2.50.1 From nobody Sat Oct 4 05:02:35 2025 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021135.outbound.protection.outlook.com [52.101.70.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33226321436; Wed, 20 Aug 2025 12:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.135 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693228; cv=fail; b=nd2jadRW0R99hFdMmBD9oIjmlD+HWkt2ONGqFO5bNFXdvMAPto0kuItBHP081Ebmi1ZjgcE54glieJs0OuUtxLRCPS1z8nWDQ05kTEgjQOatafcVzO4Pn+x+jdVllHw0db/7wHbJF2ulC1R7NPfhcb7dSJl2nhrE1crZ30yLuX0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755693228; c=relaxed/simple; bh=AKunWEmjDU1s8Xv4obEWwt+zJ0vN5IQTrTZW1W8oh24=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=hTzyn7Bf54paUAcw1sJTzQ/LHgHW6u+UuwV9vP5ZKJAfg2eWeYcBUkk6GMUgRINA+VyV2cMNkHPqx1r168xMJebA1dN7qYEvLM5iUsXcJileqw7WixggA1FcqHLsa44e7lHd5N4gSrPfjZU2VmqSpe7YYb4dsBTDX32rjoNI5Qw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=ELNZAEc3; arc=fail smtp.client-ip=52.101.70.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="ELNZAEc3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=smHtIXbgiDTmndGA+6U8om6KLZ3v1BDhS3W0plOu6dMk0g2oGGhgLWfts6d6d72fUPE8CZv2pbbvISvL9ZfKifl95Gt21r/n3KVyzjQlIYri8cvQ+7TcJ7+Uxk+kvH0RF6NvsmG4iV062UN3J4/ZsuUjDlUpH3jmVfQpkLjtyclwBR3Xb/dDOmVrxO2OpZpToPhxW37diiWrBeq/zeTaZsKL43Twqi3pCyFss0HQIPpWF4YGYl3jac9okuox9J8NkqMJm+Dm4NbXQ4NshaUR6Ex1cYVov0b07e8C+rd9KtnlTFK6nSryJNrBcvC76j786gYzWQebMEA/69nV0bmnMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K5ES5517ty02jDSje7nwVWZwUr2ltvbvBKvNErbhMco=; b=tdNDZT0hkvZSre6diQb7dF0hiCrUH2MN6jMhnkNarsiYN9Y3e8lKRyH1ZyWZgyNo4RZTI84qpjQZz/UF97/seTlAj7uvYVsP25E/rx0QCTKP/C3ILgMfT6nRuovBf4fYYBO2sEwgB4lxuQKGXVb3He3fQYQh7HPuaSCT8NRgTSt7CUvSogZ3THQr8lZcqWjunqlIAoo3plJSldSBgKiZWQU8KgDXO018Vz+P3UijnHao+aObtRMPeWkBNRbQW23dFzP+HeOPbUujzFANyouR0CRC8aIsvUZJqAn6e1BvIy5i3nmBzw/QkNBIfqX4dN/JquDGVDS1nGA1AmAItlZb8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K5ES5517ty02jDSje7nwVWZwUr2ltvbvBKvNErbhMco=; b=ELNZAEc3LNWyp3SjgqUqnjt538ml+rMPycV0RQsWEd5nZltx/ZUZvUzcKKke/xudhXd7D4m8r5EZNP8hyKiq/xlVwZgM4qhZZJEU5W4xNJCs5JgfGJ5fBQA+ZPDrts1lGBrPtdQL8VhlQEQ5xg95DM1Tft28L+iccctBT+Q6Ccnyzoht7b54X/P3sor+pZnGJTUjUz42OUFBTBMxCmDGBfgxPfr00xXmyaTBiPi2nYmcemAn51dW2z0+zSoO0fwTMzNJXFQQA5xuIUU7jPGG/ESl3EYw/11luUUMIwzKYhazXd+18K4Ym54cIrnjfE8VKmqcdi8gXEV7CmdwXKZSeQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Wed, 20 Aug 2025 12:33:37 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.9031.018; Wed, 20 Aug 2025 12:33:36 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Frieder Schrempf Cc: Mikhail Kshevetskiy Subject: [PATCH v3 14/14] spi: airoha: avoid reading flash page settings from SNFI registers during driver startup Date: Wed, 20 Aug 2025 15:33:17 +0300 Message-ID: <20250820123317.728148-15-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> References: <20250820123317.728148-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|DU0PR08MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: bed244cf-930f-4a1b-53b8-08dddfe5c8d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?B0kVJDYJXxwT6PPeYWByT6SiQ4tiJ6Yj/LVzXaERSzaubT9Q0j5yLoIu/1Bg?= =?us-ascii?Q?OfytefE6FxJ21D3a0Ow/R8xtjCqWw88GKhJINal14ixHrh8mOiPWa+BBpSaw?= =?us-ascii?Q?0J2dGsKuYliASWfntSw7FcYJRMXXRZU4V/2apJZPluESQ/sllH7+qZFMhmJ1?= =?us-ascii?Q?uZtadbpNyUhcx1idwso3PL1bhz2NWHZICBQjmt9x6mmbCv3olPGHyEGFiAQV?= =?us-ascii?Q?FGn/hZyuK3bCyO4ma1OtXsdGh7DU6NqP2rCBjboCeT61l6cWB52VW4SozMf7?= =?us-ascii?Q?n2hIb6n52W1ooJ6cnuTnkxHmzvuNYJOzYaEKQ2WP/zzKIE2CGz+iNfunBnLx?= =?us-ascii?Q?6kW0apYfezoNRD4OUiykTXYDhskht6dJ5l5LrDntlObUMEFsX5mxC0SvwOv1?= =?us-ascii?Q?g0gYJAHB3BY2yN+9ad/0vkAatkgRKMPaCPtjRVztgzAowOOYKM/4/h6urT6p?= =?us-ascii?Q?gt3cgIv0yimhvme2PvsuH2UEqnqvIAOwi+/GIvGBS5l1YGyn+Xf2buHN2Kin?= =?us-ascii?Q?ci5r38h7U9z0p4WubzS6eW3ycaHhD9ablor+TqdOGBqG/m7Pl8socY2VhFQG?= =?us-ascii?Q?hXi/f2fJabavSOtfVn6AWhVzyvp0eStWVlB+ALpDPFQVW1SHWJMgScOBMDa1?= =?us-ascii?Q?z7Xx8NZu+gtDMg+CNzdh2H48dhXreFglR7SKzhclGmdYqPdKdZDPc3luBk7g?= =?us-ascii?Q?i7y9qDf01/ezoi1R9P5rbQYe0ESKgZck5ZMdFo4vZw5hEkgf5ww1o8fURxs7?= =?us-ascii?Q?MU0KQXL04i8O7f79bYI4q6b7ju5vekvFmXd+2wm+5mGlmQCDktSzzmwbGR2y?= =?us-ascii?Q?8oczcgOE5FvMTYEtN8pl1y4jnzVCm0Li2guFdVza+Idnwt7opsAYSpDLF0fd?= =?us-ascii?Q?vyXluB74aPsc2bV81Mwsz5pUQxPdzpDRqa52EyEaJroLg4K5LAr9SPj6oRPW?= =?us-ascii?Q?4JR/7iXKp6Ato3/adI1wHJqvpnFvCZs3LUJ92gyvbdlUeTsDHofCfi3GaTBy?= =?us-ascii?Q?PFDvXbb3P8uaBz/GEQsX3F0pbulBTjbKABqS1klZ+AY+OBw+LDjwdPbyf1IU?= =?us-ascii?Q?+RqfpbIb5rNHrq77nq6CAWsIhoMEJ1QJatTgMKf7dFUafBSq9fZRJ60C2aXM?= =?us-ascii?Q?cPfbcYnm9H4keZ9WqfN9H5vZRiO4m1e9fO3KdFe/Cl9RUVN88y7BzvndvdZA?= =?us-ascii?Q?W4zVw9UrYe2dndARMaKeE2CPSMEoOtC9ix7MIG++aFwOLXVecd60A4jegUoL?= =?us-ascii?Q?+LbHTpoN5ZH3wIM40Rn1ydAS9biLBlfSSRTsqtTeuD/qSVeyPmXDhIr+vXkb?= =?us-ascii?Q?kntqVWOOfczSY1J+94/uean8hyCNU4s9CtQ9Vo0C4o6bsCc6Yi8Y8e2+L0ou?= =?us-ascii?Q?MNdraezaOzorKGpLENEU5GP2X/jQllhxzv2Ia7JhAQmrqoYBeFcZeI8BF9BV?= =?us-ascii?Q?M7xn0muyAu6ftW/7Ezrg8XiVp2FhELb8F2eg/QZbmxw4NYTi5F530A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PalnCE2zczrXWKM5c7rt9x4YAHuWoPcBXqDw48yzZb4p5hpmFJUnCFjwRglb?= =?us-ascii?Q?JLiHtoH9F/d2DubUCINehPN+4n3O2KEg6RRlQh8/H4hGSK1mSSmybWXQO+ch?= =?us-ascii?Q?StLr6RHNnfFLqyKuN14RLW0qPI/GZl5xZa5BdtX1+LWIGR2KCx4O3WDa31Uo?= =?us-ascii?Q?GDYEQZMUmMfTVuHrOAZaKY2oY6596VVJhwS0fezoG958qBgNgNWMW/nbrpMj?= =?us-ascii?Q?QBBxlCstCKkQtQGvV4CjPk8axRlSOEc2p6zLbG9eb2qMtfbLwjg1XvFFRkYQ?= =?us-ascii?Q?T/c12Vcka5xNlOSdRkdjLUz2PCl5Lj6NhCXLzsasdUdyigyU0jHrLLR5T8Ci?= =?us-ascii?Q?/GUaw9OgHNiXQsHDazpOCz9T+O89N1yBJEezhGTWSoIUfk3Hk57pMmCzdsJA?= =?us-ascii?Q?8VDhVHkAfzOprTS5HKwrfhqQMj0Lr3UjfF0fLjz9QdZKgIGUOuh1qfhtcEE7?= =?us-ascii?Q?VJogKGgn3H3WQswpXPNczdU5/uFxd23dtqrh7tup2x910pEsVG+BZlKNwOa7?= =?us-ascii?Q?1vCapsMqbauWZUYFzHPXXBOqfxfEDgeFcHfO9dCDTa1qsxwcTaugogWjGIDS?= =?us-ascii?Q?ImFcPKg4VGzO1Zyqv7cH/3ISpUMU0PTStWKhg5Lx7/qXQMVlLZ9hKYuvFRhN?= =?us-ascii?Q?rYVTCEVh2z7B9Jo7wtNWcC7+0J8jqLcuuzdOFS18kfOvfBKx9cFN3jikcdaf?= =?us-ascii?Q?ur4Q1zOoBjW3ErqYb6ISfh2x4Th8ZBq5wGJ0bQ1sVFscXsHEDXyMoIfI8/zq?= =?us-ascii?Q?g8UkjWLiqknYgsvWJ/MEuM/2MWAaw8er+MjkPRFmWMy3WSJiDpPXMV0Lt915?= =?us-ascii?Q?/F1DYk41hba/DqyaFrxLIoCimadagua7R/sdlpAD8q2MZjmrRthDjH1EZZ/q?= =?us-ascii?Q?xWhjEAXBaPUo+Ph039u2ptwSW02SrsnnggSygJ3IMIUpAU0cJOr8v4u2r2fD?= =?us-ascii?Q?LI0I8En5G+TtpXUvF1PnyUzZxlfmaZ0XfB5gOYDRzmDExVq0hqj1AyOYIn4b?= =?us-ascii?Q?Mmh4nK0I7qgxIlt5S9KFBMg1yvfvAngPQWNscGAATsiYxcMPAsSOFkaBRseS?= =?us-ascii?Q?MNbsiw6weF5zzuoQRt9K72rlnHpkrEbDpi/q190VoJIlwmgiTT5XdHgwlbP0?= =?us-ascii?Q?4qJwRBoHvsOc+E527WBWavkj8h3YFUbmjtbLu881vwpf5IWHsneGx3lVazhV?= =?us-ascii?Q?ni4wG3P++AeUmtpt2+T5ChH3z+JCiaRxzuPIwBmfPQepIu+uENoFNbH2DIIN?= =?us-ascii?Q?8cYYkGB4VszlO3KNeFcRl+NoAroXvzGTxW19Lg8EYc6C8F8WhbM1PpT1ec85?= =?us-ascii?Q?MA+6M3fQ25LmXVcbLnn850YzmII6hQUhYVmfq8gn08IKNCErLWIiNd3KBZQr?= =?us-ascii?Q?e+9QEL2VCBDkCsAfqA+/OqUO2odn41DiYVH9geFWVeYU7erbmKgukK7jpo/Y?= =?us-ascii?Q?OTKZw6A7JZnTcaNkIWmDz6HSUTKSAHD44VuLYWuxmqFnzL2J50CbmWhj9RLn?= =?us-ascii?Q?C2HZOSm8dE5urilddUgSIabKYWy290UDwV1nckdx2phUp+LYJRqGGKm67tEp?= =?us-ascii?Q?O43YqoMeVWL28XasDIcrNo9n62VT7tQxGhxNGiDQJymzxBy21FVtodIOuIlr?= =?us-ascii?Q?5bb+vPRs+AwRPQoyJ8OgDWc=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: bed244cf-930f-4a1b-53b8-08dddfe5c8d1 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 12:33:36.7513 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S6dnNd9eZXjhBVVN3lx7R8+HEGHcsT+joEOIrxJ5fEIgB7SvcHOqHEMvnYrlKvFDVxF1kl0DR6xDXNBjsRD6pBEEGTHc/NHgg9iuJetU5+Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 Content-Type: text/plain; charset="utf-8" The spinand driver do 3 type of dirmap requests: * read/write whole flash page without oob (offs =3D 0, len =3D page_size) * read/write whole flash page including oob (offs =3D 0, len =3D page_size + oob_size) * read/write oob area only (offs =3D page_size, len =3D oob_size) The trick is: * read/write a single "sector" * set a custom sector size equal to offs + len. It's a bit safer to rounded up "sector size" value 64. * set the transfer length equal to custom sector size And it works! Thus we can remove a dirty hack that reads flash page settings from SNFI registers during driver startup. Also airoha_snand_adjust_op_size() function becomes unnecessary. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 136 ++++++---------------------------- 1 file changed, 21 insertions(+), 115 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index a02dc6de5406..4974608423b7 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -223,13 +223,6 @@ struct airoha_snand_ctrl { struct regmap *regmap_ctrl; struct regmap *regmap_nfi; struct clk *spi_clk; - - struct { - size_t page_size; - size_t sec_size; - u8 sec_num; - u8 spare_size; - } nfi_cfg; }; =20 static int airoha_snand_set_fifo_op(struct airoha_snand_ctrl *as_ctrl, @@ -488,56 +481,6 @@ static int airoha_snand_nfi_init(struct airoha_snand_c= trl *as_ctrl) SPI_NFI_ALL_IRQ_EN, SPI_NFI_AHB_DONE_EN); } =20 -static int airoha_snand_nfi_config(struct airoha_snand_ctrl *as_ctrl) -{ - int err; - u32 val; - - err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, - SPI_NFI_FIFO_FLUSH | SPI_NFI_RST); - if (err) - return err; - - /* auto FDM */ - err =3D regmap_clear_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_AUTO_FDM_EN); - if (err) - return err; - - /* HW ECC */ - err =3D regmap_clear_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_HW_ECC_EN); - if (err) - return err; - - /* DMA Burst */ - err =3D regmap_set_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_DMA_BURST_EN); - if (err) - return err; - - /* sec num */ - val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); - err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, - SPI_NFI_SEC_NUM, val); - if (err) - return err; - - /* enable cust sec size */ - err =3D regmap_set_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, - SPI_NFI_CUS_SEC_SIZE_EN); - if (err) - return err; - - /* set cust sec size */ - val =3D FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, - as_ctrl->nfi_cfg.sec_size + - as_ctrl->nfi_cfg.spare_size); - return regmap_update_bits(as_ctrl->regmap_nfi, - REG_SPI_NFI_SECCUS_SIZE, - SPI_NFI_CUS_SEC_SIZE, val); -} - static bool airoha_snand_is_page_ops(const struct spi_mem_op *op) { if (op->addr.nbytes !=3D 2) @@ -570,26 +513,6 @@ static bool airoha_snand_is_page_ops(const struct spi_= mem_op *op) } } =20 -static int airoha_snand_adjust_op_size(struct spi_mem *mem, - struct spi_mem_op *op) -{ - size_t max_len; - - if (airoha_snand_is_page_ops(op)) { - struct airoha_snand_ctrl *as_ctrl; - - as_ctrl =3D spi_controller_get_devdata(mem->spi->controller); - max_len =3D as_ctrl->nfi_cfg.sec_size; - max_len +=3D as_ctrl->nfi_cfg.spare_size; - max_len *=3D as_ctrl->nfi_cfg.sec_num; - - if (op->data.nbytes > max_len) - op->data.nbytes =3D max_len; - } - - return 0; -} - static bool airoha_snand_supports_op(struct spi_mem *mem, const struct spi_mem_op *op) { @@ -640,8 +563,8 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 - bytes =3D as_ctrl->nfi_cfg.sec_num * - (as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size); + /* minimum oob size is 64 */ + bytes =3D round_up(offs + len, 64); =20 /* * DUALIO and QUADIO opcodes are not supported by the spi controller, @@ -727,7 +650,14 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem= _dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - /* number of bytes to read via dma (whole flash page + oob) */ + /* + * Setup transfer length + * --------------------- + * The following rule MUST be met: + * transfer_length =3D + * =3D NFI_SNF_MISC_CTL2.read_data_byte_number =3D + * =3D NFI_CON.sector_number * NFI_SECCUS.custom_sector_size + */ err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL2, SPI_NFI_READ_DATA_BYTE_NUM, @@ -825,8 +755,8 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 - bytes =3D as_ctrl->nfi_cfg.sec_num * - (as_ctrl->nfi_cfg.sec_size + as_ctrl->nfi_cfg.spare_size); + /* minimum oob size is 64 */ + bytes =3D round_up(offs + len, 64); =20 opcode =3D desc->info.op_tmpl.cmd.opcode; switch (opcode) { @@ -906,7 +836,14 @@ static ssize_t airoha_snand_dirmap_write(struct spi_me= m_dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - /* number of bytes to write via dma (whole flash page + oob) */ + /* + * Setup transfer length + * --------------------- + * The following rule MUST be met: + * transfer_length =3D + * =3D NFI_SNF_MISC_CTL2.write_data_byte_number =3D + * =3D NFI_CON.sector_number * NFI_SECCUS.custom_sector_size + */ err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL2, SPI_NFI_PROG_LOAD_BYTE_NUM, @@ -1062,7 +999,6 @@ static int airoha_snand_exec_op(struct spi_mem *mem, } =20 static const struct spi_controller_mem_ops airoha_snand_mem_ops =3D { - .adjust_op_size =3D airoha_snand_adjust_op_size, .supports_op =3D airoha_snand_supports_op, .exec_op =3D airoha_snand_exec_op, .dirmap_create =3D airoha_snand_dirmap_create, @@ -1087,36 +1023,6 @@ static int airoha_snand_setup(struct spi_device *spi) return 0; } =20 -static int airoha_snand_nfi_setup(struct airoha_snand_ctrl *as_ctrl) -{ - u32 val, sec_size, sec_num; - int err; - - err =3D regmap_read(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, &val); - if (err) - return err; - - sec_num =3D FIELD_GET(SPI_NFI_SEC_NUM, val); - - err =3D regmap_read(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, &val); - if (err) - return err; - - sec_size =3D FIELD_GET(SPI_NFI_CUS_SEC_SIZE, val); - - /* init default value */ - as_ctrl->nfi_cfg.sec_size =3D sec_size; - as_ctrl->nfi_cfg.sec_num =3D sec_num; - as_ctrl->nfi_cfg.page_size =3D round_down(sec_size * sec_num, 1024); - as_ctrl->nfi_cfg.spare_size =3D 16; - - err =3D airoha_snand_nfi_init(as_ctrl); - if (err) - return err; - - return airoha_snand_nfi_config(as_ctrl); -} - static const struct regmap_config spi_ctrl_regmap_config =3D { .name =3D "ctrl", .reg_bits =3D 32, @@ -1190,7 +1096,7 @@ static int airoha_snand_probe(struct platform_device = *pdev) ctrl->setup =3D airoha_snand_setup; device_set_node(&ctrl->dev, dev_fwnode(dev)); =20 - err =3D airoha_snand_nfi_setup(as_ctrl); + err =3D airoha_snand_nfi_init(as_ctrl); if (err) return err; =20 --=20 2.50.1