From nobody Sat Oct 4 04:59:52 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21E9A2D837B; Wed, 20 Aug 2025 07:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755675797; cv=none; b=tKB1m1n6afZsNm+scjmKhJdfQSU+bBb6Eb+Pv5gUD7rV7Q3BrolGfxv+hv2L6S644Lwi7mNfW1IjybvV8A+kkAAPMglJX8nIcurW+qrH6RuTYsFgtikUpejh9y30yR3BobOUhilq8D9+3cB2axOfyj6v36ILGv+DP76QXhFU0jg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755675797; c=relaxed/simple; bh=pjGZKvmGxMF/qKgMyngeTm7Z3aNgduzo0JlXz+X9aA8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CyuIaMCu6HyBICOKmKLV6r9lqUECcf6NZwzSxERb0x8xMji8U8dK33T+b4sDvZUR2a29SVd+uSCIIZzrlq8oSDuDqZtewHhUIyEuZLwspkmCM0I181sMeHBn5ND6FeGPW3DMBUzysCL383H3mkBmtTLz/bS3IxMoczR7DswuT+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=REX7/w4K; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="REX7/w4K" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 7265E20CCB; Wed, 20 Aug 2025 09:43:13 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id lVV4-Maa9Sph; Wed, 20 Aug 2025 09:43:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1755675792; bh=pjGZKvmGxMF/qKgMyngeTm7Z3aNgduzo0JlXz+X9aA8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=REX7/w4Kym5QWUu+pglh0MceOIHZE1MgohFpYm7lv00/iHZGJhtFA37tWI07YFLmb bB0/qfYYqrDNGskh96Bb2/2fQppKFTl2xppt4rzLyQEraS8ATJhQierMeg3XU+OEe9 nU4PcJq0py7IIzzrEVfJl9DIrTqslRWNI/SYaJMy1riog3QYnMVPI38yWbTvjWWUlp kDS54fxZqQn5vmaQxRH+YIyhATjBVRzY2bYI9rvq9kiSAT3J159wmQUy1SJlUXJKDo gorHC/l2FFK9hRqaQXJ71kKy7kjKxCBVFOA+vbPXfsHDTVY+LKW88aH+05ePGeQEME cpxR4hML4wATQ== From: Yao Zi To: Drew Fustini , Guo Ren , Fu Wei , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Michal Wilczynski Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Icenowy Zheng , Han Gao , Han Gao , Yao Zi , stable@vger.kernel.org Subject: [PATCH v2 1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly Date: Wed, 20 Aug 2025 07:42:43 +0000 Message-ID: <20250820074245.16613-2-ziyao@disroot.org> In-Reply-To: <20250820074245.16613-1-ziyao@disroot.org> References: <20250820074245.16613-1-ziyao@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The reset controller driver for the TH1520 was using the generic compatible string "thead,th1520-reset". However, the controller described by this compatible only manages the resets for the Video Output (VO) subsystem. Using a generic compatible is confusing as it implies control over all reset units on the SoC. This could lead to conflicts if support for other reset controllers on the TH1520 is added in the future like AP. Let's introduce a new compatible string, "thead,th1520-reset-vo", to explicitly scope the controller to VO-subsystem. The old one is marked as deprecated. Fixes: 30e7573babdc ("dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Contr= oller") Cc: stable@vger.kernel.org Reported-by: Icenowy Zheng Co-developed-by: Michal Wilczynski Signed-off-by: Michal Wilczynski Signed-off-by: Yao Zi --- .../bindings/reset/thead,th1520-reset.yaml | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yam= l b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml index f2e91d0add7a..3930475dcc04 100644 --- a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml @@ -15,8 +15,11 @@ maintainers: =20 properties: compatible: - enum: - - thead,th1520-reset + oneOf: + - enum: + - thead,th1520-reset-vo + - const: thead,th1520-reset + deprecated: true =20 reg: maxItems: 1 @@ -33,12 +36,8 @@ additionalProperties: false =20 examples: - | - soc { - #address-cells =3D <2>; - #size-cells =3D <2>; - rst: reset-controller@ffef528000 { - compatible =3D "thead,th1520-reset"; - reg =3D <0xff 0xef528000 0x0 0x1000>; + reset-controller@ffef528000 { + compatible =3D "thead,th1520-reset-vo"; + reg =3D <0xef528000 0x1000>; #reset-cells =3D <1>; - }; }; --=20 2.50.1 From nobody Sat Oct 4 04:59:52 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0400A2D8DDD; Wed, 20 Aug 2025 07:43:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755675804; cv=none; b=n7IKz55ji9iq75lif9rrXl+2NNK/j+UiwHwetpfQggh78KMDL2Ib+ofenxKNOFUo1Dc8bHaUlAQ97gsHchXC9fqJgpieh956/BIO3eBGQY8Fyg+L7eVMzoHoYQm/lzcQvXRBS/rnsMrP7wdWcLFmiI0UKPi+UyEZoTXlcz8DnMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755675804; c=relaxed/simple; bh=Im+oemJDXWL80mEoHEC/AYrA40M35zJiJWeGpLm6Pjk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KdftZhULuotSLsYFttCT5dro41frQlAet7IwVfZ84KcA6yXH/S0IJoxAFs6kiRDjqSVgPw9SuaRJcmwP84kF2hRusRLlf4Dv8vpMNSuns1s7PbqZfXmd6wpI6YT0cE/EtzWzkNW01tFnkRl5Wxndoqs33/8eFDsgfb6+S3oKlxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=jE1pS826; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="jE1pS826" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 9879320D9F; Wed, 20 Aug 2025 09:43:21 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WAWoSrNxQhzA; Wed, 20 Aug 2025 09:43:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1755675799; bh=Im+oemJDXWL80mEoHEC/AYrA40M35zJiJWeGpLm6Pjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jE1pS826qnrHeJew7gQ5Uci75z55bkn53V4TQ07BBr6WL5l5ScF4AtWIfe4kNYSvN H7WAu8z1V44qJbG4+Rl1ShJqaQL6oX5Yln898RzQA7AVw6HNRk3i/EfdJrNpPizHU+ 4gkMoHqxl5DuoSlAV7Wo063TK4usv1offxnkF9Z2oyjYPM4EdJlQp43nmeQdcC/KKk Y/H34MOxBQaobpWLMNVhDZngQxPIIG0ZAaefsgrZBHBQy2gJ3CujlNYirBAMs3N0l7 uomlqn9r8z2oNPQRkpmUtHkjkWzaOk2egOWt0DCVS+QxbFLfKuI7qIy2t5r5ZZ3rm+ iieguHInu0mdw== From: Yao Zi To: Drew Fustini , Guo Ren , Fu Wei , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Michal Wilczynski Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Icenowy Zheng , Han Gao , Han Gao , Yao Zi Subject: [PATCH v2 2/3] reset: th1520: Support the new compatible for VO-subsystem controller Date: Wed, 20 Aug 2025 07:42:44 +0000 Message-ID: <20250820074245.16613-3-ziyao@disroot.org> In-Reply-To: <20250820074245.16613-1-ziyao@disroot.org> References: <20250820074245.16613-1-ziyao@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The reset controller for VO-subsystem is previously described with compatible "thead,th1520-reset", which is misleading since it implies control over all reset units on the SoC. A new compatible, "thead,th1520-reset-vo", has been introduced to describe the controller's scope explicitly, while the old one has been deprecated. Let's support the compatible in the driver. Fixes: 4a65326311ab ("reset: thead: Add TH1520 reset controller driver") Reported-by: Icenowy Zheng Co-developed-by: Michal Wilczynski Signed-off-by: Michal Wilczynski Signed-off-by: Yao Zi --- drivers/reset/reset-th1520.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/reset/reset-th1520.c b/drivers/reset/reset-th1520.c index 14d964a9c6b6..4c8ea35b174e 100644 --- a/drivers/reset/reset-th1520.c +++ b/drivers/reset/reset-th1520.c @@ -154,6 +154,7 @@ static int th1520_reset_probe(struct platform_device *p= dev) =20 static const struct of_device_id th1520_reset_match[] =3D { { .compatible =3D "thead,th1520-reset" }, + { .compatible =3D "thead,th1520-reset-vo" }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, th1520_reset_match); --=20 2.50.1 From nobody Sat Oct 4 04:59:52 2025 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B9EC2D838A; Wed, 20 Aug 2025 07:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755675852; cv=none; b=KT297im4v2jdtDZGfzpIx3GHmcalmBjaQ/oJze68bjlmI7ACHneh437b68pCyoGMKnoeeQgxuxUm6CB/NfUX1i4IrsMK6dcVFMfUCfzIND4/BYfNvRE+4WsPD9q9WFLo2hPbTg9xA6NAJ9iyIfMpjMigSpMEhidwnAmWBugKWtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755675852; c=relaxed/simple; bh=tGfL13W8ti4YSK/nAW99ULHcrHSz0Etv9XyPU1NgCnw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZeVZigr8CY3SRU6j08ooZR7l9XftWf5b6AleY/2JpZoRGN7+rEjl+FfPy3qg/6PpNztmwShpkY+JKUOwLu6LPQKLO+o4hbKTdurzD/uCu70zb6Q+vo7IZVMWT9bQUviU87NFJ5+3ejXzFmkRbD1vc5Ym0Pg08vmg1ApEVAAL4zY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=Ra8vI+iF; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="Ra8vI+iF" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id D475925D1A; Wed, 20 Aug 2025 09:44:09 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Eg5zdjj6xz1G; Wed, 20 Aug 2025 09:44:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1755675849; bh=tGfL13W8ti4YSK/nAW99ULHcrHSz0Etv9XyPU1NgCnw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Ra8vI+iF6/xFxBmwuQMo1Tp25pzmLZs19io6wRgsYmtwhHkMoQI50B/4MA3p8jjxl Jk5bJsI6WU1J1Wxx6Z34I9uPrqvvnF0RXPMrIq5prPv1WHl2dKUph/Ua5q3Dd+1ys/ 3VjVEMUd3NSnkYal7EA62k34RHAi8M7BIcaSXeR+XWjrDEjLtqNgLrAOcnvvL1d/uj /bEhFxCY41MnhNQbL/Chs0rQO60nNtJA8Qr9bTCFLyFTQL4LicDpiP/glGFQ8K1Hk6 UcR16pT2xtMeG3qV1PwWtJ8rRTnGMCqJKdmasT9jlKgUFsxY0I8OQjGsjh8YubUTWC o7VO49zI0d8Jg== From: Yao Zi To: Drew Fustini , Guo Ren , Fu Wei , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Michal Wilczynski Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Icenowy Zheng , Han Gao , Han Gao , Yao Zi Subject: [PATCH v2 3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520 Date: Wed, 20 Aug 2025 07:42:45 +0000 Message-ID: <20250820074245.16613-4-ziyao@disroot.org> In-Reply-To: <20250820074245.16613-1-ziyao@disroot.org> References: <20250820074245.16613-1-ziyao@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The only reset-controller described in TH1520's SoC devicetree takes control of reset signals in VO subsystem, while using a generic "thead,th1520-reset" compatible that may imply control over the whole SoC. To avoid such confusion, let's replace the compatible with the new introduced "thead,th1520-reset-vo" that explicitly describes the controller's scope. The controller's label is updated as well. Fixes: 1b136de08b5f ("riscv: dts: thead: Introduce reset controller node") Reported-by: Icenowy Zheng Co-developed-by: Michal Wilczynski Signed-off-by: Michal Wilczynski Signed-off-by: Yao Zi --- arch/riscv/boot/dts/thead/th1520.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/th= ead/th1520.dtsi index 03f1d7319049..025402f6aa21 100644 --- a/arch/riscv/boot/dts/thead/th1520.dtsi +++ b/arch/riscv/boot/dts/thead/th1520.dtsi @@ -235,7 +235,7 @@ aon: aon { compatible =3D "thead,th1520-aon"; mboxes =3D <&mbox_910t 1>; mbox-names =3D "aon"; - resets =3D <&rst TH1520_RESET_ID_GPU_CLKGEN>; + resets =3D <&rst_vo TH1520_RESET_ID_GPU_CLKGEN>; reset-names =3D "gpu-clkgen"; #power-domain-cells =3D <1>; }; @@ -502,8 +502,8 @@ clk: clock-controller@ffef010000 { #clock-cells =3D <1>; }; =20 - rst: reset-controller@ffef528000 { - compatible =3D "thead,th1520-reset"; + rst_vo: reset-controller@ffef528000 { + compatible =3D "thead,th1520-reset-vo"; reg =3D <0xff 0xef528000 0x0 0x4f>; #reset-cells =3D <1>; }; --=20 2.50.1