From nobody Sat Oct 4 04:59:43 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E54622A7F2; Wed, 20 Aug 2025 06:25:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755671152; cv=none; b=A+9Dgchep7AwOuzMKbRl0c8wBMQrzyvAGk3nZ8xkwNuXShsqpKIsV7OT8jjN5Xu6PuS8a3DSC5BvcvfMtIaGByo81efeMqqtvitMFNOOLgUg73nAN9chKEiU9gTkgduQ83SsZsX6Zd7oKWfvsvpTzhILiDW+nK2wXVSiecfVpRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755671152; c=relaxed/simple; bh=E1nlm4ZXGFbHifT6NZwsf80Vayen/HI9GHmbhZPhO7k=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=tmQH1dKq6PQArA3gDakfvgBHohbfopUMV7GXkFKBnz+0u5fBSc0bBoVaYNJDlgZLmHPHKq9sd4f45uSaGQJFA/TVBAxFKsQA1Yk2nUqax2M/CdzXnG+RXVjx646HK3vtklUTAguCWrzO44rPjFGbmxZSLZa5F/uE65td6z1SamU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 7bd9d41e7d8e11f0b29709d653e92f7d-20250820 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NO_NAME, HR_CTE_8B, HR_CTT_MISS HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME, HR_SJ_LANG HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE, HR_SJ_PHRASE_LEN HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME, IP_TRUSTED SRC_TRUSTED, DN_TRUSTED, SA_EXISTED, SN_EXISTED, SPF_NOPASS DKIM_NOPASS, DMARC_NOPASS, CIE_BAD, CIE_GOOD, CIE_GOOD_SPF GTI_FG_BS, GTI_RG_INFO, GTI_C_BU, AMN_T1, AMN_GOOD AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:e636fa68-9d02-4af0-a420-e9bc43ed3e55,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:e636fa68-9d02-4af0-a420-e9bc43ed3e55,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:ffb03ffa128f39143bd09c13b159062a,BulkI D:250820142542ZBWU6064,BulkQuantity:0,Recheck:0,SF:17|19|24|38|44|66|78|10 2,TC:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,B EC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: 7bd9d41e7d8e11f0b29709d653e92f7d-20250820 X-User: duanchenghao@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 798464706; Wed, 20 Aug 2025 14:25:36 +0800 From: Chenghao Duan To: ast@kernel.org, bjorn@kernel.org, pulehui@huawei.com, puranjay@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Cc: daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, alex@ghiti.fr, bpf@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, duanchenghao@kylinos.cn Subject: [PATCH] riscv: bpf: Fix uninitialized symbol 'retval_off' Date: Wed, 20 Aug 2025 14:25:20 +0800 Message-Id: <20250820062520.846720-1-duanchenghao@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In __arch_prepare_bpf_trampoline(), retval_off is only meaningful when save_ret is true, so the current logic is correct. However, in the original logic, retval_off is only initialized under certain conditions, which may cause a build warning. So initialize retval_off unconditionally to fix it. Signed-off-by: Chenghao Duan --- arch/riscv/net/bpf_jit_comp64.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/riscv/net/bpf_jit_comp64.c b/arch/riscv/net/bpf_jit_comp6= 4.c index 10e01ff06312..49bbda8372b0 100644 --- a/arch/riscv/net/bpf_jit_comp64.c +++ b/arch/riscv/net/bpf_jit_comp64.c @@ -1079,10 +1079,9 @@ static int __arch_prepare_bpf_trampoline(struct bpf_= tramp_image *im, stack_size +=3D 16; =20 save_ret =3D flags & (BPF_TRAMP_F_CALL_ORIG | BPF_TRAMP_F_RET_FENTRY_RET); - if (save_ret) { + if (save_ret) stack_size +=3D 16; /* Save both A5 (BPF R0) and A0 */ - retval_off =3D stack_size; - } + retval_off =3D stack_size; =20 stack_size +=3D nr_arg_slots * 8; args_off =3D stack_size; --=20 2.25.1