From nobody Sat Oct 4 04:56:50 2025 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F18831A05E; Wed, 20 Aug 2025 12:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755694708; cv=none; b=SfMczAKtVurKirlKa5zR8Bw9teNR4yD62Kar/NERxcPC7IF5YjX+K7biuPHWhQX5HF5y6fmmBdfSkmyDfyxWkFeAKkYoUPz6u4+Z41aNtIeVQr6O+hxhwI89NQni6zNzvL8kd0LDW032AJH61R+6ifP8W4bmrXF7vUJpCnaSsEM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755694708; c=relaxed/simple; bh=ZWkXltt1L+/SAEorakbT4Etb8UoMMCyxdSrJDjkotCU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CzzQ3hqvLBM4IVPRGJyQhfNKPDteB81SZDjTdlTC1RIb3JBRiW8/E/b/dyeWNpIutAg3tL1v1+jtTDL56Y0/UNgRFZF2vSUOADlWUS0z33qrV1jXYnTI9e2bhtCIZHZvS3DmankmN9OFkybZrOKwwKYX2AXizki+xUBQk3arFQU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=rKhOYCOl; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rKhOYCOl" Received: from [192.168.1.106] (mob-5-90-62-213.net.vodafone.it [5.90.62.213]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D2C05710; Wed, 20 Aug 2025 14:57:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1755694643; bh=ZWkXltt1L+/SAEorakbT4Etb8UoMMCyxdSrJDjkotCU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=rKhOYCOlYMtQS/KEJLoVP4RvymF25LPHnFNOpZ+S09fF9gNCHXdKgxHrqNUHUnxmJ fuC2/0v7C3ZcwY+kEtQQRoW8WlKlOieVdzwS6zpz4CUW8M0PkxQUz9PFZgAZaOYBZO svL7ChSJV83mWzfXGXeDPLEQJhSoCDIZ53Z3yQ0g= From: Jacopo Mondi Date: Wed, 20 Aug 2025 14:58:09 +0200 Subject: [PATCH v4 1/8] media: uapi: Introduce V4L2 extensible params Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250820-extensible-parameters-validation-v4-1-30fe5a99cb1f@ideasonboard.com> References: <20250820-extensible-parameters-validation-v4-0-30fe5a99cb1f@ideasonboard.com> In-Reply-To: <20250820-extensible-parameters-validation-v4-0-30fe5a99cb1f@ideasonboard.com> To: Dafna Hirschfeld , Laurent Pinchart , Keke Li , Mauro Carvalho Chehab , Heiko Stuebner , Dan Scally , Sakari Ailus Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jacopo Mondi X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=8630; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=ZWkXltt1L+/SAEorakbT4Etb8UoMMCyxdSrJDjkotCU=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBopcZqlxAVF9PpVw8EjHQ1UWZ5uTtM4usnFhrju /8KUDMXtfiJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaKXGagAKCRByNAaPFqFW PEGLD/9U+G2aN7uUhQea8OM3EBe2KvvBYGLmISIpMFg8i2jwo+8WBzz0NUb/w7TLsNMdpB9+EAB JLLmCGvqssWAN95ECiUJ2UiF6lDotXD3RAQ8dtEJpKeYsatL1VQAMN4tUAYKEK3xM/6gO/n0F7k WAG3+aUQdKJQyiWHZV0cEhd884pNU0AtFPBbDNcx4H1N5GhFSMYngWCtuzVDjUGEI7yzQcsCc36 4roP0ReE1qywq2AGu2I3WpzBnQuZurcibaAR8tjqd2Z7VW3pqAhvFJpzx9p2KqmKPdqSLcrikyR pfKg4iah47sZQH49zDQjnDalHzsugwmFwe7y9qA06x+R2euPtudAt4Zp+Kv1atshH0eSk3phSG9 NQs0OSR1uFxoaV2LZwZ8tJvQfFMGVU2pnSTgrkB90uUNwTHfsWAvgyZx9VRx7kCK7JWwkRq7Bp1 dCvn2wxga124J3FaAJNEUjFycDOsGXagHUpJmp0huwWiO9j6bC4LHvzpY6UMoKbH4UDapSbYzii yM38FAiFPPAlPsHefNUfigIkf4I3UNaxsmqhodlzKFjBTbwu8u7E2NWvQWvQ8F8u5Nz6tIxGuH7 Mdi74UuCfjpg0h6/dVYf5Eqjyloj9PaR1207DwpfrOA+PHJp6VZph3HJtp7I+hHchlF7xRZsusF n8Ap3v5yP8Kb+vg== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B Introduce v4l2-extensible-params.h in the Linux kernel uAPI. The header defines two types that all drivers that use the extensible parameters format for ISP configuration shall use to build their own format versions. The newly introduce type v4l2_params_block represent the header to be prepend to each ISP configuration block and the v4l2_params_buffer type represent the base type for the configuration parameters buffer. The v4l2_params_buffer represents the container for the ISP configuration data block. The generic type is defined with a 0-sized data block that specific ISP implementation shall properly size according to their capabilities. [Add v4l2_params_buffer_size()] Signed-off-by: Daniel Scally Reviewed-by: Daniel Scally Signed-off-by: Jacopo Mondi --- MAINTAINERS | 6 + include/uapi/linux/media/v4l2-extensible-params.h | 146 ++++++++++++++++++= ++++ 2 files changed, 152 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fe168477caa45799dfe07de2f54de6d6a1ce0615..67216d1e92d7ac81617bb3c4329= e4096aa205706 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -26380,6 +26380,12 @@ F: drivers/media/i2c/vd55g1.c F: drivers/media/i2c/vd56g3.c F: drivers/media/i2c/vgxy61.c =20 +V4L2 EXTENSIBLE PARAMETERS FORMAT +M: Jacopo Mondi +L: linux-media@vger.kernel.org +S: Maintained +F: include/uapi/linux/media/v4l2-extensible-params.h + VF610 NAND DRIVER M: Stefan Agner L: linux-mtd@lists.infradead.org diff --git a/include/uapi/linux/media/v4l2-extensible-params.h b/include/ua= pi/linux/media/v4l2-extensible-params.h new file mode 100644 index 0000000000000000000000000000000000000000..aca643f505f2705eeca7337f0dd= 182bcfd1ea60d --- /dev/null +++ b/include/uapi/linux/media/v4l2-extensible-params.h @@ -0,0 +1,146 @@ +/* SPDX-License-Identifier: ((GPL-2.0+ WITH Linux-syscall-note) OR MIT) */ +/* + * Video4Linux2 extensible configuration parameters base types + * + * Copyright (C) 2025 Ideas On Board Oy + * Author: Jacopo Mondi + */ + +#ifndef _UAPI_V4L2_PARAMS_H_ +#define _UAPI_V4L2_PARAMS_H_ + +#include +#include + +#define V4L2_PARAMS_FL_BLOCK_DISABLE (1U << 0) +#define V4L2_PARAMS_FL_BLOCK_ENABLE (1U << 1) + +/* + * Reserve the first 8 bits for V4L2_PARAMS_FL_* flag. + * + * Platform-specific flags should be defined as: + * #define PLATFORM_SPECIFIC_FLAG0 ((1U << V4L2_PARAMS_FL_PLATFORM_FLA= GS(0)) + * #define PLATFORM_SPECIFIC_FLAG1 ((1U << V4L2_PARAMS_FL_PLATFORM_FLA= GS(1)) + */ +#define V4L2_PARAMS_FL_PLATFORM_FLAGS(n) ((n) + 8) + +/** + * struct v4l2_params_block_header - V4L2 extensible parameters block head= er + * + * This structure represents the common part of all the ISP configuration + * blocks. Each parameters block shall embed an instance of this structure= type + * as its first member, followed by the block-specific configuration data.= The + * driver inspects this common header to discern the block type and its si= ze and + * properly handle the block content by casting it to the correct block-sp= ecific + * type. + * + * The @type field is one of the values enumerated by each platform-specif= ic ISP + * block types which specifies how the data should be interpreted by the d= river. + * The @size field specifies the size of the parameters block and is used = by the + * driver for validation purposes. + * + * The @flags field is a bitmask of per-block flags V4L2_PARAMS_FL_* and + * platform-specific flags specified by the platform-specific header. + * + * Documentation of the platform-specific flags handling is specified by t= he + * platform-specific block header type: + * + * - Rockchip RkISP1: :c:type:`rkisp1_ext_params_block_type` + * - Amlogic C3: :c:type:`c3_isp_params_block_type` + * + * Userspace is responsible for correctly populating the parameters block = header + * fields (@type, @flags and @size) and the block-specific parameters. + * + * @type: The parameters block type (platform-specific) + * @flags: A bitmask of block flags (platform-specific) + * @size: Size (in bytes) of the parameters block, including this header + */ +struct v4l2_params_block_header { + __u16 type; + __u16 flags; + __u32 size; +} __attribute__((aligned(8))); + +/** + * v4l2_params_buffer_size - Calculate size of v4l2_params_buffer for a pl= atform + * + * Users of the v4l2 extensible parameters will have differing sized data = arrays + * depending on their specific parameter buffers. Drivers and userspace wi= ll + * need to be able to calculate the appropriate size of the struct to + * accommodate all ISP configuration blocks provided by the platform. + * This macro provides a convenient tool for the calculation. + * + * Each driver shall provide a definition of their extensible parameters + * implementation data buffer size. As an example: + * + * #define PLATFORM_BLOCKS_MAX_SIZE \ + * sizeof(platform_block_0) + \ + * sizeof(platform_block_1) + * + * #define PLATFORM_BUFFER_SIZE \ + * v4l2_params_buffer_size(PLATFORM_BLOCKS_MAX_SIZE) + * + * Drivers are then responsible for allocating buffers of the proper size + * by assigning PLATFORM_BUFFER_SIZE to the per-plane size of the videobuf2 + * .queue_setup() operation and userspace shall use PLATFORM_BUFFER_SIZE + * when populating the ISP configuration data buffer. + * + * @max_params_size: The total size of the ISP configuration blocks + */ +#define v4l2_params_buffer_size(max_params_size) \ + (offsetof(struct v4l2_params_buffer, data) + (max_params_size)) + +/** + * struct v4l2_params_buffer - V4L2 extensible parameters configuration + * + * This struct contains the configuration parameters of the ISP algorithms, + * serialized by userspace into a data buffer. Each configuration parameter + * block is represented by a block-specific structure which contains a + * :c:type:`v4l2_params_block_header` entry as first member. Userspace pop= ulates + * the @data buffer with configuration parameters for the blocks that it i= ntends + * to configure. As a consequence, the data buffer effective size changes + * according to the number of ISP blocks that userspace intends to configu= re and + * is set by userspace in the @data_size field. + * + * The parameters buffer is versioned by the @version field to allow modif= ying + * and extending its definition. Userspace shall populate the @version fie= ld to + * inform the driver about the version it intends to use. The driver will = parse + * and handle the @data buffer according to the data layout specific to the + * indicated version and return an error if the desired version is not + * supported. + * + * For each ISP block that userspace wants to configure, a block-specific + * structure is appended to the @data buffer, one after the other without = gaps + * in between nor overlaps. Userspace shall populate the @data_size field = with + * the effective size, in bytes, of the @data buffer. + * + * Drivers shall take care of properly sizing of the extensible parameters + * buffer @data array. The v4l2_params_buffer type is defined with a + * flexible-array-member at the end, which resolves to a size of 0 bytes w= hen + * inspected with sizeof(struct v4l2_params_buffer). This of course is not + * suitable for neither buffer allocation in the kernel driver nor for pro= per + * handling in userspace of the @data buffer it has to populate. + * + * Drivers using this type in their userspace API definition are responsib= le + * for providing the exact definition of the @data buffer size using the + * v4l2_params_buffer_size() macro. The size shall be used + * by the driver for buffers allocation and by userspace for populating the + * @data buffer before queueing it to the driver + * + * Drivers that were already using extensible-parameters before the introd= uction + * of this file define their own type-convertible implementation of this + * type, see: + * - Rockchip RkISP1: :c:type:`rkisp1_ext_params_cfg` + * - Amlogic C3: :c:type:`c3_isp_params_cfg` + * + * @version: The parameters buffer version (platform-specific) + * @data_size: The configuration data effective size, excluding this header + * @data: The configuration data + */ +struct v4l2_params_buffer { + __u32 version; + __u32 data_size; + __u8 data[] __counted_by(data_size); +}; + +#endif /* _UAPI_V4L2_PARAMS_H_ */ --=20 2.50.1