From nobody Sat Oct 4 06:35:16 2025 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A679B2848BE for ; Tue, 19 Aug 2025 15:20:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755616841; cv=none; b=WfiNgQZhWjHPPFwxN+PUzTeKBqhwbt3lno+Fd8D6c+bMxk3Nlj3d8Z2ECO+u8eLcBt5FlNWc+Y7/X4OSfwyYTX3ZYXty70mkeXu+NiyLfmlp9dKum2Pjo0af6GplmL9CZUYHa7oiTOUZ6K9q2n5oU8BrSz2gbmhFcYYrD/DQUhw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755616841; c=relaxed/simple; bh=Mapi4qRO18JNApuqaFmvuJzPJiuchg7jIC/0OT7vifs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rm750J0dlMJwlyIdmqjLJz5eAWsI1yl7bakeGh3GXWg9HHHHtwVlv8ZJWesFGXvwFpZUAjSmqoM+8tRlUvx0maYqcHakt+w/7mfzge8mkA5FXye/NneaevIgMdv9uHDQU4U5avzfax8jJ8T5sSuoGITPWNSzo6mdgxBsxIPRTY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=smartx.com; spf=none smtp.mailfrom=smartx.com; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b=Z+bDDOE4; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=smartx.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=smartx.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b="Z+bDDOE4" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-b474e8d6d04so1400702a12.0 for ; Tue, 19 Aug 2025 08:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1755616839; x=1756221639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8j1xWi8yHO61hmZJR2yMfuKWLMhG/TRDNgL+UU0ZcBE=; b=Z+bDDOE4OkQ7j2GMMGtCq60C99LHGpkrUWJXg0JVbYaZ8Gge5jizq6yRAGevKCaCem ZpyYCSkrNEy1yLynNKtBLESZeF7dJCZCLGy5sfw4N1ugUVUQLrovUSk/LmS9mFV6HViB 0sq75sNUsU1/97gkL8TYsHBPdjD7U7bLQ/2pZNyGggxDTnehqgOckR1ZPmyWPDBXRMko LRlSlutSS7kDutOgyz826TBA2Up4O225ImwgXs9j3PFL+p03VaKxIM7xrrmtbCVQqD3y nsFy2CaBcPQIqko2uRTLFnnjjfHk14UK1Rp+K9Mf8e7R3YpQf6ztiSsmIgGekdWFT0iE Hixw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755616839; x=1756221639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8j1xWi8yHO61hmZJR2yMfuKWLMhG/TRDNgL+UU0ZcBE=; b=GYhQMcQzCUj746mrJkg854EflxXe+9Akbvn+Ad99td/5Er779Ai1oK28grPHUOS6TY Gbi4ABi4o6bE6sjQ2v1LyilqM+Rk750UmsIm6tdz8KfCEHDzpzleVLZwWjvtc28M1z3W b/AuFUqn2AYZRy6OUDoWnhd8fmg2naIfV0chupZFq4KwooNe/MhP1aFe2uoCKl45fBgh zqmrVgU5q9WH38x8+WOYDim9KyRSum2iUT2yoodx4V2PJmo6JyRmOdUXk0eh6Tq8CX04 tCa4ypB9OjQsQPVx3a6XuwZxSXSpIcZxyJXcP8oGuapxDNsWn2+XtNaH3ofH8sCypYA3 SF2w== X-Forwarded-Encrypted: i=1; AJvYcCWDxDu438mk5bQ3vhb701JI8rI8RM9E9iTQHm6f4YaCcYcer4JOeOlUB/wzNXG41pej+QiBOs5SJ6Bnx0I=@vger.kernel.org X-Gm-Message-State: AOJu0YwX7e7LpORsEJ97Ii93XR5XRxFp4fU8D6geg17O41oHhbyZRIo1 0zXYEcEbYcY5J/wg54cVZlZr/QxBjUNp6B+myNpT8iNNj/NXfWBKpz87GYRSomdOM8U= X-Gm-Gg: ASbGncsFwoxRjusuzroJ2CHAITZSpZf3bHsICAruo3CO8+pXvne2rVxtsWZUNJ1brKh uJDn/Sp5Xd56M9JqIB43OLFVHlExa6yme28O5iCdXGC0nyZW6B4WFWJhSr+p2jO8m+qwd0m68gP dxBe4Fr5agaEbIRNezODSnOYTY93dXea0GHOnvdCwJEEPbDBFbGocvIPb9jL1qBLug77Z0u1+/v jbPNB7quRaAxla75HQ2qIz36/o/iza5fS4TXGckBmPMmjJrjspU5rupxC+Vb5A54s5ALCuWwJOU q5bF4mM3PjaNonVubUKMVhA+Ahb9ZW3QE2EO6blcgAjOVp25y+6JwPo+tzGEyivb0nNyrVZXogU ve53/qE9fLd+6SiKjZTYgcTqyJNpc4iYqScLarjEuC3vUrSrw X-Google-Smtp-Source: AGHT+IGQa/VvJVkJJiZS7k0VwFXOIzUvBZHkf8rJfdNj/RWnzCw/C6sQLoqqWJnZZtjkykT3dQtZDA== X-Received: by 2002:a05:6a20:918a:b0:23f:fa6e:912a with SMTP id adf61e73a8af0-2430d395366mr4209750637.16.1755616838689; Tue, 19 Aug 2025 08:20:38 -0700 (PDT) Received: from localhost.localdomain ([193.246.161.124]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e7d546ce3sm2771227b3a.103.2025.08.19.08.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 08:20:38 -0700 (PDT) From: Lei Chen To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/3] Revert "x86: kvm: introduce periodic global clock updates" Date: Tue, 19 Aug 2025 23:20:25 +0800 Message-ID: <20250819152027.1687487-2-lei.chen@smartx.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250819152027.1687487-1-lei.chen@smartx.com> References: <20250819152027.1687487-1-lei.chen@smartx.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit 332967a3eac06f6379283cf155c84fe7cd0537c2. Commit 332967a3eac0 ("x86: kvm: introduce periodic global clock updates") introduced a 300s interval work to sync ntp corrections across all vcpus. Since commit 53fafdbb8b21 ("KVM: x86: switch KVMCLOCK base to monotonic raw clock"), kvmclock switched to mono raw clock, we can no longer take ntp into consideration. Signed-off-by: Lei Chen --- arch/x86/include/asm/kvm_host.h | 1 - arch/x86/kvm/x86.c | 25 ------------------------- 2 files changed, 26 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_hos= t.h index f19a76d3ca0e..e41e4fe91f5e 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1436,7 +1436,6 @@ struct kvm_arch { u64 master_kernel_ns; u64 master_cycle_now; struct delayed_work kvmclock_update_work; - struct delayed_work kvmclock_sync_work; =20 #ifdef CONFIG_KVM_HYPERV struct kvm_hv hyperv; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index a1c49bc681c4..399045a384d4 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -157,9 +157,6 @@ EXPORT_SYMBOL_GPL(report_ignored_msrs); unsigned int min_timer_period_us =3D 200; module_param(min_timer_period_us, uint, 0644); =20 -static bool __read_mostly kvmclock_periodic_sync =3D true; -module_param(kvmclock_periodic_sync, bool, 0444); - /* tsc tolerance in parts per million - default to 1/2 of the NTP threshol= d */ static u32 __read_mostly tsc_tolerance_ppm =3D 250; module_param(tsc_tolerance_ppm, uint, 0644); @@ -3439,20 +3436,6 @@ static void kvm_gen_kvmclock_update(struct kvm_vcpu = *v) KVMCLOCK_UPDATE_DELAY); } =20 -#define KVMCLOCK_SYNC_PERIOD (300 * HZ) - -static void kvmclock_sync_fn(struct work_struct *work) -{ - struct delayed_work *dwork =3D to_delayed_work(work); - struct kvm_arch *ka =3D container_of(dwork, struct kvm_arch, - kvmclock_sync_work); - struct kvm *kvm =3D container_of(ka, struct kvm, arch); - - schedule_delayed_work(&kvm->arch.kvmclock_update_work, 0); - schedule_delayed_work(&kvm->arch.kvmclock_sync_work, - KVMCLOCK_SYNC_PERIOD); -} - /* These helpers are safe iff @msr is known to be an MCx bank MSR. */ static bool is_mci_control_msr(u32 msr) { @@ -12327,8 +12310,6 @@ int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu) =20 void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu) { - struct kvm *kvm =3D vcpu->kvm; - if (mutex_lock_killable(&vcpu->mutex)) return; vcpu_load(vcpu); @@ -12339,10 +12320,6 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcp= u) vcpu->arch.msr_kvm_poll_control =3D 1; =20 mutex_unlock(&vcpu->mutex); - - if (kvmclock_periodic_sync && vcpu->vcpu_idx =3D=3D 0) - schedule_delayed_work(&kvm->arch.kvmclock_sync_work, - KVMCLOCK_SYNC_PERIOD); } =20 void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu) @@ -12722,7 +12699,6 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long= type) #endif =20 INIT_DELAYED_WORK(&kvm->arch.kvmclock_update_work, kvmclock_update_fn); - INIT_DELAYED_WORK(&kvm->arch.kvmclock_sync_work, kvmclock_sync_fn); =20 kvm_apicv_init(kvm); kvm_hv_init_vm(kvm); @@ -12830,7 +12806,6 @@ void kvm_arch_pre_destroy_vm(struct kvm *kvm) * is unsafe, i.e. will lead to use-after-free. The PIT also needs to * be stopped before IRQ routing is freed. */ - cancel_delayed_work_sync(&kvm->arch.kvmclock_sync_work); cancel_delayed_work_sync(&kvm->arch.kvmclock_update_work); =20 #ifdef CONFIG_KVM_IOAPIC --=20 2.44.0 From nobody Sat Oct 4 06:35:16 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C26A328750D for ; Tue, 19 Aug 2025 15:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755616846; cv=none; b=Sa79YWBUCE9qKVYg7Oo/+MGhNtnpskpHxpVndCUMuQwacXG8g59mjip2ve5jN6Ui8pM28qaLmfcW58R+gjUxhBARGYbXQ3gjXt/H8wAZys+X8e/FMD/n7aKS/ONf+yta4iLupa9HBfKjN7g1BY56IXRrEPaKe1bhsLg2LtilXnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755616846; c=relaxed/simple; bh=eUrR4NP72EKznEUzfrQ6RmdmdpoU6ltR0MbO4Ojo8Yg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S/hSdvSQR8oPh3wsYLkK+IqJng52ZAhX+EiqLin7DqlEjKxHQBnKRJ9uJ92N5Y/VwCu72Nj0oAAN1blJIVFBrgvRpTJa9ddNVf+E7PfykfiDnLPoonxMMCs5l3YuvXERLKpjkF++ytLPTd+WIAsHAMaggL9e2R2IqQY/DcrF3Vk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=smartx.com; spf=none smtp.mailfrom=smartx.com; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b=ruUSWohB; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=smartx.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=smartx.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b="ruUSWohB" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-76e2eb6d07bso4606413b3a.3 for ; Tue, 19 Aug 2025 08:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1755616843; x=1756221643; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2lSDpgMZajVKYY0uCSDb90s/Pt+KK5ftnBEiQn/IXqA=; b=ruUSWohBwJyBmTuk07GSs/ZfoQzBcQKPYXC6uxe7QBdDDx1AGvtYLFzR9CD+Df7frS H8TRuvEWThWuqjJ+WagRIC7pdf4qqASgV/43dpsHNe+FCEcTlvtRalCmJXo7rF9aiLs0 nakBLSEGBVe/ZGv1EHPNhPpTCWQ1+9D+CChpktKN2Vdy/ReMU8aHG2YwXHTNpl+3+Kgf s2VeJ+Zriwumk1C42Vc2Y5/UDZQLRd2iHQG6vWc+xDO1Krk/VZ1iTYtoTaY0Qp5gt2GA 3aifJ7xl0gt0afHyRQ1Ahf5aivpjTW8LbvnZp7lesKs3Y9vW/t+TDWke12YeCowcAMit /shQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755616843; x=1756221643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2lSDpgMZajVKYY0uCSDb90s/Pt+KK5ftnBEiQn/IXqA=; b=xJJ18ePvMrSu2bEsnZtaYjYN5DhTUr9P3+XK92YN9lfTrZfc5MWZuJC5kZpAu6NBZO 7OVKBF6KH/F5ymZ8V/f+WdmXvZLcr7QB/dQc37QpmDHC7B+KUSpPk2Z+etYkEQ05ifgW yVXb4Y9t3OpX9fsfTi0itpXXaoM68z00jj61886Bu2YoHIy/RH2lXtzYkG6qMk1B5vmr c1dzaNu4vxO/ghf7tYupo3hIwJFjqnEiE9z+KJwKMcTR7ajqCpt037pI4zXTFsT1vPMR QqiqTdUzdE+AMRlQdVrobqNaF2B+zF8qSOTiYj1WuUiANhDv+uBqtZDrekC9LR4fGW52 plOg== X-Forwarded-Encrypted: i=1; AJvYcCXrQs8CEYbbgnUOM9pay2HZlRsODgrUx2aNdm1E6P3zw0TBZ8ibyJgoZesTTVDtRlikgEDjqbEwPN+46Co=@vger.kernel.org X-Gm-Message-State: AOJu0YwwtlYqKbHfncoNcWw0V54YYKZbjji3QTm87S1vlxVOCi9gjWUa zEvzy5iuaEi0mEz2gcLnPLYeu8Qg+KhS7acydAW4pA6KKViXeZk+8V9CRugy1OcBOdY= X-Gm-Gg: ASbGncvM1UnEBhtrbAMwkTHAkJnjHvQ5+ol/qvSyBY/hjZSealz5vRF4B7YbQ08vUAG gGxoqxYtW3SfMs5OfPxZSDbb01KNFBlW+bvELvRRPTLYevbouErMYV2gxiuiDPpnNXehdgJQyOb K/XlWOuo7tfgjy6h5PbOqCB+63bituxxM3ExJHKabiMoyzDRgWr3oxLF8KDJvqRQfD9x2fUZt4K xKfOloim+dQZwQbAu8/G/eMvqW4D1cI6uXllL8/0iZhaaeL/7sAX2cXLEGJVukoIM97Yf837k7E 0PwjTSihRq9AL6qPTt4bVdtyUgPoJiIkO1OJiXBlpvOeZI6etj1zSOnYaeHyXvSjSW4jIdBzjvN M7C54PnvoBaHaIl5sv4M0FnWmEAyYw3YQzQeyJw== X-Google-Smtp-Source: AGHT+IET1fYCsA43ScR7Gl7o0QqueeZxCmd7tup9t4LlIjJFy4GsUQxo56fJU5lQZ9Qa7DgyluOoXg== X-Received: by 2002:a05:6a00:2d29:b0:76c:3751:dfbe with SMTP id d2e1a72fcca58-76e8114636cmr4179133b3a.24.1755616842845; Tue, 19 Aug 2025 08:20:42 -0700 (PDT) Received: from localhost.localdomain ([193.246.161.124]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e7d546ce3sm2771227b3a.103.2025.08.19.08.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 08:20:42 -0700 (PDT) From: Lei Chen To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/3] Revert "x86: kvm: rate-limit global clock updates" Date: Tue, 19 Aug 2025 23:20:26 +0800 Message-ID: <20250819152027.1687487-3-lei.chen@smartx.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250819152027.1687487-1-lei.chen@smartx.com> References: <20250819152027.1687487-1-lei.chen@smartx.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit 7e44e4495a398eb553ce561f29f9148f40a3448f. Commit 7e44e4495a39 ("x86: kvm: rate-limit global clock updates") intends to use a kvmclock_update_work to sync ntp corretion across all vcpus kvmclock, which is based on commit 0061d53daf26f ("KVM: x86: limit difference between kvmclock updates") Since kvmclock has been switched to mono raw, this commit can be reverted. Signed-off-by: Lei Chen --- arch/x86/include/asm/kvm_host.h | 1 - arch/x86/kvm/x86.c | 29 ++++------------------------- 2 files changed, 4 insertions(+), 26 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_hos= t.h index e41e4fe91f5e..0a1165f40ff1 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1435,7 +1435,6 @@ struct kvm_arch { bool use_master_clock; u64 master_kernel_ns; u64 master_cycle_now; - struct delayed_work kvmclock_update_work; =20 #ifdef CONFIG_KVM_HYPERV struct kvm_hv hyperv; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 399045a384d4..d526e9e285f1 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3404,22 +3404,14 @@ uint64_t kvm_get_wall_clock_epoch(struct kvm *kvm) * the others. * * So in those cases, request a kvmclock update for all vcpus. - * We need to rate-limit these requests though, as they can - * considerably slow guests that have a large number of vcpus. - * The time for a remote vcpu to update its kvmclock is bound - * by the delay we use to rate-limit the updates. + * The worst case for a remote vcpu to update its kvmclock + * is then bounded by maximum nohz sleep latency. */ - -#define KVMCLOCK_UPDATE_DELAY msecs_to_jiffies(100) - -static void kvmclock_update_fn(struct work_struct *work) +static void kvm_gen_kvmclock_update(struct kvm_vcpu *v) { unsigned long i; - struct delayed_work *dwork =3D to_delayed_work(work); - struct kvm_arch *ka =3D container_of(dwork, struct kvm_arch, - kvmclock_update_work); - struct kvm *kvm =3D container_of(ka, struct kvm, arch); struct kvm_vcpu *vcpu; + struct kvm *kvm =3D v->kvm; =20 kvm_for_each_vcpu(i, vcpu, kvm) { kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu); @@ -3427,15 +3419,6 @@ static void kvmclock_update_fn(struct work_struct *w= ork) } } =20 -static void kvm_gen_kvmclock_update(struct kvm_vcpu *v) -{ - struct kvm *kvm =3D v->kvm; - - kvm_make_request(KVM_REQ_CLOCK_UPDATE, v); - schedule_delayed_work(&kvm->arch.kvmclock_update_work, - KVMCLOCK_UPDATE_DELAY); -} - /* These helpers are safe iff @msr is known to be an MCx bank MSR. */ static bool is_mci_control_msr(u32 msr) { @@ -12698,8 +12681,6 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long= type) kvm->arch.hv_root_tdp =3D INVALID_PAGE; #endif =20 - INIT_DELAYED_WORK(&kvm->arch.kvmclock_update_work, kvmclock_update_fn); - kvm_apicv_init(kvm); kvm_hv_init_vm(kvm); kvm_xen_init_vm(kvm); @@ -12806,8 +12787,6 @@ void kvm_arch_pre_destroy_vm(struct kvm *kvm) * is unsafe, i.e. will lead to use-after-free. The PIT also needs to * be stopped before IRQ routing is freed. */ - cancel_delayed_work_sync(&kvm->arch.kvmclock_update_work); - #ifdef CONFIG_KVM_IOAPIC kvm_free_pit(kvm); #endif --=20 2.44.0 From nobody Sat Oct 4 06:35:16 2025 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01158284883 for ; Tue, 19 Aug 2025 15:20:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755616849; cv=none; b=uyIMzT1mpnEeqqomOOxAStrtsiKYeJeWGqDBhcdL5aZvLoz/UHX0aHLlCVN9ihOxS4mdE/uRkzJcLZboXr8XgE/5p4p54RfajedahjTIaaLaWsOPrVEyVkQHiHVyOcdJ1dOfezY+vTtM/QlIBkRzKE6hOwd8GyIJneoHyWlhuxU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755616849; c=relaxed/simple; bh=HomK9oR9q6PgZ6KTjkrL0ZAF4ixtQM3rr4sUa8Fd5OA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nn2RB8aisErmO5Tf7rvfKk3VYMlF0uGltJioWWUbeednmFsf3USSd643Suq5/0w/0xuHG8bru2CEHbuz4YXXkzJkHD3iABPdjCJGjxMLyvWbzbLaUIrh2b0Vkj4bYYHJzAPCu/pTOnWE8nRHkZL+9vRHZy2i42GB+iETw+3mKig= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=smartx.com; spf=pass smtp.mailfrom=smartx.com; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b=OHOjyYnP; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=smartx.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=smartx.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b="OHOjyYnP" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-32326793a85so4223607a91.1 for ; Tue, 19 Aug 2025 08:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1755616847; x=1756221647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A/CvHxpYU6aT1JADHVD5nQ98mr1UgBNDG9QHGX5cLNQ=; b=OHOjyYnP7YYoC+synqXCNnGbymEKbqsj2St7ImKmsPYoJLWXpioWCZPU0nsBhQB9Wr Q5uRk2Wgq/Oht8CWltecQ6B7dbd0LWa3LKdqvYOlNfW7jRbsxnflhKFeN/wQqVV9cfBf Y0RBPo1siNrOtV8dFlG29tbWiDbn2xorHBy53mrRYyufvlfWJV2UZvcxOeMWWGXSBdGc 1ao0bYK1I2ZvB+Juh2SWujynTmwWxqakfKEvxGQRuV+jnwsQIK5+zWZBXtcxiZHJRFBq QLAY6o1oVbzEZofvTnlVBIw0TP4IAL2FpG7uAbR8ZUxT1tdwR2Zldl39hqpLGoLiz+qQ j45g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755616847; x=1756221647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A/CvHxpYU6aT1JADHVD5nQ98mr1UgBNDG9QHGX5cLNQ=; b=fkbD8a62W7mIaUqgOONy20Kelgu17UfSuZ9qyw3IXDaMp4XZm2KAQt1iZMwH6PqRo+ plD7wW+YFqOguLZyjpLOPgyEN1WVf42ARsR9wjY0/sXfKdAQON0YBBscTUW7VHdtgJo4 bvJ+aejJ/j2LjLATVVySfzehKTa2lr6MMXG5xavHyd3JU1BVBzoWGUJydmMSMlU+PtZo uvk5oVT4ADu5RlhLCKIr2b0tNGUmgfrIlZNMnAi9RaMSHTMyxsdLBJHZCUhQabOeqIWQ e2Qdqlc8xsFWDsrX3cmnqgeInA9hC1rBLpcpynRtZsyAKOifMBGzeeO2W9AzkopbXQzF uSkQ== X-Forwarded-Encrypted: i=1; AJvYcCWPs1Nc8oUA499hvKQ/+V7qEIUCqKhYXKAjsGk7sP2aLen6vGxeBwP7Z6sYRch6XhgpjnLCXI8MFxtVW8A=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1PvOjiGIVfBukUoTMTieks+8P5KEM850NKZBqPybtEAaUgf4r 9wsOy2safn0TGBFOenESgBVZDtiZE0W3qKve9JpSC3rWnF86hgH65ABLoRJQQ3yv014= X-Gm-Gg: ASbGncsQIw7ITCV1hxBCimMO3zSS1azck68kpPp/69Dmo2AG1ZRbZkfFaHm4/KSgEZ2 BvZxVlCl6OXlS2oWOxzHO8rhEV8VRlXMgZbvj8rfcPeQCmOgCj6OQSDQwiZKW9MEdXarGa5fLYS kvV65arsoKYCRhfbhUuAtnzhPOTAMJRKtTod/cz20F2sEYJbwdJhCu1Vx1f55eUVAwB4RNGmVYt Okv73QNo96Gl2harJ8kfzgoD0qmD0HMISjBpk02kSmjh+WTf5GG/H4mKVY5MAh6QwcHA/JvCMaV kXfX4whb9DdxWjVc1BoOFMy7iG5OIadL2I8Tnk2F5qadmw+QuStvaEK0n4aXEkpEb8Ud0NTaNKG UEQQLHjF3vrrGJzxOI8qYuEgYtEO2lpjtFfO7u/5xhn47eCwW X-Google-Smtp-Source: AGHT+IENiUhPFrfHidhITb1KfiGNdBaldsZlAkjMOx4cUC6/Qm5aq9ey8Ddfx+brVMdYtBBvx3KQXg== X-Received: by 2002:a17:90b:2fc7:b0:31c:3651:2d18 with SMTP id 98e67ed59e1d1-32476a9509dmr4224591a91.16.1755616846994; Tue, 19 Aug 2025 08:20:46 -0700 (PDT) Received: from localhost.localdomain ([193.246.161.124]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e7d546ce3sm2771227b3a.103.2025.08.19.08.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 08:20:46 -0700 (PDT) From: Lei Chen To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 3/3] KVM: x86: remove comment about ntp correction sync for Date: Tue, 19 Aug 2025 23:20:27 +0800 Message-ID: <20250819152027.1687487-4-lei.chen@smartx.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250819152027.1687487-1-lei.chen@smartx.com> References: <20250819152027.1687487-1-lei.chen@smartx.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since vcpu local clock is no longer affected by ntp, remove comment about ntp correction sync for function kvm_gen_kvmclock_update. Signed-off-by: Lei Chen --- arch/x86/kvm/x86.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index d526e9e285f1..f85611f59218 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3399,9 +3399,7 @@ uint64_t kvm_get_wall_clock_epoch(struct kvm *kvm) /* * kvmclock updates which are isolated to a given vcpu, such as * vcpu->cpu migration, should not allow system_timestamp from - * the rest of the vcpus to remain static. Otherwise ntp frequency - * correction applies to one vcpu's system_timestamp but not - * the others. + * the rest of the vcpus to remain static. * * So in those cases, request a kvmclock update for all vcpus. * The worst case for a remote vcpu to update its kvmclock --=20 2.44.0