From nobody Sat Oct 4 06:37:05 2025 Received: from fllvem-ot03.ext.ti.com (fllvem-ot03.ext.ti.com [198.47.19.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A995B2AE66; Tue, 19 Aug 2025 13:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.245 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755608908; cv=none; b=e8Ziox4m/cbCG7uJSUdDJ8RGg2/THja9z0UT5bRUe+pbqOiUVx18CqMBnoqpVjTw7jcMuXvbE6yR3ldN05l8zkFIvz53dLb5FDIMvVvC5E43IdED7K/Ru7Fws80iPA2JVyMI1ubulGU5fvcz//I0ph5l5ZlFlCyGNQ9H8jV9344= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755608908; c=relaxed/simple; bh=R+2gPThMfHQBIp4Sff0U97ez0sG9B4cUDaHaX8fQwGU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Jc5CtQavo12HKFBYWDbON0LrO3V6oqPcf1dmiu8JB+cLUvM63C8HqKBPVQVNKzaSUBk9tsBhGYfStWNmii3KSGy66VKSNjIj3tln2Wu12L4m9YjGPR/+JXktgi/vRRS5IY7/Mx5KqcNLW0rUxJ+QdHiUX6mrfv+uVKhjXj5TydE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=MdiZtMud; arc=none smtp.client-ip=198.47.19.245 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="MdiZtMud" Received: from fllvem-sh03.itg.ti.com ([10.64.41.86]) by fllvem-ot03.ext.ti.com (8.15.2/8.15.2) with ESMTP id 57JD8Bpw2898662; Tue, 19 Aug 2025 08:08:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1755608891; bh=ECY0T638c1KZ6ND2Cy0e9ISpZNxxtCUFnZoH1Z46FKE=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=MdiZtMudLCmshUaB7biwqgMztd+MEetcuzowg61hBe8cfdqrywNaVePVlFBFfZiiM fw7KHvTdNmVib0oXpLwzSCbVniE085zDAmMtCWhaWTDsLIhwRyMf9xMhp4CJa3aytA 2g7Sq3F+QIXKeBchEDPzdHs9n+o/Ac6BRXlrmBJ4= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllvem-sh03.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 57JD8BUm605552 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Tue, 19 Aug 2025 08:08:11 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Tue, 19 Aug 2025 08:08:10 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Tue, 19 Aug 2025 08:08:10 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 57JD8AfY3034870; Tue, 19 Aug 2025 08:08:10 -0500 From: Nishanth Menon To: Conor Dooley , Krzysztof Kozlowski , Rob Herring , David Airlie , Maxime Ripard , Laurent Pinchart , Neil Armstrong CC: , , , Robert Nelson , Jason Kridner , , , , , Nishanth Menon , Krzysztof Kozlowski Subject: [PATCH V4 1/5] dt-bindings: display: bridge: it66121: Add compatible string for IT66122 Date: Tue, 19 Aug 2025 08:08:03 -0500 Message-ID: <20250819130807.3322536-2-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250819130807.3322536-1-nm@ti.com> References: <20250819130807.3322536-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Content-Type: text/plain; charset="utf-8" Add a new ite,it66122 compatible string to the IT66121 binding documentation, since the two chips are practically same except for id register difference. Signed-off-by: Nishanth Menon Acked-by: Krzysztof Kozlowski Reviewed-by: Andrew Davis --- Changes in V4: * Picked Andrew's review V3: https://lore.kernel.org/all/20250815034105.1276548-2-nm@ti.com/ V2: https://lore.kernel.org/all/20250813204106.580141-2-nm@ti.com/ V1: https://lore.kernel.org/all/20250813190835.344563-2-nm@ti.com/ .../devicetree/bindings/display/bridge/ite,it66121.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it66121.y= aml b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml index a7eb2603691f..c99b67f0bb73 100644 --- a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml @@ -19,6 +19,7 @@ properties: compatible: enum: - ite,it66121 + - ite,it66122 - ite,it6610 =20 reg: --=20 2.47.0 From nobody Sat Oct 4 06:37:05 2025 Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D72E72AE66; Tue, 19 Aug 2025 13:08:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.235 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755608913; cv=none; b=MqEK3h0aXDnLgKONeLjIOjhtDHJ/Sqs3VfKhLozdSPruMQu3zILTOXMN5belwa6W8SlJ4oQOmTFre0c3OlyNb6bTVd6C3sIylc1BIZYW7XQAr8Kg9RKpTWvMNIxRSuqxsScTPE9FPd08O15OxF3MJ/EU0oSu2SfknIrWBSOpJkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755608913; c=relaxed/simple; bh=8zUPQxsJ00o23KO+Mia4uw1VdDmxrpvNbCcQ7zUwIBc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BuOaRGzLRhB9RqPJiWBgFmRO6lrJnTwKzqOvL4pGFRS7QJxANsTn1+fELECrsEIuiGBpJDoCkzb8K4LePF6Ql1fXzgzAOW0PkG0K8qOc/8snY7wwyv/wNHRsyYAnkiLwsS0rftAxRx6DZucufGa3/mH/Zy3zwkcJMUHCNUzxxYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=OthIoQoU; arc=none smtp.client-ip=198.47.23.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="OthIoQoU" Received: from lelvem-sh01.itg.ti.com ([10.180.77.71]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTP id 57JD8Bul014890; Tue, 19 Aug 2025 08:08:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1755608891; bh=5H4GVxhV5ns4CJy71IjFHJfll6xwTub0lOZHwjCYtrU=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=OthIoQoUhpmPtoA7Z2PBcxlz3ktM4Vx6LOIxTLdtVFpLPCEsJNIF4CADrJE3sh8m2 Q7OTTFDBTIQwK0OhPpWxE3F7GPVRSwBHPJNSdDyGoXUHAluyFFzDf8+dAq7QfKlc48 Ab1kze8KBzQpcAAOszYfY6WlNoKMhRSMQ+fpJdwY= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelvem-sh01.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 57JD8Bb0421275 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Tue, 19 Aug 2025 08:08:11 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Tue, 19 Aug 2025 08:08:10 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Tue, 19 Aug 2025 08:08:10 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 57JD8Aqc2747730; Tue, 19 Aug 2025 08:08:10 -0500 From: Nishanth Menon To: Conor Dooley , Krzysztof Kozlowski , Rob Herring , David Airlie , Maxime Ripard , Laurent Pinchart , Neil Armstrong CC: , , , Robert Nelson , Jason Kridner , , , , , Nishanth Menon Subject: [PATCH V4 2/5] drm/bridge: it66121: Drop ftrace like dev_dbg() prints Date: Tue, 19 Aug 2025 08:08:04 -0500 Message-ID: <20250819130807.3322536-3-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250819130807.3322536-1-nm@ti.com> References: <20250819130807.3322536-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Content-Type: text/plain; charset="utf-8" Drop the ftrace like dev_dbg() that checkpatch --strict complains about: WARNING: Unnecessary ftrace-like logging - prefer using ftrace + dev_dbg(dev, "%s\n", __func__); WARNING: Unnecessary ftrace-like logging - prefer using ftrace + dev_dbg(dev, "%s\n", __func__); WARNING: Unnecessary ftrace-like logging - prefer using ftrace + dev_dbg(dev, "%s\n", __func__); Signed-off-by: Nishanth Menon Reviewed-by: Andrew Davis Reviewed-by: Dmitry Baryshkov --- Changes in V4: * Picked Reviewed-by Tags V3: https://lore.kernel.org/all/20250815034105.1276548-3-nm@ti.com/ drivers/gpu/drm/bridge/ite-it66121.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/= ite-it66121.c index aa7b1dcc5d70..9b8ed2fae2f4 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -1384,8 +1384,6 @@ static int it66121_audio_startup(struct device *dev, = void *data) int ret; struct it66121_ctx *ctx =3D dev_get_drvdata(dev); =20 - dev_dbg(dev, "%s\n", __func__); - mutex_lock(&ctx->lock); ret =3D it661221_audio_output_enable(ctx, true); if (ret) @@ -1401,8 +1399,6 @@ static void it66121_audio_shutdown(struct device *dev= , void *data) int ret; struct it66121_ctx *ctx =3D dev_get_drvdata(dev); =20 - dev_dbg(dev, "%s\n", __func__); - mutex_lock(&ctx->lock); ret =3D it661221_audio_output_enable(ctx, false); if (ret) @@ -1479,8 +1475,6 @@ static int it66121_audio_codec_init(struct it66121_ct= x *ctx, struct device *dev) .no_capture_mute =3D 1, }; =20 - dev_dbg(dev, "%s\n", __func__); - if (!of_property_present(dev->of_node, "#sound-dai-cells")) { dev_info(dev, "No \"#sound-dai-cells\", no audio\n"); return 0; --=20 2.47.0 From nobody Sat Oct 4 06:37:05 2025 Received: from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB6D33EB17; Tue, 19 Aug 2025 13:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.246 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755608915; cv=none; b=tnCH1e9xxqwUquzxhpHe6ZPhLEUELOdSD0YO7fHD0cyDY488bd/7rGTzQ2h2JPT4sHVimGMoTHa1E4A/kZuGGwFB1poJItRhXPk+vXFVMFZhA0+qyMS02xg0AaeVZsBPxAj9S806Z0t+O07p5UBu1P2zT3Uulv5uRwOeqcE3HeA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755608915; c=relaxed/simple; bh=G4Ar+gKTDIb4mNY6DWe2q2aBbBn/H+KsBVF0XgzqX+g=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YjOZkwAI2oXRAGhu0cRuSv91nFeDOI6b4NtQ8AJ6Pem4udwCFPWoNbT7FP6wrGulJr+Xy9KTo1Y3fUlMyPEnQ4Bjxl1SgW0DSNDz4UYRN7mofxOurnLxCY3J0JwKwEIpYVCCRX8E9JearRqCLyHBQg3AmrZIQItnHEv3OaRjEGE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=RleMIb6T; arc=none smtp.client-ip=198.47.19.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RleMIb6T" Received: from lelvem-sh01.itg.ti.com ([10.180.77.71]) by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTP id 57JD8BUa015733; Tue, 19 Aug 2025 08:08:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1755608891; bh=jLeIjCi7gbifOeDaPfjQmKQMH6hqQKIZbl4P0FGb4Rg=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=RleMIb6TEEJ9n4DAieAWAodispTACwfFbj/RkHI3WXxQZoRWSzMlEpRUbVqjn85NB ylwS4a3MyD1QXE8+B5JVrFgEuSzefVFn3WennHoX3J7kmsiMQAIkxQMdhI/owmYZyu z8KsPc46j37oW5O+xR29JKRTbH3xZwTx+T+hBsnU= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelvem-sh01.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 57JD8Bme421278 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Tue, 19 Aug 2025 08:08:11 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Tue, 19 Aug 2025 08:08:10 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Tue, 19 Aug 2025 08:08:11 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 57JD8AVH2747733; Tue, 19 Aug 2025 08:08:10 -0500 From: Nishanth Menon To: Conor Dooley , Krzysztof Kozlowski , Rob Herring , David Airlie , Maxime Ripard , Laurent Pinchart , Neil Armstrong CC: , , , Robert Nelson , Jason Kridner , , , , , Nishanth Menon Subject: [PATCH V4 3/5] drm/bridge: it66121: Sort the compatibles Date: Tue, 19 Aug 2025 08:08:05 -0500 Message-ID: <20250819130807.3322536-4-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250819130807.3322536-1-nm@ti.com> References: <20250819130807.3322536-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Content-Type: text/plain; charset="utf-8" Keep the compatibles sorted alpha-numerically. Signed-off-by: Nishanth Menon --- Changes in V4: - New patch based on Dmitry's review comment drivers/gpu/drm/bridge/ite-it66121.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/= ite-it66121.c index 9b8ed2fae2f4..cd74f3966560 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -1619,15 +1619,15 @@ static const struct it66121_chip_info it6610_chip_i= nfo =3D { }; =20 static const struct of_device_id it66121_dt_match[] =3D { - { .compatible =3D "ite,it66121", &it66121_chip_info }, { .compatible =3D "ite,it6610", &it6610_chip_info }, + { .compatible =3D "ite,it66121", &it66121_chip_info }, { } }; MODULE_DEVICE_TABLE(of, it66121_dt_match); =20 static const struct i2c_device_id it66121_id[] =3D { - { "it66121", (kernel_ulong_t) &it66121_chip_info }, - { "it6610", (kernel_ulong_t) &it6610_chip_info }, + { "it6610", (kernel_ulong_t)&it6610_chip_info }, + { "it66121", (kernel_ulong_t)&it66121_chip_info }, { } }; MODULE_DEVICE_TABLE(i2c, it66121_id); --=20 2.47.0 From nobody Sat Oct 4 06:37:05 2025 Received: from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DAFD33EB13; Tue, 19 Aug 2025 13:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.246 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755608916; cv=none; b=L563pkMryjzcWG2qBwWxN0csK+3p3YQtaWTmqu3X4zFimsfmn4WrrEQVHbq1cMAFOeCW0rgTPcnV6hiDNJjnqF387jyfqVUPFGsIDAGds9mfAezUPQVhgdghnTa/0X0XuuEzSvGND5HRPfesBG/E2arIT29L6mb75ZbCCGUE960= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755608916; c=relaxed/simple; bh=G7HoQyXhYybHZ4/0SC/Dz9ytBCL/h1/tzB9+HU4PZ48=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I8d8FmJ8LODwgMfssiRN1OXEtadE0t/fGeyCQJQwMp/NJsdzPIWdCP9+WeOJkRXmQGeB6krmzbOaH+z1jeakyuUJyyRXwh+xrx5dtqIhoWwpyykyZr10xAtNj+xltS8ES0gDRkir48Cwwiw56pMUhA+frS6hUp89NaBLJEwcJaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=ldyNPYFq; arc=none smtp.client-ip=198.47.19.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ldyNPYFq" Received: from lelvem-sh01.itg.ti.com ([10.180.77.71]) by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTP id 57JD8BUY015725; Tue, 19 Aug 2025 08:08:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1755608891; bh=bN4t2yfMJ1zEhnOL2Q0QGPptGqLzm+0XhUkQ/BB02mQ=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=ldyNPYFqUicuiIGGI6tQlGLapHpklK4LxsXMz3Fp+BC2cgnPTP+v2WxwBw0hsHImZ 61K/0xpFEa/ECewDHHcloEK66/OQJtJzx3Vhzd0MWm7oGmrgfIOkzSnGt8u4iCu4p6 4X7KzEL9Y7YuT8QPRGY+TtNBIX/6jEBTrVybjSkA= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelvem-sh01.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 57JD8BnN421266 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Tue, 19 Aug 2025 08:08:11 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Tue, 19 Aug 2025 08:08:11 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Tue, 19 Aug 2025 08:08:11 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 57JD8BnW2747736; Tue, 19 Aug 2025 08:08:11 -0500 From: Nishanth Menon To: Conor Dooley , Krzysztof Kozlowski , Rob Herring , David Airlie , Maxime Ripard , Laurent Pinchart , Neil Armstrong CC: , , , Robert Nelson , Jason Kridner , , , , , Nishanth Menon Subject: [PATCH V4 4/5] drm/bridge: it66121: Use vid/pid to detect the type of chip Date: Tue, 19 Aug 2025 08:08:06 -0500 Message-ID: <20250819130807.3322536-5-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250819130807.3322536-1-nm@ti.com> References: <20250819130807.3322536-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Content-Type: text/plain; charset="utf-8" The driver knows exactly which version of the chip is present since the vid/pid is used to enforce a compatibility. Given that some devices like IT66121 has potentially been replaced with IT66122 mid production for many platforms, it makes no sense to use the vid/pid as an enforcement for compatibility. Instead, detect the ID of the actual chip in use by matching the corresponding vid/pid and drop the compatible specific lookup table. Signed-off-by: Nishanth Menon Reviewed-by: Andrew Davis --- Changes in V4: * Dropped the formatting change * Dropped the data lookup from match. * Have not picked Andrew's review since the patch was modified V3: https://lore.kernel.org/all/20250815034105.1276548-4-nm@ti.com/ V2: https://lore.kernel.org/all/20250813204106.580141-3-nm@ti.com/ drivers/gpu/drm/bridge/ite-it66121.c | 56 ++++++++++++++-------------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/= ite-it66121.c index cd74f3966560..a1b0f8a8f3e8 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -312,7 +312,7 @@ struct it66121_ctx { u8 swl; bool auto_cts; } audio; - const struct it66121_chip_info *info; + enum chip_id id; }; =20 static const struct regmap_range_cfg it66121_regmap_banks[] =3D { @@ -402,7 +402,7 @@ static int it66121_configure_afe(struct it66121_ctx *ct= x, if (ret) return ret; =20 - if (ctx->info->id =3D=3D ID_IT66121) { + if (ctx->id =3D=3D ID_IT66121) { ret =3D regmap_write_bits(ctx->regmap, IT66121_AFE_IP_REG, IT66121_AFE_IP_EC1, 0); if (ret) @@ -428,7 +428,7 @@ static int it66121_configure_afe(struct it66121_ctx *ct= x, if (ret) return ret; =20 - if (ctx->info->id =3D=3D ID_IT66121) { + if (ctx->id =3D=3D ID_IT66121) { ret =3D regmap_write_bits(ctx->regmap, IT66121_AFE_IP_REG, IT66121_AFE_IP_EC1, IT66121_AFE_IP_EC1); @@ -449,7 +449,7 @@ static int it66121_configure_afe(struct it66121_ctx *ct= x, if (ret) return ret; =20 - if (ctx->info->id =3D=3D ID_IT6610) { + if (ctx->id =3D=3D ID_IT6610) { ret =3D regmap_write_bits(ctx->regmap, IT66121_AFE_XP_REG, IT6610_AFE_XP_BYPASS, IT6610_AFE_XP_BYPASS); @@ -599,7 +599,7 @@ static int it66121_bridge_attach(struct drm_bridge *bri= dge, if (ret) return ret; =20 - if (ctx->info->id =3D=3D ID_IT66121) { + if (ctx->id =3D=3D ID_IT66121) { ret =3D regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, IT66121_CLK_BANK_PWROFF_RCLK, 0); if (ret) @@ -748,7 +748,7 @@ static int it66121_bridge_check(struct drm_bridge *brid= ge, { struct it66121_ctx *ctx =3D container_of(bridge, struct it66121_ctx, brid= ge); =20 - if (ctx->info->id =3D=3D ID_IT6610) { + if (ctx->id =3D=3D ID_IT6610) { /* The IT6610 only supports these settings */ bridge_state->input_bus_cfg.flags |=3D DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE; @@ -802,7 +802,7 @@ void it66121_bridge_mode_set(struct drm_bridge *bridge, if (regmap_write(ctx->regmap, IT66121_HDMI_MODE_REG, IT66121_HDMI_MODE_HD= MI)) goto unlock; =20 - if (ctx->info->id =3D=3D ID_IT66121 && + if (ctx->id =3D=3D ID_IT66121 && regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, IT66121_CLK_BANK_PWROFF_TXCLK, IT66121_CLK_BANK_PWROFF_TXCLK)) { @@ -815,7 +815,7 @@ void it66121_bridge_mode_set(struct drm_bridge *bridge, if (it66121_configure_afe(ctx, adjusted_mode)) goto unlock; =20 - if (ctx->info->id =3D=3D ID_IT66121 && + if (ctx->id =3D=3D ID_IT66121 && regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, IT66121_CLK_BANK_PWROFF_TXCLK, 0)) { goto unlock; @@ -1498,6 +1498,12 @@ static const char * const it66121_supplies[] =3D { "vcn33", "vcn18", "vrf12" }; =20 +static const struct it66121_chip_info it66xx_chip_info[] =3D { + {.id =3D ID_IT6610, .vid =3D 0xca00, .pid =3D 0x0611 }, + {.id =3D ID_IT66121, .vid =3D 0x4954, .pid =3D 0x0612 }, + { } +}; + static int it66121_probe(struct i2c_client *client) { u32 revision_id, vendor_ids[2] =3D { 0 }, device_ids[2] =3D { 0 }; @@ -1505,6 +1511,7 @@ static int it66121_probe(struct i2c_client *client) int ret; struct it66121_ctx *ctx; struct device *dev =3D &client->dev; + const struct it66121_chip_info *chip_info; =20 if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { dev_err(dev, "I2C check functionality failed.\n"); @@ -1522,7 +1529,6 @@ static int it66121_probe(struct i2c_client *client) =20 ctx->dev =3D dev; ctx->client =3D client; - ctx->info =3D i2c_get_match_data(client); =20 of_property_read_u32(ep, "bus-width", &ctx->bus_width); of_node_put(ep); @@ -1568,11 +1574,17 @@ static int it66121_probe(struct i2c_client *client) revision_id =3D FIELD_GET(IT66121_REVISION_MASK, device_ids[1]); device_ids[1] &=3D IT66121_DEVICE_ID1_MASK; =20 - if ((vendor_ids[1] << 8 | vendor_ids[0]) !=3D ctx->info->vid || - (device_ids[1] << 8 | device_ids[0]) !=3D ctx->info->pid) { - return -ENODEV; + for (chip_info =3D it66xx_chip_info; chip_info->vid; chip_info++) { + if ((vendor_ids[1] << 8 | vendor_ids[0]) =3D=3D chip_info->vid && + (device_ids[1] << 8 | device_ids[0]) =3D=3D chip_info->pid) { + ctx->id =3D chip_info->id; + break; + } } =20 + if (!chip_info->vid) + return -ENODEV; + ctx->bridge.of_node =3D dev->of_node; ctx->bridge.type =3D DRM_MODE_CONNECTOR_HDMIA; ctx->bridge.ops =3D DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID; @@ -1606,28 +1618,16 @@ static void it66121_remove(struct i2c_client *clien= t) mutex_destroy(&ctx->lock); } =20 -static const struct it66121_chip_info it66121_chip_info =3D { - .id =3D ID_IT66121, - .vid =3D 0x4954, - .pid =3D 0x0612, -}; - -static const struct it66121_chip_info it6610_chip_info =3D { - .id =3D ID_IT6610, - .vid =3D 0xca00, - .pid =3D 0x0611, -}; - static const struct of_device_id it66121_dt_match[] =3D { - { .compatible =3D "ite,it6610", &it6610_chip_info }, - { .compatible =3D "ite,it66121", &it66121_chip_info }, + { .compatible =3D "ite,it6610" }, + { .compatible =3D "ite,it66121" }, { } }; MODULE_DEVICE_TABLE(of, it66121_dt_match); =20 static const struct i2c_device_id it66121_id[] =3D { - { "it6610", (kernel_ulong_t)&it6610_chip_info }, - { "it66121", (kernel_ulong_t)&it66121_chip_info }, + { .name =3D "it6610" }, + { .name =3D "it66121" }, { } }; MODULE_DEVICE_TABLE(i2c, it66121_id); --=20 2.47.0 From nobody Sat Oct 4 06:37:05 2025 Received: from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27E0341ABD; Tue, 19 Aug 2025 13:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.246 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755608918; cv=none; b=QfzFFRzUNre04sF65PwvziyWKI/ykzLjxU/05G5ardiHJmODtYFoj97eX7y+YAtq/5E96TGKvbD6mRT0V7ATfXs8j3mOKMzZ5buEhFye87uquk2pSBOQUAvWO+0mftL+38zRb2aFgD8iUo0J8WwRdKocOPqhKcCr5KbxLql3inM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755608918; c=relaxed/simple; bh=KCWnjMiB9XFoVGMpf6BPVRD0gmoXcgXGP7kPth7WYwA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Li2JAc5dZuT2aT+1i5/78UBi1Mbe4/chs2/RzeXTf5okPacBlJjoU1lN3KuoSGX/d9TR1mNEcVuZT/UYw1YXEVbZHD4OX9RXy2AbOgpO0vT2UTtvdPBKyVeNw95jj/X3+q85GgwDnrCc8v/hS5xpBmElxFNdQt9PRJo2BOEqVfA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Ux1FMWYZ; arc=none smtp.client-ip=198.47.19.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Ux1FMWYZ" Received: from lelvem-sh01.itg.ti.com ([10.180.77.71]) by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTP id 57JD8Box015729; Tue, 19 Aug 2025 08:08:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1755608891; bh=xtTTfFfNriT5ktHRzxyQ7zHdkREPkpN1b5TtXHfK0sc=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Ux1FMWYZ2cMzW1QEKitGOj7dqtY7Fq7VRpNnr3AVIm5+envElShArvPDpM5iEQbI/ 5xzKH5K3Q9ghRK9tIHrM56MDHWbd30DV4LwrVYQM4Hd9f+IOwZdzKRlSC79IF6Ux3z lysTf4+IYT1llzi9nqsiBje/akG/g203vXxhbJo4= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelvem-sh01.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 57JD8B7X421272 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Tue, 19 Aug 2025 08:08:11 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Tue, 19 Aug 2025 08:08:11 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Tue, 19 Aug 2025 08:08:11 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 57JD8BSh2747739; Tue, 19 Aug 2025 08:08:11 -0500 From: Nishanth Menon To: Conor Dooley , Krzysztof Kozlowski , Rob Herring , David Airlie , Maxime Ripard , Laurent Pinchart , Neil Armstrong CC: , , , Robert Nelson , Jason Kridner , , , , , Nishanth Menon Subject: [PATCH V4 5/5] drm/bridge: it66121: Add minimal it66122 support Date: Tue, 19 Aug 2025 08:08:07 -0500 Message-ID: <20250819130807.3322536-6-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250819130807.3322536-1-nm@ti.com> References: <20250819130807.3322536-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Content-Type: text/plain; charset="utf-8" The IT66122 is a pin compatible replacement for the IT66122. Based on empirical testing, the new device looks to be compatible with IT66121. However due to a lack of public data sheet at this time beyond overall feature list[1] (which seems to add additional features vs ITT66121), it is hard to determine that additional register operations required to enable additional features. So, introduce the device as a new compatible that we will detect based on vid/pid match, with explicit id that can be used to extend the driver capability as information becomes available later on. [1] https://www.ite.com.tw/en/product/cate1/IT66122 Signed-off-by: Nishanth Menon Reviewed-by: Andrew Davis --- Changes in V4: * just rebase * Picked Andrew's review V3: https://lore.kernel.org/all/20250815034105.1276548-5-nm@ti.com/ V2: https://lore.kernel.org/all/20250813204106.580141-4-nm@ti.com/ drivers/gpu/drm/bridge/ite-it66121.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/= ite-it66121.c index a1b0f8a8f3e8..fd71609a804e 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -287,6 +287,7 @@ enum chip_id { ID_IT6610, ID_IT66121, + ID_IT66122, }; =20 struct it66121_chip_info { @@ -402,7 +403,7 @@ static int it66121_configure_afe(struct it66121_ctx *ct= x, if (ret) return ret; =20 - if (ctx->id =3D=3D ID_IT66121) { + if (ctx->id =3D=3D ID_IT66121 || ctx->id =3D=3D ID_IT66122) { ret =3D regmap_write_bits(ctx->regmap, IT66121_AFE_IP_REG, IT66121_AFE_IP_EC1, 0); if (ret) @@ -428,7 +429,7 @@ static int it66121_configure_afe(struct it66121_ctx *ct= x, if (ret) return ret; =20 - if (ctx->id =3D=3D ID_IT66121) { + if (ctx->id =3D=3D ID_IT66121 || ctx->id =3D=3D ID_IT66122) { ret =3D regmap_write_bits(ctx->regmap, IT66121_AFE_IP_REG, IT66121_AFE_IP_EC1, IT66121_AFE_IP_EC1); @@ -599,7 +600,7 @@ static int it66121_bridge_attach(struct drm_bridge *bri= dge, if (ret) return ret; =20 - if (ctx->id =3D=3D ID_IT66121) { + if (ctx->id =3D=3D ID_IT66121 || ctx->id =3D=3D ID_IT66122) { ret =3D regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, IT66121_CLK_BANK_PWROFF_RCLK, 0); if (ret) @@ -802,7 +803,7 @@ void it66121_bridge_mode_set(struct drm_bridge *bridge, if (regmap_write(ctx->regmap, IT66121_HDMI_MODE_REG, IT66121_HDMI_MODE_HD= MI)) goto unlock; =20 - if (ctx->id =3D=3D ID_IT66121 && + if ((ctx->id =3D=3D ID_IT66121 || ctx->id =3D=3D ID_IT66122) && regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, IT66121_CLK_BANK_PWROFF_TXCLK, IT66121_CLK_BANK_PWROFF_TXCLK)) { @@ -815,7 +816,7 @@ void it66121_bridge_mode_set(struct drm_bridge *bridge, if (it66121_configure_afe(ctx, adjusted_mode)) goto unlock; =20 - if (ctx->id =3D=3D ID_IT66121 && + if ((ctx->id =3D=3D ID_IT66121 || ctx->id =3D=3D ID_IT66122) && regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, IT66121_CLK_BANK_PWROFF_TXCLK, 0)) { goto unlock; @@ -1501,6 +1502,7 @@ static const char * const it66121_supplies[] =3D { static const struct it66121_chip_info it66xx_chip_info[] =3D { {.id =3D ID_IT6610, .vid =3D 0xca00, .pid =3D 0x0611 }, {.id =3D ID_IT66121, .vid =3D 0x4954, .pid =3D 0x0612 }, + {.id =3D ID_IT66122, .vid =3D 0x4954, .pid =3D 0x0622 }, { } }; =20 @@ -1621,6 +1623,7 @@ static void it66121_remove(struct i2c_client *client) static const struct of_device_id it66121_dt_match[] =3D { { .compatible =3D "ite,it6610" }, { .compatible =3D "ite,it66121" }, + { .compatible =3D "ite,it66122" }, { } }; MODULE_DEVICE_TABLE(of, it66121_dt_match); @@ -1628,6 +1631,7 @@ MODULE_DEVICE_TABLE(of, it66121_dt_match); static const struct i2c_device_id it66121_id[] =3D { { .name =3D "it6610" }, { .name =3D "it66121" }, + { .name =3D "it66122" }, { } }; MODULE_DEVICE_TABLE(i2c, it66121_id); --=20 2.47.0