From nobody Sat Oct 4 08:06:51 2025 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7BC03451CD; Tue, 19 Aug 2025 08:01:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755590481; cv=none; b=iQNoliuS4xJXAp/ICVuDjmQduUvg8cOomJyIR01nxAFs/6xVdONgiP5F8/Hs2UDGjjwdFz1Yb9Z7TwKC+OzYF1pMf1Yba/irSgFrr+ozx6TZ2xJMg4vxc/zrQPMW0929lOOs36PbNZ5odWehRWRZS/AKwgfGznDSKJ62Oyxfqb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755590481; c=relaxed/simple; bh=vi7JEW6IQP8xMndZaUwgoHEwD1jehDWD/KM0YIvthFc=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=bradrwy+LOzcyBrlC7GWnQB8Qy2MwwABkAp+B6etmdKMZQrv8gTwqxWFBVhCBr3kCrk91kTw31WOwjwIRdpOnEPyds30Qr0FNvNrR+lE1cGdwoHKTnv8EvXjeYpwfMIcOMIm0g3nxVuLIZi49578XL7wPPRQGVUsv/jBjPk3x70= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4c5hk73CTwz2CgJd; Tue, 19 Aug 2025 15:56:47 +0800 (CST) Received: from kwepemo100001.china.huawei.com (unknown [7.202.195.173]) by mail.maildlp.com (Postfix) with ESMTPS id B15DB1400D4; Tue, 19 Aug 2025 16:01:09 +0800 (CST) Received: from huawei.com (10.175.101.6) by kwepemo100001.china.huawei.com (7.202.195.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 19 Aug 2025 16:01:08 +0800 From: Yin Tirui To: , , , , , , , , , CC: , , Subject: [PATCH v3] of_numa: fix uninitialized memory nodes causing kernel panic Date: Tue, 19 Aug 2025 15:55:10 +0800 Message-ID: <20250819075510.2079961-1-yintirui@huawei.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To kwepemo100001.china.huawei.com (7.202.195.173) Content-Type: text/plain; charset="utf-8" When there are memory-only nodes (nodes without CPUs), these nodes are not properly initialized, causing kernel panic during boot. of_numa_init of_numa_parse_cpu_nodes node_set(nid, numa_nodes_parsed); of_numa_parse_memory_nodes In of_numa_parse_cpu_nodes, numa_nodes_parsed gets updated only for nodes containing CPUs. Memory-only nodes should have been updated in of_numa_parse_memory_nodes, but they weren't. Subsequently, when free_area_init() attempts to access NODE_DATA() for these uninitialized memory nodes, the kernel panics due to NULL pointer dereference. This can be reproduced on ARM64 QEMU with 1 CPU and 2 memory nodes: qemu-system-aarch64 \ -cpu host -nographic \ -m 4G -smp 1 \ -machine virt,accel=3Dkvm,gic-version=3D3,iommu=3Dsmmuv3 \ -object memory-backend-ram,size=3D2G,id=3Dmem0 \ -object memory-backend-ram,size=3D2G,id=3Dmem1 \ -numa node,nodeid=3D0,memdev=3Dmem0 \ -numa node,nodeid=3D1,memdev=3Dmem1 \ -kernel $IMAGE \ -hda $DISK \ -append "console=3DttyAMA0 root=3D/dev/vda rw earlycon" [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x481fd010] [ 0.000000] Linux version 6.17.0-rc1-00001-gabb4b3daf18c-dirty (yintirui= @local) (gcc (GCC) 12.3.1, GNU ld (GNU Binutils) 2.41) #52 SMP PREEMPT Mon = Aug 18 09:49:40 CST 2025 [ 0.000000] KASLR enabled [ 0.000000] random: crng init done [ 0.000000] Machine model: linux,dummy-virt [ 0.000000] efi: UEFI not found. [ 0.000000] earlycon: pl11 at MMIO 0x0000000009000000 (options '') [ 0.000000] printk: legacy bootconsole [pl11] enabled [ 0.000000] OF: reserved mem: Reserved memory: No reserved-memory node i= n the DT [ 0.000000] NODE_DATA(0) allocated [mem 0xbfffd9c0-0xbfffffff] [ 0.000000] node 1 must be removed before remove section 23 [ 0.000000] Zone ranges: [ 0.000000] DMA [mem 0x0000000040000000-0x00000000ffffffff] [ 0.000000] DMA32 empty [ 0.000000] Normal [mem 0x0000000100000000-0x000000013fffffff] [ 0.000000] Movable zone start for each node [ 0.000000] Early memory node ranges [ 0.000000] node 0: [mem 0x0000000040000000-0x00000000bfffffff] [ 0.000000] node 1: [mem 0x00000000c0000000-0x000000013fffffff] [ 0.000000] Initmem setup node 0 [mem 0x0000000040000000-0x00000000bffff= fff] [ 0.000000] Unable to handle kernel NULL pointer dereference at virtual = address 00000000000000a0 [ 0.000000] Mem abort info: [ 0.000000] ESR =3D 0x0000000096000004 [ 0.000000] EC =3D 0x25: DABT (current EL), IL =3D 32 bits [ 0.000000] SET =3D 0, FnV =3D 0 [ 0.000000] EA =3D 0, S1PTW =3D 0 [ 0.000000] FSC =3D 0x04: level 0 translation fault [ 0.000000] Data abort info: [ 0.000000] ISV =3D 0, ISS =3D 0x00000004, ISS2 =3D 0x00000000 [ 0.000000] CM =3D 0, WnR =3D 0, TnD =3D 0, TagAccess =3D 0 [ 0.000000] GCS =3D 0, Overlay =3D 0, DirtyBit =3D 0, Xs =3D 0 [ 0.000000] [00000000000000a0] user address but active_mm is swapper [ 0.000000] Internal error: Oops: 0000000096000004 [#1] SMP [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 UID: 0 PID: 0 Comm: swapper Not tainted 6.17.0-rc1-00= 001-g760c6dabf762-dirty #54 PREEMPT [ 0.000000] Hardware name: linux,dummy-virt (DT) [ 0.000000] pstate: 800000c5 (Nzcv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE= =3D--) [ 0.000000] pc : free_area_init+0x50c/0xf9c [ 0.000000] lr : free_area_init+0x5c0/0xf9c [ 0.000000] sp : ffffa02ca0f33c00 [ 0.000000] x29: ffffa02ca0f33cb0 x28: 0000000000000000 x27: 00000000000= 00000 [ 0.000000] x26: 4ec4ec4ec4ec4ec5 x25: 00000000000c0000 x24: 00000000000= c0000 [ 0.000000] x23: 0000000000040000 x22: 0000000000000000 x21: ffffa02ca0f= 3b368 [ 0.000000] x20: ffffa02ca14c7b98 x19: 0000000000000000 x18: 00000000000= 00002 [ 0.000000] x17: 000000000000cacc x16: 0000000000000001 x15: 00000000000= 00001 [ 0.000000] x14: 0000000080000000 x13: 0000000000000018 x12: 00000000000= 00002 [ 0.000000] x11: ffffa02ca0fd4f00 x10: ffffa02ca14bab20 x9 : ffffa02ca14= bab38 [ 0.000000] x8 : 00000000000c0000 x7 : 0000000000000001 x6 : 00000000000= 00002 [ 0.000000] x5 : 0000000140000000 x4 : ffffa02ca0f33c90 x3 : ffffa02ca0f= 33ca0 [ 0.000000] x2 : ffffa02ca0f33c98 x1 : 0000000080000000 x0 : 00000000000= 00001 [ 0.000000] Call trace: [ 0.000000] free_area_init+0x50c/0xf9c (P) [ 0.000000] bootmem_init+0x110/0x1dc [ 0.000000] setup_arch+0x278/0x60c [ 0.000000] start_kernel+0x70/0x748 [ 0.000000] __primary_switched+0x88/0x90 [ 0.000000] Code: d503201f b98093e0 52800016 f8607a93 (f9405260) [ 0.000000] ---[ end trace 0000000000000000 ]--- [ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task! [ 0.000000] ---[ end Kernel panic - not syncing: Attempted to kill the i= dle task! ]--- v2: Move the changes to the of_numa related. Correct the fixes tag. v3: Only amend commit message with no code changes. Cc: stable@vger.kernel.org Fixes: 767507654c22 ("arch_numa: switch over to numa_memblks") Signed-off-by: Yin Tirui Acked-by: David Hildenbrand Acked-by: Mike Rapoport (Microsoft) Reviewed-by: Kefeng Wang --- drivers/of/of_numa.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c index 230d5f628c1b..cd2dc8e825c9 100644 --- a/drivers/of/of_numa.c +++ b/drivers/of/of_numa.c @@ -59,8 +59,11 @@ static int __init of_numa_parse_memory_nodes(void) r =3D -EINVAL; } =20 - for (i =3D 0; !r && !of_address_to_resource(np, i, &rsrc); i++) + for (i =3D 0; !r && !of_address_to_resource(np, i, &rsrc); i++) { r =3D numa_add_memblk(nid, rsrc.start, rsrc.end + 1); + if (!r) + node_set(nid, numa_nodes_parsed); + } =20 if (!i || r) { of_node_put(np); --=20 2.43.0