From nobody Sat Oct 4 08:05:16 2025 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98E07311584 for ; Tue, 19 Aug 2025 07:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755587611; cv=none; b=iqH5t5r1rb6j8L+WaIEj895wuD3mkxTMpe5rOpewtN4k84LAbUiOSA+NbZNrb5SSfb7cllb2sLNQVCJ2n4fh8usKQlPSkgBONZCmpeD5SBAnHMKFtRX4ABM0tZDCSdUI1kLqtrCbnE1zClPDhOvv1JINq2egdND6xS0X28BGv/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755587611; c=relaxed/simple; bh=3pMFrlDOZ8T8T8r3hLD0YaeAwhJrzB3FJXY+D50rxjM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tk4eQzB9IUlyF/m+0SXjuL7e2ffhy6eNM2Pa5abf55p7OOl/XYJM76W61BC4UQHlQJHIB0MDKoYblgBclrnjtTidc1hX3ei+n7FpPkSMEjYYIZmwOY+GIuc0LPWS2tR2TYhjDs5ALMloxadWt88yqxGK2Yo1sMAozGmCzyNcpXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=ILI6UCHT; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="ILI6UCHT" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-b47174c3b3fso3068415a12.2 for ; Tue, 19 Aug 2025 00:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1755587609; x=1756192409; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=54h6HYLCIyFowOQ5k+dd7fW4m0Sq6cnWtzdVWW1yskg=; b=ILI6UCHTay75NzCHy40jNiPmsqUTXfK2OPI+bLoFrgKpHMETewvsLAbBYuKPTArUga KZ0IIpHtZLjrGKJPY7YBwv8/jPXGqH5qFoJn7paOKdV7aaGI2xv8XKEbp6e9T7xymZSm 208KFRWdohdsOgI/Mb56wAXG32FFsillMOnfNdPE8T1m7AxjkHruF8UfaaUCaBAD//Sq CoTGB6aCkR7X5Px33ZidyzP0rO/wMY8I5AEmpo1b9JoPVA3jJWZbRy2/wLWjZB+RpP86 TVmDWs/Kgl744ZERDbhhPtunSZWdnDUlHSYiYcZ0fltl+NFWzU1kuicI7vSK9qs9PEdB 8K9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755587609; x=1756192409; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=54h6HYLCIyFowOQ5k+dd7fW4m0Sq6cnWtzdVWW1yskg=; b=bCsyE6Gf24NRpq63T69atuo+1HQPrx0wAcpckfiIR4lyLG3tO+C1FiwTkbm+IQmC4S 9pEXGfqrfdIxPKACRr/jDFOaAXWdT2IEJanOW7mZPpk6wbQXfYijVGzeVrL28gU3RWzj QPsHZJVEwyCyVb8A4xeq7+MQXkunwUbRlzeTUr9dAn2tTUVpIqI/kEZLKIwjdrIufeiS vuLZi8ZSLU1FqRbabafMJCQvf613MqvxzzYnEMrGE524vrM4jYdvtn4XuVSxuwEVZTBN 83UHlLqr2bJAsRQqgkbaTlKtZSHjjdaXwQzoSSp8KtW+r7nmnQbYKFxHKjMSgu+zZ3ma VZrw== X-Forwarded-Encrypted: i=1; AJvYcCWoXUIH2Y9nm7C2FImbrvg4msURFFyG4NwUmpIrT6E8lSKrhqLwWsm82kP6tIJBljICeNKKCf6b0Y+5pZc=@vger.kernel.org X-Gm-Message-State: AOJu0YxUVu3qS3XijwP6l4btqPUJAdONpvFjK/wtCyCo7GWSjaQTt9yW 8pVYl10W3JXwoyPl/JWP/9FFmos6j05jRoQlYp/Li3SC1Aob+a3T8AymVwseuZUNY7Q= X-Gm-Gg: ASbGncvS2lgmFb1nLVwqx4H+KbQanA/R4AynPqbeBszmzTwl5ttRZnpLneGhotZDXQn vEoIKQqbTIAeTTicjLbJ3/SmP1xJhukCSjg5obBYciQ8lwM/LBFnu+LbqjyB1/vxBlgOdKrWpEo A2Y+3qxN3o41qMDckEGKPgd5gcB10oB2s9xXMfJoTeCWdg7dWbri81eSzh9KDAfkl/OQQ9CDdVM 3y5OU43W1M/XF9wY/8m4zT8DQAAf4rZV9mJp1wD+Zyl3Pg4Y5GgqEIaU1pB8W/TVAYQoxhva4m2 e9Qm0gZz5y6WbOYFUHSrE1kxejlR1mIn4WG8gHe/n1StWAOQUKfdUEp8xOpUQfvz3YGHtAqqoxc DbKZhuF9zWOyYA+vGiRYnUlqKWig8gE5P7PXx7bpRmWMu6A== X-Google-Smtp-Source: AGHT+IFgLj8ZUjinADX0iiyxMlpjCRbQuMeIpCjPaYhpGuAKm0Pcum7h2PqqQ0wUNesJ6iACw9jDCg== X-Received: by 2002:a17:903:22ce:b0:234:f580:a11 with SMTP id d9443c01a7336-245e0309271mr19635405ad.19.1755587608797; Tue, 19 Aug 2025 00:13:28 -0700 (PDT) Received: from hsinchu01.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2446cae6213sm100213915ad.44.2025.08.19.00.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 00:13:28 -0700 (PDT) From: Jimmy Ho To: linux-riscv@lists.infradead.org Cc: troy.mitchell@linux.spacemit.com, ziyao@disroot.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, cyrilbur@tenstorrent.com, cleger@rivosinc.com, charlie@rivosinc.com, kees@kernel.org, ben.dooks@codethink.co.uk, jszhang@kernel.org, linux-kernel@vger.kernel.org, Jimmy Ho Subject: [PATCH v3] riscv: fix using wrong load type Date: Tue, 19 Aug 2025 15:13:18 +0800 Message-ID: <20250819071318.21103-1-jimmy.ho@sifive.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" thread_info.cpu field is 32 bits wide, but is accessed using an XLEN-bit load, which might be 64bit load, fix it Changes in v3: - replace space with tab to keep it aligned with code block - Add "Fixes" tag Changes in v2: - add a comment to explain why use lw instead of REG_L. - correct commit message Fixes: 503638e0babf3 ("riscv: Stop emitting preventive sfence.vma for new v= malloc mappings") Signed-off-by: Jimmy Ho Acked-by: Troy Mitchell Reviewed-by: Andrew Jones --- arch/riscv/kernel/entry.S | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kernel/entry.S b/arch/riscv/kernel/entry.S index 3a0ec6fd5956..492ae936dccd 100644 --- a/arch/riscv/kernel/entry.S +++ b/arch/riscv/kernel/entry.S @@ -45,8 +45,10 @@ * Computes: * a0 =3D &new_vmalloc[BIT_WORD(cpu)] * a1 =3D BIT_MASK(cpu) + *=20 + * using lw instead of REG_L is because the thread_info.cpu field is 32 b= its wide */ - REG_L a2, TASK_TI_CPU(tp) + lw a2, TASK_TI_CPU(tp) /* * Compute the new_vmalloc element position: * (cpu / 64) * 8 =3D (cpu >> 6) << 3 --=20 2.39.3