From nobody Sat Oct 4 06:34:56 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610033375C8 for ; Tue, 19 Aug 2025 20:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635590; cv=none; b=FCuACj21xqGyzewP2ZIKRypKkxMjbeM26gyj3xqtSSjdP2OVG6k9mwsZB4vYyY2M0eyGzHZIBGBSd5PXB+VMXNKYv7rGMMtTKpwrgifbcGRIVrNw6VOU5Pf36KGeYZiIILXHSialnZILzqCEZ7sO47o0To6VvMSqmROeIUtbIQE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635590; c=relaxed/simple; bh=pfarMdKTP3PKuK/rYN2PwD9JvqS3ROd0ZonPoWJ3yhg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s9BJkNafFzB3e1GnsU+GIwdETU9LXx7MursxHgeztZ/bDFTJJyuPl+mUp4iG3UsLJw+KE/BaXHIHH7yZIiCP5kImUDTBn3CZwSaB2I9H01ig10q35YIkBfuBr90TfGaGxAuVB3iQIEJ5KrCHjVycj/3nHqmkPIx10tFdOgGEPBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IiUQr4VV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IiUQr4VV" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57JFLGkU007362 for ; Tue, 19 Aug 2025 20:33:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ovJO1XSWvs0KNakJASmsJP5sNHD1z0QwbqY++5/N+xM=; b=IiUQr4VV5TbyzTFC CN1iQjZqVwVVM/orFQS3P0PoGA1Pl93VgXACCmF+oOSbcxExjnyZ7dJ3BwVfTH5v vrol8L4OUtyeylkdzVy6WUHuRUHtXyDqIfl0NsIUzsrltwZ4xUEONym14TGAFzRS 2Z5hXD+tfeEoZgOnAzsYYBYskF/9xEjZ+D073I0sE5Jl5QktSeP9/CXkALhB7/Zd b1JTJ28dkpcjZbHKQAnz6L2UDY2CtfpuEgn/u7P/15NZHnIVXUkA5sCc0IQe1i6r q78OjlfhywLdgYVAydE6CDO6dF4LMC40FcD9NfdjFLtBPF1D1ZJjtNKyRezZ8qpT jdN3rg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48muu0gwsy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 20:33:07 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-70a9f636685so192457406d6.3 for ; Tue, 19 Aug 2025 13:33:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755635586; x=1756240386; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ovJO1XSWvs0KNakJASmsJP5sNHD1z0QwbqY++5/N+xM=; b=BuhGyX6pL5krWeCb02zcvJjTJW185Xy0jI/pgqZ5Z3kdqbPOVBMK+WYikDKDOOI7Bn nmP6GdHhattCq9mhktzu1EU9pt3QdTWzWuUXmBsC9kzih+Xjm8IHD4xkclyVOCgGeqk3 jPMZnW1HDHIyLiu9bE/wdoEQRrKgLGKeSF1eap1owmss7DrQpPnY2yDjdi4RLIJ7Qdy7 DmoEw78eUOqQXw0jrFTF4rXdDcnKpojLgHpxIgWB01wPqneRvJyskAS5XqmFxMdEJ0Qm XzCC5YL9r/KBGOepognlYGRVF9IQetvfb/2cbpOJvYoEM+fIei1sdYWTuhISHsL66jCr SyHA== X-Forwarded-Encrypted: i=1; AJvYcCUuw5hlBSjkltOY6WxRKJXe3/MuIYmp6S31MjHfLTiSiQ6FjMKa1BMKsS0TxjkeW2zEAUfplAUU1yl8XqU=@vger.kernel.org X-Gm-Message-State: AOJu0YzxaNvXhyIqJET1kwoxC/uGfxH2M7P8yZkN1EP0R7BvLcBo+96E xC0S+FqwA3hRHWsbuBlvo285SwK7AXxtGXgXS8cCTKAgSlkRlvjSYeRLSJ4n4FA7slqkcAS+lCf CwnjrJ4sIOz8TOBlcWh1D6WtFDjCjPkFoILcLnYVhwrmMpvH/lnMysWAKMliOfmHTRuk= X-Gm-Gg: ASbGncvIuqAls5u4KNx/yqlfb2On/kZINPxziWFUmQ0krbYOjvsAuJGgRuWFVXOlEqV F/hzl1OfZd8sGJYmxzJBjMyVfx8aAcF5lVzDJQfgpRoli7+a0sgZDJ7fMurlymS8K7MKzpzm72j yPBezpKa+8EEZxRQsISDIXOq3dZwULJdqHNR/pNyvVcC+ghRi8LaYOC7kEGMewFh6Wts4X1o4nM NCY9sCSRzLTXYJ6IPvx9kVNYfZsbj/EODeLkROJgo3XXm9d/CSs25yhMO/U2HxNM03ec2gZPmtd ZP19Vh3o5UFdlUGCDo2VK7boBnx38PO5tKZlo21n7unEcui1J/0GB5tdG/uAdnJojURihvdZyxt X8oZ4UDJva7b/s+EpSqqrA8bJzHGikPFiUW11kBtsdMaGolgM3nXG X-Received: by 2002:ad4:4eea:0:b0:704:95c6:f5f1 with SMTP id 6a1803df08f44-70d7709978fmr4710236d6.34.1755635585925; Tue, 19 Aug 2025 13:33:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExtlapPhC4VdvxehLvtICbE+wf4VkX5gXmldiks/+ryTub2wDdZG116DcdFZUySCphNajoXQ== X-Received: by 2002:ad4:4eea:0:b0:704:95c6:f5f1 with SMTP id 6a1803df08f44-70d7709978fmr4709826d6.34.1755635585259; Tue, 19 Aug 2025 13:33:05 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef351806sm2212969e87.13.2025.08.19.13.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 13:33:03 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 19 Aug 2025 23:32:55 +0300 Subject: [PATCH v3 1/8] drm/amd/display: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250819-wb-drop-encoder-v3-1-b48a6af7903b@oss.qualcomm.com> References: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> In-Reply-To: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3090; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=pfarMdKTP3PKuK/rYN2PwD9JvqS3ROd0ZonPoWJ3yhg=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ8aS+zVx+7sDXTal/otbFF9xSvEB653da1pVu5wcjWZwb P9p8uJUJ6MxCwMjF4OsmCKLT0HL1JhNyWEfdkythxnEygQyhYGLUwAmUqvC/t+J/b2vPYfQ9w8Z 7fcdbLozXYrsLgarn7RWWJkyI+udhmF3TqT3PPkPXdKqr98e2FnOcfmUBZvjJ+OHMwzU1X+XzH4 8c7+pkaBR0rXaRzuc8vSXn3diK2C38P76+qyPl7q9wOZFYfahPLmCqbfOMi/xPHvDW2eKlkVy8Y +g9f5/Wd5z/c26m3dp6yIb0RI+2eclWryLDPW7Mwu3sSZsFb+3U9X47reNOv5+gmX68zVeCnmUG Z3dzGW37vy7Mu6zvYK/753+cDXLcG25q4HNr4XPLrptYufLDu1/981izUrO9Q3xVyIvLYif9lZf LCz2it/0pWd+3vugZlfn92Vhc7tUC5Noamr9xabCb2XnAQ== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: 3vjH5TW5-H_ACsIND-z58awW0WYiL4KN X-Authority-Analysis: v=2.4 cv=YtYPR5YX c=1 sm=1 tr=0 ts=68a4df83 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=M-qvw7r3wQx8XY5Jx90A:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE5MDE0MyBTYWx0ZWRfXwIEVxW18LHL7 +dwPDC7p3AFQLBuzHBUoWsPn6eOXggMmboz+M122BSJC+m9UvIrAhQGY3mwd78jHobRUGjsggbb k8MDXbFktul8JFewkmzXt/jG4+gcyA/ndfq4U4fKR2D+e0Jt2ZmGZtEKxYTqmLmoyGYhKAZkfx3 psq1Rvetvt94kNmgIO1ElauPdxwK3AS7hy0vZbf9IVVa8xLoRT6y+h+7t/hVe76bgT40r9k4vXJ erFUWzLwxMNG+RTmwXnnyWMZuJP3B56+T6jLMXMiQEY6yBzu2QoV+LkxkdB8hboViQEp4IquQ6J woAWl2eYyq8Fm6uWV5QBuKonal4stZW7JdEv6ie3l6fmYEKkklZD+rjZ5j1bHa4iRAa7EME2r0m A25Tsn58 X-Proofpoint-ORIG-GUID: 3vjH5TW5-H_ACsIND-z58awW0WYiL4KN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_03,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 bulkscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508190143 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 18 +++++++++++++---= -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index cd0e2976e268da41f576624c50ef0c76ede67414..0c9d347b1efc804a28fb3095df9= 4e543a19e4159 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -10006,7 +10006,7 @@ static void dm_set_writeback(struct amdgpu_display_= manager *dm, return; } =20 - acrtc =3D to_amdgpu_crtc(wb_conn->encoder.crtc); + acrtc =3D to_amdgpu_crtc(crtc_state->base.crtc); if (!acrtc) { drm_err(adev_to_drm(adev), "no amdgpu_crtc found\n"); kfree(wb_info); diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c b/drivers= /gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c index d9527c05fc878ef6916782ff9fde847813938461..80c37487ca77c0494eaf769c5b9= a3c53486aa52d 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c @@ -171,7 +171,6 @@ static const struct drm_encoder_helper_funcs amdgpu_dm_= wb_encoder_helper_funcs =3D =20 static const struct drm_connector_funcs amdgpu_dm_wb_connector_funcs =3D { .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D amdgpu_dm_connector_funcs_reset, .atomic_duplicate_state =3D amdgpu_dm_connector_atomic_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -190,17 +189,26 @@ int amdgpu_dm_wb_connector_init(struct amdgpu_display= _manager *dm, struct dc *dc =3D dm->dc; struct dc_link *link =3D dc_get_link_at_index(dc, link_index); int res =3D 0; + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&dm->adev->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &amdgpu_dm_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D amdgpu_dm_get_encoder_crtc_mask(dm->adev); =20 wbcon->link =3D link; =20 drm_connector_helper_add(&wbcon->base.base, &amdgpu_dm_wb_conn_helper_fun= cs); =20 - res =3D drm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, + res =3D drmm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, &amdgpu_dm_wb_connector_funcs, - &amdgpu_dm_wb_encoder_helper_funcs, + encoder, amdgpu_dm_wb_formats, - ARRAY_SIZE(amdgpu_dm_wb_formats), - amdgpu_dm_get_encoder_crtc_mask(dm->adev)); + ARRAY_SIZE(amdgpu_dm_wb_formats)); =20 if (res) return res; --=20 2.47.2 From nobody Sat Oct 4 06:34:56 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75D85340DAB for ; Tue, 19 Aug 2025 20:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635591; cv=none; b=EecMqs00LQjfnEiaZOqZSLBUB2e6KKJ+ZzqJ8/HL/bM3/mlAkZMhb/aiA+0BX/vc19Cg79gvJ7RqhMkM5BmL6AAe1ql689DBAam/Z1W4mR6gZTMrSO8SjgqHM1GRr93XxcWO4X4WaWO6CEQobMII1ESBYwI1SoO561Mz3TP7v5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635591; c=relaxed/simple; bh=FAStH94G7STx9dmih1BwY2moi+ekwJevO6V7oZLap5U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NRG2AvQZtUle3UgCIFYyAT5ccreQPV3JVeU0VlKfLvwm4FUIaHxhsC/BAHI07bNTXRzZ5UV3z4O+AUd22Sq2nmlJUAnTwzvIgkk0T3jSv2vUcfSr1S9QztMyi0R0hNVopHi6CJdIfEoOphj99nkIDlZGGShIqPCRwXEJWfHmfRk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SjU+1JJl; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SjU+1JJl" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57JGpRKR018046 for ; Tue, 19 Aug 2025 20:33:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3LiTGbp3yrZlb6BdgcZ8Qpq6CDIhRX/Qyb9HMEmTyzM=; b=SjU+1JJlEMN5h9Lq moBhgBbX7sVHFtLKHhg1uDJF+cObpbBG1wEVxbYP1yKWK8vYKsKnNLAl/eBnBC+o h77RKV8DW2ANEg1sBVNkx0PbDgc3asTaQv9UeGnJNHu4QnWT8RFv+T9xJRyeL+PE RBX27Qu3PLDQBXT7lfmo6AiRpdwuTsz0CikBraO/amPvw4feNj5Xb7/foe/kDxJ4 VuP07j7pin7nS5EGCHJRGDDmTM/T/PSRgnQ3kusPhpsd8NlNT8qfCvXS+5YrXzdX EEFT7I3RhLOKpPQaW9oEhkt1UWrykB63FA4/onp3niGnghnM4488Hl5m2ojMXfII OtRueQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jhah1u1r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 20:33:08 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-70a927f4090so131306616d6.1 for ; Tue, 19 Aug 2025 13:33:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755635587; x=1756240387; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3LiTGbp3yrZlb6BdgcZ8Qpq6CDIhRX/Qyb9HMEmTyzM=; b=KbZ1tgDbbJWezmaoHjEW+CDJl4Cq4x4ZxAEL6Fk3loDEDi8ohxzwixplXJNB62F9ND c14zQTwtv2BOb9ufARILZQ8Od5YpxJ3c7YYyiqB8w9J8MNdfr7lTWk7mnrDmDe5y9KFW GqwZCGe3YcissNEWPGyiKSGaZxSJEcgMONRlxcNQ8Jtzo6+gBt14fkKKO2YDZpeDzS6S NbhDzHcDgldzZRdWG3FTaHJRw3N0RU2sg3lZtjS0V0LJ42aCR8Gej4+QXRHy4PemKFD+ SszIab6f0Z2Xq6kLVBAkCIMSFnh4Y8UUDv6aZNj8b7riOieGnt28Y4YQ544195F9rYz7 hRFg== X-Forwarded-Encrypted: i=1; AJvYcCWhQ9Geo4OghohaHfk4UFD03LCCagx6ot6OcDIfOUKBsnZtdgSn0NkXYf+jahYpHL/rKyHX7IPRc1sVNqk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8pRfaM10iqDGw+hVgb8BJhvGJCVPWGDzPU/OOCUK1a+JhZCqT sJ7TjyNIWaNgxEeNGgIZHESWmmUZwRSDi0bfk4CGUv10Y6h4QcmdAJ8qyjlUQ0GIIf9fJtzpfF4 P7BfjBg23qBgXPv3NkxM5DuOWcRJOF6kzn/BGlLd83bsKjo4Fwud9URgSotRMBJea1u0= X-Gm-Gg: ASbGncv0ycS5PmFszTMOcnZZi0kXGGRd15gV/HzyxedKg7o74mRfGgpi4dj/ViO5/nv nxJLbJYfTa6BOLsK7+nBy21/Ui64Ez95xcRY+oO3c3piVCaOZ5yz+XBK7t26ZJ6j0syNxmtXVls VI/uMhsB9z3YCQx/t3IbeIgRt4JiKzgcPf15D/dEcUTumzA+w1NhNcamjImcOQ1wcrvGYzUbNwK BKswCzNtV0gvbvLzuWKTHYTUwiEN/TIs9QTB1jnkHBLGkdEhNcPg9UB+6tgOKKpadcnMRKGWOhe NXMmVUuxtEs3vk+mMbt99TA8PBMnEWNAwNNjye2Va8Yd6c51iRsveq45o853TWyPamwDm93nEMg 27KUZg5EWjfZ3RYhw2QEV/i+NsjcJclMj5aH2G7k2QGrpub22/GqM X-Received: by 2002:a05:6214:d42:b0:707:4cba:124c with SMTP id 6a1803df08f44-70d76fcc6d0mr3925176d6.15.1755635587365; Tue, 19 Aug 2025 13:33:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXbzwbtPTMthExC2v/jPPGR0U6e77awEra/VfApnsoPxFWnQVPM0TA/4e3XCxu/atusvWn1w== X-Received: by 2002:a05:6214:d42:b0:707:4cba:124c with SMTP id 6a1803df08f44-70d76fcc6d0mr3924596d6.15.1755635586630; Tue, 19 Aug 2025 13:33:06 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef351806sm2212969e87.13.2025.08.19.13.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 13:33:05 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 19 Aug 2025 23:32:56 +0300 Subject: [PATCH v3 2/8] drm/komeda: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250819-wb-drop-encoder-v3-2-b48a6af7903b@oss.qualcomm.com> References: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> In-Reply-To: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3013; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=FAStH94G7STx9dmih1BwY2moi+ekwJevO6V7oZLap5U=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBopN98pXeI0YI5rMMU0cfAZCQzyHd5SV6fCosRp 2k4DpPn0m6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKTffAAKCRCLPIo+Aiko 1apAB/9Wed3uT8K4J7VbxZQYRdgbqkXEWuchv9h23rqen6qeVxtKb3hxBGlgSJGYV9xreUNSJnt kycaE7r7dHO6njLoIlrsEUjSpp8QhzDrdB3TkUHQI/qXhPZRO6jFnnNiIze3++SQeVxeLeQq2PZ 2rFLFqfPI2FY5msigg2DlqPrvKPoUNuVNS7pdu0UY/CvuGxBWQi4zhvckEkyL9Hux8vTpJPyf/i 6rhXGOI0GDWURVYOezbaytNWfpchR77qNdCUgqGdCF3fhHq8AI+avLEXbs+dyFKUqhzUgbLepqT 7umscLV59LLEPrJSAUSBGxAHsDU9svqZIx/JOZbeay4TJd/a X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=D9xHKuRj c=1 sm=1 tr=0 ts=68a4df84 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=EE5oNXVUeA2ILyHCr4wA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: QLqzHA95kCJAuFoHrAtCbFNYAfW1ZXsB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAyNCBTYWx0ZWRfXypb5UWiJ3usS SzFekGR78i6DaDVV2vfw9nfpU8eGxKI5Jfxu9WUuHjKBnfml6GAK7yv5e4oZ7qOXKofJ0gX6rXW jnDmFM47B1ffWGxXcrVu2M780ZWOoR6MBCIzxqZY6F8EyqT95ctKiqxlsz55fWKJuHN2C6LCfCD gKYtjVTpB9Luzq4hLZnV0N2yb2FQQcvf/7/qCAh8fOxgLDji3fNG9untC/NoZnv31qahGRABw3Q s5CJ3NdQZmVEK7SaXIFOyQwM9lBzgn6a2FjNibNRr4/gDncwIZCishX3VBRAE+r5/8A8mdwEEWV wLQMQqx5bWr6DLgKe7HsD+P/HXmtamZDBteaES57mbqapFUR/1eEdOFoEkrPuul/W4+HiBUT2LP ci2Y+oEf X-Proofpoint-GUID: QLqzHA95kCJAuFoHrAtCbFNYAfW1ZXsB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_03,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160024 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../drm/arm/display/komeda/komeda_wb_connector.c | 30 ++++++++++++------= ---- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/dri= vers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 875cdbff18c9dc97e736049feaa8a1fe1bcc82ff..bcc53d4015f1f27181e977272cd= cfa35e970fa62 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -5,6 +5,7 @@ * */ #include +#include #include "komeda_dev.h" #include "komeda_kms.h" =20 @@ -121,17 +122,10 @@ komeda_wb_connector_fill_modes(struct drm_connector *= connector, return 0; } =20 -static void komeda_wb_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); - kfree(to_kconn(to_wb_conn(connector))); -} - static const struct drm_connector_funcs komeda_wb_connector_funcs =3D { .reset =3D drm_atomic_helper_connector_reset, .detect =3D komeda_wb_connector_detect, .fill_modes =3D komeda_wb_connector_fill_modes, - .destroy =3D komeda_wb_connector_destroy, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -143,13 +137,15 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, struct komeda_wb_connector *kwb_conn; struct drm_writeback_connector *wb_conn; struct drm_display_info *info; + struct drm_encoder *encoder; + u32 *formats, n_formats =3D 0; int err; =20 if (!kcrtc->master->wb_layer) return 0; =20 - kwb_conn =3D kzalloc(sizeof(*kwb_conn), GFP_KERNEL); + kwb_conn =3D drmm_kzalloc(&kms->base, sizeof(*kwb_conn), GFP_KERNEL); if (!kwb_conn) return -ENOMEM; =20 @@ -165,11 +161,19 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, return -ENOMEM; } =20 - err =3D drm_writeback_connector_init(&kms->base, wb_conn, - &komeda_wb_connector_funcs, - &komeda_wb_encoder_helper_funcs, - formats, n_formats, - BIT(drm_crtc_index(&kcrtc->base))); + encoder =3D drmm_plain_encoder_alloc(&kms->base, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &komeda_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&kcrtc->base); + + err =3D drmm_writeback_connector_init(&kms->base, wb_conn, + &komeda_wb_connector_funcs, + encoder, + formats, n_formats); komeda_put_fourcc_list(formats); if (err) { kfree(kwb_conn); --=20 2.47.2 From nobody Sat Oct 4 06:34:56 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1211342CA2 for ; Tue, 19 Aug 2025 20:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635593; cv=none; b=lzTKFZwrI03yNnudgSMjiuVCNPysL3Dc+75qImjUerZIb+vusiXcOOZZgG5iA1r1hkEQvkOjZnWFUlP8mHhMOnWotODURGrovGXubgXZxHHGGcm0CT2LN7GDd37F/YB/4ppfzcMiNAV0QOerBiPtYMh5670I2HRIRNtg/7NZK7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635593; c=relaxed/simple; bh=bSu7BtDX/FJ/CYhdTG49eD8oSIyWKKcC6qKfEjkvl9M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kOTuuue4BLg91udnq7ZoNUjkPiC8JqXqqL8+CmxXyB4/0XVBlz4Cr5JbkJaWyYl7RE0/fV1Zf1MRClb6K2k7eThFCkEIlh9SKgkxXkRcsUGKhQ2JDY3SRx4V93JK15CzEFSHclrg3UG16A0FrxXiXQR1MVQayTSN6ViUdKsQn3c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AOw0gzB0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AOw0gzB0" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57JFKsYu005472 for ; Tue, 19 Aug 2025 20:33:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TRcyMGCl+30uALX35qrVjgv24YuvpY2moJlPtRkxYu0=; b=AOw0gzB094/vDr2i z2iu5TdlCo6XWCCXSc9Y0sx5QYAEBOj1Azj739aDVgO52hmdX14GEtx/lMzHirDa w1ezg4r0DxiL/qIciNJH3n5aTX3CoKP2nfgy8tk4eJqbugDVkykePpOIvQaoptGI 2JEZXFIyPvo4sKDhJqO0WP6xr5NZMRc6A+lpA98BwggLLtDobFKxkFWDIQxkVUEp IBjWiR9zFKHh76Gc8LCRf50emHPMZYvDxkLMGt5nrky7vpmZ2Q3ceWRMHPg9ros4 iOXelJWmZz5EWkLA5FJiVpzvf4jQ7fMquaDN/NI8Nv99ajmqB6dDZIpjqChu8qY5 OnHvGw== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48muu0gwte-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 20:33:10 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-70a9f5b3601so140067816d6.3 for ; Tue, 19 Aug 2025 13:33:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755635589; x=1756240389; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TRcyMGCl+30uALX35qrVjgv24YuvpY2moJlPtRkxYu0=; b=ipYYXg2ejg+aswp829spsG4EocGEZn4dH4tADGjyta99heRUAVvuCWt8YT4tmWRx9C 3BrHQdEei0xjkvG05d9xv/VfBRi7ZFHesE5YuH8WCMif/DbqM2l1X2/lVQ2NlVrVW00M BhO2Ja3jn/5T/htgQPnYTyriA3W/xylcWiW/iou9LVdd6HxAMPmqzqcTaT51hrWA2Os2 CvVQHoWL/jb0aT0UhBF96ls/7oYf23qZvJA1FtGXQk2UCFbwMabWZQnZn6K9pGxRIhjm FG4GnGrDvOHwNHFZsinctnsFNlVprocWIex5/r2Ce6pxwnHoAuH3bIJ9mBlYf7OtI1e3 ylew== X-Forwarded-Encrypted: i=1; AJvYcCV4UYWfgWagY0gY4nXejFm8CfLkO1Eyiw6ONvjJbGN0Wrv6hsIGoH4XkGcJpIyRotsFFdWqeilvywtyr3o=@vger.kernel.org X-Gm-Message-State: AOJu0YzJ68Y099KWfLsjet4IucBto+c3VOxFih2NlsKcMl+R0qsCPBPo UdPanQC72p4ae6Cru7NrHwx9xELycIaBmBwqeVFGCoLaOAAE+T3znK9MQKaPIRCjPzXA99rhkgy /ahsBFBss7+IZRV98FCh9h0Rs4oXDRqbs21KuWVhZoMUIhdBn9qp4iCs9aMlkD5ehQNY= X-Gm-Gg: ASbGncso+rchblYNuRl9V0RJz8/hNTXAEVec3ubh0ViiwZhhmrzDI/n7OJ4OuKGpOwN 9et2sdMdELyBsFhTcDWrtmDOYIvYpb0OFB6eH3TBZdsTGECOWq9rtIAVgRvbyJelKopVsDqurXt 2kW1l4E1mBAh/9mOFofnMjiTdGXgGMUVq1vuGXJA+28MCIyJ2xIcpx3wtnf++cMrWipEqltgvgL HlEXnUGk0ydxw7i9wDDdSMKMf1948j5NQuY+it+HXFOfwJhXjGkipfuWGzuwhdsGR+dPTr0XbqR e0PfHs2aolPj3bT1pA3U2sLkisXEu9MHP9nn2os7o6enxsW8NA+WVzoSyCbjsXvjg6PVzNUIbKC /fl6B7IM8s9B2mvQO3XzmVXABvvPnCyjs0xvoSQ9E0tWLFjmtT1dC X-Received: by 2002:a05:6214:1c05:b0:707:44d4:2962 with SMTP id 6a1803df08f44-70d76f5c35dmr5036986d6.7.1755635589210; Tue, 19 Aug 2025 13:33:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEGNkRtmHZj2kwRc4y9joiW0/IdD954hX+cZa8EJqfg+DQk+Kuir2C5bEakrVSMmh74F9NL6w== X-Received: by 2002:a05:6214:1c05:b0:707:44d4:2962 with SMTP id 6a1803df08f44-70d76f5c35dmr5036196d6.7.1755635588384; Tue, 19 Aug 2025 13:33:08 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef351806sm2212969e87.13.2025.08.19.13.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 13:33:07 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 19 Aug 2025 23:32:57 +0300 Subject: [PATCH v3 3/8] drm/mali: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250819-wb-drop-encoder-v3-3-b48a6af7903b@oss.qualcomm.com> References: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> In-Reply-To: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2621; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=bSu7BtDX/FJ/CYhdTG49eD8oSIyWKKcC6qKfEjkvl9M=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBopN98jRiShnU+tPqXA3NgCQCoCCCxsblmO85Nn 1h8us24U1qJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKTffAAKCRCLPIo+Aiko 1c51B/sErwvDMVP76IuxwrizrFdDwWxd1TIobv+DiOASR+c4gjQ1luTuJnSzftykasC1wY/qv/I egdxs5YNWQ+6aqMuw6GyB/W1jqi3zuaSvJl9Jf5djSqI167jMOYFXvbT+RTwSJVcNVX1EccXB2G 0u/wRJ7ySKBTSxN9gLAXZ6cE23vdGrPt0nYKZ2vSMkVtFFc4V1WVsVbd7Fhq1aVn6g58KMBSWZU I/9zSRkIaFzUE0OGTsMAFXrCVM8V9ipB+YFoC+9NWZbMjSQD8zOMmyM/Zaa847DFNIzpziBw0Nf Motkscyd5Lwe6ogpT2PUjhdWq74CwRV6cUefxzNnte9KyU+3 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: R6Sj5--0nzP_NRkWAM-ifbk1MsVzHwKF X-Authority-Analysis: v=2.4 cv=YtYPR5YX c=1 sm=1 tr=0 ts=68a4df86 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=mhD89yN676IZukTL2GQA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE5MDE0MyBTYWx0ZWRfX+LJqQNy+gNOQ dYY5bdBvTXeKu0cPYiK4brT5iXqD9TyYd/P9VaI6GvWYlm+T3biONlcaD+EULyCCjU/E57oM9HV XxrGv62lGym/fsbXAooJrmlOcP5tALKn8qqMZhCjqKO+WTBq2vsqWrzQhWSh2l6+11Mdh87QoI9 tf9Ly/6Vopxtv3Izf3BjG2xz14lXmzUpaTvsUIFqxz0axvX5dZ6fsbqeEiN51KYueswEoN/awoR xFMIRl1icRp99YY/e1fQFwTm38aynH5AOR/In5qeSzc8GwOZgthUiHzEkU04/j3nsmNB9O26Wh8 L1Ahy/s87mXUdmBnfo6LAaY7M7JU5TsjNTbWOnQwTvhVGFikwpEksw096VWTtAgj/i12zhKu8m9 /uGy7AJn X-Proofpoint-ORIG-GUID: R6Sj5--0nzP_NRkWAM-ifbk1MsVzHwKF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_03,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 bulkscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508190143 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/arm/malidp_mw.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_m= w.c index 600af5ad81b15d0c30f9f79588f40cca07437ed8..80f7f3474c4494554c6b6fb392e= 7f396b3b49c83 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -84,11 +84,6 @@ malidp_mw_connector_detect(struct drm_connector *connect= or, bool force) return connector_status_connected; } =20 -static void malidp_mw_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); -} - static struct drm_connector_state * malidp_mw_connector_duplicate_state(struct drm_connector *connector) { @@ -114,7 +109,6 @@ static const struct drm_connector_funcs malidp_mw_conne= ctor_funcs =3D { .reset =3D malidp_mw_connector_reset, .detect =3D malidp_mw_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D malidp_mw_connector_destroy, .atomic_duplicate_state =3D malidp_mw_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -211,6 +205,7 @@ static u32 *get_writeback_formats(struct malidp_drm *ma= lidp, int *n_formats) int malidp_mw_connector_init(struct drm_device *drm) { struct malidp_drm *malidp =3D drm_to_malidp(drm); + struct drm_encoder *encoder; u32 *formats; int ret, n_formats; =20 @@ -224,11 +219,19 @@ int malidp_mw_connector_init(struct drm_device *drm) if (!formats) return -ENOMEM; =20 - ret =3D drm_writeback_connector_init(drm, &malidp->mw_connector, - &malidp_mw_connector_funcs, - &malidp_mw_encoder_helper_funcs, - formats, n_formats, - 1 << drm_crtc_index(&malidp->crtc)); + encoder =3D drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_VIRTUAL, + NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &malidp_mw_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&malidp->crtc); + + ret =3D drmm_writeback_connector_init(drm, &malidp->mw_connector, + &malidp_mw_connector_funcs, + encoder, + formats, n_formats); kfree(formats); if (ret) return ret; --=20 2.47.2 From nobody Sat Oct 4 06:34:56 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E58AE3431EB for ; Tue, 19 Aug 2025 20:33:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635596; cv=none; b=XCRGYNKIf5KA3v34wu1tsLu6v+zY4dLodkRlrCpEPOWR8rtry5o3zX6E2sfHANTbeaEVcPYYF984GZz0DjlYsp7cgP6cH7pTHaZu0Yiqh20yTlgx2FNZS/5yPUZOnOdHEhsBPPxKfTdVXT2crImRh/SfO++CqaUtE/m8WjBEx10= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635596; c=relaxed/simple; bh=n7xaHZSSROB+2XdVsucGDeHL2qDsHnv9brWl2LaC/6Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=otE8kZwoTnHb0zzoXImnCRQ32DBN6KWKf9VdKEZzhIQNRIFYGMwAbeUWHZVa/NqPd55Clu3mZhKutBHDBUVRPvBBdjvw42tDDF4VgVoKMqLjFUb5d2oNnloJegLG7Qg4DarOPsryH1NTWCkRCU9oG/6b/ypnzrb8MEVe0kXAUZM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S8Uhmr/4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S8Uhmr/4" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57JHIaE1000431 for ; Tue, 19 Aug 2025 20:33:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Uae42TaI8vGi2qGQ8bwNSeWnG/c2PiftWqaI8l7bbt8=; b=S8Uhmr/4O+nSPYIm 2zKbhC/oDjV9DkZ26zlb6qdRRPz5Rnu4ww2ej5v0TmDFmkdYXv8TFVeTP/bGwxsb 4ZxQ/2im9UB6JRhBSPPadrP6c6xKYOU/sHEkIlTyb59nZdRsVRfqUKazW2GxnS+H aaRQM4t55EbBdmsQ47OzwhMocAXF0XDTJo+mbWRGecA/e6GR7IKVMmJ2s4Jbj4fl ZK5O0LX5cytxx88P+iIVnB8iDHNFRFHTIUma/cchElwTH8ASfdFxrYbMrbaas43I WepbyRcoss2ENw0vXLUxZn+tJtkDSdBp0OkS0+lQaOo+uw1esXpqN1Z1fDiJrdB/ Lbw0Yg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jh079vgg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 20:33:11 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-70a9f55eb56so131976276d6.2 for ; Tue, 19 Aug 2025 13:33:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755635591; x=1756240391; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Uae42TaI8vGi2qGQ8bwNSeWnG/c2PiftWqaI8l7bbt8=; b=HpRlyyjcS7EpWz0YXu+lMSGeSKLbXzXMu7oEZ+F5ZVHwTfpnU/tfcjtUnmg+AHwi5L sNGfk7oMYtW7wB4cFl5RtXEBQBktCMwkFO4nDbyZ2TBpVc2wgzczHbeTpxzzrAWDH3pm 33XleZ2GCcwF9wZAGQpCJc5NFcem2gQzD2RS9WMNtAXZNaV3TJ18i2hAYDTUQLq/R7zI zD5Y2pyR8BS0YpOGotlUNePAPl0+u4HiConyfG9dML+v2tUX097ixIjNvXIz1UCbordk Rs82L6YXPAFzPkHU7G/dGZFp01iyeaY2k12NfgC1cMaOaq4jaJSwJyGpKawbGVDyIymW NUGw== X-Forwarded-Encrypted: i=1; AJvYcCUNHsFxGezyTZiL/8NCeMkIf/nZPffcTbX4FoJuBnfhZ0i0EKxEmRpPdZpOqpgSMlZseNvKIKcc/5MRS1o=@vger.kernel.org X-Gm-Message-State: AOJu0YyYLcNxlILMwBOH3vt5CY3oaRb93ZCqNhgOWywh2hYVAaPNZoBY hRfTQrRhPbBLliOPz8aDAyTQ2HH57iEXEwnCwCEAWcQjNTGJYhTeNr/88vgM3mEHA8J0QLoQBLm 4bMpPGJ1znryasPcH1q6YwU2wuoZ+xaQXgchkXhGI72XTxY1Z2awjWk1044wmlC0+lEw= X-Gm-Gg: ASbGncs6kmRCnL9fkLzl8v75V4ZLFCDzVOI6pUWr2ndLAJjC9OCpXBGQgjwwOOIOVTS 67mjq1Pwwll1n5H/OnA0jEG0xnNn9JB18WmGw5fRLensBSwqu7/fhAAxhNYBVwaN4RQIcd9D2Ww R7sxI3nWVf0Ig85A96J+nioLSkBypf0SnVfRKSUoK2I2b39Lx5OylVXGKPSK9HpM7os+VPy6YEf hneSyH8tRdKMNGtNfToYMits5MTu9gwFGehRt8IZL5RRV5hGHfZUIA+NwDeSDuOpgwBu0TLA5p7 Ob6CexuCUshbBmAzlf/UJOIxsDNW6CeVy5Met3LZvhPnDq2D7H/vsDfMsJ7M4ngGX6nJhLDwV/D uHgax6KZXwZkV/JCBE5UfXdNfx6oaFwOA1kyBWSFVqk6mFof8ma45 X-Received: by 2002:a05:6214:40e:b0:707:4aa0:2f1 with SMTP id 6a1803df08f44-70d76fb03e1mr4791846d6.16.1755635590848; Tue, 19 Aug 2025 13:33:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjMUMGSvjeQdbIF0CDnT7P91YufaBD6waHQI6sRs/n+ZhEnj+eKGwawlgjU4rExarcr2ll3Q== X-Received: by 2002:a05:6214:40e:b0:707:4aa0:2f1 with SMTP id 6a1803df08f44-70d76fb03e1mr4791326d6.16.1755635590143; Tue, 19 Aug 2025 13:33:10 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef351806sm2212969e87.13.2025.08.19.13.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 13:33:08 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 19 Aug 2025 23:32:58 +0300 Subject: [PATCH v3 4/8] drm/msm/dpu: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250819-wb-drop-encoder-v3-4-b48a6af7903b@oss.qualcomm.com> References: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> In-Reply-To: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1988; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=n7xaHZSSROB+2XdVsucGDeHL2qDsHnv9brWl2LaC/6Y=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBopN98gnguR5E87tGamvaP6AjPWdsyN4w0BBcCn Y3DFYviK+CJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKTffAAKCRCLPIo+Aiko 1cIrCACZlMfXC1ZcXwkARC5jlvs99j4JLrzEnSVtPScea3jfX6Xnp5Sy3egmpoSPlOFc5GNZuv7 tqe8otrW1rgAZmoYKaWQPBtK/LzQYdu3u91oc3Ox3LhGbAIyK5c7Thl64ufZc5/XlENC8WsV34V q1Xb0pEDgNJdOAnN0d5l63dDxaacI912igs103k+ehliPAInW7DUdnmfFXdbnIQ7H45O5AoSTOM d7yhDfGWM68rDdlB9nvgMh/Tgra+l/algQswzhz+QQtwewmL8JTifw1PjO2q3eIAGUeon50Ldr8 2F5d8cwAbCkKPqKEQsVJgrO+38orTXv/L+6y81c0EHhHs1E4 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: XDV5L6qKYkigLGqhGqU_BONKY23jQ5BI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAyMCBTYWx0ZWRfX+niHvDMe5Iea zqvPIh7TOW3gZdmGyIv0F9WWU3dQ1nzmhcd8frfdN4QPHIf1I8EIS9mrF/uECjCcqdLhaMrp6GH H31DxWGu62fHxbNzarX4XkuPOcg7EyisRrrLfuh5P91CRS4K4LaDTgj9eKfEOIF2d4a0jFfxGnL gCGlWOZz4ZNjtRH6raKGE3ZqE8d7mlHkphJIi9g+Vr193lR08nKBGzeJ4b51Cjl1kPh3XMsSHgc xhnjtcUqwWaqT/UDOtRpltNtrHS5GdFVQRXkXcz0pJndVCD69bezzdLLcarRpJvH2xJWpjSN1c8 HoSKca5L08/+oDTrbhefSkjS/zUM/FZgL7w8p5x3jWWa1HHWZz3N83Bd+4fYPvVISHJz0iJy29Z m3gI11Dp X-Authority-Analysis: v=2.4 cv=a+Mw9VSF c=1 sm=1 tr=0 ts=68a4df87 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=UqIHtJT1QCIVCAY24KsA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: XDV5L6qKYkigLGqhGqU_BONKY23jQ5BI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_03,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160020 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Reviewed-by: Jessica Zhang Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/dr= m/msm/disp/dpu1/dpu_writeback.c index 8ff496082902b1ee713e806140f39b4730ed256a..cd73468e369a93c50303db2a7d4= 499bcb17be5d1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -80,7 +80,6 @@ static int dpu_wb_conn_atomic_check(struct drm_connector = *connector, static const struct drm_connector_funcs dpu_wb_conn_funcs =3D { .reset =3D drm_atomic_helper_connector_reset, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -131,12 +130,9 @@ int dpu_writeback_init(struct drm_device *dev, struct = drm_encoder *enc, =20 drm_connector_helper_add(&dpu_wb_conn->base.base, &dpu_wb_conn_helper_fun= cs); =20 - /* DPU initializes the encoder and sets it up completely for writeback - * cases and hence should use the new API drm_writeback_connector_init_wi= th_encoder - * to initialize the writeback connector - */ - rc =3D drm_writeback_connector_init_with_encoder(dev, &dpu_wb_conn->base,= enc, - &dpu_wb_conn_funcs, format_list, num_formats); + rc =3D drmm_writeback_connector_init(dev, &dpu_wb_conn->base, + &dpu_wb_conn_funcs, enc, + format_list, num_formats); =20 if (!rc) dpu_wb_conn->wb_enc =3D enc; --=20 2.47.2 From nobody Sat Oct 4 06:34:56 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3D56340DAE for ; Tue, 19 Aug 2025 20:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635596; cv=none; b=NE8Z8rLkARPjdixGLtqT7q4ir54g3qncLUePPSUZM/71pDfc8Yxo46tDEitmq6mD7y+RSu8eeSgKlkhZCzAIwoxYEpTL2D6LeeY70mPy0sk0mgyL5eXCZbf50Z4NBjZZKwTwPTig+T/K44AZhFounCjHpFAEBsKRAv7uysj7wSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635596; c=relaxed/simple; bh=/fLUas0t6+pmOh4Lpow6ATkHgTqazIs0UqCL1npG8PE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iQiol4PgVVBBN1evh03bFOGkSfUpdfZMndA86rB6RTq3/faBbGpljtSEpRdDfIri/GqI2edPrxqFA9EriYwpEU4bADfM1OepYetbuCcKNZcAHrUBRCmAybatlQDycRVY4p0Iu6BXCNt8XoJ+bflurNJC3s2G8n2StKpSRHIFE5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bFhsWMUV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bFhsWMUV" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57JHFFps008279 for ; Tue, 19 Aug 2025 20:33:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qV+1O4itHxYPrihyEQKWirrQ3uqLooPtU+1YJ1+NTiI=; b=bFhsWMUVsK/mgqrG NSHunI1XmlSLZElpNwvyRiwZ/3mr5cI5bLIb1UdAw8uev1a4V5yaOTBLATlcDjlo W6T2VMXL2ko8M0yuICaEq3v0kpOrPxbN+up8MuHWL6BORh49znwHpRqIRtEx1mDc Q6cEZwHXvWMCRPEBCjTph0OTdUlQGHZihunQzqU6FywZhRRDCD4biEmpLD5B/rOu 1V4uzyP2u4Aki5+U6rZL/RzVEMNqvk82YODQUSK8pF0jMFx1zxqkq7b1qgiBgMOn zJaJnoJhF0utusTDfKMs7NoYxNWPE7UkQQoinG1T6hTc7q4t+al2Yt7fkJCIMBba D7heoQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jk99svfd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 20:33:13 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-70a9f5b078bso62492036d6.3 for ; Tue, 19 Aug 2025 13:33:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755635592; x=1756240392; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qV+1O4itHxYPrihyEQKWirrQ3uqLooPtU+1YJ1+NTiI=; b=lQPFuHOpb7SdIjiNdvSeXo8fj5ROtiMxVbgBiInYCPZJ2IaYX/yQD2eynGJqpDa7gH +7rIG2JE4A/u4IXn86ZNaPFSer5DyLM4IWTQw8vQP7TXEbbdcckIuy0TPPlSeg4qLAlo m9vlqGKfD3QOti39M+ieFxrKJd1nw7CEwY4XkLphzmvQyro46p7uXXqz8BSMMBDL+roB 3D1MLfiU8aKUHt96+fuIYAkgdCxA1GLC0+xOa4NrSOsIxgdA93Pahge5y3bzm4/Coq25 1joTWElK3aAtwy/G4ef/2Pe5UFZ4sKNOUINmdQznvqq+4NxNLTJ4xNvkU4NxvF+Rzte3 JPAQ== X-Forwarded-Encrypted: i=1; AJvYcCVtwxNx1G0L5PPeww/bPreXjc39j4PXOxnqISIpCL8ooca3OXXc6kFtSRJeD9wOLHlkWAsf1E1IcSBv4/U=@vger.kernel.org X-Gm-Message-State: AOJu0YwQXCi+eDG0msf9sYrRhsHipbn5mVOt1AsSGJF5JUtynuOg+7HF gN93TT+vyVif+lOdReHC7UXoYLrEOMQBOSxwGxklynRrx5P7dyazu1QSANngi2JIZFp+7irxMob kuvgEpaFQAYEp2HMyNJtXEnPrH9fG7npseryQagmgPARGb981iTq9jFtKabe2MXiJWk4= X-Gm-Gg: ASbGnctmBo7LU9nI2nZ1gYuUXVU4apT9LPLN/OZq+3N0lJi3TYgWpkzRLFVPtwCSYyK N8FlLj1HmmewE5/BdAZT0QKXEzK3mcBuMALdt3otbxS1zBH5Vh6vo8aQj07B9v4lm76FnGczvkK 2YJM90iqpJnhGFkWUDbRJZ9e5HLIrm8GOkalmQr8cNy7kotp+bEGaytObZ1jrOnjJ9XAoufb7f2 4RVo7GiYgUEQqvy1aoCgiRvcA7rueY2GwVKjcq3fDOXrjxgHKfLLRge7lc5wKDsRkU6VGYk6Xf+ TyBYzUXJ9JH5UFlS7vPYz0vu6xXvzz3qGTWdx4n3AoP+LkJv56GnHI/sRe7KxmgLfHCe0Jj7u5a fUVgNXMP+kyH2/kRkHpF+huE3okfJ/be9/XP4KXiEiluUecCenzGp X-Received: by 2002:a05:6214:f2c:b0:709:bc45:b9f7 with SMTP id 6a1803df08f44-70d76f57943mr5196596d6.14.1755635592226; Tue, 19 Aug 2025 13:33:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDKziY91eNkFu9vLBSCg4AutRFh33SncxQFOgdnIxYVcxqqICtOLRE8iLeaVF2g0WJIIGjAA== X-Received: by 2002:a05:6214:f2c:b0:709:bc45:b9f7 with SMTP id 6a1803df08f44-70d76f57943mr5195916d6.14.1755635591529; Tue, 19 Aug 2025 13:33:11 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef351806sm2212969e87.13.2025.08.19.13.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 13:33:10 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 19 Aug 2025 23:32:59 +0300 Subject: [PATCH v3 5/8] drm: renesas: rcar-du: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250819-wb-drop-encoder-v3-5-b48a6af7903b@oss.qualcomm.com> References: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> In-Reply-To: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2304; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=/fLUas0t6+pmOh4Lpow6ATkHgTqazIs0UqCL1npG8PE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBopN98epbohhlNRN+h1NEK1xOyQcbh7iWhPdJwQ SZcAvaENneJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKTffAAKCRCLPIo+Aiko 1bc7B/92b1GUfl19mLZdEdSZGXv/W6zvpY2/xRH/vjYXBUUv3SeYkNDpWGIJYROMyeOMzlycp0t 99NiJcVMQjHVA9trbZTbH2fW5xaxO9f2xrJEiQI1dGEDFh5gnRoB4crRkxVTZ4um6S/atfDU271 6TMvCy1ix69lUxiKHMicdLVMUhrFcQZOqKEjZ6ZsuEFxw7QP2lR4k1YTbAiQvvheHYuoUqQKxhO 2dPVz0uaYuzwXYgBK1DtPqxj7JW2d2/YLaeMirNINj3QRZpAf4MDcQojRSJ7ALdp4yatPvOIFx3 b5mdkvmeWroQkwwNhePwPDJItO+iuBw34yibnRlo48wTJ9Xr X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: 2Ub275XfgmA6Ld3hf5kgTivLbDorykQl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDA0NSBTYWx0ZWRfX/XN7I/nBXMRB WAMnCfd1yGbRF7X/v8JlRad/97D7KxUvSoZnp1OSe9V2SH3oH54k88pxQHoypHL0i6raqEQh7Pp A+IfusBj+YwZ9LGI7nneS8CrjClhJ5Cy66B11iQ1VNetwjHrv+kjXixRDVS3e8rBjFGHUQgEOkx tcNZzYtAslxoTjHFkLwqOLYLY8UtO+RhTUkai8rx6PuLjbVDBEyFDookS7Vz4HSR4nN8yaWrl28 YLSwmp+4U6EUgTbcU5xQ2gXmqZRrdyZbfy47nDBNfqgNACDE/2PHmcr54wP900810m9MPc7935i CsPgybeyjg2DHMgq7VOkK/ny+PacoK+TyeqJkVRUxpWY1nbrHls5iRmGxEfSlppXat2G5bwqxa/ RahExa4r X-Authority-Analysis: v=2.4 cv=IIMCChvG c=1 sm=1 tr=0 ts=68a4df8a cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=mhD89yN676IZukTL2GQA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: 2Ub275XfgmA6Ld3hf5kgTivLbDorykQl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_03,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160045 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 23 +++++++++++++++---= ---- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/= gpu/drm/renesas/rcar-du/rcar_du_writeback.c index 8cd37d7b8ae281cbc1fd8cbb243c621174517e23..64cea20d00b38861e22fc53375a= b41ae988ceb59 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c @@ -134,7 +134,6 @@ static void rcar_du_wb_conn_reset(struct drm_connector = *connector) static const struct drm_connector_funcs rcar_du_wb_conn_funcs =3D { .reset =3D rcar_du_wb_conn_reset, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .atomic_duplicate_state =3D rcar_du_wb_conn_duplicate_state, .atomic_destroy_state =3D rcar_du_wb_conn_destroy_state, }; @@ -202,15 +201,25 @@ int rcar_du_writeback_init(struct rcar_du_device *rcd= u, { struct drm_writeback_connector *wb_conn =3D &rcrtc->writeback; =20 + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&rcdu->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &rcar_du_wb_enc_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&rcrtc->crtc); + drm_connector_helper_add(&wb_conn->base, &rcar_du_wb_conn_helper_funcs); =20 - return drm_writeback_connector_init(&rcdu->ddev, wb_conn, - &rcar_du_wb_conn_funcs, - &rcar_du_wb_enc_helper_funcs, - writeback_formats, - ARRAY_SIZE(writeback_formats), - 1 << drm_crtc_index(&rcrtc->crtc)); + return drmm_writeback_connector_init(&rcdu->ddev, wb_conn, + &rcar_du_wb_conn_funcs, + encoder, + writeback_formats, + ARRAY_SIZE(writeback_formats)); } =20 void rcar_du_writeback_setup(struct rcar_du_crtc *rcrtc, --=20 2.47.2 From nobody Sat Oct 4 06:34:56 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDD38343D81 for ; Tue, 19 Aug 2025 20:33:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635597; cv=none; b=pr6w78dFbxMPm2oNLJGievnhS/NIefznGvFLu5BRSu4fo3Lb/sP5n6VIVXjQm0R3V9jGQAke0PwfaY+4Do/ueJ51x84rSSedk/lU5URL+dBq5m7v/Jwg0zvWVYBf+7+fHubR5KGA7TyWTJF3RfSa2nEOdo/WtHEAVV+mI2+USTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635597; c=relaxed/simple; bh=9kPXh1enzh44Jx+JV9Ql6fG94nEVIAR8Tv81e1DfnG4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QQR3ppESaY6l2ExecUKSX/H2RFZPqXWnHN8bDQ7+lA1B+xCIzqJr8z/4dvJTBN7GTQZwJtcERGwSDfpn7G++RuiGQW47tOt8grToih2TxM19BSJBp4JErGitlHTkzjB9+efelkvrO1nSGWdhLiNol5cPVivGuzberBXfBKR9fwE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pcI7/53i; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pcI7/53i" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57JHHlUg032432 for ; Tue, 19 Aug 2025 20:33:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ndEz2xbpBNb9n5L2RWMR2nJPekvJ4u9Qsxz7tSzeQZk=; b=pcI7/53ilcL/mke/ pFPxcZ0iyDVn+aikqejKPYNI5M4gwpQ7Tcs9PHfZQKBYdpBLpCxatL+NffQnrg8F QEM85eoyQmp2/gTLmZNXcEOY9VWDtXSCE6t33xwfm2whXkLX+BEVU+12pF0OtL6L au9pE5/8IRHhA6h1udBdAG1dKXRCIEpev9TM31QSDWxgxx9VcELviP/dOu3mMS5k lo6t/TZV/YEUFSSoaS2Y+Pd9eoE1kDWuoY6KAIsj2SHCTbaS8ohFK/3a+Jxgf430 4YNNdUUPqTfKazvmDW9a1TF303UM+QQZnc3uqpkMdVxW1OdzDyK0peAv49EEEGgX v/i8tA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jj2uhxmf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 20:33:14 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-70a88de1e26so202824396d6.0 for ; Tue, 19 Aug 2025 13:33:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755635593; x=1756240393; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ndEz2xbpBNb9n5L2RWMR2nJPekvJ4u9Qsxz7tSzeQZk=; b=WP1rma4jCpIpB16v/4XHVEwG+ppEC/1Imh1EtOzXu89XojpjY9OzfTfiLGmhUNxTXX m8vHnJImWcGxd33UZvWGCUNA2g/GVEq8YJDSh3YCtyLfDkSVF5Pvd0QumVrWXoJj08+j vMRtewIIfDrElXkOcp0UUZ7TDa3Zxhbz/Oj+RJXk4rs/c4emtr3HkV2KTxO6YNIGTGkv CXg7xwrjNUUZDhXadjhoCIN0LOyb3TYRtUafVKAZGOrCbM2MTFuFxGaR1oLj3mwIRZAt NF3VwozUiSbtWCzwRcOye3h2XZ9QPbxt5zJgu45D6zyZP356t3rp6rW0iT8yFXOpx0k3 Nb8g== X-Forwarded-Encrypted: i=1; AJvYcCWizUAqaxkJNqzBpZJm0N2xXmqOPLAgH7gkja9t5UBDUDiSb9+Bb8pFcLrmSFFm/ABFWyr1lvyTEh7ZCvY=@vger.kernel.org X-Gm-Message-State: AOJu0YxG7eyLi0WqSCYVDhgF0HuydVRZXETMhcFnhb6T8OyUOy2x/42Y wG3xn/IOYlF+4Mc6VoNG3E21VlGjSGyUDOg8NuFDLUecAZ1PT95Tt883lYIQHGR0GRAbYwNJRXF T6CpUN72nqBM/abCNLMLj8cvgtW8hrig7ygiOVVrgA8uEyKmqkonbxWh1RUVpmJQeGAk= X-Gm-Gg: ASbGncuUDibn7Z7Mn+fC5WRpjKpdZsAsM04NemSAD/W7XgXaDKtGUvpj8lfItNIqjyk 6cjZ5LYTKjRpwKlTlwwDT99iWD5sRKpbSqCMLRMaxE02RjA2nkOFGxNNd1mngBwzqL+j8M83Rax W4yZIwj6gz2NId6/LbBVXQjeRIkk4SAxWUEsN5OCVpKUss2Z1l2pwBEpilhDWvWbwx7sOpK9fDZ nGY8y3nTA3Zaybj745oC+ENqTPUyp6D9g6DQL66U69foW7tmb77J0FX4lgDIuVG0DtF46yQAi03 +nEgkMrTPxVRzTbSW9hirXX0QlRohLh2GqdazNA0aukUYyyvoicXWv1/Iu0ZoP3glOBCR+iVDJV 4YdCDL8V5HdWplHgfnB8Pamt560Xvs9/jriQ1Izn/u/li/hsAK9Ea X-Received: by 2002:a05:6214:2526:b0:709:90d2:4628 with SMTP id 6a1803df08f44-70d76f92bf6mr5416866d6.19.1755635593519; Tue, 19 Aug 2025 13:33:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFxihLKXa7JhuwwkeFQ0p5zKqK7B3jNVOf3qZbLFjzpePpJRXKGGlC8e34zDhvw9cZPJCBDjw== X-Received: by 2002:a05:6214:2526:b0:709:90d2:4628 with SMTP id 6a1803df08f44-70d76f92bf6mr5416336d6.19.1755635592861; Tue, 19 Aug 2025 13:33:12 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef351806sm2212969e87.13.2025.08.19.13.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 13:33:12 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 19 Aug 2025 23:33:00 +0300 Subject: [PATCH v3 6/8] drm/vc4: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250819-wb-drop-encoder-v3-6-b48a6af7903b@oss.qualcomm.com> References: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> In-Reply-To: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1739; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=9kPXh1enzh44Jx+JV9Ql6fG94nEVIAR8Tv81e1DfnG4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBopN98FeUHqsRMxqI2y7bSGcGGmIQ2ngHpJlEtt 7qfS9PHwcmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKTffAAKCRCLPIo+Aiko 1aEoB/0S0UbRv6Cn22F8M6h9l8cAG1g8kwox9gPMNA16YkeVOr6K95UiTo3MMjJp7r9L+aqIiYW 4VY008h32adgxAl6T4rztlv/gbNcK6wpN5EIJcGDsFjXYG6mcjcx1tPbG9kOmBqd3reRp4s1wOJ KAz5KS/AtmLz2CYVi6vPsL1PZXzn0Uc9Y1E7/ZG52uZtIAvqY2e3ToYbYtmTF7RKaLy/uIYmZMS 2VVTZTlmjclBLLn02HJiSZDsiFI9KByjQEssXDY1vWz0MOTsCsts7Jrp8LWNtE7St9nwsiUNJWz E+fzSaHhOeKC2+ykQjdy0xhRKprf1e1ISuEYVrlH7d6pc9Tx X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=MJ9gmNZl c=1 sm=1 tr=0 ts=68a4df8a cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=hRdDZflY9wZGYtDLNskA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: h1Hk5x-rQvX9Lof6Kabyr5yy8tjQLtxw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAzMSBTYWx0ZWRfX45UTSUWbtREi OYfkn8WJrI4kHkkHoqVCqre8yev0ne5nEm1VXvetBJiFUJAtOBAE6ppigQpD2tsQkpLi0Kt7x92 Pqs30iVxGs1Vtx0eNmREI+AdEA9qw+0kCAK0xPox1xCriqRVPkPe0XXryzvv2eB/by1XnGCKZQX 1tSQne7CMTxAYTkj6Bu55nVHq8l61dRWad+457HcasWWsvJ/+DagK+1fifrq5uKaU9AdhK+NJVP h+sljTolUkV7tfj76rXXfUSyzprHTnWZ1ng6PloZiesLKFsLHK3cSnpDV5JsubdpCuJp9kxOXoF kh1PU6jUo/WIEvpb5vBUNAFchV0FhuTMbgkxAwdAl/wxHuos4Lauaq9WpDCRFAjebQYdWCOb5Y7 pSrYqA/d X-Proofpoint-GUID: h1Hk5x-rQvX9Lof6Kabyr5yy8tjQLtxw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_03,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160031 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/vc4_txp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index 42acac05fe47861ced226a4f64661f545e21ddb5..fef4e4ee47cf41d40de47c5201f= 0349dc36c56bd 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -377,7 +377,6 @@ vc4_txp_connector_detect(struct drm_connector *connecto= r, bool force) static const struct drm_connector_funcs vc4_txp_connector_funcs =3D { .detect =3D vc4_txp_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D drm_atomic_helper_connector_reset, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -601,10 +600,10 @@ static int vc4_txp_bind(struct device *dev, struct de= vice *master, void *data) =20 drm_connector_helper_add(&txp->connector.base, &vc4_txp_connector_helper_funcs); - ret =3D drm_writeback_connector_init_with_encoder(drm, &txp->connector, - encoder, - &vc4_txp_connector_funcs, - drm_fmts, ARRAY_SIZE(drm_fmts)); + ret =3D drmm_writeback_connector_init(drm, &txp->connector, + &vc4_txp_connector_funcs, + encoder, + drm_fmts, ARRAY_SIZE(drm_fmts)); if (ret) return ret; =20 --=20 2.47.2 From nobody Sat Oct 4 06:34:56 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F643343D98 for ; Tue, 19 Aug 2025 20:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635599; cv=none; b=a2MVkwLdK4fyEUVdkdLPXgJYR3RHgI+ukDdapcaegWooMZMu2er/qFkr3CcAiLxrflYgFoX2pVrzvbOqPYz99nMOfz2GjLYO8o4u2uvVHud8PcSITpkb5OaDUl8mjqhLnRk6iQY0FHcIbf8vlKOPvvUiLk4WTL9HAuoT8kQueag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635599; c=relaxed/simple; bh=Tfx7muI07rte1gs226Q+hRYOArvmNBAMe2ZWuhmuISI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eZKQflskcPWQows4ZsH+jeGq0/0kOwJKIj0ZeBHOwpBE1ZFDCRM8AJi2tsICLNAMVITtGQqSzmXNFXVnzh+wKsI33kv7UtHK1t/GfvJXces5+weCzOWGZ6Hnb73ofNso3Mu5yGOMaqFa6RixOWLwp5npfGqNOM8jDbF0uLJWjZU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hkRl9LDi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hkRl9LDi" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57JHd5LL030474 for ; Tue, 19 Aug 2025 20:33:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jvX092/V9dwE/NzPX2FObQHrrP1GpzHfFltQW2JSWGY=; b=hkRl9LDiymd2qGpZ Cbw4FW2f9rJF0wEieQzqe8TG+Ys7gFFG0JZaGsKgR0sfPf77GWV7Nm8yaraOwlyH Kq6tr1C9+J5z2Ty4C/sqb9rtyrRIeFQcmlK3zTL9Na3RYWLHpncroFVikj5Rh5nY 6FM8FFtpTX8kcdOW6Vb8l4gUCDCOvGmjFPioVnU6l37NjsUmAbJji9+PelgXAjUi w4Q9mQ9PRYgWdsLoc5GumltwCBTYnkp5rqgjh7iwial7dBsaaY/N0WqAGiGilQdU /tGqZ0doGVxCYSBZR1mQ8DU6SReReQ0PKMsCwCQ8RErzO49Wwau9JMrCMqYriOeI YxdHoQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48kyunx4n6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 20:33:16 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-70a9f6346f8so123345066d6.3 for ; Tue, 19 Aug 2025 13:33:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755635595; x=1756240395; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jvX092/V9dwE/NzPX2FObQHrrP1GpzHfFltQW2JSWGY=; b=LbWz91ORLvG4Cm0xrEIoPK3lNvyVVD1t/oi9p1aZpqozGLBzMZY0NrIhfc1gSx9WVp uhmxGTe1QBHwCVy1B/CKghZOpoAcilNjtwYfAlbftEaI+aSRFiNO8Ga10b9X+0VvRHwh oh4uRgJau8h+JjkSClPcus3XPbFQuUrC6WY0w/oheYKnJeyzaG6QRH8ym9GLLFCk7uII +4QWljKGe20FBJfdSZY4qSyNaWqyrqSbArZKQBoNJvK7MXNJ2kFdhtHZFDoKv1V7zaEL b/3hiLbi0uSpjSPE8vUrJE+po+Zau3SjQBrvy2euGmV6Kg0Y6UESO/6Ro3omVSeHJaND crJQ== X-Forwarded-Encrypted: i=1; AJvYcCWeAIxZwUo+pHAygz4v+egt1Nw7skZOSC/djrtLHX7+vbWMy6a4XZQvIKwR1dMijq32RqccXWrfpX3FcUY=@vger.kernel.org X-Gm-Message-State: AOJu0YxuEYgq/1ZtKL2Oj/g1SzIyeusrmOESMJRwbiGEj8XNuaxBYOVz pj17GZPsHO0bFbiQmiarvQ+UEfchbV6rRusdYRMyGbO8uV83Jl2jrlLb0xAHhq6aLBEfSgNOX9c nzhlEN1ufdL7I9FqTFs/bZfL09rsAtSsJWkXADlN9lafoi4p+ZyzpAZCV4NYNfWamMYA= X-Gm-Gg: ASbGnctNnQmeTbw78bcR045+mTD3MU8eLUWPNe1lj05kOxCixj3yElBOXn+Z4llJI5a 3N4HYf8oVITtM4m4cpAzffjv1Gi8C1h+2T2azJZPdKiPv7noXo3G3eAQQrNZksQzxj+7d+i7eem wt2jyGRjtA39U001gtstdAzDHgKu3XLTKjr5nybJ8LL2j5NhO59sck+9d5j3MhQqxifdbAkDgNH yydP9YY/TxGPIFUcEF6CwR/kwG7Q56Q6Y7Nke5aIg2ikUcnyDXwJI9y4A6b/Pz/A0OcVaQV0/Wl /pJr5lAQcBOfRyXTkybvlmB9fwR1KtLC8gPdu3LHPrdr4HptvZcUk8LfrtvXyMPm4qIczcXfQMz lmhlhv5z1yK2KjRPOMw9pFftjj8P+DGE6nqIG4ubKkLmrsyB4/ILf X-Received: by 2002:a05:6214:e41:b0:70d:6de2:50cd with SMTP id 6a1803df08f44-70d77151247mr4493986d6.58.1755635595120; Tue, 19 Aug 2025 13:33:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9xDEb9rwYCS8WqAgM9AnhKQP8F/GYNkS59+4ktlhzxroNIvOhQps/yxg6kZP/FfKY8Ql/4A== X-Received: by 2002:a05:6214:e41:b0:70d:6de2:50cd with SMTP id 6a1803df08f44-70d77151247mr4493396d6.58.1755635594371; Tue, 19 Aug 2025 13:33:14 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef351806sm2212969e87.13.2025.08.19.13.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 13:33:13 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 19 Aug 2025 23:33:01 +0300 Subject: [PATCH v3 7/8] drm: writeback: drop excess connector initialization functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250819-wb-drop-encoder-v3-7-b48a6af7903b@oss.qualcomm.com> References: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> In-Reply-To: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4592; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Tfx7muI07rte1gs226Q+hRYOArvmNBAMe2ZWuhmuISI=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBopN9947PbKAu+7+CUIfGx9WMCXm/z1B78epETI hPM199Q9DuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKTffQAKCRCLPIo+Aiko 1RGOB/wNXkcFoxuLAJNkeEum/4zloQY+WG6CED7BLahxiCH2kQfFQcxOuvNWMMXaEqDQL216LeB ZbOWSqy6HJ00dZsO1O7ipqK579LQ2XUJM9JlHUUL5y8NLvDuuUM1EKCuQj3zWwYEohl48fG1V4u CNoWUsQx7aLwvlokBWFasOGAN5IcJJ9+fg2SzVYvrV/GyXVlnUiNQnswjOEaFmEeWw1xN2a+5Uk l563zrlaIZwEhnOsazuHd9AvOzqe6Kia26+XvPFLL0G5M6Y9B4ADOhKRUWcVskHr+k/Kz+mHAPc k6+bOvRAGUKJIFEgKO3F8YUgxmulZrA6UIchfRB4kSFKOWt0 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: fQS4ttiAxqDfyxP_tTmD2LP8XnVtojXU X-Authority-Analysis: v=2.4 cv=N6UpF39B c=1 sm=1 tr=0 ts=68a4df8c cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=3owybDqXPaZAjLikVYcA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE4MDA3MSBTYWx0ZWRfXxuh+XL2s1u+X OxGu1KUa6AXhJj1ggNWuXBc2BqOgKsCeGW3lQZFYk3wcCr8J6Wuuel4FVh2lY6rorfI+MTdpVtp nuGbEy58HIk6urrlwablz9XN1ngrfPLg+7ntWhNi2DfgraG77hEqFaVpr2BMNaiOOJsxG4ZwVrR 0lIpSj1C6l9lPGp81PCvodT1q6ZMZNDqdi5tng/VuQHheq/rckomaUXuHGb+3BE7b80kTBK1nGk XAKGbXRl5hgMOTQRQdiOeGNkevgShrTcPlZo3oalPWR62FhHlyIy8Hk4tuZGRDEa6BTBFsLJMFr 9Qt4a+iO79GuBqOXutgOWvdETv3DLk+9TOuXEI2jhshSKTF47s/qHJfua8GdWALslG7l5lII8EH kdtJlQ8B X-Proofpoint-ORIG-GUID: fQS4ttiAxqDfyxP_tTmD2LP8XnVtojXU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_03,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508180071 Now as all drivers have been converted to drmm_writeback_connector_init(), drop drm_writeback_connector_init() and drm_writeback_connector::encoder field, they are unused now. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 55 -------------------------------------= ---- include/drm/drm_writeback.h | 18 -------------- 2 files changed, 73 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 95b8a2e4bda69230591b50be15d14d0b3692373b..1a01df91b2c5868e158d489b782= f4c57c61a272c 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -142,61 +142,6 @@ static int create_writeback_properties(struct drm_devi= ce *dev) return 0; } =20 -static const struct drm_encoder_funcs drm_writeback_encoder_funcs =3D { - .destroy =3D drm_encoder_cleanup, -}; - -/** - * drm_writeback_connector_init - Initialize a writeback connector and its= properties - * @dev: DRM device - * @wb_connector: Writeback connector to initialize - * @con_funcs: Connector funcs vtable - * @enc_helper_funcs: Encoder helper funcs vtable to be used by the intern= al encoder - * @formats: Array of supported pixel formats for the writeback engine - * @n_formats: Length of the formats array - * @possible_crtcs: possible crtcs for the internal writeback encoder - * - * This function creates the writeback-connector-specific properties if th= ey - * have not been already created, initializes the connector as - * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the proper= ty - * values. It will also create an internal encoder associated with the - * drm_writeback_connector and set it to use the @enc_helper_funcs vtable = for - * the encoder helper. - * - * Drivers should always use this function instead of drm_connector_init()= to - * set up writeback connectors. - * - * Returns: 0 on success, or a negative error code - */ -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs) -{ - int ret =3D 0; - - drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); - - wb_connector->encoder.possible_crtcs =3D possible_crtcs; - - ret =3D drm_encoder_init(dev, &wb_connector->encoder, - &drm_writeback_encoder_funcs, - DRM_MODE_ENCODER_VIRTUAL, NULL); - if (ret) - return ret; - - ret =3D drm_writeback_connector_init_with_encoder(dev, wb_connector, &wb_= connector->encoder, - con_funcs, formats, n_formats); - - if (ret) - drm_encoder_cleanup(&wb_connector->encoder); - - return ret; -} -EXPORT_SYMBOL(drm_writeback_connector_init); - static void delete_writeback_properties(struct drm_device *dev) { if (dev->mode_config.writeback_pixel_formats_property) { diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index c380a7b8f55a3616fa070c037d5cc653b0061fe6..879ca103320cc225ffb36874190= 88361315535fc 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -24,17 +24,6 @@ struct drm_writeback_connector { */ struct drm_connector base; =20 - /** - * @encoder: Internal encoder used by the connector to fulfill - * the DRM framework requirements. The users of the - * @drm_writeback_connector control the behaviour of the @encoder - * by passing the @enc_funcs parameter to drm_writeback_connector_init() - * function. - * For users of drm_writeback_connector_init_with_encoder(), this field - * is not valid as the encoder is managed within their drivers. - */ - struct drm_encoder encoder; - /** * @pixel_formats_blob_ptr: * @@ -148,13 +137,6 @@ drm_connector_to_writeback(struct drm_connector *conne= ctor) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs); - int drm_writeback_connector_init_with_encoder(struct drm_device *dev, struct drm_writeback_connector *wb_connector, struct drm_encoder *enc, --=20 2.47.2 From nobody Sat Oct 4 06:34:56 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B26EB345751 for ; Tue, 19 Aug 2025 20:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635601; cv=none; b=PhAwvD1yck9Ttel78Y4o+OGVYDNzK6HWbZKjzkduJXoWTcDC+KGjQ2YsXZKUiELFLdt2ZXWnip1BsrkAYZi0AMzYFsT0MxTpU4qFNP3Y9kslIC6Bqk85YQy8h5yR7QdVjgbotuEJDqox9uOGR11QT7Zn30Xu0fYf4j4Wokywpuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635601; c=relaxed/simple; bh=AaZVjuS1W7Ukw+8AzT9N6e3I54ede+nAI+GfJJ8GCnM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=arnNL/6MBFEn7WtmzZmPJ1bmx8+M+baUzU3hNyuXAMVtWXUqmlThw+fXqbB0Mkj6VVlQwOuKvcaF9njnJEuubWkHUWOsQht2RGq5FIL1EU6I7Y60Q6cA2WIbY+iGzLsYE3Z84oW8h77UNSjyYf0FyWwmh89qk2h13Zi53LX+1Yw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NQ4lk0PG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NQ4lk0PG" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57JHAb38023048 for ; Tue, 19 Aug 2025 20:33:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TbQAYOijnA+OwP4fT62BQ14vH/cW4cuE/yCXav6j8bE=; b=NQ4lk0PGxH9zd8rS jQMLEIbBuOnP0bMp7r3njdORq03oP3sTV3HCagJVJCbqP7OPz9Vk2GGnWiVxAXw9 X5RfFksrq0jtW2+PL8/T156XPpdQp4H1t1uWJjVP0j2JFMQO136CABxChaHZjYru RlXTZK/9LEr8KeA9setcBZLtpZvWQ9Ueoa673eBekunJg8qUWpdGXNDNOtAoMxGZ 1Cpb+jSHIpavEW5rmkcxF9DoOyMu1h4RFsVb4zxMx5pDjMqNLaXFk+9OHrrNwcUx NnToL0Fq8qU80z5Mwe3FqYeRdd1dCdIe+TLaT1y403w31broLxqqwfGje6OrW1Hk EgTaYA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48mca5kmht-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 20:33:17 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-70a88dd1408so127990526d6.0 for ; Tue, 19 Aug 2025 13:33:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755635596; x=1756240396; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TbQAYOijnA+OwP4fT62BQ14vH/cW4cuE/yCXav6j8bE=; b=kQbFCik35kB6+iEi/fq+dUjKh/3Jbj6cBedBncahLPfCc7Enu5BfQjsVRXyRTe0Cam 0ZXN0k0fIrlbydlccWWikY8aAeOQa87N970qNiffbdK/ibjEqmsjJsk+2r72LT4G274L 6hiq91KyrVOCsO7wrypXPmCLgZpBGDG+eJO9Z4yX1+/y907nh8g5SEBAWn7I5eJpEMfA pKNDm0WM6qHm2f/LYMSpUfROO0INBi3pLDobMYl6LYUUVwnggar5fisM4zkV6eP3MkmJ ZdErEfV+U5JHrLAZXRdxIU7M7n/PuL8NauSTmALxSNmYn9KEV/I37ID5HBPbPS+0s1Vt Bpeg== X-Forwarded-Encrypted: i=1; AJvYcCWiVo2GV3ToW8Olm8UNQjtx9qPyQAVCWiMeZaE7jgmaSV1fFdcULolrl0MwPaQUFczna+t0x3kOrlwyTyo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywi1a1ImWUBU2XdfanIE41lwsSimM1Iq0+lJw7eVpvlIddVbq0V pVVIwcJKBAq7Y9g4F8cTTxMLTeUbVyP8MrzC2mXlacl62M3gx0yvKtbTJX6r20yRruV98gFwrZy nW5o9Wj1r5Okw0mOjFhfmqALmTWCtXmtgrV3NX7fWecYDhw7DHYIa5c0NcHh9pjmeX2g= X-Gm-Gg: ASbGnctc0w9R++L1kDGPZV7+7B9NQqS6x10FPe1W7ZG63j6Ud+XaIK7axMmg+PNCMTK ePh39zBLrFsYi+gMYxGSP66aly7KtkvOjudhXd2A/xB3mZaEogd6m1vwPYFq7zxRAK+EOD2AAhq 5mjHJv4LhqnnS++iCQoUo+YcSsfV5PUy22RJfb7uTyfgBqiTB0R63oHomKPeUU6JtbM1JoE9jjL 7QasYE2YAfMzmKBL2ODNjqXcYLqmRR+pzW/a0OmH+wp3j2az1wAPnRh/oCFs06n+O4E6roZ2hsu 6c3d13RnlKe9Htb6fBTWPqRvhUu/sFwfSHGqgy4VVb/R8ZjRqlXO6T/ECTa3OuSNNHkpd0gkP80 +6GEkT7BcMfDg6rbTjR5D98jNuFMK218dcQF2+boPz3xmJ2PCgd87 X-Received: by 2002:a05:6214:5086:b0:709:b691:c9b3 with SMTP id 6a1803df08f44-70d76fb432bmr3783846d6.21.1755635596461; Tue, 19 Aug 2025 13:33:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCD6S7de5XOrwmykrvu3dZltJcf+eQjH0NdzU2XfVwlV04v3hGebHiPXpwj+mmyQIUx9Iqew== X-Received: by 2002:a05:6214:5086:b0:709:b691:c9b3 with SMTP id 6a1803df08f44-70d76fb432bmr3783376d6.21.1755635595810; Tue, 19 Aug 2025 13:33:15 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef351806sm2212969e87.13.2025.08.19.13.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 13:33:14 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 19 Aug 2025 23:33:02 +0300 Subject: [PATCH v3 8/8] drm: writeback: rename drm_writeback_connector_init_with_encoder() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250819-wb-drop-encoder-v3-8-b48a6af7903b@oss.qualcomm.com> References: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> In-Reply-To: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3126; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=AaZVjuS1W7Ukw+8AzT9N6e3I54ede+nAI+GfJJ8GCnM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBopN99dm6iqCmd2YJ7ZHRhkVfYmgs7Ag8kc737G sg2F0T336GJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKTffQAKCRCLPIo+Aiko 1TZgB/0SmKnqbM0pHSATUnozt7o8QQGkCCESrW2V+DReBipmXfhrvcZS4AJQh24WpEQYL9nol/c ebxClJrvV1du0OGYX5iNJzyxgk7XmdDpAqG6QI6xjv23Wp9Mk49FZqWe5f2jqb+DpySqmz5wQvm WQQrRRUHvKQqWfz3SQV/PEd2/8R4fTf8t0t4Zd3aBLTwVbp+2YYede7DU6arrfJhv3FSXsH0j73 DFlDjkj8wseSw79ynmOGSQrLv3XU75F3GfOBSZ6tw/V9uroFRBeDs2C2d8wSENzcp12l35llhYW NphipNhW9G2yKJehjLOfbVta9tJt3XVL9mdTv2lg2+L63IFJ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=FdU3xI+6 c=1 sm=1 tr=0 ts=68a4df8d cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=yAS5wIYi4md-6cvEWsUA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: A3fPZvkhnhrSCNaOcKJ1Ue_yx2lTpcUV X-Proofpoint-GUID: A3fPZvkhnhrSCNaOcKJ1Ue_yx2lTpcUV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE4MDIwMiBTYWx0ZWRfX3wnudljBL1Bo vh59XpjW9B1u5SFaAD7laLTsnXBYjwSs9vTlRXb5bfomhcw+kN7QwQoQqf0z0Yvf+kHZpMwzIPg FIUSmqYT2EfIPzWMByTL5w6qbeTxr4QrUb9W6BTKDnBJDrwADxJ4rCWTqpPDi6NCiqvpg6bkh2h pbddumR2VYdIvhmizbwAtwAYujg1YjdHirZaCCmtmri28lZ75Bb/liWSJip87G1dPA0KML9jUZ2 2RgnYqcyKGJCHj6uHqxlWkAY2chJ2IbCYN0B2BmmfVaYvcSEzWnXHvsRLV0hyDXjMykR5htZO01 nqsIeDlwhyUYFHoAZlyo+q9V3Q8o8JhYNoIz+WrRnG9iX5bU3+K8SM7giHhIc6xh63621trntym eSNCTe+6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_03,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 phishscore=0 spamscore=0 malwarescore=0 priorityscore=1501 adultscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508180202 Rename drm_writeback_connector_init_with_encoder() to drm_writeback_connector_init() and adapt its interface to follow drmm_writeback_connector_init(). Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 14 +++++++------- include/drm/drm_writeback.h | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 1a01df91b2c5868e158d489b782f4c57c61a272c..ec2575c4c21b7449707b0595322= e2202a0cf9865 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct drm_de= vice *dev, } =20 /** - * drm_writeback_connector_init_with_encoder - Initialize a writeback conn= ector with + * drm_writeback_connector_init - Initialize a writeback connector with * a custom encoder * * @dev: DRM device @@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct drm_= device *dev, * * Returns: 0 on success, or a negative error code */ -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, - const u32 *formats, int n_formats) +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats) { struct drm_connector *connector =3D &wb_connector->base; int ret; @@ -284,7 +284,7 @@ int drm_writeback_connector_init_with_encoder(struct dr= m_device *dev, =20 return ret; } -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder); +EXPORT_SYMBOL(drm_writeback_connector_init); =20 /** * drm_writeback_connector_cleanup - Cleanup the writeback connector diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index 879ca103320cc225ffb3687419088361315535fc..958466a05e604b387722610fc11= f9e841316d21b 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct drm_connector *conn= ector) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, const u32 *formats, - int n_formats); +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats); =20 int drmm_writeback_connector_init(struct drm_device *dev, struct drm_writeback_connector *wb_connector, --=20 2.47.2