From nobody Sat Oct 4 09:42:00 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5AB826CE13 for ; Tue, 19 Aug 2025 06:36:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755585405; cv=none; b=FXTGTNQ69SXTZhk/XT7Qjdaov0qHryECOxgd8pOodXnNRcJhqx/HDy9TxZe9Fqtyj69qfb5O3lqL/pFGSRay+f3xkhiWpxVcpWmC4dnyyd/YHdtuyPq7pU1ppglpd3LgvAboDg2lIR4r6ZuWSXV9Q+xQsOZNcLZLiRb/ufy6tvk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755585405; c=relaxed/simple; bh=rgkE1DP1easYS6YslKYK9Bbq9OWK3nty3gdcQhkYooc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Intl1VaKdot90Jsy7BXW6PCRzIoROZ2Tp+mcXCl/Xvnn7hzwT7wbXrRjXab3zVNR0uwqAKWJS2fCxOn+qbkCKxtpI9FsA5Z+tqVQxlRl4uge6V+CZSo3N308ESecMrLKVbpkKRYwYt92l9uY7WbpfhwNAO/Jcrumd+iYNg4Gm6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZW++GaR6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZW++GaR6" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57INa2c0001578 for ; Tue, 19 Aug 2025 06:36:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jWZPw+Dpps6jokruu2kK5mo0seIUmSLFHBR/QVxbsPI=; b=ZW++GaR6r2FuhTkw 9b5wRt5o8NYv2lIEhyRloLp1OufW5ndt4sDKqW6IbiUGfuJghLP/y8yObQhdQ8BV JLidfzkhERA4FNb3mqGOzKEwnG2JacuY9azj6mMDlZrfyHn+5LXWcecpvhZw3CYf 6Kejwh9NwHSRnLAcxlnFY2vedyVkCdvC4ZFkd2w+cX++mpSqJok9c0pZKqr8RKxy Jn6VM2NoDbkvOuHKM8hH7CAGA+QEF2AT7MKelyp8dRkZ0VYmlLcVYcKqxJgCsJVL ksmBWCgKDWd+uRZr75vwdgdbHX+B7i7M5oqIdALqfEZANG6g9ao/66Bal86onM5O DsGPYw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jk99qdg0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 06:36:43 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2445820337cso53087125ad.3 for ; Mon, 18 Aug 2025 23:36:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755585402; x=1756190202; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jWZPw+Dpps6jokruu2kK5mo0seIUmSLFHBR/QVxbsPI=; b=MensC2bBAU+hbNwO1F7ki/I4MJXpZG1snN+ZWNhTJSijUqbWok84NIWkXJgMcVMn+Q 04DHnRoEeuMdkcXTUfLAABVpO+LgNrxc2YodupRfGlrHegGMcpxB+23nN2FpwemD0QKl ts/RLnP4kYEk9rPvXxnielXUedPcguWO8+m2oV46dWMIMDFla3/68+a7sunPPXADDybW 6MJcvOUaJFV/LCHDS9PKBvSIMKg93xGV5u3fsNSwTm23r79bVHCexSNpiEkOlmOPIX4r 5HyZSfTGAXfL4gYvs1ZVsfOISV0ZHo6HDb+jW8nLfJfSpwJ82XRwkrmNnqvhPMMuS373 ri7w== X-Forwarded-Encrypted: i=1; AJvYcCVKSJ9xz6eRNKgIMvkFD8G0G9hdw+15AxYQvJqpWA2AGjvtgwYzTRrgHJIauGD0xwY8EXtYqPRQJEKMJ/c=@vger.kernel.org X-Gm-Message-State: AOJu0YzH/i4V4ZVyB3qma4mBN708XlHJMkZgTi6Eey9hdTY0uDnz58Vp seW3U0rvizpFCwtd3epS7620dqt5aCI4uPkFI5EByS55Y5unoiMew3qQWWxmeJ8hrH0p8SBFWy1 rWJfAmvgq0SuDQvCJazMejtSX2vOAD+cBXpaVMMSUVUQ5RPQStTm0O+jrj3O6tRTDcjI= X-Gm-Gg: ASbGnctNtp7TxHIL/Vt1JULhD4LSrS+U4p6dApAAlY2QbCWG7LU+U1cWb1lB49bSsS6 ahpegeNym1H/qFQjaZIZPIHdnj9s8VWpkB4dNktrX18CNifiksOg58G5tlZSxcZVqZyZ5nHdLpo izjDmocR/TRW8OLHDqWyNowPxD2M9flLebvwpxaDL1UCO7FmQP7lprxiWvQAR5sd26BCIQergbs sZD7oMicGMn2V20IIvro7bNPk9UmhBWKXw/FlfaB/ZQ3PI0ynz9ta2xSqSYrMVqeBdTk0evqqdp urLiFfFdewAC0OvXwfs7LZDXeJ6/DSuFPmdvdn1wTa8HhGFYSlxIEtI2hnRhcvprCUbJWShm39r 4QguWUNKbpctJe3ztZInGqV2FTiljteZvXQ== X-Received: by 2002:a17:903:234c:b0:234:cf24:3be8 with SMTP id d9443c01a7336-245e0541d6dmr14369125ad.28.1755585402155; Mon, 18 Aug 2025 23:36:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHl/lNABQK/kpg0X2OhEKp4HNBmGeNVvVA1WkA/paFD5ccWwopJ2tFxVPde1x3VdbYJUHJCYg== X-Received: by 2002:a17:903:234c:b0:234:cf24:3be8 with SMTP id d9443c01a7336-245e0541d6dmr14368825ad.28.1755585401656; Mon, 18 Aug 2025 23:36:41 -0700 (PDT) Received: from yijiyang-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2446d54fe38sm98120455ad.135.2025.08.18.23.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Aug 2025 23:36:41 -0700 (PDT) From: Yijie Yang Date: Tue, 19 Aug 2025 14:35:56 +0800 Subject: [PATCH v4 1/6] net: stmmac: Add support for 10 Mbps and 100 Mbps Ethernet speeds Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250819-qcs615_eth-v4-1-5050ed3402cb@oss.qualcomm.com> References: <20250819-qcs615_eth-v4-0-5050ed3402cb@oss.qualcomm.com> In-Reply-To: <20250819-qcs615_eth-v4-0-5050ed3402cb@oss.qualcomm.com> To: Vinod Koul , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable+noautosel@kernel.org, Yijie Yang X-Mailer: b4 0.15-dev-5bbf5 X-Developer-Signature: v=1; a=ed25519-sha256; t=1755585388; l=1721; i=yijie.yang@oss.qualcomm.com; s=20240408; h=from:subject:message-id; bh=rgkE1DP1easYS6YslKYK9Bbq9OWK3nty3gdcQhkYooc=; b=lAzLbqBZgwScoYObFRiDqWfMrCAW8S5NgGjq7r08AjwHO1jUwef1A+841LP3ckCJ1R1EY5YEH 4cuvivCRLNeDSw954otmMxHK0W9KcjsGR/NaRz4uxt+wTDkP5NVaIVl X-Developer-Key: i=yijie.yang@oss.qualcomm.com; a=ed25519; pk=XvMv0rxjrXLYFdBXoFjTdOdAwDT5SPbQ5uAKGESDihk= X-Proofpoint-ORIG-GUID: jodzIXO4FnF9w-2eG63OPkwRQVxZwn8O X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDA0NSBTYWx0ZWRfX7iNoRsrHKWMw EOVLF1WIBFyhxPLCMLMVrfPDttglrziuRk3Pl3Tsubweg0dQLBqNZ73BrTj57j4x3LJHRTD369Y q3XxUyn3vok0YAQ97uU9rE093wRM3stWz/vIfCqzSxWsl82wqwLjAGf2slmoRs82biiI140KtYO jeP6S+R3oH7p/6bp3/286EwGfGCUHZj0Nr3waJWOuwLwsvKIua4r+jU2c5w7rbk24XVSOqQbMnn 8GSJOsFxaGSxwSzfJuUgJNoBDvGeC2w4BFIyOyAZPugwKmD9zHAXmMGRu0eNPBLCKKhxK3Brw4P ouZ1+SDv01IBVS8z5oJcN8Fgm8yW/I0zAo/kUALgNJd+Nke1LGZx0msmuImeNIdT1ZdhVNoMonC xfa/o8hf X-Authority-Analysis: v=2.4 cv=IIMCChvG c=1 sm=1 tr=0 ts=68a41b7b cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=VHUZ9mhHZOqmV8q2ncwA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: jodzIXO4FnF9w-2eG63OPkwRQVxZwn8O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_01,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160045 The DLL is a Qualcomm-specific hardware component integrated within the MAC and should be configured in bypass mode for 10 Mbps and 100 Mbps speeds. If not bypassed, the timing delay will be incorrectly applied, which will disrupt signal sampling. Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos") Signed-off-by: Yijie Yang --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index d8fd4d8f6ced..a4ea72f86ca8 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -64,6 +64,9 @@ #define SDCC_DLL_CONFIG2_DDR_TRAFFIC_INIT_SW BIT(1) #define SDCC_DLL_CONFIG2_DDR_CAL_EN BIT(0) =20 +/* SDCC_USR_CTL fields */ +#define SDCC_USR_CTL_DLL_BYPASS BIT(30) + /* SDC4_STATUS bits */ #define SDC4_STATUS_DLL_LOCK BIT(7) =20 @@ -609,6 +612,17 @@ static int ethqos_configure_rgmii(struct qcom_ethqos *= ethqos, int speed) if (speed =3D=3D SPEED_1000) ethqos_dll_configure(ethqos); =20 + /* The DLL (Delay Locked Loop) aligns the clock and samples data + * in RGMII interfaces. It should be bypassed for 10 Mbps and + * 100 Mbps speeds. + */ + if (speed =3D=3D SPEED_10 || speed =3D=3D SPEED_100) { + rgmii_updatel(ethqos, SDCC_DLL_CONFIG_PDN, SDCC_DLL_CONFIG_PDN, + SDCC_HC_REG_DLL_CONFIG); + rgmii_updatel(ethqos, SDCC_USR_CTL_DLL_BYPASS, + SDCC_USR_CTL_DLL_BYPASS, SDCC_USR_CTL); + } + ethqos_rgmii_macro_init(ethqos, speed); =20 return 0; --=20 2.34.1