From nobody Sun Oct 26 05:26:53 2025
Received: from layka.disroot.org (layka.disroot.org [178.21.23.139])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959862857CD;
	Tue, 19 Aug 2025 14:57:23 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
 arc=none smtp.client-ip=178.21.23.139
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1755615445; cv=none;
 b=nGIyIxr/NruiWlC4SXALo1JEg9HVJwFQwyt4CkIFA5ywR+PEDBB7bgQL6Z6XwPBjWJWpGQXrBEW78rPyh8fmRBaFe1mM6O7Ho2JRjINIGZWz+ByXZOhYFu2qwL9xzMCVp3v8c7IGZ6WebJKZcAv38o9yJvMtjHv1Knr8VnDMJ6k=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1755615445; c=relaxed/simple;
	bh=OovY0T457rnu6HwHTffxEbBQ+PiGMrWHCs3MBjfdbpA=;
	h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
	 In-Reply-To:To:Cc;
 b=kPTrhT0vvfUSz03svenkjJ1FBkMCiQ/t64HEVdfWS35wTl2jKTyh/03ubeUuPKFbTc+fBpNUsunA2X4CQIJ/8g0yRk86DS7gh8UZBT7Y3Sc/Oi0xuvGWW7dItDuchmC5JJPob76tuYrbSjKy8VaAStmV0ESkG5E4EdtKGfzD8Cs=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
 dmarc=pass (p=reject dis=none) header.from=disroot.org;
 spf=pass smtp.mailfrom=disroot.org;
 dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org
 header.b=XP9qrk7h; arc=none smtp.client-ip=178.21.23.139
Authentication-Results: smtp.subspace.kernel.org;
 dmarc=pass (p=reject dis=none) header.from=disroot.org
Authentication-Results: smtp.subspace.kernel.org;
 spf=pass smtp.mailfrom=disroot.org
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org
 header.b="XP9qrk7h"
Received: from mail01.disroot.lan (localhost [127.0.0.1])
	by disroot.org (Postfix) with ESMTP id 32D0B20CBF;
	Tue, 19 Aug 2025 16:57:22 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from layka.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP
 id CAeAOB_ffVj2; Tue, 19 Aug 2025 16:57:21 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
	t=1755615441; bh=OovY0T457rnu6HwHTffxEbBQ+PiGMrWHCs3MBjfdbpA=;
	h=From:Date:Subject:References:In-Reply-To:To:Cc;
	b=XP9qrk7hMd5UZ8EU3R7DJFvsIBnYlLWWaSQNjhlymXzSGlSXRYh6UTR1BrsxcORx5
	 K1DPRgnjxb24gxezEQfvYFwwIGq93zpRbqxfB1sm/rAeZ96HjduE3cvdCiMKofmkqa
	 hYOOA6mEAvkweOYKbZJUigvDnoYn02y4nEfnxuaY56pxBKm+NdfyjPDbYeDo5vCXXk
	 q1n3aboPflpnWKOS6p3eTXh6/yX8WwxkZ0WIGl/j6de0wRauDnS1HPGPTgAscPjKjy
	 wh6B4zZuM3s6uV7s+4+XSVPAL5QCqxhwlFxtdk7EPehAVnIZF8s0rP+ucWHbo7ahpX
	 BShYuEvW7GhgA==
From: Kaustabh Chakraborty <kauschluss@disroot.org>
Date: Tue, 19 Aug 2025 20:26:45 +0530
Subject: [PATCH v4 2/2] drm: panel: add support for Synaptics TDDI series
 DSI panels
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <20250819-panel-synaptics-tddi-v4-2-448f466d16a6@disroot.org>
References: <20250819-panel-synaptics-tddi-v4-0-448f466d16a6@disroot.org>
In-Reply-To: <20250819-panel-synaptics-tddi-v4-0-448f466d16a6@disroot.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
 Jessica Zhang <quic_jesszhan@quicinc.com>, David Airlie <airlied@gmail.com>,
 Simona Vetter <simona@ffwll.ch>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Jessica Zhang <jessica.zhang@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, Kaustabh Chakraborty <kauschluss@disroot.org>
X-Developer-Signature: v=1; a=ed25519-sha256; t=1755615411; l=10510;
 i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id;
 bh=OovY0T457rnu6HwHTffxEbBQ+PiGMrWHCs3MBjfdbpA=;
 b=3NgnTNHTQLoNwP/ffsFpPEgDJHpqvoIvo+y39C2r0g2e53BtH9C6jSYoogvs+OZtdCBuH7bw1
 QFRovkf41C/DRHIql3MzLVGOOBSI54MuzdJ2EB/Hy0Rl21Wqy03aSVF
X-Developer-Key: i=kauschluss@disroot.org; a=ed25519;
 pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE=

Synaptics TDDI (Touch/Display Integration) panels utilize a single chip
for display and touch controllers. Implement a simple device driver for
such panels, along with its built-in LED backlight controller, and add
support for TD4101 and TD4300 panels in the driver.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 drivers/gpu/drm/panel/Kconfig                |  11 ++
 drivers/gpu/drm/panel/Makefile               |   1 +
 drivers/gpu/drm/panel/panel-synaptics-tddi.c | 276 +++++++++++++++++++++++=
++++
 3 files changed, 288 insertions(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 09b9f7ff9340abb708a503f7564acc46b2faaf7d..b080da939f5e3d11bf4c437ae16=
7480d2721b41f 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -1021,6 +1021,17 @@ config DRM_PANEL_SYNAPTICS_R63353
 	  Say Y if you want to enable support for panels based on the
 	  Synaptics R63353 controller.
=20
+config DRM_PANEL_SYNAPTICS_TDDI
+	tristate "Synaptics TDDI display panels"
+	depends on OF
+	depends on DRM_MIPI_DSI
+	depends on BACKLIGHT_CLASS_DEVICE
+	help
+	  Say Y if you want to enable support for the Synaptics TDDI display
+	  panels. There are multiple MIPI DSI panels manufactured under the TDDI
+	  namesake, with varying resolutions and data lanes. They also have a
+	  built-in LED backlight and a touch controller.
+
 config DRM_PANEL_TDO_TL070WSH30
 	tristate "TDO TL070WSH30 DSI panel"
 	depends on OF
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
index 957555b499968ebbfb55c87d2729ce88b5d48a57..a6e786e2b578e09d95de5b6430e=
ba94c668ee4bc 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -98,6 +98,7 @@ obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) +=3D panel-sitron=
ix-st7703.o
 obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) +=3D panel-sitronix-st7789v.o
 obj-$(CONFIG_DRM_PANEL_SUMMIT) +=3D panel-summit.o
 obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) +=3D panel-synaptics-r63353.o
+obj-$(CONFIG_DRM_PANEL_SYNAPTICS_TDDI) +=3D panel-synaptics-tddi.o
 obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) +=3D panel-sony-acx565akm.o
 obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) +=3D panel-sony-td4353-jdi.o
 obj-$(CONFIG_DRM_PANEL_SONY_TULIP_TRULY_NT35521) +=3D panel-sony-tulip-tru=
ly-nt35521.o
diff --git a/drivers/gpu/drm/panel/panel-synaptics-tddi.c b/drivers/gpu/drm=
/panel/panel-synaptics-tddi.c
new file mode 100644
index 0000000000000000000000000000000000000000..a4b3cbdebb6ca4062c02c6e7ac1=
84f3ec245926a
--- /dev/null
+++ b/drivers/gpu/drm/panel/panel-synaptics-tddi.c
@@ -0,0 +1,276 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Synaptics TDDI display panel driver.
+ *
+ * Copyright (C) 2025 Kaustabh Chakraborty <kauschluss@disroot.org>
+ */
+
+#include <linux/backlight.h>
+#include <linux/gpio/consumer.h>
+#include <linux/module.h>
+#include <linux/of.h>
+
+#include <video/mipi_display.h>
+
+#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modes.h>
+#include <drm/drm_panel.h>
+#include <drm/drm_probe_helper.h>
+
+struct tddi_panel_data {
+	u8 lanes;
+	/* wait timings for panel enable */
+	u8 delay_ms_sleep_exit;
+	u8 delay_ms_display_on;
+	/* wait timings for panel disable */
+	u8 delay_ms_display_off;
+	u8 delay_ms_sleep_enter;
+};
+
+struct tddi_ctx {
+	struct drm_panel panel;
+	struct mipi_dsi_device *dsi;
+	struct drm_display_mode mode;
+	struct backlight_device *backlight;
+	const struct tddi_panel_data *data;
+	struct regulator_bulk_data *supplies;
+	struct gpio_desc *reset_gpio;
+	struct gpio_desc *backlight_gpio;
+};
+
+static const struct regulator_bulk_data tddi_supplies[] =3D {
+	{ .supply =3D "vio" },
+	{ .supply =3D "vsn" },
+	{ .supply =3D "vsp" },
+};
+
+static inline struct tddi_ctx *to_tddi_ctx(struct drm_panel *panel)
+{
+	return container_of(panel, struct tddi_ctx, panel);
+}
+
+static int tddi_update_status(struct backlight_device *backlight)
+{
+	struct tddi_ctx *ctx =3D bl_get_data(backlight);
+	struct mipi_dsi_multi_context dsi =3D { .dsi =3D ctx->dsi };
+	u8 brightness =3D backlight_get_brightness(backlight);
+
+	if (!ctx->panel.enabled)
+		return 0;
+
+	mipi_dsi_dcs_set_display_brightness_multi(&dsi, brightness);
+
+	return dsi.accum_err;
+}
+
+static int tddi_prepare(struct drm_panel *panel)
+{
+	struct tddi_ctx *ctx =3D to_tddi_ctx(panel);
+	struct device *dev =3D &ctx->dsi->dev;
+	int ret;
+
+	ret =3D regulator_bulk_enable(ARRAY_SIZE(tddi_supplies), ctx->supplies);
+	if (ret < 0) {
+		dev_err(dev, "failed to enable regulators: %d\n", ret);
+		return ret;
+	}
+
+	gpiod_set_value_cansleep(ctx->reset_gpio, 0);
+	usleep_range(5000, 6000);
+	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+	usleep_range(5000, 6000);
+	gpiod_set_value_cansleep(ctx->reset_gpio, 0);
+	usleep_range(10000, 11000);
+
+	gpiod_set_value_cansleep(ctx->backlight_gpio, 0);
+	usleep_range(5000, 6000);
+
+	return 0;
+}
+
+static int tddi_unprepare(struct drm_panel *panel)
+{
+	struct tddi_ctx *ctx =3D to_tddi_ctx(panel);
+
+	gpiod_set_value_cansleep(ctx->backlight_gpio, 1);
+	usleep_range(5000, 6000);
+
+	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+	usleep_range(5000, 6000);
+
+	regulator_bulk_disable(ARRAY_SIZE(tddi_supplies), ctx->supplies);
+
+	return 0;
+}
+
+static int tddi_enable(struct drm_panel *panel)
+{
+	struct tddi_ctx *ctx =3D to_tddi_ctx(panel);
+	struct mipi_dsi_multi_context dsi =3D { .dsi =3D ctx->dsi };
+	u8 brightness =3D ctx->backlight->props.brightness;
+
+	mipi_dsi_dcs_write_seq_multi(&dsi, MIPI_DCS_WRITE_POWER_SAVE, 0x00);
+	mipi_dsi_dcs_write_seq_multi(&dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x0c);
+
+	mipi_dsi_dcs_exit_sleep_mode_multi(&dsi);
+	mipi_dsi_msleep(&dsi, ctx->data->delay_ms_sleep_exit);
+
+	/* sync the panel with the backlight's brightness level */
+	mipi_dsi_dcs_set_display_brightness_multi(&dsi, brightness);
+
+	mipi_dsi_dcs_set_display_on_multi(&dsi);
+	mipi_dsi_msleep(&dsi, ctx->data->delay_ms_display_on);
+
+	return dsi.accum_err;
+};
+
+static int tddi_disable(struct drm_panel *panel)
+{
+	struct tddi_ctx *ctx =3D to_tddi_ctx(panel);
+	struct mipi_dsi_multi_context dsi =3D { .dsi =3D ctx->dsi };
+
+	mipi_dsi_dcs_set_display_off_multi(&dsi);
+	mipi_dsi_msleep(&dsi, ctx->data->delay_ms_display_off);
+
+	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi);
+	mipi_dsi_msleep(&dsi, ctx->data->delay_ms_sleep_enter);
+
+	return dsi.accum_err;
+}
+
+static int tddi_get_modes(struct drm_panel *panel,
+			  struct drm_connector *connector)
+{
+	struct tddi_ctx *ctx =3D to_tddi_ctx(panel);
+
+	return drm_connector_helper_get_modes_fixed(connector, &ctx->mode);
+}
+
+static const struct backlight_ops tddi_bl_ops =3D {
+	.update_status =3D tddi_update_status,
+};
+
+static const struct backlight_properties tddi_bl_props =3D {
+	.type =3D BACKLIGHT_PLATFORM,
+	.brightness =3D 255,
+	.max_brightness =3D 255,
+};
+
+static const struct drm_panel_funcs tddi_drm_panel_funcs =3D {
+	.prepare =3D tddi_prepare,
+	.unprepare =3D tddi_unprepare,
+	.enable =3D tddi_enable,
+	.disable =3D tddi_disable,
+	.get_modes =3D tddi_get_modes,
+};
+
+static int tddi_probe(struct mipi_dsi_device *dsi)
+{
+	struct device *dev =3D &dsi->dev;
+	struct tddi_ctx *ctx;
+	int ret;
+
+	ctx =3D devm_drm_panel_alloc(dev, struct tddi_ctx, panel,
+				   &tddi_drm_panel_funcs, DRM_MODE_CONNECTOR_DSI);
+	if (IS_ERR(ctx))
+		return PTR_ERR(ctx);
+
+	ctx->data =3D of_device_get_match_data(dev);
+
+	ctx->dsi =3D dsi;
+	mipi_dsi_set_drvdata(dsi, ctx);
+
+	ret =3D devm_regulator_bulk_get_const(dev, ARRAY_SIZE(tddi_supplies),
+					    tddi_supplies, &ctx->supplies);
+	if (ret < 0)
+		return dev_err_probe(dev, ret, "failed to get regulators\n");
+
+	ctx->backlight_gpio =3D devm_gpiod_get_optional(dev, "backlight", GPIOD_A=
SIS);
+	if (IS_ERR(ctx->backlight_gpio))
+		return dev_err_probe(dev, PTR_ERR(ctx->backlight_gpio),
+				     "failed to get backlight-gpios\n");
+
+	ctx->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_ASIS);
+	if (IS_ERR(ctx->reset_gpio))
+		return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
+				     "failed to get reset-gpios\n");
+
+	ret =3D of_get_drm_panel_display_mode(dev->of_node, &ctx->mode, NULL);
+	if (ret < 0)
+		return dev_err_probe(dev, ret, "failed to get panel timings\n");
+
+	ctx->backlight =3D devm_backlight_device_register(dev, dev_name(dev), dev,
+							ctx, &tddi_bl_ops,
+							&tddi_bl_props);
+	if (IS_ERR(ctx->backlight))
+		return dev_err_probe(dev, PTR_ERR(ctx->backlight),
+				     "failed to register backlight device");
+
+	dsi->lanes =3D ctx->data->lanes;
+	dsi->format =3D MIPI_DSI_FMT_RGB888;
+	dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
+			  MIPI_DSI_MODE_VIDEO_NO_HFP;
+
+	ctx->panel.prepare_prev_first =3D true;
+	drm_panel_add(&ctx->panel);
+
+	ret =3D devm_mipi_dsi_attach(dev, dsi);
+	if (ret < 0) {
+		drm_panel_remove(&ctx->panel);
+		return dev_err_probe(dev, ret, "failed to attach to DSI host\n");
+	}
+
+	return 0;
+}
+
+static void tddi_remove(struct mipi_dsi_device *dsi)
+{
+	struct tddi_ctx *ctx =3D mipi_dsi_get_drvdata(dsi);
+
+	drm_panel_remove(&ctx->panel);
+}
+
+static const struct tddi_panel_data td4101_panel_data =3D {
+	.lanes =3D 2,
+	/* wait timings for panel enable */
+	.delay_ms_sleep_exit =3D 100,
+	.delay_ms_display_on =3D 0,
+	/* wait timings for panel disable */
+	.delay_ms_display_off =3D 20,
+	.delay_ms_sleep_enter =3D 90,
+};
+
+static const struct tddi_panel_data td4300_panel_data =3D {
+	.lanes =3D 4,
+	/* wait timings for panel enable */
+	.delay_ms_sleep_exit =3D 100,
+	.delay_ms_display_on =3D 0,
+	/* wait timings for panel disable */
+	.delay_ms_display_off =3D 0,
+	.delay_ms_sleep_enter =3D 0,
+};
+
+static const struct of_device_id tddi_of_device_id[] =3D {
+	{
+		.compatible =3D "syna,td4101-panel",
+		.data =3D &td4101_panel_data,
+	}, {
+		.compatible =3D "syna,td4300-panel",
+		.data =3D &td4300_panel_data,
+	}, { }
+};
+MODULE_DEVICE_TABLE(of, tddi_of_device_id);
+
+static struct mipi_dsi_driver tddi_dsi_driver =3D {
+	.probe =3D tddi_probe,
+	.remove =3D tddi_remove,
+	.driver =3D {
+		.name =3D "panel-synaptics-tddi",
+		.of_match_table =3D tddi_of_device_id,
+	},
+};
+module_mipi_dsi_driver(tddi_dsi_driver);
+
+MODULE_AUTHOR("Kaustabh Chakraborty <kauschluss@disroot.org>");
+MODULE_DESCRIPTION("Synaptics TDDI Display Panel Driver");
+MODULE_LICENSE("GPL");

--=20
2.50.0