From nobody Sat Oct 4 09:39:46 2025 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1937A273803 for ; Mon, 18 Aug 2025 19:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545295; cv=none; b=WO8rH5CYYkhR1unJk9G5OJPPeDL7OJ/KZl1cFQjcFN6uk2k0TIb8sgHuq61EhuEUcYqzfGvvKSJs1Ky0qgRWI5zXRwM7mrMXSmGrU+g37Pnbxf6dm+myVLlsfYMUiVuNctMDxzWv3jN97rmMaQQgc47ez4TPzT+us2igIEJtA2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545295; c=relaxed/simple; bh=VCkEMcoNoMwv4mRKUx7SCnl6r7yOkb5KDdHWBarni5w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RcM3b2+q3PqpZsTHKe4ZJpY+jXaF8oKYYwpOE7RqLZ87s6IRusTBb+PpcA5YZK8DLkLQU4yFJjsRqCJsyA3HYh1FvBUVRBwRQ/+MiFRESFnzfly4NyzrQPM+2Q2qajbxDiZdDVhTqZRPt79+YLX1aiWpWxGBzd4zL/pKx2Pls9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=lytxawdF; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lytxawdF" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-b4746fd4793so1160612a12.1 for ; Mon, 18 Aug 2025 12:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755545293; x=1756150093; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dmUFyq7ul3dR2ebMA31ZpslE+HfQcyB/bqxP5tTBNZs=; b=lytxawdF4p/hDHyQNzwpsreaa+nUEUdXdkZutWVzdSfB11wioEcoxZTKGVvzklCvff 8La3O/aCqhmYCDzA1kxCIgIiOj12tBeyDBiTqUx/gybLgBMPMNrz3In65BvNMunYwGzx s3Dywi36TGUpVzP2VpwE2Ljo30RYL7iw0F+o8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755545293; x=1756150093; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dmUFyq7ul3dR2ebMA31ZpslE+HfQcyB/bqxP5tTBNZs=; b=RA77SaUBdYfgqAMH1ifDEzri1sgUq3Fkhz5CqkiFpibV9m5DTaM+JHidEuXFznMwJB dwe+7LX1ypZSv8ko0UWx8pM7cB1eNBqoI5aZZ3PK4nGrjXSNVXdG7k/7y1zhOnTzuhxi RitX1kjeSrN/IAu5d8IBHYwW3k54x4TShpfxdqU0t04ov0jX65YQf63xHIRkfXkShVql cqkLwITzC1B9QFnouwtZzXXfPySTo+yll6y7eEkRRMacRQW70w/InqN2J1AjqjGFuzL/ 4okUjRth8Ai1UbDimGEQobCktFy7o/toC6Tft7I7a32n0/hfjWj6VW1/lHxeZtMcnv85 7eXQ== X-Forwarded-Encrypted: i=1; AJvYcCVcepxy26ZV9wzcVndaOKx+lzhN2tIdsnG6VGXcWsyPqo7GOfO4H7TQIQNPoIEKZf1uKvB4NDRA3mXMEnA=@vger.kernel.org X-Gm-Message-State: AOJu0YxO/22DF7uZGIBr1X+HvkJLYyepeRJRnffgDTLFx5r2yUigsHIk kwcWn0npA5oQPU3ezAEBVvDEZEEuomeSg6p3UCke5R6a/iVF9Tj12E5oH0TlGmXZEg== X-Gm-Gg: ASbGncu6AwrCNS1SXzMXCAUtidfM8Uu50J6Ea80c1OGAaam5UzrrbmAsoLUgrtAV2dD k8PNd2bwZNguyRrguNs34oJFUPk63ZM5D0GxZJRN1b8bkUqacK/m1cw2rSI+VZ2qwqbAR2kkEXs xMzbyX4jHtvKlFxwRhW+zcWFk+LPyLCqODSPdD3XBWGe9Ls1lKZDSjTp6dx0KpOlFTrs6/Pme/v FW6dOjjH7BxAs14J+1PxmYD8r/5fgAHsxYwTt1ZPXLT7VoLijc0VFPesxEqPOLpD8iKsXl5cACx M7KQdN0RLBZ2jQyP29/4N/pIeC9PIyb5pBUbB31zxZvq3/GzR7ezLHTLa4iV5JLO54UxirU8P58 uDJZZdhLnRVm6NUtig22TIhUTnQEqxpnafSOfVoztaA8hyfnljKq4njsgMHXW X-Google-Smtp-Source: AGHT+IFT0GFuq9msexYfYdFrpC2Zjye2ADTrcVGUuz8yhhr8LDG29upmo2w3AwENFXT1lwPc05IYxg== X-Received: by 2002:a17:90b:3cc5:b0:31f:762c:bc40 with SMTP id 98e67ed59e1d1-3245e59151fmr99420a91.16.1755545293364; Mon, 18 Aug 2025 12:28:13 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:87a3:e3ff:ace1:d763]) by smtp.gmail.com with UTF8SMTPSA id 41be03b00d2f7-b472d794a4fsm8795257a12.57.2025.08.18.12.28.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 12:28:12 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , Guenter Roeck , linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH 2/6] genirq/test: Factor out fake-virq setup Date: Mon, 18 Aug 2025 12:27:39 -0700 Message-ID: <20250818192800.621408-3-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc1.167.g924127e9c0-goog In-Reply-To: <20250818192800.621408-1-briannorris@chromium.org> References: <20250818192800.621408-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We have to repeat a few things in tests. Factor out the creation of fake IRQs. Signed-off-by: Brian Norris --- kernel/irq/irq_test.c | 45 +++++++++++++++++++------------------------ 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c index e220e7b2fc18..f8f4532c2805 100644 --- a/kernel/irq/irq_test.c +++ b/kernel/irq/irq_test.c @@ -41,15 +41,15 @@ static struct irq_chip fake_irq_chip =3D { .flags =3D IRQCHIP_SKIP_SET_WAKE, }; =20 -static void irq_disable_depth_test(struct kunit *test) +static int irq_test_setup_fake_irq(struct kunit *test, struct irq_affinity= _desc *affd) { struct irq_desc *desc; - int virq, ret; + int virq; =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, NULL); + virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, affd); KUNIT_ASSERT_GE(test, virq, 0); =20 - irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_simple_irq); + irq_set_chip_and_handler(virq, &fake_irq_chip, handle_simple_irq); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); @@ -57,6 +57,19 @@ static void irq_disable_depth_test(struct kunit *test) /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ irq_settings_clr_norequest(desc); =20 + return virq; +} + +static void irq_disable_depth_test(struct kunit *test) +{ + struct irq_desc *desc; + int virq, ret; + + virq =3D irq_test_setup_fake_irq(test, NULL); + + desc =3D irq_to_desc(virq); + KUNIT_ASSERT_PTR_NE(test, desc, NULL); + ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); KUNIT_EXPECT_EQ(test, ret, 0); =20 @@ -76,17 +89,11 @@ static void irq_free_disabled_test(struct kunit *test) struct irq_desc *desc; int virq, ret; =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, NULL); - KUNIT_ASSERT_GE(test, virq, 0); - - irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_simple_irq); + virq =3D irq_test_setup_fake_irq(test, NULL); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 - /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ - irq_settings_clr_norequest(desc); - ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); KUNIT_EXPECT_EQ(test, ret, 0); =20 @@ -118,17 +125,11 @@ static void irq_shutdown_depth_test(struct kunit *tes= t) if (!IS_ENABLED(CONFIG_SMP)) kunit_skip(test, "requires CONFIG_SMP for managed shutdown"); =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, &affinity); - KUNIT_ASSERT_GE(test, virq, 0); - - irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_simple_irq); + virq =3D irq_test_setup_fake_irq(test, &affinity); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 - /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ - irq_settings_clr_norequest(desc); - data =3D irq_desc_get_irq_data(desc); KUNIT_ASSERT_PTR_NE(test, data, NULL); =20 @@ -181,17 +182,11 @@ static void irq_cpuhotplug_test(struct kunit *test) =20 cpumask_copy(&affinity.mask, cpumask_of(1)); =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, &affinity); - KUNIT_ASSERT_GE(test, virq, 0); - - irq_set_chip_and_handler(virq, &fake_irq_chip, handle_simple_irq); + virq =3D irq_test_setup_fake_irq(test, &affinity); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 - /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ - irq_settings_clr_norequest(desc); - data =3D irq_desc_get_irq_data(desc); KUNIT_ASSERT_PTR_NE(test, data, NULL); =20 --=20 2.51.0.rc1.167.g924127e9c0-goog