From nobody Sat Oct 4 08:05:13 2025 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90DCD25DB12 for ; Mon, 18 Aug 2025 19:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545294; cv=none; b=Kk2Apt894cKYS7FSim+lHEBXU5F2Z7eLRLiF3lFjiLL0Boyv/+FkX30gsDqKp9vHpm9I5NWeV7MLz4bTOIKSP0Os2kY1opdgSud2VtlAglBjhtFU3lTDXx+rOCRJ0LlDMucd3IBZt8CWkEa8q2+By91M8KnObSzCEBq/RDK+T5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545294; c=relaxed/simple; bh=I1Q/5ADe/aK5ILNDdLYpOTGm5h6cDlpW8ALO+LCmpkQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RCQ2UXS4Gsm84AaCR//F0xvWhsqrvCWUXFGhc9YIg0fdEQd79OYzMVPvDyN7iopW1T3+/0VhnyxuXTbAd3y9axzryA13bXmFm7lHzr9xkh1kB2oQPH/BtwcWKzRzeh/WE/0x08vyqVMtW3bt1FWCfMGfq11GERDxd3UxDC79tYM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Opg2GDrJ; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Opg2GDrJ" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-76e2e89bebaso3316819b3a.1 for ; Mon, 18 Aug 2025 12:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755545292; x=1756150092; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iBc/8/kjXUbobC+bXkGfosbfw3HU9KPbekc4bmg+zJw=; b=Opg2GDrJc7Z6dEjp2AnKXNOL8sK2lk8qvz16ZjL3vxrXMUfVic7qjCaFv6YHtUEBAL /5V5B+hLjydcE0p1MXD6W+CVF8f35u5ciFNyxxo3Hd0lFoOhV/xnv8vAFqOGGw2wm6H7 OCqEFAmHxPSPcHpPqr7V5xFpTE0cVf+BmB1jE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755545292; x=1756150092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iBc/8/kjXUbobC+bXkGfosbfw3HU9KPbekc4bmg+zJw=; b=J/gpeQ8vqzhpfd1KW8Z1PAI1YNvanSdDKZCKk80C36sVy4VOPq92E5ybyZVIYGRYfc PM57lTV82WATDiFNF2HNBqPKQy9OlRmCpEIk0YbIvK2+h/eVE6fF503ybz+yaktGutES vFOi8sTHR3M7Fm/2drcDWZFC77Rquri8jI/XbvgjWPZik/e2b5BQ9dZ6UjOUwodEGpVT 612zvfd3o5F9Lf36DKQp/Wz37HoOmix2VgKabEbNf6Bc//sfuFoMeI29QmN4U7b1BZLh q3YjQzmqENt6/sncipQr97Ggux0o6tbSDXdVD8qjl725Nbzw6Zthh/lXkbdyZotbyTeY aB3w== X-Forwarded-Encrypted: i=1; AJvYcCUqwbuDCkJVNkd2t7aY8Qzasv1mae3oX+twl29GvLC/9NZJg1gjhaI5fzwcVaq94WAD8R7bMrk+wgKCfXc=@vger.kernel.org X-Gm-Message-State: AOJu0YxWZEkoJ7bYewPCrAbD/cNiTqK1LAAvEk715VF3SJChEYoJ0yux c+8NatGbmIxbG98YeegNA4coh5fzvNGnYWjKwM5SzbetZ5wl5NhHY9Y1b2CFZ36qSg== X-Gm-Gg: ASbGncv0xldAVWZxpHIKqxQ6rWu91AjoeaGZUhrASNl4Adrb3ROcKgWhkDHnmJiozn9 r3sPsGBLUXlil5F0kG2KMI4V2xeeO5/xinCQNsiSKHKiuW++Bqd0YO0XS0A8aJEjTu4J4VOaoUt GnYUz57HKCNZlyXj3jfHqgFMlz3hmMUnB/F8EbXGMF3825Bfxu+d3t8x46oq2qIWBjBaiuHvKVu d/sisuBC/qqs6L6pawkapCHsUz3ahlejoEfZRq4mb2EGcMFpG13O35zYSOWBvDgdyqM1Pj73SXt d6fITl0aWMmBAvzuFSRsKlnUdFOnRjmGRl29ClC8TNtT13hieAmaDv9Bdqu467UrGED06WuUKbk Se6sXXtCS6MuQf9OOA/1HUUqx5yI5Xb6x0HXqqheJTK8vAYCB7nBwF+K8LU1R X-Google-Smtp-Source: AGHT+IHK7Wdp5hNX6Ek3lXPb7srBrzM9Htr2J93rwVtwIFEJKGnUcvWlX8Y2O869HH27Srry8sYPEw== X-Received: by 2002:a05:6a00:2441:b0:746:2ae9:fc42 with SMTP id d2e1a72fcca58-76e44803060mr18110146b3a.19.1755545291733; Mon, 18 Aug 2025 12:28:11 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:87a3:e3ff:ace1:d763]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-76e7d551493sm338678b3a.112.2025.08.18.12.28.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 12:28:11 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , Guenter Roeck , linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH 1/6] genirq/test: Select IRQ_DOMAIN Date: Mon, 18 Aug 2025 12:27:38 -0700 Message-ID: <20250818192800.621408-2-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc1.167.g924127e9c0-goog In-Reply-To: <20250818192800.621408-1-briannorris@chromium.org> References: <20250818192800.621408-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" These tests use irq_domain_alloc_descs() and so require CONFIG_IRQ_DOMAIN. Fixes: 66067c3c8a1e ("genirq: Add kunit tests for depth counts") Reported-by: Guenter Roeck Closes: https://lore.kernel.org/lkml/ded44edf-eeb7-420c-b8a8-d6543b955e6e@r= oeck-us.net/ Signed-off-by: Brian Norris Reviewed-by: David Gow --- kernel/irq/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig index 1da5e9d9da71..08088b8e95ae 100644 --- a/kernel/irq/Kconfig +++ b/kernel/irq/Kconfig @@ -148,6 +148,7 @@ config IRQ_KUNIT_TEST bool "KUnit tests for IRQ management APIs" if !KUNIT_ALL_TESTS depends on KUNIT=3Dy default KUNIT_ALL_TESTS + select IRQ_DOMAIN imply SMP help This option enables KUnit tests for the IRQ subsystem API. These are --=20 2.51.0.rc1.167.g924127e9c0-goog From nobody Sat Oct 4 08:05:13 2025 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1937A273803 for ; Mon, 18 Aug 2025 19:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545295; cv=none; b=WO8rH5CYYkhR1unJk9G5OJPPeDL7OJ/KZl1cFQjcFN6uk2k0TIb8sgHuq61EhuEUcYqzfGvvKSJs1Ky0qgRWI5zXRwM7mrMXSmGrU+g37Pnbxf6dm+myVLlsfYMUiVuNctMDxzWv3jN97rmMaQQgc47ez4TPzT+us2igIEJtA2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545295; c=relaxed/simple; bh=VCkEMcoNoMwv4mRKUx7SCnl6r7yOkb5KDdHWBarni5w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RcM3b2+q3PqpZsTHKe4ZJpY+jXaF8oKYYwpOE7RqLZ87s6IRusTBb+PpcA5YZK8DLkLQU4yFJjsRqCJsyA3HYh1FvBUVRBwRQ/+MiFRESFnzfly4NyzrQPM+2Q2qajbxDiZdDVhTqZRPt79+YLX1aiWpWxGBzd4zL/pKx2Pls9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=lytxawdF; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lytxawdF" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-b4746fd4793so1160612a12.1 for ; Mon, 18 Aug 2025 12:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755545293; x=1756150093; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dmUFyq7ul3dR2ebMA31ZpslE+HfQcyB/bqxP5tTBNZs=; b=lytxawdF4p/hDHyQNzwpsreaa+nUEUdXdkZutWVzdSfB11wioEcoxZTKGVvzklCvff 8La3O/aCqhmYCDzA1kxCIgIiOj12tBeyDBiTqUx/gybLgBMPMNrz3In65BvNMunYwGzx s3Dywi36TGUpVzP2VpwE2Ljo30RYL7iw0F+o8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755545293; x=1756150093; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dmUFyq7ul3dR2ebMA31ZpslE+HfQcyB/bqxP5tTBNZs=; b=RA77SaUBdYfgqAMH1ifDEzri1sgUq3Fkhz5CqkiFpibV9m5DTaM+JHidEuXFznMwJB dwe+7LX1ypZSv8ko0UWx8pM7cB1eNBqoI5aZZ3PK4nGrjXSNVXdG7k/7y1zhOnTzuhxi RitX1kjeSrN/IAu5d8IBHYwW3k54x4TShpfxdqU0t04ov0jX65YQf63xHIRkfXkShVql cqkLwITzC1B9QFnouwtZzXXfPySTo+yll6y7eEkRRMacRQW70w/InqN2J1AjqjGFuzL/ 4okUjRth8Ai1UbDimGEQobCktFy7o/toC6Tft7I7a32n0/hfjWj6VW1/lHxeZtMcnv85 7eXQ== X-Forwarded-Encrypted: i=1; AJvYcCVcepxy26ZV9wzcVndaOKx+lzhN2tIdsnG6VGXcWsyPqo7GOfO4H7TQIQNPoIEKZf1uKvB4NDRA3mXMEnA=@vger.kernel.org X-Gm-Message-State: AOJu0YxO/22DF7uZGIBr1X+HvkJLYyepeRJRnffgDTLFx5r2yUigsHIk kwcWn0npA5oQPU3ezAEBVvDEZEEuomeSg6p3UCke5R6a/iVF9Tj12E5oH0TlGmXZEg== X-Gm-Gg: ASbGncu6AwrCNS1SXzMXCAUtidfM8Uu50J6Ea80c1OGAaam5UzrrbmAsoLUgrtAV2dD k8PNd2bwZNguyRrguNs34oJFUPk63ZM5D0GxZJRN1b8bkUqacK/m1cw2rSI+VZ2qwqbAR2kkEXs xMzbyX4jHtvKlFxwRhW+zcWFk+LPyLCqODSPdD3XBWGe9Ls1lKZDSjTp6dx0KpOlFTrs6/Pme/v FW6dOjjH7BxAs14J+1PxmYD8r/5fgAHsxYwTt1ZPXLT7VoLijc0VFPesxEqPOLpD8iKsXl5cACx M7KQdN0RLBZ2jQyP29/4N/pIeC9PIyb5pBUbB31zxZvq3/GzR7ezLHTLa4iV5JLO54UxirU8P58 uDJZZdhLnRVm6NUtig22TIhUTnQEqxpnafSOfVoztaA8hyfnljKq4njsgMHXW X-Google-Smtp-Source: AGHT+IFT0GFuq9msexYfYdFrpC2Zjye2ADTrcVGUuz8yhhr8LDG29upmo2w3AwENFXT1lwPc05IYxg== X-Received: by 2002:a17:90b:3cc5:b0:31f:762c:bc40 with SMTP id 98e67ed59e1d1-3245e59151fmr99420a91.16.1755545293364; Mon, 18 Aug 2025 12:28:13 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:87a3:e3ff:ace1:d763]) by smtp.gmail.com with UTF8SMTPSA id 41be03b00d2f7-b472d794a4fsm8795257a12.57.2025.08.18.12.28.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 12:28:12 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , Guenter Roeck , linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH 2/6] genirq/test: Factor out fake-virq setup Date: Mon, 18 Aug 2025 12:27:39 -0700 Message-ID: <20250818192800.621408-3-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc1.167.g924127e9c0-goog In-Reply-To: <20250818192800.621408-1-briannorris@chromium.org> References: <20250818192800.621408-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We have to repeat a few things in tests. Factor out the creation of fake IRQs. Signed-off-by: Brian Norris Reviewed-by: David Gow --- kernel/irq/irq_test.c | 45 +++++++++++++++++++------------------------ 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c index e220e7b2fc18..f8f4532c2805 100644 --- a/kernel/irq/irq_test.c +++ b/kernel/irq/irq_test.c @@ -41,15 +41,15 @@ static struct irq_chip fake_irq_chip =3D { .flags =3D IRQCHIP_SKIP_SET_WAKE, }; =20 -static void irq_disable_depth_test(struct kunit *test) +static int irq_test_setup_fake_irq(struct kunit *test, struct irq_affinity= _desc *affd) { struct irq_desc *desc; - int virq, ret; + int virq; =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, NULL); + virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, affd); KUNIT_ASSERT_GE(test, virq, 0); =20 - irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_simple_irq); + irq_set_chip_and_handler(virq, &fake_irq_chip, handle_simple_irq); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); @@ -57,6 +57,19 @@ static void irq_disable_depth_test(struct kunit *test) /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ irq_settings_clr_norequest(desc); =20 + return virq; +} + +static void irq_disable_depth_test(struct kunit *test) +{ + struct irq_desc *desc; + int virq, ret; + + virq =3D irq_test_setup_fake_irq(test, NULL); + + desc =3D irq_to_desc(virq); + KUNIT_ASSERT_PTR_NE(test, desc, NULL); + ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); KUNIT_EXPECT_EQ(test, ret, 0); =20 @@ -76,17 +89,11 @@ static void irq_free_disabled_test(struct kunit *test) struct irq_desc *desc; int virq, ret; =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, NULL); - KUNIT_ASSERT_GE(test, virq, 0); - - irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_simple_irq); + virq =3D irq_test_setup_fake_irq(test, NULL); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 - /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ - irq_settings_clr_norequest(desc); - ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); KUNIT_EXPECT_EQ(test, ret, 0); =20 @@ -118,17 +125,11 @@ static void irq_shutdown_depth_test(struct kunit *tes= t) if (!IS_ENABLED(CONFIG_SMP)) kunit_skip(test, "requires CONFIG_SMP for managed shutdown"); =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, &affinity); - KUNIT_ASSERT_GE(test, virq, 0); - - irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_simple_irq); + virq =3D irq_test_setup_fake_irq(test, &affinity); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 - /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ - irq_settings_clr_norequest(desc); - data =3D irq_desc_get_irq_data(desc); KUNIT_ASSERT_PTR_NE(test, data, NULL); =20 @@ -181,17 +182,11 @@ static void irq_cpuhotplug_test(struct kunit *test) =20 cpumask_copy(&affinity.mask, cpumask_of(1)); =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, &affinity); - KUNIT_ASSERT_GE(test, virq, 0); - - irq_set_chip_and_handler(virq, &fake_irq_chip, handle_simple_irq); + virq =3D irq_test_setup_fake_irq(test, &affinity); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 - /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ - irq_settings_clr_norequest(desc); - data =3D irq_desc_get_irq_data(desc); KUNIT_ASSERT_PTR_NE(test, data, NULL); =20 --=20 2.51.0.rc1.167.g924127e9c0-goog From nobody Sat Oct 4 08:05:13 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA8633451B4 for ; Mon, 18 Aug 2025 19:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545297; cv=none; b=BVNleoApZ/eR5rZykN9XaLENvzkAiRFqEg/otRbTQEGTimBFpYjiAfLONS3sp+NT2BNYuCXNTynDTP0R/3P5ihDMJBTAhcQKAo7JdDjKp3Ku1gH3rZzQAiWgqhE8c3Dtri9KUgKvPwgCDiY0XLLh17Xe30LE9WP77C0xX4NzMdU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545297; c=relaxed/simple; bh=4kPBijlkC81NpSBNY16J9lTeuReJQ4QC+ZA54UN4Ivw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WVczWP+kowYJXuORuKGCmQ1qVl5FwBxqrbf3ROP6bc/Jf6Et1ok1ShT+Ko2n8hOYvWLqnL0WxID8Z1/6cxpT4axTLdGk/SU2PIedvzk2t26KDqj6vg+LWdoeCD8ETK2Nl/qduhzKlM+kCsGVyBD7kWmEwKFv2OeQTRzStGDP3Jk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=H2JFo/uC; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="H2JFo/uC" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-24457f3edd4so32115585ad.0 for ; Mon, 18 Aug 2025 12:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755545295; x=1756150095; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IDkO8DX6+gukHF5Z8lyQnQSH3eHYqp3lwAde0IjMu1I=; b=H2JFo/uCoCnmrfv1e6wCfBYjwzAPQPL5cW+zybZgztuDxeAQwCm0IhtQ/RPle+TUbk 5zp/gunaecgq+zKM4Te6c0F24ybf25JK5t7FNpPjTcUytWJJ3J9OgTVa0D5U+lMvxm6Z y1nbJTObp+rlKebEvqc++3XpBVYtUl3hBML3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755545295; x=1756150095; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IDkO8DX6+gukHF5Z8lyQnQSH3eHYqp3lwAde0IjMu1I=; b=NYSI2rIAaatafiLknCJizLc5GjIk6VXgFiZTgkUIukA5DbsbKRDbwvbp5W2iHQZ8P3 1AAiEaXX3D3cDuJidUk545kQv09/jsp9IuLXpGShSlDbIvJJ3HgNnv6kAztN9f7YXrD4 kuJEuj5d7x86wX1YxTk4z4RnV7iYzztEJ34y82NH1/1CZMyvfQvjtt8Y/b0q4DYojbiH LQZqRsIFaRJ3+7Bs0/P3FRTWN8cwirf+0Lxq3MWeKAkmaxoPmn5CBX1RNugpj0TccQXn 6kSCSdPyDkoQOT8wuC3pHTfb2KCAWxlWTYc4EGM0I7pdKFbzy8PYEAkAEWFYupvvehaA bqug== X-Forwarded-Encrypted: i=1; AJvYcCW+CeqXoV/3DeBxkyEF/uFnhpODXG9llDZpPo6JpHGnSsVN/0Ry8mEpCvx3EMHDedXK5diUmtqS67l81Zg=@vger.kernel.org X-Gm-Message-State: AOJu0Yww1TedWKBCp1hOkCXKzfdfZL68ntqb3vknRi03CJaEOVbWlWvb yh9MlaU8T+EARtvd0PR3dx42w1CrU0fsqVZ5+4MRjU9U5vUAoR7Mmy8IUiycGZBC3FQ8Su9v0mZ nBWI= X-Gm-Gg: ASbGncu4MlkzrbjpO65c20fQEXA3DY14jvysmsHYiztU2mMt8NmeFlJTkgJt+x+vori nFZrRhN6neWKw64AQiASO6D8X+s3C+09pGeF3BT9SCtmvlg7d4zYqrRjvjXtTrFJfUfxtSEBiKB HxnzivnlRjhXHrsgfnMG4bCBed9pKqoYUx4c3MVZvB6/d86c+HA1qhJNiVb2T0JeJzCWoFxdX7L WOykvYBfqMPSfZIruR39Rfacp/3WsqhUQt6v+A9DSY8dT1kXoj3LtW0nJwb0GhhNlkDxCehzUKb faXmnZTRGmliRrQG7ThzirDf7j+/CZsH6CVHp+/LGB0ZIon7+y+gcwacIdeeOCjr6pXcA/uXwXP b3nx3Q5unxu8Uo7aMEhijs7H5zi1fwv+HN0xeka843Mtprq6xIpgnCieqRMPb X-Google-Smtp-Source: AGHT+IG3TNGIvEz2Dr2rbFdB/HwzWGf1/A9Z4HgPI7eTSXIPxa6gjJoMYtoglKZgfOWHv9+CcDwODA== X-Received: by 2002:a17:903:1c9:b0:240:6766:ac01 with SMTP id d9443c01a7336-2446d6f0386mr191138865ad.2.1755545294960; Mon, 18 Aug 2025 12:28:14 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:87a3:e3ff:ace1:d763]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2446d513c19sm87709645ad.93.2025.08.18.12.28.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 12:28:14 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , Guenter Roeck , linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH 3/6] genirq/test: Fail early if we can't request an IRQ Date: Mon, 18 Aug 2025 12:27:40 -0700 Message-ID: <20250818192800.621408-4-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc1.167.g924127e9c0-goog In-Reply-To: <20250818192800.621408-1-briannorris@chromium.org> References: <20250818192800.621408-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Requesting the IRQ is part of basic setup of the test. If it fails, most of the subsequent tests are likely to fail, and the output gets noisy. Use "assert" to fail early. Signed-off-by: Brian Norris Reviewed-by: David Gow --- kernel/irq/irq_test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c index f8f4532c2805..56baeb5041d6 100644 --- a/kernel/irq/irq_test.c +++ b/kernel/irq/irq_test.c @@ -71,7 +71,7 @@ static void irq_disable_depth_test(struct kunit *test) KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_ASSERT_EQ(test, ret, 0); =20 KUNIT_EXPECT_EQ(test, desc->depth, 0); =20 @@ -95,7 +95,7 @@ static void irq_free_disabled_test(struct kunit *test) KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_ASSERT_EQ(test, ret, 0); =20 KUNIT_EXPECT_EQ(test, desc->depth, 0); =20 @@ -106,7 +106,7 @@ static void irq_free_disabled_test(struct kunit *test) KUNIT_EXPECT_GE(test, desc->depth, 1); =20 ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_ASSERT_EQ(test, ret, 0); KUNIT_EXPECT_EQ(test, desc->depth, 0); =20 free_irq(virq, NULL); @@ -134,7 +134,7 @@ static void irq_shutdown_depth_test(struct kunit *test) KUNIT_ASSERT_PTR_NE(test, data, NULL); =20 ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_ASSERT_EQ(test, ret, 0); =20 KUNIT_EXPECT_TRUE(test, irqd_is_activated(data)); KUNIT_EXPECT_TRUE(test, irqd_is_started(data)); @@ -191,7 +191,7 @@ static void irq_cpuhotplug_test(struct kunit *test) KUNIT_ASSERT_PTR_NE(test, data, NULL); =20 ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_ASSERT_EQ(test, ret, 0); =20 KUNIT_EXPECT_TRUE(test, irqd_is_activated(data)); KUNIT_EXPECT_TRUE(test, irqd_is_started(data)); --=20 2.51.0.rc1.167.g924127e9c0-goog From nobody Sat Oct 4 08:05:13 2025 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E2912750E6 for ; Mon, 18 Aug 2025 19:28:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545298; cv=none; b=dkG+lIuduOYCrVysxi5TNe5uVQPEemPa8AtB1UFhcb0cDFiDwqzGl0IOHUi2s5qClm8SRpPiOgoFDJQqVkmzx3dIn1Lu63Iqxv1Nm7RZ1YBGGUsHavf/WYeqfvlIBufA6RWsh8rkyS+GGlbsgZst/1O7R70SUxSu0Utk+jiIxzs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545298; c=relaxed/simple; bh=eWMIZgp5iHXfiCRbCgK+sZ3dVZXFE8CcfbA+F5NJMds=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gfz+TzG0UC1sjzqDmB+Gb7+8MyAgxiMpbQPAAVhY38W+b/LgcG1b9OyAY99lroekuligA7YSzELA2vE0F50rag4dYn0Ag3p4b9lzlVaQBeVecNlEdKVc/Q8IdFWapnXmwK8rnWX0UG/gfQsajeVJn4MBi5eOhTIQZ7GOiewxkJs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=L0lZYV9z; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="L0lZYV9z" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-76e7af160f1so415113b3a.1 for ; Mon, 18 Aug 2025 12:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755545296; x=1756150096; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aqyW9AMQrLhoPKJmxnqNq0eziaV39pB/4sS3+0Stwwk=; b=L0lZYV9z35MaxUC/L65RtgjOuVXOvLTNF8kUtI2guiMwqugvreTsJRKN4EkQXc3m03 y/9y3lvye2R01wxJS/WWkbFrYlsoEoWvlGRUlCEKEEKrzt61j4T3nPIMtEgjBvrNyG8b xNte1dajFtQa/SXAn9uZ1sBZ1F6T26E1S+9W0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755545296; x=1756150096; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aqyW9AMQrLhoPKJmxnqNq0eziaV39pB/4sS3+0Stwwk=; b=PNaQFerkq9fnI04g9h3yLlejO2yb4W79Jt49sTrVupGNOk3qA+uJsP2GtMjUQ4ZK6e VADfScXzs1VzkoCE82jS1hk6iDozaNg5MZpg6PgAeoW1PrvyuJyqLDoxPj4Xfw+AZyBO 0YL7H7Eeq0RvLlk1xHd+R9+obcNjgX9lFO9caMujTY8eTnlBv57opO5H91/a05MU9l78 iMrDlCDsTmRkj8kI6m+QLOS9ENzncFfNZJsZFFXxH0tDLbeHVdXcK4ebDhRX7IZylC5d nq/Y4xolaWZr0SAk9S2XsNcuU5kr/K7wCFlyttxPWC/dnJ/xUdlP4uboCYyfAO178Czq MSEg== X-Forwarded-Encrypted: i=1; AJvYcCXvSutHzk8BieJfWJFMc37DVwK79sYEvVniAXpRPvt0QtSJDQkbbsUUrGcpoquVMcWXiGSAP+OcyKkviik=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm6Vm3P3sYefgiKgTwdA1bihlya1h8EgDE3u/GEoEf1h/p62By sM7aCWmR4Bf4ZveApx3Oi9DOan5zRUO0Aji6nUMTTt89kN4AHLRSQlIzY/qxezHBtQ== X-Gm-Gg: ASbGnctCOGgWrqtqA4pJnEFgYZAhEn6dA87tatlw6MQuUQ3YWs58HW1dBSlFt33XJpX ytHOubbMJIPhjgbrCvs/MgaOMCoMVUbY5vDU4Lp7QkRR8rXQGW2XGobcHL5dqQodaV4/jqZWB0J KvnTIKqq6DBE4wQNu7MTF1jm0Y/fIKfvB+QQolMWUEpgW+ERK4PPEiKJ0+9NgvPaI4uKWV8djSo UW03Ij4+vdjRSqQ96ltIkYKMo0QgaQL/sp95WzKCOdN24ElWXB75+OWQ233i8V38B3vOFfPLCFz DsfRc+60fLTIoFfUsd8Y/Gbww+XX+uf8wBEGtdzx4v6Y3VPvquv3ctdF/WsI+MIK2oYZyJCVgKU eTwm73OEQh6g+ewubV9xmOCE1hbugnaKjl2bRK+XYec6PcDvE/SLSf3NJ+yFrHL+dLcHGzHI= X-Google-Smtp-Source: AGHT+IGUiDIahxTrO0TYLvTSrJjpE4pGbPAwnmno/R5lKQScD3kDdYlgMAqEtTktqb0OtuaWUfumMw== X-Received: by 2002:a05:6a00:80f:b0:76b:e109:a1f4 with SMTP id d2e1a72fcca58-76e7ed284acmr471305b3a.12.1755545296604; Mon, 18 Aug 2025 12:28:16 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:87a3:e3ff:ace1:d763]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-76e7d524c88sm354460b3a.76.2025.08.18.12.28.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 12:28:15 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , Guenter Roeck , linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH 4/6] genirq/test: Skip managed-affinity tests with !SPARSE_IRQ Date: Mon, 18 Aug 2025 12:27:41 -0700 Message-ID: <20250818192800.621408-5-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc1.167.g924127e9c0-goog In-Reply-To: <20250818192800.621408-1-briannorris@chromium.org> References: <20250818192800.621408-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Managed-affinity is only supported with CONFIG_SPARSE_IRQ=3Dy, so irq_shutdown_depth_test() would fail with !irqd_affinity_is_managed(). Skip such tests if they're run without support. Many architectures 'select SPARSE_IRQ', so this is easy to miss. Fixes: 66067c3c8a1e ("genirq: Add kunit tests for depth counts") Reported-by: Guenter Roeck Signed-off-by: Brian Norris Reviewed-by: David Gow --- kernel/irq/irq_test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c index 56baeb5041d6..ba85e4eb5211 100644 --- a/kernel/irq/irq_test.c +++ b/kernel/irq/irq_test.c @@ -46,6 +46,9 @@ static int irq_test_setup_fake_irq(struct kunit *test, st= ruct irq_affinity_desc struct irq_desc *desc; int virq; =20 + if (affd && !IS_ENABLED(CONFIG_SPARSE_IRQ)) + kunit_skip(test, "requires CONFIG_SPARSE_IRQ for managed affinity"); + virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, affd); KUNIT_ASSERT_GE(test, virq, 0); =20 --=20 2.51.0.rc1.167.g924127e9c0-goog From nobody Sat Oct 4 08:05:13 2025 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3ED1275878 for ; Mon, 18 Aug 2025 19:28:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545300; cv=none; b=rhxl9B/6bfRKa1dqEObwdGx4MqnaXR3owoyRgGYKBBP9Hqb6BwPFGCQSmR5zVcpst3kFKrM74JX/o+xhBormRNH83iUPuMvXr4tEQ58CjjKCEpmQ8Bgan++wVzCK5MUJd/3Uj926u7z58jEnOl/20qDLY2IT+aFVKi5u6cMoH+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545300; c=relaxed/simple; bh=nFK99rkugGWbhOPAgzP0X6sTaz2xMT7wWgH1VAAtpy4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Edffy9fwwwraLSvfiFQcOJbON0YI5lzBtjAy8AskLVJi4OSDRkcSgjyckSRdMUna6YE38Smhi5UlXQQHWnnlCaRSCdG4+8C8zsYRifvo/ZLpME1q0Dowd4+uEkAxLMIc7MPTmfgC4j/scgDDjGPfp5O2OLfHGnhy/WdW+mxQcwo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ElBcipYP; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ElBcipYP" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-323266d6f57so4546299a91.0 for ; Mon, 18 Aug 2025 12:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755545298; x=1756150098; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XYPdsUc4rC1lF5/ZvuyamVIOSi89rwuh7w2izc4+wAA=; b=ElBcipYPWM7J5dYwzfUbz7m9AmkfoV4RoS+VMSci/Qp3PhnUc7WYxxjTzgDJZs28YI wFi6Gimv+cK3lF3QWcFeP1qxO3rK302EtuSH630qJGHAxlnySTZtM/LLorW8hRJFLhie gdj2LZ331swUN2uS/PxF279t+a77cl9UHKdbI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755545298; x=1756150098; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XYPdsUc4rC1lF5/ZvuyamVIOSi89rwuh7w2izc4+wAA=; b=nYbJ6XJZ/S012TgaznYp0xDlge34rgVrZnNCmGWqVOocOccMA/yORVMXiduRrtm2yN DEJP52sB6e0G7L4g+xvVgx8DAGk1F1KYmD9oEcGWcRcuyMsuTCBkTDwShiei+zLUJsIK bvLVbiMRv0fIvgLxTmhBfc9qxjeGweUVeLPXLkbZ0H3S8pneZoKYisZh6vAv849o9bIP YFcM1FXpwnbwrsCzy2ryl1lqHfbXT5X6xPjBNY4tLA6qF9nhHKYlYtwedqTElNKG/4yQ wegYjtVT8555TrcV63LqygGkw2Tg0LdAIsOGbmaMLV1MfYC4fxWra5jtM1o7v2tFF65t NJ7w== X-Forwarded-Encrypted: i=1; AJvYcCVI50EO6HqbPjvvh5CzoAGrDg44x6PBM++sMDsSlV6hSGoVCvxINj6CdIgNiBo5PbvyaQEBXDXNen/vMes=@vger.kernel.org X-Gm-Message-State: AOJu0YwB6lQ3t7gpE6zQImrhy4S1oQBcpkwo90H1d8sJjdJANOiwM4yO tDNpd8nwXGsMZAT5AbqcbRA68oJFL+tob0Nv17zmQAys9oBSB1+ivX689MVdKUEy8bEt7zSjG7r MfqE= X-Gm-Gg: ASbGncuvw5ZVc8Ql+MoD64gB6yNlJIn+dqqkFwco6D6wSVeLDdV5ZLLzdDqDYITD1Ep gSuiN7Rpg7hUAcghMj3/blqbpysP0HRR4DX4sxiavX4Z6RkQ8uLt+ImHkD+HNXCuF1euXwFt6Y6 kYhsk9e8amnHKXcFsX44fOrRTx1FBijLUz0fB8HWpUjuw7NI8s1yupCxQLkV58W1rSMuTQvoSzg JQXdgCDXE+3iQM2hCKAhvK87qcMX70DIBcKvi0MHeWw8PKihw6fF7rNCdETCAY0zxpciCBO3vEQ CXlC8OJUQcZBwfu8eePSMEjGRKy91wXt4x0whllttlFQHuvaaEozchs1VuuKSi3RNGG9Ycv+w6Z PdIDj3R8gob6UV6MrycQY+Qi7RgBePkRyjUfG0L7tGjcHcsxzdCuVFeASPXBl X-Google-Smtp-Source: AGHT+IHTZmudz35uDDaYMd2hGKcNZAl544XEnyNxN0mHkhu3RS+P1dFW6FofB2HGwRmOB3Qc/2HeNA== X-Received: by 2002:a17:90b:2250:b0:31f:42e8:a896 with SMTP id 98e67ed59e1d1-32476c06557mr32232a91.34.1755545298264; Mon, 18 Aug 2025 12:28:18 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:87a3:e3ff:ace1:d763]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-323632812b3sm4661318a91.13.2025.08.18.12.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 12:28:17 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , Guenter Roeck , linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH 5/6] genirq/test: Drop CONFIG_GENERIC_IRQ_MIGRATION assumptions Date: Mon, 18 Aug 2025 12:27:42 -0700 Message-ID: <20250818192800.621408-6-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc1.167.g924127e9c0-goog In-Reply-To: <20250818192800.621408-1-briannorris@chromium.org> References: <20250818192800.621408-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Not all platforms use the generic IRQ migration code, even if they select GENERIC_IRQ_MIGRATION. (See, for example, powerpc / pseries_cpu_disable().) If such platforms don't perform managed shutdown the same way, the IRQ may not actually shut down, and we'll fail these tests: [ 4.357022][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at ker= nel/irq/irq_test.c:211 [ 4.357022][ T101] Expected irqd_is_activated(data) to be false, bu= t is true [ 4.358128][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at ker= nel/irq/irq_test.c:212 [ 4.358128][ T101] Expected irqd_is_started(data) to be false, but = is true [ 4.375558][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at ker= nel/irq/irq_test.c:216 [ 4.375558][ T101] Expected irqd_is_activated(data) to be false, bu= t is true [ 4.376088][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at ker= nel/irq/irq_test.c:217 [ 4.376088][ T101] Expected irqd_is_started(data) to be false, but = is true [ 4.377851][ T1] # irq_cpuhotplug_test: pass:0 fail:1 skip:0 tota= l:1 [ 4.377901][ T1] not ok 4 irq_cpuhotplug_test [ 4.378073][ T1] # irq_test_cases: pass:3 fail:1 skip:0 total:4 Rather than test that PowerPC performs migration the same way as the IRQ core, let's just drop the state checks. The point of the test was to ensure we kept |depth| balanced, and we can still test for that. Fixes: 66067c3c8a1e ("genirq: Add kunit tests for depth counts") Reported-by: Guenter Roeck Signed-off-by: Brian Norris Reviewed-by: David Gow --- kernel/irq/irq_test.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c index ba85e4eb5211..553963136259 100644 --- a/kernel/irq/irq_test.c +++ b/kernel/irq/irq_test.c @@ -206,13 +206,9 @@ static void irq_cpuhotplug_test(struct kunit *test) KUNIT_EXPECT_EQ(test, desc->depth, 1); =20 KUNIT_EXPECT_EQ(test, remove_cpu(1), 0); - KUNIT_EXPECT_FALSE(test, irqd_is_activated(data)); - KUNIT_EXPECT_FALSE(test, irqd_is_started(data)); KUNIT_EXPECT_GE(test, desc->depth, 1); KUNIT_EXPECT_EQ(test, add_cpu(1), 0); =20 - KUNIT_EXPECT_FALSE(test, irqd_is_activated(data)); - KUNIT_EXPECT_FALSE(test, irqd_is_started(data)); KUNIT_EXPECT_EQ(test, desc->depth, 1); =20 enable_irq(virq); --=20 2.51.0.rc1.167.g924127e9c0-goog From nobody Sat Oct 4 08:05:13 2025 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A95BF2773F1 for ; Mon, 18 Aug 2025 19:28:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545303; cv=none; b=nfyfW75SkB8diocL11NfP/7PsUkSskAayTbYCJp/5hmDZPmDhrHc+GrCMXBiKROH4q93cposG+pIQnGOwtyv2bVySEntb1VVxXvKwtDwpqSbnwLwuCMRktLYzwSdM7xFgn53KP0kwHrIqJDLWnnayVm8RcFyzNqq0e9Ria4AaP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545303; c=relaxed/simple; bh=hVLL2zq/YTw+TqYo4tsPAPwG5+xsKZK5ymWiu3/MLbo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G8e7KAGUNoN0wPB7M3dBjJsK3IX8Da+G6NbZQAmD8yc0gYwOTpsEVQv6gZmvYb0+NL8t/yAI3sSAW43FvXKfC/HEBkXhv9T+647oa6DOL08+jmF3QihRK7XCwa7oofXrDrrIh5tYj1zwHsCdXquwdjbpEf49WfqIRGlajqZe4no= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=RfOljyYp; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="RfOljyYp" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-76e2e614b84so4290685b3a.0 for ; Mon, 18 Aug 2025 12:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755545300; x=1756150100; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X4JNZCWKQt+gVsEydD3GlPTBZY5ljS/Se9ONoS22WHk=; b=RfOljyYpfpib54aEeUYdiNnIeb4nI2sGdqd7ewstp8xWiuaA4vbGOHt2h+12IuD9DW 01vxIyFfv7eJeWtmhATZV567Dl99ZZQxhnGxhz3QTEO9iUWeaDaogv0NJm3RxYbvcnW0 98h/yJGU21+RZvUwAHY5/8H+L7R6Wmn6N+hGQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755545300; x=1756150100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X4JNZCWKQt+gVsEydD3GlPTBZY5ljS/Se9ONoS22WHk=; b=RNWBOdpODAUSkPAUOrcrjR/++CwVHi3P9bZQLOPAQlUGXzXa2d5TJWZwVhRrpRVq+1 3ZBXiR/OJSjI/nDZ4iMeAft+bwvAAFVbFtHoZcaVXhVyg2e5HLdUMAWRrhEikxGQhwAx 6tMWazAuGIYbKf+ZIk5oF4GqDNefyLQ8fWfaGPDrhElGxny+lhT1BacAx1BOaleUB0ou wFM/8n70hVJ4UTBHwwa0ltMr/9G3Gag0Ce+mjFSc6lGqgSKBUxFo2x0KefkJxwDZhFSg eILC0E+uvghudJJif4ZTcVx149xK1hWqtPbDh9hIwxxGiOrQnu/yaSV3i3sijGB0zKpw apaA== X-Forwarded-Encrypted: i=1; AJvYcCXeMnmbmkZ0MxTZdVlCk6f1h8R66TflYXPN85MRewfPMck/Nf8BRuLSqDNFeKkL+LLuRkDa+JRuJYiUFhI=@vger.kernel.org X-Gm-Message-State: AOJu0YzB+fVkQh57U+3qvmzZRiPVZDGbSmiMhGZeRcqnPx9X7YTpyBHI wqJ31SBCz/jlbZ/vO0Vo/ff9UJ74fmLr1bAZulJ+VmN1gln8SeZFHbRDmIUqD5o6Qw== X-Gm-Gg: ASbGncth2RdCBQoQDyLn1Ut0jTiWXr2vYdw5ppVwz/aUXmNCQzBNgEt5PMdvSH85h/n 3e38/TBPMyMyLFzTJR6zHDIz80AUoETk3gDE892rQAsDCSxEwzUagtv6SSGoBu+Cqhb1hjI1kDG HGBXkKwvaA/4BWEKNbXhrf0oZSxB7pP9wRL2PGO3n6yEm1Mg0KyBEDX/QU1C1ynCWWffk1NjUDj bnZ2srgTRYpZIQO379R6zA1x2dlmfuaHiCXgdONbrDFBUKy/YqDS4okEMVvIv4+voQ66uukd7dN FmvF1EughByKY4oITnWWzxiXu75lCD16ox/yyqRLmOnFCxO41kUpElKacNTAk7rA2ognZGu7JIz aUxuWWOMsnNI28+8oAd+ZOtHKPS/pxy/aNA9wS4ESDKQM28j3i3s8uZStO8nZidLf5wIrvRs= X-Google-Smtp-Source: AGHT+IE3gDgaOouOZi/Z5HeS6o0mYWNmw//G45w+Xx1J6bpSs3aVGqysOjPxONHf859nlLnNrRTrHQ== X-Received: by 2002:a05:6a00:1701:b0:76b:f01c:ff08 with SMTP id d2e1a72fcca58-76e446a7638mr16534029b3a.2.1755545299930; Mon, 18 Aug 2025 12:28:19 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:87a3:e3ff:ace1:d763]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-76e7d524c95sm349325b3a.81.2025.08.18.12.28.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 12:28:19 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , Guenter Roeck , linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH 6/6] genirq/test: Ensure CPU 1 is online for hotplug test Date: Mon, 18 Aug 2025 12:27:43 -0700 Message-ID: <20250818192800.621408-7-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc1.167.g924127e9c0-goog In-Reply-To: <20250818192800.621408-1-briannorris@chromium.org> References: <20250818192800.621408-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It's possible to run these tests on platforms that think they have a hotpluggable CPU1, but for whatever reason, CPU1 is not online and can't be brought online: # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:210 Expected remove_cpu(1) =3D=3D 0, but remove_cpu(1) =3D=3D 1 (0x1) CPU1: failed to boot: -38 # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:214 Expected add_cpu(1) =3D=3D 0, but add_cpu(1) =3D=3D -38 (0xffffffffffffffda) Check that CPU1 is actually online before trying to run the test. Fixes: 66067c3c8a1e ("genirq: Add kunit tests for depth counts") Reported-by: Guenter Roeck Signed-off-by: Brian Norris Reviewed-by: David Gow --- kernel/irq/irq_test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c index 553963136259..2e7adf06fd17 100644 --- a/kernel/irq/irq_test.c +++ b/kernel/irq/irq_test.c @@ -182,6 +182,8 @@ static void irq_cpuhotplug_test(struct kunit *test) kunit_skip(test, "requires more than 1 CPU for CPU hotplug"); if (!cpu_is_hotpluggable(1)) kunit_skip(test, "CPU 1 must be hotpluggable"); + if (!cpu_online(1)) + kunit_skip(test, "CPU 1 must be online"); =20 cpumask_copy(&affinity.mask, cpumask_of(1)); =20 --=20 2.51.0.rc1.167.g924127e9c0-goog