From nobody Sat Oct 4 08:03:11 2025 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E976F38F9C for ; Mon, 18 Aug 2025 18:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.183 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755542852; cv=none; b=IMY3c9LfDAld3/29If/Ea3pROfqkCdZdEq6IuvLaY1s8ko+5umox3KjIOrd7G42058QBOa/tNaMO+y+htp6MBWj/FNuAu2wD0dLZmrcjGWNEghTPJmrdhwYPlxKSLyIboD4XXcDx08LJgiMXG6AyTpcccgQdirX6KT8jvZCrQCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755542852; c=relaxed/simple; bh=I3mlaDpEqcNDtF5YfZZG3GKucVAs2J1X19Vhup6jOKE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EmWFAAFj3ZGaqn4qg4c5ofzpv1LdXDIIhZkcHzqR9N3EOZrZ9NDSCSVQFDmu+6ytd/1uqdh4HhYmThnTKaCGoJ3rOdHa876BiaZ8rWvTxioE/C36zQIhhULZiCTeA0rSqLb+/uhe9FrXFISd4XpjvGa89czo0vFFIspW3Ocinns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fT+6cKY5; arc=none smtp.client-ip=95.215.58.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fT+6cKY5" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1755542839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=h+q0dQZyXjwiVna/qdmYwFty7+4QP8wlenLPfPU4ybI=; b=fT+6cKY5SW9ud/HQq2Jjmg+rGfIZYENyeEUS2fD5hp+uiWlb58YP4vKBRHjcz6ojhSyWg9 kP901WLvabyW9uXifTsf1ehbo/jZXV1cptnbqK15RhqKwAmMbhYFj9i6l3pqRwffY7IqPm Rt3QRUcLJgj+8/3wtJbTN+Bds3MBoMM= From: Shakeel Butt To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Boris Burkov , linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: [PATCH] memcg: remove warning from folio_lruvec Date: Mon, 18 Aug 2025 11:46:44 -0700 Message-ID: <20250818184644.3679904-1-shakeel.butt@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Commit a4055888629bc ("mm/memcg: warning on !memcg after readahead page charged") added the warning in folio_lruvec (older name was mem_cgroup_page_lruvec) for !memcg when charging of readahead pages were added to the kernel. Basically lru pages on a memcg enabled system were always expected to be charged to a memcg. However a recent functionality to allow metadata of btrfs, which is in page cache, to be uncharged is added to the kernel. We can either change the condition to only check anon pages or file pages which does not have AS_UNCHARGED in their mapping. Instead of such complicated check, let's just remove the warning as it is not really helpful anymore. Closes: https://ci.syzbot.org/series/15fd2538-1138-43c0-b4d6-6d7f53b0be69 Signed-off-by: Shakeel Butt --- include/linux/memcontrol.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 9fa3afc90dd5..fae105a9cb46 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -729,10 +729,7 @@ static inline struct lruvec *mem_cgroup_lruvec(struct = mem_cgroup *memcg, */ static inline struct lruvec *folio_lruvec(struct folio *folio) { - struct mem_cgroup *memcg =3D folio_memcg(folio); - - VM_WARN_ON_ONCE_FOLIO(!memcg && !mem_cgroup_disabled(), folio); - return mem_cgroup_lruvec(memcg, folio_pgdat(folio)); + return mem_cgroup_lruvec(folio_memcg(folio), folio_pgdat(folio)); } =20 struct mem_cgroup *mem_cgroup_from_task(struct task_struct *p); --=20 2.47.3