From nobody Sat Oct 4 11:14:57 2025 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EDAE27874F for ; Mon, 18 Aug 2025 07:17:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755501460; cv=none; b=LGtesa5bDDBPWupWjTqTyrsrs/EoClPWrd3CHjxcRX6zv2szPUsDQ8hstEjag2CIc65cTP5dPAW1UQTzSxQN0Qk2YaSFtjudY4YiPAv3eVS33o0mHOBMEaSfET9/KMXWlJIG8cZHWUMCz4D8rs3XcLNO+uOdXClzq47QmimiZwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755501460; c=relaxed/simple; bh=wYVUt8KOyGWOZdkUNpunXsCZ0A9yFPuL+kWAC+HLcXM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qJsAFKJ6BqGj4naIM7RElW6NZH6rIiQ8/if1/gN4tbIaSsLgPVwnTKrZUwgdGuhLscLnXhvSz8aBfgiuQUCltE8JX4yVSJ6irq3jwjY6JbhOXL92kKax3/ps6sNxEVJ1I8EOV8KJ11rKdsZKZmPYrZn7PF4vWU8d8/qibrCVClU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eIWtY6qq; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eIWtY6qq" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-b4717ba0d5dso2566149a12.1 for ; Mon, 18 Aug 2025 00:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755501454; x=1756106254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pj3iAGQDBfnjGM61+iuWSfRjrdsa8vv7fkvRwb3+f9I=; b=eIWtY6qqwMKZX1kaW5dqX9KfIr8RUZydLvAtAZ4smwbX20BmEf2NY4FtcnxGLET3H8 7gKsZ8X5GaSZggFSHx3IvwagWmP4gh88ii1l2rIQs3OUGxOWX8w+RyqzKTIZbjFYiuK6 YHMvHjQ7FCFwVEyhCISZrWU0c3G5dL0AraoL5Go8Tdg2U6xtqVZJ8TXN6DfsEjgf/tEA 7CMhRCkUIliqS4w+5I/c7DBPLfZKUaRtt/iEMSdrhf8g/Jz23GJWpH6AL7xUdUznU/O6 C40UKS+AcuybchiNaQNlgDgN63rxerP+PvBonqNx+wey0Y1JRFvWpcHFG4OfDygN1IH+ uU6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755501454; x=1756106254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pj3iAGQDBfnjGM61+iuWSfRjrdsa8vv7fkvRwb3+f9I=; b=nYazwWbVO/MjoPvYoV5bMNlQnEDS/niOr6+hzp2ppO4ACNCOkmX4dxstM2+VxBoDc7 33uXVI6Crk0LtvL2huyaS4vTVJHP272KGMZ5TrD/v+8coFjOKNU0lKK0UJ7g2zfLSkS9 da12+JGq5koLlnzIi8vugprL3XbVjrhq4FBioClwrTDr4Apd4H9Hs/3lVPKfMIosU+wR Pu8797M33ZK4ir+dpYJ4QNgC5barM6QTlgFaqUaY9rzEP3PmPAeQ6fTFSYNuKb89hUWT nVdI4rj2F/h+BTquPz7DkdAWYNt5ML06PMHqwDiMQSKhyIXjFSs1vGFvZnRpzcaz2uGC e+hg== X-Forwarded-Encrypted: i=1; AJvYcCWeH4Nl1+h5vNyVtPWJ2hwGgAsgriTTvzyo0PxDd2F70SJZougTmy/TIcNw6YNg8AaFJbtvMBXAayqRV/o=@vger.kernel.org X-Gm-Message-State: AOJu0YxbqKszRJmyRVfdBEUf4PpVlFJE64/1zytGl6bJyTnJ2Y0yxUQG 4jSsVr0R02sSCdPA3JybaaFumat/VsnjDsf/CTSPZa6+kggNz+JthLUWLvMcshkwyBQ= X-Gm-Gg: ASbGncuexZNGuHpXD5wSHuH73RnWYU/71duPg8gB0eTVyy0RFpBqHn8mTMBpQzw6jSk s5ps6vt/jB6h1PwRzrkIZSH+v79QWldk2b8oYIcyw9Yr1Sk210XC6lQocx7FfxHpkUfuUiYv0G0 taVdfE6DpX99mqPoXpRA0ie1EehqQ0pmcCChNsx37JzpPU3RQDATkQmspJjBOGtURN1Kz2tM6HS NHHEE0EzM4Y4KAchvNSICS4CcHTDpVUqb2VN1jErrh5B+AuXnH2VO/hFE14OjSib/MRqTq7+9ps OV/AA1VugTr/opfJi0UoHlvP6yGd5dKprUGoORfsZEztr8E72WPp4Ywe+1dPUn0hzH6SNfjrsJ1 cq6Hi0vODFFdMmZJyw26q/2xgO+H8dvn/mkIo1Dnb5t/mlg4kB2DtPQ== X-Google-Smtp-Source: AGHT+IEFJNnZ6FrR2en17sXo73X9DuK1LxZNjQHgizccIJ9SYRNb5ZvWineSqQtBSA3ZtHqil12tnw== X-Received: by 2002:a17:903:11c6:b0:234:325:500b with SMTP id d9443c01a7336-2446bdd77damr167814615ad.22.1755501454480; Mon, 18 Aug 2025 00:17:34 -0700 (PDT) Received: from 100ask.localdomain ([116.234.47.202]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2446caa4139sm71934025ad.17.2025.08.18.00.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Aug 2025 00:17:33 -0700 (PDT) From: Nino Zhang To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, straube.linux@gmail.com, Nino Zhang Subject: [PATCH v2] staging: rtl8723bs: fix coding style issues in core/rtw_mlme.c Date: Mon, 18 Aug 2025 15:14:11 +0800 Message-ID: <20250818071411.90159-2-ninozhang001@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250817054202.31171-1-ninozhang001@gmail.com> References: <20250817054202.31171-1-ninozhang001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes blank line issues in coding style: - Remove unnecessary blank lines after an open brace '{'. - Remove unnecessary blank lines before a closing brace '}'. - Add missing blank lines after variable declarations. - Add blank lines after function, struct, union, and enum declarations. Signed-off-by: Nino Zhang --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 29 ++--------------------- 1 file changed, 2 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index fdf06b5253a7..c06d990350e6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -200,7 +200,6 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, str= uct wlan_network *pnetwor =20 void _rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_net= work *pnetwork) { - struct __queue *free_queue =3D &pmlmepriv->free_bss_pool; =20 if (!pnetwork) @@ -255,11 +254,9 @@ void rtw_free_network_queue(struct adapter *padapter, = u8 isfreeall) =20 phead =3D get_list_head(scanned_queue); list_for_each_safe(plist, tmp, phead) { - pnetwork =3D list_entry(plist, struct wlan_network, list); =20 _rtw_free_network(pmlmepriv, pnetwork, isfreeall); - } =20 spin_unlock_bh(&scanned_queue->lock); @@ -348,7 +345,6 @@ int rtw_is_same_ibss(struct adapter *adapter, struct wl= an_network *pnetwork) ret =3D true; =20 return ret; - } =20 inline int is_same_ess(struct wlan_bssid_ex *a, struct wlan_bssid_ex *b) @@ -378,7 +374,6 @@ int is_same_network(struct wlan_bssid_ex *src, struct w= lan_bssid_ex *dst, u8 fea (d_cap & WLAN_CAPABILITY_IBSS)) && ((s_cap & WLAN_CAPABILITY_ESS) =3D=3D (d_cap & WLAN_CAPABILITY_ESS)); - } =20 struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue,= struct wlan_network *network) @@ -410,7 +405,6 @@ struct wlan_network *rtw_get_oldest_wlan_network(struct= __queue *scanned_queue) phead =3D get_list_head(scanned_queue); =20 list_for_each(plist, phead) { - pwlan =3D list_entry(plist, struct wlan_network, list); =20 if (!pwlan->fixed) { @@ -419,7 +413,6 @@ struct wlan_network *rtw_get_oldest_wlan_network(struct= __queue *scanned_queue) } } return oldest; - } =20 void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src, @@ -454,7 +447,6 @@ void update_network(struct wlan_bssid_ex *dst, struct w= lan_bssid_ex *src, sq_final =3D dst->phy_info.signal_quality; rssi_final =3D dst->rssi; } - } =20 if (update_ie) { @@ -516,7 +508,6 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t =20 if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned)) oldest =3D pnetwork; - } =20 /* If we didn't find a match, then get a new network slot to initialize @@ -560,7 +551,6 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t pnetwork->network.phy_info.signal_quality =3D 0; =20 list_add_tail(&pnetwork->list, &queue->queue); - } } else { /* we have an entry and we are going to update it. But this entry may @@ -623,7 +613,6 @@ int rtw_is_desired_network(struct adapter *adapter, str= uct wlan_network *pnetwor return true; else return false; - } if (adapter->registrypriv.wifi_spec =3D=3D 1) { /* for correct flow of 8= 021X to do.... */ u8 *p =3D NULL; @@ -900,7 +889,6 @@ void rtw_indicate_connect(struct adapter *padapter) pmlmepriv->to_join =3D false; =20 if (!check_fwstate(&padapter->mlmepriv, _FW_LINKED)) { - set_fwstate(pmlmepriv, _FW_LINKED); =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || @@ -974,7 +962,6 @@ void rtw_scan_abort(struct adapter *adapter) pmlmeext->scan_abort =3D true; while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) && jiffies_to_msecs(start) <=3D 200) { - if (adapter->bDriverStopped || adapter->bSurpriseRemoved) break; =20 @@ -1067,7 +1054,6 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str } =20 return psta; - } =20 /* pnetwork : returns from rtw_joinbss_event_callback */ @@ -1502,11 +1488,11 @@ void rtw_stadel_event_callback(struct adapter *adap= ter, u8 *pbuf) =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { - rtw_free_stainfo(adapter, psta); =20 if (adapter->stapriv.asoc_sta_count =3D=3D 1) {/* a sta + bc/mc_stainfo = (not Ibss_stainfo) */ u8 ret =3D _SUCCESS; + spin_lock_bh(&pmlmepriv->scanned_queue.lock); /* free old ibss network */ pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->netw= ork.mac_address); @@ -1536,7 +1522,6 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) if (ret !=3D _SUCCESS) goto unlock; } - } =20 unlock: @@ -1595,7 +1580,6 @@ void _rtw_join_timeout_handler(struct timer_list *t) =20 /* indicate disconnect for the case that join_timeout and check_fwstate = !=3D FW_LINKED */ rtw_cfg80211_indicate_disconnect(adapter); - } =20 spin_unlock_bh(&pmlmepriv->lock); @@ -1645,7 +1629,6 @@ static void rtw_auto_scan_handler(struct adapter *pad= apter) =20 if (pmlmepriv->auto_scan_int_ms !=3D 0 && jiffies_to_msecs(jiffies - pmlmepriv->scan_start_time) > pmlmepriv->a= uto_scan_int_ms) { - if (!padapter->registrypriv.wifi_spec) { if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING) =3D= =3D true) goto exit; @@ -1778,12 +1761,10 @@ int rtw_select_roaming_candidate(struct mlme_priv *= mlme) phead =3D get_list_head(queue); =20 list_for_each(mlme->pscanned, phead) { - pnetwork =3D list_entry(mlme->pscanned, struct wlan_network, list); =20 rtw_check_roaming_candidate(mlme, &candidate, pnetwork); - } =20 if (!candidate) { @@ -1875,12 +1856,10 @@ int rtw_select_and_join_from_scanned_queue(struct m= lme_priv *pmlmepriv) =20 phead =3D get_list_head(queue); list_for_each(pmlmepriv->pscanned, phead) { - pnetwork =3D list_entry(pmlmepriv->pscanned, struct wlan_network, list); =20 rtw_check_join_candidate(pmlmepriv, &candidate, pnetwork); - } =20 if (!candidate) { @@ -1968,7 +1947,6 @@ signed int rtw_set_key(struct adapter *adapter, struc= t security_priv *psecurityp adapter->securitypriv.key_mask |=3D BIT(psetkeyparm->keyid); =20 switch (psetkeyparm->algorithm) { - case _WEP40_: keylen =3D 5; memcpy(&psetkeyparm->key[0], &psecuritypriv->dot11DefKey[keyid].skey[0],= keylen); @@ -2044,7 +2022,6 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ } =20 return ielength; - } =20 /* Ported from 8185: IsInPreAuthKeyList().=20 @@ -2449,7 +2426,6 @@ unsigned int rtw_restructure_ht_ie(struct adapter *pa= dapter, u8 *in_ie, u8 *out_ } =20 return phtpriv->ht_option; - } =20 /* the function is > passive_level (in critical_section) */ @@ -2484,7 +2460,6 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *= pie, uint ie_len, u8 channe max_ampdu_sz =3D 1 << (max_ampdu_sz+3); /* max_ampdu_sz (kbytes); */ =20 phtpriv->rx_ampdu_maxlen =3D max_ampdu_sz; - } =20 len =3D 0; @@ -2575,7 +2550,6 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr rtw_addbareq_cmd(padapter, (u8) priority, pattrib->ra); } } - } =20 void rtw_append_exented_cap(struct adapter *padapter, u8 *out_ie, uint *po= ut_len) @@ -2616,6 +2590,7 @@ void rtw_roaming(struct adapter *padapter, struct wla= n_network *tgt_network) _rtw_roaming(padapter, tgt_network); spin_unlock_bh(&pmlmepriv->lock); } + void _rtw_roaming(struct adapter *padapter, struct wlan_network *tgt_netwo= rk) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; --=20 2.43.0 Changes since v1: - Make modifications based on the staging-next branch. - Resolved the previous code conflicts.