From nobody Sat Oct 4 12:45:44 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 796B52F99AB for ; Sat, 16 Aug 2025 15:19:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357585; cv=none; b=kRocZwTaseU+/UHCMpHKAGuO3kYzguLqQMrjOu6V5WCtI0/tea06vrTUQ7Znb2T5aaYusSJzwxpXHEaqmeffBtL7Y8K4xesFdHLTCwBpwnLABiOgcII8/niTnw2j4mdeXiEUiEA2gwXipmk0QUWe9OkYlmVRwI8y4qrC4YCiZSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357585; c=relaxed/simple; bh=pfarMdKTP3PKuK/rYN2PwD9JvqS3ROd0ZonPoWJ3yhg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nGXBAkRLfOoEeRsa3pULrBBEQ1cz+IP6HPhMn7Klwxdp9TrmdxpqP9oMJmGomv+eFWQ24tXC5kZvimEbNfHhzYLeMIFXkAj9jfMXgk3ozZZtHs7TPOdopUfjdXWCt9XBCjaLDyhrdMKhw7hHIglsyDrpcf2A6N/3yh+LXIhbh9M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R5IKICsx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R5IKICsx" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57G3ALEk015774 for ; Sat, 16 Aug 2025 15:19:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ovJO1XSWvs0KNakJASmsJP5sNHD1z0QwbqY++5/N+xM=; b=R5IKICsxLv6COm9L PFZBk6sLP4uJR3A3VmpAMfp0N5eOTTrQoIkib5D+dYzFzDroTCmwNT6mTbwfFsaV X2jkvAKqoGclfm+vqCZlDyaZZ3futP8r88lBSkYl4SYqwzEGN9pqiEuSmJDnkrir 7ltUcd+SwHraN5/tVW7PeCQj5tO2HGFn/JufUdzNJEpRzz6EiwiQaDCr1po3ah8h br8mCgAe4ipRPOkgnQK4hM+6YJ+VvbenEyGIH4sG7S3sd9+FZZoUGB4XVNM9k130 toEuZ0l/whK3fJRWmEJ0pJJdoPbaAcWBHvI0oGZSZKD28mGs6f5stwEHkT4iI2wH 5KDlfg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jhagrvkf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 16 Aug 2025 15:19:42 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-70a9289280dso61133146d6.2 for ; Sat, 16 Aug 2025 08:19:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755357581; x=1755962381; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ovJO1XSWvs0KNakJASmsJP5sNHD1z0QwbqY++5/N+xM=; b=jY7ED6sxKNQT3bMF2XGzxp5wgdcoBACLksVry+ucmlERfsXxThPuvU13+LTY8xcOIU 1lw2uUQdZ/uZTVJNvpogVijhDbvQRF21fbIWPAWbeevDz3tMrKZNvuU0tURg7iF9lGhX ZfwoaeomUdJ9naLkA8qyikMSW2j5jrFLtvqD8PGyCVVBrZX6pVud7zMoH6yp4gIo4PnV qvZcMlmT29WC8rHqXiJ+O0O+ncXX45XF25+QB9w752GusTG7RlSA6nI5wAknDLBRbbz9 VBgVZRYf2P+q8JcTh2h5c8k8NqFS9zqTw06CkNKp4QFWNwyT+OIxu1AulqsgQlaDjbvZ /DJg== X-Forwarded-Encrypted: i=1; AJvYcCXXWNoq70abBB8R/k18fn/jpI0PDgk22yLN/aw5in/o9zeJCVvCfXdzdHpdHCm9vrMpLrpxsMUYHCBNeBU=@vger.kernel.org X-Gm-Message-State: AOJu0YzzQ/IX6RM0VYRiP0zdyjoNgWz+zYqkh5NX+OViQQAKXMLfIIUO M9I4AvVSEexJXHFQCfEBHMRTbszISbBZKUjUa4FcYEiAt/KHshk54byWbnqNo1ZlmtR4DDiUi0x fwuMi3c6C9uhpf7ckb99koSJmkqrJ6S1kO/m5vCvASR1nPOMEdYIGCLfcOg24LFd+Bvg= X-Gm-Gg: ASbGncvMy1SfpHSPWTm7EiLGCBsFOaEPmXPpWHi2jZkK04jnt2eYQEB0NnDbSDqeSpW eLnkBD2hKiS0M1Jij+sFPmV8FQhY+YsDAsMSzZeaOvSzTFOs1SUQF1nY2Bvf0DG4dLqegEUMn5p qaftmV201nqbdF3T/4KYbBRUtNuu9Owo+bbYezOljycFLMPOezyAADlmAKLBvNiXXz6nHObGCJS LmqhtWYLH+A53k5znCKJ2yRtiKQMdNe3O490l83iZ+f/+s/wvZkMP+wZdguExdzulqk31CUu5am VXQ+//4j4Rl0aCQL9rKLLK6WWtCauiRbe5G1A2n6DXWsc3N144s059H13coQPWUWNWsC8g+K32u W3ZKyQgFSsqxCt8BsmfxQhytBDdEV7Z2Cw8+0K6nt1HweJl+MRQ2V X-Received: by 2002:ad4:4ee9:0:b0:709:e3ae:d598 with SMTP id 6a1803df08f44-70ba7aa107emr81268156d6.14.1755357581463; Sat, 16 Aug 2025 08:19:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3L7Kg33TAOFsNeJ8twbLfA/y9ftS7KG9iciVNPJsGz5y06ZwF8dOFeuocvcqoStELWJ+qEw== X-Received: by 2002:ad4:4ee9:0:b0:709:e3ae:d598 with SMTP id 6a1803df08f44-70ba7aa107emr81267506d6.14.1755357580964; Sat, 16 Aug 2025 08:19:40 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef35965fsm907579e87.37.2025.08.16.08.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Aug 2025 08:19:39 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 16 Aug 2025 18:19:35 +0300 Subject: [PATCH v2 1/8] drm/amd/display: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250816-wb-drop-encoder-v2-1-f951de04f4f9@oss.qualcomm.com> References: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> In-Reply-To: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3090; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=pfarMdKTP3PKuK/rYN2PwD9JvqS3ROd0ZonPoWJ3yhg=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBooKGIUvDNB5/Vq1AfaWJ5dhoQY3yskNwZSsVo+ QLCjRWL1BWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKChiAAKCRCLPIo+Aiko 1RTIB/4oPGhWfB4pdoc2YqsPw9ILKe6U6yn/zFh6rnIOtHWK7ys5g3xj+GRAcwBghHgjcQ6BzH1 dehVbsEOedPhTFVaigfw2rPYmwG92pSk5kN5G2lc4oYNAsUF+DxFsfHK0loyjvrUkd2bFIT5jWh UtPLDKBtcuw/4M9zqa6ppMfgd1aVB1sibq2w7xnR7fuLjlHn6MugHO1j28LWmWWTpgTB0H5FYoE Olqr0/g4qa8uLRJbbDPzpY4QD0cdT0iKtnrU7KeeIMNItjD4P5bht0GvrFBxeS/39EluqjryGY8 eMVdRGRldWpOy6kPBFf2IhPHsn6/CuNNAbV8yiIu6J63L7Wt X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=D9xHKuRj c=1 sm=1 tr=0 ts=68a0a18e cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=M-qvw7r3wQx8XY5Jx90A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: -kEe0YJbgekAdACzuHkoz9KGBn4gTw4b X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAyNCBTYWx0ZWRfX/zPDIlOHQ4kU WUDt/sS2UA0xR9idMleXK/UjsdlXJk9hI7Kditf1OkfGlvte7uMkJ3hMRHwviCr3mlbAdbIEn4f mR2NkDHm2r9Me607MY7QlAOScNzzFnZ6jAi24TAma3BFL9fVAs8NoxlpgNlpAgzSpZsj4BRPSpT driXV0oeKyeCgdZTMyrbRjdYrmnxEiJ8RxsXDFuBFVzrXxMK5/WV1ZWEMPE/hOTMneeBT3bAe3X zqdgTWT4bdREGzxlMc+ZhHezZGFMis9d4gnrErP8nfPfgbMjSIDxK7akCXPxZj4BSaXVpM8oNMw lvUGDr85/CKcdH9VflvJ3fWVSYbzhnywcpB0phyvCYgSMc3n1ozGsjHmG4zNaI6NXxSQVS8E5Cz gA7bO/ab X-Proofpoint-GUID: -kEe0YJbgekAdACzuHkoz9KGBn4gTw4b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-16_04,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160024 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 18 +++++++++++++---= -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index cd0e2976e268da41f576624c50ef0c76ede67414..0c9d347b1efc804a28fb3095df9= 4e543a19e4159 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -10006,7 +10006,7 @@ static void dm_set_writeback(struct amdgpu_display_= manager *dm, return; } =20 - acrtc =3D to_amdgpu_crtc(wb_conn->encoder.crtc); + acrtc =3D to_amdgpu_crtc(crtc_state->base.crtc); if (!acrtc) { drm_err(adev_to_drm(adev), "no amdgpu_crtc found\n"); kfree(wb_info); diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c b/drivers= /gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c index d9527c05fc878ef6916782ff9fde847813938461..80c37487ca77c0494eaf769c5b9= a3c53486aa52d 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c @@ -171,7 +171,6 @@ static const struct drm_encoder_helper_funcs amdgpu_dm_= wb_encoder_helper_funcs =3D =20 static const struct drm_connector_funcs amdgpu_dm_wb_connector_funcs =3D { .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D amdgpu_dm_connector_funcs_reset, .atomic_duplicate_state =3D amdgpu_dm_connector_atomic_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -190,17 +189,26 @@ int amdgpu_dm_wb_connector_init(struct amdgpu_display= _manager *dm, struct dc *dc =3D dm->dc; struct dc_link *link =3D dc_get_link_at_index(dc, link_index); int res =3D 0; + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&dm->adev->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &amdgpu_dm_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D amdgpu_dm_get_encoder_crtc_mask(dm->adev); =20 wbcon->link =3D link; =20 drm_connector_helper_add(&wbcon->base.base, &amdgpu_dm_wb_conn_helper_fun= cs); =20 - res =3D drm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, + res =3D drmm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, &amdgpu_dm_wb_connector_funcs, - &amdgpu_dm_wb_encoder_helper_funcs, + encoder, amdgpu_dm_wb_formats, - ARRAY_SIZE(amdgpu_dm_wb_formats), - amdgpu_dm_get_encoder_crtc_mask(dm->adev)); + ARRAY_SIZE(amdgpu_dm_wb_formats)); =20 if (res) return res; --=20 2.47.2 From nobody Sat Oct 4 12:45:44 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 667822F99AF for ; Sat, 16 Aug 2025 15:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357587; cv=none; b=l/DNhBgdSYT77XwmYpoLt76ZuXtI4+ZvLqKsjVJWK8HdUUed0BungNnIS7aVjUX+Pd48KF2/5DzRk2Hwkr+fWWL7hLTU7YKN7cSq8MGI1m2KF9Myo5w21lUul96l9WwQ5TP6TLIJKTmahNm0Ws/ekw+OcQP7+oIYft/DLbOl++I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357587; c=relaxed/simple; bh=FAStH94G7STx9dmih1BwY2moi+ekwJevO6V7oZLap5U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qBgI0SvyEQ3xc8vSVATe5VyjeF2HhmsGf50PDtlGBst0A5BQRccR/pWDym3fjdoueZpr73vjpMUNLNNhM2V9xhXr2fLzdVEW3zXBWe+JxMUDPqOFmYccEsBinTKFkJzXmPBTe0hBa+lsr+2FCjdyZKWN8LNMMfYceBvYr2VSbNM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P3Qlr/sA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P3Qlr/sA" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57GDYF3d013020 for ; Sat, 16 Aug 2025 15:19:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3LiTGbp3yrZlb6BdgcZ8Qpq6CDIhRX/Qyb9HMEmTyzM=; b=P3Qlr/sAPTtXhNia iUQgs6sum8tN8E2pMz7a8TWihY4KgSewQaxH/ZJfgrXZ/PY5pEOd6sL0FyqPO2ao EzUb0Qr0R7ABXtB4JPF6KXf+02/u1iWYhU1ZiW0IzksMzTKQEWmWU6u7bYQiY1FP TUgzSv4L4ouPTCNd2LzYsZ3B2DLER/+5SadEdM/kMAOlYLhN/irGfubf19o4irlz m5NxVwNbLFM7Hg46WPSVzwhrfhZsZk+fNN8A2tUNdN/QhtJ26TI5JVza39u4mAbG +cHMw1zhe0173LPmx0Ejm9D9WORqMv8135jgO6eE4GFLFLrgYQYKZLCxSuyjsIIW mW1kMQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jjc7rsy4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 16 Aug 2025 15:19:44 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-70a9f5b078bso30247516d6.3 for ; Sat, 16 Aug 2025 08:19:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755357583; x=1755962383; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3LiTGbp3yrZlb6BdgcZ8Qpq6CDIhRX/Qyb9HMEmTyzM=; b=LUwNf4LUVGxSnxwkKh2ttwp82IxGt+qgieJ23pDHvnXU1TcBqrWHFrJz4ZdCGgMZr2 po3n5lhdyF682Xz6uZPgANJPoLUzqtEgOGjSc7vLqjrOfXfYD6tPNjrlwP/V79kOavsU VVkWkF9x2hxQGsGm1j+aqMd1k6GKQl8M6MnAtufRAC08D69TIP7aG7Wl3U8wH5XUUNUk TmeWuM+YWlfMESKeQxGe8AzgsOjWefhAT2elVDJQ0CoTJMnKlYDTC2pb+rBdVF4fTplT SVktLAwMlu+Nb5YWZFFQYIdKJu3f0GbSIKkqYeMci+ildbxmmLORArZZHYmikpjhjHQr qmWA== X-Forwarded-Encrypted: i=1; AJvYcCWK0ik14GblFK8aCiusjaRca/5OYSaRtciHqz8z3jMtGRKPuBFLmIs3yyOalimVkre6CNad4gmAKm3mmrA=@vger.kernel.org X-Gm-Message-State: AOJu0YwJQ1E/mpkOSYeFRVcmtyxBedEgtUkVBF4uw4eyOl/eCwhGOvsW CWf9Z0CzyJ++N13vUuTEYFWY/4CNRfoJJlq05BG86rm6t9rpbds2z80YTh15w0Phxxab2ZemRmx XA50oYrrGhtErcLihKL9J8LhmdaCR2TJ3R7MKnE+yl7HpTVlkoP6OGN4suuaDIhH2B7k= X-Gm-Gg: ASbGncvejR+nhM92NXrH/EdxcJ5rhI/BUYF3zxSqx6Xj+GPhvv+v4A1LIw7qffQxyXI V/3gipFusAdia4VP4RFa0CB4FNWGRgALi2VzPpu8sddshtglRsj7vZVOWyXYs/pErbeWojB4Q56 dnMLdz1v6u6DFPnMnPMwe4Zi0tOYZxJNEtgN6Xv7NRzbK72b6so47Gdl3O1CN63ofc0N6eR3Bbq K3SbAKhi5DR+NNPHca7SwhZ98mdf0OQidGaup0ZuE+9TuVuBER4o9+M9NgGo27qcJIkTkvzan6G /pmzM6qdZbUuefEcdrQJ9XHZu3k1tMjKop8Z4RaDDpE3AQBJOIo5dt4/QRqBnZpgu2ytJEITugw aJpTauCOfF58GINs0K6jqvgHkeeF+3M8zA0atN4oM9xKezoyi+wDr X-Received: by 2002:a05:6214:2aae:b0:70b:6e6d:20a with SMTP id 6a1803df08f44-70ba788e6a4mr73534746d6.0.1755357583328; Sat, 16 Aug 2025 08:19:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHX7AXYCBCRqrmrQsT1LQyM0jWdKsXIc3YtI6BivWlsRGdFHgTuLmmSZBXhNj3Yos1Vch68qQ== X-Received: by 2002:a05:6214:2aae:b0:70b:6e6d:20a with SMTP id 6a1803df08f44-70ba788e6a4mr73534476d6.0.1755357582786; Sat, 16 Aug 2025 08:19:42 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef35965fsm907579e87.37.2025.08.16.08.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Aug 2025 08:19:41 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 16 Aug 2025 18:19:36 +0300 Subject: [PATCH v2 2/8] drm/komeda: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250816-wb-drop-encoder-v2-2-f951de04f4f9@oss.qualcomm.com> References: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> In-Reply-To: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3013; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=FAStH94G7STx9dmih1BwY2moi+ekwJevO6V7oZLap5U=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBooKGIUlMQQLFiAtbFNdCE7iTeLG5NXVUIOYxXM 6vF5Guen5SJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKChiAAKCRCLPIo+Aiko 1fS5B/9UEdB+BuXCj2ytlEfQ6Knryb/dViwFtPKUeb5r+e7VL1yRxxxT2kglrR7LNYMiS8Ecly9 LHIp7j3MT33mN8RC2G81OBI4OYtosKhm7rokBbqmIN41yeqq2u1bJMK8qMo2JqOiK9qcSM9vZ8r SPIxl7ppjQ6vU1W5glfl4pxwjQeQvE8Be1Bo6s94TZCPzc7eqIe0BBd6re6aID8AvZkrbDyYVWv weP+MlXsuCXqWcP/RTxNkuwcueGDhFU/SuaVfTwJr1pI3asqMrn0GD83quiimxOrlD7Y/6SLA8b unH5GSZVhqtU7/2VAXZm3fwx4gf23rPpFp6ql62lXHM9YY54 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAzMyBTYWx0ZWRfX7DFmMfQbzxeB UoVcx0ZoKalaJ4OPNB6kfX2tObuhl68vrWVlG9twbSTo85pRMdXyVYj29Z8Fzc190+NR/ZqpRfl Yo8+u/j1x1MDwEJliPVPkM0MZPzZlbde/+iCJCkJmqNVh1i8MBCQFK6yV1rKHAKqBf8lhj9KX9g jWv71P/9SAZdo1xgWzeuRYNNIXvdW7ftRKgzPd58vK2TrA92DkHxV8ykJuse3GVvpUd5mEeS9rK 3UY5pEjwGF85DpBTzsjQOYvFzpIsuYPeMSDyTxMIzmBpFLP7/Mav7ZtOI84SDsFcf/qmSEY3VYZ 93IaDVn/xNiheXSeTrFcZ+RnhGhgtf88+WR4XxQvDa0XO5hEeoxdUU1v1iBSEUx6VXcbIAx/4qT Sumq9mKs X-Authority-Analysis: v=2.4 cv=c4mrQQ9l c=1 sm=1 tr=0 ts=68a0a190 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=EE5oNXVUeA2ILyHCr4wA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: zw5EO0ymZV5eKc5GNyEKeuY6OJVcY49m X-Proofpoint-ORIG-GUID: zw5EO0ymZV5eKc5GNyEKeuY6OJVcY49m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-16_04,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 impostorscore=0 bulkscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160033 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../drm/arm/display/komeda/komeda_wb_connector.c | 30 ++++++++++++------= ---- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/dri= vers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 875cdbff18c9dc97e736049feaa8a1fe1bcc82ff..bcc53d4015f1f27181e977272cd= cfa35e970fa62 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -5,6 +5,7 @@ * */ #include +#include #include "komeda_dev.h" #include "komeda_kms.h" =20 @@ -121,17 +122,10 @@ komeda_wb_connector_fill_modes(struct drm_connector *= connector, return 0; } =20 -static void komeda_wb_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); - kfree(to_kconn(to_wb_conn(connector))); -} - static const struct drm_connector_funcs komeda_wb_connector_funcs =3D { .reset =3D drm_atomic_helper_connector_reset, .detect =3D komeda_wb_connector_detect, .fill_modes =3D komeda_wb_connector_fill_modes, - .destroy =3D komeda_wb_connector_destroy, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -143,13 +137,15 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, struct komeda_wb_connector *kwb_conn; struct drm_writeback_connector *wb_conn; struct drm_display_info *info; + struct drm_encoder *encoder; + u32 *formats, n_formats =3D 0; int err; =20 if (!kcrtc->master->wb_layer) return 0; =20 - kwb_conn =3D kzalloc(sizeof(*kwb_conn), GFP_KERNEL); + kwb_conn =3D drmm_kzalloc(&kms->base, sizeof(*kwb_conn), GFP_KERNEL); if (!kwb_conn) return -ENOMEM; =20 @@ -165,11 +161,19 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, return -ENOMEM; } =20 - err =3D drm_writeback_connector_init(&kms->base, wb_conn, - &komeda_wb_connector_funcs, - &komeda_wb_encoder_helper_funcs, - formats, n_formats, - BIT(drm_crtc_index(&kcrtc->base))); + encoder =3D drmm_plain_encoder_alloc(&kms->base, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &komeda_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&kcrtc->base); + + err =3D drmm_writeback_connector_init(&kms->base, wb_conn, + &komeda_wb_connector_funcs, + encoder, + formats, n_formats); komeda_put_fourcc_list(formats); if (err) { kfree(kwb_conn); --=20 2.47.2 From nobody Sat Oct 4 12:45:44 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F9452FB978 for ; Sat, 16 Aug 2025 15:19:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357589; cv=none; b=Aeggvs0zw+WoYvQArFoFGPFVMYers4V+f+KA6tiQuoE1x7tyIifDN9N93ABf8n6MS6knvTu2RVcFCAc75vc3AWzhKBBzK04zHwR9RAKqMHWiG0NvR/OyLSHv3FzsJUh+cyrcv1iOOLH2B6oAhoVc+J6FhWG6PR92hYk/onFxGxw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357589; c=relaxed/simple; bh=bSu7BtDX/FJ/CYhdTG49eD8oSIyWKKcC6qKfEjkvl9M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OOrSYN5UTiFYiIKgdwS+AcX4pGmBaQNLYjwddK8zHFlaL/9lB4DNj5Gp0/kZvnFxfNexcvlfeYSDdwOQRdu6ND8XogDf3zHE0m/roLdelK179+RienzLUQKYQLIPdh4Xqs6TBcoC1tcEHmy9T7HABSaUFzWvwqZnQGlKvZt9hzM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SWH33GE8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SWH33GE8" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57G4ervX008852 for ; Sat, 16 Aug 2025 15:19:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TRcyMGCl+30uALX35qrVjgv24YuvpY2moJlPtRkxYu0=; b=SWH33GE86FDLtZn0 dlY2V3vW68TyhRFxU3mWsuoXo5/BnJWF5A8g7rb31wtBSSgn8cg6KL5ZogKpnyGv DoJoL2hzrBQh6fo0p1Q5hgYRdirAyUYrplnXJAuK/M9H5XIPDUQYxtwkxnTsBXzT cFB0IekECrC/H88ibrAS3CdJ0LMrRmUzj4JZtvfv3TpSac8n0sZuVDbd6OIpiIWB QmR08bWLoxlk+HnulcTh069TEcAe/OEfEhE/R8cVTdy5Khth0UKjizF4FomlhhTE 0dcTTKMonlm4gmzh1voCqRRnQ2I9d7w75l8kM3jV61DmsysULKlLYGmIi7fiSZie uVL/tg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jjc7rsyd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 16 Aug 2025 15:19:46 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-70a88dae248so58946996d6.0 for ; Sat, 16 Aug 2025 08:19:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755357586; x=1755962386; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TRcyMGCl+30uALX35qrVjgv24YuvpY2moJlPtRkxYu0=; b=Rals9zR1WpOP/iNoArr9AnQ37n3B3I92aYusX7X2dMjHR+ewf9+p3MjsDshWUNKwAd 5Y5wj5ZWuyWCiawOER8SQJT7mEdm0s817MNhSAGUypekJ/Nxo/B9lVIUcJQYn/GA0oT6 2h2XCnt5lLghA/RGWVIz28aQ8R9rW+xc75uci4TzJaOt+j0UmwJWiseowNjCcmJPj4bd 0bgvU3PDzBk7BjWZs7zyVpbGbXARpfKGGRVFfNk+H54+JBRA0l9tk2wg/G+SBjKxBVBo gq4OXZIU1/jEpo5CsjctLeutoiGI6YXyqHeHicow822ZLVzJWjRvghba97drFfe0gJnJ 3Luw== X-Forwarded-Encrypted: i=1; AJvYcCVbehaw1ozW1F0HuxKMCORWpuW7Ps6JZ2XinnwILdztL+NpFBgOVhb+F1SOsZz9kZNTRzRVCQFwcHDNGr0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzv3fbI8plMBl80Khe5SSVfXm8tQ1W+tt9mE4iJCIfTq62FGsNv 4uoik/XAMaZ3Q3hYMLYAKw8TwEaWHWKjkXvu5+vkX7eWz+krecuNsqMJw+7VUGzQ0J8bALor3sO jPg3LLYD1zDCDp/gvrDG7D1zV8GWrnmI2ropnmX0yw/jhkOeE8udn4Xy6zrhg48hijj8= X-Gm-Gg: ASbGnctoOBdXD4p8apdDJNyi8cCP2+zH/ROi9OIw2J7NfvL0KwZnHwe5MHYsfReUU8J OL89WLJnfIYXZghtvKYyMiXOYIvo/Jk020IkdH/vkgsAReIZR+/k9nlAEvu0Kge4T2eUmzEsyr7 3+Ht1GF3EcJ+NBNhvgBQPlPoqa+bkOziCIblLHDFbTf6gJadU9Cc5pO2pZhNsPGFEiF9cdHPGcq 4fz3FZyIHj0AqmU5fEzuog+VG8BQshGUM3Qggo1f6wRW/3bIQWj/aNwnPVg7IsOzcRw8tjKul1O YZATMUZD9rd/KqlRDK9Lf/zp5HyyFiaJSBLWBHiCLRC4TPnwYv6U7WNHSQVg/48Jqu35pX/wWqH yaRt/z2YwcuhzuuV606OdHKo+UGVSz/Xrr7eiKPflh7Jo5qy+ONlB X-Received: by 2002:ad4:5c4d:0:b0:707:89e:20a0 with SMTP id 6a1803df08f44-70b97e5f8b6mr121342666d6.22.1755357585901; Sat, 16 Aug 2025 08:19:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFYKtw8girfWWYEqO/Ggcji51+kihQkK91jR/jljS3mVOG35hIp3DD0cbbL9nG5EcyplDI8JA== X-Received: by 2002:ad4:5c4d:0:b0:707:89e:20a0 with SMTP id 6a1803df08f44-70b97e5f8b6mr121342146d6.22.1755357585415; Sat, 16 Aug 2025 08:19:45 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef35965fsm907579e87.37.2025.08.16.08.19.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Aug 2025 08:19:44 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 16 Aug 2025 18:19:37 +0300 Subject: [PATCH v2 3/8] drm/mali: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250816-wb-drop-encoder-v2-3-f951de04f4f9@oss.qualcomm.com> References: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> In-Reply-To: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2621; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=bSu7BtDX/FJ/CYhdTG49eD8oSIyWKKcC6qKfEjkvl9M=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBooKGIYX6MbbfX0q4CqCoZNIiZx1UDb6oAqdBYr e0GtlGtu66JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKChiAAKCRCLPIo+Aiko 1XFKB/0X/ib5lIagcGHFFApfOPY+gYbqF8flWf58m5QwtwRW5JbZgubNJhn8ewnog9DlDUs1iQ2 8AZd4JZE8uJ39gfaok+MTfL+tqc65sbijJoCKgvz9+dlMkRxi1rkg6W8XBAj/Ql5xi4QJdIrHuc 6v09zB7eIG7Lmmyxvy7H+l2SX3npPoNX/1kWEBUcDdZMEz+kNRYaS2C67tip/1O53yvNISFiR9v DZc/rM1UzRP81nWh7ilpYyfA7hjUAMeNnYJR+EKl0Ma4t7O6c/ABqTgZmtecludu7wNZwZhCZBX S77fnkUHzj74L0sc6kM/VDZNgmgTj+Q8ATzzUHygv8oFDR+G X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAzMyBTYWx0ZWRfX+/ouzuA/aoDx LZCTxjv/qf1nbkS0P4/cOImYBNFhaLUQ/CV/J1oJa11nNdqpHuzIH9btTRyptPb9X+ScDqvN7PI WkJkrhIxaMQ7WYBV+hy/+aGB9f4CaRnvT5La9RHp/0FUlbavLvCM27EtmtUGJq3SqN/rbYXF6tE MRYFp1FtQ49Ae5l3sD/dnQGhCmzucYGlOqHHtaNIKwNdY0oewIgpJ0H9/McHc8PWGyf+jbVZREz P24WC6LM7XwpoFclmC/MGqP1nAUeGEA03JSv9xZa3WBJC0SCmcMczq3VBCJWSuSPmWoi33h3PNR agMjrwedR7La5uH/329qT7MS+rW64FIZl66nPKrqto2fyY2FbdCsDNP94Dbq39/Q7A821SRQpTl ROqna/pt X-Authority-Analysis: v=2.4 cv=c4mrQQ9l c=1 sm=1 tr=0 ts=68a0a192 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=mhD89yN676IZukTL2GQA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: LURA6ocvKhCcq-S-x_L4lL5DLc5IbXS9 X-Proofpoint-ORIG-GUID: LURA6ocvKhCcq-S-x_L4lL5DLc5IbXS9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-16_04,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 impostorscore=0 bulkscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160033 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/arm/malidp_mw.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_m= w.c index 600af5ad81b15d0c30f9f79588f40cca07437ed8..80f7f3474c4494554c6b6fb392e= 7f396b3b49c83 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -84,11 +84,6 @@ malidp_mw_connector_detect(struct drm_connector *connect= or, bool force) return connector_status_connected; } =20 -static void malidp_mw_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); -} - static struct drm_connector_state * malidp_mw_connector_duplicate_state(struct drm_connector *connector) { @@ -114,7 +109,6 @@ static const struct drm_connector_funcs malidp_mw_conne= ctor_funcs =3D { .reset =3D malidp_mw_connector_reset, .detect =3D malidp_mw_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D malidp_mw_connector_destroy, .atomic_duplicate_state =3D malidp_mw_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -211,6 +205,7 @@ static u32 *get_writeback_formats(struct malidp_drm *ma= lidp, int *n_formats) int malidp_mw_connector_init(struct drm_device *drm) { struct malidp_drm *malidp =3D drm_to_malidp(drm); + struct drm_encoder *encoder; u32 *formats; int ret, n_formats; =20 @@ -224,11 +219,19 @@ int malidp_mw_connector_init(struct drm_device *drm) if (!formats) return -ENOMEM; =20 - ret =3D drm_writeback_connector_init(drm, &malidp->mw_connector, - &malidp_mw_connector_funcs, - &malidp_mw_encoder_helper_funcs, - formats, n_formats, - 1 << drm_crtc_index(&malidp->crtc)); + encoder =3D drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_VIRTUAL, + NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &malidp_mw_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&malidp->crtc); + + ret =3D drmm_writeback_connector_init(drm, &malidp->mw_connector, + &malidp_mw_connector_funcs, + encoder, + formats, n_formats); kfree(formats); if (ret) return ret; --=20 2.47.2 From nobody Sat Oct 4 12:45:44 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B11492FC899 for ; Sat, 16 Aug 2025 15:19:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357591; cv=none; b=Rwoqd06FVyibxbNBSFJbDvyJl4qoKznwv5IdG0YwBlsw5YvfzP1E3Vs6G+2iJJwuIjzdbaSqMKWKWXZDZXL3PvMw3P+dmz1kjQuWsaiuHOuBjvRwYgRiAmZxSVc1qKoz+A43Yo74zV47djSvVYA3xet4VcSOqL5zUWYgw8mG5CI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357591; c=relaxed/simple; bh=SsfbY2BgCwVOdMoS0AB7dKBbl1htE78XemRzUg21Jp4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CrNCndP7eTQIo9GBfhrXDPvrBcKhEegaOJCLhyrVMBBUmPfrEvLRvExTRBropqDWyCOIyADLxa9Ts/dApdJ/EHgPQcg1eWkHh3vdYcmJNiW689+ffU0V89TdAUYokhFEweWqKJvFmJJS9fOMinfPV+L80p70RBB8wjive5W2YWM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rq2p6ZCR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rq2p6ZCR" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57GAcgLt004563 for ; Sat, 16 Aug 2025 15:19:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mEvIV2bV6AlxqzM7m9xsvqcJBh2delxnqohnrAUROZo=; b=Rq2p6ZCRr0spzxZ0 77c/jJP+Aq5MegOt6dmVaWnsD1K1fiMgfkNxzfMZCTefVuTHV/4/fIak+3av+jUQ CZUQ1TyIeYAAiwf86MZ90zppw4ikLmmdYy7UzEyD5U22cD/5qGbrXv6nFTPhJsxj KZc5Bv3I//PggYVGIZGVv2+YNg5v1xBzv4lr8oyMxPE3j5e1jrSjZLQjX7eMnK7m E+/fWwk4FzT0XWqbU+lbOVqR3XwXUTutn2mNVAAs5C/27u6xCSzKcOwasrm8HGVA bflEF9yCI/ttaC2nIovn/RF+XYvx8CkO29dE3lQIOVK1f+ghxzc3dkaML72LyHTg cCAHtQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jfbn92ba-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 16 Aug 2025 15:19:48 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-70a88dae248so58947306d6.0 for ; Sat, 16 Aug 2025 08:19:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755357588; x=1755962388; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mEvIV2bV6AlxqzM7m9xsvqcJBh2delxnqohnrAUROZo=; b=ZXt09FhPlanVx5kun68ntcBVr/K656F7qYnNc+Uj7WxyrSaD9vVmQuNbgrPnqQca8E 87wPKmKI9lOxtsEwPkAXlpfznbIfXW0vPm1cBkPBG89+OvlK4W37UrtdIET8TYk2uLSp doAFsqX+IhJZx38dXj4s3TetTBPMVS9jl5D7z4Zs+iGhSyHu0MIEW2btsgNUes/0/zkW Mo4e8GRAXtKzIZPNFSxjgid2WpvtgtneIOIj5ihQBUr+oiDhPxzY2r9zaeO9fDkvAaDi FYmcLP+qbYdZ9ZdSjfEk/CwshoNP3AkyPQxgY0A6994QNRy3JKbdmMNKylr6usEtm7jQ gbsw== X-Forwarded-Encrypted: i=1; AJvYcCV6jlPV95JgBorVQQYj31toowoDmN7eWyM5ME/9zmcRppVlh5uP2RLJ0cRkCLSoc1Bn21XxoUr6yGWzo2c=@vger.kernel.org X-Gm-Message-State: AOJu0YxC0vh9AFt8rcSsIXfc8Z8s2M5lp5EBAqvOnUDVJPXzywRkpvxI AfChZTaLcFfJILWYbHulWbl4uTPwWDlJshXODYnBd7PZvkSXeuFvyLANNK1LRTeungdX26c8BBA JSEkArBA/xY8Yd+XqH2pCKFW3XotMuZRMFaIydSpb1YOK1gi6GPFEfKteUDUitDvaUUs= X-Gm-Gg: ASbGncsC712vxvvr30TLcxU/x57ErY2yJOGvwxGDAZAkBfVoOZ3HfaDd5vwq+qYBXcg vumUknEQ9ehHcF4s6WyRcw5JcARPj8RXZbDpqIRkYgA5yQGa13XoEZ1mXjv5O7bmhrt+dHJT7N5 GhgjcXn/nx3zsvlpVXQqcOFwmUh+GVOreOTmQZEDZrgGJWc6UC1dZJq4uTn3cP7o2wpW/oFSowf 6pnR4wmox/GjxN9t9xYxt5OiDTb1S7Liq2DrsXi1YZy+nCyB9WwgrEZ05KxFsXY3a2ys9gIBlHo LwgBLa2cIGgpiy8dR27JI8MmQsJ4jr9feKUzFy/XOPGDWSRgzYMm6HmkCuPVGWfGLUhSsF5QZZz hjeRI2wen3zjPzHbLejbWOx5cYPsoQ9WYHbmo9zqxKMCzDpiy1Qgw X-Received: by 2002:a05:6214:76c:b0:6fa:a5c9:2ee7 with SMTP id 6a1803df08f44-70b97d50e1cmr134782606d6.8.1755357587638; Sat, 16 Aug 2025 08:19:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGElAmZI2U8Jde4TU+ICdrflTejDEsiodGV0TbuZxZ/JkbA4U1g8hagzZyjmkD4GE9Spc44Eg== X-Received: by 2002:a05:6214:76c:b0:6fa:a5c9:2ee7 with SMTP id 6a1803df08f44-70b97d50e1cmr134782076d6.8.1755357587134; Sat, 16 Aug 2025 08:19:47 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef35965fsm907579e87.37.2025.08.16.08.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Aug 2025 08:19:45 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 16 Aug 2025 18:19:38 +0300 Subject: [PATCH v2 4/8] drm/msm/dpu: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250816-wb-drop-encoder-v2-4-f951de04f4f9@oss.qualcomm.com> References: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> In-Reply-To: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1817; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=SsfbY2BgCwVOdMoS0AB7dKBbl1htE78XemRzUg21Jp4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBooKGJdDsbpspC67fG8mISRpjdFMuBL5GkSkS6i 1YB1BXzE2iJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKChiQAKCRCLPIo+Aiko 1R+zB/9gVJgtlwuaXv286oPUL9YSSVxu5wvJRyS4WQ5lemWaU/gD7xFDGPshn+e2TlAUr79nPTK 96TU41SHn4rJvfF1yjT5zrSVt39knNzks20P0e1N2/kooOaxT1XXy2MtbLZ4ttPfwnQYVHz49ZI vrXB8KznoEhnSXUNJSGt91MSRuu8BsA3Ju2EPpnZ9OcPApZHYZgeSbTJLLX722M6HN82yun00Mi h5EbNOZ7z599t939ktW4ogS9gFbXrfpH1OSTFHXNmrGEFgNJtlzv7sSSC27KYq1rMFBU3DSLW/z RtCbCCGPzLhyP8pkwOvuLLihiQ+pB9/+eq8ylzIiVxNO/dOE X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAwMSBTYWx0ZWRfXwHa+hrvcgMLt T3I9stHrtfOBnDxiaYr+7yEdhwb5oaOg4iJ3q3aW4HA4Mul0Y6aCxOSwwjkzN1cyfVGpenU1YD0 H54yH8AErgaQs+5iGA63ogmEuhuPKMF8SFTi+j0VBBp238olSlNKMfbI6HbbH87Mjg8GZaAk0b9 u1u5iyPy6wCW3KLpxeXsH9/xhqrpLyg+zNpjO8uO/rXwGhOgXl3hhvlE8byh1FMabdonZSGrw0+ br02/sYH/U9laIvvcmtxc7KC90xo/iPMKfr8bFFMY6QG7o9K/jT0BMcx//p3+vDx0bR/Lcljca/ iyGOw/AAozYTNl6lk2J3klvZylLJHHqsG7hh1msVOAcX40Z8JNheLWxAtLQHFwsmGhxX/JhoFlA K0tweQE2 X-Authority-Analysis: v=2.4 cv=A+1sP7WG c=1 sm=1 tr=0 ts=68a0a194 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=UqIHtJT1QCIVCAY24KsA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-GUID: xy4Q6t-ZeJiVb9MlkZm-U3oms16Q2q5n X-Proofpoint-ORIG-GUID: xy4Q6t-ZeJiVb9MlkZm-U3oms16Q2q5n X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-16_04,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160001 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/dr= m/msm/disp/dpu1/dpu_writeback.c index 8ff496082902b1ee713e806140f39b4730ed256a..cd73468e369a93c50303db2a7d4= 499bcb17be5d1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -80,7 +80,6 @@ static int dpu_wb_conn_atomic_check(struct drm_connector = *connector, static const struct drm_connector_funcs dpu_wb_conn_funcs =3D { .reset =3D drm_atomic_helper_connector_reset, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -131,12 +130,9 @@ int dpu_writeback_init(struct drm_device *dev, struct = drm_encoder *enc, =20 drm_connector_helper_add(&dpu_wb_conn->base.base, &dpu_wb_conn_helper_fun= cs); =20 - /* DPU initializes the encoder and sets it up completely for writeback - * cases and hence should use the new API drm_writeback_connector_init_wi= th_encoder - * to initialize the writeback connector - */ - rc =3D drm_writeback_connector_init_with_encoder(dev, &dpu_wb_conn->base,= enc, - &dpu_wb_conn_funcs, format_list, num_formats); + rc =3D drmm_writeback_connector_init(dev, &dpu_wb_conn->base, + &dpu_wb_conn_funcs, enc, + format_list, num_formats); =20 if (!rc) dpu_wb_conn->wb_enc =3D enc; --=20 2.47.2 From nobody Sat Oct 4 12:45:44 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E96F2FD1AD for ; Sat, 16 Aug 2025 15:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357592; cv=none; b=CvYNjCln5qAwVqvDkmZGwI8obTC3H5OFXVyLlk6sOo5+/mC7EicLtl1y35gTWnR4ZJS5ufxmqE+i4nZdU1TPnCBCOoJJBo3vzRBVejYLSvUKXvJx8NKSA8x3hpGd+t1k+lCTkv7rH41BRTZbxvOG2ZnhlO9felBJloKnr1qxSvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357592; c=relaxed/simple; bh=/fLUas0t6+pmOh4Lpow6ATkHgTqazIs0UqCL1npG8PE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NsLTDzdQRhafigjiC/zc1PB2QkVOqxZMmCKx1rRLtARF6iV7uAVx6o3RNoTkiy4QLKe2gEoM+LZFdfJMtVEn1UlGxrXil0I5m64mWmLom8I0WEsKXE8ykrqQtKex6ip6zk22IiCvzRocouoEfQWgoxXpQNbtANX+mUrj3r2s5Q4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X5Gt1UWk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X5Gt1UWk" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57GDbUWA029565 for ; Sat, 16 Aug 2025 15:19:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qV+1O4itHxYPrihyEQKWirrQ3uqLooPtU+1YJ1+NTiI=; b=X5Gt1UWkBtIMJCFm C8L7MumhPmhoSG0JDTascQfKTI9hjhrhWUT6gbrN7YuPvnXR3pQr58i47YtlolQN M9404pODYFr7CzBpOICBjFPwepXwNswGlCBnmColodWNtAyZq4hzs+pl3ogNfW1B Io/VFH5qHPn8Udg6EQBqcsDBuFvhSkQ7tDwwZO4Rkx3N10j592iQjdPdOJdo4mJi JbwZTzPi0guL22dBHpQqI9VBC5u/2JMpBrd9evWVZ4EkZats8p970cEjfmK6BnTz zHr5v/oy9oNz1LO9J1K5KBBzMAnmEk8OU00Cj/P8XIbEGtcxNzGBH8cx2XShyKbj O1rWgw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jfbn92bh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 16 Aug 2025 15:19:50 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4b109c5457cso78918271cf.3 for ; Sat, 16 Aug 2025 08:19:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755357589; x=1755962389; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qV+1O4itHxYPrihyEQKWirrQ3uqLooPtU+1YJ1+NTiI=; b=tkewUaF7CfQ8AQPKs9skoC1SJFUnk4Tz1mSCEPapLjIYNi1bNjWsJL2YcuRBUeBGBJ hTmnxrEzgpShh1MVMfm6uctfUjvexOwkEm/aRdvldbNt299mOIVPA+AMH5mkKD9H7nat EZUPLtkc1tqi7CleVmm314WiNNnHcarVvxmxP9kht2ZQD1NEvr/AKLaHJJ8DYoOu25rg LzuVP6HGTvTfpkwnze1QI6KAhSYQ53rwmoh83QSsmGNmkc44kBuu7f+SaJkDEDLlxlK+ aYSZ80FXZrSWkBz/Z+e2iCwM22bcNhiCRp9yvcK7S39Mj3pyPW0btMoH8G/w1JwJWtO0 K6CQ== X-Forwarded-Encrypted: i=1; AJvYcCV0MFelz7Dv2KwJnCoco0jBQ/ZmsX5KpI4Cvu1vfuQGsCZIIU6GhS8Mcb895/ex8cUp6cdcOKZI4in9igU=@vger.kernel.org X-Gm-Message-State: AOJu0YxJr5G+8ViIEScO0Z5jQeUgNhrPjj65d4ANOhz3yUVqrosKi/kT qaZgpFyi008MQ22bABAewVEquyaEGdzPOCmcW82LxVYx61ntzfgV6Vi/GpN8Qh5VkAkOdzFR8an fGbFErNniMjkyzFtMAA+2wCG+YdCVSLOoodFLGXPQcafnbhlPgt+HBgWMCEvTGDasvV0= X-Gm-Gg: ASbGnct+pFgLERLo5Hp/IOPvy7PfzGA2I/PcMomtMq//cMjdI0P/UJyq429H3PjAC/2 C6QMjD08TMY85relGgxqqkKy3XXqII9txB/w28goJM5nd373TUJ0wj3v2t0Y1HrYaObvJyqXWci x0u1yb82FRtAiWuJi+COpv1CyAAOprvQuEyuueyaVzTHNUPKB+iPvfSsHJMGrWSRvq/lQXFPDod dHUhT9rhGz4ElGetZnSmTQVL2b3NUjboUIzdtOrHY7sUHQbjGgmexDmCX8YzBwh5pv4zurw23RV P6wTTJAB0LIG1p6FTOfFsqQK0gzViz87mCbHAn+w02aemMWyXpdgnvuzB0Kgo2mNXzarg8y156O rzVzfVHjggMpC/J4Nx+7KhGUxfszIc1msZrB+uIIlpKUn3wUZf02V X-Received: by 2002:a05:622a:1803:b0:4b0:69ff:eb71 with SMTP id d75a77b69052e-4b11e05f86cmr89079281cf.1.1755357589305; Sat, 16 Aug 2025 08:19:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4j2k4YAYzpQ0pMCPbpzOT1o6CdrG9QkvoXk17IoZ7zfFypPLXZJtxqIY6aSy3p+i62FJnEA== X-Received: by 2002:a05:622a:1803:b0:4b0:69ff:eb71 with SMTP id d75a77b69052e-4b11e05f86cmr89078721cf.1.1755357588831; Sat, 16 Aug 2025 08:19:48 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef35965fsm907579e87.37.2025.08.16.08.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Aug 2025 08:19:47 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 16 Aug 2025 18:19:39 +0300 Subject: [PATCH v2 5/8] drm/msm/dpu: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250816-wb-drop-encoder-v2-5-f951de04f4f9@oss.qualcomm.com> References: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> In-Reply-To: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2304; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=/fLUas0t6+pmOh4Lpow6ATkHgTqazIs0UqCL1npG8PE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBooKGJrX/EOza+6SHDDyhh3b0F4k58JM15op7JC zsrf9qs2FKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKChiQAKCRCLPIo+Aiko 1RPCB/9KsE7LBH2gz3/CuiP3n3VWw21nUSaR2KEoT3QNbRnJ3kkvF8BVfxyPCfMPXyL8GP8+X+W 1eo7ACU/9lwfSLQKW1Gnv3ZPNYawwta+UR+hdHck6Lfeu+kPxKKOyqfVp+p+zVXa0SQ93cL/NEf JS8K/7gj1Mb0FMolDe1qPEfHsG8P8LPEiTcY1SzvEDp94WNhqZe/hngjRryF042P4d0Bj7worm4 akTK/ST6rN9abWTt+MI51ZZc9SW1GkAGBQM6+yP9YItM403Q2JqK6zELkFGY5AXyQ8ICXLx+5Rb 2lSOj6fPeztw3nIfRul5Iclrps8maUSX1XJImBsAqhNG89N4 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAwMSBTYWx0ZWRfX/LfpN/3hX26N aKMulf8oNLy9d6O9gbEB23Elj0r7SidKmnKuopdH/SyAkNqX0PLcRJZ+ewWWeVq6HLc8Hblsa1S StCZ0UvzLGVm+h+y2rSH8qXEZldD3b4wjPf49Biioc4E14T4mByMtfFnP1ft3PJX280lnmUXbXS g23UA5oYyPySlNW5LecRNUUUqURU/ymH7OcqlecubHWevyA/XU2LLUTZU1AMITTU6lQkdh5cvhV seK44QU1MqETNEeOk3G1inRAWlyk6Yf7QsEeXMIAk0//ru3siaxJhZ/74goNfrlJ5JOrVat4pj6 te9DjOOZOgLpd/Rfh3ujp77evk1nQQxNnK6TIIeKrT+tRV+2pJypxKjOSliSOwBnpa7M8ZmTaU2 7I8TVxJ5 X-Authority-Analysis: v=2.4 cv=A+1sP7WG c=1 sm=1 tr=0 ts=68a0a196 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=mhD89yN676IZukTL2GQA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: WTGQYWdbGNEQRgP3bOGq5d2dE0imSEw4 X-Proofpoint-ORIG-GUID: WTGQYWdbGNEQRgP3bOGq5d2dE0imSEw4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-16_04,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160001 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 23 +++++++++++++++---= ---- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/= gpu/drm/renesas/rcar-du/rcar_du_writeback.c index 8cd37d7b8ae281cbc1fd8cbb243c621174517e23..64cea20d00b38861e22fc53375a= b41ae988ceb59 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c @@ -134,7 +134,6 @@ static void rcar_du_wb_conn_reset(struct drm_connector = *connector) static const struct drm_connector_funcs rcar_du_wb_conn_funcs =3D { .reset =3D rcar_du_wb_conn_reset, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .atomic_duplicate_state =3D rcar_du_wb_conn_duplicate_state, .atomic_destroy_state =3D rcar_du_wb_conn_destroy_state, }; @@ -202,15 +201,25 @@ int rcar_du_writeback_init(struct rcar_du_device *rcd= u, { struct drm_writeback_connector *wb_conn =3D &rcrtc->writeback; =20 + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&rcdu->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &rcar_du_wb_enc_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&rcrtc->crtc); + drm_connector_helper_add(&wb_conn->base, &rcar_du_wb_conn_helper_funcs); =20 - return drm_writeback_connector_init(&rcdu->ddev, wb_conn, - &rcar_du_wb_conn_funcs, - &rcar_du_wb_enc_helper_funcs, - writeback_formats, - ARRAY_SIZE(writeback_formats), - 1 << drm_crtc_index(&rcrtc->crtc)); + return drmm_writeback_connector_init(&rcdu->ddev, wb_conn, + &rcar_du_wb_conn_funcs, + encoder, + writeback_formats, + ARRAY_SIZE(writeback_formats)); } =20 void rcar_du_writeback_setup(struct rcar_du_crtc *rcrtc, --=20 2.47.2 From nobody Sat Oct 4 12:45:44 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BCCC2FE05A for ; Sat, 16 Aug 2025 15:19:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357594; cv=none; b=Hl9oWYAE7G7Htpd9+4jKZVjdDyV0cH4QOWFrnZQOMTnNg3DE2OiaHtCmWwEYnwhvdygi9H7QD/xLH/SyXwPmQ0Wv9YlIdnEkqTceTf7GhDLCBTskGuEJfTgJE2Xnfi0r38DjWVvZVpcx3AqqdOHY0uYH1H2Tti1Ln4+bj+s0mbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357594; c=relaxed/simple; bh=9kPXh1enzh44Jx+JV9Ql6fG94nEVIAR8Tv81e1DfnG4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CzBXM0DSufzP50OPQEQe5FYugtRgGuPOOcevfGTGLBdlUdDLx5Rm5zxJOYUHBghZS0XGGQKUdvbZU8tRjTp/1cJ8D6yABD143Kws68ldWhtpFER2D3JeBx3flSU+rkdcRR/KDyEwA5dBSLjZjJa9k3uDIsTtyRz/O7EcqihR244= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AqY31cXi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AqY31cXi" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57G3jsSd031419 for ; Sat, 16 Aug 2025 15:19:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ndEz2xbpBNb9n5L2RWMR2nJPekvJ4u9Qsxz7tSzeQZk=; b=AqY31cXiT6LNE/Wa gfDPIHid5llWAV+6h/L8oaVxSgGk7ykXtRHfxq9ITeYFd7x+h+dOgXww8mpMSWEB EOMxUY6YlNQZqiPz3Mb63xp0Y91aavwQCqk6BPtt4/xXxE+IcYxMQX//pXGgAsKx jqRl+Fa+nG3TjKdzeo1RGfYrwc8O2bMaqK57GtZARGvuVa33M8GoCdAb4w9qk9d4 po9G9mEOb/Al0+GzrZgcnDO/BZwhGoeZ+XTD0TUoNCGSTMjJ7dKgZa1qY116e6iC zC7aacZZHGrzVPCxcFRNtNcv+0TQyBelKxl0Z72d7IMZV26/X7h5NIYGzSsNSZC1 AsHgrA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jjc7rt03-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 16 Aug 2025 15:19:52 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4b109ae72caso73394651cf.1 for ; Sat, 16 Aug 2025 08:19:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755357591; x=1755962391; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ndEz2xbpBNb9n5L2RWMR2nJPekvJ4u9Qsxz7tSzeQZk=; b=K1bqMjeDJjYz2LWHgZVq65q8z3RPBmWsDqyRkurqVptcmQqFalLFGY6IsiKyOtxbx0 JOkO2eFOsjUbPQegTwOaYYsVWzlO5CMh+Ica05k2DaFV5k+0q6VzP2413yuoZY5qEI0/ XOv9Mth7zA6GkixeWYab4t7Hp6HSavlzJ1OJrQKgGhQRZFt4/EnUH9AVLbExcgRSj0vA E8kXb3zM28jEWSoZLhpb95pvjy7HibEDHw3WC5HVOiRQzPB/YQ6Xiy+HUAR30ndnXjlB sOEOUWGA59Zis3fF5AA7aodRMHrBlP4BIBPj0bLdnMK88tymvWZgKwbank+IPMG8hHIp y8NQ== X-Forwarded-Encrypted: i=1; AJvYcCWVwv4U9/5tPw/wnugGHfRBJk7CEo/+6tuEfylJtMR2V691vaXA/gi9VCYty28kMe1bGgIgv3eSZy983QM=@vger.kernel.org X-Gm-Message-State: AOJu0YwTZXxSBeM2NB4DjDbY5euwY0rtp94e5eKVHZgSNIka5lcWAVqs fYQuU5jPDF1+c1VaiWyOB14JCo3yT7wHb8QZjVkVt/TdMzVdc4KJ/DPlw9eTMDGcWYddl2ws626 hgDTDO5ferNsaWq2oVU6CxqPn5BCq9e0TxrFVCmAaNt1xj9SHDgnNIV6SN7Fg2QE/DUA= X-Gm-Gg: ASbGncvmO++zogIJYVuHTbJNXg9//gLuC5hiksaOSjErDVnoy8qJdf1jftKbSexweTI aBf5c20zhf2V9nVrZU0yXVOIl2t+GUhoExBNsGlP+uinmuecrFburCgDDgnTlkHKL868rk207r7 kzlLugPwImn8zFmDan9gWuy0LxCzN6971Fm9OzXzLi3VxY8E5Fu95wXZEdiNogppppNcFcV0Cjz 4ZUfqdORxkHCbVoIJ4dTNr+czNJehPCfHonMj8aR8H62ZkUNUdjQSEI2+SEO8lRTGWOOeb7WHv8 5hPiebh0nXiPO6JX9Jm9iq9dpkrXC9wc21LfmKS72nh4nurJIelnMCTnhNYuAzMZYnoACpnkJL6 /ZYcRt/cWkt4HxtwZjQ/Jl1vzeuFdNJc+EVhOtRMjOs8ZJkqonKj1 X-Received: by 2002:ac8:57cb:0:b0:4b0:69d6:85a2 with SMTP id d75a77b69052e-4b12a72d48bmr37236211cf.31.1755357591160; Sat, 16 Aug 2025 08:19:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKh/+i8IQ8KfC/PGtL5WbCPyvf0DWbyUBL4UoteG6uU57Gcw4lUvCyN3nBm4+guZJlXMKsYA== X-Received: by 2002:ac8:57cb:0:b0:4b0:69d6:85a2 with SMTP id d75a77b69052e-4b12a72d48bmr37235531cf.31.1755357590637; Sat, 16 Aug 2025 08:19:50 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef35965fsm907579e87.37.2025.08.16.08.19.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Aug 2025 08:19:49 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 16 Aug 2025 18:19:40 +0300 Subject: [PATCH v2 6/8] drm/vc4: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250816-wb-drop-encoder-v2-6-f951de04f4f9@oss.qualcomm.com> References: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> In-Reply-To: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1739; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=9kPXh1enzh44Jx+JV9Ql6fG94nEVIAR8Tv81e1DfnG4=; b=kA0DAAoBizyKPgIpKNUByyZiAGigoYmi7Z2qV4qHuc0EhD2k/N7ZfvDfuxN8wZARRRVrlbSLw YkBMwQAAQoAHRYhBExwhJVcsmNW8LiVf4s8ij4CKSjVBQJooKGJAAoJEIs8ij4CKSjVHcQH/3sm ploBZcGyn9igFEwOb7KK+duurcQL+8IUikUxpNTsSBzPUpiPsu1e2gHAun/BzV28c7qAbGwav92 TaclcXxDkLxqc9FMEZJ1M3OC0myfyvBNMomGmZNtKq8+WdLN/tEfh2JO0Vl3yUV8wOs6aPtLZ/H l0C2G+hwInuwe4NU0htEWKNERFlXfSTW6Z8j/+rMDxp5WjrESKCLI+Pd4iHWfg/rVESJNzH52G1 NmBfh+DTMCXVvLwtvWMwgN2QdOVl9O0pFeflRZX/gd04fcYREOyi3UzGvHdVXPgAoYpkiHw5mqi LABSKrPzJMFKH49LcYJDRuJcbaGH+5TXRmkLwzI= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAzMyBTYWx0ZWRfX8cp/fwuBFmaF ULb4dK/H/Sg6GVPfy9FZjzsaG2vWNHHWHcMG9R5FvwnSKNY4K63ncLsJE2w2upxgJC0MhdVgMgm tQxyTLe4r46Wn6u+8v2MpUTcC6ofbOQKrxoV5pPU9rZBrUpG9PVNgvlEWuLit04fEue6FZONcMF NoSoKVnapEgeA9Vd9iE9W+BvXp3xbzzcrQ+Ed/ckAVtHFvaW8R05G2vp5NE9dTVW5ctldyBQoe7 SauzYLD5+Ix/Vhw2dox0Z3bXH0NjBTU9oHelMixvLJs1qfsWDs3BgjSquLavUi6VEMfe1iM5nZX useA5qORU/AkCd07ALaHvUd5b48fL30gupDSjKRGdHQqDMGEcYTYd/2jr+O/9VHgQ7/gQyggZc3 Qa/UJTK1 X-Authority-Analysis: v=2.4 cv=c4mrQQ9l c=1 sm=1 tr=0 ts=68a0a198 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=hRdDZflY9wZGYtDLNskA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: wORs9wFUwYJPWMjBKgudjWhINzVqsQzX X-Proofpoint-ORIG-GUID: wORs9wFUwYJPWMjBKgudjWhINzVqsQzX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-16_04,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 impostorscore=0 bulkscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160033 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/vc4_txp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index 42acac05fe47861ced226a4f64661f545e21ddb5..fef4e4ee47cf41d40de47c5201f= 0349dc36c56bd 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -377,7 +377,6 @@ vc4_txp_connector_detect(struct drm_connector *connecto= r, bool force) static const struct drm_connector_funcs vc4_txp_connector_funcs =3D { .detect =3D vc4_txp_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D drm_atomic_helper_connector_reset, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -601,10 +600,10 @@ static int vc4_txp_bind(struct device *dev, struct de= vice *master, void *data) =20 drm_connector_helper_add(&txp->connector.base, &vc4_txp_connector_helper_funcs); - ret =3D drm_writeback_connector_init_with_encoder(drm, &txp->connector, - encoder, - &vc4_txp_connector_funcs, - drm_fmts, ARRAY_SIZE(drm_fmts)); + ret =3D drmm_writeback_connector_init(drm, &txp->connector, + &vc4_txp_connector_funcs, + encoder, + drm_fmts, ARRAY_SIZE(drm_fmts)); if (ret) return ret; =20 --=20 2.47.2 From nobody Sat Oct 4 12:45:44 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB2552FD1CD for ; Sat, 16 Aug 2025 15:19:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357596; cv=none; b=TajXpjinUNi/biGo2VzY+cP1MIEogDjTjVkmjNHq1M26Of+UGVFt3DAKSPVSppq05AJdOR4LuwWywhIXummi7dJbFS+E5E4BG2+S1NJyg6p2LCEwzLljelERSSolR1mpsfbm3eg0CdUrOVBZI6XdXOO3WbysfbQS1kGq5ZRAuko= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357596; c=relaxed/simple; bh=Tfx7muI07rte1gs226Q+hRYOArvmNBAMe2ZWuhmuISI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=As2EtBqUG1LsA6GMp/vtZh00Ys5kzmysaO/B4dJO5eG5RX7xptCpMH/SVXUluvWQCHKnNhTofVzSaREDTB3C6bYANLxZWlQZMyBL77MSj6mENT81lr67fe8rECIIrs2chQP931rxPrlz7Upx61ohAafqFceAK3TpaLOlJbOCJmc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KTXDNvBy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KTXDNvBy" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57G703Bp003725 for ; Sat, 16 Aug 2025 15:19:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jvX092/V9dwE/NzPX2FObQHrrP1GpzHfFltQW2JSWGY=; b=KTXDNvByviHGc56b FFnLd5kClgulAetW2DC3S4SFHby5ZtD0KJ8fH2EYqSj8lT4tNyLzChcnnYOIuf27 38IOkOJRsOCPQOKyWC0oWUtidi1RTxgm46QvGJfd89HjYiynmGK4i9Xwl+AddU3Z iJpGSM1j+msRnnFeq2eDcX2xTeWJJQEClNyiujfeUIRyvHm0/i4nBgmy0ykbudK3 eXO97sLRNQXIK+PFhbv9zjfd6GOVokQhZiuWaSKn2nNgdoH2iB8MHxoix7BcxLsD mzskr+TkfcIbOoLfPiMHri9q3IgBKB6J98kaX0AUi52YuR0YvfKDQYDGWNet47VC VRa5TA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jhjy8v3r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 16 Aug 2025 15:19:53 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-70a88daeb18so62031406d6.0 for ; Sat, 16 Aug 2025 08:19:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755357593; x=1755962393; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jvX092/V9dwE/NzPX2FObQHrrP1GpzHfFltQW2JSWGY=; b=FHySiGpqLI05RWuddb/Jj+VA/DgfnvOKDbuljBJLABb9I7smk6z6sR2elelUjyH2R/ J6U9NpvbkWUz4uYp25Xyaa1M9cRSSRN2mFF8At/aGa5hqjtLg5C32+IrWraB+3Jg3t7c cAtUoyfhojAqcoXqdsZQU/4tU0PhdR+Bui1HicQI2LPJmkevE06mDxTC/ePAROAQuHHF xYJ+hSo62FBY5qCCqTqR0VMbENCUz/Ng549H0aopMsnVc5DWCYVxUFbfNbX0+cPSXZ5C adTJ+Brh/YFOY87+dJaCJLSNWwCiA64JBBG3maaps216uPvlJZQy3yConbPUmfz4glI3 GSag== X-Forwarded-Encrypted: i=1; AJvYcCVAWvR6vmO4TZ+nXNp/8oLB6jggITQFPmfzfCFidT+QQYc9hoQCulejtSuW/ZVbtNqzC27m2hIpwPVoKvs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzu2w0EaqHLRklNk/yXWqZf23LEbf3P/FVb1UYUJW/qLepMDOG3 a13fh5IjQNFQuqK1Y1Vby2hbQS/T8pD3nsucUe1XiGPlDU2NYX55xcC4oa+XU+8ZVOAug1H+sWv XTxED7nCpmXraUZChOxpNHKCvKo4UY8PHBR7gd0XBceSGLGTovngChJc1dASA1zupBPw= X-Gm-Gg: ASbGncvFs9ApTJug4oA43SAoXUitRsjBQNePbbElhFMojwSzs+nHHrcr8DZOce3DnYo xMEYprqRoPA2hxvwjpV5YfOrJtx2k3MZaCC4PBNC9OtE8EoZnPgP9SavcZybikDPx04EeZDQe6S wnbqnU91Yf05Wj3+6fexqRj96fv03k5HLS8SeJ5IhZ3LCQs3wSxUclr+C7G/o4d0tzOzpAIk5HJ YdvikJRxq8bErByqrQHdaLhmmjomoWpCWt2WWMsxrfbysrs6yTppk+3UtwWwU5hFbeSP8LQTGPo WQIkrjJEGBTU/EukyRh/VpAooJyYMMRU9Vh69qYcs0NMh1lnO6Wg/zw55K+VjKMaPN6BpjAiTma Qn+Ikl55LHB743nWS24KJMRxaC8z/MVaeCFahJdYSxuJBl9SXZcqi X-Received: by 2002:ad4:5cc2:0:b0:707:56e1:4806 with SMTP id 6a1803df08f44-70ba7c0c266mr68069096d6.26.1755357592725; Sat, 16 Aug 2025 08:19:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6wpmas11TOgM/lOrBnDaaa+ZNv9CM9o5CoLSNrvXvzguwCyeZq+xByyKZu7mpxQXzAs6ZHg== X-Received: by 2002:ad4:5cc2:0:b0:707:56e1:4806 with SMTP id 6a1803df08f44-70ba7c0c266mr68068676d6.26.1755357592140; Sat, 16 Aug 2025 08:19:52 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef35965fsm907579e87.37.2025.08.16.08.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Aug 2025 08:19:51 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 16 Aug 2025 18:19:41 +0300 Subject: [PATCH v2 7/8] drm: writeback: drop excess connector initialization functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250816-wb-drop-encoder-v2-7-f951de04f4f9@oss.qualcomm.com> References: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> In-Reply-To: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4592; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Tfx7muI07rte1gs226Q+hRYOArvmNBAMe2ZWuhmuISI=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBooKGJEY6eTqDPaJVKRsqidLF7oxfl/QKqz5sJg wIuVrMnDceJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKChiQAKCRCLPIo+Aiko 1awiB/9V+Wqv1GRqu/fY8y7enzI9KgxziG2fiX1GFmYXkgNtnapTor0nvb79mCc06hn7Js5AOKV ZD4DC1TE/rb5LA9V2C5miTmsrZRAiuNzE2+Q+R1FOjcZERb4/h7VhNT/IoQyw3CJue3YjUpl5du EXhHOfAsh43jFZaE7HFBomNNVcbnAgcMQtxElaqpIeg+9Au59RNUw/cQLDyTq+5P+3785UHchWz s/0eDtcW50jpqRXgY1bBIs5gdTeWSPalphDVtxWIIOBK8iFpNOyQU0PwfWnAjzTYkQh+qm0gipx /yqL7HrrhBLPlZsJMCschecIah/fB7Wo87n0ij2ZLSm+C4CA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: GlwyphFWi8KWbbMceUODt7E8HkmCFNHy X-Authority-Analysis: v=2.4 cv=ZJHXmW7b c=1 sm=1 tr=0 ts=68a0a199 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=3owybDqXPaZAjLikVYcA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: GlwyphFWi8KWbbMceUODt7E8HkmCFNHy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAyOCBTYWx0ZWRfXxcB14MscSoVy HB2LFkdYI9YSD3Shc68nFNGpZ7Jt4lWx5WVnZFxNezyJFzwG+SbUuFzmnZDvPixLdFeAlJRx7X5 QmtEEGwqeDDc+5YRVRYcfFfa+6nfLJrdcbgfaJFoygaUW3vFulqMq0BjqFq12YhnRfSzQSIiiGE DcQZJNMoBHZiOwXrMOJ+7IoAR+8b4ghmlkCEtlvlc2tTLQG5vWzPqGsSFetgw6zgUkP51h5nBPF vQjPn1csUVcTmWzkyos71aWqReiaMGmV57X8Vq43Vs2pEvCgMd7MA0sORR9sPRdUNgCh97sSMOR JPbEewBSpTkClRcdmkFfHn/3gOIZqAfseoSI9LlW8rzOM5lHUkF2yaeBHWacUswJtYnlMMRSo+z 3w+D4Jyy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-16_04,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160028 Now as all drivers have been converted to drmm_writeback_connector_init(), drop drm_writeback_connector_init() and drm_writeback_connector::encoder field, they are unused now. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 55 -------------------------------------= ---- include/drm/drm_writeback.h | 18 -------------- 2 files changed, 73 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 95b8a2e4bda69230591b50be15d14d0b3692373b..1a01df91b2c5868e158d489b782= f4c57c61a272c 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -142,61 +142,6 @@ static int create_writeback_properties(struct drm_devi= ce *dev) return 0; } =20 -static const struct drm_encoder_funcs drm_writeback_encoder_funcs =3D { - .destroy =3D drm_encoder_cleanup, -}; - -/** - * drm_writeback_connector_init - Initialize a writeback connector and its= properties - * @dev: DRM device - * @wb_connector: Writeback connector to initialize - * @con_funcs: Connector funcs vtable - * @enc_helper_funcs: Encoder helper funcs vtable to be used by the intern= al encoder - * @formats: Array of supported pixel formats for the writeback engine - * @n_formats: Length of the formats array - * @possible_crtcs: possible crtcs for the internal writeback encoder - * - * This function creates the writeback-connector-specific properties if th= ey - * have not been already created, initializes the connector as - * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the proper= ty - * values. It will also create an internal encoder associated with the - * drm_writeback_connector and set it to use the @enc_helper_funcs vtable = for - * the encoder helper. - * - * Drivers should always use this function instead of drm_connector_init()= to - * set up writeback connectors. - * - * Returns: 0 on success, or a negative error code - */ -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs) -{ - int ret =3D 0; - - drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); - - wb_connector->encoder.possible_crtcs =3D possible_crtcs; - - ret =3D drm_encoder_init(dev, &wb_connector->encoder, - &drm_writeback_encoder_funcs, - DRM_MODE_ENCODER_VIRTUAL, NULL); - if (ret) - return ret; - - ret =3D drm_writeback_connector_init_with_encoder(dev, wb_connector, &wb_= connector->encoder, - con_funcs, formats, n_formats); - - if (ret) - drm_encoder_cleanup(&wb_connector->encoder); - - return ret; -} -EXPORT_SYMBOL(drm_writeback_connector_init); - static void delete_writeback_properties(struct drm_device *dev) { if (dev->mode_config.writeback_pixel_formats_property) { diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index c380a7b8f55a3616fa070c037d5cc653b0061fe6..879ca103320cc225ffb36874190= 88361315535fc 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -24,17 +24,6 @@ struct drm_writeback_connector { */ struct drm_connector base; =20 - /** - * @encoder: Internal encoder used by the connector to fulfill - * the DRM framework requirements. The users of the - * @drm_writeback_connector control the behaviour of the @encoder - * by passing the @enc_funcs parameter to drm_writeback_connector_init() - * function. - * For users of drm_writeback_connector_init_with_encoder(), this field - * is not valid as the encoder is managed within their drivers. - */ - struct drm_encoder encoder; - /** * @pixel_formats_blob_ptr: * @@ -148,13 +137,6 @@ drm_connector_to_writeback(struct drm_connector *conne= ctor) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs); - int drm_writeback_connector_init_with_encoder(struct drm_device *dev, struct drm_writeback_connector *wb_connector, struct drm_encoder *enc, --=20 2.47.2 From nobody Sat Oct 4 12:45:44 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 723DE2FFDCB for ; Sat, 16 Aug 2025 15:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357598; cv=none; b=ppJCtNl419X3SdsD9tNQn6UkIx5pxJYIy93atMEj0br2a/nbVDtwsjx+SGBc/KBVVZpWyNWbHFTstA1/Jl3pJKdEkohfPAggcwgIqd8dC7bnWAzINfC0Zkiq5OdU2OqlQ9rOP8QVTkefmdRzO0lItep+/1Xgcp/a9K6dzMN2YNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755357598; c=relaxed/simple; bh=AaZVjuS1W7Ukw+8AzT9N6e3I54ede+nAI+GfJJ8GCnM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AQutAEkxEafhmlEJ2A26FDTeKHTuNNdhtfj07AB3dAUSJmIKNt6Jjt+10g7sreJHnpGY2GfzxH8rhp3bdh6YX6Bx16Rp6+AohD6h1aD+4vhvLOg5dVDLYBvUAGUeuNXzMhbWptsc90qq3l3OCj4AQSwJff+VVUy5hVhUzxlV2fc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EvINhH8F; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EvINhH8F" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57G3PpD5030372 for ; Sat, 16 Aug 2025 15:19:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TbQAYOijnA+OwP4fT62BQ14vH/cW4cuE/yCXav6j8bE=; b=EvINhH8F0hgbF8KM 5qk0gSsN+3bHotJ0bJ5hK3CMF8K0NLv7uptGLSKcto7vUYnGwAKmSQgBvWRUJ530 zrn7TwACfuYdmzEHkRLcUKQkQWBmB5Ep2aAl9+Oy9nuJ/AatZtTcYu/ViiCwtxuR PYwDNh37DiJU5wsPg5xKCQ7Cyn+xnya8NCqciVIcKofiLTChW33HqTHmqeWshUTh VlQlQnZpBKWwnIAs/UmQs/Dj427ekhyYyki8cFirsYcHxjcCzzJar9yzhbrT3BFh HPaXdgh9AxeBzDJQWhVa0mq6VM+NCE2XHj5eBZA6SqNBbu5i1U2Q5t8PKdjUYc/D FW0sAg== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jj2u8u0v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 16 Aug 2025 15:19:55 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-70a88d99c1cso60969906d6.0 for ; Sat, 16 Aug 2025 08:19:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755357594; x=1755962394; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TbQAYOijnA+OwP4fT62BQ14vH/cW4cuE/yCXav6j8bE=; b=GbuDs1nFPa5K7rHJjucwbJudJR3mSmS5PTmsf1FAdGV1BZCGRrgwR0rCTBS8TxfGQj Z0ItILl2BRWxtuEnWQXyXQlHdLWgr+j0r9zjCDAxHaQG1eTH4lxUnl69DUnlCoWgpKl/ OuPLBtGYQNGMJrnA5I08C1OXwTG9+DWTyWLDhUHN0kGsEd9lq61yJ/PXUemUVKAKehHE WU+Jn7RkUg57KAHLLni2D7uAmEBT+zz2it2MBX6z9Ie/JBQYkzY0t+4R0XhtxHAAjwpN YzPShMuqfy3YNIW7bu5knoBTOnoEo+MLVcr00GCON1Tv03hruPg9cjSBny28HMNicTJJ hnLQ== X-Forwarded-Encrypted: i=1; AJvYcCV7oFP0jJUzN/Mk1juubd7GV9wvsqozUI+yCEws5nuwcWzPUlG2WdGSlbfyGuT+tvOpZR6M/EqfIxTv/cc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzxx7SnZKWn9le4mOp0NdQsBz2ohuwohshiX7I+3BXzHhjLwb2R QGj8mR9Qn7H74kQlc001UDJt/PGHWcolDY9/IXJGJmqiIJfhPR5unZD6U+ZvuvKSxyd0UVjh+dM EjNVXXMyqBsxndeRr7IwJIPfcSh2KM0F1sBYuSXX4nnIKOoMf475fUz4A3OycjfLO5IU= X-Gm-Gg: ASbGncv4JOj1/EnTXzM4li/vdEW+YzrJrCB8cAM0sNTbbLLItr0/z0pnTifONEjey3d KDgmskMy6rAZbTx2vxhdv6OSCfpCUWcIwhBBhBpTW0Ma99s5hPUDvZJsFrEtcbxByORiN4WcBrS fOkiONrz5o2cNF/i8igFVu70UwiCWhnNkSnEVzPM+esZQQkmby53kX4Uwqfm5i1lr0m3VFlvsFm TIXuTgh0we2wA9YWRYVcl2i7iGcj9lAjP8WgAHIuP1REwZ0yzE2bLRpg/aUie8RSXsKkED5elbZ GycxM/09d/y/R0nZVAhOxg9vSQ3oWAGoCbfMVoks+8oBefOLvF+P9TzzjjeOt3sIyTYvcTPamew aub+0cuhgXkQ09O7wJNeB2NNY+cMvcQYo3dugKdLd8TQWh1FvrHnB X-Received: by 2002:a05:6214:ac7:b0:709:b92d:e84 with SMTP id 6a1803df08f44-70ba7ae80c1mr81199726d6.16.1755357594489; Sat, 16 Aug 2025 08:19:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHhdLfF+QII0ufvMc+c1Td2k4+GoblWcwEEncKFspxyk5vAWtgqLRyB8GatC2wFnN2BRckcQ== X-Received: by 2002:a05:6214:ac7:b0:709:b92d:e84 with SMTP id 6a1803df08f44-70ba7ae80c1mr81199036d6.16.1755357593955; Sat, 16 Aug 2025 08:19:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef35965fsm907579e87.37.2025.08.16.08.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Aug 2025 08:19:52 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 16 Aug 2025 18:19:42 +0300 Subject: [PATCH v2 8/8] drm: writeback: rename drm_writeback_connector_init_with_encoder() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250816-wb-drop-encoder-v2-8-f951de04f4f9@oss.qualcomm.com> References: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> In-Reply-To: <20250816-wb-drop-encoder-v2-0-f951de04f4f9@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3126; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=AaZVjuS1W7Ukw+8AzT9N6e3I54ede+nAI+GfJJ8GCnM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBooKGJYpPrdEi6HVTifOyYs/TwBkaE/wZcLttBb dHmFyn9qPuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKChiQAKCRCLPIo+Aiko 1TpWB/9pVqcOdq3X6uUsOd6BlW9YVLDGMvNAlGtBquoyjHsI9eErZLJKu29rJ6TztxyiQ7q0i08 jhfNJ0QGtJnijOlndgpf3L5upqul+kGrj0NtrEGWUc/DMB313lePVT/6AJ8Fn66/y5F0U2K2YJh sYeO5+KMWvj9ZGirQtyaJLtDZ7j1P8NgMByPHWub7osZupbOECo9VtFnKoFtsTWB4xtp0xLRgpY fyrmP1520fajz+ht3NawHqe1d20Hr4uhoGwn/W+joxOzUYs40p5yAbDA40ZbsclFKknpadmDD8u bvigSvNbXvi1tsVzPhQYUP5PmRjL/8RPxzLmdvUFBcq5talE X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=MJ9gmNZl c=1 sm=1 tr=0 ts=68a0a19b cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=yAS5wIYi4md-6cvEWsUA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: Q4-gNdVENvsTxaOEC6M38-c1f3bzneSX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAzMSBTYWx0ZWRfX+IGRRrj2fjyo byX2y4skIEIell5MS1c80Y+AD09HVXp8PS2VFKTUziZFeUyE1UJsSh75F6vYeedivypORipTwTt m2Q64XpsulzH58SLQVfQbhTMT4MkuFvk/a5k76tjg7+P7cr4fEJvpoeAVS52Pho48nHjIm22Znc PWwhVxjMfQL2X+RvauD70drGgYER3C9O0zNLkhzaFPGmSb6Vt+P3OG7aW0GtCVbls3o2+vFjWlo H56opyMLCwDZi65CjTjQgzgJu7WFfHoGaXVZQ0PdL0j/oNSP+h1f+ewIvZpch4BdOYeANhf9D6Z 3FBwbQvCTgnRhVBci/TndAY3J3eYkBc/kWtwlFd/wwz9jXySxtX2m+dd3a8+ooST7i0t2mVbxEA Ec/CgaU0 X-Proofpoint-GUID: Q4-gNdVENvsTxaOEC6M38-c1f3bzneSX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-16_04,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160031 Rename drm_writeback_connector_init_with_encoder() to drm_writeback_connector_init() and adapt its interface to follow drmm_writeback_connector_init(). Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 14 +++++++------- include/drm/drm_writeback.h | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 1a01df91b2c5868e158d489b782f4c57c61a272c..ec2575c4c21b7449707b0595322= e2202a0cf9865 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct drm_de= vice *dev, } =20 /** - * drm_writeback_connector_init_with_encoder - Initialize a writeback conn= ector with + * drm_writeback_connector_init - Initialize a writeback connector with * a custom encoder * * @dev: DRM device @@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct drm_= device *dev, * * Returns: 0 on success, or a negative error code */ -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, - const u32 *formats, int n_formats) +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats) { struct drm_connector *connector =3D &wb_connector->base; int ret; @@ -284,7 +284,7 @@ int drm_writeback_connector_init_with_encoder(struct dr= m_device *dev, =20 return ret; } -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder); +EXPORT_SYMBOL(drm_writeback_connector_init); =20 /** * drm_writeback_connector_cleanup - Cleanup the writeback connector diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index 879ca103320cc225ffb3687419088361315535fc..958466a05e604b387722610fc11= f9e841316d21b 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct drm_connector *conn= ector) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, const u32 *formats, - int n_formats); +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats); =20 int drmm_writeback_connector_init(struct drm_device *dev, struct drm_writeback_connector *wb_connector, --=20 2.47.2