From nobody Sat Oct 4 14:13:13 2025 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C2892E5D14 for ; Fri, 15 Aug 2025 16:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755276460; cv=none; b=hYp46EiVygNpiaDnR/9ml8Svy7OfmbtQKfk1p1nrhDC8Z8qqFZKUdLTDzgNIdb3SgbNlBus1UTa+6MV0BMcOTFO7Z25I8WxwQSe55rUlxDFGmmSy6HuZS4s8cw+8XgNoqI8OoTxLzhCSd28cZIorkJcgwRUGJzmAWZoh71E5gW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755276460; c=relaxed/simple; bh=tLdq16+tT/SCDYe9EnIPIJ3s3zMQDVrtHieEdsXPFkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zwd3ZSpBkQgoiU9q7qwokAr/T7daO/8Cej5Bi70p9uCDPxwF3AbJQMvrWMVojwWzuAPzzCJB2yoZBJx13cjp28gmP/ejVK4dE8mdlNPyGgWrnri40YjSzeHqxuG/A3Ael3FcgKXNSeVrN7yy8JEPrW5d25ktkoNOc6kPBNNhLVY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=watter.com; spf=pass smtp.mailfrom=linux.dev; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=watter.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ben Collins To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko Cc: Ben Collins , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] iio: mcp9600: Add support for IIR filter Date: Fri, 15 Aug 2025 16:46:07 +0000 Message-ID: <20250815164627.22002-6-bcollins@watter.com> In-Reply-To: <20250815164627.22002-1-bcollins@watter.com> References: <20250815164627.22002-1-bcollins@watter.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" MCP9600 supports an IIR filter with 7 levels. Add IIR attribute to allow get/set of this value. Signed-off-by: Ben Collins --- drivers/iio/temperature/mcp9600.c | 73 +++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/drivers/iio/temperature/mcp9600.c b/drivers/iio/temperature/mc= p9600.c index 361572a241f06..896520ddf6d3c 100644 --- a/drivers/iio/temperature/mcp9600.c +++ b/drivers/iio/temperature/mcp9600.c @@ -31,6 +31,7 @@ #define MCP9600_STATUS_ALERT(x) BIT(x) #define MCP9600_SENSOR_CFG 0x05 #define MCP9600_SENSOR_TYPE_MASK GENMASK(6, 4) +#define MCP9600_FILTER_MASK GENMASK(2, 0) #define MCP9600_ALERT_CFG1 0x08 #define MCP9600_ALERT_CFG(x) (MCP9600_ALERT_CFG1 + (x - 1)) #define MCP9600_ALERT_CFG_ENABLE BIT(0) @@ -94,6 +95,10 @@ static const int mcp9600_tc_types[] =3D { [THERMOCOUPLE_TYPE_R] =3D 'R', }; =20 +static const int mcp_iir_coefficients_avail[] =3D { + 1, 2, 4, 8, 16, 32, 64, 128, +}; + static const struct iio_event_spec mcp9600_events[] =3D { { .type =3D IIO_EV_TYPE_THRESH, @@ -118,7 +123,10 @@ static const struct iio_event_spec mcp9600_events[] = =3D { .address =3D MCP9600_HOT_JUNCTION, \ .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW) | \ BIT(IIO_CHAN_INFO_THERMOCOUPLE_TYPE) | \ + BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \ BIT(IIO_CHAN_INFO_SCALE), \ + .info_mask_separate_available =3D \ + BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY), \ .event_spec =3D &mcp9600_events[hj_ev_spec_off], \ .num_event_specs =3D hj_num_ev, \ }, \ @@ -161,6 +169,7 @@ struct mcp_chip_info { struct mcp9600_data { struct i2c_client *client; u32 thermocouple_type; + u8 filter_level; /* Chip default is 0 */ }; =20 static int mcp9600_read(struct mcp9600_data *data, @@ -191,13 +200,36 @@ static int mcp9600_read_raw(struct iio_dev *indio_dev, if (ret) return ret; return IIO_VAL_INT; + case IIO_CHAN_INFO_SCALE: *val =3D 62; *val2 =3D 500000; return IIO_VAL_INT_PLUS_MICRO; + case IIO_CHAN_INFO_THERMOCOUPLE_TYPE: *val =3D mcp9600_tc_types[data->thermocouple_type]; return IIO_VAL_CHAR; + + case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY: + *val =3D mcp_iir_coefficients_avail[data->filter_level]; + return IIO_VAL_INT; + + default: + return -EINVAL; + } +} + +static int mcp9600_read_avail(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + const int **vals, int *type, int *length, + long mask) +{ + switch (mask) { + case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY: + *vals =3D mcp_iir_coefficients_avail; + *type =3D IIO_VAL_INT; + *length =3D ARRAY_SIZE(mcp_iir_coefficients_avail); + return IIO_AVAIL_LIST; default: return -EINVAL; } @@ -211,6 +243,7 @@ static int mcp9600_config(struct mcp9600_data *data) =20 cfg =3D FIELD_PREP(MCP9600_SENSOR_TYPE_MASK, mcp9600_type_map[data->thermocouple_type]); + FIELD_MODIFY(MCP9600_FILTER_MASK, &cfg, data->filter_level); =20 ret =3D i2c_smbus_write_byte_data(client, MCP9600_SENSOR_CFG, cfg); if (ret < 0) { @@ -221,6 +254,43 @@ static int mcp9600_config(struct mcp9600_data *data) return 0; } =20 +static int mcp9600_write_raw_get_fmt(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + long mask) +{ + switch (mask) { + case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY: + return IIO_VAL_INT; + default: + return -EINVAL; + } +} + +static int mcp9600_write_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int val, int val2, long mask) +{ + struct mcp9600_data *data =3D iio_priv(indio_dev); + int i; + + switch (mask) { + case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY: + for (i =3D 0; i < ARRAY_SIZE(mcp_iir_coefficients_avail); i++) { + if (mcp_iir_coefficients_avail[i] =3D=3D val) + break; + } + + if (i =3D=3D ARRAY_SIZE(mcp_iir_coefficients_avail)) + return -EINVAL; + + data->filter_level =3D i; + return mcp9600_config(data); + + default: + return -EINVAL; + } +} + static int mcp9600_get_alert_index(int channel2, enum iio_event_direction = dir) { if (channel2 =3D=3D IIO_MOD_TEMP_AMBIENT) { @@ -358,6 +428,9 @@ static int mcp9600_write_thresh(struct iio_dev *indio_d= ev, =20 static const struct iio_info mcp9600_info =3D { .read_raw =3D mcp9600_read_raw, + .read_avail =3D mcp9600_read_avail, + .write_raw =3D mcp9600_write_raw, + .write_raw_get_fmt =3D mcp9600_write_raw_get_fmt, .read_event_config =3D mcp9600_read_event_config, .write_event_config =3D mcp9600_write_event_config, .read_event_value =3D mcp9600_read_thresh, --=20 2.50.1