From nobody Sat Oct 4 14:16:59 2025 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D2A1A25B1D8 for ; Fri, 15 Aug 2025 09:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755248759; cv=none; b=aLc4mbHneEpMRRV4OXIHtIOGdBVkaKiLtp9jpPL1jBsjRnk0UofH7W4+8F0AVnoNhcPhofX1IByPfocIl0lDmUQZEA8DpjZuV6fyGlDF2Z7U7upBliLIH6sIThvsN5yND+z3e2Op9TZNs5jAT6TeWFvpzpN4wqrf7LmfbtOq45s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755248759; c=relaxed/simple; bh=g32Hr6XVP9GwpLwAAUQhn9kUg4UCXMomOMdAWoH8gi4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=S2iJFS/Uwaa4xtt+1ZDZYIhh0uKiduGtwL3vA4Q2od5qAKfAdjPwQeg32jJEgGcu963cAPBjZ5mfXhYgBOV7eB1iKtV+vLJy4VU7u2MeD1vNUGYYgSphtGy9Osmz3f7GaZYSCPgb3ImODtoykjld7fSo7+jpywhnStkqvCnT4TA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [223.64.69.45]) by gateway (Coremail) with SMTP id _____8Axx2lx+J5owzpAAQ--.21961S3; Fri, 15 Aug 2025 17:05:53 +0800 (CST) Received: from localhost.localdomain (unknown [223.64.69.45]) by front1 (Coremail) with SMTP id qMiowJDx7sFs+J5olLdNAA--.32429S2; Fri, 15 Aug 2025 17:05:51 +0800 (CST) From: Huacai Chen To: Huacai Chen , Andrew Morton Cc: linux-mm@kvack.org, David Hildenbrand , Zi Yan , Lorenzo Stoakes , Harry Yoo , linux-kernel@vger.kernel.org, Huacai Chen Subject: [PATCH] mm/migrate: Fix NULL movable_ops if CONFIG_ZSMALLOC=m Date: Fri, 15 Aug 2025 17:05:39 +0800 Message-ID: <20250815090539.1578484-1-chenhuacai@loongson.cn> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qMiowJDx7sFs+J5olLdNAA--.32429S2 X-CM-SenderInfo: hfkh0x5xdftxo6or00hjvr0hdfq/ X-Coremail-Antispam: 1Uk129KBj93XoWxKF4xGF4kWFWrWF1fAr43Jwc_yoWxCFykpF 48Jr48Gr48JrWUJr17AF1UAry5Wws7uF48Jr9rGr1UZr1rXw17JFyUtFW7Ars8Wr15JF17 JFnrtw1Yyr4UJ3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU3529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUBYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6rxl6s0DM2kKe7AKxVWUAVWUtwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYI kI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUtVWr XwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI4 8JMxkF7I0En4kS14v26r126r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j 6r4UMxCIbckI1I0E14v26r126r1DMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwV AFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv2 0xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4 v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AK xVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8_gA5UUUUU== Content-Type: text/plain; charset="utf-8" After commit 84caf98838a3e5f4bdb34 ("mm: stop storing migration_ops in page->mapping") we get such an error message if CONFIG_ZSMALLOC=3Dm: WARNING: CPU: 3 PID: 42 at mm/migrate.c:142 isolate_movable_ops_page+0xa8/= 0x1c0 CPU: 3 UID: 0 PID: 42 Comm: kcompactd0 Not tainted 6.16.0-rc5+ #2133 PREEM= PT pc 9000000000540bd8 ra 9000000000540b84 tp 9000000100420000 sp 90000001004= 23a60 a0 9000000100193a80 a1 000000000000000c a2 000000000000001b a3 fffffffffff= fffff a4 ffffffffffffffff a5 0000000000000267 a6 0000000000000000 a7 90000001004= 23ae0 t0 00000000000000f1 t1 00000000000000f6 t2 0000000000000000 t3 00000000000= 00001 t4 ffffff00010eb834 t5 0000000000000040 t6 900000010c89d380 t7 90000000023= fcc70 t8 0000000000000018 u0 0000000000000000 s9 ffffff00010eb800 s0 ffffff00010= eb800 s1 000000000000000c s2 0000000000043ae0 s3 0000800000000000 s4 90000000021= 9cc40 s5 0000000000000000 s6 ffffff00010eb800 s7 0000000000000001 s8 90000000025= b4000 ra: 9000000000540b84 isolate_movable_ops_page+0x54/0x1c0 ERA: 9000000000540bd8 isolate_movable_ops_page+0xa8/0x1c0 CRMD: 000000b0 (PLV0 -IE -DA +PG DACF=3DCC DACM=3DCC -WE) PRMD: 00000004 (PPLV0 +PIE -PWE) EUEN: 00000000 (-FPE -SXE -ASXE -BTE) ECFG: 00071c1d (LIE=3D0,2-4,10-12 VS=3D7) ESTAT: 000c0000 [BRK] (IS=3D ECode=3D12 EsubCode=3D0) PRID: 0014c010 (Loongson-64bit, Loongson-3A5000) CPU: 3 UID: 0 PID: 42 Comm: kcompactd0 Not tainted 6.16.0-rc5+ #2133 PREEM= PT Stack : 90000000021fd000 0000000000000000 9000000000247720 9000000100420000 90000001004236a0 90000001004236a8 0000000000000000 90000001004237e8 90000001004237e0 90000001004237e0 9000000100423550 0000000000000001 0000000000000001 90000001004236a8 725a84864a19e2d9 90000000023fcc58 9000000100420000 90000000024c6848 9000000002416848 0000000000000001 0000000000000000 000000000000000a 0000000007fe0000 ffffff00010eb800 0000000000000000 90000000021fd000 0000000000000000 900000000205cf30 000000000000008e 0000000000000009 ffffff00010eb800 0000000000000001 90000000025b4000 0000000000000000 900000000024773c 00007ffff103d748 00000000000000b0 0000000000000004 0000000000000000 0000000000071c1d ... Call Trace: [<900000000024773c>] show_stack+0x5c/0x190 [<90000000002415e0>] dump_stack_lvl+0x70/0x9c [<90000000004abe6c>] isolate_migratepages_block+0x3bc/0x16e0 [<90000000004af408>] compact_zone+0x558/0x1000 [<90000000004b0068>] compact_node+0xa8/0x1e0 [<90000000004b0aa4>] kcompactd+0x394/0x410 [<90000000002b3c98>] kthread+0x128/0x140 [<9000000001779148>] ret_from_kernel_thread+0x28/0xc0 [<9000000000245528>] ret_from_kernel_thread_asm+0x10/0x88 The reason is that defined(CONFIG_ZSMALLOC) evaluates to 1 only when CONFIG_ZSMALLOC=3Dy, we should use IS_ENABLED(CONFIG_ZSMALLOC) instead. But when I use IS_ENABLED(CONFIG_ZSMALLOC), page_movable_ops() cannot access zsmalloc_mops because zsmalloc_mops is in a module. To solve this problem, we define a movable_ops[] array in mm/migrate.c, initialise its elements at mm/balloon_compaction.c & mm/zsmalloc.c, and let the page_movable_ops() function return elements from movable_ops[]. Fixes: 84caf98838a3e5f ("mm: stop storing migration_ops in page->mapping") Signed-off-by: Huacai Chen Acked-by: Zi Yan --- include/linux/migrate.h | 6 ++++++ mm/balloon_compaction.c | 7 +++++++ mm/migrate.c | 16 ++++++++++------ mm/zsmalloc.c | 6 ++++++ 4 files changed, 29 insertions(+), 6 deletions(-) diff --git a/include/linux/migrate.h b/include/linux/migrate.h index acadd41e0b5c..58fac171e4d5 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h @@ -57,6 +57,12 @@ struct movable_operations { void (*putback_page)(struct page *); }; =20 +#define MOVABLE_BALLOON 0 +#define MOVABLE_ZSMALLOC 1 +#define MOVABLE_MAX 2 + +extern const struct movable_operations *movable_ops[MOVABLE_MAX]; + /* Defined in mm/debug.c: */ extern const char *migrate_reason_names[MR_TYPES]; =20 diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index 2a4a649805c1..a1d2625b5c39 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -254,4 +254,11 @@ const struct movable_operations balloon_mops =3D { .putback_page =3D balloon_page_putback, }; =20 +static int __init balloon_init(void) +{ + movable_ops[MOVABLE_BALLOON] =3D &balloon_mops; + return 0; +} +core_initcall(balloon_init); + #endif /* CONFIG_BALLOON_COMPACTION */ diff --git a/mm/migrate.c b/mm/migrate.c index 425401b2d4e1..92918fab3e1a 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -53,6 +53,10 @@ #include "internal.h" #include "swap.h" =20 +const struct movable_operations *movable_ops[MOVABLE_MAX]; + +EXPORT_SYMBOL(movable_ops); + static const struct movable_operations *page_movable_ops(struct page *page) { VM_WARN_ON_ONCE_PAGE(!page_has_movable_ops(page), page); @@ -62,15 +66,15 @@ static const struct movable_operations *page_movable_op= s(struct page *page) * it as movable, the page type must be sticky until the page gets freed * back to the buddy. */ -#ifdef CONFIG_BALLOON_COMPACTION +#if IS_ENABLED(CONFIG_BALLOON_COMPACTION) if (PageOffline(page)) /* Only balloon compaction sets PageOffline pages movable. */ - return &balloon_mops; -#endif /* CONFIG_BALLOON_COMPACTION */ -#if defined(CONFIG_ZSMALLOC) && defined(CONFIG_COMPACTION) + return movable_ops[MOVABLE_BALLOON]; +#endif /* IS_ENABLED(CONFIG_BALLOON_COMPACTION) */ +#if IS_ENABLED(CONFIG_ZSMALLOC) && IS_ENABLED(CONFIG_COMPACTION) if (PageZsmalloc(page)) - return &zsmalloc_mops; -#endif /* defined(CONFIG_ZSMALLOC) && defined(CONFIG_COMPACTION) */ + return movable_ops[MOVABLE_ZSMALLOC]; +#endif /* IS_ENABLED(CONFIG_ZSMALLOC) && IS_ENABLED(CONFIG_COMPACTION) */ return NULL; } =20 diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 2c5e56a65354..052fcc0d29e5 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -2246,6 +2246,9 @@ EXPORT_SYMBOL_GPL(zs_destroy_pool); =20 static int __init zs_init(void) { +#ifdef CONFIG_MIGRATION + movable_ops[MOVABLE_ZSMALLOC] =3D &zsmalloc_mops; +#endif #ifdef CONFIG_ZPOOL zpool_register_driver(&zs_zpool_driver); #endif @@ -2255,6 +2258,9 @@ static int __init zs_init(void) =20 static void __exit zs_exit(void) { +#ifdef CONFIG_MIGRATION + movable_ops[MOVABLE_ZSMALLOC] =3D NULL; +#endif #ifdef CONFIG_ZPOOL zpool_unregister_driver(&zs_zpool_driver); #endif --=20 2.47.3