From nobody Sat Oct 4 14:13:11 2025 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A573220F30 for ; Fri, 15 Aug 2025 07:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.101 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755242075; cv=none; b=bGpp0drw5VDzLm6qbZr9sZ2xgycnXpS/V3txSkt4oMBg0LxVHURxp3lkZtJQgGMKosi0eMnpbgNfVqK+rYtzXtUyDpnFMKiAuarGmKqnaa18Vf0pEhzZ2UA5DOrzf0AdjnM4ny+EDXjySq/d2VFiJq4kkSPYuoi94RTZryokEuU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755242075; c=relaxed/simple; bh=ewMJk6wAAzgMUMYP/9W5KcSaZDRdd0EX+zxzJTjpK/o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GsoZ2k3tKh7rGfskZm+r1X6MHO+otRKtL84yWXFKuMCE27dz79+7AcN428lLKmQo6wdojt9NDcrWLBuzb3cxBpOc2f5r3VVnhZsG3DES7GDTGynm6poPV3dZZwr9p3/nvSHaebFkD4fU8TIOcSRX3V7NhtU+MYeUIvHcs8AD/Po= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=rk6X/6t+; arc=none smtp.client-ip=115.124.30.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="rk6X/6t+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1755242070; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=d+Rgi9ggLE8RHIN7XYswQJ8cd0pl5zwQMXMpubqkD44=; b=rk6X/6t+U8Fdx8rF09QRHtP2pkzxxNg9n2M+6EgvsSi5VX+aocQ0q5C/UTTcdfl8Bg+lAQ5Y9PZW3AiF3Xnvscvv1NpRWaD35foJ/lz094aIlvH1Eq9EmBRCT06CAO0rey5kEunoukftmrLPGZZoxSpVp04hIk1NcubkLeXlw/Y= Received: from localhost(mailfrom:feng.tang@linux.alibaba.com fp:SMTPD_---0WloF6LR_1755242069 cluster:ay36) by smtp.aliyun-inc.com; Fri, 15 Aug 2025 15:14:29 +0800 From: Feng Tang To: Andrew Morton , Petr Mladek , Steven Rostedt , Lance Yang , Jonathan Corbet , linux-kernel@vger.kernel.org Cc: paulmck@kernel.org, john.ogness@linutronix.de, Feng Tang Subject: [PATCH 1/3] lib/sys_info: handle sys_info_mask==0 case Date: Fri, 15 Aug 2025 15:14:26 +0800 Message-Id: <20250815071428.98041-2-feng.tang@linux.alibaba.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250815071428.98041-1-feng.tang@linux.alibaba.com> References: <20250815071428.98041-1-feng.tang@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It is a normal case that bitmask parameter is 0, so pre-initialize the names[] to null string to cover this case. Also remove the superfluous "+1" in names[sizeof(sys_info_avail) + 1], which is needed for 'strlen()', but not for 'sizeof()'. Suggested-by: Petr Mladek Signed-off-by: Feng Tang Reviewed-by: Petr Mladek --- lib/sys_info.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/sys_info.c b/lib/sys_info.c index 5bf503fd7ec1..b2df148971ba 100644 --- a/lib/sys_info.c +++ b/lib/sys_info.c @@ -55,7 +55,7 @@ int sysctl_sys_info_handler(const struct ctl_table *ro_ta= ble, int write, void *buffer, size_t *lenp, loff_t *ppos) { - char names[sizeof(sys_info_avail) + 1]; + char names[sizeof(sys_info_avail)]; struct ctl_table table; unsigned long *si_bits_global; =20 @@ -81,6 +81,9 @@ int sysctl_sys_info_handler(const struct ctl_table *ro_ta= ble, int write, char *delim =3D ""; int i, len =3D 0; =20 + /* *si_bits_glabl could be 0 */ + names[0] =3D '\0'; + for (i =3D 0; i < ARRAY_SIZE(si_names); i++) { if (*si_bits_global & si_names[i].bit) { len +=3D scnprintf(names + len, sizeof(names) - len, --=20 2.43.5 From nobody Sat Oct 4 14:13:11 2025 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06AD32D0C81 for ; Fri, 15 Aug 2025 07:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.119 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755242081; cv=none; b=JaJGyfCS/iLF/g8RKlWD4dg8k9jTa9YXQH51LNFuvZ3+juYhKrdYlCk+o4Y7mqOjDCa65WOyj//EuQm8pPo+aM4Phs5p7ITPriPNglztBGfjbFMC9YMFdSpBvJ/o+clb9kRKDR5rCVA1rZKusB1BBKN2qoEoVAe/pI2cqgAOF0s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755242081; c=relaxed/simple; bh=8iCGFRXdjEcgH8jFuaZvEErSEaJbgl0fzstP/xAk8B0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=exol1xBTu0Fl+LRRZXC4olDHvJtF4+E5qVJkVusG41KvTfgrnDbo71IM13UGHgm6TpfRMVrIynMwCHvA2F9rQEMIRSt7P3+lho2E8eDSI882LzkUjK2SwgBVJWXg1aCcK0cwh7XmCFP9D1uIcddv0ufLkza0Q3NrVryu9WJR7zg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=WGzONB7y; arc=none smtp.client-ip=115.124.30.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="WGzONB7y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1755242071; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=uMCX/8fDc/68HLhW5LBxhhq0Ib6EqFg3uQ/2lz4dZcc=; b=WGzONB7yBrw4Yit5ezgd+ZyifkEyUHleG/gktnJe5vDbDjZfmntM3VAqK0eswZ6BqbjwfcW+MeyjZT54LvdhnpTaehOCb/Rvv362sKkRVGC0JffhsdrrtkmVPCrBP7HBKQcgr+oNbiiFbNZEs7Im2CdBmLYXY1H08pH8JBojlM8= Received: from localhost(mailfrom:feng.tang@linux.alibaba.com fp:SMTPD_---0WloF6Li_1755242070 cluster:ay36) by smtp.aliyun-inc.com; Fri, 15 Aug 2025 15:14:30 +0800 From: Feng Tang To: Andrew Morton , Petr Mladek , Steven Rostedt , Lance Yang , Jonathan Corbet , linux-kernel@vger.kernel.org Cc: paulmck@kernel.org, john.ogness@linutronix.de, Feng Tang , Askar Safin Subject: [PATCH 2/3] panic: refine the document for 'panic_print' Date: Fri, 15 Aug 2025 15:14:27 +0800 Message-Id: <20250815071428.98041-3-feng.tang@linux.alibaba.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250815071428.98041-1-feng.tang@linux.alibaba.com> References: <20250815071428.98041-1-feng.tang@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" User reported current document about SYS_INFO_PANIC_CONSOLE_REPLAY is confusing, that people could expect all user space console messages to be replayed. Specify that only 'kernel' messages will be replayed to solve the confusion. Reported-by: Askar Safin Signed-off-by: Feng Tang Reviewed-by: Petr Mladek --- Documentation/admin-guide/kernel-parameters.txt | 2 +- Documentation/admin-guide/sysctl/kernel.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentatio= n/admin-guide/kernel-parameters.txt index 747a55abf494..86f395f2933b 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -4589,7 +4589,7 @@ bit 2: print timer info bit 3: print locks info if CONFIG_LOCKDEP is on bit 4: print ftrace buffer - bit 5: replay all messages on consoles at the end of panic + bit 5: replay all kernel messages on consoles at the end of panic bit 6: print all CPUs backtrace (if available in the arch) bit 7: print only tasks in uninterruptible (blocked) state *Be aware* that this option may print a _lot_ of lines, diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/ad= min-guide/sysctl/kernel.rst index 8b49eab937d0..f3ee807b5d8b 100644 --- a/Documentation/admin-guide/sysctl/kernel.rst +++ b/Documentation/admin-guide/sysctl/kernel.rst @@ -890,7 +890,7 @@ bit 1 print system memory info bit 2 print timer info bit 3 print locks info if ``CONFIG_LOCKDEP`` is on bit 4 print ftrace buffer -bit 5 replay all messages on consoles at the end of panic +bit 5 replay all kernel messages on consoles at the end of panic bit 6 print all CPUs backtrace (if available in the arch) bit 7 print only tasks in uninterruptible (blocked) state =3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --=20 2.43.5 From nobody Sat Oct 4 14:13:11 2025 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DFE7277006 for ; Fri, 15 Aug 2025 07:14:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755242082; cv=none; b=fvSE+KckHuMgiUKDTSyyhEkk+V+bQOSorAZ/mNX5qVorCq5z5+huInvRTVuoQXSWaD7BuvTkVoZCqheo7ccjT25BfJq4EhNHfEmsmyVRdBT7/dpTzomDvLzJ99wn8mPn0pm+/BpNmTWc69uJQhv1cxysFFEXYoufJ7YRNPpFjho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755242082; c=relaxed/simple; bh=yMhwXvExAIXrUvjYDN3RRM4DD/FBUqu36oMO9HQFcC8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=G3Nm9cRtmf1bvE40ikFUBBQg06f9uBJAj3PrrPBRjhfD2AKqcdhEZHHFJmVwYDQ4HfTyJ3zupFFajCW7EOIeeGxyIcx1tjYWl6HF9R7Z44hgGlXExuxgm1hBLitkVIst2h2gpMiP4KIQEThUtvsKJnmGEUj4lsaxIYF2ngBy/oY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=SToGooAh; arc=none smtp.client-ip=115.124.30.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="SToGooAh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1755242071; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=+LJumeGJsa/l6c8YckmCr4Rkg4kV6Qdze8K+ER3yj7k=; b=SToGooAh//lLODbUdMCNMUvN1OA/NO5WZxEac+x1bPx2NuIyq6OPXkN8gRBqPnznFchrVEaEJGXLsVLUl9lIGmnkzG5PpGGW8/7V62CgLDWmQHPa++muAwXux5fVTIEkoL0Yl7Jsx8MqiVncgrcEpErlaeTpl+LvHtS0E2157Z0= Received: from localhost(mailfrom:feng.tang@linux.alibaba.com fp:SMTPD_---0Wlo5rKZ_1755242070 cluster:ay36) by smtp.aliyun-inc.com; Fri, 15 Aug 2025 15:14:31 +0800 From: Feng Tang To: Andrew Morton , Petr Mladek , Steven Rostedt , Lance Yang , Jonathan Corbet , linux-kernel@vger.kernel.org Cc: paulmck@kernel.org, john.ogness@linutronix.de, Feng Tang Subject: [PATCH 3/3] panic: add note that 'panic_print' parameter is deprecated Date: Fri, 15 Aug 2025 15:14:28 +0800 Message-Id: <20250815071428.98041-4-feng.tang@linux.alibaba.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250815071428.98041-1-feng.tang@linux.alibaba.com> References: <20250815071428.98041-1-feng.tang@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Just like for 'panic_print's systcl interface, add similar note for setup of kernel cmdline parameter and parameter under /sys/module/kernel/. Also add __core_param_cb() macro, which enables to add special get/set operation for a kernel parameter. Suggested-by: Petr Mladek Signed-off-by: Feng Tang Reviewed-by: Petr Mladek --- include/linux/moduleparam.h | 14 ++++++++++++++ kernel/panic.c | 19 ++++++++++++++++++- 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h index 3a25122d83e2..381c3779244c 100644 --- a/include/linux/moduleparam.h +++ b/include/linux/moduleparam.h @@ -199,6 +199,7 @@ struct kparam_array #define core_param_cb(name, ops, arg, perm) \ __level_param_cb(name, ops, arg, perm, 1) =20 + /** * postcore_param_cb - general callback for a module/cmdline parameter * to be evaluated before postcore initcall level @@ -349,6 +350,19 @@ static inline void kernel_param_unlock(struct module *= mod) __module_param_call("", name, ¶m_ops_##type, &var, perm, \ -1, KERNEL_PARAM_FL_UNSAFE) =20 +/** + * __core_param_cb - similar like core_param, with a set/get ops instead o= f type. + * @name: the name of the cmdline and sysfs parameter (often the same as v= ar) + * @var: the variable + * @ops: the set & get operations for this parameter. + * @perm: visibility in sysfs + * + * Ideally this should be called 'core_param_cb', but the name has been + * used for module core parameter, so add the '__' prefix + */ +#define __core_param_cb(name, ops, arg, perm) \ + __module_param_call("", name, ops, arg, perm, -1, 0) + #endif /* !MODULE */ =20 /** diff --git a/kernel/panic.c b/kernel/panic.c index 72fcbb5a071b..12a10e17ab4a 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -937,12 +937,29 @@ EXPORT_SYMBOL(__stack_chk_fail); #endif =20 core_param(panic, panic_timeout, int, 0644); -core_param(panic_print, panic_print, ulong, 0644); core_param(pause_on_oops, pause_on_oops, int, 0644); core_param(panic_on_warn, panic_on_warn, int, 0644); core_param(crash_kexec_post_notifiers, crash_kexec_post_notifiers, bool, 0= 644); core_param(panic_console_replay, panic_console_replay, bool, 0644); =20 +static int panic_print_set(const char *val, const struct kernel_param *kp) +{ + pr_info_once("Kernel: 'panic_print' parameter will be obsoleted by both '= panic_sys_info' and 'panic_console_replay'\n"); + return param_set_ulong(val, kp); +} + +static int panic_print_get(char *val, const struct kernel_param *kp) +{ + pr_info_once("Kernel: 'panic_print' parameter will be obsoleted by both '= panic_sys_info' and 'panic_console_replay'\n"); + return param_get_ulong(val, kp); +} + +static const struct kernel_param_ops panic_print_ops =3D { + .set =3D panic_print_set, + .get =3D panic_print_get, +}; +__core_param_cb(panic_print, &panic_print_ops, &panic_print, 0644); + static int __init oops_setup(char *s) { if (!s) --=20 2.43.5