From nobody Sat Oct 4 14:13:11 2025 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EE5F31984A; Fri, 15 Aug 2025 06:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238722; cv=none; b=F7u+s2CEj70tGSNDdYg+9+uepar2arltH06nDQ01bIimmR2CmdpIC/bpyo/2hSXh/FrLiiQDAEhgVfMkdrIr7nzcvo2h7hYln9m0sOg+zZvcEa5CV6MTYHd6xcwcdM7WPzJruRpZFpnnFNvWUNxN+eHGFd9SPGA5hlGKIgc23/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238722; c=relaxed/simple; bh=x1ATtyTcNSslUyv0qjv3375CuVeybZpmPNqMbhb1yZ0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gVZPKbPLWaQaMPSh+6WZhJ+kdjsA5JfSlbL0cwBd2JXhqIa3Mvz1axuuPzQO5cAm/Q9Emp5CsSWnFpxcj3xas5Rs1K6PtWDIA+bND+n4vyZqoRO+wYyyJOR3vOGjUywwABhriO+ezhkY9FEYjCkIIMA/1RWRHRru82Vo3Dk+kto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d8hDl+mW; arc=none smtp.client-ip=209.85.216.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d8hDl+mW" Received: by mail-pj1-f66.google.com with SMTP id 98e67ed59e1d1-32326e2f0b3so1359558a91.2; Thu, 14 Aug 2025 23:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755238718; x=1755843518; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4J1O4cvXmQVXOS+LA9W9A1gYpwwOti/g631zQHcAM1M=; b=d8hDl+mWoGqwLrnbGmArmB/zKOljRNrXPB0O7o6n3DUYccdNqfU8jAPLnJg/UFM9Ce DclQX4xAmBnffRzrfXigvcSfCfTdfrRgWekfijDvFAjH/7/OeSXiJYMNDk4+LnP0U17/ 9Nv889IG4OVZ/6Ma9pOiy//x7jnO54+7TBKDviXlYAYjvsa0B88g5u1s4rdoJ4bXikUp gwfnbgzdomausRTO2fP+sCUm2jXpHcOBNAZ80ZyF//FAoBROrNHP3ZdOVHMiFA3okFJT CqhBRfefMyfscZV6EJlFklikV153dsHd1KszPf1lOu760O3mxZhrD+38Cn5p4h6akQqw ByeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755238718; x=1755843518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4J1O4cvXmQVXOS+LA9W9A1gYpwwOti/g631zQHcAM1M=; b=dltmutn0TKvaE5dz7TZ42qmyitnraeJAqaKVZtv86gY2CLsqTzagmeEKPogFzdwbtW xfmvYYv/TX7ftqFSPbMZro89pXJnSdTVLhc2Fmoj7tb1Sgfvp/EQaInmkjrLZYM/tT6L CUYBBUjggwnTlY/AcK/pL8bR5tyF8sC9W6lb6BIsbJemwruKg01V5uYIdQtuDPQnXfXa X074jUP1vdfGPvPp4aWQ4I38d8gVO7V8YDqO+UCILCe6zbPx7gZR9hB5ZTJZsWTzU9u4 2dJKEYpOziGyq4XnMk2mOn0TjAlvZ5phr2g40k/usNpB9Qz4mJ7AkiOifoKT3M+JERNo FBVg== X-Forwarded-Encrypted: i=1; AJvYcCVKU00PzZOxp9ZBraVC2SPWwhC20mav5XJaH3Yo6W23yzLeHqO6vmBo7k4u1Gpn8Y1xf64=@vger.kernel.org, AJvYcCXePOopB6aiXqjKzAYD2BK6DbEQ7MSSR2lUnqM0qdXxIgejfPJ8YqK6XFE4PJF0Gt9+b3kIHIXTVxVsbHYJ@vger.kernel.org X-Gm-Message-State: AOJu0Yw2WtIg3+6UU7wvzrvvfsIWisEi7bIYVpfHemw5mMLnrlPFpYNB qZsK9ro+4NSATdyCLgnisx+RIXoP9drjTG7pfTRCaa6PZX8GctLg2LTf X-Gm-Gg: ASbGncvb6cknJZlBtbzb0S7upulq5emtDZR233O1NevBJrENBbFnZ4cFbdU1TvwUio1 V9HQs+diJL9L11MZv6yyu7ULKCbUYEcp+o7t21JWhcy1pvENfu2K5+un/Angzd4zRev16L7yayi PYZWvXgzEZBZfzBuRalF9PjYqbF8hFTJk32phgZ2yekqzsmDl9b2GiTsR/oM+UNz/FlwNwY4aoq DnMHyyeD8uc/NUwnjBIZrhP0aCpxUHZ2KW+n2zvPI5WOfwDvmX9HAk4muP0ePpGM4aSyXHPM3Na HSO/mKXsTani7cfoRcmXP5nBxyYJh64O5UCbqLwFa28FcY1A7eivrujfd0VWq9Orr1pDNOpm+o4 f6emFqqihsSm86+mBC1c= X-Google-Smtp-Source: AGHT+IGEamtl0+FoPBkIDlXgUljBSam0In6IaXjx3HrsQ//QiaFz+SZtALG8m3pGv2VN3oPUxCaPqw== X-Received: by 2002:a17:90b:3dc7:b0:315:aa28:9501 with SMTP id 98e67ed59e1d1-323421610e4mr1795691a91.24.1755238717706; Thu, 14 Aug 2025 23:18:37 -0700 (PDT) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e4558ae7bsm408607b3a.95.2025.08.14.23.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 23:18:37 -0700 (PDT) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org Cc: daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next 1/7] rcu: add rcu_migrate_enable and rcu_migrate_disable Date: Fri, 15 Aug 2025 14:18:18 +0800 Message-ID: <20250815061824.765906-2-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250815061824.765906-1-dongml2@chinatelecom.cn> References: <20250815061824.765906-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" migrate_disable() is called to disable migration in the kernel, and it is used togather with rcu_read_lock() oftenly. However, with PREEMPT_RCU disabled, it's unnecessary, as rcu_read_lock() will disable preemption, which will also disable migration. Introduce rcu_migrate_enable() and rcu_migrate_disable(), which will do the migration enable and disable only when the rcu_read_lock() can't do it. Signed-off-by: Menglong Dong --- include/linux/rcupdate.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h index 120536f4c6eb..0d9dbd90d025 100644 --- a/include/linux/rcupdate.h +++ b/include/linux/rcupdate.h @@ -72,6 +72,16 @@ static inline bool same_state_synchronize_rcu(unsigned l= ong oldstate1, unsigned void __rcu_read_lock(void); void __rcu_read_unlock(void); =20 +static inline void rcu_migrate_enable(void) +{ + migrate_enable(); +} + +static inline void rcu_migrate_disable(void) +{ + migrate_disable(); +} + /* * Defined as a macro as it is a very low level header included from * areas that don't even know about current. This gives the rcu_read_lock= () @@ -105,6 +115,14 @@ static inline int rcu_preempt_depth(void) return 0; } =20 +static inline void rcu_migrate_enable(void) +{ +} + +static inline void rcu_migrate_disable(void) +{ +} + #endif /* #else #ifdef CONFIG_PREEMPT_RCU */ =20 #ifdef CONFIG_RCU_LAZY --=20 2.50.1 From nobody Sat Oct 4 14:13:11 2025 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F8862153CE; Fri, 15 Aug 2025 06:18:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238725; cv=none; b=TaYjsu0IV1eo+vzfswxR4o6h1iUfObwDMczBHTE9tFEMoflVOE0wu9dPobwFlSne6L0lGRnLANZiuvC4NTpKOlP+KVLGUJcJJlL19BX/HktLZXbvyNXjtG9ETGN6vmnA8xktUdgOvl5eoIYfKPkdzTweMZNpC6cOf6MSVtHrixk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238725; c=relaxed/simple; bh=lR5h6MbApSZ5sM+smUV5Z0UymMEQuA/jTBLHSP9jWSQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hv19HfsFuX6kHKNEe+582kDb7wylSq+lNPCoJlYLHVauOPQ8FjnxBvG8toWCGsvocETD3nGqf2nD3V+1euqgWP5yQ2mE8vFBFmolg/EcJp99yulK+PCo9WU+pkbtuxozVlQEEGrb1Ng+zUKs4gUIJ9Js/G8fvcEH/pJOaEt/r7s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gvWFhFoY; arc=none smtp.client-ip=209.85.210.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gvWFhFoY" Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-76e39ec6f52so1232396b3a.1; Thu, 14 Aug 2025 23:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755238722; x=1755843522; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ojMIruf+CfSEtOOKLXCYppMGwHdqsotd/cjThFA4M8A=; b=gvWFhFoYY2/ha+TDghbVq2/KGcZjj77Kx31EHlkoyRPEzABXuPOxG7GnRZBQBnkfcq 1AFmdkGJqMV4Orr2M5gRmm/G5S7EY3OarV2N4yawkqykQMXRDoldSqBA7StX/syITpRq v8lZH3WHOjfv9qCpZElkK3a7MAqrME/ROARZigDLW8P2mCRx/GdxWVmbB9kR+waQ16OD nyBv0+TxSMRx9HEz1KvOK9GPwlhOM3OogNYxVntVmUK9hhW4hlGNtHBGThHlRIO+TYEp ola/GPF4GXEjAbua0nNDpdPdhmsGxpQqWWn9aBn+L1T0TSX8fDobO1q8/BbGBx/DtiIE KKXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755238722; x=1755843522; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ojMIruf+CfSEtOOKLXCYppMGwHdqsotd/cjThFA4M8A=; b=svRgMbd0MeEa8QgNaB2RKGjaCaf13BLSHmO53y82cUJYhbgmmVswog02FnHwSv3KHI 106ZIGKkg/B/BfbRxcgQTX92vp7K8GqxXOgirC87FjrpeVyTRQhpNtYA+24feMuoD7cT Cif8DUTh2hMPdBwGoaxFuSzIxoE/ED7s/cvaJ+xVxkf8QNZIu8HX90RkLQ3lCrukhVLC cJACRYNwPJoQlGO7+AojPurqcqVtYZ/GP57elIUrBqwxEomL4/8RvGA+3N67bflQf7OZ W+ERnERZGpXNupYmqT5vUF9pe57jxbc0ILnOxh1xk187QYNCQ+5Uk7eb1DIAjXh7GXeI 4aHQ== X-Forwarded-Encrypted: i=1; AJvYcCUrFp4GQMup/i260jU5VGKH9+u/I0I/DofVdvCkxbJrgMBG9o2BZaJXc3HTzVYIULiqZSo=@vger.kernel.org, AJvYcCXWhNDB2wcfNQJT6gIwBncg2t9LBNaEpzFv3A3vk0Kt4cj8lAZc4uNO9qPdG9KLvv1rkBs5w+lci8CI/Of0@vger.kernel.org X-Gm-Message-State: AOJu0Yw92EtocvJ9T6e24nUykFAujVlhllMwmXU9qh7GG6ZGtyZVHjNq 4eibZ8yL+4FH6iLdWSVypaRfNqJqb2yASTGpeJOY5dl0fS/EW2PHUTcIy700DormngE= X-Gm-Gg: ASbGncsX7LTPlNXKsEqG3oo53gsJTN2r3yYzVrs6k3uRgKYUHeQAOuLK+ZsDkAyw/ag clT6o7GmMjgCKJ6r+pKBaJAg9mY0A37F4wVEuYE6XGK5mbneqZ+yJXoJgikSrOldMSFfDwvo8Bl /t0oEekYpPXNsOeTyZadmune+jYnP3YJzLoYRHgGQb0GFGw3qqL0UkPnyG4FUlxL5s4W8o4uT2R AxDT3fFh5uoqpFxgN2A46VPxdLJmtWAlaACMPpA4ivFU9PzMD2iXEL+sw5h/BSRS562uMaAXbIh PW++Faier+2DVHFe1NV6tNZYS3wsYIQFV+uwF5jgGZjjVoK2SlgIIfRXfrHLWPcZq/28Lo0VzPt 4LTE2SkfrVFbEkhgymd4= X-Google-Smtp-Source: AGHT+IGnGoG3feiYTpDg1rm0V+UULmIqyjLhO11TZdSGX9k33joBlyQrh5QuyGGd7rVPLCi3xRo+Aw== X-Received: by 2002:a05:6a00:815:b0:76b:d8f7:d30b with SMTP id d2e1a72fcca58-76e446ef45amr1185825b3a.10.1755238721879; Thu, 14 Aug 2025 23:18:41 -0700 (PDT) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e4558ae7bsm408607b3a.95.2025.08.14.23.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 23:18:41 -0700 (PDT) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org Cc: daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next 2/7] bpf: use rcu_migrate_* for bpf_cgrp_storage_free() Date: Fri, 15 Aug 2025 14:18:19 +0800 Message-ID: <20250815061824.765906-3-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250815061824.765906-1-dongml2@chinatelecom.cn> References: <20250815061824.765906-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the migrate_disable/migrate_enable with rcu_migrate_disable/rcu_migrate_enable in bpf_cgrp_storage_free to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- kernel/bpf/bpf_cgrp_storage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/bpf_cgrp_storage.c b/kernel/bpf/bpf_cgrp_storage.c index 148da8f7ff36..9bbe74cdf918 100644 --- a/kernel/bpf/bpf_cgrp_storage.c +++ b/kernel/bpf/bpf_cgrp_storage.c @@ -45,7 +45,7 @@ void bpf_cgrp_storage_free(struct cgroup *cgroup) { struct bpf_local_storage *local_storage; =20 - migrate_disable(); + rcu_migrate_disable(); rcu_read_lock(); local_storage =3D rcu_dereference(cgroup->bpf_cgrp_storage); if (!local_storage) @@ -56,7 +56,7 @@ void bpf_cgrp_storage_free(struct cgroup *cgroup) bpf_cgrp_storage_unlock(); out: rcu_read_unlock(); - migrate_enable(); + rcu_migrate_enable(); } =20 static struct bpf_local_storage_data * --=20 2.50.1 From nobody Sat Oct 4 14:13:11 2025 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BED9A2BE050; Fri, 15 Aug 2025 06:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238728; cv=none; b=CFYNbeqQttdavLRafeiTtjNSd9lBkYIwtc6E2t9nyI8cUwqzoXACKnMVNW6kUBErItPnGnAJ3TgthJihUBlsjsZ4U+E5WuLwbDbCV0l/n11skg4t0Dp0pg6aF4MvQyqX4YgCMY3ncAzDZVyUX7TTk5SEx4Saotcel94vANzXGsk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238728; c=relaxed/simple; bh=T22DPtA1nAG5+LGr5FSekZ/PqxpR2Uxni7QIRzV6pqc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a9hnsrsn5+u9sjKAuy5s73tRt4HkA7KPy/poFEXgvZ7MEvqZn+pO+knwXfxZbL7Qt7BnhGThrHn5h31mWPNr4ka+dAO49uhxIGH7PSZqDib6TP3C06GA5VhduZaKfbfAnzkhdRVc1nR9tG5+2L0CEr0D44TNsxBxdUSP0IYAsOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m8yNh5KZ; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m8yNh5KZ" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-76e2eb6ce24so1757185b3a.3; Thu, 14 Aug 2025 23:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755238726; x=1755843526; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cprLtrSY5oTLdOA8hqkm/jLoYOshGMqvofbCfe4vh9g=; b=m8yNh5KZcyRQ/wb5k8eGJBPusxeeodcx197lfDpISNVRnLJ+OEpUA6zptVySCa0OSZ VXe3L6n0YaE3eQrytxa/ZOashbyO2hcnG8gfxJUm1nuggYyIy3p0bI1j13VvHiFA9pOF KH69oNo4Yk8AVihqN7WaD8VmvAymA1obwfeFgnCS+jiH/FM8qsTtJjL7SgCq3vRpRnG+ C4A8wYvWnV4G7w5adP+SC+mHPwiRIFW/CSOL4qHTWH3/1m53bi9SUTZOPHyOIWcCx/Xg 1ssDEhquMeaVeefvgAqkTmHI6/PcdffvD+069Fy+J+gFUQEG2cqBmG3nr82wJjVzGNyy 9a+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755238726; x=1755843526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cprLtrSY5oTLdOA8hqkm/jLoYOshGMqvofbCfe4vh9g=; b=MamwqczShl5YGvt8TQhbAOnc3poWRQPEdgIgaldiQZQMQG+sL7GWdp7w2SSFOSVb4e AkdakTNXxU65ClR52zhnPEhAtSO5rM+jqw1dMrXEiRUAXslPoPtKdAe6WV78yZBDLCkn JwUDI1hO0edsbazHNopMV0nb+4InYg2gcP0Gg8vocPHcJQ5cbkWsYwGFWGfgTA4zlEHR krnksG5ngE+T06c1ThaxfduYxsnhSE8MfC7YEY8sugaMpipnVStKFspGDx6FoV/vDqZ2 qBSAXvq6L98IlKKBVvU7O4m6rPBrZseuOK3bvXpHY6WUXjcK5ZvD174VZDbitn2QPHem CkNg== X-Forwarded-Encrypted: i=1; AJvYcCVnKcwnEf99Wlc9+vK1UtUz3TaslfH9EcVgA9xjU4gAP7c/+ftqBrzvQEJpMx9PlgP+Gxk=@vger.kernel.org, AJvYcCWEnjByg8gw1HK4tiLHGZm1cRqjzNJ20nd7jNZe7/HeBaSwmsSrnVZBGK4Q/wtiKQUU8jjvHP7pyZwQGuSM@vger.kernel.org X-Gm-Message-State: AOJu0Yyn48/Y8C4HfzPm4nefjMuFN+2eRDVt0mm8zydKFWeuZ7OM2u/r ZShL3O5VmjY8yT1XCbhMnz1x2Y/TFFbc5guoO6nbNHDW7rOZMySeKQoV X-Gm-Gg: ASbGncsJPIwAObt6x7r5DeCLr3QnXc7QQ4meO+RHIETbqQAgL2OfgubmlQ46k2tz4rA K4kiwnSyAvi+sdYYKa0LSfRN12ivC79qdjdD64d3e1RK3N5F8evh4KGRWe2V1tqnPPBayi2qm8M qrA3jVX015Y0pjS0ctaIBeqJnJ7YPrtPaeeDJngW2E5GRV+Qhbv66GjEhYYi0aE1CyLzDJlwZEQ 7/6fIXWtG1u2Q44snoirXmHUw3Enkfsfy2seOZj8ekbUP0U2PP8M6jGtHlVRiOse5Sqd7OsUFLz Pw42BG1DaPDreWYpotYPy9risDSfIqxQBWy/JwsbRw3SU164YZ2reB4RLv0r/4Wz8IOZyP5sE15 jHfq9oNLYAHhYMSJPQeRuuJZlQXjSJg== X-Google-Smtp-Source: AGHT+IFlnrErxT4MaYx0fW8YAEISQn91gN1oAGB1cwj82YyqappOfkoRJ/ANUgxJt0FIkUsm6ACfNA== X-Received: by 2002:a05:6a20:6c89:b0:240:2473:57c5 with SMTP id adf61e73a8af0-240d2ecc720mr1253707637.26.1755238725989; Thu, 14 Aug 2025 23:18:45 -0700 (PDT) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e4558ae7bsm408607b3a.95.2025.08.14.23.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 23:18:45 -0700 (PDT) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org Cc: daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next 3/7] bpf: use rcu_migrate_* for bpf_inode_storage_free() Date: Fri, 15 Aug 2025 14:18:20 +0800 Message-ID: <20250815061824.765906-4-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250815061824.765906-1-dongml2@chinatelecom.cn> References: <20250815061824.765906-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the migrate_disable/migrate_enable with rcu_migrate_disable/rcu_migrate_enable in bpf_inode_storage_free to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- kernel/bpf/bpf_inode_storage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/bpf_inode_storage.c b/kernel/bpf/bpf_inode_storage.c index 15a3eb9b02d9..548530feb4da 100644 --- a/kernel/bpf/bpf_inode_storage.c +++ b/kernel/bpf/bpf_inode_storage.c @@ -62,7 +62,7 @@ void bpf_inode_storage_free(struct inode *inode) if (!bsb) return; =20 - migrate_disable(); + rcu_migrate_disable(); rcu_read_lock(); =20 local_storage =3D rcu_dereference(bsb->storage); @@ -72,7 +72,7 @@ void bpf_inode_storage_free(struct inode *inode) bpf_local_storage_destroy(local_storage); out: rcu_read_unlock(); - migrate_enable(); + rcu_migrate_enable(); } =20 static void *bpf_fd_inode_storage_lookup_elem(struct bpf_map *map, void *k= ey) --=20 2.50.1 From nobody Sat Oct 4 14:13:11 2025 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECF412BE7C6; Fri, 15 Aug 2025 06:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238732; cv=none; b=iAps0kw/kMo1UZbo6VnRAOqSnwx4Kcojd2o71+pyRP4c5Hqr9RAchACWbNYYw14Opi+HfuTgzTnQetG3iwyZ5VEfwdAu7YwJo0C+S/+fCX5Kp9HuXl7Rc+LkBdrBkuDsCtSuh9b0/uxTSXQaDDzkzAz3xboYlOe7sW7j/w+DSSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238732; c=relaxed/simple; bh=LJbi4L24gEu0az/1z7pD+rs3U13DbjUe1venRbLLgTg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fpI89wRJcQ0IBMV7eDeNt+xTrE0IGW6EaZFXk7lxJQV0Wq41v6YaLxBUo3G12hIsoGGfbw6YxPqtV+dcpDyzMStGae60ebXEy3Zfhdzm2Pd1m/bOxAa48f3zk4vJuu9IFwlbm7MwA0PzbrPHkzMbP51rBrRK1Z01L7dJDJrBpdU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TlF1HejB; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TlF1HejB" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-76e2e8e54f8so1579367b3a.1; Thu, 14 Aug 2025 23:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755238730; x=1755843530; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RFjBsyPuuZBism1T3uUGuz3NQdntmw2nABEsJnLMNB4=; b=TlF1HejBsdQKoqyxUmBUoB4I4pEt2G3+nYUEL1piJh+9pm9zCNoeAFpuACet81y2m+ 7akhFXz93MFg1lGZShc5rKE7cj3HfUBaigQf6usrjhCCbkDTO+h/TpzO31ZBsDDvfDnx iIDRLcf3raQHAWbgWRr/FA6mNRnkuKay9AFAaEUrxg4Ku676ycIO3Kt8y5JLrSOX78H4 QSFBkDu38pakY/QmLxKcGVKWReE/XoqodKmyLj3AGYRdOZMCv7pEb/xls26N5uRRkkHF +OWNBzaIHQqRTbQyE706AyAKPNq8YrgcYzExbkSMgfhaCR1FmCmNhuN5I91RLELZ+dTA ayXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755238730; x=1755843530; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RFjBsyPuuZBism1T3uUGuz3NQdntmw2nABEsJnLMNB4=; b=cKwfJUZJ7w3UWs/lSzxgcDrrZir5EXzKYnv9xYW/UMRQXgCzX35Ys07+Eo/ws7CKQf eYCAf4Tak97nA3bNE+L0SYMsnq1Y+5FLsyPNe1koLeg7uOv5S+0qBDoFhJ4Jlrmix3ec e4WXjKHd9fhktVx3KGL1iIbEMC1bR83/QQUlpUHA42bOecbDLHc+0JRcaF6FRPnAx9rS wIDH3lAvhKJz84kkQuVPMSBakAssC56cAM8+WtHvmj+EqnUVSurp5tqP6R/WA7wnEOsh Z57sAzOT9uMqfKTybONZfcgjKaKAv4quDTxgVuiQrrB+MAx/sseVezVwZs9VnPBTMy17 7gdg== X-Forwarded-Encrypted: i=1; AJvYcCU4HVlyqu7Roh5VTi1ufNsBZnpIgKst71khkHTi0OTFnMWIM7zo84Bb2lUEuOICfBiCDqpPGx1MQWnGVLgg@vger.kernel.org, AJvYcCUlmCw1DeiNpzEW0YG8LhQb5mbzH/RE36GbVWq2qWPZ2AiHyIe0XtvB28e/1fm/QLgqYoM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+Rpvs3TgbZUdff4DbCt050d9H/AEQjGXG2Iv6TEh78HqsMaKe U9o5dg0O6d/HO7Z8Qqxt41LSaWXwMQkPaDgdAk76CpTqQ9PdmjsR970A X-Gm-Gg: ASbGnctBzmRTmBsYWpiZh7PtCdlaRH5XQhTkKSpRzQYTIJklkk+UlHk5ikOaeya9pbS qqXTuYKLXE/BaYwyK5K0L4DX089p86CH4et0LmKYE2vFkYRnwbg54xkooSEtAw7j78EWpc8+Af+ Ttjj5Ryaf36ZjN0sCULqg2IZyAEAsxNnByBbxim5g9Uovc2nhHcLNU17qGIAM+ADG6yNmIqwmvu z3FEUYdqlfmrUvEO5zBxFEJ9yGy+YQv4Q/giuvmHPa7zVRK41qtKus+ks+L/nydVQ15gKv2dHgE SWcHyMj387/E1ahX1X4kiOk1HwG6POC/4H9/xKhlhAU7jVsfIkljhg0uj3RcoJ2LkGChnnDaPOE /Bj4hFEUPr6g0aFyx/d4= X-Google-Smtp-Source: AGHT+IHGDVizASD9lmRNMdvyotuifXOUcouob918/gVKDUl8lbfI+jfgXSo9/j4zEPp6FtO0H17xDw== X-Received: by 2002:a05:6a20:3947:b0:240:195a:8324 with SMTP id adf61e73a8af0-240d2d81728mr1606846637.2.1755238730153; Thu, 14 Aug 2025 23:18:50 -0700 (PDT) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e4558ae7bsm408607b3a.95.2025.08.14.23.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 23:18:49 -0700 (PDT) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org Cc: daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next 4/7] bpf: use rcu_migrate_* for bpf_iter_run_prog() Date: Fri, 15 Aug 2025 14:18:21 +0800 Message-ID: <20250815061824.765906-5-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250815061824.765906-1-dongml2@chinatelecom.cn> References: <20250815061824.765906-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the migrate_disable/migrate_enable with rcu_migrate_disable/rcu_migrate_enable in bpf_iter_run_prog to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- kernel/bpf/bpf_iter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/bpf_iter.c b/kernel/bpf/bpf_iter.c index 0cbcae727079..25feb93d44a9 100644 --- a/kernel/bpf/bpf_iter.c +++ b/kernel/bpf/bpf_iter.c @@ -706,11 +706,11 @@ int bpf_iter_run_prog(struct bpf_prog *prog, void *ct= x) rcu_read_unlock_trace(); } else { rcu_read_lock(); - migrate_disable(); + rcu_migrate_disable(); old_run_ctx =3D bpf_set_run_ctx(&run_ctx); ret =3D bpf_prog_run(prog, ctx); bpf_reset_run_ctx(old_run_ctx); - migrate_enable(); + rcu_migrate_enable(); rcu_read_unlock(); } =20 --=20 2.50.1 From nobody Sat Oct 4 14:13:11 2025 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F23AF2BEC45; Fri, 15 Aug 2025 06:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238736; cv=none; b=ZDkSlaNmB9+Lwf55MKhI6hTYtPymb/WVpYjkJRrPBgasnamC6uommxp1vLDfK55RicMNAxP84ML/eJe6HjonwGhovta5n8rWinh7om3bHWvc7kT2zvlaiIhXtKItoVT+jk3fxj+Y4LYkQ8mvyt0tc1M/aRe8+r5GTkS9o8UT3B8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238736; c=relaxed/simple; bh=NsTLfMZJHJXpCLXkFepb95eQuuVS8RrXqUe2lWsYzoU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CRb1faFUUQBrTC1lTb9hCTN9JtCJGerM/eOuZfwnl3zlAfXqrghbD1yJDgtK9tgrZJOqgtbAFex8k3xCUm0BapiZrxWhvjn0C7e1TByPnNAqYXcC1RLaZVEg4v8DFqtAQSddpPw+ESyhMSCg+Uoe4UhW9B68d/ERR5R+ulZYhgA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ru5hqTH1; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ru5hqTH1" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-76e2ea94c7cso1608327b3a.2; Thu, 14 Aug 2025 23:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755238734; x=1755843534; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x9UFGo56n/vlzyp05DMGHWO0l7I4ZKS8r+x7sWODQkI=; b=Ru5hqTH1e8PeSf06TiBOBq2Osjsnjxex33Zu9+4VIKOx/oAzv691pAFqvEf/OuTlBT /FOmQVZu8htNLctKcKjHd/9yffxovsrqdelMw+YchaeihWrv53pDaKQOfWOm2zWsIwFj hdGHIApDp7e9LvkzDf+bRGT6U/HIe9xAlBJPSHK3Z4b7WfRxTmKHkDsx+r/dvNBUfiHY F9gRVovtUud3LrbVm0+4SCjydnEK6UObkVQYHKpwpc8/WlU3GRI7t346ujAvztiBgOBj KdYHRnaWPvZ/55qLzvSdE3tVP0CYS6je2NwIHU1bnkt2ekkAMnez0UAJ1EY3jA9rtTKu FmTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755238734; x=1755843534; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x9UFGo56n/vlzyp05DMGHWO0l7I4ZKS8r+x7sWODQkI=; b=aIF7HriAY2aGCPUDFLzhv29uCwSFnE5A3zZT5iBOSjXAh5/ZFXRxDCDigRX028VHsL x+H7wc9VrgZqbjfrEXj+gXJpCOpuB2dU6L406vIdqCLM+vr4kwlCLOt/Y8duntA+K7sE 7JEFynK5BI7wu1J+8FHfOY8S7ay5pIIanj+ubytSHoyC1/9nmX+2DQgDxWA7hbffIg1v qThYc6SfNliKyieTHYBWWpOVDVHEu3VryQ5ai2FBzKOXgBH9VLVQ1aC9qek58qdrb8ox xuAXz/pnYeUeTT75uoYemU4b+JsFQO8g04tBWnKMkTS4e7P3m70smMFfChS/0pfzUOcp 96eA== X-Forwarded-Encrypted: i=1; AJvYcCW+PmvK02T+jVa1dLfknhttdXxs6xx0IlKgypvr96LFQsLk+PwSCeBjHyFwLksrEYLJWJ8qAVNuvCXaN0ev@vger.kernel.org, AJvYcCWhaBEhT9C2uegWWMXQA0aK7HMzCjRoXY1szBn2n2Rl14i9nUyt8R7r85V28ppdbpOcq8I=@vger.kernel.org X-Gm-Message-State: AOJu0YyRYAjzaeabeG5rKDPPL1A5rLyQFWRHtqRejPtgc32sN09P9RqQ zn9SE6in04Bm83NFUgKuC16K1jqPqfARQlU5jb9MndC6ltAjr2czYJMaSmZ7G+v/SuI= X-Gm-Gg: ASbGnctwxbWJICXFdbgu3RQh2MFS4XdfmmXO31daYrpxC9SPp7vVry2z2DCaxSX8jyZ iqdJpNekSgvU/oG0RqRp8HotyvvGHOtBT2m/RTp1M9p1Vwkjyjp90pHG0iGleLaAeH92ZuW7nwa 9RTxqN6Q2BxA5gTqxprUr1tYdT6xrmc0A34LV5LuPXkuf4xMpY+yqZZUxJmnb6JZQ9t89rRWaXr L+KrjCZWRl46e9VBxSkd9X3wYQULtiAv4vGe6O+9LSE6ZuAvhQNDDIPZYTMqjfm44GJNScjfndo 1RjJbUF0WcpJBHdw0bRjhMkwMUHnr174VhXTHMQmilWk8WU22rq9eFSmC5TTdfs3j7a1CgCPGUP QuuygJ6CIAqQ9lydAafc= X-Google-Smtp-Source: AGHT+IFXvxzrWpGs+BsYWvc0w4oMbPxVzgIDu73nUQLenBzwZeujKkQmCCKVbkNwqlMgVGmraBj1Ew== X-Received: by 2002:a05:6a00:1acc:b0:76b:ed13:40f5 with SMTP id d2e1a72fcca58-76e447fd3f8mr1409114b3a.18.1755238734294; Thu, 14 Aug 2025 23:18:54 -0700 (PDT) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e4558ae7bsm408607b3a.95.2025.08.14.23.18.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 23:18:53 -0700 (PDT) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org Cc: daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next 5/7] bpf: use rcu_migrate_* for bpf_task_storage_free() Date: Fri, 15 Aug 2025 14:18:22 +0800 Message-ID: <20250815061824.765906-6-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250815061824.765906-1-dongml2@chinatelecom.cn> References: <20250815061824.765906-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the migrate_disable/migrate_enable with rcu_migrate_disable/rcu_migrate_enable in bpf_task_storage_free to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- kernel/bpf/bpf_task_storage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/bpf_task_storage.c b/kernel/bpf/bpf_task_storage.c index 1109475953c0..cbbf1b72eece 100644 --- a/kernel/bpf/bpf_task_storage.c +++ b/kernel/bpf/bpf_task_storage.c @@ -70,7 +70,7 @@ void bpf_task_storage_free(struct task_struct *task) { struct bpf_local_storage *local_storage; =20 - migrate_disable(); + rcu_migrate_disable(); rcu_read_lock(); =20 local_storage =3D rcu_dereference(task->bpf_storage); @@ -82,7 +82,7 @@ void bpf_task_storage_free(struct task_struct *task) bpf_task_storage_unlock(); out: rcu_read_unlock(); - migrate_enable(); + rcu_migrate_enable(); } =20 static void *bpf_pid_task_storage_lookup_elem(struct bpf_map *map, void *k= ey) --=20 2.50.1 From nobody Sat Oct 4 14:13:11 2025 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D6642BF3C5; Fri, 15 Aug 2025 06:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238740; cv=none; b=JSHmW/Jt5pErxqSM23K5Da0+4ewgy5vNXbmsK8lxRTCvpuGQ+p7akjNRYpZJ8EiE01OwJUtHbGT5jFDgWCTP/dPNipFhzQoAk7eVD09px3XBHuz58LRl0PHkxn/NMs0RLKpf94Iy+kKiyMixaWU0gCeBnP6DT9L7W8NQ8SPTck0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238740; c=relaxed/simple; bh=SNruwWdpjfWXEUmdcJGLbAJaSFT15pLLauu5/KGhBA0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZjpVcBdVcSywnh785F4+AEHTV1tuFjnBcUp52U0xPaj1sVhGmeUzfuT1+co4CGvRJW2wiyAS9mBB6rwRVoqYAXsyf4ZgBYynfj91gkXV5m6snaUeXuAHp2R3uFz/EoWDPvTNuc8KCFOxPhg+6umRYNV8aeSFL9WVh+onR8H2IrM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BrPKInVY; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BrPKInVY" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-76e2eb4a171so2366853b3a.3; Thu, 14 Aug 2025 23:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755238739; x=1755843539; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BxDb7VtzlRm5Ny+o2TRQ0jpYfl6LPm/O+U74ZNbAScg=; b=BrPKInVY0Xo2BDfAi+FWeNsxr8aJtuaMJ2ir0hdw8eecZFeodXJOjqcgK8lbAov1tO 3YtGMtx0M75+XZ6vdhcdKl+c8T1i9OhpuYm6hLh3R4oobKrePHlPSRxZxKeHtu+KN3s9 //1m+kt2CwOry1Kw7CQ2oHCz75caXSiQuf0xOk63M594VGMQpI7zH4F23UPUvmy5ChHq Xk4+NYwtWpeiiZjDRKSo4MQsQbdaEpjBmY6gxk1N+/XN6OCgRqZen8UeUPZp/Rif+uK1 eNPb3vb6o/KmYindXc2GQIHRQYsmf0INZtm99azFtfoec/ugqKteDDHgMpdQ/0GSpyv8 Hthw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755238739; x=1755843539; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BxDb7VtzlRm5Ny+o2TRQ0jpYfl6LPm/O+U74ZNbAScg=; b=IAEFu6Nw4tY9zxgM+Y3EIJwNUhbBNwZ2z5hOYYxQVp4F5+fVc74OHlObQwYAS2nstA z11zOUeYuna73N7GaaL+rYSeF0PDHtcAU2Ysb6t3fDsDk2hEBbFYBBA7EVY2f/WSsZRG tQD23v9qYJPnV8tuowodUFVi98mXpaBxz5w481uPbKCrtrj6INqyB/fs84riBch14n7m KGteO78rVNJ4AzrKfeDcJMQkK5q+4TZdWVT1//iA+kT9JffGj5U1pK3Na6Y97fdURkxZ 9QH1DRoZIXl7o1TJDgv0MhkC7wubzXRrqywkimLgCS5XhTLccAgICd5qnAEaUK7z0/NU ncSw== X-Forwarded-Encrypted: i=1; AJvYcCVcbziKN0N0V0NCYvB0eAic9P8KdQ4A+T7YGr9nq72/q6ojHev01aL+RAIoSbSY7y0+JRYwEkdTZ1v8cn1b@vger.kernel.org, AJvYcCXHcR4UgL3u204DgoHqQt4TC8JMwhjrpe4zTa2syLjMI3PinE4/k8UTErTQ6SnRFG35/Kg=@vger.kernel.org X-Gm-Message-State: AOJu0YwGB6i6XIWfGt9MCu8M2yd+a+edMInPev4+zYllQwMxqwFW/P9T dpHtt6tGMyHSaq+msom9sM2csDd2Z94UTMagAV+Uw8LAHLJHsaX/OKmG X-Gm-Gg: ASbGnctL0SiJ60heBQp6Lg9K8BBqJG0neXwVUpzIfxZB2E8oXOLvYW1GW0QagpmqZjG cws6XOWjjsb5TMn/6brWaZbQxacdz+UcDRGMjJG01fYqRVRIYYlBaLRqK4wuQH328Dcbh123DwO eBu3dy5yIAemgGLOhlTTc8s5HtwH+UfMHTGsuNXYzVAubnxgBkcdPPPQhTpXvF7YQlTU1AYMt4w E4mclz2HCF1EIMn8TaYSb6Ae40gKksYguikvqkGpOzqbEojqe4k5jUEhrve9pU/wSYJegIseSg5 zHjLuP0zmF7+Kpr/o61Vb7TF0nPHnrQRmU6Bd2E5ceMF+HNibCE/vTscnqEs6c5wiEKM6f7nBPV Q40zUPzJ9twX+TeiJhHQ= X-Google-Smtp-Source: AGHT+IGHzJYc1b8aDYJWk7Oedt+80knVWvfTd5tT3z4XLOl2atN3JAUuQkm707sPiHl14JZtY/hoNQ== X-Received: by 2002:a05:6a00:4fcb:b0:76b:f828:34e4 with SMTP id d2e1a72fcca58-76e446c575amr1104030b3a.6.1755238738586; Thu, 14 Aug 2025 23:18:58 -0700 (PDT) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e4558ae7bsm408607b3a.95.2025.08.14.23.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 23:18:58 -0700 (PDT) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org Cc: daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next 6/7] bpf: use rcu_migrate_* for bpf_prog_run_array_cg() Date: Fri, 15 Aug 2025 14:18:23 +0800 Message-ID: <20250815061824.765906-7-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250815061824.765906-1-dongml2@chinatelecom.cn> References: <20250815061824.765906-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the migrate_disable/migrate_enable with rcu_migrate_disable/rcu_migrate_enable in bpf_prog_run_array_cg to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- kernel/bpf/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c index 180b630279b9..694635699d46 100644 --- a/kernel/bpf/cgroup.c +++ b/kernel/bpf/cgroup.c @@ -71,7 +71,7 @@ bpf_prog_run_array_cg(const struct cgroup_bpf *cgrp, u32 func_ret; =20 run_ctx.retval =3D retval; - migrate_disable(); + rcu_migrate_disable(); rcu_read_lock(); array =3D rcu_dereference(cgrp->effective[atype]); item =3D &array->items[0]; @@ -89,7 +89,7 @@ bpf_prog_run_array_cg(const struct cgroup_bpf *cgrp, } bpf_reset_run_ctx(old_run_ctx); rcu_read_unlock(); - migrate_enable(); + rcu_migrate_enable(); return run_ctx.retval; } =20 --=20 2.50.1 From nobody Sat Oct 4 14:13:12 2025 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678BF2C0F6E; Fri, 15 Aug 2025 06:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238744; cv=none; b=EP23stiJ12FPq57tCpzUS7sYwgeDmNy+figCbYtf9HVdbUEHQpLyVWfnE1qGEH5H3JO4AlHF5P1YnTAbLHH9E9EphhoaC3VrFet/Zr6xuK+vRc6pxMhB7dezDiDsqRH2Pyb70lsFlHrp96R57VDzFv3nUPpt/lUQ095cr6MJE90= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755238744; c=relaxed/simple; bh=SUj70jwKD1YJWvHj/lmbBVeF62EZ5vaRAX/pOH2XWOw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PLUu5vvIIHFN9zHe6ghkh9x5DvCIdqR7am9Js5dgT52v8+k9FMNcdZ6gS0tJStCzlrG40BFAryBptCwKzwHaQbJMisuM4+Xk3nk6x8V3w+6uOqwvjO19jHD1QP9PvTDpRdFllfMLjFFgXGIJAcur5I+4cgKgXylKgWQdrTGvDb0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fM74U2gp; arc=none smtp.client-ip=209.85.210.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fM74U2gp" Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-76e2ea933b7so1665596b3a.1; Thu, 14 Aug 2025 23:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755238743; x=1755843543; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=biaR6krtJBdyRWUCr4TpqQjC9azJSYTfDqHuCAG64dE=; b=fM74U2gpJzENqaOmMaZVy6cUgV1F0qkf2mkhOr+Nr4pU1kClgy+tPwBzd+7Y30bZEt 5tl6oRadqzbQTnmDVXOljV5hEvjdaDXkzMntGmG0XlCjaAmAum8Xcygt29kssKgIXydF OL+08ijuH6nKKNhK6WlnVaounbbe9sj1aiRWptbKkzipijih1AyY9AdqWHrKzsdDgcvq v0ra1DYXlrHxXae1D4WTtQC1iFXw9EJkXlA6IUUYhzhw8QhuQhb5MKWfb8q2JOy5QoiX 7uQhcW0sZF9sDT7Rdv7kwq+LwKXVakVcqPCJfuNwCP118HNUhHG+KTdhcxzVuUnDhzeE uCkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755238743; x=1755843543; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=biaR6krtJBdyRWUCr4TpqQjC9azJSYTfDqHuCAG64dE=; b=mULXJS9xga6e1zR+3c2pOjdBZFumT0N+3bL3i39100La+a2kbXGwhmZlmvUh8dZf6W nDCYDBV/4L0b/bhuGshzhcwY+OgSeCP/5UqagZlxyEMTuzb3+0cLk6zsTws0bDQJVS1V W9rheIg0Necodh4AcJm25ASubYjwYkFbnHS6GCC0Ad7O6byR619Z9AOb/0zv3T7R3brm nemkX0dbkSJW++jr4v63V0WZOk/LbFn0033bPCqyrpa80d5030Q/AoJSK5dy2it3Yxfn AJw1vV/XWqtU7qUdhsKcofAIqAFJ7BGE6BYKm5md3lTo3qGaXKtS/4uWHcvVlChQp/bX hx5w== X-Forwarded-Encrypted: i=1; AJvYcCVU+4TJRqhUKnafjq0gOuWnu9X8hA8q++OsuvgKi+Z0EOV/xaGmVqCCqFBfiNVtKJMdrmU=@vger.kernel.org, AJvYcCWEI2vcwS7v2Crswr8PERr8rLsoApVRbSl5GNik07o/LlVnEuOJ4Us4XDR86x87qu8HoSCpVd6CajMTs0lW@vger.kernel.org X-Gm-Message-State: AOJu0YxfvD0TC/MeJfEHKTpcidsgC+13xAaqO+3Q05UE8vow7WJB2nO8 4FXFQNyPFkBRvZRlVC1fZPPYU53i/xrndSVo92k1XmzFawpk+IABnisN X-Gm-Gg: ASbGncvjBqbixjkqYyTfSMZOU6r2AvqPVmgiAgDMjtDljlhUigcuLJBMoxW/oErTx9C VUlKCvruX6sfnQxeefSVeTI2PaNsMPgQ+KWNV67Sl8dCijzV5iHsquHekCaz8obQa9cKXUQ0Njs 66ILVN/4jrMvwSktZWDZnBXYfnJlwHLUibU3aaxXA96itdn+ZFExnKuEX/z6VwvzChA8oKkVZZM 3gpRwqJQCzrbiSVSK0fmV+EDennO84k561SrftwOZ8f0jQQRlT0+/xVVktBIVNtINaloWj0avGr wvlg3lw8Yy/5Avot1SoBsVtA/OcbfLDhU8hBUejAorCTpXQdQz0Pm4BbqQDF5FAAMR6HFzpOAdn 5V0YedddKc6wcKttvmg4Iabpa1XW33A== X-Google-Smtp-Source: AGHT+IE27qqZar5VEXjDF36q37jqNIiBeBtrvOFfZ4MxCuj+OiymsPKpASTZhLqXm/licsP3jYZJjQ== X-Received: by 2002:a05:6a20:3ca6:b0:220:898b:2ca1 with SMTP id adf61e73a8af0-240d29c7302mr1798883637.21.1755238742779; Thu, 14 Aug 2025 23:19:02 -0700 (PDT) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e4558ae7bsm408607b3a.95.2025.08.14.23.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 23:19:02 -0700 (PDT) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org Cc: daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next 7/7] bpf: use rcu_migrate_* for trampoline.c Date: Fri, 15 Aug 2025 14:18:24 +0800 Message-ID: <20250815061824.765906-8-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250815061824.765906-1-dongml2@chinatelecom.cn> References: <20250815061824.765906-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the migrate_disable/migrate_enable with rcu_migrate_disable/rcu_migrate_enable in trampoline.c to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- kernel/bpf/trampoline.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c index 0e364614c3a2..a0608152c394 100644 --- a/kernel/bpf/trampoline.c +++ b/kernel/bpf/trampoline.c @@ -900,7 +900,7 @@ static u64 notrace __bpf_prog_enter_recur(struct bpf_pr= og *prog, struct bpf_tram __acquires(RCU) { rcu_read_lock(); - migrate_disable(); + rcu_migrate_disable(); =20 run_ctx->saved_run_ctx =3D bpf_set_run_ctx(&run_ctx->run_ctx); =20 @@ -949,7 +949,7 @@ static void notrace __bpf_prog_exit_recur(struct bpf_pr= og *prog, u64 start, =20 update_prog_stats(prog, start); this_cpu_dec(*(prog->active)); - migrate_enable(); + rcu_migrate_enable(); rcu_read_unlock(); } =20 @@ -961,7 +961,7 @@ static u64 notrace __bpf_prog_enter_lsm_cgroup(struct b= pf_prog *prog, * programs, not the shims. */ rcu_read_lock(); - migrate_disable(); + rcu_migrate_disable(); =20 run_ctx->saved_run_ctx =3D bpf_set_run_ctx(&run_ctx->run_ctx); =20 @@ -974,7 +974,7 @@ static void notrace __bpf_prog_exit_lsm_cgroup(struct b= pf_prog *prog, u64 start, { bpf_reset_run_ctx(run_ctx->saved_run_ctx); =20 - migrate_enable(); + rcu_migrate_enable(); rcu_read_unlock(); } =20 @@ -1034,7 +1034,7 @@ static u64 notrace __bpf_prog_enter(struct bpf_prog *= prog, __acquires(RCU) { rcu_read_lock(); - migrate_disable(); + rcu_migrate_disable(); =20 run_ctx->saved_run_ctx =3D bpf_set_run_ctx(&run_ctx->run_ctx); =20 @@ -1048,7 +1048,7 @@ static void notrace __bpf_prog_exit(struct bpf_prog *= prog, u64 start, bpf_reset_run_ctx(run_ctx->saved_run_ctx); =20 update_prog_stats(prog, start); - migrate_enable(); + rcu_migrate_enable(); rcu_read_unlock(); } =20 --=20 2.50.1