From nobody Sat Oct 4 14:35:21 2025 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 112DD22FAFD; Fri, 15 Aug 2025 04:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755231703; cv=none; b=tCqveewIAbWzW+mfAtE/WJa/uxpdTX8v1HRwTiaVXii1G0q1S6RU57E5y8cRhoZxRjYmZh0A/l1bJQUTPyDQHCRq+aDbAwPzOP90BeKBPYeE0N0MQ41f4crFUhx2M5RiJe5mLHJIt8PJtOrX35gubWi4l/UD8FsMkykcPwoTESc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755231703; c=relaxed/simple; bh=IkJp91E/55DupmuvLpEkYBgYYD4Won+UDcbvNLHgmfo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dK2GHiOqYib8r++BoVNdu94ll0057FtfKUXek2hmXDADQc1Ms9ZRGWeOx0Tw9TIEbsuU5xa/geL0ZIhld/wOOo7WQlkFR8XTN9/vsnMf/suyZtYjd1rPr2T+Ob/Y2jE+aAzc4wseUTHyVDImwb3nh9RUFqjMb6Mt70xtEPm+8KM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WXN5d+Jh; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WXN5d+Jh" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-88432cc7058so47101239f.0; Thu, 14 Aug 2025 21:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755231701; x=1755836501; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rlEaJjXuqoZ1HAzBjMXk8fek5DSH2Rnu+HHF/ZX6DPI=; b=WXN5d+JheLVhDp9T/J/TF1n2WSRWotw7tBF++Gfqm2jqUIpkP53CIxZq7eTHWGSUSX 6xycTqkhS4XPvUixtTk51AdSbYmZaq5et9S3u/Wh24F5ARU56SGNrnSe6/Y7sI3TRbFX oHOlTgBBCrdCz0MgvwYO4gSnjQR0OcvP617ywTRjWUTWDJ8vRp9anaN6QZvfMr+Ec4DY IO/mPKUuMIg0IUws02og4kPS86ww902jPVRRNKLl/nCbVvVKvnFzzbWL5sIV76vW+Qdj W6p8Gq/rJltapLgRDglCK1K1er7N7LIfPB0o/Ybeta0Orxh4W8+4loqPGWg7pkHakdvG itvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755231701; x=1755836501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rlEaJjXuqoZ1HAzBjMXk8fek5DSH2Rnu+HHF/ZX6DPI=; b=Xzt3ksGez3smlYljBrGXs+V5LfyurcA4ASKinfn/horhrasmmMktpciklj6HHsvnah 38607Zp6mzQRo84gn0412FNDy5+T+2N4WkRMIvs4NS3wrcrTEMzxXWMfL7EsyYSQ55i7 MVsw0WVCl7F6fiw7y/502s9w4YL+Gd4gA2NDSBBfhn1V/OEtuZjvofrlct5UYzcsMKUk 4VGry3pXUEZMDSEiwHOyXmpsvuIWrhvBulLxBx+xmH1lhbd5vDtv6QReErb5IldRYNqa mUCqzLlD57IUIR9jEeC27RSX5OjboARuCB1HyfKhmuGbD4YEQV9+rw1LBBrH+3jBH3jy bKXQ== X-Forwarded-Encrypted: i=1; AJvYcCVS1q6DF9L3w9hC4tCGw6rDkyoEFSUp1HgIb6YxHN2OoTHFmBHWAvLvILmLYz9v6yrSyt22d3lMs69h1Ac=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2cHnPHFjKnReg303Y6Ck/nXaLWc4RaJCpKcAFamOcTiOWb5IP VJ9rIWRBz+5sh5YSAOfUdFLNIxLawKpRC62w9QZDNzY0+uMoYNu7Kh6x X-Gm-Gg: ASbGncu0SgI7ghyhl2i5M8cJfuPSdbR0lxLs/0Szkzcc0Tlyg+DgQg19sFdN6AaBIK0 ovxmmJzdmGRCGlRmb09jnAQUqcxhhMgy95wCX3UYQL8aZoay1kXomS0o/pJlkffPFeY7J5N8joj urcex4OOhQJEhFXwThkD5HfEC+gU5XN3opmfRvyOPRpWh/Q/dxpxZI75SxwaXqkFo1q++Zg/cO1 cAi8z0b9ZLthf0bDhioNRSxoxAimgyvdSHtloSwpD72l/Q0kdgFRzDHj/2x3BOAQACX/yKvilTC r4M4ZxOJRihFScA5xAbolhzTAH3J27Hty4F4WYfhfJsXXhy68NeFn+as/pjelzXtGym4tTVr+IW +gFq/apRFMN22bV0gSvemog810DE1J7VDo6rS6JA66MWjgfpGn4K/9edvANHIfxUTHhs= X-Google-Smtp-Source: AGHT+IEIJY5yuuiRjS3rmxW+Q4bh6AhCH/5DK0O/b/9BcnO1EB5P9I1mqCzp66//AjqmuCTsfBOb3A== X-Received: by 2002:a92:ca4f:0:b0:3e5:6882:6604 with SMTP id e9e14a558f8ab-3e57e8a7acfmr12847365ab.15.1755231701056; Thu, 14 Aug 2025 21:21:41 -0700 (PDT) Received: from localhost.localdomain (65-128-248-47.mpls.qwest.net. [65.128.248.47]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e57e5a585esm1689365ab.16.2025.08.14.21.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 21:21:40 -0700 (PDT) From: Shimrra Shai To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shimrrashai@gmail.com Subject: [PATCH 1/3] ASoC: es8323: remove DAC enablement write from es8323_probe Date: Thu, 14 Aug 2025 23:20:21 -0500 Message-ID: <20250815042023.115485-2-shimrrashai@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250815042023.115485-1-shimrrashai@gmail.com> References: <20250815042023.115485-1-shimrrashai@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove initialization of the DAC and mixer enablement bits from the es8323_probe routine. This really should be handled by the DAPM subsystem. Signed-off-by: Shimrra Shai --- sound/soc/codecs/es8323.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/es8323.c b/sound/soc/codecs/es8323.c index a98229981..194720e4d 100644 --- a/sound/soc/codecs/es8323.c +++ b/sound/soc/codecs/es8323.c @@ -632,7 +632,6 @@ static int es8323_probe(struct snd_soc_component *compo= nent) =20 snd_soc_component_write(component, ES8323_CONTROL2, 0x60); snd_soc_component_write(component, ES8323_CHIPPOWER, 0x00); - snd_soc_component_write(component, ES8323_DACCONTROL17, 0xB8); =20 return 0; } --=20 2.48.1 From nobody Sat Oct 4 14:35:21 2025 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B17D7215062; Fri, 15 Aug 2025 04:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755231709; cv=none; b=lYZZWRvJX8CKR8KtbtdopadDhrryymn2eAZPJqGIswTfKtwazZKwnBLC+a8p4aJieigNMWf8IMX4IjNWqER5X064e2Xac8Hl3LGSEJCNP2Lrd3D9uAmlfw6LVEXn52yq09U/YPYdalNWyoNmuDru9y0+RKlRdSmfHfhFAKsbpM8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755231709; c=relaxed/simple; bh=yYU3BGY8apJ7/bVxueA9JZ+trRFHpqUCjdyPBdS65Bg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hxxj4yEhtm56eP/ai2IPpgwbWeUa3apSt7Q8OhU6AkVFpWBNq9op7nzEOcQ6oSiBU/hJvZsd48yXjfc/EsCqBi4S8CDfeIWD5MAv8SoHQqG5yBxvPtrcufF17Olpp1iuTJlWfZlI/9/Hab8uDU8BIM1ylou2b1F6tKekdaNBZXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PFF7fRqk; arc=none smtp.client-ip=209.85.166.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PFF7fRqk" Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-3e575ff1b80so5495985ab.3; Thu, 14 Aug 2025 21:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755231707; x=1755836507; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sQaQCUUCbOrsHCY9Z7BsQ0uU/8o3MVoc/bvLf/aDeTs=; b=PFF7fRqkitizFtBCmrYMEo9Lux7VUeAujWNR/Fi/mz+a3puDRol9hwTi9wd2aFXY/E lYcFQEhz4XSZVIavBqa3mQS1BNPR84z7+Q5BoFJCLLZ6UaBRMh354Ix57jcGVOGkEKfp XohLzWydPTgEjVterDYG6WDaia4wi+wExUVUDAiMEJfOF+Mxo+kQzmIp2If1oKh+l0xM ekbU8Ua25MFcT4kD8gQo4GPspzSXZrHEuIVFlA6WSHoENAQzvjaw5fevit2CHuV9L9NI Ef73eB8ZaiWdq/InVayZCt7/q+esvbUo7ds/jarGLpaY/pXgrjtT//REiRxTRPBvBnTV t+JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755231707; x=1755836507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sQaQCUUCbOrsHCY9Z7BsQ0uU/8o3MVoc/bvLf/aDeTs=; b=gVHBYUmqONoyukB2q1y/MoHkNBsXFhfpO73zUpTUFzI0vncp8Lnn+0njviGIIFcNZh n6s/N1bEWV4k0G5c2+m3GYQXEYtQIV9YHDaoGtHT9hvZZuTLeCokJvsUGjBn4oY6bVw/ KrNVQMiZEF3Q3+XHjdaW12aPPpDZ6ewVDaFt5MpsBmlYfu2wm990AnMRFo0Ao6Ujz74y X4hoQ74RWM65VJSvWOD93oGS/fJDGknhuyfwzQL7pwJ20P1Ob7tTTeByitGUDEXMANvk GR1cfmlB/Kaobs0Pgf+ia1GQREv6vUh7uZC1AdbuUZ1retNwHZizwTMiBMf3uDkhzw/4 R2ZQ== X-Forwarded-Encrypted: i=1; AJvYcCWhAX9v+dZ33R60/6nVa7YwlbZp/TA4wiLHQ5gVZ3wYQiAcKiYVNgK1M0Vm4H6BSDOjxJXyocQIdyRoDcA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/9fdv1lmkIlfWolntsJTC0uQXTNSTGh3AOiOkMscyxzGLUwBJ 4kEua4wlYX+ewCDK/BiVEFbOSv/+BG657vENKYdH6Fw96rjVXw62i2gU X-Gm-Gg: ASbGncusb/7lBwwVKT3DhJaIiZOxHEk0PaBFDaYulwVzzfLe1sSd2wASQmxBMhPs9s7 kaHBEXEWUCfR7PSvmHA/JgW5yw6Lqosqcbql0MlVEhYI2gg74+pQgL9HhEqvpMnLSpnV84HLNCm +loGQ51Zt1umjl7rO+2ZsmwSzaXAK5d6jHx7WIrfbwefPOKqiNlJJPBD/Eadfr6YN2Nt3wm1GmU /JvvxI5ygPK5L5AyHkUsvnU7ce4gG5IwRI4c8QDNUoE5CTW4vFUfBcNCIZNQ31vYpmMufEpoGzU jXUsSPUPJEPht/bROZD0udZKJrw85rvASU7L0hxdqCqe+lt20L4O3sm0ogxYXjcGTvDCg3C3GXK RniCsUpsiCtIWwW8KzFAHOwAEwE/mIqOFyvbXHVWPcEzz/lf3oJS+sW5adip6tVXJ1LExw/qI3j uOTA== X-Google-Smtp-Source: AGHT+IF6eJniCFCdaYOLX9voLhd8W5yzM9nF+Is9Q9zOcgxX03gda7Mqvx74f+HDrW5PoHAVO5pobw== X-Received: by 2002:a92:c24d:0:b0:3e5:4fee:75e8 with SMTP id e9e14a558f8ab-3e57e9dd050mr10205665ab.20.1755231706763; Thu, 14 Aug 2025 21:21:46 -0700 (PDT) Received: from localhost.localdomain (65-128-248-47.mpls.qwest.net. [65.128.248.47]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e57e5a585esm1689365ab.16.2025.08.14.21.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 21:21:46 -0700 (PDT) From: Shimrra Shai To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shimrrashai@gmail.com Subject: [PATCH 2/3] ASoC: es8323: add proper left/right mixer controls via DAPM Date: Thu, 14 Aug 2025 23:20:22 -0500 Message-ID: <20250815042023.115485-3-shimrrashai@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250815042023.115485-1-shimrrashai@gmail.com> References: <20250815042023.115485-1-shimrrashai@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add proper DAC and mixer controls to DAPM; no initialization in es8323_probe. Signed-off-by: Shimrra Shai --- sound/soc/codecs/es8323.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/es8323.c b/sound/soc/codecs/es8323.c index 194720e4d..79f1fa967 100644 --- a/sound/soc/codecs/es8323.c +++ b/sound/soc/codecs/es8323.c @@ -182,13 +182,13 @@ static const struct snd_kcontrol_new es8323_mono_adc_= mux_controls =3D =20 /* Left Mixer */ static const struct snd_kcontrol_new es8323_left_mixer_controls[] =3D { - SOC_DAPM_SINGLE("Left Playback Switch", SND_SOC_NOPM, 7, 1, 1), + SOC_DAPM_SINGLE("Left Playback Switch", ES8323_DACCONTROL17, 7, 1, 0), SOC_DAPM_SINGLE("Left Bypass Switch", ES8323_DACCONTROL17, 6, 1, 0), }; =20 /* Right Mixer */ static const struct snd_kcontrol_new es8323_right_mixer_controls[] =3D { - SOC_DAPM_SINGLE("Right Playback Switch", SND_SOC_NOPM, 6, 1, 1), + SOC_DAPM_SINGLE("Right Playback Switch", ES8323_DACCONTROL20, 7, 1, 0), SOC_DAPM_SINGLE("Right Bypass Switch", ES8323_DACCONTROL20, 6, 1, 0), }; =20 --=20 2.48.1 From nobody Sat Oct 4 14:35:21 2025 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5A391CD215; Fri, 15 Aug 2025 04:21:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755231719; cv=none; b=Xh4K3It+Mw1JpQ2zfRJ57J7d9grCTHJ7xYovxSeVDppB4WHUQq9sGMUzVWF+LBzFnXfkD990Sf8nyESoOUfWSlt6vAxj90oRfJY8kzFYO/nyWCBoyB8LaPxaVD90Qcgn/x0hVUmhy5o6Jlz5mKZH14XiLsOn42pnANmfOhhm7xA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755231719; c=relaxed/simple; bh=RmAkGq6W4WlUqzQXHGqGnRGBMlL425ZqNLgZsMOdfio=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fGXP7FW5dTPHxKzwarO0lI/zcAUWFvmtgohhUZlfphVmDuj78iDZ7b2FyEgIdO286NhnhIT5qRycpPTAQ5yQmBDbHYIAcowshcYypJ/A//rzJJqVURbs0Xx1PsX54N+14yI0qN0Ph8NTlWtJkh7wyXCVMQOYiMQCsomVA7LJwzE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FSPFr74g; arc=none smtp.client-ip=209.85.166.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FSPFr74g" Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-3e57376f638so3895535ab.1; Thu, 14 Aug 2025 21:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755231716; x=1755836516; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3MY9UWLRYUehtd8TTSjgdbfjrvmnJ4bqiAl1A8JyFtM=; b=FSPFr74gSmztslSiBp+cV/baUU1/hnC6GpYBSTCpwNhI/89yL7QNhQ4BoxPLdixHVW TLxnCasTmWQgG7jXSqyCUhPxq+NIl09TD0hrlrqKHW7D+HXGhvhWV/HFGovTbm8xf0MS ttwgQr79Ep97S2uE1+pAL/Xx+sKx0OObOgML2TeWOYXFzCpevixyuWWk4cxX1OnMPvbW +FWyK9Z2FSQYu7Ic9AhgUg2ZskSq8UuwIaNrsMY1CQHIRiJ39OcVHBsLdS/GZoMfRQOL mOGCDftwZ+q/grIjRrsj/j6WEasA6tPNNdK7zHMwAYxiu+HU93UKPLgWJ98dOeaDCfkP ecbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755231716; x=1755836516; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3MY9UWLRYUehtd8TTSjgdbfjrvmnJ4bqiAl1A8JyFtM=; b=Zh6S0felJ9fNN5PG5x+snjCPmWW8FbI/CoR5o34Ha2SsXl9SgpuI0cUYVDUY2WxFKg ZbpkjhzuPU+f9IfJx4urDsiFV0B7uK/lyhhx+ztqAYp03OEgUIzyPZxv/We0tFC+ycTk uJQv8k2c7aHfKvsBwQAkuY1VtkvCFQsfb5VClflXDtiBjW0PdJF8k37U8c5pfz4nR/Tj XBFMQ8Y58QLFsTxTSb9YJFfEA+t7f6Bj1akyhpZ2nR7O+bbaos5XRPfnk5nFIgG5CE6F 48SYK87BTiYMmi8aVfk5dqKvc75lNxYSYgaURtx+Rk6kJXivWshQcBlX6XiWgiTzkgUW sL9A== X-Forwarded-Encrypted: i=1; AJvYcCXgAWE15zDXPurQMeRaKx0sFkMxc42Dzoc4Mb2hDfTAs54vE7V0myfMbcHd/CIFo5JjPt65eitXLsWqIj4=@vger.kernel.org X-Gm-Message-State: AOJu0YwqogCQXVhpjsW1Vq4FfXfdZjusBdjytLd0/QsP7BHyjjplLvth uJFbG1oDIQBjXsjAsZzsZknC0f5fJGgAGwYl08YdRyDzZmU8Ctq5sjmN X-Gm-Gg: ASbGncvzWYi5+z+r5STIKyrfA5zjfG/uCEwPREXlVFVkpfIIHPF6E7bYJloosDT36ZU Fd1E5m8mg04TIh9c9GllANH/VtI/SQenqpv8OC3K6HrwsciJNgm5iKK5CjKHOXdNXq/WdQvCoTN 8xAe3Yatzdns/T/ddni6o1cP2HK8jGo61OS+a6q+etFGks6jkK103WrSgkyOPlvl6ewoPuMzqEw nCfcldB/yS+Ruq0/uyRUvJe1+G423DdVQKDdIcgi0C1xbAPr0atpAzbOPovbyqF2wno2RliGjav fAb1/BMXCR4B72d0JurIZbkPzUNh3jUsShzabI4wHgODum10oFxhv/BKHqbiXS7GxFqI8GyHOwQ kSTc1GhGuXL9QtGHdLzIZ+QftcfVRx6t/5txjdJDJZz0QV6A3ImB+zROUsjXZ3JesfO4= X-Google-Smtp-Source: AGHT+IEvdihc3ix/SVgsBXg4IlLTvFH75x9CWs/xiTB3HkO78Mc2w/YasOw5+CLfwS3E/L11rkqn/g== X-Received: by 2002:a05:6e02:1808:b0:3e4:2ea:bbf5 with SMTP id e9e14a558f8ab-3e57e9c1bddmr13105085ab.21.1755231715678; Thu, 14 Aug 2025 21:21:55 -0700 (PDT) Received: from localhost.localdomain (65-128-248-47.mpls.qwest.net. [65.128.248.47]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e57e5a585esm1689365ab.16.2025.08.14.21.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 21:21:55 -0700 (PDT) From: Shimrra Shai To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shimrrashai@gmail.com Subject: [PATCH 3/3] ASoC: es8323: enable DAPM power widgets for playback DAC Date: Thu, 14 Aug 2025 23:20:23 -0500 Message-ID: <20250815042023.115485-4-shimrrashai@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250815042023.115485-1-shimrrashai@gmail.com> References: <20250815042023.115485-1-shimrrashai@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This part might not be needed for resubmission as it was already accepted on the previous submission of this patch, but since the whole series was not accepted due to that I had retained and expanded the initialization in the probe routine I'm not sure if I should submit it again. Signed-off-by: Shimrra Shai --- sound/soc/codecs/es8323.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/es8323.c b/sound/soc/codecs/es8323.c index 79f1fa967..eb85b71e8 100644 --- a/sound/soc/codecs/es8323.c +++ b/sound/soc/codecs/es8323.c @@ -211,8 +211,8 @@ static const struct snd_soc_dapm_widget es8323_dapm_wid= gets[] =3D { =20 SND_SOC_DAPM_ADC("Right ADC", "Right Capture", SND_SOC_NOPM, 4, 1), SND_SOC_DAPM_ADC("Left ADC", "Left Capture", SND_SOC_NOPM, 5, 1), - SND_SOC_DAPM_DAC("Right DAC", "Right Playback", SND_SOC_NOPM, 6, 1), - SND_SOC_DAPM_DAC("Left DAC", "Left Playback", SND_SOC_NOPM, 7, 1), + SND_SOC_DAPM_DAC("Right DAC", "Right Playback", ES8323_DACPOWER, 6, 1), + SND_SOC_DAPM_DAC("Left DAC", "Left Playback", ES8323_DACPOWER, 7, 1), =20 SND_SOC_DAPM_MIXER("Left Mixer", SND_SOC_NOPM, 0, 0, &es8323_left_mixer_controls[0], @@ -223,10 +223,10 @@ static const struct snd_soc_dapm_widget es8323_dapm_w= idgets[] =3D { =20 SND_SOC_DAPM_PGA("Right ADC Power", SND_SOC_NOPM, 6, 1, NULL, 0), SND_SOC_DAPM_PGA("Left ADC Power", SND_SOC_NOPM, 7, 1, NULL, 0), - SND_SOC_DAPM_PGA("Right Out 2", SND_SOC_NOPM, 2, 0, NULL, 0), - SND_SOC_DAPM_PGA("Left Out 2", SND_SOC_NOPM, 3, 0, NULL, 0), - SND_SOC_DAPM_PGA("Right Out 1", SND_SOC_NOPM, 4, 0, NULL, 0), - SND_SOC_DAPM_PGA("Left Out 1", SND_SOC_NOPM, 5, 0, NULL, 0), + SND_SOC_DAPM_PGA("Right Out 2", ES8323_DACPOWER, 2, 0, NULL, 0), + SND_SOC_DAPM_PGA("Left Out 2", ES8323_DACPOWER, 3, 0, NULL, 0), + SND_SOC_DAPM_PGA("Right Out 1", ES8323_DACPOWER, 4, 0, NULL, 0), + SND_SOC_DAPM_PGA("Left Out 1", ES8323_DACPOWER, 5, 0, NULL, 0), SND_SOC_DAPM_PGA("LAMP", ES8323_ADCCONTROL1, 4, 0, NULL, 0), SND_SOC_DAPM_PGA("RAMP", ES8323_ADCCONTROL1, 0, 0, NULL, 0), =20 --=20 2.48.1