From nobody Sat Feb 7 22:15:20 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E9A829D26C; Fri, 15 Aug 2025 03:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755228448; cv=none; b=b3EGtQaQfntAimNI7ctTmlBk/cIJqeBPZ/t404WXgmiDoJtUDKxtX+1dpYQMfPdHo8aOfKEzDbZZAFRsbySoQYsENb8wtTGVSMXwvZd5lRFrMLOVFd0wLsZWHm/7PCnasxGcJapM2HS9HYhpvdyfYW8xBBHcE/qrcuoRjkKabBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755228448; c=relaxed/simple; bh=50Y13gswXvqynDSmLEISvpYLyX8qVSTFdfU8wyi+m8U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Z45vCGBJgoNN5Vl1zsMqY/k9y3VjBLJU3oTI1OBb72jy/qD33XFgH/Nh/ItcucL2/uQyHZTTliMT7iyZbmLFEfgV/ykR5eweV4dlYBr1OoINCkYy4acLVfeTE3acij+oR8ldywUnlvmib/82knvNM9EFLL1j9rFBrc7vfshRShA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sWbOy3cN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sWbOy3cN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF83CC4CEED; Fri, 15 Aug 2025 03:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755228448; bh=50Y13gswXvqynDSmLEISvpYLyX8qVSTFdfU8wyi+m8U=; h=From:To:Cc:Subject:Date:From; b=sWbOy3cNwY+FsyxS1p/A0QgX8uaWkDnkn2zZNul6Zl16InRhK1e0/hV9d4LWjdU46 MEBr+KjmSbpM8xdmC0Oe/c2CnXLvIgqMd2+11EJBvPa8Nfxq2rQng3ZqTx4p2uJDcp 43aCcXqylukOuG30r4BcYhpcfeLRoL2h62/C2RiU3w11QbXKdiv8AayEji5tU6id3e ZFgA3EHZsXGD/zhcAxDgBMpeM417vlo83UmXxuxgqQ5hS1DhmlCILnVrX5bDLZLSIU V5+lNvoqb2EwV4QQD6LS1CKEIX6gklsUALtjXPwGqCLTAC6Dsdixm3yOa/I54rvlet NE5TlFWv5IDng== From: Jisheng Zhang To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pwm: berlin: Fix wrong register in suspend/resume Date: Fri, 15 Aug 2025 11:10:16 +0800 Message-ID: <20250815031016.31000-1-jszhang@kernel.org> X-Mailer: git-send-email 2.50.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The 'enable' register should be BERLIN_PWM_EN rather than BERLIN_PWM_ENABLE. Fixes: bbf0722c1c66 ("pwm: berlin: Add suspend/resume support") Signed-off-by: Jisheng Zhang --- drivers/pwm/pwm-berlin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-berlin.c b/drivers/pwm/pwm-berlin.c index 831aed228caf..858d36991374 100644 --- a/drivers/pwm/pwm-berlin.c +++ b/drivers/pwm/pwm-berlin.c @@ -234,7 +234,7 @@ static int berlin_pwm_suspend(struct device *dev) for (i =3D 0; i < chip->npwm; i++) { struct berlin_pwm_channel *channel =3D &bpc->channel[i]; =20 - channel->enable =3D berlin_pwm_readl(bpc, i, BERLIN_PWM_ENABLE); + channel->enable =3D berlin_pwm_readl(bpc, i, BERLIN_PWM_EN); channel->ctrl =3D berlin_pwm_readl(bpc, i, BERLIN_PWM_CONTROL); channel->duty =3D berlin_pwm_readl(bpc, i, BERLIN_PWM_DUTY); channel->tcnt =3D berlin_pwm_readl(bpc, i, BERLIN_PWM_TCNT); @@ -262,7 +262,7 @@ static int berlin_pwm_resume(struct device *dev) berlin_pwm_writel(bpc, i, channel->ctrl, BERLIN_PWM_CONTROL); berlin_pwm_writel(bpc, i, channel->duty, BERLIN_PWM_DUTY); berlin_pwm_writel(bpc, i, channel->tcnt, BERLIN_PWM_TCNT); - berlin_pwm_writel(bpc, i, channel->enable, BERLIN_PWM_ENABLE); + berlin_pwm_writel(bpc, i, channel->enable, BERLIN_PWM_EN); } =20 return 0; --=20 2.50.0