From nobody Sat Oct 4 15:52:48 2025 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FF5E244664 for ; Fri, 15 Aug 2025 05:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755235092; cv=none; b=dvslVe3WDMHCm9faYxE9OedMnfdb80Dwg7tSLbDHgOK4IGj18TyzfG0rNCQpkvei5LcHu+kiGWx1aRAbMEPSeFVYMlc6J38B2T3ZyBA8G6ZxlPqlqkUL3vdLI2d+kjQSipnAwEi7e/adnd2uT9vh3flSnHG+26QuUaHCj2Eggeg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755235092; c=relaxed/simple; bh=UKe+dJ5K7ELbDKwHq7yoq8502F2M2Iu2qW+JceNoxSI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YNebt20grzGH7hZfEEllMfB7dUTSrQbXnpvhXJknDTbJMe0RE7W6UVKkvZKU8+ypYkU8nDZ/OOHyEFu7bf1pMrdDDNwwIMv1KbvaOvbRxkjFrWCz2XQnEiXkae99gN7OEMCz1aCqQ82uqyBRK9fP/FHyZ/YZg3pWyWR+k2u5Fjo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=UnYvEbH4; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="UnYvEbH4" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-b47175d02dcso1490617a12.3 for ; Thu, 14 Aug 2025 22:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1755235089; x=1755839889; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4K+SY37dyqVcPJJCZYgKmmTu/WHqvqW32AeiYFgaBnA=; b=UnYvEbH4hJ/EtAvaNlpg58C9hXmUGd542clfHEHxT4GwS1SyInaQY9cQ7PtBKM0bOr v6ycdL8XVEaNtAlWE9rZsLjGE2Ftccgvm5JqEaJCh9LNzrahQFpJZviqqbWg6ddDEgBL /dDH18PwIZmB4HWZmpwfeaXmHwF0ilLHZ8toRl32Ymzi8tOJCs8sDlPf7DwCnbFcpljw Y0dsF+lWvS/R94DRYcTfD8MkFNqW1SmY2MzB4lVakH/TfokH2LFwr1aXmchRNsUlAjoD nrfZZbsBjsuqZeDd8EplucsV7KYZRKnknqGIy/i+wQLV3PFvP9JG+NjorIJB2OmSMUlS h+5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755235089; x=1755839889; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4K+SY37dyqVcPJJCZYgKmmTu/WHqvqW32AeiYFgaBnA=; b=clxKkOSwZEqPHGGm7KSn3bqkipEpDH40odGtzGVvJO9xYWKXJm+jRabjxRKgaiXxlh yNArgeY4qi3Viz2q2+lYNFXa2QjdrE43+kmsN1upIsZHi3iCuiYiX2k4ieUwMMxhGosO doHYReSYihjudHoaI4DqnRArs2TzIAMJtUNQkbMKKR6+NUrdrzRY2f0Aoy9MwvQqI9rb LdYukQXFNq/uTj9tj0BRCPWwDgXzePrDRd6lMalYBM7QwHf2zhNN3qJ8ThrioPrw6vSU OXpYp241MUxjE8sHj4K4gZJPcySbmm73yhc2FZCZEpygt6nz/WQMYyifp6zsQshjK0Ig VbgA== X-Forwarded-Encrypted: i=1; AJvYcCXhnvESxFrkDHBZaEMymsfZd+HHrInZMWCllmsqnCIqy/6802kEmNyvhwih9JV2Eoze9M/oMnFa242P0iM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp+VBFzUuTrOIne9zcL6UTVhGwGYme/DvG2M0l+GyRUpjOFfJA kBVlVA0MUJhH1SAScuqXk2XKQu0qcOm3dpQwb5BkMdTrB2TdvK8mcYIh5MFQQMTEj9k= X-Gm-Gg: ASbGnctXZOBgznI7giWHZxV/MehDtsBC3qd3KWiYZ+qDMZHypfCszh0Pws9VMcPhog4 2JLI5IlgJEWk13eHyye/PjcK42RQTdy6ZGXt/PKoGxWYzwlmt6V8iP4NGBPCGUQUhrRPSmUUvys PN2MAjEV7/UY36io1rLs3kKzgAWTMZHH8i8M2ppQrEdYbfHP5u1Fom8i0GXHr29Twfm1pZeDrU1 lTh/3G8f9a7U4Vz3NoVVawb2KLW9UQjz8F/72KGlMwMWn7kAuNyeICMsWDjC/0cpdzvm4sTi7ol tOCmt2wUjYoYJ67ptGvJvx/npkZqhhy5/m1PRQsxLzV5Kn0jqYKihvr7mNt/FNdVzr/U6MoMc9g eC22NJ/TPAprIGZVlyswRyhtwh2HdFHBV X-Google-Smtp-Source: AGHT+IEf4qawwxe44eaVc0uK4/HwugJzFNy+DklkqjKPUXgqEqhlMol/I4o9OLq2m+sgprjKs26ebw== X-Received: by 2002:a17:90b:1d05:b0:31e:f3b7:49d2 with SMTP id 98e67ed59e1d1-32340f9db40mr1745695a91.0.1755235088360; Thu, 14 Aug 2025 22:18:08 -0700 (PDT) Received: from [127.0.1.1] ([103.88.46.155]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-323439978a4sm373212a91.10.2025.08.14.22.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 22:18:08 -0700 (PDT) From: Guodong Xu Date: Fri, 15 Aug 2025 13:16:27 +0800 Subject: [PATCH v4 5/8] dmaengine: mmp_pdma: Add SpacemiT K1 PDMA support with 64-bit addressing Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250815-working_dma_0701_v2-v4-5-62145ab6ea30@riscstar.com> References: <20250815-working_dma_0701_v2-v4-0-62145ab6ea30@riscstar.com> In-Reply-To: <20250815-working_dma_0701_v2-v4-0-62145ab6ea30@riscstar.com> To: Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , duje@dujemihanovic.xyz Cc: Alex Elder , Vivian Wang , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, Guodong Xu , Troy Mitchell X-Mailer: b4 0.14.2 Add support for SpacemiT K1 PDMA controller which features 64-bit addressing capabilities. The SpacemiT K1 PDMA extends the descriptor format with additional 32-bit words for high address bits, enabling access to memory beyond 4GB boundaries. The new spacemit_k1_pdma_ops provides necessary 64-bit address handling functions and k1 specific controller configurations. Key changes: - Add ARCH_SPACEMIT dependency to Kconfig - Define new high 32-bit address registers (DDADRH, DSADRH, DTADRH) - Add DCSR_LPAEEN bit for Long Physical Address Extension Enable - Implement 64-bit operations for SpacemiT K1 PDMA Signed-off-by: Guodong Xu --- v4: No change. v3: No change. v2: New patch. - Implement 64-bit addrssing support to mmp_pdma - Add support for SpacemiT K1 PDMA - Extend the MMP_PDMA entry in Kconfig to depend on ARCH_SPACEMIT --- drivers/dma/Kconfig | 2 +- drivers/dma/mmp_pdma.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 82 insertions(+), 1 deletion(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 05c7c7d9e5a4e52a8ad7ada8c8b9b1a6f9d875f6..b8a74b1798ba1d44b2655399042= 8c065de6fc535 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -450,7 +450,7 @@ config MILBEAUT_XDMAC =20 config MMP_PDMA tristate "MMP PDMA support" - depends on ARCH_MMP || ARCH_PXA || COMPILE_TEST + depends on ARCH_MMP || ARCH_PXA || ARCH_SPACEMIT || COMPILE_TEST select DMA_ENGINE help Support the MMP PDMA engine for PXA and MMP platform. diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index 610df28f429783779c1c143a13b3a829e42cf003..28c03d05e0b2708fcb8faffeeb9= 7b97ed6fcbdc5 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -28,6 +28,9 @@ #define DDADR(n) (0x0200 + ((n) << 4)) #define DSADR(n) (0x0204 + ((n) << 4)) #define DTADR(n) (0x0208 + ((n) << 4)) +#define DDADRH(n) (0x0300 + ((n) << 4)) +#define DSADRH(n) (0x0304 + ((n) << 4)) +#define DTADRH(n) (0x0308 + ((n) << 4)) #define DCMD 0x020c =20 #define DCSR_RUN BIT(31) /* Run Bit (read / write) */ @@ -44,6 +47,7 @@ #define DCSR_EORSTOPEN BIT(26) /* STOP on an EOR */ #define DCSR_SETCMPST BIT(25) /* Set Descriptor Compare Status */ #define DCSR_CLRCMPST BIT(24) /* Clear Descriptor Compare Status */ +#define DCSR_LPAEEN BIT(21) /* Long Physical Address Extension Enable */ #define DCSR_CMPST BIT(10) /* The Descriptor Compare Status */ #define DCSR_EORINTR BIT(9) /* The end of Receive */ =20 @@ -76,6 +80,16 @@ struct mmp_pdma_desc_hw { u32 dsadr; /* DSADR value for the current transfer */ u32 dtadr; /* DTADR value for the current transfer */ u32 dcmd; /* DCMD value for the current transfer */ + /* + * The following 32-bit words are only used in the 64-bit, ie. + * LPAE (Long Physical Address Extension) mode. + * They are used to specify the high 32 bits of the descriptor's + * addresses. + */ + u32 ddadrh; /* High 32-bit of DDADR */ + u32 dsadrh; /* High 32-bit of DSADR */ + u32 dtadrh; /* High 32-bit of DTADR */ + u32 rsvd; /* reserved */ } __aligned(32); =20 struct mmp_pdma_desc_sw { @@ -222,6 +236,57 @@ static u64 get_desc_dst_addr_32(const struct mmp_pdma_= desc_hw *desc) return desc->dtadr; } =20 +/* For 64-bit PDMA */ +static void write_next_addr_64(struct mmp_pdma_phy *phy, dma_addr_t addr) +{ + writel(lower_32_bits(addr), phy->base + DDADR(phy->idx)); + writel(upper_32_bits(addr), phy->base + DDADRH(phy->idx)); +} + +static u64 read_src_addr_64(struct mmp_pdma_phy *phy) +{ + u32 low =3D readl(phy->base + DSADR(phy->idx)); + u32 high =3D readl(phy->base + DSADRH(phy->idx)); + + return ((u64)high << 32) | low; +} + +static u64 read_dst_addr_64(struct mmp_pdma_phy *phy) +{ + u32 low =3D readl(phy->base + DTADR(phy->idx)); + u32 high =3D readl(phy->base + DTADRH(phy->idx)); + + return ((u64)high << 32) | low; +} + +static void set_desc_next_addr_64(struct mmp_pdma_desc_hw *desc, dma_addr_= t addr) +{ + desc->ddadr =3D lower_32_bits(addr); + desc->ddadrh =3D upper_32_bits(addr); +} + +static void set_desc_src_addr_64(struct mmp_pdma_desc_hw *desc, dma_addr_t= addr) +{ + desc->dsadr =3D lower_32_bits(addr); + desc->dsadrh =3D upper_32_bits(addr); +} + +static void set_desc_dst_addr_64(struct mmp_pdma_desc_hw *desc, dma_addr_t= addr) +{ + desc->dtadr =3D lower_32_bits(addr); + desc->dtadrh =3D upper_32_bits(addr); +} + +static u64 get_desc_src_addr_64(const struct mmp_pdma_desc_hw *desc) +{ + return ((u64)desc->dsadrh << 32) | desc->dsadr; +} + +static u64 get_desc_dst_addr_64(const struct mmp_pdma_desc_hw *desc) +{ + return ((u64)desc->dtadrh << 32) | desc->dtadr; +} + static int mmp_pdma_config_write(struct dma_chan *dchan, struct dma_slave_config *cfg, enum dma_transfer_direction direction); @@ -1110,10 +1175,26 @@ static const struct mmp_pdma_ops marvell_pdma_v1_op= s =3D { .dma_mask =3D 0, /* let OF/platform set DMA mask */ }; =20 +static const struct mmp_pdma_ops spacemit_k1_pdma_ops =3D { + .write_next_addr =3D write_next_addr_64, + .read_src_addr =3D read_src_addr_64, + .read_dst_addr =3D read_dst_addr_64, + .set_desc_next_addr =3D set_desc_next_addr_64, + .set_desc_src_addr =3D set_desc_src_addr_64, + .set_desc_dst_addr =3D set_desc_dst_addr_64, + .get_desc_src_addr =3D get_desc_src_addr_64, + .get_desc_dst_addr =3D get_desc_dst_addr_64, + .run_bits =3D (DCSR_RUN | DCSR_LPAEEN), + .dma_mask =3D DMA_BIT_MASK(64), /* force 64-bit DMA addr capability */ +}; + static const struct of_device_id mmp_pdma_dt_ids[] =3D { { .compatible =3D "marvell,pdma-1.0", .data =3D &marvell_pdma_v1_ops + }, { + .compatible =3D "spacemit,k1-pdma", + .data =3D &spacemit_k1_pdma_ops }, { /* sentinel */ } --=20 2.43.0