From nobody Sat Oct 4 14:35:18 2025 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0CCD42056; Fri, 15 Aug 2025 10:02:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755252130; cv=none; b=ma1tjmEVIx03fyBiOZzJ7d0vyze5HNBzXwwPXZRsvEFskb3CS+SblJwyUtiDrMq8hFjOe47GAvsHb2tZRqBFhYYlPAyIp+xaTvvq4oTkhhvdfLUUWcUUXPXTrHbGdwiziytPkbDmQOxnRxJb40yqrKyeDtDf0hL3n+qv0rQiPck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755252130; c=relaxed/simple; bh=7ZAY+2Peo7S2rRiLYIRAhUNbUzK4+1P+0qH+dyOPnWc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lRt+urstsJ8VQgDaQC4tOwrHcNc0Voq2Ta4hgh9hvmQYCUFll66NPgkMi6qQ1iiE2n/eo0NnQVfHBb/z3t2zZZyywfUjgU2fsdxn9qXH7iOFeWfg1PDfYZJ+Tngr+eOQ43cANAmVysSxHSNK2y/5SDAPW5A/m8F4FwUkNflhEJg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W6syvQ2V; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W6syvQ2V" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-afcb7a0442bso275817166b.2; Fri, 15 Aug 2025 03:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755252127; x=1755856927; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Xe/jpg8erHMI8XAl5plVXtak/ycKmWW+BnUpeddeEcY=; b=W6syvQ2Vj7wCz+AWKx+ZUuGZASMPleYBFNY+JhC/mVIl8v5nhEVTzorsm3ICAmb5Xx FrHcGqGmH3PhKJzTj5DNn/X+GTQVsVWMq5CsDUNG8J831URH9ilUhdwxmAYvRe+0C5Nn 3jbQSC9ZGwis2FWx1b2eqGlDCH93fY4oJNM2D0mHHu4Q1yWpsdG38OQaLyLyygxw7Ouu mP2HN8ffl2g9LFWeoXHpd4WTdSdhzpM3kbvlGo4s2dFfAK7B5HBbSpZcI/PNHF/c2eSc +aCzpDGdCfbGWlzOjGrMmfncjFxzLIWq19P9BhmqBQxb0fPUrg/TRlxTEMB6PhJcuk6g D1PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755252127; x=1755856927; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xe/jpg8erHMI8XAl5plVXtak/ycKmWW+BnUpeddeEcY=; b=j++v7kxCI0xqIQ+LxabfZux9zu1xB6XTMBiYBJXapdIm+kuv7W8x9ocNTzJfOXztT4 3noBc3FG8XEOBq+BAKOOog6eLXmTZBxqYqjSUth/IKrQYMr1hDqmvZcJD0Xo50+/rx0W ipUINJ3UnPt2S5CTzfpkFDgyfqFyI5mBmhDKZMelZh9NsL2So0Pq3HYxJ+LcGepfSDwJ TPryUhUEHAGyTqPaliV/ohKV9b4KkxICwQ7YdYcWkOVYMxCFPqAKjMLCGD3BnSbKIT/R Vx4U/hopbpDZ0sM9vDpj3oW0wAR5sBDWH1PfxYsvcHUQxTPjlkomFe+4qRXr86gkrV8t TV4A== X-Forwarded-Encrypted: i=1; AJvYcCVJALR44c7JAJAMQ6gLQN+MOC8Nyic8G/8ITsfYg0StPcsgkIEiLm4HsJZqFk3kiJwerw88MwgxrjV8@vger.kernel.org, AJvYcCWTte7EBkXXSqO4aVV0usV9LcJpbVyRBRgIRJRZKDgv5tXAYcqUx4OoJ0fH4fQq/UI5LQ/hzsr3pClr@vger.kernel.org, AJvYcCX1J+PzxoTbRHSebqsorO+dF4ffhLhmuIcDfDrNRiYhAwrW29UqPQBVpHLPo3/3c+bdAHqOEKHkcPPfMuMa@vger.kernel.org X-Gm-Message-State: AOJu0YzdMbBAfNN0Xpk9n5b0C3qDx3UG1q8TIlGQyz8c4DuH6+aWCDG/ q5QRf+ffeKi0gftU9N58/P6web4KtEoyyQ9jagzAh8HgqdVD7PtwYNUMwNcnVDET X-Gm-Gg: ASbGncun6gy43pW2OuNEL1Pa35rSgC1ABaRYao2ncKwg2q1qoPvnkxbE+nm3UCEMW9q 51ouuK6Xv3PuhS/+py2cRw2kkwdYs2pjM/pX5Q3O1Ek/CrgFDHE/3y8c9EoM1Y8PHvzFJ3R8hw9 Ucm7P4mIp+LD39c9KD47Wzllfuz3Ws4z7HW0POdpi3SGcVFT9iNP3Ulc2rP3o2hhVLdAXPbsXMF UX0ypVz653FiS1pes+gNc+KzQnsT+TTkZP1q/IAfa2ao7YOlDMYDBy4hN/f2tAbo5uDq1tMg/xI ybE6f07IwsGZ4I0uAEmzfpO3nYsIqmFxCm1Q80bSJ4Kzp4O5jKl4f3u22VVs96BJopUyE3Z0zqD h9LR5owb06F2x4vfbQ/0QkiNkrdYX X-Google-Smtp-Source: AGHT+IF0llnTVaBNjnplbmfZQjRdfKlaWfXT74yRY8kCDjVSpRWMCEhECZKDAZxsCIIC8SS6Mq93UQ== X-Received: by 2002:a17:907:962a:b0:ae3:f524:b51 with SMTP id a640c23a62f3a-afcdc25105dmr141869466b.10.1755252127037; Fri, 15 Aug 2025 03:02:07 -0700 (PDT) Received: from [127.0.1.1] ([185.177.137.147]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afcdce72d5dsm119031766b.37.2025.08.15.03.02.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Aug 2025 03:02:06 -0700 (PDT) From: Yusuf Alper Bilgin Date: Fri, 15 Aug 2025 12:02:02 +0200 Subject: [PATCH v4 1/3] dt-bindings: iio: adc: ltc2497: add lltc,ltc2495 bindings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250815-ltc2495-v4-1-2d04e6005468@gmail.com> References: <20250815-ltc2495-v4-0-2d04e6005468@gmail.com> In-Reply-To: <20250815-ltc2495-v4-0-2d04e6005468@gmail.com> To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Beguin Cc: Michael Hennerich , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Yusuf Alper Bilgin X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1755252124; l=1424; i=y.alperbilgin@gmail.com; s=20250811; h=from:subject:message-id; bh=7ZAY+2Peo7S2rRiLYIRAhUNbUzK4+1P+0qH+dyOPnWc=; b=EZjtrnBDYituhPsyMvnftMErGznq12QYkFh0bFyJq80i3Uva4wGvfHjThz/6PIyj5E6LXVWLb jZqCId/RBS4Dx5zM/HDDax5/Il1rG5Z63badrRsBfEzSroiNGWno4Eq X-Developer-Key: i=y.alperbilgin@gmail.com; a=ed25519; pk=FtW2oyQ0+xlYU0XmhYiJYC3lNPtPrgeE6i4WXPwaFnY= Update the binding documentation for LTC2497 to include LTC2495 to enable support for its internal temperature sensor, which requires a different I2C command format and a new IIO channel. Signed-off-by: Yusuf Alper Bilgin --- Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml b/= Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml index 5cc6a96840778473895f436b7e2627d6240b254b..2a3e3dcc6ca7a48a0fccb88d8d4= 2fee34efcff73 100644 --- a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml @@ -17,11 +17,13 @@ description: | =20 https://www.analog.com/media/en/technical-documentation/data-sheets/23= 09fd.pdf =20 + LTC2495: LTC2497: LTC2499: 16bit ADC supporting up to 16 single ended or 8 differential inputs. I2C interface. =20 + https://www.analog.com/media/en/technical-documentation/data-sheets/24= 95fe.pdf https://www.analog.com/media/en/technical-documentation/data-sheets/24= 97fb.pdf https://www.analog.com/media/en/technical-documentation/data-sheets/24= 99fe.pdf =20 @@ -29,6 +31,7 @@ properties: compatible: enum: - lltc,ltc2309 + - lltc,ltc2495 - lltc,ltc2497 - lltc,ltc2499 =20 --=20 2.43.0 From nobody Sat Oct 4 14:35:18 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B58F2FD7AF; Fri, 15 Aug 2025 10:02:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755252132; cv=none; b=cjTAkELNye5zTI58JPYI2dle+VLy9p0q8TiTGstgWCK2x6NsCPgT4A1MaIhnt5BlXfPdCuK2Iz82fF7JUo/QR6BRmRQEm4ThhL7R/Gr5fiSi+aN3UYe4bWaKB06MERVSI6suyn7EKS0u/SV8NaGGDkjNwuaW1T9k7Tw9z6cMhLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755252132; c=relaxed/simple; bh=JEUYQMGsKw802pSrUBvEuSI6h9jXfzKKuLQpTzQit14=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=op0llRW3qwzIEvmGh1BwQsFNH0NrzWMuA7iZXVA/k7QzFlOJCLkr1I5Q8yp71gfA1mljYmu2tb5ufDKrEGR9Cn4+knMdaLxk3DClAWCMmvNh6BJF9xegWbFTaAye5BR94dv2FTw1RDgH1stPE/SraocETc+duJwdVIQm5Gufs5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cE4IhACj; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cE4IhACj" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-afcb7aea37cso241357066b.3; Fri, 15 Aug 2025 03:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755252128; x=1755856928; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OiYwOw6U1QcztXra4utgt/P9v++aI38I7fzbBpmmo6w=; b=cE4IhACjzS6orUjlbzomrEgqeDGO6BnftlNztb6EaOlvp04pAZ+knq/hZPxBpXow90 dA8fUUAlaRtMNesazfUnI5xwgkVTn+F2qhXlvOmruH8JfKPIkzkmwqFj/GF1LyWR+5bN NDgKj/3fENqjFO0iq/udnp5H05CdWOXse5vXCiZoPg6G/9Y13iLreHiCGBsgecKORcws D58guKa0KKE3aEqPS9aDoRYXLmWI9OBZ+Pw0pPXvqr6eeZBk+11Wfd2PVAgtNyrlv14/ 8gvMu/E0RfpZv7N3SFn/F4CTmXyojvmxB7rihpz06H+1ka4Plax6zbPjtJWEuhYqMyCN hY1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755252128; x=1755856928; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OiYwOw6U1QcztXra4utgt/P9v++aI38I7fzbBpmmo6w=; b=XF6PTq169duIZUMrJp8246yiSQwcIQFHajRj8NS55X4X8+0g0IlEx4oSTmwDPvZ6ML px0UR8zzt3uHxLeWuB9eUxSNg+JPSPgTsl/Xa+w29YLbrpxqzxo4U7HMNXAY2zk2Z1KF A7FZfO9aIXRSJgmuijx4s3qiUfL3ETpTQRoNZTyaLQIz1NdyhlDyrO2BAHKx8CoX2wCB JYQzNJxkRNSCLd/IbPYkXeDzDS9dymhFPpkHpcbuD4xHGp3uN4yiJHGe8+j7WbNUeBaR Wxgpvs9UZ3Hn91Axu94XoKbfMPC6hutEfCDC+WIJALHZWFKv9IhadTx5OiqiX754a3dy 3W3Q== X-Forwarded-Encrypted: i=1; AJvYcCU4RsZlju95PAYc+mzMwYVpaf5fcw6gLqVhWnubAvdc6YIKOoXd8Edoe4DgewJ6nKa1nkpOMV3KdY5y@vger.kernel.org, AJvYcCVyZzIAgB4Q9NAHyRffDD0afovHL1TyXUFoG5yxJ+hUnLHRy9d7BnjJwI9JT2QfpxtvHjO2xTkaxB3kn6LA@vger.kernel.org, AJvYcCWArNCz7BkJLzugg62+lF69dTrPqs/e4HZMzORypHWWijXcB92T1LXFGORnbnp0SKYYXEqxHP0k59e+@vger.kernel.org X-Gm-Message-State: AOJu0YwiHA55a3NAb6Y51A2KWXCxlzWHoTVhx9Awrpa795PNSkKKqN+x oweGsEg1mxbd9elqyJoVtXbpEjnYga4roz/mQqMy5NFmnRT/xfilppp6 X-Gm-Gg: ASbGncvjY9kFQpEmY6YdlXZr0g8C4OpeHkC8uEzxg8jO3qYnVE1LrgIAGnkhPwHVwpK OL80UTKREU2EIeAxXbXVJkT11CBxoKgHutO0V8+5Ygq3FrbIbjk62SvifeijqeZQ7lbu+9Suli1 PYnUUHAMf269NJ5jObPI5y6PboWbemM59IVteD4Mwd3pNfcRLiInX2vq3Sq4AwYLT/nvlfqgwLz Gng8z6Y4yk+dOBGJseRVZv0jXYAXM7MmwAcY/7Ke+c5qOePUrLSp6xMcBIkrjQQpw6o71jzovC3 WQepAXS4y7iB8XPcj+Ta5EUDvriIycyz0fv/RzNQ7XV3Cl6BfKN63u/Xs/YDJ660p/64lb1V2xc b7cXrVaigirnFIgwjWBRbI38rB0CU X-Google-Smtp-Source: AGHT+IHt5VPJS222P902wv4YloJ68QWavQ8uO8Hp1ehIwkyMSkd/de7mqWzcqtxpvTFgdb5ctK1mwg== X-Received: by 2002:a17:907:9805:b0:ad8:9997:aa76 with SMTP id a640c23a62f3a-afcdc2c11d1mr123784866b.37.1755252127880; Fri, 15 Aug 2025 03:02:07 -0700 (PDT) Received: from [127.0.1.1] ([185.177.137.147]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afcdce72d5dsm119031766b.37.2025.08.15.03.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Aug 2025 03:02:07 -0700 (PDT) From: Yusuf Alper Bilgin Date: Fri, 15 Aug 2025 12:02:03 +0200 Subject: [PATCH v4 2/3] iio: adc: ltc2497: add support for LTC2495 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250815-ltc2495-v4-2-2d04e6005468@gmail.com> References: <20250815-ltc2495-v4-0-2d04e6005468@gmail.com> In-Reply-To: <20250815-ltc2495-v4-0-2d04e6005468@gmail.com> To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Beguin Cc: Michael Hennerich , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Yusuf Alper Bilgin X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1755252124; l=11228; i=y.alperbilgin@gmail.com; s=20250811; h=from:subject:message-id; bh=JEUYQMGsKw802pSrUBvEuSI6h9jXfzKKuLQpTzQit14=; b=FpyzVFnqSN9I2xMWDHD4ySB7M+6A5VgSikbaFoJmGW7c5KIRxsBLkCfjisJAd/Ym90jYLYJg9 gTDcqrZqTLdD0Wi8+x5KR1oSc2gqhXPaGoibs33imDo0N5wDFPomQyu X-Developer-Key: i=y.alperbilgin@gmail.com; a=ed25519; pk=FtW2oyQ0+xlYU0XmhYiJYC3lNPtPrgeE6i4WXPwaFnY= Update the LTC2497 driver to also support the LTC2495. Support for reading the internal temperature sensor on LTC2495 and LTC2499 via a standard IIO temperature channel. Signed-off-by: Yusuf Alper Bilgin --- drivers/iio/adc/ltc2497-core.c | 132 ++++++++++++++++++++++++++++---------= ---- drivers/iio/adc/ltc2497.c | 39 +++++++++++- drivers/iio/adc/ltc2497.h | 11 ++++ 3 files changed, 140 insertions(+), 42 deletions(-) diff --git a/drivers/iio/adc/ltc2497-core.c b/drivers/iio/adc/ltc2497-core.c index 2dc5c704426949a4ec62c42591d6c2c40ffb79cc..9f3509c5974dd7a0489145c5916= 30e1ff9dc333e 100644 --- a/drivers/iio/adc/ltc2497-core.c +++ b/drivers/iio/adc/ltc2497-core.c @@ -12,6 +12,7 @@ #include #include #include +#include =20 #include "ltc2497.h" =20 @@ -46,7 +47,8 @@ static int ltc2497core_wait_conv(struct ltc2497core_drive= rdata *ddata) return 1; } =20 -static int ltc2497core_read(struct ltc2497core_driverdata *ddata, u8 addre= ss, int *val) +static int ltc2497core_read(struct ltc2497core_driverdata *ddata, u8 addre= ss, + enum iio_chan_type type, int *val) { int ret; =20 @@ -54,11 +56,13 @@ static int ltc2497core_read(struct ltc2497core_driverda= ta *ddata, u8 address, in if (ret < 0) return ret; =20 - if (ret || ddata->addr_prev !=3D address) { + if (ret || ddata->addr_prev !=3D address || + ddata->chan_type_prev !=3D type) { ret =3D ddata->result_and_measure(ddata, address, NULL); if (ret < 0) return ret; ddata->addr_prev =3D address; + ddata->chan_type_prev =3D type; =20 if (msleep_interruptible(LTC2497_CONVERSION_TIME_MS)) return -ERESTARTSYS; @@ -83,7 +87,7 @@ static int ltc2497core_read_raw(struct iio_dev *indio_dev, switch (mask) { case IIO_CHAN_INFO_RAW: mutex_lock(&ddata->lock); - ret =3D ltc2497core_read(ddata, chan->address, val); + ret =3D ltc2497core_read(ddata, chan->address, chan->type, val); mutex_unlock(&ddata->lock); if (ret < 0) return ret; @@ -95,10 +99,37 @@ static int ltc2497core_read_raw(struct iio_dev *indio_d= ev, if (ret < 0) return ret; =20 - *val =3D ret / 1000; - *val2 =3D ddata->chip_info->resolution + 1; + switch (chan->type) { + case IIO_VOLTAGE: + *val =3D ret / 1000; + *val2 =3D ddata->chip_info->resolution + 1; =20 - return IIO_VAL_FRACTIONAL_LOG2; + return IIO_VAL_FRACTIONAL_LOG2; + + case IIO_TEMP: + if (!ddata->chip_info->has_temp_channel) + return -EINVAL; + + *val =3D ret; + *val2 =3D ddata->chip_info->temp_scale_mV; + + return IIO_VAL_FRACTIONAL; + + default: + return -EINVAL; + } + case IIO_CHAN_INFO_OFFSET: + if (chan->type !=3D IIO_TEMP) + return -EINVAL; + + ret =3D regulator_get_voltage(ddata->ref); + if (ret < 0) + return ret; + + *val =3D kelvin_to_celsius(0) * ddata->chip_info->temp_scale_mV; + *val2 =3D ret / 1000; + + return IIO_VAL_FRACTIONAL; =20 default: return -EINVAL; @@ -126,39 +157,54 @@ static int ltc2497core_read_raw(struct iio_dev *indio= _dev, .differential =3D 1, \ } =20 +#define LTC2497_TEMPERATURE_CHAN \ +{ \ + .type =3D IIO_TEMP, \ + .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW), \ + .info_mask_shared_by_type =3D BIT(IIO_CHAN_INFO_SCALE) | BIT(IIO_CHAN_INF= O_OFFSET), \ +} + +#define LTC2497_VOLTAGE_CHANNEL_LIST \ + LTC2497_CHAN(0, LTC2497_SGL, "CH0"), \ + LTC2497_CHAN(1, LTC2497_SGL, "CH1"), \ + LTC2497_CHAN(2, LTC2497_SGL, "CH2"), \ + LTC2497_CHAN(3, LTC2497_SGL, "CH3"), \ + LTC2497_CHAN(4, LTC2497_SGL, "CH4"), \ + LTC2497_CHAN(5, LTC2497_SGL, "CH5"), \ + LTC2497_CHAN(6, LTC2497_SGL, "CH6"), \ + LTC2497_CHAN(7, LTC2497_SGL, "CH7"), \ + LTC2497_CHAN(8, LTC2497_SGL, "CH8"), \ + LTC2497_CHAN(9, LTC2497_SGL, "CH9"), \ + LTC2497_CHAN(10, LTC2497_SGL, "CH10"), \ + LTC2497_CHAN(11, LTC2497_SGL, "CH11"), \ + LTC2497_CHAN(12, LTC2497_SGL, "CH12"), \ + LTC2497_CHAN(13, LTC2497_SGL, "CH13"), \ + LTC2497_CHAN(14, LTC2497_SGL, "CH14"), \ + LTC2497_CHAN(15, LTC2497_SGL, "CH15"), \ + LTC2497_CHAN_DIFF(0, LTC2497_DIFF), \ + LTC2497_CHAN_DIFF(1, LTC2497_DIFF), \ + LTC2497_CHAN_DIFF(2, LTC2497_DIFF), \ + LTC2497_CHAN_DIFF(3, LTC2497_DIFF), \ + LTC2497_CHAN_DIFF(4, LTC2497_DIFF), \ + LTC2497_CHAN_DIFF(5, LTC2497_DIFF), \ + LTC2497_CHAN_DIFF(6, LTC2497_DIFF), \ + LTC2497_CHAN_DIFF(7, LTC2497_DIFF), \ + LTC2497_CHAN_DIFF(0, LTC2497_DIFF | LTC2497_SIGN), \ + LTC2497_CHAN_DIFF(1, LTC2497_DIFF | LTC2497_SIGN), \ + LTC2497_CHAN_DIFF(2, LTC2497_DIFF | LTC2497_SIGN), \ + LTC2497_CHAN_DIFF(3, LTC2497_DIFF | LTC2497_SIGN), \ + LTC2497_CHAN_DIFF(4, LTC2497_DIFF | LTC2497_SIGN), \ + LTC2497_CHAN_DIFF(5, LTC2497_DIFF | LTC2497_SIGN), \ + LTC2497_CHAN_DIFF(6, LTC2497_DIFF | LTC2497_SIGN), \ + LTC2497_CHAN_DIFF(7, LTC2497_DIFF | LTC2497_SIGN) + static const struct iio_chan_spec ltc2497core_channel[] =3D { - LTC2497_CHAN(0, LTC2497_SGL, "CH0"), - LTC2497_CHAN(1, LTC2497_SGL, "CH1"), - LTC2497_CHAN(2, LTC2497_SGL, "CH2"), - LTC2497_CHAN(3, LTC2497_SGL, "CH3"), - LTC2497_CHAN(4, LTC2497_SGL, "CH4"), - LTC2497_CHAN(5, LTC2497_SGL, "CH5"), - LTC2497_CHAN(6, LTC2497_SGL, "CH6"), - LTC2497_CHAN(7, LTC2497_SGL, "CH7"), - LTC2497_CHAN(8, LTC2497_SGL, "CH8"), - LTC2497_CHAN(9, LTC2497_SGL, "CH9"), - LTC2497_CHAN(10, LTC2497_SGL, "CH10"), - LTC2497_CHAN(11, LTC2497_SGL, "CH11"), - LTC2497_CHAN(12, LTC2497_SGL, "CH12"), - LTC2497_CHAN(13, LTC2497_SGL, "CH13"), - LTC2497_CHAN(14, LTC2497_SGL, "CH14"), - LTC2497_CHAN(15, LTC2497_SGL, "CH15"), - LTC2497_CHAN_DIFF(0, LTC2497_DIFF), - LTC2497_CHAN_DIFF(1, LTC2497_DIFF), - LTC2497_CHAN_DIFF(2, LTC2497_DIFF), - LTC2497_CHAN_DIFF(3, LTC2497_DIFF), - LTC2497_CHAN_DIFF(4, LTC2497_DIFF), - LTC2497_CHAN_DIFF(5, LTC2497_DIFF), - LTC2497_CHAN_DIFF(6, LTC2497_DIFF), - LTC2497_CHAN_DIFF(7, LTC2497_DIFF), - LTC2497_CHAN_DIFF(0, LTC2497_DIFF | LTC2497_SIGN), - LTC2497_CHAN_DIFF(1, LTC2497_DIFF | LTC2497_SIGN), - LTC2497_CHAN_DIFF(2, LTC2497_DIFF | LTC2497_SIGN), - LTC2497_CHAN_DIFF(3, LTC2497_DIFF | LTC2497_SIGN), - LTC2497_CHAN_DIFF(4, LTC2497_DIFF | LTC2497_SIGN), - LTC2497_CHAN_DIFF(5, LTC2497_DIFF | LTC2497_SIGN), - LTC2497_CHAN_DIFF(6, LTC2497_DIFF | LTC2497_SIGN), - LTC2497_CHAN_DIFF(7, LTC2497_DIFF | LTC2497_SIGN), + LTC2497_VOLTAGE_CHANNEL_LIST, +}; + +static const struct iio_chan_spec ltc2497core_channel_with_temperature[] = =3D { + LTC2497_VOLTAGE_CHANNEL_LIST, + LTC2497_TEMPERATURE_CHAN, }; =20 static const struct iio_info ltc2497core_info =3D { @@ -182,8 +228,14 @@ int ltc2497core_probe(struct device *dev, struct iio_d= ev *indio_dev) =20 indio_dev->info =3D <c2497core_info; indio_dev->modes =3D INDIO_DIRECT_MODE; - indio_dev->channels =3D ltc2497core_channel; - indio_dev->num_channels =3D ARRAY_SIZE(ltc2497core_channel); + + if (ddata->chip_info->has_temp_channel) { + indio_dev->channels =3D ltc2497core_channel_with_temperature; + indio_dev->num_channels =3D ARRAY_SIZE(ltc2497core_channel_with_temperat= ure); + } else { + indio_dev->channels =3D ltc2497core_channel; + indio_dev->num_channels =3D ARRAY_SIZE(ltc2497core_channel); + } =20 ret =3D ddata->result_and_measure(ddata, LTC2497_CONFIG_DEFAULT, NULL); if (ret < 0) diff --git a/drivers/iio/adc/ltc2497.c b/drivers/iio/adc/ltc2497.c index eb9d521e86e54def0493ea0e81f63b37900c56a5..cd3d00a8ffcb44107c9ad948913= c97db9412b5f5 100644 --- a/drivers/iio/adc/ltc2497.c +++ b/drivers/iio/adc/ltc2497.c @@ -18,7 +18,12 @@ =20 #include "ltc2497.h" =20 +/* Optional second byte fields for LTC2495 and LTC2499 */ +#define LTC2497_EN2 BIT(7) +#define LTC2497_IM BIT(6) + enum ltc2497_chip_type { + TYPE_LTC2495, TYPE_LTC2497, TYPE_LTC2499, }; @@ -85,8 +90,28 @@ static int ltc2497_result_and_measure(struct ltc2497core= _driverdata *ddata, return 0; } =20 - ret =3D i2c_smbus_write_byte(st->client, - LTC2497_ENABLE | address); + /* + * Chips with temperature sensor support (e.g., LTC2495/LTC2499) + * require a two-byte command format to select any channel. + * + * To read the internal temperature, LTC2497_EN2 and LTC2497_IM + * are sent as the second byte. To read a voltage channel, LTC2497_EN2 + * is sent, which sets the default configuration: simultaneous 50/60Hz + * rejection, 1x speed, and gain=3D1. + * + * Chips without this feature use a standard single-byte command. + */ + if (ddata->chip_info->has_temp_channel) { + if (ddata->chan_type_prev =3D=3D IIO_TEMP) + ret =3D i2c_smbus_write_byte_data(st->client, LTC2497_ENABLE, + LTC2497_EN2 | LTC2497_IM); + else + ret =3D i2c_smbus_write_byte_data(st->client, LTC2497_ENABLE | address, + LTC2497_EN2); + } else { + ret =3D i2c_smbus_write_byte(st->client, LTC2497_ENABLE | address); + } + if (ret) dev_err(&st->client->dev, "i2c transfer failed: %pe\n", ERR_PTR(ret)); @@ -131,6 +156,12 @@ static void ltc2497_remove(struct i2c_client *client) } =20 static const struct ltc2497_chip_info ltc2497_info[] =3D { + [TYPE_LTC2495] =3D { + .resolution =3D 16, + .name =3D "ltc2495", + .has_temp_channel =3D true, + .temp_scale_mV =3D 12250, + }, [TYPE_LTC2497] =3D { .resolution =3D 16, .name =3D NULL, @@ -138,10 +169,13 @@ static const struct ltc2497_chip_info ltc2497_info[] = =3D { [TYPE_LTC2499] =3D { .resolution =3D 24, .name =3D "ltc2499", + .has_temp_channel =3D true, + .temp_scale_mV =3D 1570000, }, }; =20 static const struct i2c_device_id ltc2497_id[] =3D { + { "ltc2495", (kernel_ulong_t)<c2497_info[TYPE_LTC2495] }, { "ltc2497", (kernel_ulong_t)<c2497_info[TYPE_LTC2497] }, { "ltc2499", (kernel_ulong_t)<c2497_info[TYPE_LTC2499] }, { } @@ -149,6 +183,7 @@ static const struct i2c_device_id ltc2497_id[] =3D { MODULE_DEVICE_TABLE(i2c, ltc2497_id); =20 static const struct of_device_id ltc2497_of_match[] =3D { + { .compatible =3D "lltc,ltc2495", .data =3D <c2497_info[TYPE_LTC2495] }, { .compatible =3D "lltc,ltc2497", .data =3D <c2497_info[TYPE_LTC2497] }, { .compatible =3D "lltc,ltc2499", .data =3D <c2497_info[TYPE_LTC2499] }, { } diff --git a/drivers/iio/adc/ltc2497.h b/drivers/iio/adc/ltc2497.h index 64e81c95a3dd05911b6717c09ac0560c9f47f304..dfe2d5c30017adeb3f17e57fc5b= f1e0e792ff30f 100644 --- a/drivers/iio/adc/ltc2497.h +++ b/drivers/iio/adc/ltc2497.h @@ -7,6 +7,16 @@ struct ltc2497_chip_info { u32 resolution; const char *name; + /* + * Represents the datasheet constant from the temperature formula: + * T_Kelvin =3D (DATAOUT * Vref) / temp_scale, where Vref is in Volts. + * + * To allow the driver to use Vref in millivolts for the calculation + * and also to avoid floating points, this stored value represents the + * datasheet constant scaled by 1000. + */ + u32 temp_scale_mV; + bool has_temp_channel; }; =20 struct ltc2497core_driverdata { @@ -18,6 +28,7 @@ struct ltc2497core_driverdata { u8 addr_prev; int (*result_and_measure)(struct ltc2497core_driverdata *ddata, u8 address, int *val); + enum iio_chan_type chan_type_prev; }; =20 int ltc2497core_probe(struct device *dev, struct iio_dev *indio_dev); --=20 2.43.0 From nobody Sat Oct 4 14:35:18 2025 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C886A2FE06D; Fri, 15 Aug 2025 10:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755252132; cv=none; b=kEPOOqKmJTkjJyOCbFBoMmY0qInC0oQ5fRp1pVKGn12aqElg2C2sRuHBuCQE/8sJ+M5lVV/Tgxc4aRukoCFWNi3AbvG8vyIdwJrz19FqYUPczIfa/mWfHJtotDZVheNK4HLAG1tuHvyhlpdeEfH1aTyCO+auNE/Hzwikc8L33qI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755252132; c=relaxed/simple; bh=sw/GxrjNBfbj/4YWc+dvIqX6eB1g/so/jFMom8jSTms=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FA8HxsV2YLQyhUCGegDV8/cLbSEkoTeBsEDiDDQLrWovIxW0RrTTH2kjzMTWrMMiS8bk9XVITX0/K5IskKwTxVoTujLGKktfZC4wOMev6F+64VYnLzGFv4Co38ovKyASdr0Edjua9ZeXjU6hWZKZ4hGozt6W213j5Geoe8cFu9I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UaKXJR+4; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UaKXJR+4" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-afcb731caaaso245985166b.0; Fri, 15 Aug 2025 03:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755252129; x=1755856929; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hSHiYv82zlQIjN/InQskDU2zSOHyGcoOeUDBehBVTYs=; b=UaKXJR+4Qao7Db1GQsHwiJGhOiDFtFvdfSy0Fmtedgv5q0SfYKjAMNfbw0K+y+QJYC oGaR6GLWSy5DPbmDRiU+7XOreFJ7JZ6Jyre8iyCCT2YOXEBssXVjPBZzuosJuZsYkafB Ve4QnrE7MOKIRjOPsQtkqjI3L7yXF2Csoh0OMGKAiMij4oxbPyP1LB0x/uyxO8mG79rd TfWJz2hln9UsChiegWe0+f205gecUvULQVl1o04as1jc0Cm2fgS08y5tK8lV58LU00+Y 7pAZTQOBPeMd+vOuosVMSsUy8ZOu0C2oLaKlWZynW7ZEOGAgNyTAhQopdmGRnXxDURoO 0ojA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755252129; x=1755856929; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hSHiYv82zlQIjN/InQskDU2zSOHyGcoOeUDBehBVTYs=; b=jM6nz/xy65Xrt9F9LW5IwmtQSu3ctzk9F3fL8BBOclWCzsZmyA/W88znSuMow/Ojox T0RzSDCG2hp7qYzpKl0NTucoY9jDjYw9AYdiibwRBZLVRVExwaHoJuaaCzpShbn2zPyf 5bBtzM7KQDXb7wZRHHQL0j1h9gURwkybkmpAOwJ1TLoGcXfo9crr3m1LTmzAFnhSrXgf IWhomuRzqalXBa9R+SmA35mzC9br8xGivJqNqzqqru53BWYAEFamKjI5FOYd71nCO61W xH9YAUx+pnzkTcCGRcqAEDqD5yQCq3WW9ydNzUcuyOb0Nvkln/3at76+oLl56N5ZAHF9 VCPw== X-Forwarded-Encrypted: i=1; AJvYcCU/jcI+MDXTJNJSKhJ4vTPyltr4aBX3gqXiwkhlujzkEt5ScY74u3inxJ0Yt7T3k95tlnCgvmJt+ocSMsv+@vger.kernel.org, AJvYcCUz585K39GW9JfFKpF0a/WHorugpzD1qDA3wEvtC3k3znl1Ka5rcJUTWcDGiRzDRtTxgcrIxRosPcYn@vger.kernel.org, AJvYcCWOVbU/PNbug4x9KJzV6ZyK7ZxyGKxS2TDpNsexBD34wEDHDGOkbM51nWnrU+Tm9wMQhYa3Sxl7tw/P@vger.kernel.org X-Gm-Message-State: AOJu0YzU/cx/+u436qYAi3G6b5RgFa/6+FndEfXhQgSlzqa37XTsM0R0 cfxqJx8qkGaBxoVuriYPfnO5gXH663cOH2N1RbcTY0NQYcUe7dhgmfnN X-Gm-Gg: ASbGnctKsrbTPfkl6ho7oBUFf1zmgoSKdunlgkorciU9tFaLMWBPqYs4UGUpGVg9sbW J3QAD7Qm9skXLPESYNQhYml7TN8o8K41LRhJ4lZ0OTSdr3uuQFv2RaGLGuQaQB2BvIRp2xGc3Vv +iv1xHrrMFTc8ZweiT+bKqmSyvU0Y4vCxHAkIvv7MVgmuO1rf2ObbFUOXLy1FqpagiuxkQYmPVJ CWcG1k3NAtXtSH6Oesi86eqjiYrdscUkMWSUt5HNM7SvheLoWI06oW4jsM12IGl6MTRg3X9zOE4 W3D+9/GB3eAA6vNMg+0j3Z6RVhtXdYbmmLHIVVBDh33cc4+RmakWsma5W8+iCm7AQD1APITdujj u+Vvh3mdLJuGtcc0289B5h2OnlvG2 X-Google-Smtp-Source: AGHT+IEYbc66YvfCs6ShJHKZ/L9mKZnKgiRZcakuMlRBlVprbCd3+5uLUPKmYBIOV4eOJnJJE3XQuw== X-Received: by 2002:a17:907:961a:b0:afc:d5a3:90c1 with SMTP id a640c23a62f3a-afcdc3f8108mr128940366b.55.1755252128842; Fri, 15 Aug 2025 03:02:08 -0700 (PDT) Received: from [127.0.1.1] ([185.177.137.147]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afcdce72d5dsm119031766b.37.2025.08.15.03.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Aug 2025 03:02:08 -0700 (PDT) From: Yusuf Alper Bilgin Date: Fri, 15 Aug 2025 12:02:04 +0200 Subject: [PATCH v4 3/3] iio: adc: ltc2497: reorder struct members to fix memory holes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250815-ltc2495-v4-3-2d04e6005468@gmail.com> References: <20250815-ltc2495-v4-0-2d04e6005468@gmail.com> In-Reply-To: <20250815-ltc2495-v4-0-2d04e6005468@gmail.com> To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Beguin Cc: Michael Hennerich , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Yusuf Alper Bilgin X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1755252124; l=1725; i=y.alperbilgin@gmail.com; s=20250811; h=from:subject:message-id; bh=sw/GxrjNBfbj/4YWc+dvIqX6eB1g/so/jFMom8jSTms=; b=d8g6Yo0+oXnGNBwncQwM8nzxDDbU3Xg4nhfwKFfM0Gd3Z60y0JOkJJalMl1+97MwIdolHEXkr XPOsP/1BqziAE0nEMLH4u/RL5aMtRxQL4RVjbRLf3QF11vrwOUecqm+ X-Developer-Key: i=y.alperbilgin@gmail.com; a=ed25519; pk=FtW2oyQ0+xlYU0XmhYiJYC3lNPtPrgeE6i4WXPwaFnY= Reorder members in the `ltc2497_chip_info` and `ltc2497core_driverdata` structs to eliminate memory holes identified by the `pahole` tool. Confirm via the `bloat-o-meter` that this change has no significant impact on the final code size: | Object File | Total Size Change | |-----------------|-------------------| | ltc2497-core.o | 0 (0.00%) | | ltc2497.o | +2 (+0.10%) | | ltc2496.o | 0 (0.00%) | Signed-off-by: Yusuf Alper Bilgin --- drivers/iio/adc/ltc2497.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ltc2497.h b/drivers/iio/adc/ltc2497.h index dfe2d5c30017adeb3f17e57fc5bf1e0e792ff30f..48e9f74870ab489b5df6e69a394= 46610c6a72b93 100644 --- a/drivers/iio/adc/ltc2497.h +++ b/drivers/iio/adc/ltc2497.h @@ -5,8 +5,8 @@ #define LTC2497_CONVERSION_TIME_MS 150ULL =20 struct ltc2497_chip_info { - u32 resolution; const char *name; + u32 resolution; /* * Represents the datasheet constant from the temperature formula: * T_Kelvin =3D (DATAOUT * Vref) / temp_scale, where Vref is in Volts. @@ -20,15 +20,15 @@ struct ltc2497_chip_info { }; =20 struct ltc2497core_driverdata { - struct regulator *ref; - ktime_t time_prev; /* lock to protect against multiple access to the device */ struct mutex lock; + struct regulator *ref; + ktime_t time_prev; const struct ltc2497_chip_info *chip_info; - u8 addr_prev; int (*result_and_measure)(struct ltc2497core_driverdata *ddata, u8 address, int *val); enum iio_chan_type chan_type_prev; + u8 addr_prev; }; =20 int ltc2497core_probe(struct device *dev, struct iio_dev *indio_dev); --=20 2.43.0