From nobody Sat Oct 4 14:35:17 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 777DA2877D7 for ; Fri, 15 Aug 2025 01:45:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755222324; cv=none; b=hvJ9djPyz8kvfvup/AGuH4yKOFVmYHLfoWhmMHZHvnovqhUygO3yXQuQEWYXBfhekof2Y0hXVtn4A5m0IR3D2OaMjE2wsep8Wz994hbdljWENOONH3t9SDyLJUcX/Dk+k2UPJcJMOO2NUr6bhLUGqAlP1Ostv1Mo72y/ic+2FRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755222324; c=relaxed/simple; bh=Ooh4F6PH697oKIemfVheQzHdNaYpbQC31p+1w2jl4Jc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rg1vT/mg16c4/xnolyfSqWijS3KlOrbhGwrEd6etN4E8MFeUzA3X2tz/+eDL2wJstsAoMs2JyVFXq8pa9jEpkVy0E2JckQ5E1nr9BVHcur4uG/z/NEUhtwXPXid8tp9fYg6ZT3XU8RtlF8h7HaPWfbBUFOigotEyDyljysF8Tvw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M93puMou; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M93puMou" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57EHY6Om002794 for ; Fri, 15 Aug 2025 01:45:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f2JJpNn1stvDlteeqX4h1Cq06+aEkFey/378SB+Go3s=; b=M93puMouYWldia7v EGGfEOnkU6CZm+O1LhdzImwJn4mzZXeXy4wdHj64ihFoeVzxkLcISt/fmFFnKoUM o96Nr1JYaVHXX3glaEpkJ0U3WZnvioThOyLjoyn15F1/XoRFmRasElUdYqLlLm+9 ZQQaBKsM3lyB9HjQJgNC5EFae/qBbfdXIL24RIMsLNzip97RH94XiZshcquLqxRH aiSGoxFRqcp9802s0pNkKHFbpGHuVQDXWAMAhpaj/JfohpCmGDIAqgPHJjzXud0s 7w0ioKn0iVPZfGi+DKslCpwYvv5bmsnKGgE1CK4fOKqF/sBt/ssj9vPJvqu4FO7i 7mAEMA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48dxdv9n5x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 15 Aug 2025 01:45:21 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-32326e6d8a9so1644262a91.3 for ; Thu, 14 Aug 2025 18:45:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755222318; x=1755827118; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f2JJpNn1stvDlteeqX4h1Cq06+aEkFey/378SB+Go3s=; b=hoQKdXUDyXQ8tZ/tEwBNrO2NYE8Jibav6rSBhUV47srMd2kpB84j8EyaDstt1w7oR9 bY0cs1/MXPDuJ61TDUzzPf+YAPI+6L4L9rHgTjwdNAIk5QU20I1BbRpkLu6pVNDSrqd5 X3IXGXOtX/ytd8Bo47uyJD5MOFmJ42b6LFaMsvF3SH0MCsOVZABnHntNJtpdmJKusrn9 cK7xQO1N0wtanOY83cAsVKy8Lef6lKNGaJyEOteJeNUoDdKEY4oq9oz9iHTowysLQWLV mMxDplK94ZIhItSku7H8gJ+HdJFHwlIpaRLBJ92cINhLjoTp2jIzsnzR7NwQrxXETbH3 0xKA== X-Forwarded-Encrypted: i=1; AJvYcCWmDE7vYmileK+TFHDfvL4p7n5HKPeZzPtE55tt2fiyRImt7uTbkp1cNcW7yiZ4jTniMeJoHPid7g3rVgA=@vger.kernel.org X-Gm-Message-State: AOJu0YzBAgzFSizN+AX21OTVhVNljrPHWPZBC2aNSLd2KPyOTWjNdXrm UoKy3OviFGzwlwEWEnvWzsrYtNxwNegtHnaPjHLWTzwsP8QV+D50Yc3USnkwPpJl2F6aeqRoYQZ ZeIP9SpRibyJj8SlOQdkt5GGBNHk2T53YkBKWx51Fhv+B6Nu/hQn4bVjvHUZ1Zc1QylI= X-Gm-Gg: ASbGncuMkTlPUy+p7U5JNK+uScPAVrUOmNFmSGTtp9oAxfk9k5NnEpIXYN//sM5Xd6v EjfjOhSRxirrsOzGTrEi528Yt+PDU4p6M7zuBqQ4ogp2DJHn463GV9SXEb5P8vWlqfs5z7XV7nU gnUORRwZm0P1jYQ3Pd9nqQAMxeR1KsINUoajtMjEARWkt4X9+uOM1Q75+SQNDcKzqRma2Af0xWj KaDrAPZaCe5S8KeHR8/nIArwiixmfG6wkJ0BJW7c/eBlKH9ZFuUGNmOuCYlGX8ghqv4RK+m4rgU aFMiBVqmIYllBlijgrOXh0C9mGvS0mBWMerAwChg93U1n6F+Lm9qM/PHGM1UyZ0UdtQCUn35+BB 8qKshhSBMX52KDm4D X-Received: by 2002:a17:90b:180d:b0:321:7a2f:985d with SMTP id 98e67ed59e1d1-3234216190bmr588152a91.25.1755222317986; Thu, 14 Aug 2025 18:45:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTATHglsejKDU1aURWUA2qjKt/Z9C08Zt0r1OWZF/vn9I1mLXPEpEoSQOPZtYki1JSB3Pf3w== X-Received: by 2002:a17:90b:180d:b0:321:7a2f:985d with SMTP id 98e67ed59e1d1-3234216190bmr588123a91.25.1755222317407; Thu, 14 Aug 2025 18:45:17 -0700 (PDT) Received: from [127.0.1.1] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b472d7735f4sm20273a12.48.2025.08.14.18.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 18:45:17 -0700 (PDT) From: Baochen Qiang Date: Fri, 15 Aug 2025 09:44:56 +0800 Subject: [PATCH ath-next 1/3] wifi: ath11k: downgrade log level for CE buffer enqueue failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250815-ath-dont-warn-on-ce-enqueue-fail-v1-1-f955ddc3ba7a@oss.qualcomm.com> References: <20250815-ath-dont-warn-on-ce-enqueue-fail-v1-0-f955ddc3ba7a@oss.qualcomm.com> In-Reply-To: <20250815-ath-dont-warn-on-ce-enqueue-fail-v1-0-f955ddc3ba7a@oss.qualcomm.com> To: Jeff Johnson , Kalle Valo , Carl Huang , Karthikeyan Periyasamy , P Praneesh , Sriram R Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, Jeff Johnson , Balamurugan Selvarajan , Ramya Gnanasekar , ath12k@lists.infradead.org, Baochen Qiang X-Mailer: b4 0.14.2 X-Authority-Analysis: v=2.4 cv=IuYecK/g c=1 sm=1 tr=0 ts=689e9131 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=4avV6w9vhD41MOPHW_EA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: 3iwDO51G__Xb7CFuteceYEwVHnQROfIh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA5MDAyNSBTYWx0ZWRfX0WSHpqlJD/7U HqM+v9xSQf7+J88IbFrO7Qh02djKIQll03uno38Q0crkDZa6dbJVidNaAKQMPtDvKaZI6h7Ynpu fMwFVRV8dRjiaCqSZxL3xezw06UgkvFfZ2w4244rutwf0HgVRnR09ULY6k7feC3F3TaE0U4+l6a 4FQ032HMVzjkYpbd8M+iKoLziB1VAjCWB+dKQyoWqLjLrjhaaesmFIp8oTt9bODckz5JfD4Q6D1 aOA+ooKensNFKhqjQOC8IfMzDdsn5HoIJn/rUcdYaJsOdalmm2DAJtD6ZVcG6tfSnj2RmK00Rb9 LoDvXNHaOIxEt4nWd8IiO7AXMTKFpqtL+HeWw2IbH5hLc/+EGzLn68W2fxzq1TFITKOZYx6ihSG nvHo2Xy4 X-Proofpoint-GUID: 3iwDO51G__Xb7CFuteceYEwVHnQROfIh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-15_01,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508090025 There are two rings involved in the Copy Engine (CE) receive path handling, the CE status (STS) ring and the CE destination (DST) ring. Each time CE hardware needs to send an event (e.g. WMI event) to host, CE hardware finds a buffer (to which the tail pointer (TP) points) in DST ring and fills it with payload, then hardware fills meta data in STS ring and fires interrupt to host. Please note the TP of DST ring is expected to be advanced by CE hardware before interrupting host. While handling the interrupt, host finds that DST ring buffers are used hence increases rx_buf_needed to record the number of buffers to be replenished. Note before that, host compares TP and head pointer (HP) of DST ring to see if there is available space. Normally rx_buf_needed simply equals available space. But sometimes CE hardware doesn't (for whatever reason) update TP timely, making the comparison fails, then enqueue is cancelled and a warning is logged: ath11k_pci 0000:02:00.0: failed to enqueue rx buf: -28 However even enqueue fails this time, rx_buf_needed still records the numbers of needed buffers. Later when TP gets updated correctly, the missing buffer will be eventually replenished. And there is no doubt on the late update, it always comes (or lots of such warnings should be seen). Since this won't cause any functional issue, downgrade logging level to avoid misleading. Compile tested only. Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D220269 Signed-off-by: Baochen Qiang Reviewed-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath11k/ce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/ce.c b/drivers/net/wireless/at= h/ath11k/ce.c index c65fc9fb539ef10ba44f1c1d5571462b40fa098d..a7a163621b21067ba5a4f96131a= afdccfbda3d03 100644 --- a/drivers/net/wireless/ath/ath11k/ce.c +++ b/drivers/net/wireless/ath/ath11k/ce.c @@ -354,7 +354,8 @@ static int ath11k_ce_rx_post_pipe(struct ath11k_ce_pipe= *pipe) ret =3D ath11k_ce_rx_buf_enqueue_pipe(pipe, skb, paddr); =20 if (ret) { - ath11k_warn(ab, "failed to enqueue rx buf: %d\n", ret); + ath11k_dbg(ab, ATH11K_DBG_CE, "failed to enqueue rx buf: %d\n", + ret); dma_unmap_single(ab->dev, paddr, skb->len + skb_tailroom(skb), DMA_FROM_DEVICE); --=20 2.25.1 From nobody Sat Oct 4 14:35:17 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DBE42877F1 for ; Fri, 15 Aug 2025 01:45:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755222325; cv=none; b=IaynzLXP4L6jls8uIf1Xbwo4uSpefGssOoR6DQLAkfROpDA69DNV0QG/2iQzvGwbB5gMudSRS+wRZvM0lKOIEq/YvNw+RyI3KpkPmcMmtuv9P1ofcZYETUnarschQtUexwXIrDVT6u16sXxurmIXWRwuuFISDK7vpfBh+0z+O9Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755222325; c=relaxed/simple; bh=Ddu7QujtO4Q6hfp1GuZr8ES+Bm9lIQeS5W0/PaWsaOE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OMc9PmxO4AFmVqLybH0e3+zzoUGXCn4MS/WPQefm1HjnFftMlRjkhu9BfyUf4NSbh6rRBo7AQu67b4aU8NKaltSkMV+z0Dg/n90jIjKhEY5z9tfDmfNt3wXMJ6VgMHF4zuUiqlHiZ6EA7LUpOkkhV5ksDuD+gjK4Ia7G/9RC2Cc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EgSM5PxS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EgSM5PxS" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57EITVQF020726 for ; Fri, 15 Aug 2025 01:45:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kxYCF6nACau5/iqJnJgpcLYWSFZCwi7it4PbOasdPHM=; b=EgSM5PxS9S52676e gr39z/Y+zJqcax4+6Mu1IB5gYTTb30zEpnXeH/97wK9CWV9UrxxC2wNIhtVhHUet MReBct0n4WQlCksmNam2iwpdckpnjTH7QN2b9AfyhcTfh1tvE19Z5fYLwuC94rzO lBaRSxDcpXDwALplPpCYMcxFKojrTwycsK7tq5iCYuOVtpS0mflrBe33M/+UyL13 TqOkJjiH3XmxJQp5Pz3l/84Ncl8Lq5sefQSgwN1dR0yu4Tg+HBg46Ln9MAQ7IcrV hSN4GnUHqfq6DR8gF8eA6MWUyOxACkeI5RH3OiKy1oPwTasHxDkFHLHGwwsC8tQ6 R7Tiuw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48dw9t1vjb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 15 Aug 2025 01:45:22 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-323266dcf3bso1504742a91.0 for ; Thu, 14 Aug 2025 18:45:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755222322; x=1755827122; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kxYCF6nACau5/iqJnJgpcLYWSFZCwi7it4PbOasdPHM=; b=xUYbW4ztylxy0YUZ88YmcJABKeRKCkHS0FO39DyCCQJSLerX+MYv7M9iTLxnAc1fLM ljyFaVTy2T3XaR9ah3B9dR3Ddv0kQWNk6ohB6t4oyjlV5ee4vEDIr+yBPNrg/Mcnzody 3/VYc4T7n8GmgDfc6aQG7gZbrOUvUwEOPGDB9MRQyCCco9RFKFC4718YvleVZjjTAXe8 QO3veBDBA1qmIfpoKxsOH0MVaMYip/7qEg+Wu9y5QJufStXiM+JkqyGbc+POmpMA6IY/ uusT9ssWimvVuX0E3iO6nkQPL+MXAnTyVs2zB6Yt+f23JpCtC/rF7WFJU/FUflgGGSjE tw2Q== X-Forwarded-Encrypted: i=1; AJvYcCV5wgOAdFJOR6QXNCZVkpP2W+qUAuGORXL2Gils4IrPtOGQ3/hFc4sTbExAadYp0eY4swz7yOFjpX6pIo8=@vger.kernel.org X-Gm-Message-State: AOJu0YwsJfxknyT+HpE9qmCzTNhV6yC9x2FqBq655slb4JRVxEV4rxfw ueSRbiEVWf5IpY3hiupjy1WeCiJ/cAkrdpErynZw7dSAOie2lv6LdqmacJO0RKasArpIxiLXzoT ZF6zVgTRXvxlC8EHc2hzH5HKSObaJTC9OeTULK4x1P3jvSZA+E+vnEqr1jk+sQyu6ps8= X-Gm-Gg: ASbGncsNd0B6g81EFIgP/WoR9AdcjwMJUnNi0zbrwXHiYJ1Ok5Irv2wIlKA8OYMKn6Z eozm7yVttz/ms3VBkezEHS2nvqyMGm5G/2RnngFh7U9V/BBwkbUQvXTlb8MtnAxd2EGk71Ref/T rrbgztpck+/liFzD41EvXJkNyMTXDPeGrFbq5KcUt4U+IeDZnMRGrdhyzJg9icJj68TdvfdfT8I aMisvBu8fEVunUkcj9loKuynhG2Y1WjugAxIwVTHeAPGH3/vGvSZRSscjBekY/il88Hzpn8yBKA RxaHMy5wpBbw2JNR8Ewa4PMsofZ/jWekw7XQv15Rq5+4rtcC+ryH10X9L/YRtqaUa7bP5xxL86Y VCP/9UhVruFru3nd6 X-Received: by 2002:a17:90b:2542:b0:31f:150:e045 with SMTP id 98e67ed59e1d1-3234224bd01mr480284a91.32.1755222321534; Thu, 14 Aug 2025 18:45:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHp4WB24m89Yhcn0ioUDH1nUmYAvdRLnZOaTdAnGSAHnM7xxPbWq3Z6LhNQhmBtmQrugKO+wg== X-Received: by 2002:a17:90b:2542:b0:31f:150:e045 with SMTP id 98e67ed59e1d1-3234224bd01mr480246a91.32.1755222321004; Thu, 14 Aug 2025 18:45:21 -0700 (PDT) Received: from [127.0.1.1] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b472d7735f4sm20273a12.48.2025.08.14.18.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 18:45:20 -0700 (PDT) From: Baochen Qiang Date: Fri, 15 Aug 2025 09:44:57 +0800 Subject: [PATCH ath-next 2/3] wifi: ath12k: fix wrong logging ID used for CE Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250815-ath-dont-warn-on-ce-enqueue-fail-v1-2-f955ddc3ba7a@oss.qualcomm.com> References: <20250815-ath-dont-warn-on-ce-enqueue-fail-v1-0-f955ddc3ba7a@oss.qualcomm.com> In-Reply-To: <20250815-ath-dont-warn-on-ce-enqueue-fail-v1-0-f955ddc3ba7a@oss.qualcomm.com> To: Jeff Johnson , Kalle Valo , Carl Huang , Karthikeyan Periyasamy , P Praneesh , Sriram R Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, Jeff Johnson , Balamurugan Selvarajan , Ramya Gnanasekar , ath12k@lists.infradead.org, Baochen Qiang X-Mailer: b4 0.14.2 X-Authority-Analysis: v=2.4 cv=J+Wq7BnS c=1 sm=1 tr=0 ts=689e9132 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=fHvqFdtNKkU2r1BsT3EA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: 5NyJLJsB4wC0H-KRfPw5Nv4yuf_9l8Tt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA5MDAxNSBTYWx0ZWRfXxkECpRgqWRvs bKuSXwVGtDYQk+Q7tyQw7/xUZO0tJUOjmNMNk2Wgc1w4ZGoFmdOabVdKKMAyFPKhgVV82hqynVV jwE/3IWVTUDPHnXyuUKOL+POlHFdAg6/7bf6y6tJyvarYiJghbY9M2PRFIoHdawnRrAbmk0J2Zs x7B50/dxGAtIVAJoazGagdK9bMgo4JRKkiK1l0FwRpEtUE1hLl0Eu687nMTe+2bumo5308Jy4bn Nz0seOSXmYVFNWhsSRQJzeDhFUHfdM5wUHhxuAxJKtuqyNgAegAeUp9/36Zg4ofQUdpjLEV8ouX +YcvhCgV8+aovQZbLF34cOQwAM17KaC3n0+QZbJB60zVjVwTf33O4tlpVZwqrh9qhyxcvL0zL7g yX2RayyY X-Proofpoint-GUID: 5NyJLJsB4wC0H-KRfPw5Nv4yuf_9l8Tt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-15_01,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508090015 ATH12K_DBG_AHB is used for CE logging which is not proper. Add ATH12K_DBG_CE and replace ATH12K_DBG_AHB with it. Compile tested only. Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") Signed-off-by: Baochen Qiang Reviewed-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath12k/ce.c | 2 +- drivers/net/wireless/ath/ath12k/debug.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath12k/ce.c b/drivers/net/wireless/at= h/ath12k/ce.c index f93a419abf65ec6e9b31e22c78c8c2cdd7bdbc76..c5aadbc6367ce0d18080bb0e15a= 88d3ddf2e34ff 100644 --- a/drivers/net/wireless/ath/ath12k/ce.c +++ b/drivers/net/wireless/ath/ath12k/ce.c @@ -478,7 +478,7 @@ static void ath12k_ce_recv_process_cb(struct ath12k_ce_= pipe *pipe) } =20 while ((skb =3D __skb_dequeue(&list))) { - ath12k_dbg(ab, ATH12K_DBG_AHB, "rx ce pipe %d len %d\n", + ath12k_dbg(ab, ATH12K_DBG_CE, "rx ce pipe %d len %d\n", pipe->pipe_num, skb->len); pipe->recv_cb(ab, skb); } diff --git a/drivers/net/wireless/ath/ath12k/debug.h b/drivers/net/wireless= /ath/ath12k/debug.h index 48916e4e1f6014055bbd56d5c71ef9182c78f3b6..bf254e43a68d08f97171d9baffd= 0ebc3aabfb3e4 100644 --- a/drivers/net/wireless/ath/ath12k/debug.h +++ b/drivers/net/wireless/ath/ath12k/debug.h @@ -26,6 +26,7 @@ enum ath12k_debug_mask { ATH12K_DBG_DP_TX =3D 0x00002000, ATH12K_DBG_DP_RX =3D 0x00004000, ATH12K_DBG_WOW =3D 0x00008000, + ATH12K_DBG_CE =3D 0x00010000, ATH12K_DBG_ANY =3D 0xffffffff, }; =20 --=20 2.25.1 From nobody Sat Oct 4 14:35:17 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C16072877D9 for ; Fri, 15 Aug 2025 01:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755222328; cv=none; b=kEdT5LEl2TbZlfLrG66Aqb8KTj8UiOwcgek+0Ra4OmJPNviek/PScpMxV0V5S/jOhb2b1vyYOrii+GLuQfi3fwQ0lLC2Tz684eyItb7Ib1Cn1XtELGG+k9Vnk5SRumVAEdLJiUyAsVNYkH71NJw/v4h6zVLnw4l9ykHxg5fdInM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755222328; c=relaxed/simple; bh=rlydFC+d2bX9ULKW8mN9KviQO2RPvRtnZWR6YiURGYk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mv90nwQccPMQvUerdwIKf72sIDgkzBHNgpYGRglLZ6yI8n6KowsA7MGnJAqf+XNX5vddeFb7YiZylMDREefWaowWIIgej7IV2svO/T190e46Ub3ALuAsi58jCrwHl2/TfadTW6CMU7NzXg0pSmntpjxPoRmHpR5Y05MTO4YmSdU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fd03oLg3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fd03oLg3" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57EIRGEI012963 for ; Fri, 15 Aug 2025 01:45:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zlsOJK5oVN3gW0ovDjkscdY5GxIZWuWXxKFxu34qXhg=; b=fd03oLg3y6Izcc+W BLyxaO7osrOdVreAQhjHOBb6GhsBuVA4cWyhIk5ocH0aY9b38jRJlIFJkxTuJG6P Ee2MKkKfvg2GA0t4Iqkl9/vqJ2K5YvwAOoBzs8WQl7Gl4+i6VPrljH8BXk12iEL5 xdjBO/ymfts83GSNuHuPILo2TRkSfAzq5+/2s4QjJmxNZ+vIe4qkVhkkgxIE13IA KXdh4WxKoHoijmCOME0VmuVRQBhCB2789HTEXBxFZR3X5p8jzSLxJwDlLjXHt5M+ DSO78aXZBxlYv2pUyuek9y38NV0C2iPJsaKAuOBY4LFbT3QobQruNIJWf8EF+JhL bMK+KA== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48ffq6whpq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 15 Aug 2025 01:45:25 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b4716fc56a9so1844397a12.0 for ; Thu, 14 Aug 2025 18:45:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755222325; x=1755827125; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zlsOJK5oVN3gW0ovDjkscdY5GxIZWuWXxKFxu34qXhg=; b=aKZbo8KqnbyxTkgGun+U50meCMnQjmJFSnLbEHgsvw7qEYvDqAApqJyX5k517j28FA ScW4LTj689/mnbl9mmcxkPXy6OZqUyvxA8bvVtL+pytFpKKqUFOxDMGboOtLHuHlaTsW QQv/WRUzxSaioVk5CZMh+73U2MNhvGVb//sShL+Ajcz135PCf1WLhIQPI62bLX62dGKc ZVl9NCB/NdA+RXEiqnPdBJt1iKyAyCd8Qp1F9oaXbakp7v7F3sk/eWdVurDRCHZ/ZXic U/6R8Vk9pL015fC0Ys7zsXlilR2aiAtrI34T43SC3nfRFfbp6sYEPyiSO0MSzLXGlv3t Kb1Q== X-Forwarded-Encrypted: i=1; AJvYcCWnXosSaEn4XFrC8MPLjYGLJ1jvFiqQCk7lZHlmFPLSxnaXh8otFDFctzIa/l2+0589wwVV9D6QDp/lyQo=@vger.kernel.org X-Gm-Message-State: AOJu0YxVh5DAVOBY8blubCR2GNc7uz9GllVEX7+CGHkqLZvXX6UlybWC MZlcgDZAaswJphRCeu5F0Pmk6be2QM1pZwxJEQed9i+W95YJMxXPFNat2jfcwZF8v2B5Q3hlmdE uufqQ5QiAVXv5lhsekJNhtQbDG/O3qfJVML2D6LRy7Dl9gjhChk3+bPQF1pDshNdaV6o= X-Gm-Gg: ASbGncvlQn9WZghiorfJWSP2WqptYyqKm/ByKIWHCsFbeS++OJX09VZLsQ9p9Tm78Y9 O80cvAf480oupkJJWYN0mq+PDEBt2fGa0ANGXeC01ilzsE4LHLuZznRQdEF8DWVww6WQm1ZJtwM ZIzOZgSkOIvN8C//NdOr/Zvh1y6MjHeHIm3rjOUofGfXoX4MYxNOXQp96KOjhIX93q0QQJAhbrL C+6X1d83Z4BNJ5aMyZ6/yVicJKS+/JHgoK+8/P2ZTqA6YKWv/lAlbkRPMxen2rB4HukJe01FH9u E8uwPSi0nimUWVZirWHfiyi0v8MORRAf57ZsfxVpRJqsUbv6bC4xlkDCsRUrJCQzyJeBawo+pHb MEOWjswMsktfTUjiI X-Received: by 2002:a05:6a20:430d:b0:238:351a:6437 with SMTP id adf61e73a8af0-240d2f3f71bmr628324637.43.1755222324999; Thu, 14 Aug 2025 18:45:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcAx/TsRQqAm4kbPDgVI2KzEGpjPVvzLo1WQbeY5Z9fq04iIy5aj3QYJ7X0o5DKPHyKP5YAQ== X-Received: by 2002:a05:6a20:430d:b0:238:351a:6437 with SMTP id adf61e73a8af0-240d2f3f71bmr628291637.43.1755222324516; Thu, 14 Aug 2025 18:45:24 -0700 (PDT) Received: from [127.0.1.1] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b472d7735f4sm20273a12.48.2025.08.14.18.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 18:45:24 -0700 (PDT) From: Baochen Qiang Date: Fri, 15 Aug 2025 09:44:58 +0800 Subject: [PATCH ath-next 3/3] wifi: ath12k: downgrade log level for CE buffer enqueue failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250815-ath-dont-warn-on-ce-enqueue-fail-v1-3-f955ddc3ba7a@oss.qualcomm.com> References: <20250815-ath-dont-warn-on-ce-enqueue-fail-v1-0-f955ddc3ba7a@oss.qualcomm.com> In-Reply-To: <20250815-ath-dont-warn-on-ce-enqueue-fail-v1-0-f955ddc3ba7a@oss.qualcomm.com> To: Jeff Johnson , Kalle Valo , Carl Huang , Karthikeyan Periyasamy , P Praneesh , Sriram R Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, Jeff Johnson , Balamurugan Selvarajan , Ramya Gnanasekar , ath12k@lists.infradead.org, Baochen Qiang X-Mailer: b4 0.14.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODExMDA3NSBTYWx0ZWRfX2uYtjphLEfF8 lPkHTikKELPNg1O2m2hDcFtAwG7zhOdfAPOGIc6otLSGiyeYuAKHYAqhzAppKc/153oDROIBgMh XcF9i591V33IB6G3oVicDg/00ojz/OzuyOp+zoZmmPbMn9QFMRfoQopsMykiOy5ir91P8sj55Px C6QP7MgMzSMdRRpECyfsxeu+LNhkfDQIew2dhE+dMErzsggblpamzlyF2sO5zBbgn0DBTpED51/ 9NvQ4ha75AGB+HiMCHvzGr0Oe5ruSlUk/yjYHWgiGtLC6u2ANRwDPXX7o51kTc+ZeiemXln5ICp celc19AIMnIJQN5J2VK9FGm00UFrwj16TNYccdlv42eJhJTv/myda0zmSZMhvCWmEopA9L2l+LN TUu0YgVr X-Authority-Analysis: v=2.4 cv=TLZFS0la c=1 sm=1 tr=0 ts=689e9135 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=4avV6w9vhD41MOPHW_EA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: XQGAguEeSBE4_yVe3eqOP9CenoIr0UlS X-Proofpoint-ORIG-GUID: XQGAguEeSBE4_yVe3eqOP9CenoIr0UlS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-15_01,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508110075 There are two rings involved in the Copy Engine (CE) receive path handling, the CE status (STS) ring and the CE destination (DST) ring. Each time CE hardware needs to send an event (e.g. WMI event) to host, CE hardware finds a buffer (to which the tail pointer (TP) points) in DST ring and fills it with payload, then hardware fills meta data in STS ring and fires interrupt to host. Please note the TP of DST ring is expected to be advanced by CE hardware before interrupting host. While handling the interrupt, host finds that DST ring buffers are used hence increases rx_buf_needed to record the number of buffers to be replenished. Note before that, host compares TP and head pointer (HP) of DST ring to see if there is available space. Normally rx_buf_needed simply equals available space. But sometimes CE hardware doesn't (for whatever reason) update TP timely, making the comparison fails, then enqueue is cancelled and a warning is logged. However even enqueue fails this time, rx_buf_needed still records the numbers of needed buffers. Later when TP gets updated correctly, the missing buffer will be eventually replenished. And there is no doubt on the late update, it always comes (or lots of such warnings should be seen). Since this won't cause any functional issue, downgrade logging level to avoid misleading. Compile tested only. Signed-off-by: Baochen Qiang Reviewed-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath12k/ce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath12k/ce.c b/drivers/net/wireless/at= h/ath12k/ce.c index c5aadbc6367ce0d18080bb0e15a88d3ddf2e34ff..9a63608838ace31587691dd53c1= d4aa8f081cb6f 100644 --- a/drivers/net/wireless/ath/ath12k/ce.c +++ b/drivers/net/wireless/ath/ath12k/ce.c @@ -392,7 +392,8 @@ static int ath12k_ce_rx_post_pipe(struct ath12k_ce_pipe= *pipe) =20 ret =3D ath12k_ce_rx_buf_enqueue_pipe(pipe, skb, paddr); if (ret) { - ath12k_warn(ab, "failed to enqueue rx buf: %d\n", ret); + ath12k_dbg(ab, ATH12K_DBG_CE, "failed to enqueue rx buf: %d\n", + ret); dma_unmap_single(ab->dev, paddr, skb->len + skb_tailroom(skb), DMA_FROM_DEVICE); --=20 2.25.1