From nobody Sat Oct 4 15:52:44 2025 Received: from SEYPR02CU001.outbound.protection.outlook.com (mail-koreacentralazon11013047.outbound.protection.outlook.com [40.107.44.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 088A72ECD31; Thu, 14 Aug 2025 10:21:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.44.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755166894; cv=fail; b=OCBauqiUcB9GwLhrCA6bXaPj67cUA7fUahzUMNlKDJ+mlqaeA+ou9fBezw9RzNmlVICDOu7GyJawKkiGyBMh6VnDfB+tdEFewXIwEQmx2dLr7PV1KuJs1h7nbPf0dkiloCSboLIfuVaKChnlGy7JlxZx7dq4+OBBwNpc66jg5V8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755166894; c=relaxed/simple; bh=rB06RauaRhhT+rcOrwYqWnzhWPXzuu26YttMid7xX5A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=R9W8uVGz3+f4e4Lbf28dmjOv41svLX9q/kaxlvi2c7iB1c44IpH+ktFvYQFkIEBTILTuriwAahlHuSd7rWmJ/X6Ol0+tK2H0QIVs1QJzGBwz1RslqFyuH2dwiO2cMSaNsURbSlAC1QJwE5y3GGKGiTRBAqfzu9M1ZBZot1OfbQE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=iPBnoonu; arc=fail smtp.client-ip=40.107.44.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="iPBnoonu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nthomgXxGXIM7ZrZk/xnjYN7rY/4LBb2cfP4EJvGbWQjf6dsXHkxRJIghPkW6jgpC+xhxH2OsmtPuiK6hwZaPw/vgLjwocdgsNkXCTiejEYdqZm9eYRLyLukF5k4Wrsnd1D9uDrOBteqhWKXvnXbQIq4GxpBvzc+O0pBemDNNeFq5bAPYMECyrxtLRGOcM4DVg/A556dBVbAB9pg9P5Kn9y8/K5wa0E4qlmVjDtgSLezso52RSEbTL6lxlrDoxZCHdhQ1bx9arjozDVmPIQp89ucxKPB/rYhOoIKpQOtgVq1xDsrC6Rl5IqiOuT54Y9yP6JgK7NzOmGSg9yiRsvkww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g66FfNAfdyM/r7sLMHDl0KevB00FRH9DeNz7Zc5iyAY=; b=MtBKoivIxQ6LKw6frwogEPzg5+pndLmOGU6Ynm/o5kVudmzFJVGYAReHkzJy0dvba+53Qtd6JrC3gZ8YEVzlto0frQsqsHp+92mOPii3/7mbUrK5DaAJwcjYjrhgv5blBQJgDRekJXhWEtb4fCpYSUQDUeC8OP2uqIGqJP3Zt94sBmqHxSt+sUjjIr0xTN79FTk7VRXep8ikSCWpBXgrsyLSR/05VHCrJKC3QAw0c1b0T4x5472ODqFR44y7YEHEWV9j6WfNNFhFlbmWPi4h29+H6kqQiUYmd3ttIziaG6VlYrDToPXJIsSKQxiwpfv1LYgIdBqSh0of6vVuvHSLiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g66FfNAfdyM/r7sLMHDl0KevB00FRH9DeNz7Zc5iyAY=; b=iPBnoonuSMvkkJNFYnRUiG7ZDnAWRXQPz9AU5Y4Ro5/XoFgy1g4OJdpDqezHvdSP16BGBb/eqBIWjYpIwKQP+Fyi65bUPjRQWbqwed8LZKORBmk0avlXRFO9bLCp5nEMXIgPylM8tVxOT87ns9k6Obi9vWP/jtCCmCx94cyNSfIoK9YK5V3hes7IjFxW0If3DjbjRez4hGRETqXJkyTRZYLSCENiAdo+ugIPhNJeka/DVbHS/8jOBNK3pTtm6O3Yre5HXZKmUjX1S6OyeFwYHPnKBRic3cxC7JEZlfIY8/6ReUg53x1x1BpMNiAiFjnlgFfHDmfl+DcEYF7IJw+TRg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by TYZPR06MB6699.apcprd06.prod.outlook.com (2603:1096:400:45b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.15; Thu, 14 Aug 2025 10:21:29 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%5]) with mapi id 15.20.9031.014; Thu, 14 Aug 2025 10:21:29 +0000 From: Qianfeng Rong To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , intel-wired-lan@lists.osuosl.org (moderated list:INTEL ETHERNET DRIVERS), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list), bpf@vger.kernel.org (open list:XDP (eXpress Data Path):Keyword:(?:\b|_)xdp(?:\b|_)) Cc: Qianfeng Rong , Aleksandr Loktionov , Paul Menzel Subject: [PATCH v2 1/3] eth: intel: use vmalloc_array() to simplify code Date: Thu, 14 Aug 2025 18:20:53 +0800 Message-Id: <20250814102100.151942-2-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250814102100.151942-1-rongqianfeng@vivo.com> References: <20250814102100.151942-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYAPR01CA0149.jpnprd01.prod.outlook.com (2603:1096:404:7e::17) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|TYZPR06MB6699:EE_ X-MS-Office365-Filtering-Correlation-Id: 304e1c5b-8e3f-4169-cbf2-08dddb1c5536 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|7416014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6WUWzz+qDQ4cHvQc9qrCzCNFC10IORxvig2WkvPvydUvt5CSLEP9LwhMg6bP?= =?us-ascii?Q?4aWolG6q95Ob28ycK9Zpjt6XzCLthFTN2pG1NqQ6RN1Ddb4Cb8I8Y9q49WIO?= =?us-ascii?Q?ovMKkdwXQOdhSZIVFO5INqHwmoOh+ydueNhb0lPTRFuYl/5bIx+0zUbMmQiB?= =?us-ascii?Q?VSeA/yjb+bZD5XEvuNGGpsMq07TK/KVx1xVNW1tq98LHd082X6oTKFZHMd5I?= =?us-ascii?Q?BsDuPKRNolKf+r0kCbdvU3dIFZIgvU86rs9fHz5QXIrea7E4xzZqzvD+KT7K?= =?us-ascii?Q?YP9wxu6G1tExg4Ec1AI03Bp+mYhADXPoGj9FNMZsVSLuixVWMKoFeREaLYDD?= =?us-ascii?Q?zqFYDWDV7+DDAFqIf+lHsHK37dqLJjJ9Fh1zDeIxImboxCE+HZuzI9/qVY33?= =?us-ascii?Q?hS+DuOG5P+UWx2r8i0Y2T78ymyx87NaLbGro0UxKi8z3PcxxJjAWj1ewwD1i?= =?us-ascii?Q?+/LfC57F45JqGZIHKNgonv4YphXYFcua+6MBoc6FYkL161UdiR0mpbIBFjDu?= =?us-ascii?Q?2zRQRJEB1DOtUdR+laHVBpxnkfv0JNtBiw5BbENyvBa2h8msABnmYPTSZTwp?= =?us-ascii?Q?whY+BxPkkLkSzATJhvRv1zgQusQzUEeZlIRbgHMnapdZIeunsPLnIsP+TWga?= =?us-ascii?Q?7+ZmTRDxKbzLY6TUjQuC4Gi3roNEG1hIRD5bbRuNSR63Opqcv3aX5Ugyga3z?= =?us-ascii?Q?GU80x+EfMv6I3HvxY2RTWUCe90swWsYYL0WrY8fJeKNGAuCkpprP8iKGJU7L?= =?us-ascii?Q?ZXQuiijpbiffdMnb3FC3kDrX8NL0l92itNR0VxD5GVNNoWDWnZnaAo8fCkpb?= =?us-ascii?Q?XZaEVwGdmkVO/LnhLOCkdNcaONiBMus3PwNh2TpsC3fQn+S1Q4T3+PLdcSND?= =?us-ascii?Q?syZuXBBHNtLhR1Ncja8W684xa24+D9wvDDdSSnWSzFW9ipyj8HT++mkdSjnv?= =?us-ascii?Q?qmrfv6Fz0VTMVHV/At1bqHSeQzYhu93cySouf5ZwPqJ/xqInHxVwVRGNw0eR?= =?us-ascii?Q?nNccf+QoS9B3jD/3f1FKdXbAN7BRRmBXQsJlnmyeavazB1f2G/QpMYfgBNq9?= =?us-ascii?Q?w7qTQkEeBc5p2PEL5Dup1Um/aTYblMbXReI6v8HrF3A36mgFbA+N/iYZ8VTf?= =?us-ascii?Q?1GTaxbw7sXHOLklv/eFJ6WPwmsVOCeL7N2SBj0Nuk6JUgb1tCEeGS1ItSKOo?= =?us-ascii?Q?zMGCTBur16QXyC8ghSUk82nwvJ8b9IVe0MbzrgU5J8IxA9xRP0eVautXXSCM?= =?us-ascii?Q?5U/yghgmzInSkypJwJpFu+tRnHPzOe/O0dVFtvoI0tw2FQlzz4om0I4R9Y2v?= =?us-ascii?Q?j4keXjSw0zxllPpvVs5twQR+2UhUwhQzuQtJmZX9H3rqYr35nGFXmlg6gPS+?= =?us-ascii?Q?gJF0aG9c1PF5s+4CB/N3iqL7dyXChJqXLLEm8tw3qoH4QvGsKcsg3LXDWJXn?= =?us-ascii?Q?QAY4tacHyfH7INjxudOH0S7KhIYzrXTw9QX9J0SdI+LP6mQocatRpNPGNOmR?= =?us-ascii?Q?lGwS4LDvwt8Z8mU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(7416014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DZla3I8oDsu5tLA9Cz3J4cn67cCPI8MtgpIQqivfRtGpokotNooz2OB/eSVu?= =?us-ascii?Q?634HN4CxXj3ePaEsy2kiwWb++4feZSz5luX0dHmdb4b9p6qOmOkg6F9hY8FM?= =?us-ascii?Q?sQcRM7GVMgn8DHHB2Tuw2s5COWsJQ1n7xt5z2RNEzATRlxox31dljuG0rC3U?= =?us-ascii?Q?HpxS0zF9Y0bgcGeyLiXPwCMa7Dc+jEDwfEzq/KRwd1PJThdw20BR38y58wDw?= =?us-ascii?Q?GnpYqmNmc8+8rRvHzpZ4nETxl0vz1Scf1++HBg3zfvrl93ckNMAH/YTR1rfg?= =?us-ascii?Q?VUvnAgt+q/EGMtfCyU1l+Fli9bDiqTGxuxkgj8sn+/ZQLGV7cGSBjUZV/Kk5?= =?us-ascii?Q?d1QL4wqPidpGXss/EkqCtqJUuLhZ/hobthCq4i6zF9o9kzGp0UF2Iqsjmlek?= =?us-ascii?Q?8vP6b8BcGsOtmLPqunhkzOl0X2EoFjaisicPQ25fzaUj4h6YRsYgp1Cae1WP?= =?us-ascii?Q?HxhkJqvVHX7QQ5eWdSkf9WRZE9FWSsGDJxfkQe9xco2xEggmOPf8NBbCHeBK?= =?us-ascii?Q?tN/uQenjI4kilcECJaVMa9am4YMe4LWNtgyz5/qs9Iltql6Inm7Cy8+ErEXy?= =?us-ascii?Q?RvM1ELKx6vcf9IEA6V6gABQz0cEgTBS+ZIaEeO8i3Vq29XysCk7U5gZX3o7O?= =?us-ascii?Q?7BX/BjIFTgVh4gOUf831lhQoQPMyrZdVUetFh77Slltq6JpKwuOy9MGGOdz0?= =?us-ascii?Q?hIfJlERwHrAfFeFwzZXuEwySrM2xeOap79VEttEkIn0AjpRyzQ7tgPSXX+qm?= =?us-ascii?Q?5r9wPI0HaXk+biErYGsxTX2uPlfZMjuHnHZmu1a4q8peiAyoVueAxI2dlDNr?= =?us-ascii?Q?4Y9eBZARUt5kmH2Gy1aXPt2bJ1WgqjIa3egJNb/yfASijTGJLHhipxFKB4Ey?= =?us-ascii?Q?ey905bEdBfeCTzwcdsxlL6BoePnKXI/qN7PAyUHan68JU7+PheXd9uOefvV7?= =?us-ascii?Q?Iqzlblh+NfcblKtHOS//dhM/wBckgJX0A6w10PelMUQ57KjKyNna6zkaSNuI?= =?us-ascii?Q?+Dqv7a9cCKyvTXlotWEB3lw1k7bffV/tIQPuZlEStrTEFpB3f8W5sXTOzMIY?= =?us-ascii?Q?KPN8HJOSwxXUrB2Ve4RX5TyYgf6uqRJ4485Ud0xKCJgeuVKhVrp3b4/4/y/e?= =?us-ascii?Q?JHo/zDtxc45uVeuhdMd9We+IZoEMxVhZvqum4bC+mbZycG7UK3S562bsLaL1?= =?us-ascii?Q?p96B58nZHUz5X2nvAHGpIsY+HkdWBG8MMM2PfIm5rwNeahrGB80xjIByyomM?= =?us-ascii?Q?xkSHfSW+1QyuyXEhVT3Xmnv688CdHWMoFeCGFri+FyWrsnhr1oGxiW/V5qGv?= =?us-ascii?Q?Td9WlZ4GB3ZtQuU+6cZ2bzvm5DZjg1PoXwVx6CqSzdOyTgPXEp+uUqqTy0Lj?= =?us-ascii?Q?2Cq3KghvaawtuFTcH2JmeySVwhD9Aeabq9955LgNYTMdxL2zklq0nJc+gw4B?= =?us-ascii?Q?kzsJOmXbVbio8MP7/N5lA6pdRVS+NQGCHaMMl/+Yso6VZArSCZpeG2ezW//I?= =?us-ascii?Q?9Xoojy0rrhwjuzgdGuiGpfbUrdkJFNjMGjc6Je7z+MJ7nadQbAC3ilWy69Nb?= =?us-ascii?Q?lvL0IJzV1lMJmbTQJXSucm2qOD9XfOU0L54RfT4I?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 304e1c5b-8e3f-4169-cbf2-08dddb1c5536 X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2025 10:21:29.3976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oKtYtOuc2vkTHiX16FbgeO0Bxdz/UmBGk7EMfYwVAxPAS+vGGtCOULWWZ4Vg1VyC3W2qQmUKkACOVGk/92fHjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6699 Content-Type: text/plain; charset="utf-8" Remove array_size() calls and replace vmalloc() with vmalloc_array() to simplify the code and maintain consistency with existing kmalloc_array() usage. vmalloc_array() is also optimized better, resulting in less instructions being used. Signed-off-by: Qianfeng Rong Reviewed-by: Aleksandr Loktionov Reviewed-by: Paul Menzel --- drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 2 +- drivers/net/ethernet/intel/igb/igb_ethtool.c | 8 ++++---- drivers/net/ethernet/intel/igc/igc_ethtool.c | 8 ++++---- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 +- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 6 +++--- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net= /ethernet/intel/fm10k/fm10k_ethtool.c index 1954a04460d1..bf2029144c1d 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c @@ -560,7 +560,7 @@ static int fm10k_set_ringparam(struct net_device *netde= v, =20 /* allocate temporary buffer to store rings in */ i =3D max_t(int, interface->num_tx_queues, interface->num_rx_queues); - temp_ring =3D vmalloc(array_size(i, sizeof(struct fm10k_ring))); + temp_ring =3D vmalloc_array(i, sizeof(struct fm10k_ring)); =20 if (!temp_ring) { err =3D -ENOMEM; diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/eth= ernet/intel/igb/igb_ethtool.c index 92ef33459aec..51d5cb6599ed 100644 --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c @@ -920,11 +920,11 @@ static int igb_set_ringparam(struct net_device *netde= v, } =20 if (adapter->num_tx_queues > adapter->num_rx_queues) - temp_ring =3D vmalloc(array_size(sizeof(struct igb_ring), - adapter->num_tx_queues)); + temp_ring =3D vmalloc_array(adapter->num_tx_queues, + sizeof(struct igb_ring)); else - temp_ring =3D vmalloc(array_size(sizeof(struct igb_ring), - adapter->num_rx_queues)); + temp_ring =3D vmalloc_array(adapter->num_rx_queues, + sizeof(struct igb_ring)); =20 if (!temp_ring) { err =3D -ENOMEM; diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/eth= ernet/intel/igc/igc_ethtool.c index ecb35b693ce5..f3e7218ba6f3 100644 --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c @@ -627,11 +627,11 @@ igc_ethtool_set_ringparam(struct net_device *netdev, } =20 if (adapter->num_tx_queues > adapter->num_rx_queues) - temp_ring =3D vmalloc(array_size(sizeof(struct igc_ring), - adapter->num_tx_queues)); + temp_ring =3D vmalloc_array(adapter->num_tx_queues, + sizeof(struct igc_ring)); else - temp_ring =3D vmalloc(array_size(sizeof(struct igc_ring), - adapter->num_rx_queues)); + temp_ring =3D vmalloc_array(adapter->num_rx_queues, + sizeof(struct igc_ring)); =20 if (!temp_ring) { err =3D -ENOMEM; diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net= /ethernet/intel/ixgbe/ixgbe_ethtool.c index 25c3a09ad7f1..2c5d774f1ec1 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c @@ -1278,7 +1278,7 @@ static int ixgbe_set_ringparam(struct net_device *net= dev, /* allocate temporary buffer to store rings in */ i =3D max_t(int, adapter->num_tx_queues + adapter->num_xdp_queues, adapter->num_rx_queues); - temp_ring =3D vmalloc(array_size(i, sizeof(struct ixgbe_ring))); + temp_ring =3D vmalloc_array(i, sizeof(struct ixgbe_ring)); =20 if (!temp_ring) { err =3D -ENOMEM; diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/eth= ernet/intel/ixgbevf/ethtool.c index 7ac53171b041..bebad564188e 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c +++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c @@ -276,9 +276,9 @@ static int ixgbevf_set_ringparam(struct net_device *net= dev, } =20 if (new_tx_count !=3D adapter->tx_ring_count) { - tx_ring =3D vmalloc(array_size(sizeof(*tx_ring), - adapter->num_tx_queues + - adapter->num_xdp_queues)); + tx_ring =3D vmalloc_array(adapter->num_tx_queues + + adapter->num_xdp_queues, + sizeof(*tx_ring)); if (!tx_ring) { err =3D -ENOMEM; goto clear_reset; --=20 2.34.1 From nobody Sat Oct 4 15:52:44 2025 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013053.outbound.protection.outlook.com [52.101.127.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 262D32F39AA; Thu, 14 Aug 2025 10:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755166905; cv=fail; b=pFhp/VYXuKV5XSKtbR7v0vvpdVOzCM9AgeMcflgo79ZjlAAnFNjYTp32Jac5R28WgcvQL10s67QvEK2GS5Fw34wf9fzsRGhkMn0U9rZOfDfpRJdCLJuroIks4nR+1wm0gryzrLA3XavHi8e2uxG378RZUulu4SeGjL60jbGa6iY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755166905; c=relaxed/simple; bh=eVxOEkg9lfl7ATxz7HRoV2PjUFpae2ySe+6Gv+M1kwE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=JupV/O+jJ/2SWCzOmtt6W6/zpZO66hBObY5381oWmUPg5KWdwqWgA3qzbzcVuHWYNdirYSeIt1w1LZrGo6CBKBHLV8aDRzFYtjDaMuBETyt6PPKPhUlnjRCOgTEwLMRb1QYzQQ9VFU4IzJY4imbj8oFVKXL7c0Z/wcrHHfBlugU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=GS8eNQKP; arc=fail smtp.client-ip=52.101.127.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="GS8eNQKP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UehKnP6646PrzyOZPdnbafQhJKJTGDrZiTJ6SNLm8RsBsXPaJs3fNL+UuPGkLtY5spd77yiYJKDQLaf89qcWXWBBV9iqKBpjM801x9v2kZYcHfGHMc/P88oGBqz5FzYp7jhUK5cwgGS8fKXhnwitktM5O1lFgSE0OVsrDRf8uXnyK5VujYfXa7seTU9wMRcjVIUeJZkV4nx1aFs7+yd/Iw3TmLNMSMrcsHMGWFopQSs2NlfxgPsZwgUGiZo+de/yorsNzqHZKOUe3IaWW+LfFi9tFO8dbOUiLjp6tPKCOS27K6l8DIstIhBPajvkE7z7bwFcQltcvJvVKRz8RL+b2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xdD+wzuD0Idfl9bscud9UmAvoAbM+0WpbkZAng01vPc=; b=bFduoVHJYIrvkithiUGQYspLjQC42BWa+ijzrYRZ4qz9XWRmTUaHUNl5y0RedHk868ZJSzfR40wDW3ls9TeQMicjVDxEub+gHrI/YMMdrwEUlNx1y2oRuItSC7pG86ZCCmAzdChp0l2x7B89ic88AtbWlzJYYYIPwMLODgKfLwOsvfcgifsz8l1R0QkV0bCU9bZqPivoN8LMrxvM6OZ29brfzum2Xo0Rl2zVrKkv6GCqz+ZAvo7C+updCSlO6vMRU/Lay2+y0o4O4AdrqCU00ikJfa1jFtY5kZjskccVOzf+pO6H4XEdEl326NasGBpH7qh+HkqVi1AlaYR8OPNs0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xdD+wzuD0Idfl9bscud9UmAvoAbM+0WpbkZAng01vPc=; b=GS8eNQKPJxWY4r1IlFhulI/Wpi/0XXD+f7MzZGJDzVWZEdciE/J1vRWAI0TlMAQHh1hI4uj1oSI9kcOeUkqnA9kB9wzUrh8zlm/ffDn/YY85AtyRb9+1y9ratrQrmbFYJe0nPABuiqwR9HNe17AKAs+mR2Nuteh453FgNajR9WKenI1wxn4D+00D3KgEjjWes812nhiS1mdpAJaDmGgMcUFaAmaeSzDi0rJD7HVLfctio/6jBgm9/TnVMXHSTwj1rw2nc5H0wqDPGEZsCsXdDRFzw+dCCBswKXanqIs76ZIspFBBPL1te1LkdonubvbpGJD6GuAQY7Ow8M9Ft7Rx1Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by TYZPR06MB6699.apcprd06.prod.outlook.com (2603:1096:400:45b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.15; Thu, 14 Aug 2025 10:21:39 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%5]) with mapi id 15.20.9031.014; Thu, 14 Aug 2025 10:21:39 +0000 From: Qianfeng Rong To: Jakub Kicinski , Simon Horman , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , oss-drivers@corigine.com (open list:NETRONOME ETHERNET DRIVERS), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Qianfeng Rong Subject: [PATCH v2 2/3] nfp: flower: use vmalloc_array() to simplify code Date: Thu, 14 Aug 2025 18:20:54 +0800 Message-Id: <20250814102100.151942-3-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250814102100.151942-1-rongqianfeng@vivo.com> References: <20250814102100.151942-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYAPR01CA0149.jpnprd01.prod.outlook.com (2603:1096:404:7e::17) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|TYZPR06MB6699:EE_ X-MS-Office365-Filtering-Correlation-Id: 74796698-8749-4b9a-02ca-08dddb1c5b36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rnsmBXs4zg/O0xz5qdvbTHh/jJeb/6EsyTzT3koEk/nr7sJIeA961Tq0t/Wi?= =?us-ascii?Q?RcgG9DuGLzsPjfIdJY3SwCkNl4Yb6Rp7e2jsfQZTh9eLYowrGGlMMydMPh9Q?= =?us-ascii?Q?7b4IaUbNBL7h3zR+hjKevElZy7k+oEyMNxYDFnD8iGBAi8whhVew6vD62I4v?= =?us-ascii?Q?HZ7j9zxQjeeSevCe3f+SJ/NalPk1ksj5Zg6err7k4Oy41wkLZmmErAiHBqmR?= =?us-ascii?Q?5kGE/LcrbaOHZmTLwMXvYUcscHutyLiET048RQl66uwDd3ASZP/p2f8vFs9R?= =?us-ascii?Q?cp0STE2eozAfJ/3WlEVIdROjXWbDK9gEWIzHHc16sCO8PsPdN4d1A0njbSnp?= =?us-ascii?Q?HHJR/5Sh8mKWj7D7D2kAxVg5WpyMDRG4HTzSKwMXwl1fwDqsJB3jpOhVeeTN?= =?us-ascii?Q?LayvDwlRHJAqDczth1ZNBtAOg038nA2yCMjmUvGP69YFL//SRhPz+l7ySvQl?= =?us-ascii?Q?BuSByApxAzkplEEVxPFhAY5zQT4N48FuAFBJR//89EvF0PfdVRRZZpDiIs28?= =?us-ascii?Q?lLIE0CTNzGck2AOT1cO1N2c2lfb4PH46XvhndFy80DTJCHJ+ItDDyvt86AP3?= =?us-ascii?Q?M+RDI/3KwB0H1MOCqvrbm0x+Pj6guD90QkUu8LYUN9rGM9jeMKkSTRtbTQtJ?= =?us-ascii?Q?JcK/+V3C9yBK8ufAGGvfN6IhsN8xJx4XHOzfuDC/w3ea+vKAeXEyrPt25RXo?= =?us-ascii?Q?Rqrmutb5nLVEbufKFOrF0kKzeGIUH2SQSo81XdpnbanvYAjQOM+P0gWWhLFH?= =?us-ascii?Q?TtFgOIAnAedy37YzQjXM2zvL+/2lGZ6Y5nSfzWZo66bmI1yXAF5FIlucR11Y?= =?us-ascii?Q?XvyKHVhv3FunQZqu4R6HFxQsxgZ3LMNJjLzmbtKbOifZNJ590mSnax9TCBsz?= =?us-ascii?Q?hHkv01xNIS9HnreoAMM2E8vGVM1O/awPxDEB+wATavpz+kneVAg5nZ/mdYqn?= =?us-ascii?Q?KoYJK9KEEeRxeYeNfCEM930gRcaUjXo4mGzk2Zo5O3ejKUiHYBzqnnbFcF1n?= =?us-ascii?Q?jaKpwyEYZH0CS6xozFcliRF09AwkESzL5XqcIzZh9AbH4uwRVhGk2sdGl27x?= =?us-ascii?Q?LgjPrfZkoEDfdxVBHLa68L57eiIN5OvMzPslVkziKKcaQFcaahnMB2Ev+BaK?= =?us-ascii?Q?5ObsnvGMFKnbOjsTwxACnIIpOK2flPJHR59oi2lBiNTrAzWjonTicsWFFUDx?= =?us-ascii?Q?kxZZBDEyIcGkv601rHXze7IlLsSBn8N40tn2Ou/keQ9bmX7va2W/qBX/1Eq0?= =?us-ascii?Q?eVK0Ay8n79TqKzhyO9FSvqnUaU5+5iUhBlYMJ1LbhaWmwWlZS6HIcn+VwsGr?= =?us-ascii?Q?/n1u59i5Ii5+Q4KQvYcsRXkHcSmRIEGiqV25YnF7t2qvHp4VitjXmO0TQVVj?= =?us-ascii?Q?OXIWVE7rSIBna629dJjhKmDCuHoFtCfRO1mUtIwtBqvWiSL5msXAjkH879iH?= =?us-ascii?Q?lbMoqlymLEfg3zTvJZwD7+mxWH3GnZRpX5pgXe04l0qWhyHtQUhS9g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?f38yo/7zcLynHJYxta+v6otR5boJ3Y2yG0e5TFNyrl17c9Jbf34wMcu5VyL2?= =?us-ascii?Q?pLHddlcELrO3C7T44FhdnZ+Yw9b+Z3O9B600yymYKWRtER/JI/VZCGihgVHr?= =?us-ascii?Q?wRyuwGmXi7g3E+JIXiw+zBLeAJh9w32OQGzvUbx0nKP9oNfZAfxRmH3W3CWc?= =?us-ascii?Q?u5sr58EEUUk7M0DxFAYmxRQsxRcJlYxR4NcCM0ZEz8hSZ0Y55EsMCD59bIsH?= =?us-ascii?Q?hnx83eEnvZGPfnZww+JEtvKkPwMUiIAyEXgwFc24BMJNagz+yyB2AruAApVA?= =?us-ascii?Q?JyWtVuN2hejou8RiRID2bYVs2LYYvBWARcOmWrlFUdEEltvShezAb5kD4nP6?= =?us-ascii?Q?Haqg5RZgOkPEudpia4iLgvcEOkd5RZXGC9JpcRAi1hi2OwlRaZbMCR2pFDnZ?= =?us-ascii?Q?L6lHiNvh/mOlLwZavjoTd4Jms93z02VDOjodyiDJNY/S/R8WLsu6Yu8pZZKy?= =?us-ascii?Q?qbIlxtiLBMRbttKjsna+hvbuSx41wj7qIUhPTT3I/7GC1dBwPbZlc2ypdiC4?= =?us-ascii?Q?akxKQbQjkM4wcD/9pAxstvx81zdFMUt5WEHSK484n7AFwfQLR0SNP1mjW7Jl?= =?us-ascii?Q?SI6Mt0NjBJ1RvtDoWqHexPK/6roDiv36z4exILkwLYbyjLwDbPbCiM2wQAkQ?= =?us-ascii?Q?s4R1vnJxMZKe8acafOfg1weiedrbLUO7YeoPtdVMk9Nwn00BWTDbLyNnKXrJ?= =?us-ascii?Q?3QWDB8O3YEC8n/85bVM3JU6T78lTv3kvHPb6FmpdU7ZmJNX/TrYqX1w25EwE?= =?us-ascii?Q?uydlTONTS7H0LMYv/BSEt8SuVh4RK13bOhKbvYiJmq+GjEFC/oiWfb+2OhjO?= =?us-ascii?Q?YYz1BE8TX40Ixj1lx74gz3RULC/3p52lknkUHanp7e5KRbSRqZ2f+7eTmpfc?= =?us-ascii?Q?bkY6ZLFOShrmUeJQw1cg9SWd7tro5nN9MhCHB2hoT47BFN0C7HibHX90A8M6?= =?us-ascii?Q?gs0vYtvCuZjpdqAR/0IYD7QV8DlGrjNu9RGUc3ze0+Fjsl196G4oHlC61Mq5?= =?us-ascii?Q?SLGaLaf/Jbw7ZBwYt2zzT7Bx16LaZGWWssNHFhnV0RvAbFQZqE59oTv1pTI6?= =?us-ascii?Q?0HmlMT4jAsAJ9F/wwDwQhwV2+I+XEd5xLSWaYQljbuUC+Bez0SwjKlMkYTP9?= =?us-ascii?Q?9t+QP9Wcka7kzPzRqM9c5qw3aY+huI8px4RJK6NycSI3lXbk3FuQY/hvAoFg?= =?us-ascii?Q?jjdx7xs3fhZz7OIIOMVTVE4u4elto65VsD1liAP754kQ4ezR2uKmOmdMuRFP?= =?us-ascii?Q?lY+0YNg1liDGG6t0nsM3eHC3GfssXqKaD0p0jks+ciH9JJvEaRf83KSPuGD8?= =?us-ascii?Q?DJ4P2MH1NMkZt5F5nzo1+qOKm9KIfgSh04ybPCuq1TaS7KbdlsyilWLdgzUn?= =?us-ascii?Q?z5q9ecLpoB9UApSz9E/jTRxHNRQAw7LWfTJoAASNKQoo/84hpP3QcDQtT/kI?= =?us-ascii?Q?VKBRElmXRILfQO1rtTYkatWT2Jk+9XlBZLO29S+0d1lNKoYpR8IEUuEnu6CE?= =?us-ascii?Q?hdmhR24tPBU7iWcEWuuIpEgy3NEKoVm35ory/m3Lq08rf8k9mGoCarAx0Onv?= =?us-ascii?Q?qC7ijrfXZt8nu98Qjf48mIqVNl6b8jInrnBog22v?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74796698-8749-4b9a-02ca-08dddb1c5b36 X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2025 10:21:39.4425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6yNo92T0ICb5nVXxIoxN+jhpy95DyqKwG2i3nP9o/wf3pP370Dshn64hmcwXXB5Qgu8HrA4T5Lb6BauYfr0G2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6699 Content-Type: text/plain; charset="utf-8" Remove array_size() calls and replace vmalloc() with vmalloc_array() in nfp_flower_metadata_init(). vmalloc_array() is also optimized better, resulting in less instructions being used. Signed-off-by: Qianfeng Rong --- drivers/net/ethernet/netronome/nfp/flower/metadata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/metadata.c b/drivers= /net/ethernet/netronome/nfp/flower/metadata.c index 80e4675582bf..137e526e2584 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/metadata.c +++ b/drivers/net/ethernet/netronome/nfp/flower/metadata.c @@ -564,8 +564,8 @@ int nfp_flower_metadata_init(struct nfp_app *app, u64 h= ost_ctx_count, =20 /* Init ring buffer and unallocated stats_ids. */ priv->stats_ids.free_list.buf =3D - vmalloc(array_size(NFP_FL_STATS_ELEM_RS, - priv->stats_ring_size)); + vmalloc_array(NFP_FL_STATS_ELEM_RS, + priv->stats_ring_size); if (!priv->stats_ids.free_list.buf) goto err_free_last_used; =20 --=20 2.34.1 From nobody Sat Oct 4 15:52:44 2025 Received: from SEYPR02CU001.outbound.protection.outlook.com (mail-koreacentralazon11013033.outbound.protection.outlook.com [40.107.44.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D791A2FD7B5; Thu, 14 Aug 2025 10:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.44.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755166914; cv=fail; b=uAXJgSZfZUPpFUc2Jq1xgW2fXK5TeVIH5vmTBrWxzuClMr7RbFfGGkjbswTvR7MClvPzh++aaLSv0hiSAVOipsG/eg8tXzyEyXmm+u31IwTJ0kwz3E7DCpS+d1F0XJrtzV55sv+DthiOYNdvBybJwipTcFg8E4ckAWxZ2L/9bfA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755166914; c=relaxed/simple; bh=RONMa2ikn2wsB/Ey7wpwT7gSToCq7xrR/pCzIBwe1wM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Svauz886ynSSipCokuxu1AkFj71pPMCxi/j60NpT9PP7V+wLWv8NOTokFmTha/WcBBfkS6VnLIgRzNWlDe1PdagnIvGrIqMlN/UDuixVGYZ7jxDZcTPOV8AzQxwmvprrqJkdyo0OrLh+ftfD3yWzrk9Bb9pIyOinFtmP0hQMJ54= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=L5D2Pz61; arc=fail smtp.client-ip=40.107.44.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="L5D2Pz61" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UJ/VA49XoWX5FNn+rENOFDiFXOsL8GZrbeaQ28zByikw/XkVBl+YWR5Si1vdow86Bs3RSctWYBmrP0nD+OD9WsZzUk/Zf8sd5f8zOvhiErgpI4dWNfjiEMr4VNTI+ThWaxLEomSaGfNyFdvlKE0uo6cDdhrz1WrwscpVnpbDa5v+cGBqgTfscEULgNsetuoZBMmZ/44nsn+B4ePBQZOzBx9qNItPa8oGpO2+lEUD0J36hlBKjdIMwHftVwc4KGLYKqwoCV/A30Bt/mukbWDECEuiqroRNZAGNe19OIYJzRB1a5Pw7lo32B2PwW3xM9g0uzh0nabIV9/bKhzcGiz37g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AtBoFe1vdZ9oleHWyUJUi+QZsigTWaqMmO/4a1oBhSY=; b=SFp3T28s44o9Z+CSRudTSxu3Mv07Xk3Btd/eUn0mO72C7fCXwMRugJPGQYu76xq2DU+cwGrxA8PppJiS/eQXIOcIRP5iGTbuo+RvgmzotuxdA1w8YQZsip/A9sSNnQ6tMFYPFRN85voU9twAo3Ix/FLY7T8WRm4jeQSKVQ1b2S1IEdgcoIlWHUUV10Z6eCnpuXTLCeLhdPcADe672Sp3wN+ucu/Y1SspYyrNxklEC9xCwl2a+pq9wskRwieToY545KUuV17nuwfqAWtzkk5xb6FDTyvSu4Vg56EUnGGUlXc9Q7ScVAPxWjMmZ65ypc7JebpC1upVnYkz+VOj9/MeXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AtBoFe1vdZ9oleHWyUJUi+QZsigTWaqMmO/4a1oBhSY=; b=L5D2Pz610R8o+Ii7VCcXQp5IPzkVNCefC5Yhuzpkks16/FflWTYYbaoGjJLm1EWecAQ/cjpc3nyqnMN+mMW+10qzeivl+gw7e14Kx1gqu7JYWYDNRclkDlTc56VOl8SR1AYtGCDWjIbOOHQOPdTV+B4O2SHyNPvILelqJeohhJ54UP/9F/WAPWNQomPamIKK3srEzkrKwsTUYBLwTM+gM8I8K4XVviYRIpWcp5ZTmfp/zb2ODFm4tEHpPYARo4WV1Bb7fq/HtWywFajwcveBZjT1ndhRJPz4TsIXtYCSX5lDOEHU6cF0jpMfCKrdMLMCGSfSJRz2sTi+VzcSDDeljQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by TYZPR06MB6699.apcprd06.prod.outlook.com (2603:1096:400:45b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.15; Thu, 14 Aug 2025 10:21:50 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%5]) with mapi id 15.20.9031.014; Thu, 14 Aug 2025 10:21:50 +0000 From: Qianfeng Rong To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Qianfeng Rong Subject: [PATCH v2 3/3] ppp: use vmalloc_array() to simplify code Date: Thu, 14 Aug 2025 18:20:55 +0800 Message-Id: <20250814102100.151942-4-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250814102100.151942-1-rongqianfeng@vivo.com> References: <20250814102100.151942-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYAPR01CA0149.jpnprd01.prod.outlook.com (2603:1096:404:7e::17) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|TYZPR06MB6699:EE_ X-MS-Office365-Filtering-Correlation-Id: a7984ae7-6975-4d2d-50f3-08dddb1c61b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?TJ/kCgdOttnjZBmm4Wt6tn/oS9k2CtwzGvKlJ9/HbJt95RNRmuh2+ICs70fR?= =?us-ascii?Q?H7UMZf3rsWrvQn0j0gjpD/fpNP1zU6bSYmLQ16f1/ZV3MTIgsyDtsEQ16atH?= =?us-ascii?Q?3sLHz5XMVZeLhl+sdnV0IKZ6PPP9Wnw2uYjfwcjt58po21AGs36/SM6b+pvZ?= =?us-ascii?Q?3tCaI1IbUei6Vs3oVwleptVO4ka8KeNxdNq2JMVjtuw1nISh2kMftqOmYn2W?= =?us-ascii?Q?qbaQ5QMrTRvpk/ag/xJPCxjPZk16DkniZM8AaTzQRaVPMx5itlXr4nZ1R2yo?= =?us-ascii?Q?NnfEZ7QhPS6VtJgBOvp6dP8NXi4ZmH3JyJF0iiHApzjYAGK5cdNsasmZOiFJ?= =?us-ascii?Q?1hnJLYuymi5votME7Q+T3p/iNWW7xn0Z9gDYTcuoIpROlEHDbann6xImmrEn?= =?us-ascii?Q?GOecACX+oSvdhy08wFXnzm9EVsdZ/06iFZIBuI4l3MUeMuPvsHxWPxRH/r53?= =?us-ascii?Q?7eR0jlobZVvONcDD0ahn1FE2OzC2WkawQ2bOLo7Bg7dqIDa0gOSG1Vowf+nJ?= =?us-ascii?Q?9xhFxvkgehYIsIU7/+4/Ucs5MP1TpUhMzQGTSkqHeRRzIrcO5U1nU71NJi2k?= =?us-ascii?Q?I/zeWSkNHZ7hIYtqL9S2rfAhGwDz1+ECl16PLXE31iGjYnEKuASk+w92Ykci?= =?us-ascii?Q?CWNrGcGysHdBIZbGRzJdrpLMhvk9OO33cq08cBXYO+KNE0MKJ+WzlR+2gvAh?= =?us-ascii?Q?KTbdlPwQ+PlZa8OYiZ0y/QPy1YQfMu5kmx4JhDyeiChvC+BYqnHY8yk901y6?= =?us-ascii?Q?1aKzsSlJaMw0A2TCHO7WRdx6aRs+JPaCEexiuTRA7gP5lIspH4OiyX/B/Wy1?= =?us-ascii?Q?8l6uN6lHBCSDc0Gm0IBo8fVBlLpQOp47R5PrBwjvwLhgrahzwoNpYhNrw8ml?= =?us-ascii?Q?6L2PDPbWe2pIwHm3aL8vwgE1c+jE5s66X9OMamwNohUa+NcYCApNeOAUORbq?= =?us-ascii?Q?IcE2e8Kj7xqtD3gwVkahlpMNI9gq3KnEFWtHF6nh9tyugL54BxLQym44tEht?= =?us-ascii?Q?+dx5jzQNt2rRNTwpS2PkT5XU+jl2UQMYRbLUVTAAcGMftmZDHozW2xqKTpNI?= =?us-ascii?Q?W3o5c6By2cyyD1nR30kPrhYZSBcPu2dNBE9zaYb0C1KiZZuHNRNiwofR20OD?= =?us-ascii?Q?//t7M3GuhaxAORmMOra7hglLRi0suxbGmZuSqXjenVyu2GF6qrMb4M6hjL4C?= =?us-ascii?Q?x5it0SzfRNEpnCOBpiCTTuhA61TCy10jHQvmPaC3kwPECOTV69yckOuAiXhX?= =?us-ascii?Q?okshiPINgN9kn+plzIQ4QwkVP7oljoipOY8q6I3B7/7wrFYIyNphGmSJvtDr?= =?us-ascii?Q?pmAcSzs0YKfLM5wrAZFNNSRVLEqSKt2ojpvTg6FNImJ/nDuyCN3rUgV2JlN5?= =?us-ascii?Q?9C2qnYbmxLQywpVeQcgtQhFCoNU4/hEKbpBbuBwOU/Fbw8ckUTOhAYiyP2QM?= =?us-ascii?Q?QgKl5S1gbLGThiVjKrHeuEkx2X8wuDFZ129TNe8JFT/eqiGT83A9rA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/8GSfLM2FUrCr0WafxavvsgGu44/mW6GW5HMmVLtJ67PEvLZkrS49giFpLIR?= =?us-ascii?Q?bFoUqSO5K/IRdJYFzyvyIsXix/SUiBoB0RcLdMmGCwEw06xRGBboqsjjAtTT?= =?us-ascii?Q?2hQHd8Jdz9ex0uocQDih8GV1HKKeCAluCZ+GiREzwS2AzmzbCMSAuxU7R3bh?= =?us-ascii?Q?H3Th4OkSIub26msQrbVwN9OVb1BX7Hr7fq7Fb15WGO3XOv2PgtZXI/39jWFv?= =?us-ascii?Q?VG8YtPI7PYKmzawOCnBZ88TfUb8Xuzn/zNgI1Y86M8sRqqseUF0uJLEOyuP3?= =?us-ascii?Q?ifNrcV4I/ah8LB0/jIOZ/TVByTvISyXDhI2YXbZEQmsAPVsAF9Bzfv97r72z?= =?us-ascii?Q?5XqG3f83StwcDUQDZlafbSYz3/ryHhflCHycYhcuizQmibI6w8N0B6VsGlFL?= =?us-ascii?Q?uQO8Gvi+wNWWIkJSVKxPTzx7E0YJu0vKzqJbbt5s0acA3Fia+QwWDAQhMWwd?= =?us-ascii?Q?aOU/jEaD01D70ahxFRuCiZWLh1fDMZuZTY1RXs2bc+SkffUnZY1ng+mDmPMn?= =?us-ascii?Q?2FnsmIa6LNBYtpoow9/NMVg1UUeFB5CRqXMExxk6Dqg3wssfM2X8upQC9/tB?= =?us-ascii?Q?YaW/Kqn8piSCH3js+POvedaoxw515pEWIsppqi7XZyfClp7u3Reks45rY9eC?= =?us-ascii?Q?SZ/yXQlPthzQkFiwqHNFN5ugHxulkO75DheaTsyv+XOqEXr/jkCqIpZVEflK?= =?us-ascii?Q?deIGSEFYrtJ7oeXcUpP8ojvOrSB4fOBCfUfGBORGMRXIb7kHYqxM/XPSrVLW?= =?us-ascii?Q?5jB+piwsvE8/9du9kPLJ148T9VBe6ewy6fWYebYD1iYn1+X9T8RkaLuIC5/H?= =?us-ascii?Q?mUeLYwgoSwQ2LGn0gsfBRvuD1tQWH9jE5TibqhXmHCU7m5OyGtopE3rtDVZq?= =?us-ascii?Q?YHqkNwwgy7o/JB4Ha7ccRG+IbRoOoSvvf9T895XACCqq1RlO3ZzNEPtsHCb7?= =?us-ascii?Q?g+MGVNMO/4bTEwIw3qMUKENObAU+QMoJmSt1GG7BwuvZSnfEL9nxuSCRWJEs?= =?us-ascii?Q?DEgQXX02brvVN+UzKEodbngKAnongd+mVg17k4HyCI0gU4Zp7IPM98qfF+lC?= =?us-ascii?Q?p/NITcYWFXxoz8rcyqlHWKKpFIyXEhZseBWjpPyjRRWuJ01bnNWiOy6YfxMu?= =?us-ascii?Q?OXIVp1ff5CQV/pwvgOsWuhgBtbhTWmZ1cECLVEgyto7pO9MT2eOJozim64s6?= =?us-ascii?Q?BK0mfVJQTUUX3nGcZmROE3NSYIuGVocARH1+0TiEH7F7byjcTg8SxczVpUsU?= =?us-ascii?Q?IOgbhj7PHCJGmhKHbbGUj8S92B2XH2T5ZsejGto723nwLkji6KsCGlov8oVZ?= =?us-ascii?Q?s13R8w4B5qw0mysKh2EkpgL64UyQWXgnKHBu4Ha2oS3HMuWBIA/IywwUAlta?= =?us-ascii?Q?ksP4s61CMGlNGai27tUlyiL1bkMLRY4Tn4sPj1n+VwkgaVGbUnJkQaRb8Nwk?= =?us-ascii?Q?AYWEwADeXi5toIlW9De3KH+5oGfG9Cm/qdfU/F2mzEoD4vewdvvesZqKleZ4?= =?us-ascii?Q?9JAqAB902CXafvDowDup/GpXArjwvR4Ll3LAgNQOCJBdY4dkILyExTMlL0yv?= =?us-ascii?Q?Mgix+8VHiWi4B+KQt2quDJu0LmwlbqoJbVfR8aZe?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7984ae7-6975-4d2d-50f3-08dddb1c61b6 X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2025 10:21:50.3465 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2g25PYvCwzI3hshfNMHwaWYRlhdamGOHBQKwMbtuZWgazDuKqduDR5VOFCZU0Bo18Qy8nYaFkMCDA6bzNXd/ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6699 Content-Type: text/plain; charset="utf-8" Remove array_size() calls and replace vmalloc() with vmalloc_array() in bsd_alloc(). vmalloc_array() is also optimized better, resulting in less instructions being used. Signed-off-by: Qianfeng Rong --- drivers/net/ppp/bsd_comp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ppp/bsd_comp.c b/drivers/net/ppp/bsd_comp.c index 55954594e157..f385b759d5cf 100644 --- a/drivers/net/ppp/bsd_comp.c +++ b/drivers/net/ppp/bsd_comp.c @@ -406,7 +406,7 @@ static void *bsd_alloc (unsigned char *options, int opt= _len, int decomp) * Allocate space for the dictionary. This may be more than one page in * length. */ - db->dict =3D vmalloc(array_size(hsize, sizeof(struct bsd_dict))); + db->dict =3D vmalloc_array(hsize, sizeof(struct bsd_dict)); if (!db->dict) { bsd_free (db); @@ -425,7 +425,7 @@ static void *bsd_alloc (unsigned char *options, int opt= _len, int decomp) */ else { - db->lens =3D vmalloc(array_size(sizeof(db->lens[0]), (maxmaxcode += 1))); + db->lens =3D vmalloc_array(maxmaxcode + 1, sizeof(db->lens[0])); if (!db->lens) { bsd_free (db); --=20 2.34.1