From nobody Sat Oct 4 19:18:38 2025 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97E9926E14C; Thu, 14 Aug 2025 07:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755156572; cv=none; b=u+paWCAG2ce+GmiFtTSsBskjnEdBGCgmU3asjoXqGvCd17FCbvYV9tAwbvs6Kohdjxl8/Ty03ov5y0aR89TeI83yNcjqoSDm5bi3Si2IROdj4Rlax0K7ZJpciZ20oqerthzP5kseavbSf5b2zX/JeaEoZMCpSxz77AsWF7qeHdk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755156572; c=relaxed/simple; bh=MdGDFOp63pOxhwYv/QqVxRQ/ITwQrV9I93hd7KuGVNs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lpOcW3he/cMYEZAnDRoWCNjjU9ge5rlwqEdr9Bm8gLS3DdxkYqZ0ZKhIO1elY7kfZysGL5qWCybrZyfizWQOqoWsJ+WjErtKikyUjJHTlzycK3p/zp6aYyHv+RE3KoxglmggFfPLQxXWzuU1bXiKa2O3dqr1dT/4JdG8k4tEbVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4c2cGs732Jz13N9w; Thu, 14 Aug 2025 15:25:57 +0800 (CST) Received: from kwepemh100008.china.huawei.com (unknown [7.202.181.93]) by mail.maildlp.com (Postfix) with ESMTPS id 583AE1800B1; Thu, 14 Aug 2025 15:29:23 +0800 (CST) Received: from localhost.localdomain (10.50.165.33) by kwepemh100008.china.huawei.com (7.202.181.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 14 Aug 2025 15:29:22 +0800 From: Lifeng Zheng To: , , , , , CC: , , , , , , , , , , , Subject: [PATCH v4 3/3] arm64: topology: Setup AMU FIE for online CPUs only Date: Thu, 14 Aug 2025 15:28:53 +0800 Message-ID: <20250814072853.3426386-4-zhenglifeng1@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20250814072853.3426386-1-zhenglifeng1@huawei.com> References: <20250814072853.3426386-1-zhenglifeng1@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems200001.china.huawei.com (7.221.188.67) To kwepemh100008.china.huawei.com (7.202.181.93) Content-Type: text/plain; charset="utf-8" When boot with maxcpu=3D1 restrict, and LPI(Low Power Idle States) is on, only CPU0 will go online. The support AMU flag of CPU0 will be set but the flags of other CPUs will not. This will cause AMU FIE set up fail for CPU0 when it shares a cpufreq policy with other CPU(s). After that, when other CPUs are finally online and the support AMU flags of them are set, they'll never have a chance to set up AMU FIE, even though they're eligible. To solve this problem, the process of setting up AMU FIE needs to be modified as follows: 1. Set up AMU FIE only for the online CPUs. 2. Try to set up AMU FIE each time a CPU goes online and do the freq_counters_valid() check. If this check fails, clear scale freq source of all the CPUs related to the same policy, in case they use different source of the freq scale. At the same time, this change also be applied to cpufreq when calling arch_set_freq_scale. Signed-off-by: Lifeng Zheng --- arch/arm64/kernel/topology.c | 54 ++++++++++++++++++++++++++++++++++-- drivers/cpufreq/cpufreq.c | 4 +-- 2 files changed, 54 insertions(+), 4 deletions(-) diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c index 9317a618bb87..a9d9e9969cea 100644 --- a/arch/arm64/kernel/topology.c +++ b/arch/arm64/kernel/topology.c @@ -385,7 +385,7 @@ static int init_amu_fie_callback(struct notifier_block = *nb, unsigned long val, struct cpufreq_policy *policy =3D data; =20 if (val =3D=3D CPUFREQ_CREATE_POLICY) - amu_fie_setup(policy->related_cpus); + amu_fie_setup(policy->cpus); =20 /* * We don't need to handle CPUFREQ_REMOVE_POLICY event as the AMU @@ -404,10 +404,60 @@ static struct notifier_block init_amu_fie_notifier = =3D { .notifier_call =3D init_amu_fie_callback, }; =20 +static int cpuhp_topology_online(unsigned int cpu) +{ + struct cpufreq_policy *policy =3D cpufreq_cpu_policy(cpu); + + /* + * If the online CPUs are not all AMU FIE CPUs or the new one is already + * an AMU FIE one, no need to set it. + */ + if (!policy || !cpumask_available(amu_fie_cpus) || + !cpumask_subset(policy->cpus, amu_fie_cpus) || + cpumask_test_cpu(cpu, amu_fie_cpus)) + return 0; + + /* + * If the new online CPU cannot pass this check, all the CPUs related to + * the same policy should be clear from amu_fie_cpus mask, otherwise they + * may use different source of the freq scale. + */ + if (WARN_ON(!freq_counters_valid(cpu))) { + topology_clear_scale_freq_source(SCALE_FREQ_SOURCE_ARCH, + policy->related_cpus); + cpumask_andnot(amu_fie_cpus, amu_fie_cpus, policy->related_cpus); + return 0; + } + + cpumask_set_cpu(cpu, amu_fie_cpus); + + topology_set_scale_freq_source(&amu_sfd, cpumask_of(cpu)); + + pr_debug("CPU[%u]: counter will be used for FIE.", cpu); + + return 0; +} + static int __init init_amu_fie(void) { - return cpufreq_register_notifier(&init_amu_fie_notifier, + int ret; + + ret =3D cpufreq_register_notifier(&init_amu_fie_notifier, CPUFREQ_POLICY_NOTIFIER); + if (ret) + return ret; + + ret =3D cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, + "arm64/topology:online", + cpuhp_topology_online, + NULL); + if (ret < 0) { + cpufreq_unregister_notifier(&init_amu_fie_notifier, + CPUFREQ_POLICY_NOTIFIER); + return ret; + } + + return 0; } core_initcall(init_amu_fie); =20 diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 78ca68ea754d..d1890a2af1af 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -417,7 +417,7 @@ void cpufreq_freq_transition_end(struct cpufreq_policy = *policy, =20 cpufreq_notify_post_transition(policy, freqs, transition_failed); =20 - arch_set_freq_scale(policy->related_cpus, + arch_set_freq_scale(policy->cpus, policy->cur, arch_scale_freq_ref(policy->cpu)); =20 @@ -2219,7 +2219,7 @@ unsigned int cpufreq_driver_fast_switch(struct cpufre= q_policy *policy, return 0; =20 policy->cur =3D freq; - arch_set_freq_scale(policy->related_cpus, freq, + arch_set_freq_scale(policy->cpus, freq, arch_scale_freq_ref(policy->cpu)); cpufreq_stats_record_transition(policy, freq); =20 --=20 2.33.0