From nobody Sat Oct 4 15:57:30 2025 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2136.outbound.protection.outlook.com [40.107.94.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFFEB189F3F; Thu, 14 Aug 2025 16:53:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.136 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755190391; cv=fail; b=Sjrp+Vcv3/TFHFBmY77PAO0DoUr81icL26jODXTli5PUQCbroeymF4epya6wkOv0TBv9kub8FFJ5UdGX/JYFJRypFr7AYINxl9X8aVrcLeX4J73AuUADu0V5i0qfdExpVXZpkvQpPxUSmkUgtRW3qGN7tnpIIv2T4XJa7BapeiQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755190391; c=relaxed/simple; bh=sc3gfZ4nGvKFVsMqS9gB29CNtupExAllNxPjSCI6Kno=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=NhEDKSSqAeyXf5BK0ULVNvVPYNILtOkULSDxrGlF57BRF5lgPCD1JCNcdXynI5nYR42cObZb/l8yTQEXoFIEkXb01gIAYCYnzJvTvwagnyIb/xYqBU4hxFiU13+hf2vndXsdEbNBo7uetgScj7eVdtYvpt6NJPv/+QahTM4vdX0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=J6pwmJ8O; arc=fail smtp.client-ip=40.107.94.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="J6pwmJ8O" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E8MJjxICWUB8ebBOVq6RoHgA3v3hwpc655637132oZ+Cs94vuL4JT1Sj2gxUXIqrgAbsGmfOASE2Vo/lNYEygt+P5TV5XV7DZXyB3F80RY3HWxUdQrJzOo8SlapFo9+t7VAArB2INxdGB0JN1zBz1LRsftg3M5QtXfurPXCydBqi5FjTrrn+e/2Hqey3md6qRh5BQtymvya1kxp7/Q0/L9yFyZw7hA8btQGENUTqCvcgyKCL8Voi5k383g4hcv4z3V+xFY2tCQwlxznFlabG/Id2hk6/rR2ArInlW0WI60ivmkj2G9T6+00/JdbOrHJo9fcZcVbHLxrVZLbyA3B9XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YzwmSN7axjrbTpyKQElaA0AcHIs92Rj7KpGwamN7seM=; b=E7FpdhHknwLVDFz0Il6W1aPGWsa6jg6nTkIt6iG8XpVYwCIyWRFH0cMHMOVYESSKvtrzIX8tDktcj/15f16ZxniJqcBWGnUhyMlun6mVJcjHnATjNAdYZwjl4OTjqzB7IGf61avZ3gnxhf/EUOfH02VfN0vFOfCL/b5sl6AJiKyhVPC+SHTD7TBmuI/Zk+o1U70ZOTtPwlqmtHljm8YWkTvFqQIq8hUa5s59Z3K2qUklZ4P7tbVbDtI0CNefWVdzqZ4Seqtr0gUKvoLKbIpLcC7g3NPZLmGoQ/k7Wp773LjFf4L/PRwqeSO4FfbtZXVUF0q4JnusS+xqdRvDibdf6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YzwmSN7axjrbTpyKQElaA0AcHIs92Rj7KpGwamN7seM=; b=J6pwmJ8OpuOQSqRIEJWQN51T0XPdwMLQONss0dHgcTbXFcgIRxwc+sGZQSEXLMx99XkbH3EvjwrcnvBYHY72tqzLGcX9o5F5X+trEPZQBhvdOXMMxURrMthlGUnfm294GHoZFH3sqtu7bqi+BdG1i+BkY9koN3R5PtiDjbIX+IA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SA3PR01MB8473.prod.exchangelabs.com (2603:10b6:806:397::12) by BL3PR01MB6881.prod.exchangelabs.com (2603:10b6:208:354::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.18; Thu, 14 Aug 2025 16:53:03 +0000 Received: from SA3PR01MB8473.prod.exchangelabs.com ([fe80::46d7:1d3a:dc9c:69c3]) by SA3PR01MB8473.prod.exchangelabs.com ([fe80::46d7:1d3a:dc9c:69c3%6]) with mapi id 15.20.9031.014; Thu, 14 Aug 2025 16:53:03 +0000 From: Daniel Ferguson Date: Thu, 14 Aug 2025 09:52:52 -0700 Subject: [PATCH v6 1/5] RAS: Report all ARM processor CPER information to userspace Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-mauro_v3-v6-16-rev2-v6-1-e5538d534aa0@os.amperecomputing.com> References: <20250814-mauro_v3-v6-16-rev2-v6-0-e5538d534aa0@os.amperecomputing.com> In-Reply-To: <20250814-mauro_v3-v6-16-rev2-v6-0-e5538d534aa0@os.amperecomputing.com> To: Ard Biesheuvel Cc: Jonathan Corbet , "Rafael J. Wysocki" , Len Brown , James Morse , Tony Luck , Borislav Petkov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, linux-edac@vger.kernel.org, Jason Tian , Shengwei Luo , Mauro Carvalho Chehab , Daniel Ferguson , Jonathan Cameron , Shiju Jose X-Mailer: b4 0.14.2 X-ClientProxiedBy: CH2PR12CA0024.namprd12.prod.outlook.com (2603:10b6:610:57::34) To SA3PR01MB8473.prod.exchangelabs.com (2603:10b6:806:397::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA3PR01MB8473:EE_|BL3PR01MB6881:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c6db9c7-0d92-4b0d-33f9-08dddb5308c9 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UHFEdC9LQ3hRdWdkYThxRUpOVnJyMUFUbzZqcGhSZEttZ0U1TjA3b0U5YXBK?= =?utf-8?B?YnRjT0lmM2VwVmY4cnFaTTd2c05HNXN4NGR4dE15eUIxVXp5ZFY1QmV3ZGU5?= =?utf-8?B?SE1XWWFLZVlzOGhOZWE2a1ZHdTJOMk9lMngvaHZFeFJ5aEFmSG5wdUhwNi93?= =?utf-8?B?M21abk4vSStSdjZHSTFqOS9EcHAzWWNuVWlNRVl2N3VncHp3MVlMT1pQMlM4?= =?utf-8?B?MlVwOElmeEpDWUtMY3JwR290emlTVFVQdU1hcGx5L1ZYa0g4N3hwMlVTT1hs?= =?utf-8?B?NmJGQ0pac1ZvZk9LNGlvc2JBR29GYjVxdHRPUTNGQzNSUmVsRGU4dFJaM05H?= =?utf-8?B?MHNpUW53czYzZXZOVlJpR2wwVmVtTkVydzhiZ0ROOEFhbkJVakVNc3BYcGNC?= =?utf-8?B?NTI0WWc5Um9uVkVIQ3R0QXpLTjVUK3B1SDhsQm83Z0Rsb0o2RlV4dDJTZE5v?= =?utf-8?B?ZjVpb2FpUHcwMHl4UVdoME92aUlOODRFTDc2QTlGRzZoNnIzUTMySkh6Z2Rl?= =?utf-8?B?bFBNY1MwaUVMdVhEalRzdlNXRzFDNHJ2YkxLbGxmTmt4U2gxS3NqUDhzTFMr?= =?utf-8?B?R29sZHVEU0tuTExiZW52ME5rbzdLR1BsbE9PQkUzNG9nVFRWRGFER1RBZUpJ?= =?utf-8?B?b0Nqc255cW1RZm1OLzRiYi9uRUdEYWw5bUk0Ti9aS2xGL2lQZkJtVmVBd1N6?= =?utf-8?B?d1M3bFhnaVZCZkRYZGtaWVlIcEZHTnVrZzR0Tk1BTWNXRklZVURPZ1VORFFP?= =?utf-8?B?alBzSFhSYjFjYTlUSmJqV3A4cVM5OUpEc3ZXT0U0bVgxQkpGazd1SWdySjhi?= =?utf-8?B?akl0SDUrZnJKaHJBNDZlU1BHajBqdFB3RTQzdXMxQkdib2pEUzlXTThmT0VW?= =?utf-8?B?RDg1ZmhHWG1iUzgvRlIvVUtHMEs0SlQ5QXB4MTZiR3RCR084TnhQb05UdTRD?= =?utf-8?B?YXVVODFKcDVPRW5SV2Y5R0k4V09BeXhRYkxkQVlacHovYTlBMmVYeE81L1d6?= =?utf-8?B?NTRCeFBnZCtCNnNwZHNqK3NGVzVOQ2hIY05SRmxreVRPeHpRZ0o0UXV5Qktj?= =?utf-8?B?TWFCU1BDWWp2ODRVM0xSdGcxdFVzZzRLWDNRU3BIemFxcTdVVWlDY3lSNXZa?= =?utf-8?B?TFd2Q2FjeFdwUmVEYW1obURNa2ZNaHh4U1JsT2dRNGc3QUppck11NDE1VjR4?= =?utf-8?B?Wmh5QXl3aTNNOHhLM2JzVDBiMFNCNmxUd3VDeTNDRFZ6ekRpWitFK05hMVRo?= =?utf-8?B?MHBPVzFwUzNjRmlEejBZREYraHBwMUFVak5RNlRyWWh0Zi8zTldTQWVDV0J5?= =?utf-8?B?TUN3T3Q2blp3U0F3eUZnMS9DMHB0elgwRGVINDlwbDk4N1FIL3VZNTladDln?= =?utf-8?B?dkIzc3A2cGZSNXFxeW41ZFFvODBucEw2dllPZFNXajJqQTUwdnJrbUxid3lQ?= =?utf-8?B?MEVjOEdOUjBycnczYVFjTDVjUytwTGlTVWFpeVBiUFBjeTBYUC9vT2xaVXl4?= =?utf-8?B?bjVYemZSVVZ2MmI2czc4dHluNlBxZ1c0RW1JNnZuczdXMEVNZkIvb0JKWkhi?= =?utf-8?B?L0tEaDMwK1RBSzNpc2JYK013aDdTVVN3aXpjQ2k2Z0VLalZGVElLbStQNmEy?= =?utf-8?B?Z2xMTCsvalNVZENETkJYU3BReW9tQ1R6QzhITCttR3EyL0pFSEU0YUtqeU05?= =?utf-8?B?c3I5aENYQ3M1bnB0Nk5yc1RiUFRyUlphV09sTEE2cDJteDdUUHpIVVBRb0dt?= =?utf-8?B?ZURJNk8rV3RzVk1CWExmamY4aFRjZVdDSkI3cHlLS2pHY0hVOGx1aHppSmt0?= =?utf-8?B?SGpya1d0dHdCdzJRQ3FEWGN3WXlRZkx4SUZZTmIwTEZ3NmxzZEdaWHpucXBX?= =?utf-8?B?YTQwMmxUcGxCZ3FxTG9nWVhndDA1SnlqVXAxT1ZEaVZ2a2J0dUVTTlZXV081?= =?utf-8?Q?iZnkEJ1Qqfc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA3PR01MB8473.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZENrNEJBTWZHNEZRN2YxdUlQeHpsaUNqRnQ1NTVQelpVdnVVNHYvOFhQcVRY?= =?utf-8?B?cksrRnYzaEJwY1dJcVdxZTNocVpndnhkMUZzcVJtNzFFSGpsdGpTTkd3WXVS?= =?utf-8?B?RmJEMEVPS0RGSTF3TWUxQ2wrNTMwYTdEMkpQODJON1BMeXR3eldDZmZzdWs1?= =?utf-8?B?T002OW9QbTlPWGJRRUF3Zk1qUnN1Z1hqcDROTEdWU3pmbk1GM1ZBcENjMFdU?= =?utf-8?B?VndoZHY0N0F2bHp4YURLbHpTNktNVDA4MkxuaXZnYmVWbVg0NHVhYW9mRnli?= =?utf-8?B?dFVMWkdMclFXZmxwT090KzQxdXRDbktPbzJMTXVEdWI5cFZ2NGRlellkOHhp?= =?utf-8?B?SVlORnFiVWVwMGV1TUNRd2FTY1pjakgrdlFUaWNOQUpPQWFXN0pzNXY4eWZn?= =?utf-8?B?M3Zic1hqS3dpczNhS0NxUXpic3ZpVkNta2JsU0FTd0c2S1VNaTgwbjNHSXR2?= =?utf-8?B?dTNzZTFlOHBxeE5uNkZSSHo0dHZFQzNkcmgwVE95cTZ2djR3YzI2Mi9WRUxC?= =?utf-8?B?ZThMS08wRkdNRkZnSTQvcFpIMmVLNVVja0N6UExvT25HOGIyTGVJK1IwU0F0?= =?utf-8?B?UHlxRlVnYnF1ZnNLVG04YzRyeXZjczhjamZqb3Q3NG1Za2hleWMwYllkWVFq?= =?utf-8?B?VVhhZktBWmRmem82N2ZKUk0xTEo2T0VHYWxTd2ZKbThTS0dVYmExOTBDYmpw?= =?utf-8?B?Z3A1akh6Y0Q0QU94ZUNaOEMyVlNySG5Fb3RZVjlkR1NHbTg5MFZLVXJ6OHVD?= =?utf-8?B?MVZieU9yb2pLWXgyWHkvN05vYzJFQ1hhZ05Xbm1ST2c3UlIxYVI0b0RnWkZx?= =?utf-8?B?R2tCVVMzUS9TUGJFeUdEZWtpRXJENUxVS0kvNS90YmV2LzdPMEgxeXZMTFlS?= =?utf-8?B?SjZ4cU0xQytMN016bUtVZUtEVzFSRGNkWXF6cVl4b0JQR2lxRCtnYllFa2JB?= =?utf-8?B?MzdMM0YrZEJDaG5pSmp6ZTZRMnpjY3ZEelpxMW1TMTdEWnUrQ1ZkRUg0UVRK?= =?utf-8?B?ZjYwekpWR0V0eXEvRmIwQXpkakhqRjVwclRpZjROQnNjd25vdnRETnl0TWdy?= =?utf-8?B?RnBDWk5oTzNoVWdvdGtId2Njd1NSRi9HVlF6L1JMMldERU9MNkM2dEtUYng3?= =?utf-8?B?enh4cFp2bnhHMXNVT1g4ZVQ1VEROTTdNZmtHSnVZTXozRG5qemYrVVYxUFRw?= =?utf-8?B?bkFZNWEyLzNSTTNEOVBVanpHbjZaRjl6SUZGKzY5R1RrMTJGeXoxWDdUWGhw?= =?utf-8?B?UGJCR2g3a053VEs2OTRKeFJYUXpJcXhyUElrY2RXbk4rYTZDM3FhYmtRYkQz?= =?utf-8?B?aytSaDF6RFRoNEhsa2Y1dTg2RTB5S2VXRGdab0M1RnhjQkozWDIzbm8vdFJv?= =?utf-8?B?NCtoQ050WUhYaHBNbmhHaUxFa1orbGU1RFgzV0QxZFAyN1FhSFEydHZUV0cz?= =?utf-8?B?MjJaMU8ydTAwaWxUZjB0N0F3dzNKeldZTVRyTjk0U09qbFpyOEhidzFJWUw5?= =?utf-8?B?MnRzVmNhTm84MlBzdkpCWGVrbkI0ZWhsYWp1ZHlyS2xmK0F1NXNxdDNLL0JX?= =?utf-8?B?MmNoRjlpdFNDNThzNnFVVVhWa3dpYStzSzFsaitmZzkwcjBOeWpEaEtJT21M?= =?utf-8?B?ODdIQTkvSHBCdWtXWHVISEl2VkozUFJvNW1jME5iUjB6SVpLcWtTdGEwbU1R?= =?utf-8?B?YUkwRzdZZnhyVDN3YWZRc3RkVlliRHFVWXBTdnNOdlJRaWsxelZMUmVlQUsv?= =?utf-8?B?M2w5WllINGNBZ3lIcGt4ZTNJNmE5MkhmWWI2QmlLWFUyVE5xV3BSMVcrTm9z?= =?utf-8?B?ek1UZ2lDdjRYY2c3dFJ6dVc4U3RzWGxiRUtROFBiYXFHZEsycHRFN01RVCtT?= =?utf-8?B?N0dtWWFWQ1lNeHhyUU4wTlBJN2FxOU82bzRuVEpzY005YlFvb3ZPL1pjZTAr?= =?utf-8?B?Z3hwc250NjZhM0ZCSHMwdUhjcXYxNnZzbkdPTHhvVjNXZVFnOFF0UkR5WGwv?= =?utf-8?B?RlhVbmpPK1RRMnFlelV0bU5KWXpWSTVVOWVGckRFdk10YnorU3lNY1I0UWhw?= =?utf-8?B?V2cwZDdpZk1PaUNFS0FFTHo0cUFKNFR2UHJSK1UvVFo3dnVsQ01ZM09uTzZZ?= =?utf-8?B?TE5pSUVMa1Vra1N6QStOOU5IaG5VdWZCem1tMU91TEtySExnNkpGN3Y0czZw?= =?utf-8?Q?Ix8SjvhGaeaAceRWvshOAKY=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c6db9c7-0d92-4b0d-33f9-08dddb5308c9 X-MS-Exchange-CrossTenant-AuthSource: SA3PR01MB8473.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2025 16:53:03.4596 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X2kTw+FN005VOl0oklBaVEM1WnT5puvxfh3CUm9WhlPXqT09x4tmRrSzUR5rRgX5tE+U4TV9zMNd4yfArAES4R1NoiYlGd00HyrBkNR/vwvwwjXjeY3Ng1piwcZPI9Pj X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR01MB6881 From: Jason Tian The ARM processor CPER record was added in UEFI v2.6 and remained unchanged up to v2.10. Yet, the original arm_event trace code added by e9279e83ad1f ("trace, ras: add ARM processor error trace event") is incomplete, as it only traces some fields of UAPI 2.6 table N.16, not exporting any information from tables N.17 to N.29 of the record. This is not enough for the user to be able to figure out what has exactly happened or to take appropriate action. According to the UEFI v2.9 specification chapter N2.4.4, the ARM processor error section includes: - several (ERR_INFO_NUM) ARM processor error information structures (Tables N.17 to N.20); - several (CONTEXT_INFO_NUM) ARM processor context information structures (Tables N.21 to N.29); - several vendor specific error information structures. The size is given by Section Length minus the size of the other fields. In addition, it also exports two fields that are parsed by the GHES driver when firmware reports it, e.g.: - error severity - CPU logical index Report all of these information to userspace via a the ARM tracepoint so that userspace can properly record the error and take decisions related to CPU core isolation according to error severity and other info. The updated ARM trace event now contains the following fields: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D UEFI field on table N.16 ARM Processor trace fields =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Validation handled when filling data for affinity MPIDR and running state. ERR_INFO_NUM pei_len CONTEXT_INFO_NUM ctx_len Section Length indirectly reported by pei_len, ctx_len and oem_len Error affinity level affinity MPIDR_EL1 mpidr MIDR_EL1 midr Running State running_state PSCI State psci_state Processor Error Information Structure pei_err - count at pei_len Processor Context ctx_err- count at ctx_len Vendor Specific Error Info oem - count at oem_len =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D It should be noted that decoding of tables N.17 to N.29, if needed, will be handled in userspace. That gives more flexibility, as there won't be any need to flood the kernel with micro-architecture specific error decoding. Also, decoding the other fields require a complex logic, and should be done for each of the several values inside the record field. So, let userspace daemons like rasdaemon decode them, parsing such tables and having vendor-specific micro-architecture-specific decoders. [mchehab: modified description, solved merge conflicts and fixed coding st= yle] Signed-off-by: Jason Tian Co-developed-by: Shengwei Luo Signed-off-by: Shengwei Luo Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Daniel Ferguson # rebased Reviewed-by: Jonathan Cameron Tested-by: Shiju Jose Acked-by: Borislav Petkov (AMD) Fixes: e9279e83ad1f ("trace, ras: add ARM processor error trace event") Link: https://uefi.org/specs/UEFI/2.10/Apx_N_Common_Platform_Error_Record.h= tml#arm-processor-error-section --- drivers/acpi/apei/ghes.c | 11 ++++------- drivers/ras/ras.c | 40 +++++++++++++++++++++++++++++++++++++-- include/linux/ras.h | 16 +++++++++++++--- include/ras/ras_event.h | 49 +++++++++++++++++++++++++++++++++++++++++++-= ---- 4 files changed, 99 insertions(+), 17 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index f0584ccad451915a2679c17f2367461c141663c5..99e25553fc1320b2306efb751e1= 2f2377c86878a 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -527,7 +527,7 @@ static bool ghes_handle_memory_failure(struct acpi_hest= _generic_data *gdata, } =20 static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, - int sev, bool sync) + int sev, bool sync) { struct cper_sec_proc_arm *err =3D acpi_hest_get_payload(gdata); int flags =3D sync ? MF_ACTION_REQUIRED : 0; @@ -535,9 +535,8 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest_g= eneric_data *gdata, int sec_sev, i; char *p; =20 - log_arm_hw_error(err); - sec_sev =3D ghes_severity(gdata->error_severity); + log_arm_hw_error(err, sec_sev); if (sev !=3D GHES_SEV_RECOVERABLE || sec_sev !=3D GHES_SEV_RECOVERABLE) return false; =20 @@ -870,11 +869,9 @@ static bool ghes_do_proc(struct ghes *ghes, =20 arch_apei_report_mem_error(sev, mem_err); queued =3D ghes_handle_memory_failure(gdata, sev, sync); - } - else if (guid_equal(sec_type, &CPER_SEC_PCIE)) { + } else if (guid_equal(sec_type, &CPER_SEC_PCIE)) { ghes_handle_aer(gdata); - } - else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) { + } else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) { queued =3D ghes_handle_arm_hw_error(gdata, sev, sync); } else if (guid_equal(sec_type, &CPER_SEC_CXL_PROT_ERR)) { struct cxl_cper_sec_prot_err *prot_err =3D acpi_hest_get_payload(gdata); diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c index a6e4792a1b2e9239f44f29102a7cc058d64b93ef..c1b36a5601c4b12988089ad292e= e5f1c5dc862d5 100644 --- a/drivers/ras/ras.c +++ b/drivers/ras/ras.c @@ -52,9 +52,45 @@ void log_non_standard_event(const guid_t *sec_type, cons= t guid_t *fru_id, trace_non_standard_event(sec_type, fru_id, fru_text, sev, err, len); } =20 -void log_arm_hw_error(struct cper_sec_proc_arm *err) +void log_arm_hw_error(struct cper_sec_proc_arm *err, const u8 sev) { - trace_arm_event(err); + struct cper_arm_err_info *err_info; + struct cper_arm_ctx_info *ctx_info; + u8 *ven_err_data; + u32 ctx_len =3D 0; + int n, sz, cpu; + s32 vsei_len; + u32 pei_len; + u8 *pei_err, *ctx_err; + + pei_len =3D sizeof(struct cper_arm_err_info) * err->err_info_num; + pei_err =3D (u8 *)(err + 1); + + err_info =3D (struct cper_arm_err_info *)(err + 1); + ctx_info =3D (struct cper_arm_ctx_info *)(err_info + err->err_info_num); + ctx_err =3D (u8 *)ctx_info; + + for (n =3D 0; n < err->context_info_num; n++) { + sz =3D sizeof(struct cper_arm_ctx_info) + ctx_info->size; + ctx_info =3D (struct cper_arm_ctx_info *)((long)ctx_info + sz); + ctx_len +=3D sz; + } + + vsei_len =3D err->section_length - (sizeof(struct cper_sec_proc_arm) + pe= i_len + ctx_len); + if (vsei_len < 0) { + pr_warn(FW_BUG "section length: %d\n", err->section_length); + pr_warn(FW_BUG "section length is too small\n"); + pr_warn(FW_BUG "firmware-generated error record is incorrect\n"); + vsei_len =3D 0; + } + ven_err_data =3D (u8 *)ctx_info; + + cpu =3D GET_LOGICAL_INDEX(err->mpidr); + if (cpu < 0) + cpu =3D -1; + + trace_arm_event(err, pei_err, pei_len, ctx_err, ctx_len, + ven_err_data, (u32)vsei_len, sev, cpu); } =20 static int __init ras_init(void) diff --git a/include/linux/ras.h b/include/linux/ras.h index a64182bc72ad3f2b430c53c7a9e23e798a1c1fbe..468941bfe855f6a1e3471245d98= df5ffb362385b 100644 --- a/include/linux/ras.h +++ b/include/linux/ras.h @@ -24,8 +24,7 @@ int __init parse_cec_param(char *str); void log_non_standard_event(const guid_t *sec_type, const guid_t *fru_id, const char *fru_text, const u8 sev, const u8 *err, const u32 len); -void log_arm_hw_error(struct cper_sec_proc_arm *err); - +void log_arm_hw_error(struct cper_sec_proc_arm *err, const u8 sev); #else static inline void log_non_standard_event(const guid_t *sec_type, @@ -33,7 +32,7 @@ log_non_standard_event(const guid_t *sec_type, const u8 sev, const u8 *err, const u32 len) { return; } static inline void -log_arm_hw_error(struct cper_sec_proc_arm *err) { return; } +log_arm_hw_error(struct cper_sec_proc_arm *err, const u8 sev) { return; } #endif =20 struct atl_err { @@ -53,4 +52,15 @@ static inline unsigned long amd_convert_umc_mca_addr_to_sys_addr(struct atl_err *err) { return -EINVAL= ; } #endif /* CONFIG_AMD_ATL */ =20 +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64) +#include +/* + * Include ARM-specific SMP header which provides a function mapping mpidr= to + * CPU logical index. + */ +#define GET_LOGICAL_INDEX(mpidr) get_logical_index(mpidr & MPIDR_HWID_BITM= ASK) +#else +#define GET_LOGICAL_INDEX(mpidr) -EINVAL +#endif /* CONFIG_ARM || CONFIG_ARM64 */ + #endif /* __RAS_H__ */ diff --git a/include/ras/ras_event.h b/include/ras/ras_event.h index 14c9f943d53fb6cbadeef3f4b13e61470f0b5dee..ab217cc277c556b8847971c807e= bbb587d5a29ce 100644 --- a/include/ras/ras_event.h +++ b/include/ras/ras_event.h @@ -168,11 +168,25 @@ TRACE_EVENT(mc_event, * This event is generated when hardware detects an ARM processor error * has occurred. UEFI 2.6 spec section N.2.4.4. */ +#define APEIL "ARM Processor Err Info data len" +#define APEID "ARM Processor Err Info raw data" +#define APECIL "ARM Processor Err Context Info data len" +#define APECID "ARM Processor Err Context Info raw data" +#define VSEIL "Vendor Specific Err Info data len" +#define VSEID "Vendor Specific Err Info raw data" TRACE_EVENT(arm_event, =20 - TP_PROTO(const struct cper_sec_proc_arm *proc), + TP_PROTO(const struct cper_sec_proc_arm *proc, + const u8 *pei_err, + const u32 pei_len, + const u8 *ctx_err, + const u32 ctx_len, + const u8 *oem, + const u32 oem_len, + u8 sev, + int cpu), =20 - TP_ARGS(proc), + TP_ARGS(proc, pei_err, pei_len, ctx_err, ctx_len, oem, oem_len, sev, cpu), =20 TP_STRUCT__entry( __field(u64, mpidr) @@ -180,6 +194,14 @@ TRACE_EVENT(arm_event, __field(u32, running_state) __field(u32, psci_state) __field(u8, affinity) + __field(u32, pei_len) + __dynamic_array(u8, pei_buf, pei_len) + __field(u32, ctx_len) + __dynamic_array(u8, ctx_buf, ctx_len) + __field(u32, oem_len) + __dynamic_array(u8, oem_buf, oem_len) + __field(u8, sev) + __field(int, cpu) ), =20 TP_fast_assign( @@ -199,12 +221,29 @@ TRACE_EVENT(arm_event, __entry->running_state =3D ~0; __entry->psci_state =3D ~0; } + __entry->pei_len =3D pei_len; + memcpy(__get_dynamic_array(pei_buf), pei_err, pei_len); + __entry->ctx_len =3D ctx_len; + memcpy(__get_dynamic_array(ctx_buf), ctx_err, ctx_len); + __entry->oem_len =3D oem_len; + memcpy(__get_dynamic_array(oem_buf), oem, oem_len); + __entry->sev =3D sev; + __entry->cpu =3D cpu; ), =20 - TP_printk("affinity level: %d; MPIDR: %016llx; MIDR: %016llx; " - "running state: %d; PSCI state: %d", + TP_printk("cpu: %d; error: %d; affinity level: %d; MPIDR: %016llx; MIDR: = %016llx; " + "running state: %d; PSCI state: %d; " + "%s: %d; %s: %s; %s: %d; %s: %s; %s: %d; %s: %s", + __entry->cpu, + __entry->sev, __entry->affinity, __entry->mpidr, __entry->midr, - __entry->running_state, __entry->psci_state) + __entry->running_state, __entry->psci_state, + APEIL, __entry->pei_len, APEID, + __print_hex(__get_dynamic_array(pei_buf), __entry->pei_len), + APECIL, __entry->ctx_len, APECID, + __print_hex(__get_dynamic_array(ctx_buf), __entry->ctx_len), + VSEIL, __entry->oem_len, VSEID, + __print_hex(__get_dynamic_array(oem_buf), __entry->oem_len)) ); =20 /* --=20 2.50.0 From nobody Sat Oct 4 15:57:30 2025 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2136.outbound.protection.outlook.com [40.107.94.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36870222562; Thu, 14 Aug 2025 16:53:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.136 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755190392; cv=fail; b=eAiyQFsct7QnsIOVsADge1Mwms+kLk1xmbHxnvrHYERKDbVS4m3vAbKWMfGeJiI6+xORvf7dHwTVQJmpJOnSaI4Y+1bnRQaiUJUQQOF2C/9G/x9t7g8Xh5Yifhwslsv6gM0JLiVNFjTttDjG42QLxc06B6kAW5K8XnAcKo1we3k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755190392; c=relaxed/simple; bh=LlZZ0Gm00xCu5Lae6eN/LXpEBiAwLxBE9cvc3rBi8Ws=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Svt1owkWU8X1cyAgiYKou2/2BBeV/ahv9JKMi4eZr0bpIqwgyg6aIvHesvnwDTmqUL+KycAo/PaVJg/ZiJxUQOB7hK0Fi/jFLm80igEyDsFiOALseSkvPxbNA4GEoyRupLuPrZwLkTYmx80B9E75KguPJwOEXXPedjLrZkEQqsU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=MgvlT7Li; arc=fail smtp.client-ip=40.107.94.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="MgvlT7Li" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MSp8u5RFz0BtxjYO5rFibuGoMZVPUajlzbbI5gOvFIipP/QKAqdjfRqMUd+SPs2+077VfqWEzaZAD6rIXYwE47PchhShP+Nw2ysFmezah8+7lSLnk4l4HqApeKiuo9N2pP5koWtsRsdGCRrcM9C4HlL7d4rn8/lS0bRwdydYINQhG02Rz+K/WM25i5jdUfzExP7dmnIftjZfI10qpdNkmJ5I8jX/8Fn4ezOIvRBVUXcNBSg6iEjFXoWgqeF0AJBIFHhyFsgSQLRBKlJLF0VGGxN3NNx0a78DqiOCCw7aciRMT9dUGS6jS6VRD38FnPbbxzoMjouwAM9MsoowS3SWIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N5dTYyLO+c0RocfQ/gTdNVPVLsU4K+mEnn3DMqJxO1g=; b=sRMrEG1S+RozdkJFAsgkdLAMNU59899oCmw2ZScQ55fMVixUcG40/zdoFftlVDOIYGfh1gI3yRLU0wafhGVKMWyTjFTy6f/IgFS6rZ0u2Ao1ufUTuWmIRKFpp41pXVGgOkE79hteRKmleQ6KVUL74YxPXUw9KjF+kL4cQOvF7135PNsKkVUqTBlB8SSP/ZoOqtJh+S7oRYjc+Q/W3B33wT/rvzC6ibRWrbZwa7p0d8sW6MrMBn23tZ3n2HUo6bSC/mBDmo41ntvFl6XHI3jnhfRn4weTL+47WP6aYrGxieTEOame9iYCDbcaiKki9rIx/wc8DoQiUMLNd+ahqVzufg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N5dTYyLO+c0RocfQ/gTdNVPVLsU4K+mEnn3DMqJxO1g=; b=MgvlT7Li40DuhSl9KNRJTPZpz4i1+NBUcr3SuO2Pmk3KsfsbkaS0+l1SHQIykezeOPNrk1tmkEY4tuSkcAkqCkw1EYPEmZsKJOPTSPabwJXC+FvDG1uhG0hn7uh9OVkIRbgm5e1wm2g02PrnxvIBqPleW/Qq7PvM36lKnnEw9SA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SA3PR01MB8473.prod.exchangelabs.com (2603:10b6:806:397::12) by BL3PR01MB6881.prod.exchangelabs.com (2603:10b6:208:354::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.18; Thu, 14 Aug 2025 16:53:06 +0000 Received: from SA3PR01MB8473.prod.exchangelabs.com ([fe80::46d7:1d3a:dc9c:69c3]) by SA3PR01MB8473.prod.exchangelabs.com ([fe80::46d7:1d3a:dc9c:69c3%6]) with mapi id 15.20.9031.014; Thu, 14 Aug 2025 16:53:06 +0000 From: Daniel Ferguson Date: Thu, 14 Aug 2025 09:52:53 -0700 Subject: [PATCH v6 2/5] efi/cper: Adjust infopfx size to accept an extra space Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-mauro_v3-v6-16-rev2-v6-2-e5538d534aa0@os.amperecomputing.com> References: <20250814-mauro_v3-v6-16-rev2-v6-0-e5538d534aa0@os.amperecomputing.com> In-Reply-To: <20250814-mauro_v3-v6-16-rev2-v6-0-e5538d534aa0@os.amperecomputing.com> To: Ard Biesheuvel Cc: Jonathan Corbet , "Rafael J. Wysocki" , Len Brown , James Morse , Tony Luck , Borislav Petkov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, linux-edac@vger.kernel.org, Mauro Carvalho Chehab , Jonathan Cameron X-Mailer: b4 0.14.2 X-ClientProxiedBy: CH0PR03CA0384.namprd03.prod.outlook.com (2603:10b6:610:119::26) To SA3PR01MB8473.prod.exchangelabs.com (2603:10b6:806:397::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA3PR01MB8473:EE_|BL3PR01MB6881:EE_ X-MS-Office365-Filtering-Correlation-Id: a996e30d-6ecb-4629-5e40-08dddb530aa2 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|366016|1800799024|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c2RWNkkyL0JwakczZmJOOVBVTWRUV3ZjNW8xSmRucTRaYjVhZTdWUmhwT1R0?= =?utf-8?B?bGIvWXJxcU1JUFJjNjEwSHV4dEpCQVJOc05vRVphU090L3liYnpNR252eW9S?= =?utf-8?B?bWJjQWM2LzBYWDh3eGlETy9wVHFoUDhQMDg0S0hXMWphWFMzOWwwR0dRcENT?= =?utf-8?B?cHF3T2xQQ1lYWWh4VWttY1huUWs2N1V0UFVxK0pKTXFKalp0RUozVWViV2k5?= =?utf-8?B?a0hySjNFZmJ0VHVTamxJbFpvY1lGSUNLMEhabkQ1S3Y4US9ENk1uZnVVYUNs?= =?utf-8?B?NU1BcUxjaXNBN1BYQURwbUNIamI5YXZ0cHRsbFFIYUhHR1YwUkw2bStQeTdj?= =?utf-8?B?bkJtUnBjY2RPMTd4QXBJMUVnaEdmSW9FZjREY25zQUJrOGFFVmdGcG1RQS9r?= =?utf-8?B?TUFmcUthKytnTHdtYTQzYWdGRTAyVTVmWmNhZEo5V2MrR1lCNEdCRjlVVG5Y?= =?utf-8?B?NlIyT1ZUVkZSZVkwZ2x6OHVuVVNLVzhseWYySUxsYk5Ra1BrUWEvQWhDTHow?= =?utf-8?B?SDAybkgvRE5xYlB1UXZoeHdINlFTcSsvaXZmcnRac25SYzllYjNxYWNQeUVw?= =?utf-8?B?L2tWUjVtaWhVdXV1QTlLNkFId3hiKzVpaTNIMHdUTWczMWRVZUN2bm95dmhN?= =?utf-8?B?VkZ1WlMxQ2kxb2I0VnpWcjJnbkVSNGxSZ0NIRlhqOE5hTUVSdHM5SjhwV3pt?= =?utf-8?B?eWlaZ2xjTkZxRGh6WHhhaUZlV2xqb3RRaVJuaHVYRkVwMUJCa1dpdGgzdjBF?= =?utf-8?B?bmhCOVNBM3ZZWm1SamREaEtVYUtHczRMcSswaXplTEt0Qll4YTVYQVNsMEZJ?= =?utf-8?B?b1ZCSHpQM0R3L1hxZkloLzB6dVA5cEVMWW5ENnNvb3QzaGduRG9VMXBKMVFR?= =?utf-8?B?MWtnTksrVVRLYWpYRFh5dmRzZkE5K1djZkloK2J1ZWFoL016LzFCcUhqdXhW?= =?utf-8?B?N1pTWng5RWtuNjZkWHYyKzRLb2lUSWRzTFFPYkZYL2tvRVVLWlViSFFTUEFC?= =?utf-8?B?bkZCc2g0cUhydlJLZkpmc0NhQUhaQ0JUbkp1akRXU3F6d3Z4UWd3WVVLT1ph?= =?utf-8?B?MkhwZkJjVUZ3ajNGRUlxemJwcFNZdEtiNlRWaXBicEVteWtjRURNMkMwMzZi?= =?utf-8?B?UmhRb005amRsUGMySTRkTlZ0eWJnWnRidVhjTHp0VWpYdkpyQkhWcDRhY0Jy?= =?utf-8?B?dEVBTGVuTG81SXROM29iQ3BFcTdpMWlJZTFGZnROaWxmMEpjQzIrc1p6eEow?= =?utf-8?B?alRYUTFFcnZzQ1Ava2tXZmJiTlNyRHRmRmM2dWhMMDBCeWt6L2Rydlc1UUx3?= =?utf-8?B?NEhBZExCWnBwWVRkVFVxN3dCd1dFaWFZa1psWStJTDUyaEtaRlRLUW0zK1Q0?= =?utf-8?B?NDYrR2dNYUNnLzV2OGVlam1FQVliN1U5VnVsYmJ5RkVQRDV4ekQ4RU80UUhB?= =?utf-8?B?cElOZFNLVVBmZ1l5NTdtam5OOVNOSUprMldXZVBpV3pjaUgwcXVWTlhsR25y?= =?utf-8?B?U29Fd3BSRTdsMThNK08rdnlOTXowTDNaZmcyNFFnUTNpSVNKb3pFYmRWYnVG?= =?utf-8?B?UEoyQjlaRVdQdEJxeG05TXpyMnlNa3pvNlNoQ0hrdERuRCtvL0s4ZVVYRkV3?= =?utf-8?B?SEFwU1NIbTUrVWRrNHA3dHFPejdwd0VFRytQR2Y1NmhJeHF4VGRHbTZPSnZl?= =?utf-8?B?aWJ3SzBUbmpOWVVpRy9HajZZTzhGSW94V0lJTE1SSlMya1o1Z0l0Qno5WVly?= =?utf-8?B?SDFUdzJ4cC93MTFaMm1PWlVjd1UwNUM0YXhWMEovUVU0L0NQYTgwZXdPV250?= =?utf-8?B?cUhGNjBMRG5kR0NvMnhtb2hESzZaS0RiUUh1bjNzNjY2L3J5NXQvd3VXVlRG?= =?utf-8?B?akpNek4vZE00ZjZjaXo0MmhramRNL092Q0lhVjloRGIxVEptRlVCQ1AvM0h3?= =?utf-8?B?blVRa2M5aWNXa3dUR0NzY2J6ZlFLemJwM24wS055TlUrVXFWTHhzeFFJZDl4?= =?utf-8?B?bC9mMXI3SzhRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA3PR01MB8473.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(7053199007)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejRTbk9TSXpmdWdUSDFnVlFzcUJ3QS9kYTMyRHJnQjVjWkZwV1ozWktnbjZU?= =?utf-8?B?M2JycElaUmVHYUpaV3BnNnp0MmtxdXN2aWR3SWpVZkg5U3V1aFZsaTdqbnpK?= =?utf-8?B?RmUreUNkenBIRk1LK0ZKMVlldG5aUEZvcGhYbWtDa0Z1U3N5encyV0pzenM4?= =?utf-8?B?NjJRcE9ZemZwUHVkOGFMSjV1bi9MZXFLMFJQNXFaZWhiMnVTQVRsN3k0MlVD?= =?utf-8?B?OXlkdWh2STRkUXorRTlFZDlPK2FpK1pnM2NRSmYyei9yeHBOeGtwc2tpM2o0?= =?utf-8?B?bW1ybGNEZ2pIRWxucWVKN0FidXltOXlnZnA0SUFVL1V6WCsrM2FqVXJ4c2VN?= =?utf-8?B?RXVVZDc2bThiQTNWd2VuN1VkUTJ6RVV0bU9aMi9JM0R6L3c4bjl6SUlTbHc0?= =?utf-8?B?MEFpdy9TUzRvaFZRYlMyazkrengreTk0ZlpHYVNSMXN3alVFTXJHUy9EZS9Z?= =?utf-8?B?TWhMK1NVVlRYNzRvUUVlSXhLczc3cXkwNjkxb2ZhTW5Tcmd5NmFjOW4wdnRh?= =?utf-8?B?bDlucjBOUzFlMHBTcmRURlBQUFEvZzRtOG1qaFNZSHAwTzZVQWo2Z09oTTJ2?= =?utf-8?B?TUNLYWZrenUwZ1NmVGZqZ0t5QWMrWEt4OEZLaWVMRGVCN0czUUpmSTVlZld6?= =?utf-8?B?SjFaTG1OY1IzTmFvamgvTmxGVDVtYkZZUE96UzV2R2xzWG5iTDhOVmZCYnRI?= =?utf-8?B?SjNPVk5VaGN5Skd1ZFo2dUlwVXBWK1JjSE5BZ2ZsUk9vSFdqOW1OeE91QklF?= =?utf-8?B?UDl5OUpNTGVzNVpUU2FSNjh1Yi9xVWNNZjRDWEw2dUtTS0oycEI5d1BMd00v?= =?utf-8?B?VGI4M3BaMHlPeVRlWktWWlU0RmNaWkdUWU1icUNkQ21JTWs0TXNKK1dvajZ0?= =?utf-8?B?ZWFrZVVQOTM4aUFOL3YxdGhFUEk0VWhJeGh3Y29CSGFMNnlqdDkwUnkrMFY5?= =?utf-8?B?VG5MQ2MxcnhuQUdIU1hTc0xKMFFPUEh0eU56RXdPYVhRbisvdnlweUM4ZmlU?= =?utf-8?B?SUl4amRmTll6d0pnRFN6aWJRN0M0RHRUUXgyN3NkVURHZjJZc3dRenYxUE5p?= =?utf-8?B?K0RtRFVubHMrNUpXUU11UFUvbkl4bVBxU1pIanRuVnluNjVNSmI4T2FhZ1U5?= =?utf-8?B?MkoxdmJTNU1SUVVPRGc2ckdDMnZBUENtcWw3TzJMQlZnajh6L0pXT1RVSldk?= =?utf-8?B?cVkvR3dIcHo3ZFRCZ1p6L3RNejFqZ0gwRXovZnZaVkh0RmVadDM2R2RRZklF?= =?utf-8?B?Nm14UktYbFRCeGJ5VnIvUDFOdXJVaTVzcG12aFh6M1poOHN0OG10clpFZGVI?= =?utf-8?B?MFpUSldveDY1SE5JYmZwUmRxbDFGczYrVFhmYzhucmhrcFNSNS90M1M1V25F?= =?utf-8?B?QTAyYWhqeXlKajErK2FvUkVzc2p6UTgvc3BueDRCekNuRlVSWnhyWnIvT3Ay?= =?utf-8?B?Zk9yL2RDSEpKekx1TVRGazd0bHI5ZGpvS2JranF6RS9NVXBObjRROXk5cGox?= =?utf-8?B?cDVINzlkQ2d1cDJLRzdhSDhpcVdkUmtSZCtzNFFqSFJsUHJXQ0w1WUZFbHpB?= =?utf-8?B?ZUhFZzcxK0VZTC9OendadDlBTlBKYVVhaW5IVzhSNzJzVjJtZ0VnNmhFYjFY?= =?utf-8?B?RWJ4QVMrZ3RhWlNUUm90azR0T0JvNHpvbEVFN3k2RFVxUFhYTHlJd2oybVlr?= =?utf-8?B?WXMzRU1Nb1VKOXM5SHZBL1dRaG9FczUreHlPV25wZ1VQQ2lQcWI5SzV4cFRq?= =?utf-8?B?MnNOOEdvalQwelgxYzltNWwzWEFzWEw2VlNEMXg1RGVOV3hudXlyN0N6bmV2?= =?utf-8?B?TjRJRElzMXhyUHZleWgyaVFHbnRqSXR0cWtHaFQxS2Q3SmhLU3ovSmtNb2d2?= =?utf-8?B?akczbGdHVUg5Zy95WFJqUUJIRTdtQTZwYWNnYXZsWFd3T25EWWt1VG12UDc0?= =?utf-8?B?emFnRVVmY2FHdzBCZzF3Zk85RTA4OG1FYnU1b3B5dTBJZUZUTWs2eXZzclVq?= =?utf-8?B?dFpRcGcxRXFIRlQ5NGF3S1lDakZZRDdMYjQ3eVE3SlVVb21hVWlTRTBqKzBE?= =?utf-8?B?ZklRWjhydW96TzJJNXpkbmo3NElqeVVVTEJNNHhGYzV2QTh3c1VEdjVFdEVa?= =?utf-8?B?UzROVWN2R0NiT0hlWlljWkt1RVQwSkt0QXo1NGRucWZLT2xJVjJrM0wxUWhE?= =?utf-8?Q?HUkSaP5v7wy4GHp9wdNcg/k=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: a996e30d-6ecb-4629-5e40-08dddb530aa2 X-MS-Exchange-CrossTenant-AuthSource: SA3PR01MB8473.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2025 16:53:06.5562 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TJ5yIoBxT6DlqYVsf3FFPglISvp4baoaPPbMqlTdFK+2uPiaTSmlY0ng3cAmUkjUX4ONtSFV6a/WOrZlVIRP+R8PyhEbsEc9u5qE5y30iju+eBrB2w3itIWRtCl6QRhj X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR01MB6881 From: Mauro Carvalho Chehab Compiling with W=3D1 with werror enabled produces an error: drivers/firmware/efi/cper-arm.c: In function =E2=80=98cper_print_proc_arm= =E2=80=99: drivers/firmware/efi/cper-arm.c:298:64: error: =E2=80=98snprintf=E2=80=99 o= utput may be truncated before the last format character [-Werror=3Dformat-t= runcation=3D] 298 | snprintf(infopfx, sizeof(infopfx), "%s ", n= ewpfx); | ^ drivers/firmware/efi/cper-arm.c:298:25: note: =E2=80=98snprintf=E2=80=99 ou= tput between 2 and 65 bytes into a destination of size 64 298 | snprintf(infopfx, sizeof(infopfx), "%s ", n= ewpfx); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~ As the logic there adds an space at the end of infopx buffer. Add an extra space to avoid such warning. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron Acked-by: Borislav Petkov (AMD) --- drivers/firmware/efi/cper-arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/efi/cper-arm.c b/drivers/firmware/efi/cper-ar= m.c index f0a63d09d3c499b2f1e51d5ef35b69deeb3cbdb3..6ff781e47147c05c784ca5aa571= 49d1435cb2467 100644 --- a/drivers/firmware/efi/cper-arm.c +++ b/drivers/firmware/efi/cper-arm.c @@ -240,7 +240,7 @@ void cper_print_proc_arm(const char *pfx, int i, len, max_ctx_type; struct cper_arm_err_info *err_info; struct cper_arm_ctx_info *ctx_info; - char newpfx[64], infopfx[64]; + char newpfx[64], infopfx[ARRAY_SIZE(newpfx) + 1]; =20 printk("%sMIDR: 0x%016llx\n", pfx, proc->midr); =20 --=20 2.50.0 From nobody Sat Oct 4 15:57:30 2025 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2136.outbound.protection.outlook.com [40.107.94.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3DA31FE444; Thu, 14 Aug 2025 16:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.136 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755190395; cv=fail; b=TBHChZTXlNLtagu8mqUR7RxjnvnLMeBcRdSlCyV3yfrJe20qGWQS11biQZMl0bTbxJ2WV6pLtmJAOCneBJlQU8JehoIV5rZfI8Xe1foInQ6bs7ooQkuId7nu7ro1i6VGomR/XFplWz4WXzYucej7UBUK82BnxXcCTbWOvQGg2b4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755190395; c=relaxed/simple; bh=WIm4YZuVm8GRqQ56fl77W9tQ9ZnRZw0TB9sxkSlwrhE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=IHwtjn7ynnLDqPMT43+H4Mq+8rlCG2e/gITPkWv7lZyiGLCmyF/eSeY7gttkCAv17p+GKAL99RKWAHn1yE5t3XKz5lj7pX9F+2LqJCviw4QOLfW8D0x0UD5w2/Vm+5qgDvqSQP/vZh0xOmXeowB0FxoLsGpq+//XzIbksXhzrBo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=tfKzbTf/; arc=fail smtp.client-ip=40.107.94.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="tfKzbTf/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dXshcARbhq7uDD24jLTF0nNHwC2T0e9ZX0OADIrfvVKIWtqsdaVyuhxzD+WOJHCjLrsv1shWIDLclQeJXZ20C4V2ha63tfVF3TNOAPI355Z037ETK65A8UqAHvxKwr/kY7OyJCZceSxEYCpEtU14xhfTNZySQS+S+2jZQgrEnp5/WFRK4jOPLoBupdf6fAhbjzRWoTBCOUyftSRywwRwpWh7in9wmo6p00RA5/g3AA9UVk9ECKV6WMhKlR5F4cBsi7ymCMuoJOiXWEdPKNV8A9UGOQAIKecB7WdB/E2fDWJ0FJCCXUwTCosi3s2EDvvIHT5AyFlpIOPB07O8luzOnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hU7qPRDo098enreObDWvO8WMDj7vA18Bpd0e6VEm0wQ=; b=NWdsRjdOhx6ZmVa/xAKIzaSZ9P5whlYqSi75ef1v3FfCSbXK8Yy7GiCIGBjbnnz/2BpRehADhof1a/yDzz+v1nquHp8gMVDHSs3nIgB3WMUJBxWVQu3Zy3qVDhXQLvKYdMHe7eHRmRt+2e5bgF3MsgFIsPzUGOLC+ybiiKOWv94ZjkiyhteHa/rnmpnVoh7zkhwW9Ul98udUhhz8M4ZBNBF8sIllsVXBzZKKOOp85wbWhaEZjg0NAgiMuHWC1OChjyb4kFIWQiOXs+y2ROx6y/JBn6yVQUBOiP1+88Rx8H3kWPN9yt437vlM4e4iWWSXzeDUhbt2KfqMwyIQzaEJjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hU7qPRDo098enreObDWvO8WMDj7vA18Bpd0e6VEm0wQ=; b=tfKzbTf//nLOk9lvSm4x+vwmwlnb84i+9MfN3K0hF6m5BcRX1rahgwzY2FdH7OnOrNbjVs26you+KpSN64du0+E0jUUEH8LPY2TljcTBzMh84Hj2KlDJuzetCtE0XcRxOYw1+x7ySpjBNPbj5afjrubY6pLKlEVt0D4xvRFNAA4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SA3PR01MB8473.prod.exchangelabs.com (2603:10b6:806:397::12) by BL3PR01MB6881.prod.exchangelabs.com (2603:10b6:208:354::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.18; Thu, 14 Aug 2025 16:53:09 +0000 Received: from SA3PR01MB8473.prod.exchangelabs.com ([fe80::46d7:1d3a:dc9c:69c3]) by SA3PR01MB8473.prod.exchangelabs.com ([fe80::46d7:1d3a:dc9c:69c3%6]) with mapi id 15.20.9031.014; Thu, 14 Aug 2025 16:53:09 +0000 From: Daniel Ferguson Date: Thu, 14 Aug 2025 09:52:54 -0700 Subject: [PATCH v6 3/5] efi/cper: Add a new helper function to print bitmasks Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-mauro_v3-v6-16-rev2-v6-3-e5538d534aa0@os.amperecomputing.com> References: <20250814-mauro_v3-v6-16-rev2-v6-0-e5538d534aa0@os.amperecomputing.com> In-Reply-To: <20250814-mauro_v3-v6-16-rev2-v6-0-e5538d534aa0@os.amperecomputing.com> To: Ard Biesheuvel Cc: Jonathan Corbet , "Rafael J. Wysocki" , Len Brown , James Morse , Tony Luck , Borislav Petkov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, linux-edac@vger.kernel.org, Mauro Carvalho Chehab , Jonathan Cameron X-Mailer: b4 0.14.2 X-ClientProxiedBy: CH2PR19CA0007.namprd19.prod.outlook.com (2603:10b6:610:4d::17) To SA3PR01MB8473.prod.exchangelabs.com (2603:10b6:806:397::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA3PR01MB8473:EE_|BL3PR01MB6881:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e414a8e-3aed-41d9-bbba-08dddb530c89 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|366016|1800799024|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c2RCOWpFbFZwWGVTY3E5a2ZXOURieks2MVZQMWVETGdkMDJQSjNxK0ovTXQ4?= =?utf-8?B?NlN0eEI2cmdGNEJEclROMlRmd2VhWCtHTnZMMi9OTjdQWjVDYmhhWXJwY3Vr?= =?utf-8?B?R3YveHJuVW9DcjRhY3d6TlEvNkJVbTIxWGdaYzhyNFpaaHFBZWdhWkUrWUJ5?= =?utf-8?B?T1drby80ZHppTVFzdXRwS1F6RHh4WWpJbmt4eDJTazhqVEp6a0p2azBiNDF5?= =?utf-8?B?MFBjUEpDSHpOa1FrOE5tN3BTd1JIek5xeERmWCs0dnJCR0tFY2VFRU50ZkIx?= =?utf-8?B?Q3RoeUdqZWpQcDcwYndIYVRZM2hFU28xVXgzakNGL01mei92QmtaZkJyNVBX?= =?utf-8?B?UnM2bGtjaGt0bmJ1OWo4N3NyaktwTWNaSGlBT25kZ3hCQnZjZm56WHZUU0lr?= =?utf-8?B?YXd4VGxNQk5vZnpYSm15U2VwWnRxOTlYYW1lT1dla3lhQmpjbDNaTkovM29U?= =?utf-8?B?OUcxNHdIMWF3bXFpQ2czL0JnN1RTZnBiUkU1YW1rK3c1eFJtaE1BdmFyNncv?= =?utf-8?B?Y3kzU1hXeEEvVUF3emFRSFlsWng5cERObFp2RlhLTXd5Q3dFc2tiTUFiNGRK?= =?utf-8?B?VHgrWitvSWF0cHIvbFpZM2pVOUZGdUxMeWRzenBhb1NNb1FjS0ZLYUs3OXQ2?= =?utf-8?B?YmVDWnJ2NXZFR04xL3pGMDV3U1JBNnFYYi9hM1VBTlc1NHZISzlmUkdXaTV3?= =?utf-8?B?dHh6VEY5T3BJK1Z6aTZRYjFBSHRka1dpOWJ6dDB6ZTA0c0grYnNKdFNzOXVL?= =?utf-8?B?WjlJbWxTaityVkVjR3YzQUZLMld0SjhmNHM1Z0RYNEY0dU80cHZJMTB3Vk9p?= =?utf-8?B?dnNvUm1rcnRIOHdKeFlob2RSNE4zU0VRS0Q3YnltbTU0WTgxc0tSTVZnWU5C?= =?utf-8?B?Y21QOWgwTW9aalBGWGthUWVWWHBRbW9CaDNZbG8vSXJLQXRWeUN0N3Rid2ww?= =?utf-8?B?c1BRYWRXUHFuYmxISGtZM1E2WWZNRkRVTnNvbVFNNWdYN1FEK2U1LzVwczBu?= =?utf-8?B?Q05KdWwrcUhlTnhBdWFHQjMycnNwSmFxVXlnUjZWcm5HbzR5alc0Q3Y0Mi9h?= =?utf-8?B?M1NmRGVlL2RXcHhnL0laN3BUYm9uMXdGRHBqbHVCRlpleUpXQ3VVZk55MGZx?= =?utf-8?B?UWpGNzVISUFTUWM2eDFRbHQxV0dlSy9ucE02b080L1dGUllZT0lDYitkeWlI?= =?utf-8?B?b0hMbjl5QUl2amxQaWR3dFRtL051WXgvMVExYlRqL2ZYUEZzbUxCUmVibXJ3?= =?utf-8?B?Q1lmY3RGaWEzcGNYQ2RGN2MrTTBJK05uU3BGUFNXSCtSb2w0cXFYazhPTmtr?= =?utf-8?B?ZTAvUWxyMFZZTUllTmkwMTgrZWhYVnFFVTdGMDEyaThqU3UxUXBjTTFXeEY1?= =?utf-8?B?d05LeVF1eHJmUkhhOWQxK3gvTkxYdWRZT1FUdFBoR1d3bnBXcE5WTGxnK3hX?= =?utf-8?B?U29XcGtjSTBINUVUck9qeGZMbWtWWUdwb0ZsdjRaUnNaa0tlcmFjYmVqT0pC?= =?utf-8?B?ZDZGMjRBQ1lXUDAxSDBSQW1jQ0lLQkZzSnU2NWxZaE51dU1RNTAvWUFpc1JZ?= =?utf-8?B?S3k2MzlDQzMweUI0Z2NtOHJlOWh6a2pVNnFEOFNwRkpCNiswZGtHMGJ4eEdM?= =?utf-8?B?eUNCdGJrb2FEWGx5VFdzNlExcE5mSm4vMDV5WGYwQjJQWSsyMzhXaG5OazJ6?= =?utf-8?B?d3N4TG1Da2NXRm1nNzVST2tVMzdreUMzcnVhNWFRRlFrVGxaWTR0dmx5VjBq?= =?utf-8?B?TUhLMWRlaWg5eVZVakFLYWx2WFZNMXhsYXMrQXBOSkVGRFV0UWJvdTRtL0Zz?= =?utf-8?B?cDAvYXZQT21yeGpobzJobmFZc1ZGSHErd1lMZ3FQRXREM2VWdHJqSGs0K2sz?= =?utf-8?B?MDBLSVN0Tk8vaTNjTmRBeFpyN3VCcGdVTFF2Rnp0aStPY2J6eDdaVGo4WXp2?= =?utf-8?B?ZkdiUHY0citnbkgxV3N2ak1lV0lCakZJV1NlRFJZQzdEbzJtT05LZlRtcVZo?= =?utf-8?B?eU52ZEZpVUl3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA3PR01MB8473.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(7053199007)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGtRM2JVTTQzL1pVN01xbDVpUXZtQXg5Q0JLNW95eTFlOTIzY3o5MUJtYXh5?= =?utf-8?B?SzdmdkZ6SjdnSENvSjNmOGFBTEZ6QXRxc3ZMeTFVc29YVUxCVGlFdkJwdy8x?= =?utf-8?B?aGxaSit1TVpWcDVnR2tTWG8wWWRqaHNIT2tUT1dadzI2eEY0QjBpRmpKZmty?= =?utf-8?B?dk5QVDZpSDJlMGQ3YkxybW1uYXltWCtoWTlQaGNEUk0yVGNnZ1M4dCtiaWRx?= =?utf-8?B?VU82MUl3Q3JwNUlEaWxoRndWMEtJYnZ5dUlSdjR0V1c4Z052dEoyR2VEN3NC?= =?utf-8?B?OUp2VkYydmNiaDcvWEtueXRyV3YwN29lQjZucEsxa3o3cm40Z2wrMVB1b1ZT?= =?utf-8?B?M1ZMQ3pHWitFc2pEaUJob1hzenRqdkxTVlZWcVNucGVZRFhycW0ybUpkaEhn?= =?utf-8?B?R1V4dDJvOEhld3dvQkZSVFJ1VW1Fd0xINEJvRlJPNG9hSFdmK1duNWIram5E?= =?utf-8?B?SVNTM05QYnlkY09tNm4rRmljbDZoaWVVekVaY0VUYzN4NUpLTngvcVl3V0du?= =?utf-8?B?RmJPcE9KSGZ1bVhVRDNPSzRKekh6K0VhL3c4SjIzeVhLUTFDaDJHSWloY2tH?= =?utf-8?B?UW5VRWFidTFTQUN2SytGdjVmRzNwMytiSStMSWVmM2M0OVNNMkdQQzBuYm1E?= =?utf-8?B?Y2prM2xHbnljVGpXdkNkaDhNK0JLVU9BZHRlZGtmZVhUL3E5Z3p5VUxaeWxz?= =?utf-8?B?R1E3YzNrekM0WVRDTEcwZ1FvZnpiTkNjUjU0R0Q1a1kvU2VBTFNHcWpEcytY?= =?utf-8?B?V09iN1pER1p1cmJlK25kZkcwOFFnb1dVWGFlSUFySERHSFBTRjhETkRqRC82?= =?utf-8?B?SERYWXdCZ0xZeGVvbmdZc29ETU93RmVyVFNSVGRRaWdtUnREcEJuQWJRZkhq?= =?utf-8?B?eWRxZTVCanBSUlIzR1k0K0dscFdtTUlyV2ljMlhBczhDZXczWUo2YnU0MmQx?= =?utf-8?B?MnYwdDBjSitQK2ZITWNEdFZ4M3BpTUJaSUI4UDlKREZoQW1wTkFzOVJTbDhQ?= =?utf-8?B?T2FyMU9wTUMzTFFFYXMwUzRtcTdXeHY0aUtwUTR5dWZMeTFMbHZvQlZvVXA4?= =?utf-8?B?akJOdlc2eEQvSWNSbUJxTW5BL3FxckRqd0FXdFRHeTEvUk1ZRUdsckhNaVdN?= =?utf-8?B?WVJuK3VIVlpiMzdtcjBqLzBnT3lEa0lBcSt0M2o3TWFnQ0k0ZUM5RG1EdkE5?= =?utf-8?B?eGpRSHVhdGFqb0MwYkk2alZGdkpZanBXQktiK2NwSUNNOHhJdkVSYWQxMm5j?= =?utf-8?B?SG4rSnFLMDBtcU1XeTZUemZweVZISW1wZkJoV3ZpNTFiaCthZGt5dzd5S1BS?= =?utf-8?B?ak4xeU9LVnJ0V0ZuUnZWNVY3cGQ5dEY3a0tFcjkyVEN5ZFJnN3JvbG9YdWlS?= =?utf-8?B?a09kYUp0Rk9RM2dteGd0OFZlNzlFZ1g1U1V2UjFiZjc4MGxBcWVTZ1M4YkZj?= =?utf-8?B?QVdwWTBBYjg3M0ZGYWZtZTdDZGNyOFNBdVlYTE1xVUhIRFZzaVkveno2elFL?= =?utf-8?B?cW5oQnIzSEdLTGR2YjlTc0xEMVV0aDBKY0VvakN4UHh4OFlNSTNvcHNZN1Vy?= =?utf-8?B?S1YwNGZlTkdKMjNGakpkRHg0T0FPMHdwcjBsRmhrRkJvUzhYaUE0ZVpudktQ?= =?utf-8?B?TUt3T3V5SmJwNVlpbFh1Zk1ZS3EzNmx6aW9rb2l3b0VLVURudlFZTng0WnZp?= =?utf-8?B?M3FIclBjYkRGUVd3dERwT3ZtTUU4eVVVV2NpZlZIY0E4MEIvSFk3R0VpNkZE?= =?utf-8?B?TWVrVVgrV1k1UjdOUDBlU2xGSHcwczdzQ3RMZGlXY2h6Ti92NzZXSFptY1Mz?= =?utf-8?B?K1ZBQnlQTXdQRElmL0VBZ1ROY09BSTZBWlJjc3ljaFRmRUlwY3ovck44SHlu?= =?utf-8?B?bGVWWWJiRll1akJNNTNOWHh6U3Qra1N3V3VmL2hxZTVJUFhmT1dleXBOYkxN?= =?utf-8?B?YVJ6Z2V2TURVQWxPdjZSYkszOHM1K1BpSy9TRzNzKzRUOGlvZWZZZjE3QmJk?= =?utf-8?B?SlYyTmM2dFZMeTdwS3kxVk9FUUgxRktLNk05WXM2anNPcnNZUWE4Q1I2R2VE?= =?utf-8?B?Tloyb0RqQnJNbnBnUjdCQ0ZnRjI1RXJwbUdjMVMvSWhsYlM2eHN1c3FyNCsr?= =?utf-8?B?OC9vSzlTcnNvTm0wdTgvSlg2YWdXaTQwZGhqc2paS1JYMSs0OEErMVlURWty?= =?utf-8?Q?DyBnD1Hu5rXg7hkFF38rINA=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e414a8e-3aed-41d9-bbba-08dddb530c89 X-MS-Exchange-CrossTenant-AuthSource: SA3PR01MB8473.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2025 16:53:09.7302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OqYlvWHvgGI7ZKa+FPY4Sx5ldiTfLGSgf0jSLzFdqpwGnHc9EbQcrW7sOCY08I+fpTARTT567DfmfrITGLuh/qYEaxTrkN+CSeM/Je9THt5otrHFZjb/k+noOsiJx2Z4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR01MB6881 From: Mauro Carvalho Chehab Add a helper function to print a string with names associated to each bit field. A typical example is: const char * const bits[] =3D { "bit 3 name", "bit 4 name", "bit 5 name", }; char str[120]; unsigned int bitmask =3D BIT(3) | BIT(5); #define MASK GENMASK(5,3) cper_bits_to_str(str, sizeof(str), FIELD_GET(MASK, bitmask), bits, ARRAY_SIZE(bits)); The above code fills string "str" with "bit 3 name|bit 5 name". Reviewed-by: Jonathan Cameron Signed-off-by: Mauro Carvalho Chehab Acked-by: Borislav Petkov (AMD) --- drivers/firmware/efi/cper.c | 60 +++++++++++++++++++++++++++++++++++++++++= ++++ include/linux/cper.h | 2 ++ 2 files changed, 62 insertions(+) diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c index 928409199a1a4009b11cf3189fe036ad8861169c..79ba688a64f8da7af2dad097b93= 31c72afc73864 100644 --- a/drivers/firmware/efi/cper.c +++ b/drivers/firmware/efi/cper.c @@ -12,6 +12,7 @@ * Specification version 2.4. */ =20 +#include #include #include #include @@ -106,6 +107,65 @@ void cper_print_bits(const char *pfx, unsigned int bit= s, printk("%s\n", buf); } =20 +/** + * cper_bits_to_str - return a string for set bits + * @buf: buffer to store the output string + * @buf_size: size of the output string buffer + * @bits: bit mask + * @strs: string array, indexed by bit position + * @strs_size: size of the string array: @strs + * + * Add to @buf the bitmask in hexadecimal. Then, for each set bit in @bits, + * add the corresponding string describing the bit in @strs to @buf. + * + * A typical example is:: + * + * const char * const bits[] =3D { + * "bit 3 name", + * "bit 4 name", + * "bit 5 name", + * }; + * char str[120]; + * unsigned int bitmask =3D BIT(3) | BIT(5); + * #define MASK GENMASK(5,3) + * + * cper_bits_to_str(str, sizeof(str), FIELD_GET(MASK, bitmask), + * bits, ARRAY_SIZE(bits)); + * + * The above code fills the string ``str`` with ``bit 3 name|bit 5 name``. + * + * Return: number of bytes stored or an error code if lower than zero. + */ +int cper_bits_to_str(char *buf, int buf_size, unsigned long bits, + const char * const strs[], unsigned int strs_size) +{ + int len =3D buf_size; + char *str =3D buf; + int i, size; + + *buf =3D '\0'; + + for_each_set_bit(i, &bits, strs_size) { + if (!(bits & BIT_ULL(i))) + continue; + + if (*buf && len > 0) { + *str =3D '|'; + len--; + str++; + } + + size =3D strscpy(str, strs[i], len); + if (size < 0) + return size; + + len -=3D size; + str +=3D size; + } + return len - buf_size; +} +EXPORT_SYMBOL_GPL(cper_bits_to_str); + static const char * const proc_type_strs[] =3D { "IA32/X64", "IA64", diff --git a/include/linux/cper.h b/include/linux/cper.h index 0ed60a91eca9d6425c9a41947a927b59f7aa2c71..58f40477c824e61c7f798978947= bf1f441ce45ad 100644 --- a/include/linux/cper.h +++ b/include/linux/cper.h @@ -588,6 +588,8 @@ const char *cper_mem_err_type_str(unsigned int); const char *cper_mem_err_status_str(u64 status); void cper_print_bits(const char *prefix, unsigned int bits, const char * const strs[], unsigned int strs_size); +int cper_bits_to_str(char *buf, int buf_size, unsigned long bits, + const char * const strs[], unsigned int strs_size); void cper_mem_err_pack(const struct cper_sec_mem_err *, struct cper_mem_err_compact *); const char *cper_mem_err_unpack(struct trace_seq *, --=20 2.50.0 From nobody Sat Oct 4 15:57:30 2025 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2136.outbound.protection.outlook.com [40.107.94.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0882E2FCBE7; Thu, 14 Aug 2025 16:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.136 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755190397; cv=fail; b=ksdzDnJuVEEUjld5zLgVQeH9qnFQcu3TLE8jhj+QOZmpkzXkdg8MN9yAR0x8N9RTF2vWfWGsBX/K8SlsXeBcpBpjezSlclsVTfv5q4iEd+2F/+bXoy91RktX+geLe+H2UvK231u1qKhpKOkCYLxk/PDkN8uoNLMpCBfZc9E1gik= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755190397; c=relaxed/simple; bh=W9uCxRmXFi4I4ZipftyIxfEBg9sBVDNykOu0JSV8rGE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=RRnzbe6cstb45N18H4Jt4GVIqDoLJD/51oHPS45cJ70S0VAkLn/N0qFLb8ebnehxhNIOx8igUh11yxBaprpZIi9dwYv8/OFhGUaNQOpXgykq43asxKTih2dFL+O8II/v7+h8DFLGKRhE4gT1AAYBbd38We6DxKf75cNSy/LY+CA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=hY0ZR+8F; arc=fail smtp.client-ip=40.107.94.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="hY0ZR+8F" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DhMFIfIMXZfRvolJZdEGzitMcoloda7gXVZI/LlFhiBT/HMcWbTM1dZ0sE+i9B9ZTQeXeOgZ3l+L2eVmc96ZK5W1K83dOLjB2agfSaKh2jJVkkV8LuuDXPhYukiNILKS9ll3Hy18bzZykL5IF5EcrDu+issRSL/eof+1FijgUz5QEJS4uSFlyP7TPfYT7KoTzCO6xteAnU5bG7ec/kyEHUDNoaX5mhRdMwPl8tVc4temU7+89Bvyyo0JYhObV3OofTd6RCUgT0ucs5zW9VeQe6co9H2Hp8DcXBFtC/AhDMI8WxbbwZHcwHFVajW4/koyB8Bi/30ZziPTNA850IzfRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JDPdh5/KZZhUE9C8eI1j3GemRKaQ4CISdV05oe41s8o=; b=VekdtT8cASyiOWcGaWrKP4yxSkyrmwOGmJ0gYwYoKPAFMwv2AMD+5ckOGGM0e2H2/aE1fG/9C5Nf6Z6xj4hUMiMqYwxEQxmnBSbZKRHOGaD0nqsihUqm0uFuWSLCNhY7gYiryO6Xh/Xy8/n3h/+U3RcpnlNh6Gaob7WBeVS7NfQBovOKMLmMk8aj/+nvnNpQ6X1MX0DboZ8pynxw36ksXKZVIgofXp9RBUPfLdED0JuroJg9He+tazo/Y6z9w0wGMrCCDH+N3m+ynpgLaepLEtf0lOjhJR82sNKikC3YxCBNR0gg4lftzaz5tKe8C0FCKUEwVYUMHmpOMNpVwm5XQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JDPdh5/KZZhUE9C8eI1j3GemRKaQ4CISdV05oe41s8o=; b=hY0ZR+8Fk+B5Sr8MdKUA366rtFcfttxyHKyNcLcBx0PNWJIdlqbrNJ2VOz4pjeNwHss2ZkH1IOdAeDAK1ggigls4+nsrpvRFVAdczeF0DS7lifkEtaTSFdYiXUIqRRW1G8g0bVnoopjz8a0gDtOlmwpcXbSVruZkG0GvQ9efH2w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SA3PR01MB8473.prod.exchangelabs.com (2603:10b6:806:397::12) by BL3PR01MB6881.prod.exchangelabs.com (2603:10b6:208:354::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.18; Thu, 14 Aug 2025 16:53:13 +0000 Received: from SA3PR01MB8473.prod.exchangelabs.com ([fe80::46d7:1d3a:dc9c:69c3]) by SA3PR01MB8473.prod.exchangelabs.com ([fe80::46d7:1d3a:dc9c:69c3%6]) with mapi id 15.20.9031.014; Thu, 14 Aug 2025 16:53:12 +0000 From: Daniel Ferguson Date: Thu, 14 Aug 2025 09:52:55 -0700 Subject: [PATCH v6 4/5] efi/cper: align ARM CPER type with UEFI 2.9A/2.10 specs Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-mauro_v3-v6-16-rev2-v6-4-e5538d534aa0@os.amperecomputing.com> References: <20250814-mauro_v3-v6-16-rev2-v6-0-e5538d534aa0@os.amperecomputing.com> In-Reply-To: <20250814-mauro_v3-v6-16-rev2-v6-0-e5538d534aa0@os.amperecomputing.com> To: Ard Biesheuvel Cc: Jonathan Corbet , "Rafael J. Wysocki" , Len Brown , James Morse , Tony Luck , Borislav Petkov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, linux-edac@vger.kernel.org, Mauro Carvalho Chehab , Jonathan Cameron X-Mailer: b4 0.14.2 X-ClientProxiedBy: CH2PR02CA0030.namprd02.prod.outlook.com (2603:10b6:610:4e::40) To SA3PR01MB8473.prod.exchangelabs.com (2603:10b6:806:397::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA3PR01MB8473:EE_|BL3PR01MB6881:EE_ X-MS-Office365-Filtering-Correlation-Id: abcace19-59c4-4478-205d-08dddb530e57 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|366016|1800799024|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YVJBUkVRd0JndngzMitDTThUU0VybnJmekYzVWZLTWgrMURQUTFRRDZDeHJU?= =?utf-8?B?Y0cvQjlHRGQvTnE1U2QvNzJEZHVHdlBHM1VIWHc5ZEMrdGlvd1prMUEvV1U1?= =?utf-8?B?OVc0eEl4TnVaQktCQmFvbHhvQ2ZTa3pHMVA5SEFzWFMvdURLT0lyb1dSbjYz?= =?utf-8?B?L1UwOHFtK1B3d2pHQ3FHakh5TGxLZmMvZktpcCt3QXdhdXU2ZmI1RENKR3hW?= =?utf-8?B?ZDcrSHZmY0VTR1dJU2U5S01yY25SZ09uV3FnbHVwQUtkTFdlYkNIRFNBZEZH?= =?utf-8?B?Q2NkNkNXVkF1TklqckdCWXRPc1lOeis1bko3STZaMk5ac1RxRTFBejVZc0JR?= =?utf-8?B?d0ZnKzU4OWxuSkZFNS9kQU02dzNJcjhYT3N2UCtyeUdWcVl5Z0RuNUpxUVdR?= =?utf-8?B?MmN5Wnh3NGp0bDlYMUU0SzdBR1NGUmk0VHRBYmpycXhFcCtaYlU4c1lnT3Ix?= =?utf-8?B?QWZERWh5bGJKM2RsaS9HNFNxUWptbUh5TUNFZzAzRlBqbTdBSnNHRzVCZHBM?= =?utf-8?B?TkljcXpWcFJWcVFnSGFWRE1CdzlUVml0TXI2NDNLSmtGZDZqazlHdnVIdjY1?= =?utf-8?B?U2N6OFpDcnIxcWptVVFKbUJlQmd6akZ5RE9tcHNSdFlwSDMwa2NDSE9hb0p3?= =?utf-8?B?bVErMXRxbVorQTc4TUxUWHIvMkNlSUlpeW8xeWU1UTRoM1FoMm9JOGhkTmk2?= =?utf-8?B?MFZOdVQrd3VsdTB3eDBmSVR5Nm45UURIb1BIbFVjNnhLd09raVBSQ1Y2QklQ?= =?utf-8?B?YzVOWkZqazFPWG5PV2Z4ZStENW11c0ZXS2Zvb0JCYWJPN1BJVWp3RmxWTnl2?= =?utf-8?B?d1Y3clFxVUpsbzN6NWRpTkV4eThjY1lEMTZWb0VjZXNkaElEUlFHZEl4TjZT?= =?utf-8?B?cXNIK0NTbXdzUW5XN25GVEhRbWRYNTBERndjblR6cmk4ckM5RjVMeTRhSWdB?= =?utf-8?B?cFdsMW1xcTkrRnVFVitmVk1rNmxKdWdCWklpUXgxYXlONjFrZWVRYVo0M1Mx?= =?utf-8?B?NUY0dFRvbnJUakcxS2pqZGd4UEtzd0JKbGt5OWo1d0VpaUp4Q1pwMUpHcWlu?= =?utf-8?B?Z2JLUXlQNlZSS012R1JjNHl2WGtnQ0Z1aFgzRTRNVjFYMzdiejh6dWJpOFJt?= =?utf-8?B?b2J2TWNsVTBXdGFzZEZJL1JacGZibVhZdmNaRjRXK0FFeElqd05Wd2NqSWFG?= =?utf-8?B?a3VRNktLV05ZUk9MZWt6V1FVY3daNit6YW5HcHVDd1Jnb2xvYVVnRmQ4NFpS?= =?utf-8?B?cFNIQXIvSDJTU1NGSkc5dXAwM3lTZ2hiNGdoclc1WXFCZklVQ0xKNnlZdHVB?= =?utf-8?B?bE84QUFDMklpVVBIdklyeldETXBGd3RnRFVLSnJhbXo5WU5Qa25RS3FhcUtn?= =?utf-8?B?QkpKMWd5Tkc1dnNsbS84SXBUYmM4YVV5dmY0aFpVOVF3a2VSRk14V3hSUmJi?= =?utf-8?B?M2QyeEo1K1RRZ2FnL2FQUEJtS0tZUDkwKzU3K1BvWnRxVHQzR1M3NWkyUVN6?= =?utf-8?B?WkR6R3F0d2tVb1JmazFwMjhuYzhob0FlZWVlN2RLU0NyUjdPdk5iWmNNWk9I?= =?utf-8?B?RTFDZSs4WjVhMlowVS8xRlkwMVdaN2gyV3ozRjVpajF4aUc5ZFJZaHFFTWI1?= =?utf-8?B?SU5BVWw5RnNYUDBGSnlVVkZOb2xHYms2NDBFd3VpaGhIT2VSbXJQTGZodnk0?= =?utf-8?B?UGRKYjFzS0JzakhjY3ZUNFRGTDBzSEFKTXE2MEFPVFF0MEptVi9uWlZHQ2JF?= =?utf-8?B?enI3bEVmd1RPNllZS0Jsem00TkhTZk1VaXF6NDFpdG4wQ0FwL3JnaHAzWmRZ?= =?utf-8?B?WFlWM2F4RzBwQWhTamhBSlFXRjBJaStZeTZqUmZScDc2dUs0S1lmYXVWWVU1?= =?utf-8?B?cUJqbGRXMFNOeFBueWV4OXdMUFg3NkhFcWZ5Rmc2c3lLMkk4WWlEWC9kQmlw?= =?utf-8?Q?UVBuSwZHJDE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA3PR01MB8473.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(7053199007)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0JwbU8ySHpzNW1HM0VwRXNKLzZvc2RhblQrdU1ra0diY29VQldBZzh0Mi9z?= =?utf-8?B?STVPdE9wWEVqZGcvdGo2R3pGWHhSeDZuYWpGam1EbXFJVnozYk9naG5qeWtM?= =?utf-8?B?cHBBYll0aFZsMGR3R2h6N2c4ZkFJV29PVXlSNFpMN1NoMCtqTVl2Y1pjdzhO?= =?utf-8?B?ZFZnNkNHUEFFMFovYVIrMTZpK3B6UTA2a3BoL1AvT0wvQ2lobTJ5a2RTeUVs?= =?utf-8?B?OG5GSUovcmp0SGx6bHhCazMvRDBzQ2tiYXdMbjM3R1hkV3JtQk5MQUhwVWRB?= =?utf-8?B?S1h5R1FkcTlBVHBlZDBsbEtLbzRNT3FQcTdFNWhTMFdDMzE4Sm1TMjJQMThG?= =?utf-8?B?VGp4Mnk0eGtDUy9HZ250WmtZcWNnNWdERm1TUlc3R2lTbDFQR2NJeUFIQUpt?= =?utf-8?B?bHNWaWU0OFZQbXRZcmZneldiSGJCcGR6dTExRUN6UmdkcWFpYWRkUVV0NmND?= =?utf-8?B?NUxGMkhUNGdiL2k4WWFRMzQrK2YzQXk1dUw4QlpjcjNBempLWTRJNVJPcENq?= =?utf-8?B?aGZjLzI1V1dDaVB1b2tVekJGQzFiNnNtMVR5VHJNOUNzWW02UXh1TFFlTm5N?= =?utf-8?B?S2NPYnJBTVhjQUM3UU1SNmdTRnNDL1ZyRjhUY1k4MkhZUjVtOXVJaHJVQzVi?= =?utf-8?B?V3VNZG9seHNyRllZK3BpUlE1L2RObWZBYkUrTUtBYU9iV29ncjF1aEZNaTdJ?= =?utf-8?B?SVBPZ3NtdmxqeDhiYVU4QnBJSGJpTFNaNVBoWU55c3BwRER4QWNwNkx1aGtk?= =?utf-8?B?ZE5WM3NCaFR1bmNPZHpXQWRwdTVBYUdsWmFNRkVuRUxkRDRrWnp4Z1l0dWhR?= =?utf-8?B?dXNGWnpuejhQd2FsVVQ2b3IzODNCQ2F2QzZBdWN5aVpTekY5RlpzZWhRV3ox?= =?utf-8?B?R3diYnJaV3lwWmtIblE3MHM5S2tVSVNFYTZxRUh2elllUktkSUhLdGcvbUFZ?= =?utf-8?B?ZkRQSWdrcmpVNVFTeFNXdmtlcUIzVmd1b2VJUEhzcUVVbFBqMXN3RUNhZDBw?= =?utf-8?B?TnBZWnBrVlMvYyt2c1Rpd0J5MWtWOTBRejdxb3VQdkMveDVXazlHU05BN1Ix?= =?utf-8?B?eDVQNitzRHJCUXc2bk5kUXZpS0RXdndQck42VXg3OXprYkJPRHlMQ25zNzNU?= =?utf-8?B?VXdyc0lxYUJhRU85c1Z0MW12d2NXOU45SUxVM2NSb1BtVWMzbUtIVldJZmpI?= =?utf-8?B?S3NYYVBCa1A0eit5OE5FYXkvbExZdTdPeStwcmNWdEJmL1VJeEpGNzNXZjNN?= =?utf-8?B?VTJaNUFHY3lIRk9WWldtazhHSEVEeGg2cFMzbklNY2lIT2dlUk94WEk4Y29t?= =?utf-8?B?R3RhemhRRUg2bm55YU5GVWJxeW56eWNNOXBPcVNJcW1DOHJJTkg3V1c4cUNI?= =?utf-8?B?VUFFRWFkZVVtNWRYVnVNN04vRWcvL3M2RjdLc3IxVEFwQjU3VUtTbXNpQ09J?= =?utf-8?B?VGhtVlhvcU03WStHN2ozaTNCZjZJcUZJVXpHdHF6dmJQL3FseUtmNFpya2Ni?= =?utf-8?B?TXVxYkkwZkZ5VzJlRjJlajB0eExnamwwSXRxeFIyQ2VsdTQwd1FWTjl2eHRy?= =?utf-8?B?bytlZi9sYTR6MWlLOHIrazQ4d0xNd0FJV0ZVeE02ZmVMUWNVNElZMnZCV3Z2?= =?utf-8?B?ZytNVXZJeXlKS3JKcnFQVUROUzFScWNUbVFRU3hibWY2Q2hzSUtzZldNYXI5?= =?utf-8?B?eHlzUlpQVC9ZUWhpeitkTE1TM2luWjUrRldIRzQ1SlVVemNYRS82OEVHUXJL?= =?utf-8?B?MmlHblVic3RSQUlMeDJyaUwvMGRWaVFXQm5vaFZrUUtjZTUzSU5CbG1UN25o?= =?utf-8?B?elZPb0hNTUtkK2Nyc09YUy8wVkFJKzYxazh1bkphYkp6U3FUcEJmbTFzakk5?= =?utf-8?B?VTdIUURwMGdyWE9wWUVrekxYamhnTlJ1TXhYdHdUOWpaeUZ6QVRtTitkMWQr?= =?utf-8?B?cTE3OHptOExkN3Z5UUxDdFZmMjdTN0pOV1l6L3BydnV3NG91ZGVpbTdSRkhs?= =?utf-8?B?Qzd3VWg2TlJBMWtUNEpsOWVPRVhmbkZFRUZuUHlBM2RjTFdXTm5iQzVOY3hI?= =?utf-8?B?YVdEdk5vQU1JVEdTb0FJbzJjcUJxQWFIb1V2RTRRUGE0bC9zYisrQUQ1eU93?= =?utf-8?B?RThhUnU2VGxZek9QcUpzNXJjYWhZLy85aWk4R0g1ZXpmSEtybjc3Um9PSWVI?= =?utf-8?Q?OV6s3ia7Ep4DpS+lDVB0lH8=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: abcace19-59c4-4478-205d-08dddb530e57 X-MS-Exchange-CrossTenant-AuthSource: SA3PR01MB8473.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2025 16:53:12.7194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fpy25IkkCpAGXtZzywApmp3TXMFcVxBXugR9kjefRRKkn6UZ3StWQBTjCY61M099UpnA6ukFVzzoqX+Z+tdQqH9hUqCtoOGJaxVBg+7Q1fRC8GAGaRpaU0ZZz7t+/UiT X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR01MB6881 From: Mauro Carvalho Chehab Up to UEFI spec 2.9, the type byte of CPER struct for ARM processor was defined simply as: Type at byte offset 4: - Cache error - TLB Error - Bus Error - Micro-architectural Error All other values are reserved Yet, there was no information about how this would be encoded. Spec 2.9A errata corrected it by defining: - Bit 1 - Cache Error - Bit 2 - TLB Error - Bit 3 - Bus Error - Bit 4 - Micro-architectural Error All other values are reserved That actually aligns with the values already defined on older versions at N.2.4.1. Generic Processor Error Section. Spec 2.10 also preserve the same encoding as 2.9A. Adjust CPER and GHES handling code for both generic and ARM processors to properly handle UEFI 2.9A and 2.10 encoding. Link: https://uefi.org/specs/UEFI/2.10/Apx_N_Common_Platform_Error_Record.h= tml#arm-processor-error-information Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron Acked-by: Borislav Petkov (AMD) --- drivers/acpi/apei/ghes.c | 16 ++++++++----- drivers/firmware/efi/cper-arm.c | 50 ++++++++++++++++++++-----------------= ---- include/linux/cper.h | 10 ++++----- 3 files changed, 39 insertions(+), 37 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index 99e25553fc1320b2306efb751e12f2377c86878a..79a128cb04c351c1d01ee749904= ee844963d0f10 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include @@ -531,6 +532,7 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest_g= eneric_data *gdata, { struct cper_sec_proc_arm *err =3D acpi_hest_get_payload(gdata); int flags =3D sync ? MF_ACTION_REQUIRED : 0; + char error_type[120]; bool queued =3D false; int sec_sev, i; char *p; @@ -543,9 +545,8 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest_g= eneric_data *gdata, p =3D (char *)(err + 1); for (i =3D 0; i < err->err_info_num; i++) { struct cper_arm_err_info *err_info =3D (struct cper_arm_err_info *)p; - bool is_cache =3D (err_info->type =3D=3D CPER_ARM_CACHE_ERROR); + bool is_cache =3D err_info->type & CPER_ARM_CACHE_ERROR; bool has_pa =3D (err_info->validation_bits & CPER_ARM_INFO_VALID_PHYSICA= L_ADDR); - const char *error_type =3D "unknown error"; =20 /* * The field (err_info->error_info & BIT(26)) is fixed to set to @@ -559,12 +560,15 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest= _generic_data *gdata, continue; } =20 - if (err_info->type < ARRAY_SIZE(cper_proc_error_type_strs)) - error_type =3D cper_proc_error_type_strs[err_info->type]; + cper_bits_to_str(error_type, sizeof(error_type), + FIELD_GET(CPER_ARM_ERR_TYPE_MASK, err_info->type), + cper_proc_error_type_strs, + ARRAY_SIZE(cper_proc_error_type_strs)); =20 pr_warn_ratelimited(FW_WARN GHES_PFX - "Unhandled processor error type: %s\n", - error_type); + "Unhandled processor error type 0x%02x: %s%s\n", + err_info->type, error_type, + (err_info->type & ~CPER_ARM_ERR_TYPE_MASK) ? " with reserved bit(s= )" : ""); p +=3D err_info->length; } =20 diff --git a/drivers/firmware/efi/cper-arm.c b/drivers/firmware/efi/cper-ar= m.c index 6ff781e47147c05c784ca5aa57149d1435cb2467..76542a53e20275cf0f059e9ce40= 9fd898de16d4d 100644 --- a/drivers/firmware/efi/cper-arm.c +++ b/drivers/firmware/efi/cper-arm.c @@ -93,15 +93,11 @@ static void cper_print_arm_err_info(const char *pfx, u3= 2 type, bool proc_context_corrupt, corrected, precise_pc, restartable_pc; bool time_out, access_mode; =20 - /* If the type is unknown, bail. */ - if (type > CPER_ARM_MAX_TYPE) - return; - /* * Vendor type errors have error information values that are vendor * specific. */ - if (type =3D=3D CPER_ARM_VENDOR_ERROR) + if (type & CPER_ARM_VENDOR_ERROR) return; =20 if (error_info & CPER_ARM_ERR_VALID_TRANSACTION_TYPE) { @@ -116,43 +112,38 @@ static void cper_print_arm_err_info(const char *pfx, = u32 type, if (error_info & CPER_ARM_ERR_VALID_OPERATION_TYPE) { op_type =3D ((error_info >> CPER_ARM_ERR_OPERATION_SHIFT) & CPER_ARM_ERR_OPERATION_MASK); - switch (type) { - case CPER_ARM_CACHE_ERROR: + if (type & CPER_ARM_CACHE_ERROR) { if (op_type < ARRAY_SIZE(arm_cache_err_op_strs)) { - printk("%soperation type: %s\n", pfx, + printk("%scache error, operation type: %s\n", pfx, arm_cache_err_op_strs[op_type]); } - break; - case CPER_ARM_TLB_ERROR: + } + if (type & CPER_ARM_TLB_ERROR) { if (op_type < ARRAY_SIZE(arm_tlb_err_op_strs)) { - printk("%soperation type: %s\n", pfx, + printk("%sTLB error, operation type: %s\n", pfx, arm_tlb_err_op_strs[op_type]); } - break; - case CPER_ARM_BUS_ERROR: + } + if (type & CPER_ARM_BUS_ERROR) { if (op_type < ARRAY_SIZE(arm_bus_err_op_strs)) { - printk("%soperation type: %s\n", pfx, + printk("%sbus error, operation type: %s\n", pfx, arm_bus_err_op_strs[op_type]); } - break; } } =20 if (error_info & CPER_ARM_ERR_VALID_LEVEL) { level =3D ((error_info >> CPER_ARM_ERR_LEVEL_SHIFT) & CPER_ARM_ERR_LEVEL_MASK); - switch (type) { - case CPER_ARM_CACHE_ERROR: + if (type & CPER_ARM_CACHE_ERROR) printk("%scache level: %d\n", pfx, level); - break; - case CPER_ARM_TLB_ERROR: + + if (type & CPER_ARM_TLB_ERROR) printk("%sTLB level: %d\n", pfx, level); - break; - case CPER_ARM_BUS_ERROR: + + if (type & CPER_ARM_BUS_ERROR) printk("%saffinity level at which the bus error occurred: %d\n", pfx, level); - break; - } } =20 if (error_info & CPER_ARM_ERR_VALID_PROC_CONTEXT_CORRUPT) { @@ -241,6 +232,7 @@ void cper_print_proc_arm(const char *pfx, struct cper_arm_err_info *err_info; struct cper_arm_ctx_info *ctx_info; char newpfx[64], infopfx[ARRAY_SIZE(newpfx) + 1]; + char error_type[120]; =20 printk("%sMIDR: 0x%016llx\n", pfx, proc->midr); =20 @@ -289,9 +281,15 @@ void cper_print_proc_arm(const char *pfx, newpfx); } =20 - printk("%serror_type: %d, %s\n", newpfx, err_info->type, - err_info->type < ARRAY_SIZE(cper_proc_error_type_strs) ? - cper_proc_error_type_strs[err_info->type] : "unknown"); + cper_bits_to_str(error_type, sizeof(error_type), + FIELD_GET(CPER_ARM_ERR_TYPE_MASK, err_info->type), + cper_proc_error_type_strs, + ARRAY_SIZE(cper_proc_error_type_strs)); + + printk("%serror_type: 0x%02x: %s%s\n", newpfx, err_info->type, + error_type, + (err_info->type & ~CPER_ARM_ERR_TYPE_MASK) ? " with reserved bit(= s)" : ""); + if (err_info->validation_bits & CPER_ARM_INFO_VALID_ERR_INFO) { printk("%serror_info: 0x%016llx\n", newpfx, err_info->error_info); diff --git a/include/linux/cper.h b/include/linux/cper.h index 58f40477c824e61c7f798978947bf1f441ce45ad..5b1236d8c65bb7d285a327c4571= 15a18fc9d7953 100644 --- a/include/linux/cper.h +++ b/include/linux/cper.h @@ -297,11 +297,11 @@ enum { #define CPER_ARM_INFO_FLAGS_PROPAGATED BIT(2) #define CPER_ARM_INFO_FLAGS_OVERFLOW BIT(3) =20 -#define CPER_ARM_CACHE_ERROR 0 -#define CPER_ARM_TLB_ERROR 1 -#define CPER_ARM_BUS_ERROR 2 -#define CPER_ARM_VENDOR_ERROR 3 -#define CPER_ARM_MAX_TYPE CPER_ARM_VENDOR_ERROR +#define CPER_ARM_ERR_TYPE_MASK GENMASK(4,1) +#define CPER_ARM_CACHE_ERROR BIT(1) +#define CPER_ARM_TLB_ERROR BIT(2) +#define CPER_ARM_BUS_ERROR BIT(3) +#define CPER_ARM_VENDOR_ERROR BIT(4) =20 #define CPER_ARM_ERR_VALID_TRANSACTION_TYPE BIT(0) #define CPER_ARM_ERR_VALID_OPERATION_TYPE BIT(1) --=20 2.50.0 From nobody Sat Oct 4 15:57:30 2025 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2136.outbound.protection.outlook.com [40.107.94.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F3ED3002BC; Thu, 14 Aug 2025 16:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.136 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755190399; cv=fail; b=DlNUuzrnq91DqK8G98BSg/grOJrlrctiIxWP8QEFs883VQqtKQWqPlUauU0tkuhTdKWeoM9+8bnxIi1xPX0hbiEJjmZQooCZK2hCq3A/oausOKXQm54r1wb4C3/yUYsrBlvMA0GiXtajwbHdKYArTgcaIpkFzHL5hIKPV5XWD4w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755190399; c=relaxed/simple; bh=VWmmZySvsC0NkQY8VVXYlfvIiROA6vS4HSNzWwgHstY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=HRnye2Kiy6z+QBtldwC2vSi9IiwyMDBrSgwVo9onV0QEplCXC7m+AeLaurW+FtiYufv9lae1J3KIJ2jovaG7cWskU+/6cDeZi+Dp4kmzmayQ4ZF/W1DI+7M7gDOG4pgrRDs/HzhfH4xOjYhvwOPFDAabE5D5BEZZ8H1QNl7gL04= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=QdbPUgHX; arc=fail smtp.client-ip=40.107.94.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="QdbPUgHX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vnUQG1AvMIbVZIEt3HLDUoMnyv7dJKypwKK2io8B/YCu1Zbfoah3JVW6ANozj99+wN2EAUHDJha6AMOEfYDX3XBbdVJAA2lwVOPg0t9F0CwBmuN7jJquOzwbEkH159kj6qY1yfFoa6Ja9uggvnMdisG+ok8pHzW1VJgD+jNGplKw8wg0aGeBXikcu2AIvTqik78eLTuTwe1mh1ft2n0kxqi3YGWMX/2QQG/CWfwqlPWykWU/I+JbrrEDGBNf7ruC7V+VW0DT/BJoHerDpK2azgvNfRgH3VhVP/yNXHEfcaw356efWI0kRIthFeusa+Ujs0WoFovztTDh5MwCFlA48A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ONZ6VMxeM/i9fNQr6Ks14ia8iihRqfgfE9CGNxrxYY=; b=juhRIJ9rutkZ7kINAdJpIS3MGEBWK5G+uMebHkynpOp0aZKdkQ6+THsqzk/KPpkczsEFyidu0+jmiSDTNllqRpp/NG+MKex3H3blcS08UP7iOQLFdcsDfO7onu627wugFfiVx9TNf543Tqf0QBPc1IdBhQq4vCuXF3kVWFcG8TzJrCrjgWwCwghkNA0mCXJR9vZ7xr9SV30k5BA+6AmdLvs6QjDO48YCZO654jbi/VztMSI9iRhhQLjfM8NSrsk4Uj3nCnozRJLkte0rta+2ALn+gTx9r+zk+W8cTu5M8roAA0iqBWlak8ce93RmSuZNpXB6dzLfmRbCFTf9mKJWAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ONZ6VMxeM/i9fNQr6Ks14ia8iihRqfgfE9CGNxrxYY=; b=QdbPUgHXUPBojQppI/N2moFV0sG5L9e6wYTl7JIqE1mVwyd9Wo4XoqHijehY/GPKfNogbKwWFc9VUDOk3nKNfnNDcVbNWnI2Ow6Szxaf2IIes9QmnNUu41K1x3XOndOB4q1CPdqjTgQACIXVNHmtxgdDRZlK8n6u2HIyJuLv1UM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SA3PR01MB8473.prod.exchangelabs.com (2603:10b6:806:397::12) by BL3PR01MB6881.prod.exchangelabs.com (2603:10b6:208:354::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.18; Thu, 14 Aug 2025 16:53:15 +0000 Received: from SA3PR01MB8473.prod.exchangelabs.com ([fe80::46d7:1d3a:dc9c:69c3]) by SA3PR01MB8473.prod.exchangelabs.com ([fe80::46d7:1d3a:dc9c:69c3%6]) with mapi id 15.20.9031.014; Thu, 14 Aug 2025 16:53:15 +0000 From: Daniel Ferguson Date: Thu, 14 Aug 2025 09:52:56 -0700 Subject: [PATCH v6 5/5] docs: efi: add CPER functions to driver-api Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-mauro_v3-v6-16-rev2-v6-5-e5538d534aa0@os.amperecomputing.com> References: <20250814-mauro_v3-v6-16-rev2-v6-0-e5538d534aa0@os.amperecomputing.com> In-Reply-To: <20250814-mauro_v3-v6-16-rev2-v6-0-e5538d534aa0@os.amperecomputing.com> To: Ard Biesheuvel Cc: Jonathan Corbet , "Rafael J. Wysocki" , Len Brown , James Morse , Tony Luck , Borislav Petkov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, linux-edac@vger.kernel.org, Mauro Carvalho Chehab , Jonathan Cameron X-Mailer: b4 0.14.2 X-ClientProxiedBy: CH0PR07CA0006.namprd07.prod.outlook.com (2603:10b6:610:32::11) To SA3PR01MB8473.prod.exchangelabs.com (2603:10b6:806:397::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA3PR01MB8473:EE_|BL3PR01MB6881:EE_ X-MS-Office365-Filtering-Correlation-Id: 69718704-0e44-4da5-88e2-08dddb531030 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|366016|1800799024|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QUdRdjRnU0ZLbVlZQTBFbnEzaFR2RzBGdlVPNGNET3ozOUROKzl3dEVtODNu?= =?utf-8?B?Q3gyVmxweGp3bFpsZzZNalBvMVdqeFRadHhaZW5xTmRNc0xQVUphakt5UDhW?= =?utf-8?B?QVQ0WjE2VDkwRVNoZ0pEdDJubzhoMlBRcmZMZzVlUDBqY0ZVRFJOd21FL1Ev?= =?utf-8?B?VHh4aDYvVGNPYUFmZXJ1Nk5xYlFWN1BoWnd1eDZoTExoellFb1BSZWNtRW0w?= =?utf-8?B?TzBJOWx5Yi9Fd3NsMHdsNXJ3RGpsRGpzdElPQi9XVDFrYTFNdWxvUVdDcVdw?= =?utf-8?B?Y3ZkNTVkQThYUzRuUC9SQUI4ZlFCOFF6TUpiZnpxS2VXVjZPUW9TZndhaHRm?= =?utf-8?B?dW1oMi9RQWM3aDZIVlZDZmZNeW8zdWhDSU9PM0N5ckVPUGt4Sk5ycTRNUjRL?= =?utf-8?B?N05EaHJIZThhcXl0WjBCd0Q0cUR0cmxKaWMvVy9sSzRwejFpcjFNUHQ3V08y?= =?utf-8?B?QWY5TTNQTjNKYVFMNHkrUDlMSVN5Ykw1Tlo3SDgzb0ZtUDhpcnBBc0x3eC9T?= =?utf-8?B?elhQL21vRkwyYTVqdXVDNlNURm5ZaTdOL1pnd1RUR29wc05PMUhJVGZzTmtX?= =?utf-8?B?T3FpTlBNWVdpZHNjVnBuTTBqcnlYS3lDWnZqeENUa3JEamNETFo3TXEzQjB0?= =?utf-8?B?MCtKL011OThuMEl1YSt2dHd5RXFsazhKd0dscEJRV1FQaWhiaHB3Y0swTWM0?= =?utf-8?B?Uml6UE1lU2tVN1lNVHFCa3V0VFlwYzQ0STFUTnc2MHFjS09DSDlhY05iWFJM?= =?utf-8?B?Y0RqazNKVHhPbE5GeDBVelNuVm1lOVMreEMyZ2F6bkR4cytjcHRhbVVHNGNk?= =?utf-8?B?dXJLMVAvNUVlNTdMQi9HMXVwMVk2R0dtdmZNWjdnTHVLb1B0TXhseDVZbU5z?= =?utf-8?B?YlI1NUNvaElmWVFSK1JQUDlnMVM2QzdJb2ZYZ0lxdG5PTDExMkNQWmZsQldQ?= =?utf-8?B?TzVuc29JaDQwOHJHYXorbUhpeWlxU1JueE1YVzkxa3pUbUdXenF0VHk1b2hO?= =?utf-8?B?dko3bThYRWtxZVB2TzFUUVZVNU5KTXBUZXg0NlFFVEp4QUlKQ0QxZkVqL0Ru?= =?utf-8?B?MzJrMnRnZ0pETUN5UWxtNTZVOUdhTzJsbXc3a21PdC9IdUU2UUNTYnczL3Nl?= =?utf-8?B?TmtHbWRGeFFCNER2OHlmT0M1cjdHbWZxS3p3Q0hTNnBtMFhGdkxKRW1lL1A1?= =?utf-8?B?LzZXWTJhUThCbVFuaUVyZy9ESFNXaUpKNjdnaVg0N0syVnAxQXRxOVpEOW9T?= =?utf-8?B?YzE1bXp4d1I3aTcrc3dtb2ROUEJYVzd5cXBMUTV5YW5ZQ1Qwc05FRGtqUzdU?= =?utf-8?B?LzJIcUgrNTQ0ZjhMMDJsSHk5ZVUzWUtmdXoyb2N2SHhBL3ZKRFFoYlVwdmtk?= =?utf-8?B?MGNmcjNVYmwyVWRPUWZBckV1S0hDZmhmT3p0SGlpWktTbTIzc3RIOXlCblhD?= =?utf-8?B?Mm5JWEFJbXc2YW1zUGxSTmdUZkczWjE4NDdDT2lVZDlRZWVJRDVLTHowUEZp?= =?utf-8?B?NzhEcWZzbHpuWDVzQ2tudVFxY2pvLzhyQW1WMnJtMmdJcjdXOWdEZGEyTW10?= =?utf-8?B?clpmQ0Y3SUIvdy9LM1cvekg2Z3RNNzFrYmpkY1FXcTNMZm9QR3lya1ZTM1hP?= =?utf-8?B?c0FXSmdCUU9MczgvZkVYcjFyWTZBdFFLTzRQRE5RbDIybldmSEl3S3pka2I5?= =?utf-8?B?VXVDSkpwb1ZHNldnenNxWTAwMTQvRjcrUDQxUjROU1Nwb2lzM1Ztemx5OFNE?= =?utf-8?B?RzJxRHJLOUE5aCs4VTdkdm1YTTRuSDlneVh6QlMzcjF5TzVuUFRGK1NwODBY?= =?utf-8?B?eFRhV3pMbHd5c0dlazU1eXliY0VYbkFPWHAxUkdXS2syR0VFUmZHTHE2Q1lu?= =?utf-8?B?ZjBvOUN4VmFxRWNGLy9RSEVhZU5zKzY0MFFqMDV3b3cyS0hJQlBoc0E2YmFt?= =?utf-8?B?RURDMVNWWXJkQVdMQW9saGowWlA5RjIxTTBKZXE4bnozN1F4V0RhRlErNFhG?= =?utf-8?B?WUFvMmV2SzFRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA3PR01MB8473.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(7053199007)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWdNVmhETTJHcy9iNnlmRUVNSW5sazRQcXhWOEF6UWg1UGZmaGY5NVZHT0tl?= =?utf-8?B?MWRPY0lWZTdpVzdwbnl4Q29zUmg0M201Qnh4SUt1TFYzQ3NxUHdCR0VjaW9K?= =?utf-8?B?MXpUaTdJT3RmWGdVdHpjYk0raW83ZXoxZTZSMFEyNTdOdUNPc0xkbHg2ZWw3?= =?utf-8?B?RnRhSi9sbzJCS2haclVDMVo2R2lBNGZpb2tRNFNpclpnWWlVYS9qL0NFT1BJ?= =?utf-8?B?bW9Vam43SjUyblpnTDBDbFpZaHMzanM0UVJTeW1zZk9jTFJET3VUWTc3eGE3?= =?utf-8?B?cW9OaGd0dFRIMi8wdlB3V0Nyc2VqRDUrYVFGVVc2djFyVzFxRUNOV016L0Vz?= =?utf-8?B?RHRuRXJya2pMZFNudktPOHJraXV2Z0dpUmFvU2t3T2FhTzMwcGQxN3RYNGdi?= =?utf-8?B?cW9NRUQ3WHlTMVluZDBoQ001cFIranRIVDcrK1dwQnpWT2NrTkEwVmZGdDZE?= =?utf-8?B?K2JXWm1PdzBkb3J3SDhadlBLUmh3b0krQUJxTnpoU1FGcGVPQmkrcTJ5bEdk?= =?utf-8?B?ZCt6QkQ2eUVlekJPdjV5ZXJ4d2t2TnhPeE1ONXFRaC9zekplTHlqbVR0dEhq?= =?utf-8?B?QVdnZEVXS1BWTm9Ec3hRdDBZc3JkU0R1czRmVVh2QUhjanJCRk8xRVlrZ0k5?= =?utf-8?B?UlVlZm9EQWZDNitDVHJROUM2eWE2THNCc3VnbVMvUFo5YTlXeEFwV1pTY3Z1?= =?utf-8?B?UEtXdERuVDUxWEFTa0JpdDcwLy9sU0NadUM2WjNkZUFCUmFmU0VaSHF6RVhL?= =?utf-8?B?NUdqbmx4VithdE9vSEtROTYrNktHRnNQNnJsS1BLRDdmbzRWRnBQWGVjMk5C?= =?utf-8?B?cmJYSzA3NUhKQUFKdnY1WUdnVVdBUlQ1Z2NpVlkwNVBNdHUydlovVzdMQ2tM?= =?utf-8?B?NVlzWVBBOXFYeUJwQW9udERHb2lSS3RLRTdqQVlNcmpDcmNRL0IxSktFSk9h?= =?utf-8?B?RlFpMVBWaHZsRENrbnlWSm42RW1EcmxtTmpYN0tOT2dJaGk0cGR1ZDJjWlpG?= =?utf-8?B?SENmM0hvQUtWeDJBeVZUcy9pSGtqUjlsa0xNQlVtWjdwakhxM09NY0x6STJw?= =?utf-8?B?WWpLYWpRWG5xaktPd2Fwb1lveGt1V3Vsb3ArZzJPRlJJN3JNbmRRTnh4c3hE?= =?utf-8?B?UENwcUxUOFVDSk1wN2tiMWZodmVUTER5a1c3UVAxNlJqRlRqWlhSdG1KRSs2?= =?utf-8?B?SmRDeEhGeTBIWkVSbWdIZ1MzelVsbmM3b2s0TDAyUi9EQmpsOFNTOU1uZ3BE?= =?utf-8?B?UkRMejlrVS9DWUFhM3BqTG9zSnVocW85Mm10azNxRkJJWDVvbW9McEpFYnpu?= =?utf-8?B?emVmQ3Q1UE1LMDRKL0JNS29vL0tIYlJHRUl3bFlGVjZCajF4TU1yZjNhbE51?= =?utf-8?B?UDh0QVNISmI0d3BqSFY1YnFFcVFXcUp1TWZYbno1dnNzdk9kdllBZVpKcFB5?= =?utf-8?B?TzFjZFZ0M3ZLSzQwL3p5UjE4MXhNYzQrZ01SSlQyS2UreFRIU0t0aTFBL21W?= =?utf-8?B?dkZnNWRNUkZBcCt3TzZKQ0E5cUJlcnJYdGtHTHZFblc5NWtSWFNMZ2I0cEtn?= =?utf-8?B?elg1cDM5ZWdXSHc4bytma2lKNDNUYW5Scm1DalpCRGlxOE90YVY5RHB6dm5C?= =?utf-8?B?VFdUeDRVM2REeWQ1TFZZc3ByZFdUTTc5K2poSlVKUExmY3E2dWpsNW91V0NN?= =?utf-8?B?VnBWOG1TeW5IK21iRWtMdVp0d2gxT2VPdHFqb0c1a2Vtc2pXanpRSUJJU2sy?= =?utf-8?B?N2pocWJ4N1ozQ3Q1blpYR0lSZDVkcm4yYU1ncFVEcHQxU3g2cStpcmNacllu?= =?utf-8?B?Rmk2SjRoUUFHTWMycWRYcHg3NUJNdnZpejIxenlsbVhhS1JGR3hZUXJvNVVL?= =?utf-8?B?RitUTWRXOW1jRlkzbi9PZ0xZck1QSFRsZUlDemVmbk1hbXNRcEdyNUtnell4?= =?utf-8?B?RmdhWXkyeGRrNmFpQ1B6ZS9aUDNTWGV1YWtCdDZ6TDdobDNxbFYweU44Yy9U?= =?utf-8?B?RjN5a0FUR2MwaUpmQmx2cm9Ec0dSVy9xcjdLT3pJK3RMSXlMc1lKblh2WHR6?= =?utf-8?B?ZFdLYVYwLzJuWHlkd1o3bDRoS1ZiTHRsYlorcjRlblpzTGxsc1EzSFp2OStj?= =?utf-8?B?bDRrcVZyTUFRclVtODZZYnpJd1BGRWt5WG8rZzlENmlLUDhHMzFKZkpxWE0y?= =?utf-8?Q?VRTR2A6TiAWBH3Ea5WJFp/w=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69718704-0e44-4da5-88e2-08dddb531030 X-MS-Exchange-CrossTenant-AuthSource: SA3PR01MB8473.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2025 16:53:15.8294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dY8ZLNlUjuOwY+IBbKaN2ey8oc/Tlg6LrM544lqKFs2A18tPuboKxEItqFPKM/fkkZan2a+uaY3sJlMAGuR0FdM04f2FN/2yQl8HWr6m5N4kc1i4hbEAuAqmED8gc5e4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR01MB6881 From: Mauro Carvalho Chehab There are two kernel-doc like descriptions at cper, which is used by other parts of cper and on ghes driver. They both have kernel-doc like descriptions. Change the tags for them to be actual kernel-doc tags and add them to the driver-api documentaion at the UEFI section. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron Acked-by: Borislav Petkov (AMD) --- Documentation/driver-api/firmware/efi/index.rst | 11 ++++++++--- drivers/firmware/efi/cper.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/Documentation/driver-api/firmware/efi/index.rst b/Documentatio= n/driver-api/firmware/efi/index.rst index 4fe8abba9fc6bf8ed53443e48e79285730871c32..5a6b6229592c9a9d1eb223966c5= 82e0969ee9514 100644 --- a/Documentation/driver-api/firmware/efi/index.rst +++ b/Documentation/driver-api/firmware/efi/index.rst @@ -1,11 +1,16 @@ .. SPDX-License-Identifier: GPL-2.0 =20 -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D -UEFI Support -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D +Unified Extensible Firmware Interface (UEFI) Support +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D =20 UEFI stub library functions =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D =20 .. kernel-doc:: drivers/firmware/efi/libstub/mem.c :internal: + +UEFI Common Platform Error Record (CPER) functions +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D + +.. kernel-doc:: drivers/firmware/efi/cper.c diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c index 79ba688a64f8da7af2dad097b9331c72afc73864..0232bd040f61c9b4521ae50ec4b= 6a1b0bfa5cc19 100644 --- a/drivers/firmware/efi/cper.c +++ b/drivers/firmware/efi/cper.c @@ -70,7 +70,7 @@ const char *cper_severity_str(unsigned int severity) } EXPORT_SYMBOL_GPL(cper_severity_str); =20 -/* +/** * cper_print_bits - print strings for set bits * @pfx: prefix for each line, including log level and prefix string * @bits: bit mask --=20 2.50.0