From nobody Sat Oct 4 17:47:47 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FFD62566D2 for ; Thu, 14 Aug 2025 16:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187628; cv=none; b=MyLu0RzOsAduMGf6Ls/1vHGOKzoDyhbIBCfvMC/kcpoZ19HMJnlVf3tRbeSrsP3L/905PpGtkcqbEit6XDJTLMgpA7jReZPcs103M/9sdEsnkfJbfyUCbtf3qxVyol0kCWaZPoI2oRjvQmMR/7jFGnGet88SunZ4HzZar5gi/hU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187628; c=relaxed/simple; bh=tGr7ZdC9lWhIzCCUsw+rFlJmgOHa5c1oy9NRasjlofM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hg4PL+GXRKATMtbe+78lxE7iUMHmTfSP9UA76QjWWdRtZ5OKb6aUTZoI+9T288oWeTkoD2mO4IBmWK2dTPI9it89AYsoofmJ6dnZMl5FPhrm7SZRBoYSD/9GxUh3PWN0rLhAR5NV6GgJzEt3UiGap3TxCzMbHVn+Wd9bVLqzsjs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Qpw4hO0d; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qpw4hO0d" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45a1b0cd668so5602375e9.3 for ; Thu, 14 Aug 2025 09:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187625; x=1755792425; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kIP40WisTeT4zrEy6wQwK47oVAaa0UgJRrDSFCcyNWg=; b=Qpw4hO0dtRi+GaLCNUcinFGipsBEL+i/BFhL4ouvTZeBy/fZfOYCvQ2LXd3+6CXxa1 X4BXls5DLFYyej9wdnEspJL5svTXa/N+SvA8rDaTrkKbNxozcnwgqzpQm+0huOu7wdYc Xt0N5GQ9XhwMm9fk7fHmsFsCE+QiY54o9y9So6k6ATPg4QcESDo5C9p37CbwOwHgowA3 WshOA4B8nMzBqLQXB3csqDJ0WmchHB0lRAp1VT1T9eKUXvN355UyF0iBYEMrzdd/IeS9 CaVC0ZqpeTZv1yWUGhUDpRG510PE4aMR4sTZ96h1f8lFGIJGtMC0WaeP8IkjfooyVTLb oeHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187625; x=1755792425; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kIP40WisTeT4zrEy6wQwK47oVAaa0UgJRrDSFCcyNWg=; b=Rr5qyO8TbeCCPktdF5zfBaUEqlqpgGdBNjSTnKgrnRg89WGZglskaAelditTnPf7KC lJ8ax0HyG99xlYbl9m4/dwub6vvTAPlLzXOMQscu7Xfc/x+DkDOMuKi76Eoq6YgB8KtX OhPZRhl/jTyTcdmp/D8ZqDQ/FD+m1i2mcRGHg6k2XthXp1P0kVtBYFW1cUEIRGWSBRFx STnoEM9dO4R8RhzIcWvLYFP7IalT/mWGkIl7Ol0g8NJCsF+0Z+Vi4uYjnVKk8i2NmCDK v2K7Fj0omjOCWy0HJ9oOMq8FfTmFC+tX7lYbY0e3PSJqmq/0nsiJCH+HyKdl3V+NKeOi ZLrg== X-Forwarded-Encrypted: i=1; AJvYcCUE29QihpDPDF9v6PfsBtEVSXqA+xqpsmbzRFLp04A0ws2oeaBFxrjYDE2mZXuMYhFnuBgAhfOGojlJeFo=@vger.kernel.org X-Gm-Message-State: AOJu0YxosV+bODNCDC1nJaYzh0fKPNp0kLWs2Wklq05wFlm6ERmREb6k PEjc4YaoqDGukJaRL3C9qPoxFxOdqPerf8I8Og95jaZ0Zf3Q3xtk6io8iEOUXsT2FR8= X-Gm-Gg: ASbGncuIFFAWCw1VnxdnUxqCUtTPJiOVogtZ+2aL4IWYZXvkfsdNbdEkdANQawrwPqL IcPcyrQa6suwwRENbZeLN2UHj78bYiHvo1ZFlO11RQ5dP32Ex+y9GXiSfuNT7HgynmJoA6erLUo Qe7RMou50RbGwMOT8RoFcK8Cs8PYa0hc6euLX96r5EU76fX1FIWLOzlhDIcaY1OoNsdLYV6qNiP ST9J1cqT9jTVxIJK6TrC5mZrTzLnOqi2R7kDqypwXyyH97rJpNdyPKYImHAzvFsNvEsW6+jaP9b xmgim+ctfATZ3YXsA+sVvR5gQ4UQiQns6NmYYW0RhjaUsacF//gcfrqZ8IvBWTgAD7ZnEr5coyk ypeXlymqGETH75V1HWdi4QkY1ZolIMyk= X-Google-Smtp-Source: AGHT+IFHK7GjTXRXCwZAe8/WmOBTSJ+eME2lZCidVPBvgVxCWAF3s0hzjYhWMNTNHWm2p91GYyv0Yw== X-Received: by 2002:a05:600c:4715:b0:459:ddad:a3a3 with SMTP id 5b1f17b1804b1-45a1b657876mr28054405e9.25.1755187624778; Thu, 14 Aug 2025 09:07:04 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:04 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:43 +0100 Subject: [PATCH 03/13] spi: spi-fsl-lpspi: Reset FIFO and disable module on transfer abort Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-3-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 From: Larisa Grigore In DMA mode fsl_lpspi_reset() is always called at the end, even when the transfer is aborted. When not using DMA, aborts skip the reset leaving the FIFO filled and the module enabled. Fix it by always calling fsl_lpspi_reset(). Fixes: a15dc3d657fa ("spi: lpspi: Fix CLK pin becomes low before one transf= er") Signed-off-by: Larisa Grigore Signed-off-by: James Clark Reviewed-by: Frank Li --- drivers/spi/spi-fsl-lpspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index c65eb6d31ee7..aab92ee7eb94 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -734,12 +734,10 @@ static int fsl_lpspi_pio_transfer(struct spi_controll= er *controller, fsl_lpspi_write_tx_fifo(fsl_lpspi); =20 ret =3D fsl_lpspi_wait_for_completion(controller); - if (ret) - return ret; =20 fsl_lpspi_reset(fsl_lpspi); =20 - return 0; + return ret; } =20 static int fsl_lpspi_transfer_one(struct spi_controller *controller, --=20 2.34.1