From nobody Sat Oct 4 15:57:14 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4495B24A05D for ; Thu, 14 Aug 2025 16:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187626; cv=none; b=kc2RLJTeG+jGF3LIqdvzS60pzBdnt+epHG2kDeFubjUawJazmOftN20iUh3jseJduzg9co/7FIOHJxoVBFbVdnqr++EfKC4OdXoqCifEnDeV3g/8Jz1eR8QhH+Je2qptdveQEcVsz7VxM65m1tPH5uYyKVuPCxFHlWMPmXXWowk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187626; c=relaxed/simple; bh=LIQFUNWTOqtolcuHkK+5pFdAZIsgYQVKYSFmavPARR8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rAss/qHui9Gm04fAWW53MrJ8ld8TKyQRvWAybqnqYEyOp/QtdYhxc4CQ3caNZvLnBy+GjE659ZjQ0hyTYOEle9DhTQXEco1huQ5y2QrN2CS7TiwWj8WhCPkE0SS/gXnumpjZ/VLGD+t40rgH76s1KW1NRTn4As4og+eCizVcxdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UC6ZixgO; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UC6ZixgO" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3b9d41cd38dso788471f8f.0 for ; Thu, 14 Aug 2025 09:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187622; x=1755792422; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8Uvtvrck5DhEfDGyTURDlx1K5TeMVtpeGZ6H7CuQmSw=; b=UC6ZixgOqGpndMbxWTWe6b6053rtwQSP6FVAtHMfZXA4J+8O4tAytCkXBAKJyeB0nA P+H7HQ2kNCC0ZktDELHXWmb231LzqTL5DJIY7OMviT/mR60khjNdlJEK4fXcL0Dfn3+A Dj3yfIp+v9/kV68xFFr1wuqAu1Le3CN5hvjJZLQ4U7SKZlm6g/sl69ExuwpQMa0eXONS HnKz+PikUFAsjMONjp0orJzTjrTGx4Mm9wTH6Ljpi8hFApOB/fTh5RfkV18FinZU+nML 0yHeNDtv5F0u1uj35VcFMPmm+nTIVRO21h1klh/DLUsepif2KQIx5IxpOPlJ4B0jSq9C y4Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187622; x=1755792422; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Uvtvrck5DhEfDGyTURDlx1K5TeMVtpeGZ6H7CuQmSw=; b=fSWspNCgo4VK/NT7eng5M1+zszZ/IvK4JtWapsVc3q9n6WSGfTf2LuTf/BL1zNie1b Utn8PAz7CDIVFzB/B0tNhAI3P/E0xYPEDgIHqcVs4r6NNAT2ZIuwHbbsi3KY9dRS7T6Y RsaczcLK+l87vEBtTkF4bDMtb0jyeTQo8Vd+9gasjNqYTQ7Xs1SRkEfC2IFyv89w/VOI TpIjy8LLKyw1E5/0Q5J5bSULjF9ur9l0GWRGDXOtIYwNGyWKLY5oS356Sov+YC1GFpj3 c4GRN/h8Ye1Sxmsj4FlrFiGLzxV2T8CGR6SlUB681SPcI/U3D7V6/N2wf3UocpkJF1G8 wTjw== X-Forwarded-Encrypted: i=1; AJvYcCVjduSh/uyLEgyzASleqo4ZWiQto8w45UIDZ7Ii+iUq29OPnwp8AiTlp9Cy1A4c7oldUeOyzVYXmJJlBTQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxGD6DFJ9oF96Sl5J4vRBwkPIr+RKDHRyeWSSiizWuOFxO2OElN eWGa6kd3QogXpR31Ek8IhcFAvun9T6uz+ZTjw5t2Um/EhNxj1cW3jjbwh//6ldbBEHM= X-Gm-Gg: ASbGncuDJ3hnqTC5ovVukwyfeol9upaJQiYSzziXFD5oWTpDhklHVVHmqh7gmHo4wNX mhvC8b4qUYAvVQcLZWq+UQsoMiIxNC5jUE1Vqqkv8q+MtPtknoGER3x2a25z+bvl8imCn9M0N/G fUDkTc/+oIoxjD9WnJlrvcI8uA7+AOH4kiGEgYNAeNI45cSTSnIZqFum47nELyhgHg7sji7ndx1 B7ENmO9Creq0BvZtpMWBKook4VTz+S8FzKb04OLmSvf0su21/DOXkCcv9GhxkUpHmigE63D7/VG ClavN7G1FNhwP0D1lUWak8+04J6ep2nfv2lfwYAjuvAgXZFSKg1vlUeZrfzEt9mks6jtQtkzWRw QRuONJHLSPAx2bL8g+KBdh9jwE+2rCDylUzIbt0HGXQ== X-Google-Smtp-Source: AGHT+IGGBjbFKFRqiepm/LRwXnuwS+AKKH1MPA2LgWH+5Eq1mmSqrnU9CryUHU5mJcv16mc4hIWejw== X-Received: by 2002:a05:6000:2893:b0:3b9:1d32:cf34 with SMTP id ffacd0b85a97d-3b9e415856amr2916372f8f.12.1755187622548; Thu, 14 Aug 2025 09:07:02 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:02 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:41 +0100 Subject: [PATCH 01/13] spi: spi-fsl-lpspi: Fix transmissions when using CONT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-1-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 From: Larisa Grigore Commit 6a130448498c ("spi: lpspi: Fix wrong transmission when don't use CONT") breaks transmissions when CONT is used. The TDIE interrupt should not be disabled in all cases. If CONT is used and the TX transfer is not yet completed yet, but the interrupt handler is called because there are characters to be received, TDIE is replaced with FCIE. When the transfer is finally completed, SR_TDF is set but the interrupt handler isn't called again. Fixes: 6a130448498c ("spi: lpspi: Fix wrong transmission when don't use CON= T") Signed-off-by: Larisa Grigore Signed-off-by: James Clark --- drivers/spi/spi-fsl-lpspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 67d4000c3cef..d44a23f7d6c1 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -3,7 +3,7 @@ // Freescale i.MX7ULP LPSPI driver // // Copyright 2016 Freescale Semiconductor, Inc. -// Copyright 2018 NXP Semiconductors +// Copyright 2018, 2023, 2025 NXP =20 #include #include @@ -787,7 +787,7 @@ static irqreturn_t fsl_lpspi_isr(int irq, void *dev_id) if (temp_SR & SR_MBF || readl(fsl_lpspi->base + IMX7ULP_FSR) & FSR_TXCOUNT) { writel(SR_FCF, fsl_lpspi->base + IMX7ULP_SR); - fsl_lpspi_intctrl(fsl_lpspi, IER_FCIE); + fsl_lpspi_intctrl(fsl_lpspi, IER_FCIE | (temp_IER & IER_TDIE)); return IRQ_HANDLED; } =20 --=20 2.34.1 From nobody Sat Oct 4 15:57:14 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B40E25334B for ; Thu, 14 Aug 2025 16:07:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187627; cv=none; b=mHDOoTpPHPTCIIFYHHmL8DGLXUFJj8on8ceeIlmJ+ny2Zlo4yh3UlduqhiJvT0zgolwbHe+5RNVgT6z3rlwY6r/GLRkFeKhRedAb916fm2gj9bx/pBg/PG9TTI01phICHkYl/ev/x3pb5LqCoabH93X6LiEtX+iEBJ7l8S0e83Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187627; c=relaxed/simple; bh=CLq0x//RJ1+g8/wsiBtMX89qchTr6zzzAuw6KnvXyPQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G4AvOjhtFskpNxigWLdQTkB/45nTddZ2XMgBx7tn5YITR0bNUSqUyXmS/xL/mARpcRENwVSCcsN8d72/xbXvHidaFuJWFnxlcIkHu6V+SxpWpm7ReYxT+es1Zc9avpft5TbBXPA9EoAjFdzDiT6D+pp//WsV3Qyfid+0JYbRUvg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BfNbBkm+; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BfNbBkm+" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-45a1b00e4a1so7447675e9.0 for ; Thu, 14 Aug 2025 09:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187624; x=1755792424; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G4vuRjFCf3vC4nZa1AB/3PAeoOAW0nxzKRYHE4PiFcg=; b=BfNbBkm+/qP+o+hsycsZUgAJKmo1n5950rHNgCZoNG7Bxm0swDxb296pqAzlQib5/v G0QBZ5Vk8qXutb5tAHpQTwv8aYYj1XdWK+3POUzsPBCGLbC6SrTp8Jnzj/JjYQ6ySsmD 9rFXPONjArHuPbpAAA+q6bLhSQd9h7VYmDIupH50jfZRNSE+hJNrSJWNdhsTCHXWOY/j Of4K6SJl+FKCx1yXwVT0dyH9fpTFmwS4Kr/HnsxZOLWdzjNaXSKr+YeIuMSkClhklofA ICxgdbJfIrbBMUiPzfoOu3ePUC08itzVNBZfvrk6HA5jRhEGEU2MzzemXv0q+q81+6CC pTAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187624; x=1755792424; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G4vuRjFCf3vC4nZa1AB/3PAeoOAW0nxzKRYHE4PiFcg=; b=RKHV0ng4/d5UEOlyMNz7Orz9WNrgXiy0yVOcN4V5u4Gpqh9D3pt97BY6yuS7yBwnQi eqsF0H3UAFMlkOEzp4yMNty5D0at+m5MrXj933rGk0Wnc8/ejLgXneuYZEsyzomlL1DF 3slcHZIQcMWsOic5UbQ9QQYCujuBI1Nuvlf3fziIfTA9UCSPiAmvuvDTcqrbvoqsf5F9 a5uoRXx+04UQYcsjjWGpMsrgYf90q5HO6sL2bdU1U0HRAgHOyLmU9M3uBE7U1+AZFObs d2KVi0FmBeFQRW7niSGVhfeiYFtWsbqfK5lPn4oJUKKf0mVUhPiwBj+J4mwH0D7Kwses DbJg== X-Forwarded-Encrypted: i=1; AJvYcCVMtm1dTobha+vJgtOqmqeg21frIoM72zb8s6RejC8Ye3HJ2w//FygHrrxRwBwAgNNnnBBuMc6KQeGTaNM=@vger.kernel.org X-Gm-Message-State: AOJu0YyrLIVevEkHjVhtYHqESTzySfSY1fdCEmvBP0DF4YWBxm1B6bWm RjHOwvLuP2+UOSVD8WlujNr8cTjUebE37u+ruuoU/szphDRM4YOLM94BYrukVSOTc6o= X-Gm-Gg: ASbGncv16v/xFQ8bXOYLlutyEsg++uEPcE8dmn0nriNocUmhLC4u5ZNQY/ZTgdZs+Mw MjErdifOG8rYBtrmoHgKf5/u9es95IcdUynaOYFdNLQ/Jiw5LAXL7/i/YruEK5x63XBeRHWwa8B PM7OkzpuCZXd1/Vgw8GD/DgMDX6tPu6wBRp7RwB76kKAcV6fFhyguNDwWmq5nS1eQadfA6TKNOF S3UPrTvmSzFvYHCA0hexdwwiWNcQszYCXLSwZvBiyaG8Rr919Ag0wFEcAby0yWLwGohHKXzmA4m i2JmsrarDl+mykO18xAcsqEakjzx2egQhbFl3pS2Uy+dJqwm4z10jk2Svu4kY0Qld7OaSKzmA4v Qz5ww3aWoFd7dizxHTAvtkEo6bgkdLkY= X-Google-Smtp-Source: AGHT+IH/+4jZEpKRE7MfihNgsJ2kDCK+C5ucKz6591vTGYsk5Mbo7reqdiCgmL0v7c+F3KACTVzlYA== X-Received: by 2002:a05:600c:1c97:b0:459:ddd6:1cc7 with SMTP id 5b1f17b1804b1-45a1b597881mr34789795e9.0.1755187623699; Thu, 14 Aug 2025 09:07:03 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:03 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:42 +0100 Subject: [PATCH 02/13] spi: spi-fsl-lpspi: Set correct chip-select polarity bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-2-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 From: Larisa Grigore The driver currently supports multiple chip-selects, but only sets the polarity for the first one (CS 0). Fix it by setting the PCSPOL bit for the desired chip-select. Fixes: 5314987de5e5 ("spi: imx: add lpspi bus driver") Signed-off-by: Larisa Grigore Signed-off-by: James Clark --- drivers/spi/spi-fsl-lpspi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index d44a23f7d6c1..c65eb6d31ee7 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -70,7 +70,7 @@ #define DER_TDDE BIT(0) #define CFGR1_PCSCFG BIT(27) #define CFGR1_PINCFG (BIT(24)|BIT(25)) -#define CFGR1_PCSPOL BIT(8) +#define CFGR1_PCSPOL_MASK GENMASK(11, 8) #define CFGR1_NOSTALL BIT(3) #define CFGR1_HOST BIT(0) #define FSR_TXCOUNT (0xFF) @@ -425,7 +425,9 @@ static int fsl_lpspi_config(struct fsl_lpspi_data *fsl_= lpspi) else temp =3D CFGR1_PINCFG; if (fsl_lpspi->config.mode & SPI_CS_HIGH) - temp |=3D CFGR1_PCSPOL; + temp |=3D FIELD_PREP(CFGR1_PCSPOL_MASK, + BIT(fsl_lpspi->config.chip_select)); + writel(temp, fsl_lpspi->base + IMX7ULP_CFGR1); =20 temp =3D readl(fsl_lpspi->base + IMX7ULP_CR); --=20 2.34.1 From nobody Sat Oct 4 15:57:14 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FFD62566D2 for ; Thu, 14 Aug 2025 16:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187628; cv=none; b=MyLu0RzOsAduMGf6Ls/1vHGOKzoDyhbIBCfvMC/kcpoZ19HMJnlVf3tRbeSrsP3L/905PpGtkcqbEit6XDJTLMgpA7jReZPcs103M/9sdEsnkfJbfyUCbtf3qxVyol0kCWaZPoI2oRjvQmMR/7jFGnGet88SunZ4HzZar5gi/hU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187628; c=relaxed/simple; bh=tGr7ZdC9lWhIzCCUsw+rFlJmgOHa5c1oy9NRasjlofM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hg4PL+GXRKATMtbe+78lxE7iUMHmTfSP9UA76QjWWdRtZ5OKb6aUTZoI+9T288oWeTkoD2mO4IBmWK2dTPI9it89AYsoofmJ6dnZMl5FPhrm7SZRBoYSD/9GxUh3PWN0rLhAR5NV6GgJzEt3UiGap3TxCzMbHVn+Wd9bVLqzsjs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Qpw4hO0d; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qpw4hO0d" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45a1b0cd668so5602375e9.3 for ; Thu, 14 Aug 2025 09:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187625; x=1755792425; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kIP40WisTeT4zrEy6wQwK47oVAaa0UgJRrDSFCcyNWg=; b=Qpw4hO0dtRi+GaLCNUcinFGipsBEL+i/BFhL4ouvTZeBy/fZfOYCvQ2LXd3+6CXxa1 X4BXls5DLFYyej9wdnEspJL5svTXa/N+SvA8rDaTrkKbNxozcnwgqzpQm+0huOu7wdYc Xt0N5GQ9XhwMm9fk7fHmsFsCE+QiY54o9y9So6k6ATPg4QcESDo5C9p37CbwOwHgowA3 WshOA4B8nMzBqLQXB3csqDJ0WmchHB0lRAp1VT1T9eKUXvN355UyF0iBYEMrzdd/IeS9 CaVC0ZqpeTZv1yWUGhUDpRG510PE4aMR4sTZ96h1f8lFGIJGtMC0WaeP8IkjfooyVTLb oeHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187625; x=1755792425; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kIP40WisTeT4zrEy6wQwK47oVAaa0UgJRrDSFCcyNWg=; b=Rr5qyO8TbeCCPktdF5zfBaUEqlqpgGdBNjSTnKgrnRg89WGZglskaAelditTnPf7KC lJ8ax0HyG99xlYbl9m4/dwub6vvTAPlLzXOMQscu7Xfc/x+DkDOMuKi76Eoq6YgB8KtX OhPZRhl/jTyTcdmp/D8ZqDQ/FD+m1i2mcRGHg6k2XthXp1P0kVtBYFW1cUEIRGWSBRFx STnoEM9dO4R8RhzIcWvLYFP7IalT/mWGkIl7Ol0g8NJCsF+0Z+Vi4uYjnVKk8i2NmCDK v2K7Fj0omjOCWy0HJ9oOMq8FfTmFC+tX7lYbY0e3PSJqmq/0nsiJCH+HyKdl3V+NKeOi ZLrg== X-Forwarded-Encrypted: i=1; AJvYcCUE29QihpDPDF9v6PfsBtEVSXqA+xqpsmbzRFLp04A0ws2oeaBFxrjYDE2mZXuMYhFnuBgAhfOGojlJeFo=@vger.kernel.org X-Gm-Message-State: AOJu0YxosV+bODNCDC1nJaYzh0fKPNp0kLWs2Wklq05wFlm6ERmREb6k PEjc4YaoqDGukJaRL3C9qPoxFxOdqPerf8I8Og95jaZ0Zf3Q3xtk6io8iEOUXsT2FR8= X-Gm-Gg: ASbGncuIFFAWCw1VnxdnUxqCUtTPJiOVogtZ+2aL4IWYZXvkfsdNbdEkdANQawrwPqL IcPcyrQa6suwwRENbZeLN2UHj78bYiHvo1ZFlO11RQ5dP32Ex+y9GXiSfuNT7HgynmJoA6erLUo Qe7RMou50RbGwMOT8RoFcK8Cs8PYa0hc6euLX96r5EU76fX1FIWLOzlhDIcaY1OoNsdLYV6qNiP ST9J1cqT9jTVxIJK6TrC5mZrTzLnOqi2R7kDqypwXyyH97rJpNdyPKYImHAzvFsNvEsW6+jaP9b xmgim+ctfATZ3YXsA+sVvR5gQ4UQiQns6NmYYW0RhjaUsacF//gcfrqZ8IvBWTgAD7ZnEr5coyk ypeXlymqGETH75V1HWdi4QkY1ZolIMyk= X-Google-Smtp-Source: AGHT+IFHK7GjTXRXCwZAe8/WmOBTSJ+eME2lZCidVPBvgVxCWAF3s0hzjYhWMNTNHWm2p91GYyv0Yw== X-Received: by 2002:a05:600c:4715:b0:459:ddad:a3a3 with SMTP id 5b1f17b1804b1-45a1b657876mr28054405e9.25.1755187624778; Thu, 14 Aug 2025 09:07:04 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:04 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:43 +0100 Subject: [PATCH 03/13] spi: spi-fsl-lpspi: Reset FIFO and disable module on transfer abort Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-3-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 From: Larisa Grigore In DMA mode fsl_lpspi_reset() is always called at the end, even when the transfer is aborted. When not using DMA, aborts skip the reset leaving the FIFO filled and the module enabled. Fix it by always calling fsl_lpspi_reset(). Fixes: a15dc3d657fa ("spi: lpspi: Fix CLK pin becomes low before one transf= er") Signed-off-by: Larisa Grigore Signed-off-by: James Clark Reviewed-by: Frank Li --- drivers/spi/spi-fsl-lpspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index c65eb6d31ee7..aab92ee7eb94 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -734,12 +734,10 @@ static int fsl_lpspi_pio_transfer(struct spi_controll= er *controller, fsl_lpspi_write_tx_fifo(fsl_lpspi); =20 ret =3D fsl_lpspi_wait_for_completion(controller); - if (ret) - return ret; =20 fsl_lpspi_reset(fsl_lpspi); =20 - return 0; + return ret; } =20 static int fsl_lpspi_transfer_one(struct spi_controller *controller, --=20 2.34.1 From nobody Sat Oct 4 15:57:14 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1921825BEF3 for ; Thu, 14 Aug 2025 16:07:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187633; cv=none; b=ZEhN+OS70/mwlDciTZp5QAGMz6lfvGAKsVuuJbySzoCQJm5cVggW4iJGe01gZx0mzy9XODbvKKMW1VuyaAErFf6o93rj9JOlnu5LT5TZgE1AmLdOLV1y+J6U92UXCg5qPK6b5OvxWI7lr2D6PjtMWGEd1P9Sq5KTC4mPR3Awq9w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187633; c=relaxed/simple; bh=TEu3fUN3erzyt+FPBw44SIOHKGNM0QzRYPzn7NfE4so=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cMMWsB6P9kXyBArZhBPeTfCVBTcDN8uP4o+tqr8EUnUiPtGtaeVt3W9l9WKvjtmb8Q1c8/IuCPIWPjV9iNClVhMTm/wwywU4uXyOSZsJm1BGmO5dnMLjKcl8e91W8uK0uQ1qY2ps2I4DBzY88YWh7Vyu4BEPS3kh4m5jzIo9e3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LZGBNhqX; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LZGBNhqX" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-45a1b0d224dso5970205e9.3 for ; Thu, 14 Aug 2025 09:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187626; x=1755792426; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DMBgPb4Xq82JDov80ni4i5qWbWTDW7t8a9VlWvi+IP8=; b=LZGBNhqXCSFBfTMsfTypjAypvClYCc8UBt4qo1N2xtQNu2e4fPC4R+4QC7lqMFOIvt Hfr1Xw+ozcfCIinHAuYrx7/KxiRbalCELZ4C+DOIUeIcZqpVu53KnwbTl+8ZzrVe9eHu 3IynDUhlbbt2R9bN7qIVFOMxmpgiManmwiiN2Pd401Im2xTQb9MGNuMLImlbR4iYbjGj STlCbAEwaFR6GJcAnl2PIh3NTakGqfC0fWigJZLDovYgzvM44T2/LD8B2tJI9YofAqgz SwKIEGIuamQv1nBA8uPMeiCmUaC4whNBdrt9yD/m3Y0Qihl78tF5J2GrOCTFdTzvUI9X SAwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187626; x=1755792426; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DMBgPb4Xq82JDov80ni4i5qWbWTDW7t8a9VlWvi+IP8=; b=r3jX2bPHMf9COJVqvc9D9jDiQXLUr0mQZe8fg77Lq41S0+lb5WmyNRGKBK5ZkZubB3 PUx7o9N508rEnLo5VPEcQDsCQW3Xl4keAKKb8VQJyipG/L6HKc9EYHkP5+s9Qd2CoVrF fWEAY7NkwXBh/Aa5R9siW9Tb5YzHdOs0UOsgLbJdYROoWPKcWKZbfl1tVVGsxXGjHNeX ubPm19GN5Nnjfrx2OR1DrxJl3X7QBca5NZzXKLe2Co7PFV5Qm3OP1HFJyj1igwGrniBI jCJnHdNV2/5SsWlNg8+rFuSfUuER+Hw/4gb8H5HzOZ2+D17IwElw4nsNZQuDwn+CFEK0 j+Fw== X-Forwarded-Encrypted: i=1; AJvYcCV1aS+jNfdUXxtWjRE7Hy8tItrQl99dECtzUhSHjmhk0XFRBT+bK2KLQDVIMyejaJRUgjJ1KkS0RWeAMsI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxb/NCQuno/0jIehJVRQshfKYEqaE/V8XCsqqBpYRUbJ+Bepwd9 9fqcbB6GlQmt0UL4UaWW6Rg6e2b7yQLge+gZE1neCK8Jw6uhdDc0U9X13cR02dtSTls= X-Gm-Gg: ASbGnctuzlKodUVtvwNFHbQTLjDm0YrlsmYIvJHy1cgQFMv6AwScN3nneTuBfN5pUu2 CqA9sG7oKxP4l34dTWZVhUZisoM1QXa3Bq5KdztdV0IGdPZML6449Zk9qXkU0VC3hnuKIV/6UPi BVfCEy4QSp7XY1S9DdQGuiMuuS7F0LOF/1Mb+nxcxi133SYdAcEeRY5HyIW7AAKZuwrwVriGP90 IRh077Clq5r6VkJ32R+C+vpzaYBcoj7wMav3Kg5KslJLxFamT5h0yBQd5UNJbOAGbam20EHITgA bMwPPm2OiLFbCymelKKZ/a9Q7E/0XhqotFowD7UHnFP9RphaDha18gHhOt7htuRlPA3f9UeiDPT QN2HqiHGtgvgTvW7iCuHw5uVM680iruQ= X-Google-Smtp-Source: AGHT+IEOT2wwsPyctFrgMr5ByDkZdw4HXDUlDk99xnD5BV/nP3sUkqvIgtuH6uOuro0r9fJd4VPXLQ== X-Received: by 2002:a05:600c:870f:b0:456:285b:db3c with SMTP id 5b1f17b1804b1-45a1b88d5fdmr33513625e9.3.1755187626069; Thu, 14 Aug 2025 09:07:06 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:05 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:44 +0100 Subject: [PATCH 04/13] spi: spi-fsl-lpspi: Clear status register after disabling the module Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-4-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 From: Larisa Grigore Clear the error flags after disabling the module to avoid the case when a flag is set between when the flags were just cleared, and when the module is disabled. Although fsl_lpspi_reset() was only introduced in commit a15dc3d657fa ("spi: lpspi: Fix CLK pin becomes low before one transfer"), the original driver only reset SR in the interrupt handler, making it vulnerable to the same issue. Therefore the fixes commit is set at the introduction of the driver. Fixes: 5314987de5e5 ("spi: imx: add lpspi bus driver") Signed-off-by: Larisa Grigore Signed-off-by: Ciprian Marian Costea Signed-off-by: James Clark Reviewed-by: Frank Li --- drivers/spi/spi-fsl-lpspi.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index aab92ee7eb94..79b170426bee 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -82,6 +82,8 @@ #define TCR_RXMSK BIT(19) #define TCR_TXMSK BIT(18) =20 +#define SR_CLEAR_MASK GENMASK(13, 8) + struct fsl_lpspi_devtype_data { u8 prescale_max; }; @@ -536,14 +538,13 @@ static int fsl_lpspi_reset(struct fsl_lpspi_data *fsl= _lpspi) fsl_lpspi_intctrl(fsl_lpspi, 0); } =20 - /* W1C for all flags in SR */ - temp =3D 0x3F << 8; - writel(temp, fsl_lpspi->base + IMX7ULP_SR); - /* Clear FIFO and disable module */ temp =3D CR_RRF | CR_RTF; writel(temp, fsl_lpspi->base + IMX7ULP_CR); =20 + /* W1C for all flags in SR */ + writel(SR_CLEAR_MASK, fsl_lpspi->base + IMX7ULP_SR); + return 0; } =20 --=20 2.34.1 From nobody Sat Oct 4 15:57:14 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00DA22DC34B for ; Thu, 14 Aug 2025 16:07:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187631; cv=none; b=A1H+kfKoD5GgXddREsAPrkv3QGdS15UmyEasBoyTlpUEeUtUdjGXC8fhbA6RdgvGlyooDQKcraQJegsBGXfDiv19IPmx69mWwHajmcY0rmX8MzdymFbBwF/SfLOQcEymSUMe7lneJLHg0QqIsqSKS6oA5zxgtxQHuqgrYn9uZMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187631; c=relaxed/simple; bh=bWgha+DV3Wa1id7olbSo3Evp0auMrFKcgECRKOQUQgc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YT+edwnNoh4BzanVaVQYMrrzjrpWAbV8XaBWABJ6e26Cb34m7wAyyZ1qeJZn/e8FUk7lcmLHDA9P7sQ8CKnuZSN6mRvIdHMof/qSZq+nc6B8k4tmzbIsrRVR/S9Htn91HBbMejKHYCpLlakoYLYX5BluPD3q8ieIlxBbwuUV6XU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=P9aCuss5; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P9aCuss5" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45a1b004954so7938335e9.0 for ; Thu, 14 Aug 2025 09:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187627; x=1755792427; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aHOC2LGUA3QZ5xVo8Zfg2sW76sxCAGlwB+vvvOMaDRw=; b=P9aCuss5GWNAaIEB+fv6LqR/58JZdQZrv/nST6R96+8+k3wevXNIKvJgIyDQVODDin V0CFZo6tZIW5KjS7Y0z7VfnJ9YVTD4yC6hCxv0Qb6gP3ZvN0nqEA07nbr26CNHzyH0bT aFgWF/886mDUWG3qrswUlrSK/K07Cp7LlDMviRlirpSCiXYUAxBR+WX8npUn87Y944e/ Nxbz3zl06AwMT4m2NejoBMV4mEDi32Z3VO/02neGg5i7ajZ23ccRJuDfNSX3E+ozaEnm nW0M+HHqrM5XpImSgC21o9judctusg16jYMqe/lhjNpdDlnJyimPpPlHLWMyirI902v1 Lh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187627; x=1755792427; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aHOC2LGUA3QZ5xVo8Zfg2sW76sxCAGlwB+vvvOMaDRw=; b=AgOes59M3D80jAxsaxcl5DvZjBPMWEuw8MWdplXIXSVEOPww4I4NrNAnDlyUEPhDr6 H8d4C0Qg4QD2S38kDDDnEzZ6PQmymPwf1hRpzA4ytOh03kw6oi+SX7zhv4uIYqflMql5 esRDLkCevjUGbOs2tTwYiEJNxtVyox2txv5Tfiu3LgQxgGdCPOosLk9EN+SqY3tdft/7 NWNHGL/mU6T82OnZaoMPTEVd1dBwS/mZO378kQMHuR51AE6vhMXKZc6qkvuI4J3FatmD Sw1xfS//1ob8H/7C+t32RqeFnDiDKb87DoT0Iwx6RRP9U2SFcXvi/h8/Vy759fFS+NlN HpNQ== X-Forwarded-Encrypted: i=1; AJvYcCXk7ykL1iTBLmwuV1bn8o1d8IuCBI3UgZSxR0yk+vjwwhx4MpQNGV5aOjR7vzcLOoBB/mo+toqoUeclcAI=@vger.kernel.org X-Gm-Message-State: AOJu0YxbtoJ7RrMd/1+PD1XoZ86yv+Vxb7L82GKAFM30bLB/1AheHJIl 22QJAHMY+ppdHR5XCJKcjk6lkjHJBvnqcgmYzdY8HJQOk9SPJiOBqgJNSM8TmhoVfZs= X-Gm-Gg: ASbGncsquGNKpvrQ7FjdZVpWJNN9k+JLL+5SMQ8tYsg3G55EcVLV94eBM1p+nd6IHUe dKFgsszAkAT7PYTu9DK3bqPTlCzmddbJcTLi+iQRvFvsAE+bViPgOK1FD3+//g81vmWjmcem+xk 8ldN781LA5+LFUhOFXVr+I/N+/uO0lUdAmjjf1kN/v+JUgQKdxn753mkRQi6rMx4YaIenDUGftH U+ZrLWkxB9pD5qa5ZevbmsCTWmSXMeqZTeEwzVlrkttZ1QfCREZTjUZCPNGxomRSZ6s3f/ej7cR wuDw5wWWDNS6z8FkMZ7b4No4MbICy/keH6J2Mz2Y6RAwHmw3wrdrflYdYqfnN/KL1MQJ6pxt7W0 jJVKrf2t4kwd6frGl5cL4jpM4y1M4ZXg= X-Google-Smtp-Source: AGHT+IEUHsQ0l/NtdaJERHq/WSd00uZIkZVtp4OgX2ON8GYUOwmRShR360uVb0ELZ0IKVWDhUp1roA== X-Received: by 2002:a05:600c:4e88:b0:455:f59e:fd9b with SMTP id 5b1f17b1804b1-45a1b6707e4mr33074545e9.24.1755187627290; Thu, 14 Aug 2025 09:07:07 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:06 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:45 +0100 Subject: [PATCH 05/13] spi: spi-fsl-lpspi: Enumerate all pin configuration definitions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-5-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 Add all the possible options, use names more similar to the reference manual and convert _OFFSET to _MASK so we can use FIELD_PREP() and FIELD_FITS() macros etc. This will make it slightly easier to add a DT property for this in the next commit. Signed-off-by: James Clark --- drivers/spi/spi-fsl-lpspi.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 79b170426bee..816e48bbc810 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -69,7 +69,11 @@ #define DER_RDDE BIT(1) #define DER_TDDE BIT(0) #define CFGR1_PCSCFG BIT(27) -#define CFGR1_PINCFG (BIT(24)|BIT(25)) +#define CFGR1_PINCFG_MASK GENMASK(25, 24) +#define CFGR1_PINCFG_SIN_IN_SOUT_OUT 0 +#define CFGR1_PINCFG_SIN_ONLY 1 +#define CFGR1_PINCFG_SOUT_ONLY 2 +#define CFGR1_PINCFG_SOUT_IN_SIN_OUT 3 #define CFGR1_PCSPOL_MASK GENMASK(11, 8) #define CFGR1_NOSTALL BIT(3) #define CFGR1_HOST BIT(0) @@ -411,8 +415,9 @@ static int fsl_lpspi_dma_configure(struct spi_controlle= r *controller) =20 static int fsl_lpspi_config(struct fsl_lpspi_data *fsl_lpspi) { - u32 temp; + u32 temp =3D 0; int ret; + u8 pincfg; =20 if (!fsl_lpspi->is_target) { ret =3D fsl_lpspi_set_bitrate(fsl_lpspi); @@ -422,10 +427,14 @@ static int fsl_lpspi_config(struct fsl_lpspi_data *fs= l_lpspi) =20 fsl_lpspi_set_watermark(fsl_lpspi); =20 - if (!fsl_lpspi->is_target) - temp =3D CFGR1_HOST; - else - temp =3D CFGR1_PINCFG; + if (!fsl_lpspi->is_target) { + temp |=3D CFGR1_HOST; + pincfg =3D CFGR1_PINCFG_SIN_IN_SOUT_OUT; + } else { + pincfg =3D CFGR1_PINCFG_SOUT_IN_SIN_OUT; + } + temp |=3D FIELD_PREP(CFGR1_PINCFG_MASK, pincfg); + if (fsl_lpspi->config.mode & SPI_CS_HIGH) temp |=3D FIELD_PREP(CFGR1_PCSPOL_MASK, BIT(fsl_lpspi->config.chip_select)); --=20 2.34.1 From nobody Sat Oct 4 15:57:14 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D3242FA0C9 for ; Thu, 14 Aug 2025 16:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187632; cv=none; b=Cr68DjWBcEc5RWUPMLHTWVbtnKhDjHdXXisSezsXgYO5e5G+iRZL6KIAclzl6s80OFpWIEs4pS7urjIjJM0+Kg3bxGGZeRARbjI0gM6CDzzytwG465EtLFCsaasnQsMpOJ79SoRYitx0JGRWkw9iDq5LWt0iy/iPZxOy7ae4+Cc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187632; c=relaxed/simple; bh=kHiusdNohinSSATnpMTFXT3o3848Vs6qfqTYwtpUuZA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mfogZnBlrcwOCZqq5JdBCmf0OJsv0h49dWIkIPqsgTfCGab+UDYrOgiZTo0RJgrI3bpMHsybBJaERwk2JZOKL7jKAr8lIcMRaE6NlLkgzVlYKqoVdIjfH9c6OrqpNM2/GDeayQ+WsHW6gXv3xLxd9JGS7TJLYyzUthLbPECMeIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tMxQyEBl; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tMxQyEBl" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-45a1b00797dso7437355e9.0 for ; Thu, 14 Aug 2025 09:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187628; x=1755792428; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Zzgs94UaPpR4eiZY/A2IoO5J4EqrnU9/y/7GbaVqos4=; b=tMxQyEBljJ6iv+qkYnJwWRCswdSmtozB1tmA4qO5t9fQJ1Hoy3h7qszUgy1Z7fJjOf tJTFT/AXknaI3oPjChYmPkM2D8PRn5xGmmgLRFA4CHSe0RIfi1jaK8M40IKrdy14b8Gn UQ/yseuFnDsI8bKodnNqjGqs2HomARI5nGW46hNFqmL6PfzcgFZc9foG2GiOBR57+bbI U5++GTPVTnpaFSEEDpJCERMlKSp/kyLDYO9HY9CHtLLOojh8Vi86AzJGLAlWF9R8zsSk 7jtRP+KiVxiUPyWd4wVkrZv4ZgfFdKDc+fHMfbAktH5f7kk1kAgwwAV29V4co2Ag42XL iCrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187628; x=1755792428; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zzgs94UaPpR4eiZY/A2IoO5J4EqrnU9/y/7GbaVqos4=; b=GPLXgNxLgVDHER9GYLFXw475a/nXKvfUNit55/eosbClQwXtZlOIeIgCx/JFjBgBEu QqcnIJGo6vMW7BLueUBscnYpxxlh4I4rPzxsEFiUDv/XojBFRWp5pKx6wSeUhrl/tcU0 RDzofYVR24wZ3AlGJK96emTif6lNnwOSVx8Ghc9aruJN83oBThAKMeJv+qFsmxnFsdyi SXJKCC+18qR9xwIuGDwTWQ8bjgfuX2gigZ4GVloAiI6Tr88md/Nlex8DeRSsJw4vbosd Ee+TvG573NWkgtn2ow95YXZOPNgmSFKs9w9jeD56OOHvuNQhxrTD1VEH2H0CkoSsw4Cf wRgw== X-Forwarded-Encrypted: i=1; AJvYcCUAMc2XLwxq/B4/DUi7uev8+sFRrmbV6FRf1GskrhOYy5LKIwxKcZqk8KxS2onzwNm5bCalsDg4HZma8nQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwKb/zhboUJSGADQU+TXUngqEVTyZXLMZqeYzk+GEad92M968C3 s4HUNI6AKJ/8Zqg2tjKdi6WdBJ169I67rcRP8NJ0EI0KaUvIbM9Rrj7LaTMIkf4Ea6o= X-Gm-Gg: ASbGnctjc+QvLVUObASlESnj2+Du4D9ddfbg50L2QpBIiRI/zwqd1GKOzqix/3/CDKk T1VAhSunIDE6SXBwOfjrjtxDLrqHV3D/wMW4+x5qVXmcFvCuV6h5unMQHnTMja5WkA9crGpmFLP tmVjDNvyXhbKunVTp7+OBC5JIUG0DLz4KWjjMn3niKtsZvZkUgzsOcPT+b9zcVWNCMc89UNgG/G FHsoIRaw71gxeCMT6yxYkSZtxoY0z4/Vactyji7ETB/CSrUEaEmEdgjwHndQGCqLz9n/9LSFyF4 2yZVw3yd7D0WV1GhZ5vfkwu69eao8ufXI5rS1EWQhWwxkCwb21Bhgb71W50PgjPxrz/rrI1WBtm Yj4KWuslNIzouQu/a9nfIPScDwNZL5HRs01wfWRK/XQ== X-Google-Smtp-Source: AGHT+IGktcl8YaEWCqH4pc5f5bXMJs47KV7sRjWfK4gjUNrG3xeCwFQRXRTrSkxb2XHOnppAWphUiQ== X-Received: by 2002:a05:600c:1c1b:b0:459:ddd6:1ca3 with SMTP id 5b1f17b1804b1-45a1b5a2033mr33274125e9.0.1755187628364; Thu, 14 Aug 2025 09:07:08 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:08 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:46 +0100 Subject: [PATCH 06/13] spi: spi-fsl-lpspi: Add DT property to override default pin config Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-6-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 This allows the SIN and SOUT pins to be flipped. Use an enum instead of a bool even though we only support 2 modes so that the other two half duplex modes can also be used in the future, if the driver ever supports them. If no property is specified, continue with the old defaults. Signed-off-by: James Clark --- drivers/spi/spi-fsl-lpspi.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 816e48bbc810..98da6a5d7013 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -88,6 +88,13 @@ =20 #define SR_CLEAR_MASK GENMASK(13, 8) =20 +static const char * const pincfgs[] =3D { + [CFGR1_PINCFG_SIN_IN_SOUT_OUT] =3D "sin-in-sout-out", + [CFGR1_PINCFG_SIN_ONLY] =3D "sin-only", + [CFGR1_PINCFG_SOUT_ONLY] =3D "sout-only", + [CFGR1_PINCFG_SOUT_IN_SIN_OUT] =3D "sout-in-sin-out", +}; + struct fsl_lpspi_devtype_data { u8 prescale_max; }; @@ -417,18 +424,27 @@ static int fsl_lpspi_config(struct fsl_lpspi_data *fs= l_lpspi) { u32 temp =3D 0; int ret; + const char *pincfg_str; u8 pincfg; =20 if (!fsl_lpspi->is_target) { ret =3D fsl_lpspi_set_bitrate(fsl_lpspi); if (ret) return ret; + + temp |=3D CFGR1_HOST; } =20 fsl_lpspi_set_watermark(fsl_lpspi); =20 - if (!fsl_lpspi->is_target) { - temp |=3D CFGR1_HOST; + if (!of_property_read_string(fsl_lpspi->dev->of_node, + "nxp,lpspi-pincfg", &pincfg_str)) { + pincfg =3D match_string(pincfgs, ARRAY_SIZE(pincfgs), pincfg_str); + + if (pincfg < 0 || pincfg =3D=3D CFGR1_PINCFG_SOUT_ONLY || + pincfg =3D=3D CFGR1_PINCFG_SIN_ONLY) + return -EINVAL; + } else if (!fsl_lpspi->is_target) { pincfg =3D CFGR1_PINCFG_SIN_IN_SOUT_OUT; } else { pincfg =3D CFGR1_PINCFG_SOUT_IN_SIN_OUT; --=20 2.34.1 From nobody Sat Oct 4 15:57:14 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4905A2FD1AF for ; Thu, 14 Aug 2025 16:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187633; cv=none; b=sL4pRn0m3pcjChLqNSsGjqc/9M4PIPPDqb1w7Cd9qfeNr3efv+ij8DhMTe4pE2uMtXyESpqZbOCzAWuSVN8FR9uEuyEAvYfgwykNv2mN125SnUKE6PmjIt1xcQitR7s4tndclHpsb+xwU8AapUlQPXkZ/Pvh+2gBjG6rT4YttXM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187633; c=relaxed/simple; bh=x6+cgJsB3/bivyB/8CpTvAXJFzLNyeY5QyOEcAO/NHM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MK/6SGBgr9tYTEXl11cl4d330khrI7TkT5nllpxo52ggDufbLVYW9VjZSTdOdY7rlqB0l+IyWG0iC8S41MCUVwSSSiT9KFSCFDlUEgSAZZNotmEt8+jiPjMRiJqvOog0gDOJJl3TBGFBMYBT/vdcl4sIDSj0spBgbWA2Obcc250= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=o++eq/c2; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o++eq/c2" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-45a1b098f43so7598795e9.2 for ; Thu, 14 Aug 2025 09:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187630; x=1755792430; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WEY/dtRV5XlPcMpsbJUXrg5ckl8gnLAS3vBlRMh6s4M=; b=o++eq/c28Jh842+yI3UYFqPaH6Ns8nTnJCs0JuIhwpsl9AD0zF6Y5S5rodvefXJmq3 dP61B3sz8/Fir1F7SQ1sQmh9+cA7JUg23oHzpuf6s51oMY+/Eznqn2T+u8Swd8RC6TuK Q8pU7hNv5j+gawd6Cwf+TPLJDF/VPXKzesYLd3a+HKk2tSXqAfPKjapFrW61KjlboOWF ++XfQYeJt2ioIBPFAzDG0NSV3FFgEWv/ghd3e70DC8M7zVkGnYNDqK5cFvhu2HN8G/6n eAV394D+hsKhoWRDtB6AkPOFQ8G9LEcZiZMlJougH57VRDvWaDMbWwEEs5MMkW19oTYp d8gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187630; x=1755792430; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WEY/dtRV5XlPcMpsbJUXrg5ckl8gnLAS3vBlRMh6s4M=; b=erTdjIUeCJmYE1B9Fb0vPXEu7EJrcEPrz3Boz8/R2C59LamshRaBqANlACn6GY3q14 YFDJzU4RaZdE8IIDb4ds7MSk1F4LcY1G0BAU2uwEGNJ8VAtajXbFgStsc9C2nUsxHOhA x+IA1NTnr+TlhbFtumeLd1+1ZYtwPmR/44VDAei09X4ZheJ/Tf5ahgxAeFXuhbAoxklq a8EavJO6T7AP/cJ9x4ZaYHN5l1sFOXo0vEZsTfUVjx9MqNebr2ouwQhwkg2c8Bp9Wsmi O8IzdYATKPzO5Dh09E/YokZ7p2P9xKrmaN5IFTtH0EKsd8OztdTO/BYx077ZGcUQOoQD yxsQ== X-Forwarded-Encrypted: i=1; AJvYcCUuVhbIoupDVTiI0kMD4JcLWnJwHATkkf9MZKtbeC0YUVRvpkUux9ymKp+8z368XPXgb75hy6EQAC7UWHQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz730r6mGhyPK6+b7drtnjxJ+Ded+GljHEd/elBILjQL3rw1VK2 tD08X4jviTb2Kgx/deTjfLT/9kZtS+ysirCmOOVYIy9t2GS+deRSKCngyNi3WrIwBkI= X-Gm-Gg: ASbGncvz49SR6eHrRj84LQcVZUoOwkkExjJKCDOxsQoWwclLXirD12NBMogErSnevv3 9uhhMXQWznSjkhkZkzyKGTOIZPN5lXv3UZXNCbemjGfZCWeGSIyxbnZ4EjSNr333SYXZWXKfycc 5d808Xsk1LbYTg3BHYj7t8GZWH14yhtLgrOrvtIuSW0umHSiBXCWN0Qt5Rw7M/vRkDFJRU6AuLF DXOtETk+NF61BM82U7tedrmN19EdhBFXx8tMubrJCOhj+RWhIXeH1ks51F8Z2FWG9blZbUFVheU a36sFHSbX5GYFuHLVyo3pKvraOWBWVq+NiiUbofpbUBf3ufBHP0SGA2ZfNFGUxPcXWtx73qqfPi UAfq4SWrB671nXXUJxkNZgqd+itx3whFWHdfzCxNgNg== X-Google-Smtp-Source: AGHT+IFs/lEP4IWVBoJgkpoH19R4IKvmXIZCDViCWIe4I0U2tewRdOz/LgHXlcznz0VkzRUCVVfEsw== X-Received: by 2002:a05:600c:19c7:b0:459:dde3:1a33 with SMTP id 5b1f17b1804b1-45a1b66e81emr29035635e9.26.1755187629543; Thu, 14 Aug 2025 09:07:09 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:09 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:47 +0100 Subject: [PATCH 07/13] spi: spi-fsl-lpspi: Constify devtype datas Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-7-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 struct fsl_lpspi_data->devtype_data and fsl_lpspi_dt_ids that point here are already const, so these can be too. Signed-off-by: James Clark --- drivers/spi/spi-fsl-lpspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 98da6a5d7013..332a852b746f 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -145,11 +145,11 @@ struct fsl_lpspi_data { * ERR051608 fixed or not: * https://www.nxp.com/docs/en/errata/i.MX93_1P87f.pdf */ -static struct fsl_lpspi_devtype_data imx93_lpspi_devtype_data =3D { +static const struct fsl_lpspi_devtype_data imx93_lpspi_devtype_data =3D { .prescale_max =3D 1, }; =20 -static struct fsl_lpspi_devtype_data imx7ulp_lpspi_devtype_data =3D { +static const struct fsl_lpspi_devtype_data imx7ulp_lpspi_devtype_data =3D { .prescale_max =3D 7, }; =20 --=20 2.34.1 From nobody Sat Oct 4 15:57:15 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A06442FE07C for ; Thu, 14 Aug 2025 16:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187634; cv=none; b=cQF7vFGEVPKuQg7+PSS0XPdmpo51fTgIj4XQ3pGhvNOKYsKPZQnMvIxNCxlcvU5hDON8rI+/m93bqAsQWaBwPEelmRCdLqy+4JnEkPcGl/iT8nrtuAPXl+SzD2xUHXjXsK4Rkr82vDp93aRS1VBEUB6+2zgAgUcfSFBs7zWhuw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187634; c=relaxed/simple; bh=ZiCKUtZKTqw9rKZf/7+lmX/pnv0/DEYvxI7bYI1KMjU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZYB0Dpy6xnadyiFMYpRVoqNCqWzPn/dofOycKMvUTzpScO4ZO486EXDmQ/XBs7PwlDrBbOv5hbFMuANXqqc7EIxzjlPyE2Z1FBd0UxcsQSdK2sBufwN1e+etV3Sd5JCo5tjFWLnwOy8ZV92AS+WUhQeUI6R/Hl46Da+SxGwMB9s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vHJ2mU7G; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vHJ2mU7G" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3b9d41d2a5cso870385f8f.0 for ; Thu, 14 Aug 2025 09:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187631; x=1755792431; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V+xkEKCXMOBI9HGuIfKoOfST0QQ0+/qYTKxEDH2g02Q=; b=vHJ2mU7GwvoQlMlpsbPU6Vv6TNT4Y/lPihzUyFjol9FtByqq42MxA5ofW2rlNYGE4Y 9pHF9x/P9kVPpe7GLCMaOUGW9UdT2T5DtXMPAvcUZ1lW4nMnNx2NHUrs48/bmsRM+eEE arRAA8y2gaoDzbUKWpA8jWNSffEpmjpfEACh+ezW9/2u8MaNhrppxI+qUkx2gWDyQnu6 VIXHlxi60+UYxtczXWKtNDXRC0oY45kdUpJKh4dRHZvV6kmUEY+Ok2zuQnUCyT57OKYA hf3KFKpiLs5NeHZJ9hNypm8fB5y/Ga3myhx982E2ov/6W2SOzoxsSFZUP/Vp1iKqHAeA fcOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187631; x=1755792431; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V+xkEKCXMOBI9HGuIfKoOfST0QQ0+/qYTKxEDH2g02Q=; b=Utfyx/ga96CTI7++fZOc2SRD3tUsgXNE5feHxR142L3yvu8WWKvopW39Xa5wlLlaB/ K6zalRWOxD47fMs+O3ZTZCt5oQuYYoMB1StwvXY1KK5jEz6Mz7UHkGM+BaSEq/ad7Mh5 dXP1uKFESFhBDWyZWuvzvH3hyTfIJrxFE4IAoAV7z7MKaZw/UYHTVGFWhHrD/dIHuLbI LwFTMyECxN2JENxSVn1n4ntTFtaifp+TIGxWyyRYJwwOecyBt9kihhP4F2a+uYEEc/QV RzabWxI4+Oea8FLJijNVOA1meirUr+CIFgN/B03GtRIzAlBruu7wy4XINkCtwRmQxAss EztA== X-Forwarded-Encrypted: i=1; AJvYcCU+uqjL/ItbJjkgycjP6P0YfbgfekQHtAstT4Rbqah+vmkPXdPojz6mYtGJZynZdkfkKVOmJ4svH1CPau0=@vger.kernel.org X-Gm-Message-State: AOJu0YzWWCI2kBxT+WkgWgkeePPlYFnVDbtOUs5oyfADpAHnJsFogYZn EHG3J1yBHUFTFGcg+ehCDNaxqZpF0AsFmlYPUJzdzuXKB3Ity3l7pcC/sSeospxqbTw= X-Gm-Gg: ASbGncsvdVGL4opV7SVQI2a87vAzNX+iOtiOSk+tI0DnVa3JDlt8atK6JDG8pz8LvFn 0KFOrDNdC79jlYthY5W1yNEbPMo/QU4r712ZySBlwSW5YAKgftGmeU1nMBsZChAMhXCRatBqvdm vhLN/kbVkGJXg0XuzPtUrl3rGJhVUx4gs+lyhTalty9Ic6ULXBl/as4GuPWg9ko6L6Hsv3n0jHT W72WJ+E2X7C3ufQehkCu7B89wTt0uia6EMYilv7hU2Eu+92PLGsufSe/cR6hKDUdM3ilPRdgoyw bfTkSRJy7np7J1s68X7CznrAZ5WFvT5Icqs/iL44aLmy9n2U7mHLTc89jRG7KGQa/vxZU+BRwY+ QQYW+VUHdg8wRlBgBg4iyR1quZe8f//k= X-Google-Smtp-Source: AGHT+IHnPTemnQhlu4YOUH9ujk8ivLrojbab2xEKJpPhGixHfcJ0gQI64MgagrxrAFS1KKMyz+LVmw== X-Received: by 2002:a05:6000:22c1:b0:3a4:bfda:1e9 with SMTP id ffacd0b85a97d-3b9edfe4a34mr3391077f8f.46.1755187630845; Thu, 14 Aug 2025 09:07:10 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:10 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:48 +0100 Subject: [PATCH 08/13] spi: spi-fsl-lpspi: Make prescale erratum a bool Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-8-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 This erratum only ever results in a max value of 1, otherwise the full 3 bits are available. To avoid repeating the same prescale values for every new device's devdata, make it a bool. Signed-off-by: James Clark --- drivers/spi/spi-fsl-lpspi.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 332a852b746f..1013d5c994e9 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -96,7 +96,7 @@ static const char * const pincfgs[] =3D { }; =20 struct fsl_lpspi_devtype_data { - u8 prescale_max; + bool prescale_err : 1; }; =20 struct lpspi_config { @@ -144,13 +144,16 @@ struct fsl_lpspi_data { /* * ERR051608 fixed or not: * https://www.nxp.com/docs/en/errata/i.MX93_1P87f.pdf + * + * Devices with ERR051608 have a max TCR_PRESCALE value of 1, otherwise th= e full + * 3 bits are available (0-7). */ static const struct fsl_lpspi_devtype_data imx93_lpspi_devtype_data =3D { - .prescale_max =3D 1, + .prescale_err =3D true, }; =20 static const struct fsl_lpspi_devtype_data imx7ulp_lpspi_devtype_data =3D { - .prescale_max =3D 7, + .prescale_err =3D false, }; =20 static const struct of_device_id fsl_lpspi_dt_ids[] =3D { @@ -329,12 +332,11 @@ static int fsl_lpspi_set_bitrate(struct fsl_lpspi_dat= a *fsl_lpspi) { struct lpspi_config config =3D fsl_lpspi->config; unsigned int perclk_rate, div; - u8 prescale_max; + u8 prescale_max =3D fsl_lpspi->devtype_data->prescale_err ? 1 : 7; u8 prescale; int scldiv; =20 perclk_rate =3D clk_get_rate(fsl_lpspi->clk_per); - prescale_max =3D fsl_lpspi->devtype_data->prescale_max; =20 if (!config.speed_hz) { dev_err(fsl_lpspi->dev, --=20 2.34.1 From nobody Sat Oct 4 15:57:15 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B59D73002BE for ; Thu, 14 Aug 2025 16:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187636; cv=none; b=HWz53jUrrnLya3eY2ltsbsnkGnwB2rh8jZoLAEGBoE3ktL8U4kTBe0qZxbQLIDr1mgpEGI7/GGQJfEEfDtC+nb65V7tFCxObHvb+RYj++j2QuXgomrcHbzpBApiyaicZkkvUNEqkq0OQD7c9km5j50C7s13ACCVmO8niLE6BTCc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187636; c=relaxed/simple; bh=nLKgSvSgI7gDUsnC9ALIo8slGJAiPfy5nla9VR+CXBY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q0AzwSYEAv46d4vOKiVpXxcabgIlcTFSsbjUsokwUsPhIpQCRfaoLEXn42bkzg8Zv8mFrpskf05uqyy0sZ7JUkUAPfZn+5eQ9EE1P8z8YBrlVRmAXWCvOluUwE1/8dMDbNIcULfAKcIEuqo8mgRCXmCkImxPpmsmNSEK1Ze+khQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OpxXIH6W; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OpxXIH6W" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45a1b0cbbbaso7685325e9.3 for ; Thu, 14 Aug 2025 09:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187632; x=1755792432; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4uUiAWgIv/rr4bdczjmXB0zM0zB+f4UfZqA/MDFkyEc=; b=OpxXIH6WnOgr9w2Rx+EIqSUiQTFtBf17ypM/jrVrZLCfamNvsf5mLZB9E3i9bGkUXy FZU97LRnAnJ6DbtOjjqW+hjq1D8a1qlCJStxsngTISkQJboYcY6lYoMOfVBi0dMVrR/o dYFXU+LNZMBDf7RH2F5ZjjLiGVyg3YWLgnEejCaG1Ewa1Y0cK18I34Jml5r5kXVISgTp v6kXwt6l64/2l5zilVq5nADsP1yR8BES5Ch027v+j+r7dgrvv+uDckfvSXBrWp1xM/RY Ido3qNvhqJrpbRcug3VZPm2kYV4Sbta6c7c/kCGPWqK8Zmmk6q+bIhuS1KUmoTCaVRji E8Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187632; x=1755792432; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4uUiAWgIv/rr4bdczjmXB0zM0zB+f4UfZqA/MDFkyEc=; b=GbU1rK/y0+7ys7y0pSM0MC/Rsuzu8uyWglhVsqf+OL7x5nC4ufI8RD4KpGbVOzpXQS 5PJqGQTh6n8HKZLgnn6NAaPWDrY30MDlEFM8ybzdhaYcW0grhugjUT+22WBMjnj3Vz39 QZ376LQPzDE/WZxs8UqUktBtxYW44E5CgbliZlL2dZQk4eCRhDzfpfbCDjF5LGwYl3wk FhyJROFC2cq3LcColRYHIZHC6oaQPPlWlvZLQnuKkv4VOXpCHSju1H5+cWxgxhqiwIpD eFaE9Yk9to6Jsldg9aHoo8EgxY/n6cN23EJd3Jh+LZGa26sdWPEdc2rwP557kcDHKG80 hHVQ== X-Forwarded-Encrypted: i=1; AJvYcCUwOR6qhG/TCIcqqiz9pjoFTpF2ZAIvbi2slZsBQw+YyreoW/GmPM/aDNmYzdT1EEDuC9oUxt1+ElKid2U=@vger.kernel.org X-Gm-Message-State: AOJu0YxPeICNqDXSqcKHHuxwB8uhnxHEvS5GYLGOKdRLGnPB7UPQTrCb DtHIbg7rcPn62KdY8gT5IpsWePK8/D0oLggDKSFChjf+K7O1XuxA8Wm+6nLVOq8dvXg= X-Gm-Gg: ASbGncuKpYIWojZ2nV5PgjXLtxK7mEJ9QMFFCaqHxfiMH2QYwy9GxCNPsWTh28hiazJ PLrLerQ9GwFrt1C9fKPMKd8nHz6kICPiyBVG2edRXvBxeyPUX8kSql6o8KmSfbdr28wxgb/KrKv ZKJgi/YbUovYTpVAmWhapEr+AA7lKMMtRfzXvz2dRrMph3I3X/0u1rLSWZjCHZXLcYDn07w88xz wiRIGF5qG2a8MFZ0xujYgS30JU0osvfluPFLYycbDh/VBNBas7uXBvt4/BZ7lkdA5VR7AqhDsMw wBzdIWLEOkH1KosHkRGR/PPRqqY0eWUhXIUgB5NsscKWGWXwP8D4RAzQzPSWO7hPWaTbo8wzSGq kgGDEfOwUaWLuiF4O1zR9x51KoKdJB6o= X-Google-Smtp-Source: AGHT+IFZZ/SClwkyS/5PD0FX0+0seHog/otwGwC9/uLDftMPrJiGWVG1n+A33cLiR0ff/m9sgu3Qog== X-Received: by 2002:a05:600c:35d3:b0:459:da76:d7aa with SMTP id 5b1f17b1804b1-45a1b6758a4mr27865565e9.25.1755187631973; Thu, 14 Aug 2025 09:07:11 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:11 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:49 +0100 Subject: [PATCH 09/13] spi: spi-fsl-lpspi: Parameterize reading num-cs from hardware Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-9-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 To avoid adding more string matching here for every new device, move this property into devtype data. Signed-off-by: James Clark --- drivers/spi/spi-fsl-lpspi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 1013d5c994e9..6d0138b27785 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -97,6 +97,7 @@ static const char * const pincfgs[] =3D { =20 struct fsl_lpspi_devtype_data { bool prescale_err : 1; + bool query_hw_for_num_cs : 1; }; =20 struct lpspi_config { @@ -150,10 +151,12 @@ struct fsl_lpspi_data { */ static const struct fsl_lpspi_devtype_data imx93_lpspi_devtype_data =3D { .prescale_err =3D true, + .query_hw_for_num_cs =3D true, }; =20 static const struct fsl_lpspi_devtype_data imx7ulp_lpspi_devtype_data =3D { .prescale_err =3D false, + .query_hw_for_num_cs =3D false, }; =20 static const struct of_device_id fsl_lpspi_dt_ids[] =3D { @@ -960,7 +963,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev) fsl_lpspi->rxfifosize =3D 1 << ((temp >> 8) & 0x0f); if (of_property_read_u32((&pdev->dev)->of_node, "num-cs", &num_cs)) { - if (of_device_is_compatible(pdev->dev.of_node, "fsl,imx93-spi")) + if (devtype_data->query_hw_for_num_cs) num_cs =3D ((temp >> 16) & 0xf); else num_cs =3D 1; --=20 2.34.1 From nobody Sat Oct 4 15:57:15 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF3C730102A for ; Thu, 14 Aug 2025 16:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187636; cv=none; b=nkvNvQ99ip5iZqbPJ23Q5b6b+ioBER1mBuuftKWFh0MWWnwnkYrKxWDcUgld282yVFYCZvXDobSgWZQ+VisucVsM2zMtY3p9kU3wTgzBbuxJLop6InZ2qFdoI55Tmn+2D/hTjqVBzKjoiMd48wzWEypRus7Y9ktS7+oLBDYA1Dw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187636; c=relaxed/simple; bh=SFon36ABMtRsmD5ilgjDyUKNSBjeuJpo2bI25Qgo1Ko=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=b7vQwVohM9WtDV7688oM1PeGDppxNo+C2Wr+i9668AWdXPKuMxDdpiEObjSw8+tQTs3WQR5XoTIwOvFxUuZl9DVGBXRjY7GXiDvcCQksM/Vck5GgUuIM+Bhw4DQFibcI7WZW8FmzG/3b0xYwASUmA/s3ru/PRGXxG+23GVtCc4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ScnZ+PFe; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ScnZ+PFe" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3b9dc56ff66so599222f8f.1 for ; Thu, 14 Aug 2025 09:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187633; x=1755792433; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VfumknsBYh2IzrO2lYrQcKgYbnTHwmFJ/9yneF90CH0=; b=ScnZ+PFej4bEDz5jrt5paBeDqTfU3Kyjynh1fiNoccfwnZzrqyiE8IjfzCyyMoNft0 Yh9UbkvqwrFgNDmuh4cul4+F66PZjwNxuj+pn6hSrNuTB3fyIBGUQew7XQwqJrSgij2y SxQE1tdRrp9cjPqYanTgxn+AhAZZcwSohXmQrJT0DbuWaFv2qsbcta2joamRhdzSnA3L xGOaiJ1cqoGFVhaYI0FTl7w9z1R1incFngchKy9hIHU63xC8pGwg8aSOsU01ai4v+TG2 8V3rMHP1PA9IzpGKSNIEwKFR/X8jdVlpMvGtViAM43omFIeNLjOzw9JlOBfbfMBsE8no B1tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187633; x=1755792433; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VfumknsBYh2IzrO2lYrQcKgYbnTHwmFJ/9yneF90CH0=; b=ptNkest76MKutbX4WGUqGR8uNtwtL7q0VCyAG/SeVen0B1KVOEjfJK6hG/N28SG+ok ejxVqM2VnjC4+KqKrb2AAUASxnOOoM7VaazY755docnxKsl4wiCZGTOrbjSUC8YQxUSa eXT1kdBif3YNWheky7n3UWM+CUT0MjMoiVc6TaqdXjo6ArC9rDQj2mILAM7cU49+ZBKC hvH4Yq2HQR+nNlYfyFcJrbP3A+NSKYuzPmLEaSzl88BSDpvmyIUCf7/3rYQMqQc89YUO oM51Hdi19Mx/44aOgJac4iR44Ps0/D8hy9QgvLvxMUgpOy+7O/2SLw2NZWoTJFbjOvsZ c36w== X-Forwarded-Encrypted: i=1; AJvYcCWuK4Vr7Kx9Byc1Nx5BKFK2X0SylaJvMonjpqmQLkChJA73JMrmpbI7MHec5Wcbp8rEg9Js6/rNp67bDME=@vger.kernel.org X-Gm-Message-State: AOJu0YwA7lox/ksCYjZuDXDuOCk+XrNmGANYe7TMk9D3IXkhRuqtaLKB xvSPGi/02SewNKuK1+4riqPp38J3myRey8W6KfFHyIDBCKmhhmnVlMZMM8HiwHJMfPs0JyAKtB+ 8r0Zo X-Gm-Gg: ASbGncuv3GKa9qBnGKomwn6FsLp9N1eg877lBy+C4WRTA6AigmBN5JSGkfBhi3Kpdf8 Tzv4UWpsSO+Fy+Li46AkSKfguvprO/92nsCGl3cIvT4y7kbLLo1oLRVrxOiUN/5rM8kqvpMft5J 3XUzBSMMLcFapjpHRN/5haDIgg3f1IwWA7Kr60SIrkvNEQgZRwEqqiIgr8HuuP0SyImHrkWhQl8 PB04SiPVaujP//s3ggUy5LVU+NIDBGBcTruX4HpeR2HFbBOfPCeFJAHlpk3uRSRQ6kJqOS7DVjU x0hMDs+u87atEGglPAGfrxW+GSq6bpvtp6Ew7tpokJ7N1vfaNfT0X3s1X5Z+gfA775v7IWFbr02 hBB6U6VdA+riU3/+ZG6DQoPgzCAxByy7JHW3H7RhGsA== X-Google-Smtp-Source: AGHT+IGmcHiTNvo2snzvvx3pgNCl27xtRPoj1Whp77k0Jwwx8FV68OpPTATGMjohvUNhCC5M4Zx3aA== X-Received: by 2002:a05:6000:24c2:b0:3b7:974d:537b with SMTP id ffacd0b85a97d-3b9fc3597c2mr3324954f8f.35.1755187633092; Thu, 14 Aug 2025 09:07:13 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:12 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:50 +0100 Subject: [PATCH 10/13] spi: spi-fsl-lpspi: Add compatible for S32G Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-10-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 From: Larisa Grigore S32G doesn't have the max prescale erratum and it can query the max number of CS from hardware, so add those settings. Signed-off-by: Larisa Grigore Signed-off-by: Ciprian Marian Costea Signed-off-by: James Clark --- drivers/spi/spi-fsl-lpspi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 6d0138b27785..a4727ca37d90 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -159,9 +159,15 @@ static const struct fsl_lpspi_devtype_data imx7ulp_lps= pi_devtype_data =3D { .query_hw_for_num_cs =3D false, }; =20 +static struct fsl_lpspi_devtype_data s32g_lpspi_devtype_data =3D { + .prescale_err =3D false, + .query_hw_for_num_cs =3D true, +}; + static const struct of_device_id fsl_lpspi_dt_ids[] =3D { { .compatible =3D "fsl,imx7ulp-spi", .data =3D &imx7ulp_lpspi_devtype_dat= a,}, { .compatible =3D "fsl,imx93-spi", .data =3D &imx93_lpspi_devtype_data,}, + { .compatible =3D "nxp,s32g2-lpspi", .data =3D &s32g_lpspi_devtype_data,}, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, fsl_lpspi_dt_ids); --=20 2.34.1 From nobody Sat Oct 4 15:57:15 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10C89254AF0 for ; Thu, 14 Aug 2025 16:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187638; cv=none; b=do8y2UPn32PZ6cqCDiTb2v/ETQRmRYCUgWiAadpx3aMrPXJXsBygy1qTKzaRsdUHeUNqAjK6BV4dZmgzDVRtVe4n81hhbDasMM1txlhcXvPt2pLdYVbwwE+u7cTkVSwz77dWfUcbbz2u3LB6hX8jDjAyKoCrj5m0ek+H4wtRedo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187638; c=relaxed/simple; bh=tuyFNbIZjJIEwYsTvCXnsEW/EVfjfUpA1Tb/WaZ6BA4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y+kp06/hO7zwBDzPpAllFENsQeTREWk/TGe9tPZ0qs0/ZzBxCaS6Azox0kHovjv62C+2gT7z45BRvEBVZl+nDkb0Qc9pZYjXg1G47mtpzlU18EX0kydhC4jZ3PtBjB3MnsYvLAtdPO230z7ilwqLc5QOke9uNE2Tg2n0UPfYwro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=H0p1PYhs; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H0p1PYhs" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-45a1b065d58so7363605e9.1 for ; Thu, 14 Aug 2025 09:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187634; x=1755792434; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TD30mQRry1zYj/pxkKOJqqK6h7OO9d6sUU7HFt4NRSg=; b=H0p1PYhsBp7V+rik+q9YRlAXP3khx0uxMf/1GbHV+MZ42eUCuQcCAUHcC8c46D2+PG xGUwc8fAg8skNctg4zqHvIbfD/9mtv+A82uUWRxTZ96ZZBf0IpN47AtNi6r2NTtArgAk Q7j1QR5RKZqBK6sSWZfWpGNEirQMVUBgqgMJtgT/xZzGkAXFNDrL0YNY5LrKAeo6KwLr hCRCz+ivCRh0eW3PIo1oIoR2JhWyIR7JAdhjpue7y4PTCg0/it7I+3M0rQ05VuKmT5pl un4eDdE/M5DZ/+a+RU5ElfEKUVyqXi+xENGpsnZiphMomhKXrYn/maioLnWigkFirED6 rYzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187634; x=1755792434; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TD30mQRry1zYj/pxkKOJqqK6h7OO9d6sUU7HFt4NRSg=; b=irxu0NK6Md35vBJB81EWMePaVGjHdBMVOCZ+4MTs/J4ocyaNU3rHARk2qJgEx4dN/p nyI6RbdXZ+5N/oCSrzF1oJCjN2J3h11m4/Hx5WnI5S5Tt27480+qQIfYq/tAvp0zKbyJ vluQWggKIrl9PqexREs+S8T6sHRXIpFg1Z+t6arEE/ijCMmtmiw2yt+wMIax+AcQBEB1 LHhOYAylzGz7cZ0fbGi8cbS7AVzsh4rKfRhczn93ve1/AqgtI7PVw/CZG470sG6ZdUmI OcuR+q1oyQ7Cqwojm1RcUArAB4+SKTC+n1AwEjOUF9V503KX2RG6DZGLmnRd/WbIfF2r BlVA== X-Forwarded-Encrypted: i=1; AJvYcCVkPIwusEu8DfgcJO1NoRiq+IpUbSTp+4S6KTm40F5pJ6kkd/WuX3CwKn9ocWYfFFniC5AuqPvckOf/RA4=@vger.kernel.org X-Gm-Message-State: AOJu0YxqRf8j0lrjNEbNNuVUM4tYpoXzDlgUn3tQzmgqhWuvlzFuzhun fOWLGwI4ym/REN/54voydp18B4nw03946BsrNrTLKE/DHr1IMz6gP50eloOl+oo04Y8= X-Gm-Gg: ASbGncsyaShcPZZmEtTCPiQAgtoxAVolptJnHFn+lOQMKI2g6T825itqT+0Emdv/DUO AMhE+mVkADfFDkQ741Ki/SGRZ0GOLGSg3L2yjUMfDf/cjepi9M0Szdc0xcwd4rwxuWAC7O0XA2s efq4r/sC5eggL58ui1iKLTr179Iqq64zQwaVybzQqLC1QZGm/qG/xlO1WsFyQc6CPqepjPdApDE h5z+NWIsL3bSN3S0W2LpAttqv18rPV8SWN7SHC493ORb5Igsye662AFBDIJrEP6fQN5AIwIdghY /y3qFE6AUzE8nWdC6kn9dukFN2tiqD3NAy2lZaRjK+66qXpA7VxHktshoIIOA0ltoG31X5LnzpB 1O7HQ2Dlpi6epp7WqkJupIO3ijIQnLUc= X-Google-Smtp-Source: AGHT+IH3g7Lbg9BD0ijgtIIxDOgR9U2NbTxPGle12zoaibJgP+H7TGUyhDPESpYkX6F/UP8500PcEA== X-Received: by 2002:a05:600c:45cd:b0:459:a1c7:99ad with SMTP id 5b1f17b1804b1-45a1b646924mr27213635e9.22.1755187634247; Thu, 14 Aug 2025 09:07:14 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:13 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:51 +0100 Subject: [PATCH 11/13] dt-bindings: lpspi: Update maximum num-cs value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-11-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 As mentioned in commit f46b06e62c86 ("spi: spi-fsl-lpspi: Read chip-select amount from hardware for i.MX93"), some devices support up to 3 chip selects so update the max value. This isn't a fix or functional change because the devices with 3 chip selects support reading the number of chip selects from hardware, so the value wouldn't have needed to be set here. However the commit states that the DT could be used to overwrite any HW value, so the full range should be supported. This also avoids confusion for any readers about how many chip selects there are. Signed-off-by: James Clark --- Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Doc= umentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml index a65a42ccaafe..ce7bd44ee17e 100644 --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml @@ -64,7 +64,7 @@ properties: description: number of chip selects. minimum: 1 - maximum: 2 + maximum: 3 default: 1 =20 power-domains: --=20 2.34.1 From nobody Sat Oct 4 15:57:15 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EC64302CB8 for ; Thu, 14 Aug 2025 16:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187641; cv=none; b=NNC+7/qaznM7niNN7Psrip4ntfBteBgPwvNwDGkZ895cJTHxRxRsIx14q2bvePWMDh4/2+nSXwYNN0+uKSVZVYrLVtwKgl3G6QTRciw0mhWtqLyqgyfFbxPBpKcy6GBiWFLdJ8xJe5u2iFTQRsW9FPY9Y5nYDQX1Gm/TFtYTSvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187641; c=relaxed/simple; bh=+rq+9BGDr8wJ7iR/RwIfiOewQa5sKFiC9C2659q5u04=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uHJZcHHRybBihOOD+AVSFIlR+HqpgSk5vCscE6ZFUgVZt63VvW9E0LQUiUAWaukM+qCflg3A57MozF9OTAwc6SJPq8ZkboRu4BfpjLv0JZQ4b0+w3RLJQBjp9mO+zCE4uWCEs9lMe8No66zQ/Ryy1VrXqs20n7BnQn6Cjn5syCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IjbXN+IY; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IjbXN+IY" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-45a1b098f43so7599395e9.2 for ; Thu, 14 Aug 2025 09:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187636; x=1755792436; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DdsFgMvzLev3pjfqMcBF4MpZ0JDQWqKgzuICi66wU9g=; b=IjbXN+IYqeYBNZdqhxXrQUSAT7XYY/KjSN25ICMHW/uBv8+Pr9s1+oW8bw+iqj27BU 4ntem6jamDJNDSPdvsoheJavAOW+4Pw3nJr2wPtQ5rqtzXkH82Gyk6Hxn3yfzY+0KHUq LxQeHWl5DlcKg5wCm2PCZq8a7nIeIXvBjKCr202c0jBp/JxaLTeJzEBBSMKYPwiF+rC8 54RL7T2ilR6jSKkUnTACIB1V2KbdwtVNAFHKLymWqa3Ra2ZFRP8q926O/m/CPFj3VuG1 3dhw3dA5Q3dpOh/eyaUFYy5a7WxVg2GDQP7NMYAa25L5Z8JDIG16LdfuSHsyLqg/Rb+r rA8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187636; x=1755792436; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DdsFgMvzLev3pjfqMcBF4MpZ0JDQWqKgzuICi66wU9g=; b=lMo8olaDSpWZ6oZy6tvKvhruW1wmORJ1WEHl5QGZ7KgXt1+EvWcBeXDrKXzg/deQpX m6JbppFGxY5txlCev9H6me8Sx/g20R4FdTgmzZhB6vFnsAF1bwye1FzP0w8jtQpxz6kK /tkLCvMpz9DcDdG81I5w7hij5CW91BR6hqZvy6YUYbxY0qlxFO8WVHQOhuGVFcgL8Vyc glaymoGYbrqMBU9HoTGau5mXeHcDSu/qoPvM4VdNgzLjE/00rEwMeI+i23mxfVx1Cdlj o3+HP8LQIsEUWbq3Xt3Iqf6440FEf0cPinVRFELdplWh6cWHS42L+rBgQAN9Jtx9JsPy CHWQ== X-Forwarded-Encrypted: i=1; AJvYcCU4krfH54/uph4bbSBtIRHusM57q9mKhEBqr9g2d9zCZ1t42gcEFiyhvKaPYCkXOMaV/lfhW4i47NVGF3M=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5mkrUt84VFvEGomWLdtBzyjUxKy4EnpJYRFQ1oK/MsFlOR1Oe JDWKU9nCF7zNZm/5SJ0XbcjYEgcxKrNcPjolL8fp54JPPCLZEYmiLjd7eCDx3tH+SnI= X-Gm-Gg: ASbGncvKu/2o9YYoPb9m9Ytzd60+RYZ9+8sqrBtSmhepnzjzG0dnyGDDcfXYQD431E1 u3rN9u2c4fLaxuBpKsRLvRxQpY8ZuEd/wiN+st70z08pfxLaBrC5k86sUQzC4LodBYL5OtWHer8 XYbKIsfGoaK3PFSQriajnuSQxewe7N+iW2N3s5rgvcDMxGF272qrDpHGorw0qabz/3+bEuNkyN8 0P3682yVht15qrNWNQUofmj0eZYsmtxv1ftiHWCh9toLCYG09AZ6GAuRW9ZELheB3hq4go8rNqG G0t+7TtvDe3qNp/VjFyrxWesJvomDY/B6z8NbPbfgL7v0q3GFBL31HObk0ZiN/i3PiG9SoEZ1y5 cCp9Z7YRCshPGGrg+Z8xeXlBpRR5scsE= X-Google-Smtp-Source: AGHT+IHYk5C7hCYyM8ADnaIqffGtiumP8f9Dmz3RPTAWKY3pFIZH3LXw+Mpypp1GBsMLsBv+UgnJRA== X-Received: by 2002:a05:600c:8b4b:b0:456:1006:5418 with SMTP id 5b1f17b1804b1-45a1b61eaf8mr35450955e9.13.1755187635781; Thu, 14 Aug 2025 09:07:15 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:15 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:52 +0100 Subject: [PATCH 12/13] dt-bindings: lpspi: Document nxp,lpspi-pincfg property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-12-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 Document the two valid pincfg values and the defaults. Although the hardware supports two more values for half-duplex modes, the driver doesn't support them so don't document them. Signed-off-by: James Clark --- Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 14 ++++++++++++= ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Doc= umentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml index ce7bd44ee17e..3f8833911807 100644 --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml @@ -70,6 +70,19 @@ properties: power-domains: maxItems: 1 =20 + nxp,pincfg: + description: + 'Pin configuration value for CFGR1.PINCFG. + - "sin-in-sout-out": SIN is used for input data and SOUT is used f= or + output data + - "sout-in-sin-out": SOUT is used for input data and SIN is used f= or + output data + If no value is specified then the default is "sin-in-sout-out" for h= ost + mode and "sout-in-sin-out" for target mode.' + enum: + - sin-in-sout-out + - sout-in-sin-out + required: - compatible - reg @@ -95,4 +108,5 @@ examples: spi-slave; fsl,spi-only-use-cs1-sel; num-cs =3D <2>; + nxp,pincfg =3D "sout-in-sin-out"; }; --=20 2.34.1 From nobody Sat Oct 4 15:57:15 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A241303CB4 for ; Thu, 14 Aug 2025 16:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187640; cv=none; b=oK7PcWXcCZM6FqaWy+Q3rJi0aZRPf1dSrdBsu/PFjdthH0FVLJxsIce/k2kVUBsY/lHuTOJDOZJ7iRVV3+UUzpU8CAcnagjCvJr19sziLJiFwiJL0ZI4a120coWFuQSUqn77BEm4gxif0noCBiRIIGQFDbXHn7mblYzG8hGaiHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755187640; c=relaxed/simple; bh=1ZN/hBU5KFnWEm5a5v90vlczlCZ4mmlahGdTTa+btSo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M1p6+NbxXHsrseQb9tDdSs81CtThpt94h0fnr5+xFH7qvVTKYthfaZkvrDzi3WhOC24B6omNO2htmTLgRVuDPsu39W4odPxbvrfvGHjcPbGzBxmZ9bRGfHgEsRmz2vKWzecXGCMlpGiD+L5FSylX6Na/fxxoeSA26/+09ammncw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MDc5ysOE; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MDc5ysOE" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-45a1b281d25so4763325e9.3 for ; Thu, 14 Aug 2025 09:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755187637; x=1755792437; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6w8t1k0+L73Z3H7zGEQgr6I4vcHFOJ0Mhc+O6mOnc/w=; b=MDc5ysOEPsZpzRLgJeMRCPc62mgSbmRtYz5mn8RCsRC0ZfxWSJxaVLcurIktGTYoXq aHfAeXwv0mGTR+PLepNlQ/yFKudtVkHj6VC6ceWmve5Bh8Jcd0Jf2q8BSnABSwZaAImj fLQ67WN5HktggrpfpcwkDFzdmtrT8Gey5UW5jITC55NtneQ5fTLH8Mbst7vqCJ0x3H7m UAyy6y29IMoU6sp5jDAWBl1fGPCDyGC+l/luneApY3pnri1C7Ys4cQbVnv59CybQuxzH 3MQhmiIwT+fVVpK40pYUOjgHohbCD4/V2nh2xUU4XmrAzk0isM1MdxQA+Z4ivS0B0cLA lgdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755187637; x=1755792437; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6w8t1k0+L73Z3H7zGEQgr6I4vcHFOJ0Mhc+O6mOnc/w=; b=gPj/q+5hbAA+jW/+qM8Agbo/acqNb92y4KpNKaypotYLxYgkjWc0Jb1hYdZOSFKIPL 4wtTffcmI4t/tSTcQl/AlDzl9CBbz2LZRObaKsm5tbKjYC/Gcr24UMqecAyZJqx8046W AxOvUDFKjt4dZ3eMUbGYNcAQNFs/9QPnQQ1sY4ex2vXsolfQptlY1Qq1kTe8XTREzloJ zk/5bCEmxv8qZUA1KFNGwn0r2tAdWGH2vaCKY+pO2+EQ4mK2DR6mOhTmxHk+vfW6+xdm JY36rZnTO0Kwp/FeelW6y1vNHgrcsZ/9D+uep3Xul1YCf9JDpTZnNMarwoe1/vE4DgVf XNNg== X-Forwarded-Encrypted: i=1; AJvYcCWk1wuwW/U5Pk9uZoalOpvx1bf+PO7/Yo/9T2vQMnG6FQz3kIGYkby+nHuN0xmwMgJQlYPjAkU8+H/yTl4=@vger.kernel.org X-Gm-Message-State: AOJu0YyDmDe0D2DSxa2bKqo5FYHi+97A0KV+qLHmjVfFJxpNi9CMBZGv vACtuDdjjUKzgs3BmlLdtHFTpVIBgod+tJx+qOtvAGJczU/obCG83xcirCKGxZFL6uw= X-Gm-Gg: ASbGncvzGAMg4MaISdG1BvDS/ZKeI9XkpsuZb/pxtQ82zOls/lhqC2B8zKXnIeP1dKM SntcHrmsWaf4xLcfyJQZdw0Ep5vWzJHK+MqR6emQOp7VWXPxIY+Rsn7qIX4i7y1nr+oC1KBkXsb Z6kzsl4MedPo3GUg+FSdI8UnsGpyFB9XJEl7Mfti304Lf/65L4/+IZ36G9nR4py3Rmjdun+Y+7V qWkLBMjVjUG9fv9etOotT+FIcJ7LWHyFuGh4zr0Q4ZJLSMPVr7ruT32IUEIruZG8i24RjPWGJYY 3rXZbHlL3fvdLwVpz3gY4rph2WKpxGAz9G7qUDiB+ayiXwHi72Ikx1rNj/vI/IQtI0iTCyyhKSE 5HMGWQnsccW7dS2HLVg8WlObIZyEEgUE= X-Google-Smtp-Source: AGHT+IEZbpliyIDsPb6R0FpfpFlg3UBRXfnKDNpZBswiqyG30cWnXAPOznL3hegH/Ef1DZOEk8/F0Q== X-Received: by 2002:a05:600c:45d0:b0:440:6a79:6df0 with SMTP id 5b1f17b1804b1-45a1b644c34mr26991495e9.22.1755187636941; Thu, 14 Aug 2025 09:07:16 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c6bd172sm28363495e9.6.2025.08.14.09.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 09:07:16 -0700 (PDT) From: James Clark Date: Thu, 14 Aug 2025 17:06:53 +0100 Subject: [PATCH 13/13] dt-bindings: lpspi: Document support for S32G Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250814-james-nxp-lpspi-v1-13-9586d7815d14@linaro.org> References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> In-Reply-To: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> To: Frank Li , Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com Cc: James Clark , linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.0 From: Larisa Grigore S32G2 and S32G3 are currently treated the same way in the driver, so require that S32G3 is always paired with the S32G2 compatible string until there is divergence in the future. Signed-off-by: Larisa Grigore Signed-off-by: James Clark --- Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Doc= umentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml index 3f8833911807..9fc98b0f3428 100644 --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml @@ -20,6 +20,7 @@ properties: - enum: - fsl,imx7ulp-spi - fsl,imx8qxp-spi + - nxp,s32g2-lpspi - items: - enum: - fsl,imx8ulp-spi @@ -27,6 +28,10 @@ properties: - fsl,imx94-spi - fsl,imx95-spi - const: fsl,imx7ulp-spi + - items: + - const: nxp,s32g3-lpspi + - const: nxp,s32g2-lpspi + reg: maxItems: 1 =20 --=20 2.34.1