From nobody Sat Oct 4 17:31:17 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E70822FFDF6; Wed, 13 Aug 2025 18:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755111338; cv=none; b=GsuntJdOPd1ETQEB21twtX8fo9W3aC+mNFU9NZXQhb0Tta67tLTemyLdgLfJKJc36N5MA9KdB2IVsT6GYcVxroWAz9Es90/4m9sdCwVizOKQ12WE8IN3XayzmVf2vZgArXSuMqLs5+5dsD+23cUPNWiuMl/PSiktRItOZGf2WvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755111338; c=relaxed/simple; bh=Ie0dJTj2bMPEL7BIu8nXzt1eyswuKdvb2tJzm4LPZFg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WRewvvmCUVlx+Zf56HYlQEJW4vT1occOgZteLk0S67tP85XeKEIIpWNXZcyLosG9FdYDaI7l8E/GurydeQLfxtMH0jud0dNUIHm2hqgwAlcpcRYbvmOw6k7KVBgq0jiz42DVE8uBBSx3fibKsFvzt3zUYQoDDNGZGeQTS2qujzo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LHBUhWCo; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LHBUhWCo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755111337; x=1786647337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ie0dJTj2bMPEL7BIu8nXzt1eyswuKdvb2tJzm4LPZFg=; b=LHBUhWCom8ASj1ipHWLtj8vb3mHUQ7D9GO1V/qKd2E8gA3vAb9H671ZF HdinYDcrLwHo8Q/hzbFBBTsvB4R3CWKHHsUbQd0+wCkSgOsTgNmBV5AHo 7zlEF/mMnP3B4AFPcf8QOAL7zDbHtIriq7U9hYv0MuNNpbc5YJ+d3dt0C fi6U98tGLOEhw+UwvdJBGoArutoFLgCaafD6dcrORqUJoR6/Hk6VN3Mb6 bblMEj44O3IzuaHcqo4OpbnWH7UrLyBUJ3g24iE0XMS1/oONAUGm+a/rV 3rIzc6UBm3jUyvnRRPOxf7b9Lt1GqX9V2iWhdAg3lM5rS/+A7ucH3wdNj Q==; X-CSE-ConnectionGUID: eRO1q9x0RiKfXYQlmVW6lw== X-CSE-MsgGUID: 8RRThAKrSgG0yx6HZqMkRQ== X-IronPort-AV: E=McAfee;i="6800,10657,11520"; a="56631232" X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="56631232" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2025 11:55:34 -0700 X-CSE-ConnectionGUID: 1mDm1L3VSjqpHghadvmW5g== X-CSE-MsgGUID: w99HVsxyR02p3+7YKoXiRw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="170755036" Received: from spandruv-desk.jf.intel.com ([10.54.75.16]) by fmviesa005.fm.intel.com with ESMTP; 13 Aug 2025 11:55:34 -0700 From: Srinivas Pandruvada To: rafael@kernel.org, daniel.lezcano@linaro.org, lukasz.luba@arm.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Pandruvada Subject: [PATCH 1/5] thermal: intel: int340x: Add support for power slider Date: Wed, 13 Aug 2025 11:55:26 -0700 Message-ID: <20250813185530.635096-2-srinivas.pandruvada@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250813185530.635096-1-srinivas.pandruvada@linux.intel.com> References: <20250813185530.635096-1-srinivas.pandruvada@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for system wide energy performance preference using a SoC slider interface defined via processor thermal PCI device MMIO space. Using Linux platform-profile class API, register a new platform profile. Provide three platform power profile choices: "performance", "balanced" and "low-power". Profile sysfs is located at: /sys/class/platform-profile/platform-profile-* where attribute "name" is presented as "SoC Power Slider". At boot by default the slider is set to balanced mode. This profile is changed by user space based on user preference via power profile daemon or directly writing to the "profile" sysfs attribute. Add a CPU model specific processor thermal device feature PROC_THERMAL_FEATURE_SOC_POWER_SLIDER. When enabled for a CPU model, slider interface is registered. Signed-off-by: Srinivas Pandruvada --- drivers/thermal/intel/int340x_thermal/Kconfig | 1 + .../thermal/intel/int340x_thermal/Makefile | 1 + .../processor_thermal_device.c | 10 + .../processor_thermal_device.h | 4 + .../processor_thermal_soc_slider.c | 171 ++++++++++++++++++ 5 files changed, 187 insertions(+) create mode 100644 drivers/thermal/intel/int340x_thermal/processor_thermal= _soc_slider.c diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/therma= l/intel/int340x_thermal/Kconfig index 4c699f0896b5..4ced7bdcd62c 100644 --- a/drivers/thermal/intel/int340x_thermal/Kconfig +++ b/drivers/thermal/intel/int340x_thermal/Kconfig @@ -12,6 +12,7 @@ config INT340X_THERMAL select ACPI_THERMAL_LIB select INTEL_SOC_DTS_IOSF_CORE select INTEL_TCC + select ACPI_PLATFORM_PROFILE select PROC_THERMAL_MMIO_RAPL if POWERCAP help Newer laptops and tablets that use ACPI may have thermal sensors and diff --git a/drivers/thermal/intel/int340x_thermal/Makefile b/drivers/therm= al/intel/int340x_thermal/Makefile index 184318d1792b..436be34b21a9 100644 --- a/drivers/thermal/intel/int340x_thermal/Makefile +++ b/drivers/thermal/intel/int340x_thermal/Makefile @@ -14,5 +14,6 @@ obj-$(CONFIG_INT340X_THERMAL) +=3D processor_thermal_mbox= .o obj-$(CONFIG_INT340X_THERMAL) +=3D processor_thermal_wt_req.o obj-$(CONFIG_INT340X_THERMAL) +=3D processor_thermal_wt_hint.o obj-$(CONFIG_INT340X_THERMAL) +=3D processor_thermal_power_floor.o +obj-$(CONFIG_INT340X_THERMAL) +=3D processor_thermal_soc_slider.o obj-$(CONFIG_INT3406_THERMAL) +=3D int3406_thermal.o obj-$(CONFIG_ACPI_THERMAL_REL) +=3D acpi_thermal_rel.o diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device= .c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c index 29fcece48cad..4aea5c9baae9 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c @@ -432,8 +432,18 @@ int proc_thermal_mmio_add(struct pci_dev *pdev, } } =20 + if (feature_mask & PROC_THERMAL_FEATURE_SOC_POWER_SLIDER) { + ret =3D proc_thermal_soc_power_slider_add(pdev, proc_priv); + if (ret) { + dev_err(&pdev->dev, "failed to add soc power efficiency slider\n"); + goto err_rem_wlt; + } + } + return 0; =20 +err_rem_wlt: + proc_thermal_wt_hint_remove(pdev); err_rem_rfim: proc_thermal_rfim_remove(pdev); err_rem_ptc: diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device= .h b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.h index 49398794124a..ba3f64742f2f 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.h +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.h @@ -69,6 +69,7 @@ struct rapl_mmio_regs { #define PROC_THERMAL_FEATURE_POWER_FLOOR 0x40 #define PROC_THERMAL_FEATURE_MSI_SUPPORT 0x80 #define PROC_THERMAL_FEATURE_PTC 0x100 +#define PROC_THERMAL_FEATURE_SOC_POWER_SLIDER 0x200 =20 #if IS_ENABLED(CONFIG_PROC_THERMAL_MMIO_RAPL) int proc_thermal_rapl_add(struct pci_dev *pdev, struct proc_thermal_device= *proc_priv); @@ -127,4 +128,7 @@ int proc_thermal_mmio_add(struct pci_dev *pdev, void proc_thermal_mmio_remove(struct pci_dev *pdev, struct proc_thermal_de= vice *proc_priv); int proc_thermal_ptc_add(struct pci_dev *pdev, struct proc_thermal_device = *proc_priv); void proc_thermal_ptc_remove(struct pci_dev *pdev); + +int proc_thermal_soc_power_slider_add(struct pci_dev *pdev, struct proc_th= ermal_device *proc_priv); + #endif diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_sl= ider.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider= .c new file mode 100644 index 000000000000..c492ee937dc7 --- /dev/null +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c @@ -0,0 +1,171 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Processor Thermal Device Interface for Reading and Writing + * SoC Power Slider Values from User Space. + * + * Operation: + * The SOC_EFFICIENCY_SLIDER_0_0_0_MCHBAR register is accessed + * using the MMIO (Memory-Mapped I/O) interface with an MMIO offset of 0x5= B38. + * Although this register is 64 bits wide, only bits 7:0 are used, + * and the other bits remain unchanged. + * + * Bit definitions + * + * Bits 2:0 (Slider value): + * The SoC optimizer slider value indicates the system wide energy perform= ance + * hint. The slider has no specific units and ranges from 0 (highest + * performance) to 6 (highest energy efficiency). Value of 7 is reserved. + * Bits 3 : Reserved + * Bits 6:4 (Offset) + * Offset allows the SoC to automatically switch slider position in range + * [slider value (bits 2:0) + offset] to improve power efficiency based on + * internal SoC algorithms. + * Bit 7 (Enable): + * If this bit is set, the SoC Optimization sliders will be processed by t= he + * SoC firmware. + * + * Copyright (c) 2025, Intel Corporation. + */ + +#include +#include +#include +#include "processor_thermal_device.h" + +#define SOC_POWER_SLIDER_OFFSET 0x5B38 + +enum power_slider_preference { + SOC_POWER_SLIDER_PERFORMANCE, + SOC_POWER_SLIDER_BALANCE, + SOC_POWER_SLIDER_POWERSAVE, +}; + +#define SOC_SLIDER_VALUE_MINIMUM 0x00 +#define SOC_SLIDER_VALUE_MAXIMUM 0x06 +#define SOC_SLIDER_VALUE_BALANCE 0x03 + +static u8 slider_values[] =3D { + [SOC_POWER_SLIDER_PERFORMANCE] =3D SOC_SLIDER_VALUE_MINIMUM, + [SOC_POWER_SLIDER_BALANCE] =3D SOC_SLIDER_VALUE_BALANCE, + [SOC_POWER_SLIDER_POWERSAVE] =3D SOC_SLIDER_VALUE_MAXIMUM, +}; + +/* Convert from platform power profile option to SoC slider value */ +static int convert_profile_to_power_slider(enum platform_profile_option pr= ofile) +{ + switch (profile) { + case PLATFORM_PROFILE_LOW_POWER: + return slider_values[SOC_POWER_SLIDER_POWERSAVE]; + case PLATFORM_PROFILE_BALANCED: + return slider_values[SOC_POWER_SLIDER_BALANCE]; + case PLATFORM_PROFILE_PERFORMANCE: + return slider_values[SOC_POWER_SLIDER_PERFORMANCE]; + default: + return -EOPNOTSUPP; + } + + return -EOPNOTSUPP; +} + +/* Convert to platform power profile option from SoC slider values */ +static int convert_power_slider_to_profile(u8 slider) +{ + if (slider =3D=3D slider_values[SOC_POWER_SLIDER_PERFORMANCE]) + return PLATFORM_PROFILE_PERFORMANCE; + if (slider =3D=3D slider_values[SOC_POWER_SLIDER_BALANCE]) + return PLATFORM_PROFILE_BALANCED; + if (slider =3D=3D slider_values[SOC_POWER_SLIDER_POWERSAVE]) + return PLATFORM_PROFILE_LOW_POWER; + + return -EOPNOTSUPP; +} + +#define SLIDER_MASK GENMASK_ULL(2, 0) +#define SLIDER_ENABLE_BIT 7 + +static void set_soc_power_profile(struct proc_thermal_device *proc_priv, i= nt slider) +{ + u64 val; + + val =3D readq(proc_priv->mmio_base + SOC_POWER_SLIDER_OFFSET); + val &=3D ~SLIDER_MASK; + val |=3D FIELD_PREP(SLIDER_MASK, slider); + val |=3D BIT(SLIDER_ENABLE_BIT); + writeq(val, proc_priv->mmio_base + SOC_POWER_SLIDER_OFFSET); +} + +/* profile get/set callbacks are called with a profile lock, so no need fo= r local locks */ + +static int power_slider_platform_profile_set(struct device *dev, + enum platform_profile_option profile) +{ + struct proc_thermal_device *proc_priv; + int slider; + + proc_priv =3D dev_get_drvdata(dev); + if (!proc_priv) + return -EOPNOTSUPP; + + slider =3D convert_profile_to_power_slider(profile); + if (slider < 0) + return slider; + + set_soc_power_profile(proc_priv, slider); + + return 0; +} + +static int power_slider_platform_profile_get(struct device *dev, + enum platform_profile_option *profile) +{ + struct proc_thermal_device *proc_priv; + int slider, ret; + u64 val; + + proc_priv =3D dev_get_drvdata(dev); + if (!proc_priv) + return -EOPNOTSUPP; + + val =3D readq(proc_priv->mmio_base + SOC_POWER_SLIDER_OFFSET); + slider =3D FIELD_GET(SLIDER_MASK, val); + + ret =3D convert_power_slider_to_profile(slider); + if (ret < 0) + return ret; + + *profile =3D ret; + + return 0; +} + +static int power_slider_platform_profile_probe(void *drvdata, unsigned lon= g *choices) +{ + set_bit(PLATFORM_PROFILE_LOW_POWER, choices); + set_bit(PLATFORM_PROFILE_BALANCED, choices); + set_bit(PLATFORM_PROFILE_PERFORMANCE, choices); + + return 0; +} + +static const struct platform_profile_ops power_slider_platform_profile_ops= =3D { + .probe =3D power_slider_platform_profile_probe, + .profile_get =3D power_slider_platform_profile_get, + .profile_set =3D power_slider_platform_profile_set, +}; + +int proc_thermal_soc_power_slider_add(struct pci_dev *pdev, struct proc_th= ermal_device *proc_priv) +{ + struct device *ppdev; + + set_soc_power_profile(proc_priv, slider_values[SOC_POWER_SLIDER_BALANCE]); + + ppdev =3D devm_platform_profile_register(&pdev->dev, "SoC Power Slider", = proc_priv, + &power_slider_platform_profile_ops); + + return PTR_ERR_OR_ZERO(ppdev); +} +EXPORT_SYMBOL_NS_GPL(proc_thermal_soc_power_slider_add, "INT340X_THERMAL"); + +MODULE_IMPORT_NS("INT340X_THERMAL"); +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Processor Thermal Power Slider Interface"); --=20 2.43.0 From nobody Sat Oct 4 17:31:17 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75F342FF15E; Wed, 13 Aug 2025 18:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755111338; cv=none; b=cvCbPRi2Zmqr6lKaqBgUUDdIIQs6IJdOcHmvzW9nMCKb3o6upol96KRs/WOfgAy/PgRGHnGVS8FDeWpdkWQ5Spt5JU0vXw5wWNDvoyiy810W7R3KBrfPKrCDFmnfwQGEistebkXbVA7j7bgiLXHRbu4UMsMUVtxgipMQO4/bSs4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755111338; c=relaxed/simple; bh=kLnHQ3zpn7XOHx9rL75UtBJGklUswj7YH4jIS0oKVIM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=khgNlN60BJAXOKmH1nbBOTeq6lT/7z89PqPtHSqyB9IkQgaXaT4CwkcQgpvti8RzWPadE5SrtEEybZ80tIxapoRrZgBgEWMloAcUDX9oYEluUJjWsXelIeQzJqJqGCYFDf16MwzElClGHH2XxX4hQLwkIC9Lmq/QulQrav+2Tmk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ny6o9SDi; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ny6o9SDi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755111337; x=1786647337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kLnHQ3zpn7XOHx9rL75UtBJGklUswj7YH4jIS0oKVIM=; b=Ny6o9SDiyFc3XUCVhbJZRm2YlzgKsjo3h/CcUTY5YX4F/LE+sJlgnUE/ VahxyyAhDfFdZ0mHjXzECY5qb5/1GTaBTh1YTWFt0pTa3PfngWeKIpRqL bEjiiWGhla7XzEpyJUUIZgGZfFZd9wQmy7m/nNBbV58T8M9g1VwYU6JIJ ef1sGUxNu7YBtbO+BZtY+/8WLTw7zm2pmDsxMP8QzGR6cEaW80/pO1zdm DZNrSn4WvT2AuL4eODGqrQwY7bk9ucan9sU/CED+KMVpqXjgr800bPrGc LO75tG9eTCIFMIZ0YUEz1tY0CxaJZsLJ6jJ8iAK32wW+vVFX9wFlxdmQe A==; X-CSE-ConnectionGUID: PcqHpDS/TbGvgeSE0P2Jzg== X-CSE-MsgGUID: Q8LC+t7uRDK6PAmv36pr8w== X-IronPort-AV: E=McAfee;i="6800,10657,11520"; a="56631236" X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="56631236" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2025 11:55:35 -0700 X-CSE-ConnectionGUID: yaHAKAZYQt2/Aq6J6oGC8g== X-CSE-MsgGUID: EuW1ZCQURmyi/4/syNCC/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="170755037" Received: from spandruv-desk.jf.intel.com ([10.54.75.16]) by fmviesa005.fm.intel.com with ESMTP; 13 Aug 2025 11:55:34 -0700 From: Srinivas Pandruvada To: rafael@kernel.org, daniel.lezcano@linaro.org, lukasz.luba@arm.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Pandruvada Subject: [PATCH 2/5] thermal: intel: int340x: Enable power slider interface Date: Wed, 13 Aug 2025 11:55:27 -0700 Message-ID: <20250813185530.635096-3-srinivas.pandruvada@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250813185530.635096-1-srinivas.pandruvada@linux.intel.com> References: <20250813185530.635096-1-srinivas.pandruvada@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Enable power slider interface for Panther Lake. Signed-off-by: Srinivas Pandruvada --- .../intel/int340x_thermal/processor_thermal_device_pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device= _pci.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci= .c index d4d7e8e147d2..e2471768d355 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c @@ -498,7 +498,8 @@ static const struct pci_device_id proc_thermal_pci_ids[= ] =3D { { PCI_DEVICE_DATA(INTEL, PTL_THERMAL, PROC_THERMAL_FEATURE_RAPL | PROC_THERMAL_FEATURE_DLVR | PROC_THERMAL_FEATURE_DVFS | PROC_THERMAL_FEATURE_MSI_SUPPORT | PROC_THERMAL_FEATURE_WT_HINT | - PROC_THERMAL_FEATURE_POWER_FLOOR | PROC_THERMAL_FEATURE_PTC) }, + PROC_THERMAL_FEATURE_POWER_FLOOR | PROC_THERMAL_FEATURE_PTC | + PROC_THERMAL_FEATURE_SOC_POWER_SLIDER) }, { PCI_DEVICE_DATA(INTEL, WCL_THERMAL, PROC_THERMAL_FEATURE_MSI_SUPPORT | PROC_THERMAL_FEATURE_RAPL | PROC_THERMAL_FEATURE_DLVR | PROC_THERMAL_FEATURE_DVFS | PROC_THERMAL_FEATURE_WT_HINT | --=20 2.43.0 From nobody Sat Oct 4 17:31:17 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E70F4302CB4; Wed, 13 Aug 2025 18:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755111338; cv=none; b=BZqBREZ+7vLgpBuS6d96gchtdcBGY2jXXBwX+VMVRsRqaFM0nn4g+FWjIXPvSb9L94xdus39MDyIH2B/nomPtsU7rGLF8yJYkHq97qf1p6GP1KEW4hXfcJoXO4XqwmfbxsJNEOM8NRKoq7FuNyaJc/MHgXscaA0U72Upt/s/ym8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755111338; c=relaxed/simple; bh=U+yATFvwfv8aN0sM1IWxBAe3+5KrxXYsfjmovYr2liQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cw6pVyJjwgpkS42B8X0oSYHUn0IRRLuYqf7SvEDzx6a5RreQuD5cORJiHCN1JWSti7OafTlCK23zX00TSJtur0E++Hh95F9paqASUpG8UdxejVrU1QXm31s77ZDNG8nO1/aZHgZwvW3KQA7CvqZUYk9tCQubye5wHaDZPuh56FE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fMfQ0cL7; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fMfQ0cL7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755111337; x=1786647337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U+yATFvwfv8aN0sM1IWxBAe3+5KrxXYsfjmovYr2liQ=; b=fMfQ0cL7XUhq4FSi55FfRR4T57j6MSxkxOTKOW+j6nbXHZ19zIu8MsEY 2DbkPRWvI8kTeCSKKzzhh1aezkcuZXE3RPyzelwOrqb8e+uAmXEEqmpvx J/YApZdDUMBHhfw5DfUaT75E8Z410tdWFo2mBAbChN95lVs+jMm/1nluM mKs1xpOR2GvJCLNeXH/5FPnZPe0s6oN0J/d2A8KnlB1sinI/SOQD7VDI7 uth8TYjeJWw+Il2yFL1XgE0+0w3d/doTBRw+7MroyCYMBsFuJFf/OLsMD SkiGREmllDouSZ+KqecmF7HQPHzY3t8/6K5skhFTsWLQGnxNOLb3hZhUz Q==; X-CSE-ConnectionGUID: AdUCzdO8SjqAdPSD+SQgzQ== X-CSE-MsgGUID: flVEW/94QhSYQDWgph+zZw== X-IronPort-AV: E=McAfee;i="6800,10657,11520"; a="56631240" X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="56631240" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2025 11:55:35 -0700 X-CSE-ConnectionGUID: NfMtbdWKSyK/ytWVuMsruw== X-CSE-MsgGUID: iu7KVGRdQh6NyxyBjWHjcQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="170755038" Received: from spandruv-desk.jf.intel.com ([10.54.75.16]) by fmviesa005.fm.intel.com with ESMTP; 13 Aug 2025 11:55:34 -0700 From: Srinivas Pandruvada To: rafael@kernel.org, daniel.lezcano@linaro.org, lukasz.luba@arm.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Pandruvada Subject: [PATCH 3/5] thermal: intel: int340x: Add module parameter for balanced Slider Date: Wed, 13 Aug 2025 11:55:28 -0700 Message-ID: <20250813185530.635096-4-srinivas.pandruvada@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250813185530.635096-1-srinivas.pandruvada@linux.intel.com> References: <20250813185530.635096-1-srinivas.pandruvada@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" By default, the SoC slider value for the "balanced" platform profile is set to 3. A new module parameter is introduced to allow users to change this default value. After modifying the module parameter, users must call an update to the "profile" sysfs attribute for the change to take effect. Signed-off-by: Srinivas Pandruvada --- .../processor_thermal_soc_slider.c | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_sl= ider.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider= .c index c492ee937dc7..ffc538c9b9e3 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c @@ -50,6 +50,43 @@ static u8 slider_values[] =3D { [SOC_POWER_SLIDER_POWERSAVE] =3D SOC_SLIDER_VALUE_MAXIMUM, }; =20 +/* Lock to protect module param updates */ +static DEFINE_MUTEX(slider_param_lock); + +static int slider_balanced_param =3D SOC_SLIDER_VALUE_BALANCE; + +static int slider_def_balance_set(const char *arg, const struct kernel_par= am *kp) +{ + u8 slider_val; + int ret; + + guard(mutex)(&slider_param_lock); + + ret =3D kstrtou8(arg, 16, &slider_val); + if (!ret) { + if (slider_val > SOC_SLIDER_VALUE_MAXIMUM) + return -EINVAL; + + slider_balanced_param =3D slider_val; + } + + return ret; +} + +static int slider_def_balance_get(char *buf, const struct kernel_param *kp) +{ + guard(mutex)(&slider_param_lock); + return sysfs_emit(buf, "%02x\n", slider_values[SOC_POWER_SLIDER_BALANCE]); +} + +static const struct kernel_param_ops slider_def_balance_ops =3D { + .set =3D slider_def_balance_set, + .get =3D slider_def_balance_get, +}; + +module_param_cb(slider_balance, &slider_def_balance_ops, NULL, 0644); +MODULE_PARM_DESC(slider_balance, "Set slider default value for balance."); + /* Convert from platform power profile option to SoC slider value */ static int convert_profile_to_power_slider(enum platform_profile_option pr= ofile) { @@ -106,6 +143,10 @@ static int power_slider_platform_profile_set(struct de= vice *dev, if (!proc_priv) return -EOPNOTSUPP; =20 + guard(mutex)(&slider_param_lock); + + slider_values[SOC_POWER_SLIDER_BALANCE] =3D slider_balanced_param; + slider =3D convert_profile_to_power_slider(profile); if (slider < 0) return slider; --=20 2.43.0 From nobody Sat Oct 4 17:31:17 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28153305E00; Wed, 13 Aug 2025 18:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755111339; cv=none; b=o8DaetAPqcniXMxgItv01zIIJeDxD4YDUuTB3pzD5oAjGo+0FWqwGCKA5OEFnSUvC2goZ5CKxxeQbqq6tvpLu0dlf9M/0MhSqQo1xKJvaFT8C1yYdeKZEk6sEO7jsCJW838AoNVk0tH4ohwlHXE/AM8my6vRam2w1XfuuvyMlAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755111339; c=relaxed/simple; bh=MBe+Me2In0xIgcB1VyXX+jo+JmDp0MlroPhu3l7p6Og=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hcixS86WISaoxvF0AtJwMf2YXOjZAIULOy5SD9DhFOEJFdZnSYnK+HTm+FPFy/AKxGpjx1I+l9uCQLjkQoZc4bvGINmOOEji6Es0MyVFBhX5H0Wusn2/+2SSkyfo4HajeUa/bPq7Ttk03Q3DQdr64mTQDfpcTvjUxSfrpVA2TSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ak68hFxT; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ak68hFxT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755111338; x=1786647338; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MBe+Me2In0xIgcB1VyXX+jo+JmDp0MlroPhu3l7p6Og=; b=Ak68hFxTr0HKHAdADAKVb6+2rgEBSJ5ho+PyyoyPZpX2Y5ms89a88Zct taaUJ7NQpapFbeu7zFnBjh+6Gwh00pv9bCGXNmiS7zW3U+NEcyEi5zgJJ DTO2E3CEIixAofE3U6pEP6EhBXypB3QTwhtD2GmY1TEVDVww4aQWmFXHa qi0lEVZga3y79AsPSljTUv7vf9UX7kt67CiEFDw0LF+AiEaJ7CGMQogf+ FQoJVL3lQtNHUoGPNUkMmkY3ux8OkaJ/c6NsEXq3OVMoruY3uPUzampR0 0Xn3d02OuA6qHaky/1agIC3X5GLbkjD4nATqDwdR2pbbxs6H+y9Zoj6pV A==; X-CSE-ConnectionGUID: wKwWvqTeQcWv2Si99tL5dA== X-CSE-MsgGUID: nffhJCKEQPes+BGaqG9BOw== X-IronPort-AV: E=McAfee;i="6800,10657,11520"; a="56631244" X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="56631244" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2025 11:55:35 -0700 X-CSE-ConnectionGUID: s9ZSUkHqS36Xev5UR4k4HA== X-CSE-MsgGUID: WNYlSPPhQUeC+7PaHGe91w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="170755039" Received: from spandruv-desk.jf.intel.com ([10.54.75.16]) by fmviesa005.fm.intel.com with ESMTP; 13 Aug 2025 11:55:35 -0700 From: Srinivas Pandruvada To: rafael@kernel.org, daniel.lezcano@linaro.org, lukasz.luba@arm.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Pandruvada Subject: [PATCH 4/5] thermal: intel: int340x: Add module parameter to change slider offset Date: Wed, 13 Aug 2025 11:55:29 -0700 Message-ID: <20250813185530.635096-5-srinivas.pandruvada@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250813185530.635096-1-srinivas.pandruvada@linux.intel.com> References: <20250813185530.635096-1-srinivas.pandruvada@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The slider offset value allows the SoC to automatically switch slider positions in range [SOC_SLIDER =E2=80=A6 (SOC_SLIDER + slider offset)] base= d on internal algorithms to improve power efficiency. By default, the SoC slider offset is set to 0. This means that SoC is not allowed to switch slider position. Signed-off-by: Srinivas Pandruvada --- .../processor_thermal_soc_slider.c | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_sl= ider.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider= .c index ffc538c9b9e3..bd4ff26a488b 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c @@ -87,6 +87,40 @@ static const struct kernel_param_ops slider_def_balance_= ops =3D { module_param_cb(slider_balance, &slider_def_balance_ops, NULL, 0644); MODULE_PARM_DESC(slider_balance, "Set slider default value for balance."); =20 +static u8 slider_offset; + +static int slider_def_offset_set(const char *arg, const struct kernel_para= m *kp) +{ + u8 offset; + int ret; + + guard(mutex)(&slider_param_lock); + + ret =3D kstrtou8(arg, 16, &offset); + if (!ret) { + if (offset > SOC_SLIDER_VALUE_MAXIMUM) + return -EINVAL; + + slider_offset =3D offset; + } + + return ret; +} + +static int slider_def_offset_get(char *buf, const struct kernel_param *kp) +{ + guard(mutex)(&slider_param_lock); + return sysfs_emit(buf, "%02x\n", slider_offset); +} + +static const struct kernel_param_ops slider_offset_ops =3D { + .set =3D slider_def_offset_set, + .get =3D slider_def_offset_get, +}; + +module_param_cb(slider_offset, &slider_offset_ops, NULL, 0644); +MODULE_PARM_DESC(slider_offset, "Set slider offset."); + /* Convert from platform power profile option to SoC slider value */ static int convert_profile_to_power_slider(enum platform_profile_option pr= ofile) { @@ -120,6 +154,8 @@ static int convert_power_slider_to_profile(u8 slider) #define SLIDER_MASK GENMASK_ULL(2, 0) #define SLIDER_ENABLE_BIT 7 =20 +#define SLIDER_OFFSET_MASK GENMASK_ULL(6, 4) + static void set_soc_power_profile(struct proc_thermal_device *proc_priv, i= nt slider) { u64 val; @@ -128,6 +164,11 @@ static void set_soc_power_profile(struct proc_thermal_= device *proc_priv, int sli val &=3D ~SLIDER_MASK; val |=3D FIELD_PREP(SLIDER_MASK, slider); val |=3D BIT(SLIDER_ENABLE_BIT); + + /* Set the slider offset from module params */ + val &=3D ~SLIDER_OFFSET_MASK; + val |=3D FIELD_PREP(SLIDER_OFFSET_MASK, slider_offset); + writeq(val, proc_priv->mmio_base + SOC_POWER_SLIDER_OFFSET); } =20 --=20 2.43.0 From nobody Sat Oct 4 17:31:17 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3AC7305E1E; Wed, 13 Aug 2025 18:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755111340; cv=none; b=eNCqVohTHY29hE4gdrWI8sxoVRyybW2JKgWQuIXecAPy0ejjZLN/WLO2MDa6sSF9HKZ8Wr/bH0diyTZPPu4xJe5ZfD1tr0W4zp9X2o+s0Gm1Mbax2wLrK6ltr94o/nzrxI6wOSA20uEnlkRXAD9OhvqufMR+GrHSVJbngBzy3ic= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755111340; c=relaxed/simple; bh=ch/o4xVd8lIYnBl2yT/WfH6wbEpaFaYG6SCxK0C0vl8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gdXcQ7s8AALNv2JIeuKdHOWYiXv8D5qqlpu8JqownqWdEbFG92H+ftCs6F1hYA4xJCR81XfTgyyTFs3sWWUBl3R6xTLgGxbozjwXokZj6nygbXh6i+Dz6tiTSiqfHHf/3uqkQajMISuEmbhMjGc2e7Mcbc3GilLph/IFEK/BHAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=D+oSBxtp; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D+oSBxtp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755111339; x=1786647339; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ch/o4xVd8lIYnBl2yT/WfH6wbEpaFaYG6SCxK0C0vl8=; b=D+oSBxtpGnjmYd+Xmm5RkDDjoMflcpaEBPuoWyXvkOpjUdR9VCB8Y7WY YupZAR0WL0s8jBcj2LsJLeN3VMp5WPlPP0yxOuAfL74J1i2whbetNrncn 2sydmeI7EhHlI5qxsdgPcxQc2EKVNWR2GK9kSHIP9FprqympluQ0FhdcG 17eWQIQKosRfORlDSP5QPpsF7LsKRtDQyFAB3ZU2+vt9kS+mUic9jI7K1 vbQ9U+OJaggX64vHXYl9np8TaQRUWERmOgLPJejto/6+Vz+ZFm00iciav VD/V6yoDAsuqyLQdi7bJMEhYe4CtZKBHvmj76J+D3a5gQJMT7Ig0rSqY3 w==; X-CSE-ConnectionGUID: 16Z5I1g/Qn2qgutRdSe1Tw== X-CSE-MsgGUID: UvKg+hZVSIC+7RXTOG4k9w== X-IronPort-AV: E=McAfee;i="6800,10657,11520"; a="56631248" X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="56631248" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2025 11:55:35 -0700 X-CSE-ConnectionGUID: 5McULt/1R8uzckTiEDCrKw== X-CSE-MsgGUID: qX/1ACUpQOaNhZoe4fa5yQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="170755040" Received: from spandruv-desk.jf.intel.com ([10.54.75.16]) by fmviesa005.fm.intel.com with ESMTP; 13 Aug 2025 11:55:35 -0700 From: Srinivas Pandruvada To: rafael@kernel.org, daniel.lezcano@linaro.org, lukasz.luba@arm.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Pandruvada Subject: [PATCH 5/5] thermal: intel: int340x: Add suspend and resume callbacks Date: Wed, 13 Aug 2025 11:55:30 -0700 Message-ID: <20250813185530.635096-6-srinivas.pandruvada@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250813185530.635096-1-srinivas.pandruvada@linux.intel.com> References: <20250813185530.635096-1-srinivas.pandruvada@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During system suspend callback save slider register and restore during resume callback. Signed-off-by: Srinivas Pandruvada --- .../int340x_thermal/processor_thermal_device.c | 10 ++++++++++ .../int340x_thermal/processor_thermal_device.h | 2 ++ .../processor_thermal_soc_slider.c | 15 +++++++++++++++ 3 files changed, 27 insertions(+) diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device= .c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c index 4aea5c9baae9..a772c187bedb 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c @@ -338,10 +338,17 @@ static int tcc_offset_save =3D -1; =20 int proc_thermal_suspend(struct device *dev) { + struct proc_thermal_device *proc_dev; + tcc_offset_save =3D intel_tcc_get_offset(-1); if (tcc_offset_save < 0) dev_warn(dev, "failed to save offset (%d)\n", tcc_offset_save); =20 + proc_dev =3D dev_get_drvdata(dev); + + if (proc_dev->mmio_feature_mask & PROC_THERMAL_FEATURE_SOC_POWER_SLIDER) + proc_thermal_soc_power_slider_suspend(proc_dev); + return 0; } EXPORT_SYMBOL_GPL(proc_thermal_suspend); @@ -357,6 +364,9 @@ int proc_thermal_resume(struct device *dev) if (tcc_offset_save >=3D 0) intel_tcc_set_offset(-1, tcc_offset_save); =20 + if (proc_dev->mmio_feature_mask & PROC_THERMAL_FEATURE_SOC_POWER_SLIDER) + proc_thermal_soc_power_slider_resume(proc_dev); + return 0; } EXPORT_SYMBOL_GPL(proc_thermal_resume); diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device= .h b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.h index ba3f64742f2f..30760475102f 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.h +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.h @@ -130,5 +130,7 @@ int proc_thermal_ptc_add(struct pci_dev *pdev, struct p= roc_thermal_device *proc_ void proc_thermal_ptc_remove(struct pci_dev *pdev); =20 int proc_thermal_soc_power_slider_add(struct pci_dev *pdev, struct proc_th= ermal_device *proc_priv); +void proc_thermal_soc_power_slider_suspend(struct proc_thermal_device *pro= c_priv); +void proc_thermal_soc_power_slider_resume(struct proc_thermal_device *proc= _priv); =20 #endif diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_sl= ider.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider= .c index bd4ff26a488b..268bf9124d95 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c @@ -248,6 +248,21 @@ int proc_thermal_soc_power_slider_add(struct pci_dev *= pdev, struct proc_thermal_ } EXPORT_SYMBOL_NS_GPL(proc_thermal_soc_power_slider_add, "INT340X_THERMAL"); =20 +static u64 soc_slider_save; + +void proc_thermal_soc_power_slider_suspend(struct proc_thermal_device *pro= c_priv) +{ + soc_slider_save =3D readq(proc_priv->mmio_base + SOC_POWER_SLIDER_OFFSET); + +} +EXPORT_SYMBOL_NS_GPL(proc_thermal_soc_power_slider_suspend, "INT340X_THERM= AL"); + +void proc_thermal_soc_power_slider_resume(struct proc_thermal_device *proc= _priv) +{ + writeq(soc_slider_save, proc_priv->mmio_base + SOC_POWER_SLIDER_OFFSET); +} +EXPORT_SYMBOL_NS_GPL(proc_thermal_soc_power_slider_resume, "INT340X_THERMA= L"); + MODULE_IMPORT_NS("INT340X_THERMAL"); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Processor Thermal Power Slider Interface"); --=20 2.43.0