From nobody Sat Oct 4 19:17:41 2025 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22AB72D6605 for ; Wed, 13 Aug 2025 18:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755110840; cv=none; b=uufUNe71rft2wDU5s7gxMizmKVZoXh08ESQWL4pC2cLFdHu8Kn7y+Z9RwkKF+XpY+5gn5TkYuNoF6+nGJVUH+pOgUf4rdhVAi5MnEYUtpDIhFEiGNTr8qvlDEDtvud5VdfaExjcRpwrJ/+0Wel376Z+74LCNeKS9p5ViaEr0+0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755110840; c=relaxed/simple; bh=9JiTzc+nbSzwUTT5LP/gBaUYlsQKrRaibwJd/W957kM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MwSCKFAvORsGGHURDIFvIksecmpsMzIK3NkSQZNcFp938OvkoW6HdHKj0uwSJ4Y7uoP5cwmdFa3wloT/V9LiV0W/YdxNrcxn9jHi4puotPZsKRYAq4uqolsAs/tzYZ/DUU0ZsgnXnw6nfjNDXHgzKPzGkBVv0nA+ZENBVG6e/+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=Gzj/4EEE; arc=none smtp.client-ip=209.85.166.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="Gzj/4EEE" Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-3e56ffcecf0so1516785ab.1 for ; Wed, 13 Aug 2025 11:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1755110837; x=1755715637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RqrSikMFQmlD3ircysZ9Jpg6O9yGDaE8xFduYiDcjjk=; b=Gzj/4EEE5nluUGgAlVDBpCVnfuDv9q/U6KoJGpPoJ3IItLowXEmYhc4fvWHqu7w6PL YzNp/KRnGDhIVs0abp40N9+KFQ+eOV15wv3nJ5jRVzkWDbZTZC+R+SWE4GyiLvUQ9cDm O2dKIsyzzKiZMvwg+xcxqdhgpgeAGfW0sOSxtBZHrIVbaOGhKNcy38g+rVX1FQvSw1Aj sjhE4QdPZd3YbaZXz9mZJ2nmslT6F/v/Wx+Iawq8HITkUvnM7MdrcvcXnc/WGzTa4YBC EQD3n9eZ78aGOqywmRtdbBM7WgY0Jn8B1ielbeGmkYKkUvnWoJGqD+Hwkv122j72RPQs OpRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755110837; x=1755715637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RqrSikMFQmlD3ircysZ9Jpg6O9yGDaE8xFduYiDcjjk=; b=jJSy+FKkIB2/cXoaExMVo2zhU14vv5BFjAS3lQNDCWUzoGcZ0GrS0Volw6b0T/hn9L NZ2zebucccMDQ+GAjGDKEvwj1YsnmH5Ue+gViVNtuzKCqaofPnrH/UW9gBWvY3ENK177 IVdR7ceOpasm0JlKUaPvrBfaC1KMkpZvoaQm/uKCeeHbZZd/CIYzl5ZSUGbyx2ChzJBK 2U5B9zIwumzP3EjtNnWDcgPCZvdCtGWzimBQhEDuQP1SNv25OJ2YezvVOqnEDwNQxGcj ZtHZy926zCCYZveaRHpWPGei4KAPWGFYgvT9Um3b6d+dVzZzl5pzwFXP1xkcfnqm5c8U L4Aw== X-Forwarded-Encrypted: i=1; AJvYcCXqqRcAyR1Pey36KIdVa8qAVRWKN2zGlx/0LmnccTExacr/e4ZCJ4PXkRaijS4NPCgHSDu+T2sRAICgU/U=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj5g5E1aOdD8nfI0zbPismG1WEFKtxMFJ3KdyaAcJTJjxWnJIx Ajq0MAxsv9NDXGx1gCS8gIG/iO1TqS7GMBxblHq15X88Cl+iYivW38fwNydTKf1T59g= X-Gm-Gg: ASbGncv8jdLVwZSS8MHftPHcC8BWCkxE2iuSW7avdMt4BGrE1hEKhvNfMWwj2y8pKjw OoSOCt87xxVUbO2lOYISzxVjdvsrf2jSx5muc1IFdxvZDOv4dFWmrjmfXcFu5CmHGM2PX7aRLNQ rY8MgbFmKnWmGsaebNIblyWL+8EmkGgSCHdaTA210G+BPLYhC3701IaGFFGmcuf1Le+nIZfSYZa dqUHUNMFYYJyJe+SISQohws7ZCScEc45Nd55UK4wbruZGt5/VQ8RxWBGXlZHTcAfWE4jM5SZgwY 6ReJItGrh6f3hHSaU0Fklg/A05k+y/zWMtAlmTc9CmZw5+JhL4QxOigKDjI6K5h/hrjbj9Bm6k2 PmsTCTaDkIV9SxTKqYjpXzozb1w1K3HyQeynJCEK60QqdT//CaLpCcYoJ6hJeA0eO3iPc6yffOQ Ky X-Google-Smtp-Source: AGHT+IFakcubpn5mHTn1JDkWaREv1XsONoVtOusT8QU6x779GX8VBGlCp0xzpJfuBOt06dZoHGIOJA== X-Received: by 2002:a05:6e02:1a0c:b0:3e5:4e4f:65e6 with SMTP id e9e14a558f8ab-3e57087a1bcmr4222795ab.13.1755110837093; Wed, 13 Aug 2025 11:47:17 -0700 (PDT) Received: from zippy.localdomain (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50ae9bd89d7sm3933104173.59.2025.08.13.11.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 11:47:16 -0700 (PDT) From: Alex Elder To: lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, kishon@kernel.org Cc: dlan@gentoo.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de, tglx@linutronix.de, johan+linaro@kernel.org, thippeswamy.havalige@amd.com, namcao@linutronix.de, mayank.rana@oss.qualcomm.com, shradha.t@samsung.com, inochiama@gmail.com, quic_schintav@quicinc.com, fan.ni@samsung.com, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] PCI: spacemit: introduce SpacemiT PCIe host driver Date: Wed, 13 Aug 2025 13:46:59 -0500 Message-ID: <20250813184701.2444372-6-elder@riscstar.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250813184701.2444372-1-elder@riscstar.com> References: <20250813184701.2444372-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce a driver for the PCIe root complex found in the SpacemiT K1 SoC. The hardware is derived from the Synopsys DesignWare PCIe IP. The driver supports three PCIe ports that operate at PCIe v2 transfer rates (5 GT/sec). The first port uses a combo PHY, which may be configured for use for USB 3 instead. Signed-off-by: Alex Elder --- drivers/pci/controller/dwc/Kconfig | 10 + drivers/pci/controller/dwc/Makefile | 1 + drivers/pci/controller/dwc/pcie-k1.c | 355 +++++++++++++++++++++++++++ 3 files changed, 366 insertions(+) create mode 100644 drivers/pci/controller/dwc/pcie-k1.c diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dw= c/Kconfig index ff6b6d9e18ecf..ca5782c041ce8 100644 --- a/drivers/pci/controller/dwc/Kconfig +++ b/drivers/pci/controller/dwc/Kconfig @@ -492,4 +492,14 @@ config PCIE_VISCONTI_HOST Say Y here if you want PCIe controller support on Toshiba Visconti SoC. This driver supports TMPV7708 SoC. =20 +config PCIE_K1 + bool "SpacemiT K1 host mode PCIe controller" + depends on ARCH_SPACEMIT || COMPILE_TEST + depends on PCI && OF && HAS_IOMEM + select PCIE_DW_HOST + default ARCH_SPACEMIT + help + Enables support for the PCIe controller in the K1 SoC operating + in host mode. + endmenu diff --git a/drivers/pci/controller/dwc/Makefile b/drivers/pci/controller/d= wc/Makefile index 6919d27798d13..62d9d4e7dd4d3 100644 --- a/drivers/pci/controller/dwc/Makefile +++ b/drivers/pci/controller/dwc/Makefile @@ -31,6 +31,7 @@ obj-$(CONFIG_PCIE_UNIPHIER) +=3D pcie-uniphier.o obj-$(CONFIG_PCIE_UNIPHIER_EP) +=3D pcie-uniphier-ep.o obj-$(CONFIG_PCIE_VISCONTI_HOST) +=3D pcie-visconti.o obj-$(CONFIG_PCIE_RCAR_GEN4) +=3D pcie-rcar-gen4.o +obj-$(CONFIG_PCIE_K1) +=3D pcie-k1.o =20 # The following drivers are for devices that use the generic ACPI # pci_root.c driver but don't support standard ECAM config access. diff --git a/drivers/pci/controller/dwc/pcie-k1.c b/drivers/pci/controller/= dwc/pcie-k1.c new file mode 100644 index 0000000000000..e9b1df3428d16 --- /dev/null +++ b/drivers/pci/controller/dwc/pcie-k1.c @@ -0,0 +1,355 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * SpacemiT K1 PCIe host driver + * + * Copyright (C) 2025 by RISCstar Solutions Corporation. All rights reser= ved. + * Copyright (c) 2023, spacemit Corporation. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "pcie-designware.h" + +#define K1_PCIE_VENDOR_ID 0x201f +#define K1_PCIE_DEVICE_ID 0x0001 + +/* Offsets and field definitions of link management registers */ + +#define K1_PHY_AHB_IRQ_EN 0x0000 +#define PCIE_INTERRUPT_EN BIT(0) + +#define K1_PHY_AHB_LINK_STS 0x0004 +#define SMLH_LINK_UP BIT(1) +#define RDLH_LINK_UP BIT(12) + +#define INTR_ENABLE 0x0014 +#define MSI_CTRL_INT BIT(11) + +/* Offsets and field definitions for PMU registers */ + +#define PCIE_CLK_RESET_CONTROL 0x0000 +#define LTSSM_EN BIT(6) +#define PCIE_AUX_PWR_DET BIT(9) +#define PCIE_RC_PERST BIT(12) /* 0: PERST# high; 1: low */ +#define APP_HOLD_PHY_RST BIT(30) +#define DEVICE_TYPE_RC BIT(31) /* 0: endpoint; 1: RC */ + +#define PCIE_CONTROL_LOGIC 0x0004 +#define PCIE_SOFT_RESET BIT(0) + +struct k1_pcie { + struct dw_pcie pci; + void __iomem *link; + struct regmap *pmu; + u32 pmu_off; + struct phy *phy; + struct reset_control *global_reset; +}; + +#define to_k1_pcie(dw_pcie) dev_get_drvdata((dw_pcie)->dev) + +static int k1_pcie_toggle_soft_reset(struct k1_pcie *k1) +{ + u32 offset =3D k1->pmu_off + PCIE_CONTROL_LOGIC; + const u32 mask =3D PCIE_SOFT_RESET; + int ret; + + ret =3D regmap_set_bits(k1->pmu, offset, mask); + if (ret) + return ret; + + mdelay(2); + + return regmap_clear_bits(k1->pmu, offset, mask); +} + +/* Enable app clocks, deassert app resets */ +static int k1_pcie_app_enable(struct k1_pcie *k1) +{ + struct dw_pcie *pci =3D &k1->pci; + u32 clock_count; + u32 reset_count; + int ret; + + clock_count =3D ARRAY_SIZE(pci->app_clks); + ret =3D clk_bulk_prepare_enable(clock_count, pci->app_clks); + if (ret) + return ret; + + reset_count =3D ARRAY_SIZE(pci->app_rsts); + ret =3D reset_control_bulk_deassert(reset_count, pci->app_rsts); + if (ret) + goto err_disable_clks; + + ret =3D reset_control_deassert(k1->global_reset); + if (ret) + goto err_assert_resets; + + return 0; + +err_assert_resets: + (void)reset_control_bulk_assert(reset_count, pci->app_rsts); +err_disable_clks: + clk_bulk_disable_unprepare(clock_count, pci->app_clks); + + return ret; +} + +/* Disable app clocks, assert app resets */ +static void k1_pcie_app_disable(struct k1_pcie *k1) +{ + struct dw_pcie *pci =3D &k1->pci; + u32 count; + int ret; + + (void)reset_control_assert(k1->global_reset); + + count =3D ARRAY_SIZE(pci->app_rsts); + ret =3D reset_control_bulk_assert(count, pci->app_rsts); + if (ret) + dev_err(pci->dev, "app reset assert failed (%d)\n", ret); + + count =3D ARRAY_SIZE(pci->app_clks); + clk_bulk_disable_unprepare(count, pci->app_clks); +} + +static int k1_pcie_init(struct dw_pcie_rp *pp) +{ + struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); + struct k1_pcie *k1 =3D to_k1_pcie(pci); + u32 offset; + u32 mask; + int ret; + + ret =3D k1_pcie_toggle_soft_reset(k1); + if (ret) + goto err_app_disable; + + ret =3D k1_pcie_app_enable(k1); + if (ret) + return ret; + + ret =3D phy_init(k1->phy); + if (ret) + goto err_app_disable; + + /* Set the PCI vendor and device ID */ + dw_pcie_dbi_ro_wr_en(pci); + dw_pcie_writew_dbi(pci, PCI_VENDOR_ID, K1_PCIE_VENDOR_ID); + dw_pcie_writew_dbi(pci, PCI_DEVICE_ID, K1_PCIE_DEVICE_ID); + dw_pcie_dbi_ro_wr_dis(pci); + + /* + * Put the port in root complex mode, record that Vaux is present. + * Assert fundamental reset (drive PERST# low). + */ + offset =3D k1->pmu_off + PCIE_CLK_RESET_CONTROL; + mask =3D DEVICE_TYPE_RC | PCIE_AUX_PWR_DET; + mask |=3D PCIE_RC_PERST; + ret =3D regmap_set_bits(k1->pmu, offset, mask); + if (ret) + goto err_phy_exit; + + /* Wait the PCIe-mandated 100 msec before deasserting PERST# */ + mdelay(100); + + ret =3D regmap_clear_bits(k1->pmu, offset, PCIE_RC_PERST); + if (!ret) + return 0; /* Success! */ + +err_phy_exit: + (void)phy_exit(k1->phy); +err_app_disable: + k1_pcie_app_disable(k1); + + return ret; +} + +/* Silently ignore any errors */ +static void k1_pcie_deinit(struct dw_pcie_rp *pp) +{ + struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); + struct k1_pcie *k1 =3D to_k1_pcie(pci); + + /* Re-assert fundamental reset (drive PERST# low) */ + (void)regmap_set_bits(k1->pmu, k1->pmu_off + PCIE_CLK_RESET_CONTROL, + PCIE_RC_PERST); + + (void)phy_exit(k1->phy); + + k1_pcie_app_disable(k1); +} + +static const struct dw_pcie_host_ops k1_pcie_host_ops =3D { + .init =3D k1_pcie_init, + .deinit =3D k1_pcie_deinit, +}; + +static void k1_pcie_enable_interrupts(struct k1_pcie *k1) +{ + void __iomem *virt; + u32 val; + + /* Enable the MSI interrupt */ + writel(MSI_CTRL_INT, k1->link + INTR_ENABLE); + + /* Top-level interrupt enable */ + virt =3D k1->link + K1_PHY_AHB_IRQ_EN; + val =3D readl(virt); + val |=3D PCIE_INTERRUPT_EN; + writel(val, virt); +} + +static void k1_pcie_disable_interrupts(struct k1_pcie *k1) +{ + void __iomem *virt; + u32 val; + + virt =3D k1->link + K1_PHY_AHB_IRQ_EN; + val =3D readl(virt); + val &=3D ~PCIE_INTERRUPT_EN; + writel(val, virt); + + writel(0, k1->link + INTR_ENABLE); +} + +static bool k1_pcie_link_up(struct dw_pcie *pci) +{ + struct k1_pcie *k1 =3D to_k1_pcie(pci); + u32 val; + + val =3D readl(k1->link + K1_PHY_AHB_LINK_STS); + + return (val & RDLH_LINK_UP) && (val & SMLH_LINK_UP); +} + +static int k1_pcie_start_link(struct dw_pcie *pci) +{ + struct k1_pcie *k1 =3D to_k1_pcie(pci); + int ret; + + /* Stop holding the PHY in reset, and enable link training */ + ret =3D regmap_update_bits(k1->pmu, k1->pmu_off + PCIE_CLK_RESET_CONTROL, + APP_HOLD_PHY_RST | LTSSM_EN, LTSSM_EN); + if (ret) + return ret; + + k1_pcie_enable_interrupts(k1); + + return 0; +} + +static void k1_pcie_stop_link(struct dw_pcie *pci) +{ + struct k1_pcie *k1 =3D to_k1_pcie(pci); + int ret; + + k1_pcie_disable_interrupts(k1); + + /* Disable the link and hold the PHY in reset */ + ret =3D regmap_update_bits(k1->pmu, k1->pmu_off + PCIE_CLK_RESET_CONTROL, + APP_HOLD_PHY_RST | LTSSM_EN, APP_HOLD_PHY_RST); + if (ret) + dev_err(pci->dev, "disable LTSSM failed (%d)\n", ret); +} + +static const struct dw_pcie_ops k1_pcie_ops =3D { + .link_up =3D k1_pcie_link_up, + .start_link =3D k1_pcie_start_link, + .stop_link =3D k1_pcie_stop_link, +}; + +static int k1_pcie_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct dw_pcie_rp *pp; + struct dw_pcie *pci; + struct k1_pcie *k1; + int ret; + + k1 =3D devm_kzalloc(dev, sizeof(*k1), GFP_KERNEL); + if (!k1) + return -ENOMEM; + dev_set_drvdata(dev, k1); + + k1->pmu =3D syscon_regmap_lookup_by_phandle_args(dev_of_node(dev), + "spacemit,syscon-pmu", + 1, &k1->pmu_off); + if (IS_ERR(k1->pmu)) + return dev_err_probe(dev, PTR_ERR(k1->pmu), + "lookup PMU regmap failed\n"); + + k1->link =3D devm_platform_ioremap_resource_byname(pdev, "link"); + if (!k1->link) + return dev_err_probe(dev, -ENOMEM, "map link regs failed\n"); + + k1->global_reset =3D devm_reset_control_get_shared(dev, "global"); + if (IS_ERR(k1->global_reset)) + return dev_err_probe(dev, PTR_ERR(k1->global_reset), + "get global reset failed\n"); + + /* Hold the PHY in reset until we start the link */ + ret =3D regmap_set_bits(k1->pmu, k1->pmu_off + PCIE_CLK_RESET_CONTROL, + APP_HOLD_PHY_RST); + if (ret) + return dev_err_probe(dev, ret, "hold PHY in reset failed\n"); + + k1->phy =3D devm_phy_get(dev, NULL); + if (IS_ERR(k1->phy)) + return dev_err_probe(dev, PTR_ERR(k1->phy), "get PHY failed\n"); + + pci =3D &k1->pci; + dw_pcie_cap_set(pci, REQ_RES); + pci->dev =3D dev; + pci->ops =3D &k1_pcie_ops; + + pp =3D &pci->pp; + pp->num_vectors =3D MAX_MSI_IRQS; + pp->ops =3D &k1_pcie_host_ops; + + ret =3D dw_pcie_host_init(pp); + if (ret) + return dev_err_probe(dev, ret, "host init failed\n"); + + return 0; +} + +static void k1_pcie_remove(struct platform_device *pdev) +{ + struct k1_pcie *k1 =3D dev_get_drvdata(&pdev->dev); + struct dw_pcie_rp *pp =3D &k1->pci.pp; + + dw_pcie_host_deinit(pp); +} + +static const struct of_device_id k1_pcie_of_match_table[] =3D { + { .compatible =3D "spacemit,k1-pcie-rc", }, + { }, +}; + +static struct platform_driver k1_pcie_driver =3D { + .probe =3D k1_pcie_probe, + .remove =3D k1_pcie_remove, + .driver =3D { + .name =3D "k1-dwc-pcie", + .of_match_table =3D k1_pcie_of_match_table, + .suppress_bind_attrs =3D true, + }, +}; +module_platform_driver(k1_pcie_driver); --=20 2.48.1