From nobody Sat Oct 4 19:16:40 2025 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DB6574420; Wed, 13 Aug 2025 10:34:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755081255; cv=none; b=UBF+WdUV/aCPLpb4ZVthzW6vIYojVr+J15ZgIKVUhsBkQ/h2LdnLyiGaAiUr64ut5iF5euYDg/wkXuwchWCE1g76IZgM7iNSUXBinqaF0hDwKthA5wY8KZKv+Mr3NmG35tZNLZRs8/YdDTqYu7a7kgb9MowGaZv654Oqt4D4KsI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755081255; c=relaxed/simple; bh=RdQTeqQB8uoTlU13DhVu51bey3H2cntBXfP/WY0N2a4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G2cEs+OqnYZ9/ymk3CgEkfOqlxTEQ6QB+DCshqiQshgCeYb7PpAbBst2Kym5BOSLT5R6cd3gHY74BNeVi9NNWk1iumxDg4rd/Uaenfail667PMNqHNWGo5szuay2aaF0/w9HvWslhipi4PHXvpKaLo8PjVK0nOOVXSaG/fEFnN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=cgT8KXDs; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="cgT8KXDs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1755081253; x=1786617253; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RdQTeqQB8uoTlU13DhVu51bey3H2cntBXfP/WY0N2a4=; b=cgT8KXDsZdgp7Qk6jRieyswytv+ZJpt9uCc7qm4Rctsff5ENT4T3wj3n N/lHw5tsympIfWG6GgMc7vV+fLOtZbWA0GH4s8dBmZLc2U2G9GUWHt0zI fLZoOb6k7QKGIf8A4ybovEPjuSUlCWsXDW9F95FD1zI3Gd6mnRU9kd9qr vmMNK77ap4PuDbYWeKhtFxSMyD9K5FLFyPVyQpvdKMZCazMHleX2TZfUc Gsr9rZgrm9t/WA8UPA1EwH8NSgbo+t1beo1G8YlCSIJVqAMp7AFUo1vjU tJnf7jpumkcLguUxwawRsl6fS3GvN1qR/2a3lAWkMhTMf7BHTeLRHiyE8 w==; X-CSE-ConnectionGUID: 7pl1KfoDRtWRHbFbwqg1xg== X-CSE-MsgGUID: 02vxkrFKRsK/KyyW/r515w== X-IronPort-AV: E=Sophos;i="6.17,285,1747724400"; d="scan'208";a="276535068" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Aug 2025 03:34:13 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Wed, 13 Aug 2025 03:34:07 -0700 Received: from che-ll-i17164.microchip.com (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.44 via Frontend Transport; Wed, 13 Aug 2025 03:34:04 -0700 From: Parthiban Veerasooran To: , , , , CC: , , "Parthiban Veerasooran" Subject: [PATCH net 1/2] microchip: lan865x: fix missing netif_start_queue() call on device open Date: Wed, 13 Aug 2025 16:03:54 +0530 Message-ID: <20250813103355.70838-2-parthiban.veerasooran@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250813103355.70838-1-parthiban.veerasooran@microchip.com> References: <20250813103355.70838-1-parthiban.veerasooran@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This fixes an issue where the transmit queue is started implicitly only the very first time the device is registered. When the device is taken down and brought back up again (using `ip` or `ifconfig`), the transmit queue is not restarted, causing packet transmission to hang. Adding an explicit call to netif_start_queue() in lan865x_net_open() ensures the transmit queue is properly started every time the device is reopened. Fixes: 5cd2340cb6a3 ("microchip: lan865x: add driver support for Microchip'= s LAN865X MAC-PHY") Signed-off-by: Parthiban Veerasooran --- drivers/net/ethernet/microchip/lan865x/lan865x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/microchip/lan865x/lan865x.c b/drivers/net= /ethernet/microchip/lan865x/lan865x.c index dd436bdff0f8..d03f5a8de58d 100644 --- a/drivers/net/ethernet/microchip/lan865x/lan865x.c +++ b/drivers/net/ethernet/microchip/lan865x/lan865x.c @@ -311,6 +311,8 @@ static int lan865x_net_open(struct net_device *netdev) =20 phy_start(netdev->phydev); =20 + netif_start_queue(netdev); + return 0; } =20 --=20 2.34.1 From nobody Sat Oct 4 19:16:40 2025 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 203582F49F3; Wed, 13 Aug 2025 10:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755081256; cv=none; b=p6vDlcnF5f6XxwEyn4L1txykGXo4FkjK86RGf6Q5FIXmfs5+VjoHuX3ggkcmVzEs1eggZ6JYPV42vUAxwQiButEM9J3olFXHjwH6iY0mUyXuJxW8DNgmnEan8NC1gi2lTylSgjC2kXk78mjJ2+zwumTdsEkNtz1W7H3miSfrMyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755081256; c=relaxed/simple; bh=4M4WTr7aDG7m7x4izcfAcsDMik6L9YC6njBc54p0N+c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cHbxmMQgPDVAolJJgkx5FI6vEV8jcOEgR7hohciUVUyjeBS/2WHl1b2wLKTcJQOnQha56EGtFTyIZo7hAoXvItsm7/ULvRiYD3J/iW7Yl0QHqIarNGdqgr3On3uPkS5mpaCw7/xpAQzQaq5gMTEGarUj2/XkQRI+evmpbJqKk5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=kyBOcDDu; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="kyBOcDDu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1755081255; x=1786617255; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4M4WTr7aDG7m7x4izcfAcsDMik6L9YC6njBc54p0N+c=; b=kyBOcDDufpfOiQ5JTdz4/fkb3JwioI5bxRE3Q3D1G0j9fxVEnVPcSm+D dxyLrAshgfoKUGNohVK2CmSbvpYTjQFPQsDxA93Tb41UmVlXlP/Q5I872 zCEryMh2NXUDW2VnadsC9JjKPQspnI9+IbNWJM5AfAKH3m8/zfvS4NKa0 3kx1sUegh1h29CYlPvsKxqO8x1sIZHZKRzA8FLmdT2io0IHo5HUSXladd KkwkbNTRfC6E1JeKQ/i79Ovqz+bwrfGsu8q3EOTkHClhUVIaRA0cWM7R8 M8p224FNgHfi1z9u5zujP7njz0yIpP0zqYkYQxXWIDPr4mpMU/fCsA6Uw g==; X-CSE-ConnectionGUID: 7pl1KfoDRtWRHbFbwqg1xg== X-CSE-MsgGUID: IP/Mkq3KR1yKKoEIgpPfjw== X-IronPort-AV: E=Sophos;i="6.17,285,1747724400"; d="scan'208";a="276535070" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Aug 2025 03:34:13 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Wed, 13 Aug 2025 03:34:10 -0700 Received: from che-ll-i17164.microchip.com (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.44 via Frontend Transport; Wed, 13 Aug 2025 03:34:07 -0700 From: Parthiban Veerasooran To: , , , , CC: , , "Parthiban Veerasooran" Subject: [PATCH net 2/2] microchip: lan865x: fix missing configuration for Rev.B0/B1 as per AN1760 Date: Wed, 13 Aug 2025 16:03:55 +0530 Message-ID: <20250813103355.70838-3-parthiban.veerasooran@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250813103355.70838-1-parthiban.veerasooran@microchip.com> References: <20250813103355.70838-1-parthiban.veerasooran@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix missing configuration required for LAN865x silicon revisions B0 and B1, as documented in Microchip Application Note AN1760 (Revision F, June 2024). According to the guidance in the application note, register 0x10077 must be programmed with the value 0x0028 to ensure correct operation on Rev.B0/B1 devices. Without this fixup, the device may not function correctly or may fail to initialize. Reference: https://www.microchip.com/en-us/application-notes/an1760 Fixes: 5cd2340cb6a3 ("microchip: lan865x: add driver support for Microchip'= s LAN865X MAC-PHY") Signed-off-by: Parthiban Veerasooran --- drivers/net/ethernet/microchip/lan865x/lan865x.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/net/ethernet/microchip/lan865x/lan865x.c b/drivers/net= /ethernet/microchip/lan865x/lan865x.c index d03f5a8de58d..a55ca485062f 100644 --- a/drivers/net/ethernet/microchip/lan865x/lan865x.c +++ b/drivers/net/ethernet/microchip/lan865x/lan865x.c @@ -32,6 +32,14 @@ /* MAC Specific Addr 1 Top Reg */ #define LAN865X_REG_MAC_H_SADDR1 0x00010023 =20 +/* LAN865x Rev.B0/B1 configuration parameters from AN1760 + * As per the Configuration Application Note AN1760 published in the below= link, + * https://www.microchip.com/en-us/application-notes/an1760 + * Revision F (DS60001760G - June 2024) + */ +#define LAN865X_REG_FIXUP 0x00010077 +#define LAN865X_FIXUP_VALUE 0x0028 + struct lan865x_priv { struct work_struct multicast_work; struct net_device *netdev; @@ -346,6 +354,14 @@ static int lan865x_probe(struct spi_device *spi) goto free_netdev; } =20 + /* LAN8650/1 configuration fixup from AN1760 */ + ret =3D oa_tc6_write_register(priv->tc6, LAN865X_REG_FIXUP, + LAN865X_FIXUP_VALUE); + if (ret) { + dev_err(&spi->dev, "Failed to configure fixup: %d\n", ret); + goto oa_tc6_exit; + } + /* As per the point s3 in the below errata, SPI receive Ethernet frame * transfer may halt when starting the next frame in the same data block * (chunk) as the end of a previous frame. The RFA field should be --=20 2.34.1