From nobody Sun Dec 14 01:41:04 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34EFF2BEFFF for ; Wed, 13 Aug 2025 06:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755066101; cv=none; b=OKTqQMCNpW/MWlz87zavZLRwf8t0VWpocijbXzS8Eh3ndtfsIyBj+n6Lx2NOdD+aEKtVaJIXx0DnT6Zx/v48j/W/qTmflr8fqVvQsVIOvRtcHcDjahU265ALVpvAienmN1Va5T/QZFnbpzAQH3kiNOP2h7EtBfBzO9IOjOln58s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755066101; c=relaxed/simple; bh=9lXBpt4mIMT6d2TGJJvZMhjb/fpze1Qddkv0CbIjggs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lkNewr4TJv3ZIUlVCGmYdZa+Mhv9wKiWQusIxOtT3yUPGRjtYnn7fIi4JpQnHHN9X8LwPHJ789Qouffge5gDmp8df8IbAprRIOkVxm+6NY2nje5rhLb7kXBJYS/l/+2bMVfJQP/thqSrEnDG3iBFc+NekgQC7D7cGgN5qwG1GzM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bAxeC1GP; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bAxeC1GP" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-76bee58e01cso7429495b3a.1 for ; Tue, 12 Aug 2025 23:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755066099; x=1755670899; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9ST3OBHUDmupawOhRPYNVodoxTLlNYfnl/2sDqaHKqM=; b=bAxeC1GP5Dm0TrZM583FtAZ+A0qVnlIeDT3S5qQewa4s+RHCqEkXMtd7PfYzMtfEjr 0+doA9KiPm0foIbYTvy8F8WYGJWuPjBAATv4iYucq8YHXdHkV7AhABgHQrFWVf9HQMUX SKChZw49ZavPaUNpMXS2tpscGWgf9Mkh9UCYi3GjQHaI2a1EL4hIchgrG96wALpnXixv exG/FhtZ5IpokS4oNAsU5NsXO4jtcwvSs+PEzn+xyIsbATNFToJDq3zWncmRCDxsalck xSIBbV1VhAbiUt6QpOlkBnHuyZuOvB0ewsiw1dmDQeVvEaMc3JBE5udNOu2CqsnA7G30 Tq3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755066099; x=1755670899; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9ST3OBHUDmupawOhRPYNVodoxTLlNYfnl/2sDqaHKqM=; b=LJ4jRD5++bkZFUBS0jvmUcAVDLYx1Mb5Y41uLcLG1miSmw+bbB7azWHX5NDD3++Phe l4oSXm+C8s8v9I0hbN5xrXENYA96JL1WLTKdyEYAEFvAmNYwl9SU/TRTg/E4XMTY+Bom cn0NychKMjXa/JfTXhaHWUzKw60U3aDLd7J9B3SweddNMQo/WroHnTpnsa6kiisuZ93v K9wD08uIFG6oDWMaef53PrDc1K2qstyRqbjN3X/FKoA/vxlEPFsXdFHnoPnYgKddF39M FwD1Ic8Fmephuo9GmZbP6XZfHONjq5F9eJBnSKkLDJbVHLxBQyMOxHF/YY6DAbeEyRdn XHVg== X-Forwarded-Encrypted: i=1; AJvYcCXgW98J7Hy0JBxp4Nbsm9Bdbk+dL1gscpWmrFec9xXFMkpdb4l7IOvzByUyKeDpNpjT3w9jir1NBh7oVUk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2O+kRajj8o3cBGj+/iqSe6YAjSJK4oMHPLTs17VSVClxmWfHO ck6Qj3+nDlnJFoqIWAmsfsjJmuKr2DLDjJrwxtcuV+XWE70fdwfzK/zS X-Gm-Gg: ASbGnctce7L50rNaZmVd+sGpSwJnH7ex/luV6viFwtGjYtW1IlFr6Ph0ex/7fGyL826 F746REGYab+FqbfCrmRGv3USMVu1w3iSvaD0nzRXAxvH8uXZL0BLTOSzc6HY9nUZmlmVcPgbT8K FH2n7YIFwY9k8p6LnT/d5mTuMOGHfcAAumTIWx2Rjp+zvE+YDUWs+6oaaB/Y1v2+gzrCFaS8Dc8 +Ck3wFa3OBTVAk1PIrRh91+0MuQS6Kyh/vWYLMTOJUgVRRHWpQ+Q6riSsJ0pAqe4OdM63idhmC6 LLkFbRH1ygsrz1gORcfn9cPNARVItwd7cIlNPa5IB3iQ/y8RGrfkF/U9D/CYylOXevFiYppIhWm w2qiqexvcRLoHvYebWbY= X-Google-Smtp-Source: AGHT+IEcTztVLi+UwZHZ0a2lGY69Y011yXfIdJLL6J3nKQcw2Coh7E6JYmUMTFdAFtBh6CYhcaokWw== X-Received: by 2002:a05:6a20:244b:b0:240:7ed:402b with SMTP id adf61e73a8af0-240a8b76ba5mr3616066637.33.1755066099386; Tue, 12 Aug 2025 23:21:39 -0700 (PDT) Received: from Terra ([2001:df0:b240:417c:391a:2d23:2970:dee9]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bcce89132sm31303296b3a.29.2025.08.12.23.21.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 23:21:39 -0700 (PDT) From: Athul Raj Kollareth To: airlied@redhat.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, gurchetansingh@chromium.org Cc: Athul Raj Kollareth , dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] drm/virtio: clean up minor codestyle issues Date: Wed, 13 Aug 2025 11:51:05 +0530 Message-ID: <20250813062109.5326-1-krathul3152@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix codestyle warnings and errors generated by CHECKPATCH in virtio source files. Signed-off-by: Athul Raj Kollareth --- drivers/gpu/drm/virtio/virtgpu_display.c | 3 +-- drivers/gpu/drm/virtio/virtgpu_kms.c | 20 ++++++++++---------- drivers/gpu/drm/virtio/virtgpu_object.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_plane.c | 2 +- drivers/gpu/drm/virtio/virtgpu_vq.c | 2 ++ 5 files changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/vir= tio/virtgpu_display.c index e5805ca646c7..c3315935d8bc 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -131,9 +131,8 @@ static void virtio_gpu_crtc_atomic_flush(struct drm_crt= c *crtc, * in the plane update callback, and here we just check * whenever we must force the modeset. */ - if (drm_atomic_crtc_needs_modeset(crtc_state)) { + if (drm_atomic_crtc_needs_modeset(crtc_state)) output->needs_modeset =3D true; - } } =20 static const struct drm_crtc_helper_funcs virtio_gpu_crtc_helper_funcs =3D= { diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/= virtgpu_kms.c index 7dfb2006c561..1c15cbf326b7 100644 --- a/drivers/gpu/drm/virtio/virtgpu_kms.c +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c @@ -162,18 +162,18 @@ int virtio_gpu_init(struct virtio_device *vdev, struc= t drm_device *dev) if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_VIRGL)) vgdev->has_virgl_3d =3D true; #endif - if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_EDID)) { + if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_EDID)) vgdev->has_edid =3D true; - } - if (virtio_has_feature(vgdev->vdev, VIRTIO_RING_F_INDIRECT_DESC)) { + + if (virtio_has_feature(vgdev->vdev, VIRTIO_RING_F_INDIRECT_DESC)) vgdev->has_indirect =3D true; - } - if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_RESOURCE_UUID)) { + + if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_RESOURCE_UUID)) vgdev->has_resource_assign_uuid =3D true; - } - if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_RESOURCE_BLOB)) { + + if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_RESOURCE_BLOB)) vgdev->has_resource_blob =3D true; - } + if (virtio_get_shm_region(vgdev->vdev, &vgdev->host_visible_region, VIRTIO_GPU_SHM_ID_HOST_VISIBLE)) { if (!devm_request_mem_region(&vgdev->vdev->dev, @@ -193,9 +193,9 @@ int virtio_gpu_init(struct virtio_device *vdev, struct = drm_device *dev) (unsigned long)vgdev->host_visible_region.addr, (unsigned long)vgdev->host_visible_region.len); } - if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_CONTEXT_INIT)) { + + if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_CONTEXT_INIT)) vgdev->has_context_init =3D true; - } =20 DRM_INFO("features: %cvirgl %cedid %cresource_blob %chost_visible", vgdev->has_virgl_3d ? '+' : '-', diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virt= io/virtgpu_object.c index 5517cff8715c..e6363c887500 100644 --- a/drivers/gpu/drm/virtio/virtgpu_object.c +++ b/drivers/gpu/drm/virtio/virtgpu_object.c @@ -47,6 +47,7 @@ int virtio_gpu_resource_id_get(struct virtio_gpu_device *= vgdev, uint32_t *resid) *resid =3D handle + 1; } else { int handle =3D ida_alloc(&vgdev->resource_ida, GFP_KERNEL); + if (handle < 0) return handle; *resid =3D handle + 1; @@ -56,9 +57,8 @@ int virtio_gpu_resource_id_get(struct virtio_gpu_device *= vgdev, uint32_t *resid) =20 static void virtio_gpu_resource_id_put(struct virtio_gpu_device *vgdev, ui= nt32_t id) { - if (!virtio_gpu_virglrenderer_workaround) { + if (!virtio_gpu_virglrenderer_workaround) ida_free(&vgdev->resource_ida, id - 1); - } } =20 void virtio_gpu_cleanup_object(struct virtio_gpu_object *bo) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virti= o/virtgpu_plane.c index 698ea7adb951..29e4b458ae57 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c @@ -120,7 +120,7 @@ static int virtio_gpu_plane_atomic_check(struct drm_pla= ne *plane, crtc_state =3D drm_atomic_get_crtc_state(state, new_plane_state->crtc); if (IS_ERR(crtc_state)) - return PTR_ERR(crtc_state); + return PTR_ERR(crtc_state); =20 ret =3D drm_atomic_helper_check_plane_state(new_plane_state, crtc_state, DRM_PLANE_NO_SCALING, diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/v= irtgpu_vq.c index 55a15e247dd1..8181b22b9b46 100644 --- a/drivers/gpu/drm/virtio/virtgpu_vq.c +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c @@ -248,6 +248,7 @@ void virtio_gpu_dequeue_ctrl_func(struct work_struct *w= ork) if (resp->type !=3D cpu_to_le32(VIRTIO_GPU_RESP_OK_NODATA)) { if (le32_to_cpu(resp->type) >=3D VIRTIO_GPU_RESP_ERR_UNSPEC) { struct virtio_gpu_ctrl_hdr *cmd; + cmd =3D virtio_gpu_vbuf_ctrl_hdr(entry); DRM_ERROR_RATELIMITED("response 0x%x (command 0x%x)\n", le32_to_cpu(resp->type), @@ -468,6 +469,7 @@ static int virtio_gpu_queue_fenced_ctrl_buffer(struct v= irtio_gpu_device *vgdev, if (vbuf->data_size) { if (is_vmalloc_addr(vbuf->data_buf)) { int sg_ents; + sgt =3D vmalloc_to_sgt(vbuf->data_buf, vbuf->data_size, &sg_ents); if (!sgt) { --=20 2.50.1