From nobody Sat Oct 4 20:54:32 2025 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD35326C3A5; Wed, 13 Aug 2025 02:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755053537; cv=none; b=UZ/Y2mqPasFlXQ51y7o/KSoj4IZCFAVUJZs/jJUF87IfIwLKPIEwW8urrarwUFL3HNdu8Jp1nuZpEmcJmqnrVRGM8g94G1KIRjv90XYhNkGOaTIans6nM9Q/7jt2sTAQGRz/sJ+4gVvrCjbyAjDjJX+N0rqw3xGFlKdB/qv2VZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755053537; c=relaxed/simple; bh=pWPtEhrfKrsC9K7/YtHpy6pZ1rJYAEdnHYMeXUEPRCk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kdS8mKVcGPN5TFlW6dMvHyG4vCcNO7Y6gHdqakTRV+NQG0JD5yeBlW0XSA/8E6PQrnfG/ujXWxOuTCN42CadqrvzyzbqgGPqAqsnxKge8VCXR5N2S5Be+6mKsKefG2NNxrpXXb7134Nu4GrpiavqV3iJFjg0zX1/VQK+rSTRJpE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4c1tFV5qpyzYQtHM; Wed, 13 Aug 2025 10:52:14 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 6A0CF1A1562; Wed, 13 Aug 2025 10:52:13 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgBHwhLQ_ZtoAscBDg--.14424S5; Wed, 13 Aug 2025 10:52:13 +0800 (CST) From: Zhang Yi To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@lists.linux.dev, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, hch@lst.de, tytso@mit.edu, djwong@kernel.org, bmarzins@redhat.com, chaitanyak@nvidia.com, shinichiro.kawasaki@wdc.com, brauner@kernel.org, martin.petersen@oracle.com, yi.zhang@huawei.com, yi.zhang@huaweicloud.com, chengzhihao1@huawei.com, yukuai3@huawei.com, yangerkun@huawei.com Subject: [PATCH blktests v2 1/3] scsi/010: add unmap write zeroes tests Date: Wed, 13 Aug 2025 10:44:19 +0800 Message-Id: <20250813024421.2507446-2-yi.zhang@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250813024421.2507446-1-yi.zhang@huaweicloud.com> References: <20250813024421.2507446-1-yi.zhang@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: gCh0CgBHwhLQ_ZtoAscBDg--.14424S5 X-Coremail-Antispam: 1UD129KBjvJXoWxAF13tFy3tr43Ww1kXrWfuFg_yoWrArW3pr y0kFZYgrW8XrsrJrs5Cay7Wr13AanYyry7Way7Jryj93ykZr17urs7KFWjqa1fGryfCw40 qay5XFWSkr1Dt37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUmmb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUGw A2048vs2IY020Ec7CjxVAFwI0_Gr0_Xr1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV W8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMc Ij6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_ Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I 0E8cxan2IY04v7MxkF7I0En4kS14v26r4a6rW5MxAIw28IcxkI7VAKI48JMxC20s026xCa FVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_Jr Wlx4CE17CEb7AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j 6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r 1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1U YxBIdaVFxhVjvjDU0xZFpf9x0piRRR_UUUUU= X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ Content-Type: text/plain; charset="utf-8" From: Zhang Yi Test block device unmap write zeroes sysfs interface with various SCSI debug devices. /sys/block//queue/write_zeroes_unmap_max_hw_bytes should equal to the write_zeroes_max_bytes if the SCSI device enable the WRITE SAME command with unmap functionality, and it should return 0 otherwise. /sys/block//queue/write_zeroes_unmap_max_bytes should be equal to write_zeroes_unmap_max_hw_bytes by default, and we can disable write zeroes support by setting it to zero. Signed-off-by: Zhang Yi --- tests/scsi/010 | 84 ++++++++++++++++++++++++++++++++++++++++++++++ tests/scsi/010.out | 2 ++ 2 files changed, 86 insertions(+) create mode 100755 tests/scsi/010 create mode 100644 tests/scsi/010.out diff --git a/tests/scsi/010 b/tests/scsi/010 new file mode 100755 index 0000000..c5152a4 --- /dev/null +++ b/tests/scsi/010 @@ -0,0 +1,84 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-3.0+ +# Copyright (C) 2025 Huawei. +# +# Test block device unmap write zeroes sysfs interface with various scsi +# devices. + +. tests/scsi/rc +. common/scsi_debug + +DESCRIPTION=3D"test unmap write zeroes sysfs interface with scsi devices" +QUICK=3D1 + +requires() { + _have_scsi_debug +} + +setup_test_device() { + if ! _configure_scsi_debug "$@"; then + return 1 + fi + + if [[ ! -f /sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_m= ax_hw_bytes ]]; then + _exit_scsi_debug + SKIP_REASONS+=3D("kernel does not support unmap write zeroes sysfs inter= face") + return 1 + fi +} + +test() { + echo "Running ${TEST_NAME}" + + # disable WRITE SAME with unmap + if ! setup_test_device lbprz=3D0; then + return 1 + fi + + umap_hw_bytes=3D"$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_z= eroes_unmap_max_hw_bytes")" + umap_bytes=3D"$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zero= es_unmap_max_bytes")" + if [[ $umap_hw_bytes -ne 0 || $umap_bytes -ne 0 ]]; then + echo "Test disable WRITE SAME with unmap failed." + fi + _exit_scsi_debug + + # enable WRITE SAME(16) with unmap + if ! setup_test_device lbprz=3D1 lbpws=3D1; then + return 1 + fi + + zero_bytes=3D"$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zero= es_max_bytes")" + umap_hw_bytes=3D"$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_z= eroes_unmap_max_hw_bytes")" + umap_bytes=3D"$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zero= es_unmap_max_bytes")" + if [[ $umap_hw_bytes -ne $zero_bytes || $umap_bytes -ne $zero_bytes ]]; t= hen + echo "Test enable WRITE SAME(16) with unmap failed." + fi + + echo 0 > "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_ma= x_bytes" + umap_bytes=3D"$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zero= es_unmap_max_bytes")" + if [[ $umap_bytes -ne 0 ]]; then + echo "Test manually disable WRITE SAME(16) with unmap failed." + fi + _exit_scsi_debug + + # enable WRITE SAME(10) with unmap + if ! setup_test_device lbprz=3D1 lbpws10=3D1; then + return 1 + fi + + zero_bytes=3D"$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zero= es_max_bytes")" + umap_hw_bytes=3D"$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_z= eroes_unmap_max_hw_bytes")" + umap_bytes=3D"$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zero= es_unmap_max_bytes")" + if [[ $umap_hw_bytes -ne $zero_bytes || $umap_bytes -ne $zero_bytes ]]; t= hen + echo "Test enable WRITE SAME(10) with unmap failed." + fi + + echo 0 > "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_ma= x_bytes" + umap_bytes=3D"$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zero= es_unmap_max_bytes")" + if [[ $umap_bytes -ne 0 ]]; then + echo "Test manually disable WRITE SAME(10) with unmap failed." + fi + _exit_scsi_debug + + echo "Test complete" +} diff --git a/tests/scsi/010.out b/tests/scsi/010.out new file mode 100644 index 0000000..6581d5e --- /dev/null +++ b/tests/scsi/010.out @@ -0,0 +1,2 @@ +Running scsi/010 +Test complete --=20 2.39.2 From nobody Sat Oct 4 20:54:32 2025 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5344B26E140; Wed, 13 Aug 2025 02:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755053538; cv=none; b=COp7cj54SswiV/kO95QpIN9U4tsAHvxbHmgHxx/dPbyImzW5g9UAZOMao7xmgym7FL9mjphg3PrZNFigOkJVbpOvpfnHGTXHgQv9t9IS6CmpziHVED8MMdgggnYd3gXquSDOQcnFqFT+JTDH3yyjvIrhhLYrfJUlDqZk0XPQufc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755053538; c=relaxed/simple; bh=Ng1Ssi6NZ/gTlISD5WEog7sJSA+ksH4LKDz/q7bby0E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gMQXvvVyEocRa05MUN+fQYN0s90oJ2iPJxJhL0XC3XpUa3r3QFMkQ68y+qy3q3vtkWxnhOcRYKhdxD5r+aTfoLRPmWIKKyBrJWlWU3XDPTu39D0Qehq1bF986Rws7Y0twQlhVgoDlGelQ8yOEryIfVxRXHkpuqJPF8BbNlHqJUE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4c1tFV6bkCzKHMdD; Wed, 13 Aug 2025 10:52:14 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 28D581A12BF; Wed, 13 Aug 2025 10:52:14 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgBHwhLQ_ZtoAscBDg--.14424S6; Wed, 13 Aug 2025 10:52:13 +0800 (CST) From: Zhang Yi To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@lists.linux.dev, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, hch@lst.de, tytso@mit.edu, djwong@kernel.org, bmarzins@redhat.com, chaitanyak@nvidia.com, shinichiro.kawasaki@wdc.com, brauner@kernel.org, martin.petersen@oracle.com, yi.zhang@huawei.com, yi.zhang@huaweicloud.com, chengzhihao1@huawei.com, yukuai3@huawei.com, yangerkun@huawei.com Subject: [PATCH blktests v2 2/3] dm/003: add unmap write zeroes tests Date: Wed, 13 Aug 2025 10:44:20 +0800 Message-Id: <20250813024421.2507446-3-yi.zhang@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250813024421.2507446-1-yi.zhang@huaweicloud.com> References: <20250813024421.2507446-1-yi.zhang@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: gCh0CgBHwhLQ_ZtoAscBDg--.14424S6 X-Coremail-Antispam: 1UD129KBjvJXoWxZF1xJFWUZry3Zw17XFy5Arb_yoWrJF1rpa 47CFy5KrWxGFnrWws3Z3W7WF13Aws5ArW3CayxJryj934DXr13WaykKFy2q3Z3GryfCwn5 Aa17ta9Ykr1Uta7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUmY14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_Jryl82xGYIkIc2 x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJw A2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS 0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2 IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0 Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2kIc2 xKxwCY1x0262kKe7AKxVW8ZVWrXwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWU JVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67 kF1VAFwI0_GFv_WrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY 6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42 IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIev Ja73UjIFyTuYvjTRMWlyDUUUU X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ Content-Type: text/plain; charset="utf-8" From: Zhang Yi Test block device unmap write zeroes sysfs interface with device-mapper stacked devices. The sysfs parameters should inherit from the underlying SCSI device. We can disable write zeroes support by setting /sys/block/dm-/queue/write_zeroes_unmap_max_bytes to zero. Signed-off-by: Zhang Yi --- common/rc | 10 ++++++ tests/dm/003 | 86 ++++++++++++++++++++++++++++++++++++++++++++++++ tests/dm/003.out | 2 ++ 3 files changed, 98 insertions(+) create mode 100755 tests/dm/003 create mode 100644 tests/dm/003.out diff --git a/common/rc b/common/rc index dfc389f..bb96a88 100644 --- a/common/rc +++ b/common/rc @@ -668,3 +668,13 @@ _io_uring_restore() echo "$IO_URING_DISABLED" > /proc/sys/kernel/io_uring_disabled fi } + +# get real device path name by following link +_real_dev() +{ + local dev=3D$1 + if [ -b "$dev" ] && [ -L "$dev" ]; then + dev=3D$(readlink -f "$dev") + fi + echo $dev +} diff --git a/tests/dm/003 b/tests/dm/003 new file mode 100755 index 0000000..0b6bce2 --- /dev/null +++ b/tests/dm/003 @@ -0,0 +1,86 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-3.0+ +# Copyright (C) 2025 Huawei. +# +# Test block device unmap write zeroes sysfs interface with device-mapper +# stacked devices. + +. tests/dm/rc +. common/scsi_debug + +DESCRIPTION=3D"test unmap write zeroes sysfs interface with dm devices" +QUICK=3D1 + +requires() { + _have_scsi_debug +} + +readonly TO_SKIP=3D255 + +setup_test_device() { + local dev blk_sz dpath + + if ! _configure_scsi_debug "$@"; then + return 1 + fi + + if [[ ! -f /sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_m= ax_hw_bytes ]]; then + _exit_scsi_debug + return $TO_SKIP + fi + + dev=3D"/dev/${SCSI_DEBUG_DEVICES[0]}" + blk_sz=3D"$(blockdev --getsz "$dev")" + dmsetup create test --table "0 $blk_sz linear $dev 0" + + dpath=3D$(_real_dev /dev/mapper/test) + echo "${dpath##*/}" +} + +cleanup_test_device() { + dmsetup remove test + _exit_scsi_debug +} + +test() { + echo "Running ${TEST_NAME}" + + # disable WRITE SAME with unmap + local dname + dname=3D$(setup_test_device lbprz=3D0) + ret=3D$? + if ((ret)); then + if ((ret =3D=3D TO_SKIP)); then + SKIP_REASONS+=3D("kernel does not support unmap write zeroes sysfs inte= rface") + fi + return 1 + fi + + umap_hw_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_unmap_max_hw= _bytes")" + umap_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_unmap_max_bytes= ")" + if [[ $umap_hw_bytes -ne 0 || $umap_bytes -ne 0 ]]; then + echo "Test disable WRITE SAME with unmap failed." + fi + cleanup_test_device + + # enable WRITE SAME with unmap + if ! dname=3D$(setup_test_device lbprz=3D1 lbpws=3D1); then + return 1 + fi + + zero_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_max_bytes")" + umap_hw_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_unmap_max_hw= _bytes")" + umap_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_unmap_max_bytes= ")" + if [[ $umap_hw_bytes -ne $zero_bytes || $umap_bytes -ne $zero_bytes ]]; t= hen + echo "Test enable WRITE SAME with unmap failed." + fi + + echo 0 > "/sys/block/$dname/queue/write_zeroes_unmap_max_bytes" + umap_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_unmap_max_bytes= ")" + if [[ $umap_bytes -ne 0 ]]; then + echo "Test manually disable WRITE SAME with unmap failed." + fi + cleanup_test_device + + echo "Test complete" +} diff --git a/tests/dm/003.out b/tests/dm/003.out new file mode 100644 index 0000000..51a5405 --- /dev/null +++ b/tests/dm/003.out @@ -0,0 +1,2 @@ +Running dm/003 +Test complete --=20 2.39.2 From nobody Sat Oct 4 20:54:32 2025 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC661270559; Wed, 13 Aug 2025 02:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755053538; cv=none; b=l9QJEkDJ99abgtXB0QRUfkCsIPHRT/UUiCR3Te/iPj5FK06tR+h8C5uTMnFv4E27ebZMo7+Qha/ukvNintwnwZhR9rmWJgVlBf+Kg/kNcGB4eCzCCmWggfdHVSd6uVzG226sl/WWbE4yFkr1zfx3qrZs17IgHD4JbB7X0dC8LkA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755053538; c=relaxed/simple; bh=pMO/5u3bPj59OUaY7EWtNX7Gfw7oK1jmCpyQpQRv/2c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aGdkBE9VZjj/iyhn3dTfjexGQ4XdjFjPedk+h7VzlMNFJ22kKWINbL8qxrca7bFW0SldLjx8zI8/HCJOCVMpoQlopaSez6UFK3K7uDjyVNDVaa4fTi1Jb69vuXAazzMEjhV4SsUREDcJ53F3J11HRg2/luPZuzxov/C8o8jH5lg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4c1tFX3F5xzYQtpJ; Wed, 13 Aug 2025 10:52:16 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 0F6F81A0359; Wed, 13 Aug 2025 10:52:15 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgBHwhLQ_ZtoAscBDg--.14424S7; Wed, 13 Aug 2025 10:52:14 +0800 (CST) From: Zhang Yi To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@lists.linux.dev, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, hch@lst.de, tytso@mit.edu, djwong@kernel.org, bmarzins@redhat.com, chaitanyak@nvidia.com, shinichiro.kawasaki@wdc.com, brauner@kernel.org, martin.petersen@oracle.com, yi.zhang@huawei.com, yi.zhang@huaweicloud.com, chengzhihao1@huawei.com, yukuai3@huawei.com, yangerkun@huawei.com Subject: [PATCH blktests v2 3/3] nvme/065: add unmap write zeroes tests Date: Wed, 13 Aug 2025 10:44:21 +0800 Message-Id: <20250813024421.2507446-4-yi.zhang@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250813024421.2507446-1-yi.zhang@huaweicloud.com> References: <20250813024421.2507446-1-yi.zhang@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: gCh0CgBHwhLQ_ZtoAscBDg--.14424S7 X-Coremail-Antispam: 1UD129KBjvJXoWxAF1fCr17tr1rZryfKrW5GFg_yoWrXF45pF yjyFyakrWxWFnrGws3Za17WF13Cw4vvry7Cay7tryj93srXry3WrWkKa4jqw1fGF93uw10 yayjqFWS9r1UtrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUm214x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JrWl82xGYIkIc2 x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJw A2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS 0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2 IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0 Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2kIc2 xKxwCY1x0262kKe7AKxVW8ZVWrXwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWU JVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67 kF1VAFwI0_GFv_WrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY 6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIx AIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBIdaVF xhVjvjDU0xZFpf9x0pRG2NZUUUUU= X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ Content-Type: text/plain; charset="utf-8" From: Zhang Yi Test block device unmap write zeroes sysfs interface with NVMeT devices which are based on various SCSI debug devices. The NVMe device's /sys/block//queue/write_zeroes_unmap_max_hw_bytes should equal to the write_zeroes_max_bytes if the SCSI debug device enable the WRITE SAME command with unmap functionality, and it should return 0 otherwise. /sys/block//queue/write_zeroes_unmap_max_bytes should be equal to write_zeroes_unmap_max_hw_bytes by default, and we can disable write zeroes support by setting it to zero. Signed-off-by: Zhang Yi --- tests/nvme/065 | 96 ++++++++++++++++++++++++++++++++++++++++++++++ tests/nvme/065.out | 4 ++ 2 files changed, 100 insertions(+) create mode 100755 tests/nvme/065 create mode 100644 tests/nvme/065.out diff --git a/tests/nvme/065 b/tests/nvme/065 new file mode 100755 index 0000000..8631bfa --- /dev/null +++ b/tests/nvme/065 @@ -0,0 +1,96 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-3.0+ +# Copyright (C) 2025 Huawei. +# +# Test block device unmap write zeroes sysfs interface with nvmet scsi +# debug devices. + +. tests/nvme/rc +. common/scsi_debug + +DESCRIPTION=3D"test unmap write zeroes sysfs interface with nvmet devices" +QUICK=3D1 + +nvme_trtype=3Dloop +nvmet_blkdev_type=3D"device" + +requires() { + _have_scsi_debug + _nvme_requires + _require_nvme_trtype_is_loop +} + +readonly TO_SKIP=3D255 + +setup_test_device() { + local port + + if ! _configure_scsi_debug "$@"; then + return 1 + fi + + if [[ ! -f /sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_m= ax_hw_bytes ]]; then + _exit_scsi_debug + return $TO_SKIP + fi + + port=3D"$(_create_nvmet_port)" + _create_nvmet_subsystem --blkdev "/dev/${SCSI_DEBUG_DEVICES[0]}" + _add_nvmet_subsys_to_port "${port}" "${def_subsysnqn}" + + _create_nvmet_host "${def_subsysnqn}" "${def_hostnqn}" + _nvme_connect_subsys + + echo $(_find_nvme_ns "${def_subsys_uuid}") +} + +cleanup_test_device() { + _nvme_disconnect_subsys + _nvmet_target_cleanup --subsysnqn "${def_subsysnqn}" + _exit_scsi_debug +} + +test() { + echo "Running ${TEST_NAME}" + + _setup_nvmet + + # disable WRITE SAME with unmap + local dname + dname=3D$(setup_test_device lbprz=3D0) + ret=3D$? + if ((ret)); then + if ((ret =3D=3D TO_SKIP)); then + SKIP_REASONS+=3D("kernel does not support unmap write zeroes sysfs inte= rface") + fi + return 1 + fi + + umap_hw_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_unmap_max_hw= _bytes")" + umap_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_unmap_max_bytes= ")" + if [[ $umap_hw_bytes -ne 0 || $umap_bytes -ne 0 ]]; then + echo "Test disable WRITE SAME with unmap failed." + fi + cleanup_test_device + + # enable WRITE SAME with unmap + if ! dname=3D$(setup_test_device lbprz=3D1 lbpws=3D1); then + return 1 + fi + + zero_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_max_bytes")" + umap_hw_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_unmap_max_hw= _bytes")" + umap_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_unmap_max_bytes= ")" + if [[ $umap_hw_bytes -ne $zero_bytes || $umap_bytes -ne $zero_bytes ]]; t= hen + echo "Test enable WRITE SAME with unmap failed." + fi + + echo 0 > "/sys/block/$dname/queue/write_zeroes_unmap_max_bytes" + umap_bytes=3D"$(cat "/sys/block/$dname/queue/write_zeroes_unmap_max_bytes= ")" + if [[ $umap_bytes -ne 0 ]]; then + echo "Test manually disable WRITE SAME with unmap failed." + fi + cleanup_test_device + + echo "Test complete" +} diff --git a/tests/nvme/065.out b/tests/nvme/065.out new file mode 100644 index 0000000..262cfc9 --- /dev/null +++ b/tests/nvme/065.out @@ -0,0 +1,4 @@ +Running nvme/065 +disconnected 1 controller(s) +disconnected 1 controller(s) +Test complete --=20 2.39.2