From nobody Sat Oct 4 19:14:35 2025 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C095927FB18; Wed, 13 Aug 2025 15:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099598; cv=none; b=Wo0SAD8Q+/tXvk7wRXIb1oc3CcSsLeBGO7vtQn8r5C4fWmjN3qFn9yskEviFuuvgxpgvghlzDVXYRsOXb2LLjgQXh3ZJG/5vOeBNLfg/iVMt8GT6wPb3hv8kgAwYWYh1nKcly3UKWNlWen0RPMqJ2Wre7rXACCbAt4qKG8bsdeI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099598; c=relaxed/simple; bh=389zTUeuB5JbibSGFWLgE7LO3s/a6burYE85gcD6ZMA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LJs+Ge6vRkNFE3N16kxqPfVxKUw5i0bwtZQr271JfXKeVIhwo+GaZzeVhk6bFgNNi6AA+hfQ3s8BYl9t9/WCaU0mm5lmk60fcWluqQwLH0hiPFFCkoqqmPKuGoVfdpGN8ziaKzjC/1YUiOdjWwFQPnmfFWSx5JXkumKNqElMQFA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FBhjNRjM; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FBhjNRjM" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7e6696eb47bso664586885a.3; Wed, 13 Aug 2025 08:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755099595; x=1755704395; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PGoVOhy4jERd3neINn4TPM8U5EEaP5ugIKSB6mln43c=; b=FBhjNRjM36CqI6VFinjl02jPr3aHoqloJi4V+G/eIfGPpDUkjur1rVn+dXJ8mwfUkS Nk8K1mXzNBpgzxZt1L4yuokK1e3UcPL6Rv8TySfqDGTrh5fjqb5V+g4BWQ78VOeshgTl MKdlcaniJeFF96i0BRW1V+fDyDN1QBxUwy3t/gP5jx2rySzCUZ5DdWHrBH9DvgmWjV2P 2SXimZ15JxrxYwy7rtFc41p/tAC8NQagdwwC91WBvd9wGvns767ag8Boh/Dv5IIM8OfF 2FQ3V582guwut0a3J0HFvA+uTDskzMnSPbAPdi5L50kAfzs9oePGSjrt5Zo+aoGPencA 5pRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755099595; x=1755704395; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PGoVOhy4jERd3neINn4TPM8U5EEaP5ugIKSB6mln43c=; b=lu+DGz9w3zGIvwzv8Lss/fFFXAh0/MZm8gYeP8MQSTH0Zp/FddiM8qGjJRrWYWvC+J Q/HokJPz4Mho1X5Fqtylfx6KV4I+Dp3greW/yzk2DV3UPPU1+KF1QbEaNyAeoLeqWsod AKjVzacrW+/YLWsxpAC8mpEglj0KZVPfYlqzK18MC3+cZBblANxNegJBfihuMe2MFfHi je8OlGq9EGqU9f+xfFqSBlrJfpUbbeJOJF6AiIKsIAKYX9Sj4PUAuS4iwiHWJz/eOiZK v/AtZYMiVObqGWEay6LXZe9HV9ki5Aa+5R+hrGkr5zrzx/5AqPsXvA0njChV/ZSGmuEd hJbw== X-Forwarded-Encrypted: i=1; AJvYcCURE7tQUnWSJ9b01F1G4h8j3Lu+lP5w6kkAyiPSalrAFXvztREfhhdEtj/lRKWUK1/Q26J/UPb8kj7lgVBaIUA=@vger.kernel.org, AJvYcCUUXy0UDg4q/6u8FuNCON+FzIy+sTG2dnsXwBHV/WDuQliVObwP5c2TeJ/Pdqz6mHvTyUvOv0hfUgdnIQ==@vger.kernel.org, AJvYcCUvrUVfmp+BmLnGbh49wWbJq30AGO27QoCAA6TZZns32NNxtyfpZ8XDEXqZEewxgoTD/+cEPTwtV/D4iQI1Fg==@vger.kernel.org, AJvYcCVnEpzvwyJDQaumDh/5lkn/MagSDpVERQWZlDiz41yPGJ7j7YT8quBIWgePr+lwC5ODetEtXPXF0L+BrbVj@vger.kernel.org, AJvYcCXWRmwX7VEKilHooV2DNY59UidOfjQczMhp6PtWJ7ppZFIYOpBo/+1yIpIIpZpb+SpSpvlQ1+3Q9L7XqgElUN6T@vger.kernel.org X-Gm-Message-State: AOJu0YwLKxsLkLw0Qcu1u7Ic754IJQxEVphE9UwaEqhGuqQfsQU2gkAU EemaMSTFsRJCnE8CSrXLzSa8sKUAv7CYqnUZBWYgumcYsqc9dJ62DNTA X-Gm-Gg: ASbGnctd8MZJdB7RuK720eqMZoxHlY7Ijq9S/3uJWUEzJb338b/RohMDiKQJVdEYD93 pOZW4EKsqc0TVGMn49VOSmOlLisCBifo3mdLazxsODRGW/L3Ghl/ecjMjJdNlyYYN9QssVvDM/b CIXKIb3q122W+R8UDWF1wT2/cjPQmgTgiuE8aBZGtXx1FLdQ13rHc14ehOhrgbVO8+yOSDx7j9D Hgh4+fBp90QLTb4Z1m4QKVTtC/DJTN7Xex6YifpH9Ya2VJe4gWudqtYh23x3vg1IB6oqpPNSWFB R2NjGfSnjvW5sAokhroUqUOR09WQaoXK9jB+AO1KFYEpvXoA6o7khMqTlNRP1PXydcomcAndjbO C6eHwNoMyfrDjKZCq4Vih7ioor3V01O68ZbXlhjIZIJUhMGCBG83Lt4ABC0+E46P5LeCbUP5gW4 Z2wnVdIQIIA+2wIJqx9nS+amQUt8owwp6OBQ== X-Google-Smtp-Source: AGHT+IHs0ZT7on5I9bZ1u8GrngyqrpuYHkDBkbdZIYm0MXwjYrSAWt/b+r463sWhhOCkHmkmHHChcg== X-Received: by 2002:a05:620a:2814:b0:7e8:3324:7aff with SMTP id af79cd13be357-7e86520cfbbmr401368585a.9.1755099595332; Wed, 13 Aug 2025 08:39:55 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4808:6353:5c00:d445:7694:2051:518c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f728a6asm1976119385a.64.2025.08.13.08.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 08:39:54 -0700 (PDT) From: Tamir Duberstein Date: Wed, 13 Aug 2025 11:39:46 -0400 Subject: [PATCH v3 1/9] gpu: nova-core: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250813-core-cstr-fanout-1-v3-1-a15eca059c51@gmail.com> References: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> In-Reply-To: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Alexandre Courbot , Alexander Viro , Christian Brauner , Jan Kara Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-fsdevel@vger.kernel.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1755099590; l=2221; i=tamird@gmail.com; h=from:subject:message-id; bh=389zTUeuB5JbibSGFWLgE7LO3s/a6burYE85gcD6ZMA=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QH/OsVlm0jUqXUwZWz2BvLX/LLKHbQHM91qDOJUmbF5e65uFWklBkvH4AGdcLYQ44WEXJF4RoEQ Dbvzeo+QbbAo= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- drivers/gpu/nova-core/gpu.rs | 3 +-- drivers/gpu/nova-core/regs/macros.rs | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index b5c9786619a9..600cc90b5fab 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 =20 -use kernel::{device, devres::Devres, error::code::*, pci, prelude::*, sync= ::Arc}; +use kernel::{device, devres::Devres, error::code::*, fmt, pci, prelude::*,= sync::Arc}; =20 use crate::driver::Bar0; use crate::falcon::{gsp::Gsp, sec2::Sec2, Falcon}; @@ -12,7 +12,6 @@ use crate::regs; use crate::util; use crate::vbios::Vbios; -use core::fmt; =20 macro_rules! define_chipset { ({ $($variant:ident =3D $value:expr),* $(,)* }) =3D> diff --git a/drivers/gpu/nova-core/regs/macros.rs b/drivers/gpu/nova-core/r= egs/macros.rs index a3e6de1779d4..6b9df4205f46 100644 --- a/drivers/gpu/nova-core/regs/macros.rs +++ b/drivers/gpu/nova-core/regs/macros.rs @@ -149,10 +149,10 @@ impl $name { =20 // TODO[REGA]: display the raw hex value, then the value of all th= e fields. This requires // matching the fields, which will complexify the syntax considera= bly... - impl ::core::fmt::Debug for $name { - fn fmt(&self, f: &mut ::core::fmt::Formatter<'_>) -> ::core::f= mt::Result { + impl ::kernel::fmt::Debug for $name { + fn fmt(&self, f: &mut ::kernel::fmt::Formatter<'_>) -> ::kerne= l::fmt::Result { f.debug_tuple(stringify!($name)) - .field(&format_args!("0x{0:x}", &self.0)) + .field(&::kernel::prelude::fmt!("0x{0:x}", &self.0)) .finish() } } --=20 2.50.1 From nobody Sat Oct 4 19:14:35 2025 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7F0428000F; Wed, 13 Aug 2025 15:39:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099600; cv=none; b=AppO8JBA7ZmrxvxTgcNyxpgCTGQFIk1h4Vo0rz3JrByamKvKcvHmqc1+LuR2YuXzm78UU3FsEW8mB347ghrrFt0EAnVV0zruMoXpG7qHiFIxqTDUmzI3kOEQsI96SGGSLh/QmspB6NVj+adApDCZWPZGhSelUymtDMjDdkTK/Ww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099600; c=relaxed/simple; bh=PSL4iigvbqQ2ksUQBIiw94ADQQA5vnHuf37BheuwWG4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lS5xnJwMEuU7PRsTQ4xGrV+xw7np3srwcbdDW3KSeZNXGzkeKdDXzWo5YhsU2cEbrQ6VR0Oy0DzBQ496tqt9+MAOSRp9It7w2aGISQs7YeocHmc/Do8XbhKs+IPTd7nibziweujMt2VrFQClDlVcP72dSOMv7odE6pY40MsD4fM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ijRwty/s; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ijRwty/s" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7e80ba947cfso667986585a.0; Wed, 13 Aug 2025 08:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755099597; x=1755704397; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k8zwWmF5N009AGIXlDD+XsD4K4+mEgy8HqbF8g/gLNE=; b=ijRwty/st5sHfOJtI0bg9CEzQmNMNJlCiIxLfs5wAvpPj/A7gtWn3LIyXjVsCt8HXe pzkRM7hSdj3vtrjmkM4r80+G/xMhCDEjOhWYdoWMtRlM2pDkTT1ImWo1zh+frPQw9+d+ UTdGVbTqB6OuMmUh7VPNA+Soe9ppnyJIiKV/AFa6sKxaYr52nd2Dlv1L9CVuJKvYVpvq Z1zYynWDwDQ1Z1h4kMN8FIxJIb9CEFpSBvN5fw2SjLwyG5ldhQlWmxZtHDSZzDHbuBfr ZnKQoPtMzTuBpCd0EdLcQLOzpnZAJ3ljMB9dSxR2z6aZFLo5Hw9pymycylVvTWCrdM1X /iXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755099597; x=1755704397; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k8zwWmF5N009AGIXlDD+XsD4K4+mEgy8HqbF8g/gLNE=; b=q50JR8nR9gpvYlLwv3oUfvD0cul/pC3lj3mbdIKSNiEOIRo6zQGoSvFnkD5x2AzXzB RTMUbUrRqrIxCvTiDnnBE2nbH6BGPxSIU1+xE2UCaDiJphYA/3deJqof9tktONyunx4n 32Ne+WyE4CHK6rzeh67Jvcpe3io0mbxlxu/pTNvUL3XdIpIREcYhaj7BFvb6uCX+Hu8/ UcJ5EvUEI/TksnZcj6Z1rpvLDkQU/lGUDY0WjvDMn/t3D36vChbJFgvFhqf9CvQqHExx JXmQSISm78FLAOjOooOWyIqqOsMRVQudNCIj24jtgNhRDlCTlJq8D82jk9s9ryUROTCu GfKQ== X-Forwarded-Encrypted: i=1; AJvYcCVKBPGuBNZ9Kw08sJyql/bTcB0VxUVOEj+ha/pFem0gx9EaZnYebOoQyCkg10X78eYleU/6SpITfJAQQA==@vger.kernel.org, AJvYcCVSezZupcI+fdmTCC/FOc+Yk9ZN/ktWVgFHGqe6q6cAfZHFoFrc8rwn+g085K6bsBhZWT0+dJ5kml6TDt1FJg==@vger.kernel.org, AJvYcCVb4XZbG/0IDNJkVI2XhR2UBzFa37NnhkkVeKmm97R+QcYc1E0QaaEzp7IJvN1B17N3vD64zmjv8u7U/ypTwXI=@vger.kernel.org, AJvYcCWAYUQjykAbQBvVRShU24RoiJyQKKFFPsIacDsxzBsZoCyZs8B6llS3sVgtPVx4SAqj4kbE5gYcJby3nVAQNDMb@vger.kernel.org, AJvYcCXU9gA4Vuhmq393QoUfL1/7NFRRqiOLI+tlSRRaXRPPUySfQ1qXbFU32vvFCJfipTfT6/UCXXuCTHko1CSu@vger.kernel.org X-Gm-Message-State: AOJu0Yw78BW46Nq8nsML4PTfzNJFBK5gNrwSjhWk1VX8BmgDkPgc3imm +2A8l5waT3aUQTNLwh8BuPqdg1SbL0odHaoUngVnoIkyjsbbY+CbbZoU X-Gm-Gg: ASbGncvr5dGUdHxoq0SjlqXxLrFMwFX/mzHqf01uGAjmmwvO2xJUURCioSr/zoZZQGe ab/+Tx0O45GE5s5eLn7Jf9Bn+cNfHvSc48ctmpC2YKPU6uPNpnEgBgeKBtP1iFt8A8pZUnF/6gp 1ZQvAvAUG8y68DQBs59DgDE+FRMBJxArJDzeXtsnEoycpD/jdGspyqWCIxVf7xuOKAVnAFBitlP Viz4ZyDKScTCBZorm7+a+hR50AXjjEVClLkqW4RnEGXCQ6F4auMa16pO15wXPJRd5jsNOT9sLfP GTT7AEDmANQZjRKrce8WSBl7mT4ACDePW5QC5hY+TCYZy13HgV0tAZQn1uAhhu7mx/spVDevhk+ 3/CjzFoBwKDOCXPy5vUMyds0eOT+LYSEs5Poyw8dIVpwE81AWo9LaoRpQh/CSlHnXP810hf77HA xAMD8mAWpbrpDWsFrQTMARNXeCN6T3NqhmGLJw1WrOo0FE X-Google-Smtp-Source: AGHT+IE1pby1TNrlRmqWtTqCTDZQP1D4c39paDUDyEiVNPrf/2gtoMRUjpJ7cXNWJtGfePDy+14ROw== X-Received: by 2002:a05:620a:8a83:b0:7e8:21ab:2846 with SMTP id af79cd13be357-7e8653207f2mr294256985a.36.1755099597290; Wed, 13 Aug 2025 08:39:57 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4808:6353:5c00:d445:7694:2051:518c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f728a6asm1976119385a.64.2025.08.13.08.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 08:39:56 -0700 (PDT) From: Tamir Duberstein Date: Wed, 13 Aug 2025 11:39:47 -0400 Subject: [PATCH v3 2/9] rust: alloc: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250813-core-cstr-fanout-1-v3-2-a15eca059c51@gmail.com> References: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> In-Reply-To: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Alexandre Courbot , Alexander Viro , Christian Brauner , Jan Kara Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-fsdevel@vger.kernel.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1755099590; l=2090; i=tamird@gmail.com; h=from:subject:message-id; bh=PSL4iigvbqQ2ksUQBIiw94ADQQA5vnHuf37BheuwWG4=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QN+HYlLAYPrUuy/AnIupocmwcDxEYQ6EU0tYcePMf7VZdJcmyQEaJoOPoXUfzoxZjDXIW6ttbd0 6E4kkz9lOvwo= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- rust/kernel/alloc/kbox.rs | 2 +- rust/kernel/alloc/kvec.rs | 2 +- rust/kernel/alloc/kvec/errors.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/alloc/kbox.rs b/rust/kernel/alloc/kbox.rs index 856d05aa60f1..563187d09a8e 100644 --- a/rust/kernel/alloc/kbox.rs +++ b/rust/kernel/alloc/kbox.rs @@ -7,7 +7,6 @@ use super::{AllocError, Allocator, Flags}; use core::alloc::Layout; use core::borrow::{Borrow, BorrowMut}; -use core::fmt; use core::marker::PhantomData; use core::mem::ManuallyDrop; use core::mem::MaybeUninit; @@ -17,6 +16,7 @@ use core::result::Result; =20 use crate::ffi::c_void; +use crate::fmt; use crate::init::InPlaceInit; use crate::types::ForeignOwnable; use pin_init::{InPlaceWrite, Init, PinInit, ZeroableOption}; diff --git a/rust/kernel/alloc/kvec.rs b/rust/kernel/alloc/kvec.rs index 3c72e0bdddb8..4a1b2c26209a 100644 --- a/rust/kernel/alloc/kvec.rs +++ b/rust/kernel/alloc/kvec.rs @@ -7,9 +7,9 @@ layout::ArrayLayout, AllocError, Allocator, Box, Flags, }; +use crate::fmt; use core::{ borrow::{Borrow, BorrowMut}, - fmt, marker::PhantomData, mem::{ManuallyDrop, MaybeUninit}, ops::Deref, diff --git a/rust/kernel/alloc/kvec/errors.rs b/rust/kernel/alloc/kvec/erro= rs.rs index 348b8d27e102..21a920a4b09b 100644 --- a/rust/kernel/alloc/kvec/errors.rs +++ b/rust/kernel/alloc/kvec/errors.rs @@ -2,7 +2,7 @@ =20 //! Errors for the [`Vec`] type. =20 -use core::fmt::{self, Debug, Formatter}; +use kernel::fmt::{self, Debug, Formatter}; use kernel::prelude::*; =20 /// Error type for [`Vec::push_within_capacity`]. --=20 2.50.1 From nobody Sat Oct 4 19:14:35 2025 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB3D228312F; Wed, 13 Aug 2025 15:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099602; cv=none; b=Cqlo4oO+Gdlbdt88xrCRMNoozui/kOXWb/vssRP4ORLUH6lmInK7Mj87Itr3WRAeJQak+tf+190A9m2vOcMBnuVsehBW/7/ssjERpVTGy9uAjG3OxM1t9yWvCmoYOmcrK27fJVrrIj3iyaFbaEou+v8WLsWs/P1AWVN36Gg4q2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099602; c=relaxed/simple; bh=af6FE21/bV11TzZblZrnYjzjw1z2PLK6stOqUBZ4ohw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gHGFIsuLkwST9NCdtNNy1AcGjXbmyqyZDamq6FOQmqnqxafZxpVjBsQ5wEdFz3t0M4AoPKBAi8z9CWyWLfcYkTR4+x1clL8l5WwrPxmPVSvmB6YZxQEsRJ+0om3eJRUyV3ZJtKKQNtW+16wzRDTl2ZEYysINuWup09DoXYsRO1I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wxqiin/s; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wxqiin/s" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7e809baeef7so736315585a.0; Wed, 13 Aug 2025 08:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755099600; x=1755704400; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EoILmxC+s8qjLUlPIig2YwOCGBuLO0IARaqVpLKdXqs=; b=Wxqiin/sRn4csfQAjPud0nUqlgEGPNKeVTjWvQpL5Y/P3jnVWB150NZjm1L9gKnwGx hormPyTWoRGZCPHTwDOOKzXhxGWVAmjUv6a1E0htPHSbkK8ydTd4k2dD928755t0beEV FbRd+l+L3PWbBInQy194AEV0Vsscg6KEcDbfKJDjRyNG4PXk3AvmcI6EM30X5Tdbwwsr o3/12jtTjPkPNGltP45QwZEF1O5qpp7OdQeUemN3xviMNJ1qZNd18YsCgh9ZCHRBQVRB Xh/W0UFGXw5E0JBaW7lwq+jckZtP7f1ND+Uj1v6UyRUufZdahX5Gsx29j6JfnRGBNN1L 4O1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755099600; x=1755704400; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EoILmxC+s8qjLUlPIig2YwOCGBuLO0IARaqVpLKdXqs=; b=HtwPegxhyb6uAMquofLPf4dplKCfGiVqGXCKxoyNB7HrfFucqJEPI3fQoAYaFfdO+1 L317K+QG3MrMvrvLAlRURK128C1A/5R5BJukiOKiq1zKe+zbO2Q7AGJd0bt42v84VclS c7RDuX4LZB/GXbpKNbSXbKlEiKbzU4Dnr6RPwJ8rSu+0werbRciexBbHAJVGZ9nLg9im c+zv/kdEyaH5mZsjTG+agkL1kRBX28o8eDvrDDl1MEj0bnY0d/p9P67NHMbMs+yJ10xs 69kQT+MtTGBEgSjEvrE0Fd9w2t8dZUY3trSeO996AhRUSwctEHtaUjR1GNWWHXA1IvH8 BNrw== X-Forwarded-Encrypted: i=1; AJvYcCUH9nNGsFIVxg7KYIxDqedLBIWKa13NDemzNOQ7tieQJspX2ntGLjy3E/hTxLqxBA4q4f3vaMPL+yHuyipT@vger.kernel.org, AJvYcCUZ+riX8nLXJdIKvacegUE6ZFrRVChZBFtmdrTwFoslbNxyqRppGWA3qOTnSc8VxA015QgAIMLrBNM5XuswHZ8x@vger.kernel.org, AJvYcCVVPMe8LRmTz3PAhD1DdTrZTkD3ANF6ILXnqXuVCbz2Td6NuVQWYynoFG0Cfglxs6XJJX8zcOGbsm3PwA==@vger.kernel.org, AJvYcCWe5kQcqp0Mgsw/xtU9SY00snat1qSRxf6vYJZDjw43wdKju1P4MzFlgMCt3z6Imab6gK8XKYAxyZVBgaDchyM=@vger.kernel.org, AJvYcCXGEZHlo4hkrafSK8nFVGIp2D1cHdbH+hOoZmvngxbvji67VMYYFtLoZn3j54zOmGokYVm4Kj+eP8zxHlkNfw==@vger.kernel.org X-Gm-Message-State: AOJu0YziX+CKcU+W/HSU9HWrb4diVP5mBRudPXPkyCuQjQv2o5MDUi// 2K9nFIrRh6f4LiSyt7fEjF05MFjux7xZECLx5OJvg32LSCGtKzIO2nD4 X-Gm-Gg: ASbGnct8ImyhH0qBjrP3xzAtijtQFnizGIhr+V18qUqiX5a4zJ3Duoiiyh9KTE7UAZz Ka2jgylWGm+422Qiyq0Gexm57c6FggqNJ2+TuvX4gG4tV7HsXoDPKb3ksqOW3Wnpgz98Ut8+xo6 cuWMfydWU8gtmBHHi9MOzK69e+ekC0ce3inQfn7V2UJrUStBA8o+UTuTX2VLIkdquSqYdMye8CF UKHBDqJcuWfmFL0dbexz9Pu3UxrcIM0vUPUtBpH3s4lEIyMd1VdDyppgKoYE0+G6PWo/bkypck2 xqxfQNjsPOqk+nmLHIJeJw9q8wAxBD5gDmZdnYu78KuMNPE8n8UsIhQpLQ+3vMoS69TIKeX3RqY tQMbGEPkh31Z2HgKuM2QtNkipuPbnUvvtPu9Hqas1S1elaNx61P1Y4p47Sj738aSjWVbg4pfb9D 9zIuE/o2ZsG2MSQ6k96XxHJi5V12wXPnhTYIa8OWBEs/OH X-Google-Smtp-Source: AGHT+IHJTBTQsKJ9J0icDqWPfLqwUQt/F8t0mjlt1AUtpFI3OZp9iuL1Mfx3vEnp4RBicKJJchksRw== X-Received: by 2002:a05:620a:9174:b0:7e7:fe10:60ac with SMTP id af79cd13be357-7e8652dfb35mr381227685a.33.1755099599634; Wed, 13 Aug 2025 08:39:59 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4808:6353:5c00:d445:7694:2051:518c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f728a6asm1976119385a.64.2025.08.13.08.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 08:39:58 -0700 (PDT) From: Tamir Duberstein Date: Wed, 13 Aug 2025 11:39:48 -0400 Subject: [PATCH v3 3/9] rust: block: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250813-core-cstr-fanout-1-v3-3-a15eca059c51@gmail.com> References: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> In-Reply-To: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Alexandre Courbot , Alexander Viro , Christian Brauner , Jan Kara Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-fsdevel@vger.kernel.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1755099590; l=2915; i=tamird@gmail.com; h=from:subject:message-id; bh=af6FE21/bV11TzZblZrnYjzjw1z2PLK6stOqUBZ4ohw=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QND6ryUce6zUmM6RgxlBBczQVu5n2eIQGV08rFnIBp3j+aPyM2w4SbFr7X/VFxWqv4YqG7uQRhM UPVnePCfgnwU= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Suggested-by: Alice Ryhl Link: https://rust-for-linux.zulipchat.com/#narrow/channel/288089-General/t= opic/Custom.20formatting/with/516476467 Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Signed-off-by: Tamir Duberstein Acked-by: Andreas Hindborg --- drivers/block/rnull.rs | 2 +- rust/kernel/block/mq.rs | 2 +- rust/kernel/block/mq/gen_disk.rs | 2 +- rust/kernel/block/mq/raw_writer.rs | 3 +-- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/block/rnull.rs b/drivers/block/rnull.rs index d07e76ae2c13..6366da12c5a5 100644 --- a/drivers/block/rnull.rs +++ b/drivers/block/rnull.rs @@ -51,7 +51,7 @@ fn init(_module: &'static ThisModule) -> impl PinInit { .logical_block_size(4096)? .physical_block_size(4096)? .rotational(false) - .build(format_args!("rnullb{}", 0), tagset) + .build(fmt!("rnullb{}", 0), tagset) })(); =20 try_pin_init!(Self { diff --git a/rust/kernel/block/mq.rs b/rust/kernel/block/mq.rs index 831445d37181..61ea35bba7d5 100644 --- a/rust/kernel/block/mq.rs +++ b/rust/kernel/block/mq.rs @@ -82,7 +82,7 @@ //! Arc::pin_init(TagSet::new(1, 256, 1), flags::GFP_KERNEL)?; //! let mut disk =3D gen_disk::GenDiskBuilder::new() //! .capacity_sectors(4096) -//! .build(format_args!("myblk"), tagset)?; +//! .build(fmt!("myblk"), tagset)?; //! //! # Ok::<(), kernel::error::Error>(()) //! ``` diff --git a/rust/kernel/block/mq/gen_disk.rs b/rust/kernel/block/mq/gen_di= sk.rs index cd54cd64ea88..494c95623b97 100644 --- a/rust/kernel/block/mq/gen_disk.rs +++ b/rust/kernel/block/mq/gen_disk.rs @@ -6,9 +6,9 @@ //! C header: [`include/linux/blk_mq.h`](srctree/include/linux/blk_mq.h) =20 use crate::block::mq::{raw_writer::RawWriter, Operations, TagSet}; +use crate::fmt::{self, Write}; use crate::{bindings, error::from_err_ptr, error::Result, sync::Arc}; use crate::{error, static_lock_class}; -use core::fmt::{self, Write}; =20 /// A builder for [`GenDisk`]. /// diff --git a/rust/kernel/block/mq/raw_writer.rs b/rust/kernel/block/mq/raw_= writer.rs index 7e2159e4f6a6..d311e24e2595 100644 --- a/rust/kernel/block/mq/raw_writer.rs +++ b/rust/kernel/block/mq/raw_writer.rs @@ -1,8 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 =20 -use core::fmt::{self, Write}; - use crate::error::Result; +use crate::fmt::{self, Write}; use crate::prelude::EINVAL; =20 /// A mutable reference to a byte buffer where a string can be written int= o. --=20 2.50.1 From nobody Sat Oct 4 19:14:35 2025 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAFB0283FC8; Wed, 13 Aug 2025 15:40:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099604; cv=none; b=cYo9groVbpiRUlAdW+noBVppr6laK+j2OgSRCEMMNgsTLUH94+cm4ejwq0xf3kd/jggfRBYvQxDJ9gtSutQDNnD7LFTRuMZsvuLxdYVlr20sdE/jaqoqqUIzC/NQoihKhZBA2g5iEojmcP2R/cWxo4iUJQYciim0zyIpLEuFuo8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099604; c=relaxed/simple; bh=l5FpEcw0uQYnPs0RLtDbZfxzw/E05BYYCtB2nhqouWU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lxYKPHI3YIV+kOmK7GTmRJXuax3R1/pK5nGLnENF23jJlVSXK49+1qX0e4DU+IS18FJx9hdEDazt27OCbRzVIOlE+xoyP1T0XJS61Nb3US0cdnf86ryyAFNJml+qYP4j8nH6jdwmOi1/Ieu0FC4O+6Z8oRlIUx6bGkOqtkKoUBY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DH6+hJEY; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DH6+hJEY" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7e2c1dc6567so443840485a.1; Wed, 13 Aug 2025 08:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755099602; x=1755704402; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MRfZ2w/4F4Ea9f92rkBZAFGpsLi9iHZG21wugvWYEpw=; b=DH6+hJEY9DPisitJAsRfDHXF9wgfsSkcJ2XySPyTwmTe6JquCRodPdgetdhsYdocTy LRtbzS0m/reZE8/h+peIJQPEDqwPRRLNcHbCV8exTrNGFFuWgdceiXy7v/zJ7z27aTBk 3zsdddShcAtS5hYUvRTij12CgZkUVmFCqTC/dUx9TReUbBgO6NjQZWFATMa909PRiHv/ 8hvGtCtA8WCTTk1d+o7AIX1n0gsS27NY+VkK4YE2Pk79o5ZVfI2hyI3dKZnHe7Wzj5d+ G7iTEwr2poKWF3oiiFb/pj3k1PNkR7zYX0h3n2Az40Uf6aOyr2EthFAj7tIzvx9rXO6h FwTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755099602; x=1755704402; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MRfZ2w/4F4Ea9f92rkBZAFGpsLi9iHZG21wugvWYEpw=; b=dlmBgPMYk2GIBBIEszN2dAgA5xO2F2ltWZwPL3+dactT820xZU1BwfZc6+9WLvJJs1 zOmlcTN1JLcO9WcZ0GPJHAwb2kHgg8iZcG6n8Q08cv9vjh/NxlHSEix8pvExCxwbZZwI iHl/o+/LFthk1cRCxNfOAR2lBItG2RVgwe3M+MjPnbCvJlhkwt8uiQ0fBQlyLiyMNepL 9YMONMu0W4UAmgA5564vUjPVoGwmhhPnRRvbBNPSHGEFwMcm02O+l5YNuoz5pLWLK99o jz5EWxpJO946+AhthlDewskzM/Evom4Vp+I37XTGJkAw6x0qOEEq9UMp5gXh3FzWdwYs RccA== X-Forwarded-Encrypted: i=1; AJvYcCVsd5ktslQrG/0CTB+uA+B7Gnijf31FxUlCBnirF683PE7KN84txWN6TCv5NNMvQx3qXn/3gXejekSPHLPh8hvq@vger.kernel.org, AJvYcCWXxNCMTHDTsD6JDtMqla9S6pgPrUZ6nbzbO4JWcaa2ZABDPaC9y1g5wvMTIT6TkobIoAXjFOVDpzQqLA==@vger.kernel.org, AJvYcCWaiVgdntYNsK5Wnyyi6iUrLhE7ONlWJO7DJTgCB6neMtvWsAGg+UIPFGPmrSAHnY55TaLQMRgD1hLmt+STxQ==@vger.kernel.org, AJvYcCWu6NyiiJUjkQR8J8fQQXIyiw/akPHGJGEAkVLaJuqk155z+M8L5gQ1z6ZPsTfOgxiueIMA7rj1VxCSzb9eYAs=@vger.kernel.org, AJvYcCXiD8GYWUWE5zPXYtq8KgnA7JaREeXpzvBxhLHUgJRTYjTe8XWHhHnku30cMrCYJP2W2b5VcqV4HQXDnyaV@vger.kernel.org X-Gm-Message-State: AOJu0YzrxtAZUJgB5GBO7Z9EkUUPEnoSnqVEyCyG1TaZdqBrIZBxwTVm dPF/K8bIBSDs6LRcaG8p3aJAvsYb0z6nTUQCSo7yoJHKChpGjGij5Pxv X-Gm-Gg: ASbGnct3zQ4jgX0O1ii92hkQctlz/yBqJd/LYFhKsWUGyknd2eMGVJsUgDsaWNNl43I bAvdayXNMo2CcvrpTaKlWJSCRngXk5sJOVQZ5t0e62BUL+FUomfjoOSyhhdj07W9TKNfBKs4OOG 5TNScON7By6r9yb4nE2Ja5SHmQ/6ko5ONBhuCYIcsoEhdlJPec715SoigOjZwR0tI99DEbOn1JS OG3ICnLBo0sYRex5vMdILaG3G8l2YW6v9NQxe+b4hQZWKxsuGKDN4bybTYimoyB8JBcyuHrzvsH n4L+fmXqqhpqDnqD+Ytc6YMDiV6uQZy/mRn2pyYXU61m30ahrJYwnN+5l8v3TMSgwFfGA1MsSR7 Qgh038MBEEt1JM3KscbE3DQfO1bzK7sMeJHYv4uc/VfW9lwNvH8/0qhLY2T3BXVk/VR+gpvOGwF YVfazI7C4WZxuw2pSE+IL1CpPpkBmuso5qKek5mAdKk4x4 X-Google-Smtp-Source: AGHT+IHc3zRAl0lkk0iybOGSsFCbiPVspNuo1MJksI72/kUVwI0EXzlGYnouroXpZFiNdgcqWm0lKw== X-Received: by 2002:a05:620a:4001:b0:7e8:3a70:795c with SMTP id af79cd13be357-7e8653782c2mr475868385a.65.1755099601681; Wed, 13 Aug 2025 08:40:01 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4808:6353:5c00:d445:7694:2051:518c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f728a6asm1976119385a.64.2025.08.13.08.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 08:40:01 -0700 (PDT) From: Tamir Duberstein Date: Wed, 13 Aug 2025 11:39:49 -0400 Subject: [PATCH v3 4/9] rust: device: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250813-core-cstr-fanout-1-v3-4-a15eca059c51@gmail.com> References: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> In-Reply-To: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Alexandre Courbot , Alexander Viro , Christian Brauner , Jan Kara Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-fsdevel@vger.kernel.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1755099590; l=1289; i=tamird@gmail.com; h=from:subject:message-id; bh=l5FpEcw0uQYnPs0RLtDbZfxzw/E05BYYCtB2nhqouWU=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QC5C2cxbS+6RI0o5ytJmwUqcqJ2t/hbVRgJ5waZwP6iVwmKa7NnILxyeTSEYvFBt+Rv1Lv2ql5F nY/Gb6itHSwo= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- rust/kernel/device.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/device.rs b/rust/kernel/device.rs index b8613289de8e..65306e77d97d 100644 --- a/rust/kernel/device.rs +++ b/rust/kernel/device.rs @@ -5,10 +5,10 @@ //! C header: [`include/linux/device.h`](srctree/include/linux/device.h) =20 use crate::{ - bindings, + bindings, fmt, types::{ARef, ForeignOwnable, Opaque}, }; -use core::{fmt, marker::PhantomData, ptr}; +use core::{marker::PhantomData, ptr}; =20 #[cfg(CONFIG_PRINTK)] use crate::c_str; @@ -435,7 +435,7 @@ macro_rules! impl_device_context_into_aref { macro_rules! dev_printk { ($method:ident, $dev:expr, $($f:tt)*) =3D> { { - ($dev).$method(::core::format_args!($($f)*)); + ($dev).$method($crate::prelude::fmt!($($f)*)); } } } --=20 2.50.1 From nobody Sat Oct 4 19:14:35 2025 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3178284B5B; Wed, 13 Aug 2025 15:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099606; cv=none; b=druwsg3WrZ6zDBNQTsVcxwBebJmcN+LC13xWrdnB/aW78JvQzgShdW+E3JQUjGjQnmqKn3+qdXP+g3dD14HwJiPNJMm9PbBW1tBcQnfBMZL9wanZgfio9BHe91Z09I/nvYgUvreKMMFQ2HROTo8w8DSv1BmcTjtv9VTsQe325qU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099606; c=relaxed/simple; bh=RP9BgmTgGLsZJlnOuBKxXo7vRURZVQnq5fRAl43lnxk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ikl98TG42cCNX4u9uFScmeWuZrcyplKX+M9FvcCcU7iDvVVZTK7CJSqGmgyRFvtd6hCU6XC7z5K0cOrccjY/5Bm7Gs63BOBTvqMgoDePAQq+5x+ulT9iW1VJyuRpReGhTTVBx4Rrf62zQAWHMD/s72ryOywRB+EqFkGJ4T6LFZI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jg7SU6t/; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jg7SU6t/" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7e86faa158fso2366385a.1; Wed, 13 Aug 2025 08:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755099604; x=1755704404; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/qpsl+4vBrJRbJlqVCZp4ufITcVO/mct/gLsPqZyfMc=; b=jg7SU6t/q4khit85L6POZZrVL7pq2KYEjhC6K1k99xqAlKwpY3KNaTd5e8dJpyxY3Y jSoWsgRppxxW98SNQ2hsp1sGobDYylv1lxhFZSWX/mqsFl1ZO/NFwfdkZbV50OQ2fL6J hIQG5j0+MrqR5p7KN4hkSEQ4Gm0vbwGj4yYJIdQsEoXan0IfLvUUNAD5aELok69szmn/ qjmfRZiRKmi88oUiMcAHfkcSChWlT0ox+EWtnKM6o/KffSVjCE+8KKf8MVJ+LQiK0hs5 nAjQwueeCyL0g4AWrKQSiznfLRde95uzxOrtQd7fyzVSQxsPoEoDx1XCgIsD9vmIKxZ9 8ZpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755099604; x=1755704404; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/qpsl+4vBrJRbJlqVCZp4ufITcVO/mct/gLsPqZyfMc=; b=vU3i04oF1e9yTjy69f+spa0IRcBu9FcIFd0Q8lzErjXbKK1a+sBA9VHNWbuGNGdodL 7TG7Kpj1e8SA0ikfmXNV/59VlQdDRQ/9DJIUwBm0cmLHjbYkp4UyYImeyP9x08uGDF5k u+ZPeTuPDzjccv20H9A2SBLAgIoovOZqK6UK6d4wI+9sqfCyB39hc0T0q3kQQpPaMIOe Nz6/XXThJYYp4WVMHvs87hEi2X22b2jK6jaUyT0T959Tx+/F5tzIogIL8nKr9NUnba4y Jig3xDaHy5YJN/mixnLPtSTpouDG/13XoikzQmK4Skk+Dkium7RKZy1RpZwVBRKs9nM+ iScg== X-Forwarded-Encrypted: i=1; AJvYcCUHB3pcmQZpKqnIwAL0P1/C+aQwh6rpT3aljqzASL3oDzBBCI9V91unk3qZlnTO4BVk4vmNIQTo6mS5dA==@vger.kernel.org, AJvYcCUl0HkLyhHQhLG1bgw6nt67ir6WJs/NhVySuGgCgScC2kPNj/BWwEwYdn/iGxDDuA5DsbbMiyKS5iZj0dZ6NvoH@vger.kernel.org, AJvYcCVaq1flXGukef0LuPmFYP+MmQ4Dgsyu9K3sszZ9WNzKp9IFI73hJBoSOyk3k4PnogdD5ZS1mEjPDYHE9j4C@vger.kernel.org, AJvYcCWLd1dfjMj/Wy/DCipx4wO5PxCUvq06amP9zfaxbvzF2icSTz7QYLjgnyhswbwI5jgko43hgmZftcW7Y6TEVg==@vger.kernel.org, AJvYcCWsTv6Y4Gar+iH24mun/7hrifpFJ7SYYVlgECuBAjxVT8IKtTlP4TC2f4CiLhsl/+vie3wgg6QmNmALc7MSGKQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwmAEkYz5vkVkmoq96BSCY23VxsPgAZ6dPvY377ffPsNiR0eIwa eUlioc6zbSPbvTMy5AViNo7bPlr/yrVumL2XUKFChiUYgLNJvlVR6YRt X-Gm-Gg: ASbGncsGIEwWGxr1OH2l1YFUjnuFYT4oCyH/nX2uJBzQyeuZqwAlgkQkNvMHIIS/O9/ qQUmGh4dEkvrJKe+ghNfz01xrGSZ4C8p3FCXkLONN+hABgoqggQt1M5PQhuEO4xE9hCpN7004RH QhIURDOQJNkuNHEi493r7h3H8xzfFMP/wjkdMknZiI4DNvlto3Z3ACZxT1dhmG1KSdcyTHhSugU LWS3Te/EzYyzwT35sqK7dvCVHtseC/FdwCBc8I0zenZOz1s5IUfcNzYr24rxzq1y5b4IErw6Z2h Zj/2vANOZTBYj8BVJCqnFcSa4yVpvRhritBFqHA7TX5m083hEI3RQm3vwE+aB+b8T31ktN35rMI SBi65Psg5YoX9i5JouzcIqWneE6pqWRRUH4xyDfAI5Gnf/79CLtjD8TiwgYI0XZ/Tp9dNrY6bTm gQ6/sK3wfv3yND+s9Ds7JvUrsA+0S93LRSlg== X-Google-Smtp-Source: AGHT+IEuXl9nU8BxNMaZcf00fEBMhN8CPnsH2MX5pRIR595Bg9FirSB63Hs35j+kk9MEGbhoVixU0w== X-Received: by 2002:a05:620a:450c:b0:7e6:92a4:3f03 with SMTP id af79cd13be357-7e86fc24707mr5121985a.8.1755099603612; Wed, 13 Aug 2025 08:40:03 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4808:6353:5c00:d445:7694:2051:518c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f728a6asm1976119385a.64.2025.08.13.08.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 08:40:03 -0700 (PDT) From: Tamir Duberstein Date: Wed, 13 Aug 2025 11:39:50 -0400 Subject: [PATCH v3 5/9] rust: file: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250813-core-cstr-fanout-1-v3-5-a15eca059c51@gmail.com> References: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> In-Reply-To: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Alexandre Courbot , Alexander Viro , Christian Brauner , Jan Kara Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-fsdevel@vger.kernel.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1755099590; l=1134; i=tamird@gmail.com; h=from:subject:message-id; bh=RP9BgmTgGLsZJlnOuBKxXo7vRURZVQnq5fRAl43lnxk=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QKl+lYEvf8gi26tp1qsgbmNj69ikU6KcIBZ+ES5GC7bQ34Bf2HyuMiq2uxB6M1hJNeJt7F1p9V5 +oP2Eqk03xw8= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Signed-off-by: Tamir Duberstein --- rust/kernel/fs/file.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs index 35fd5db35c46..67a3654f0fd3 100644 --- a/rust/kernel/fs/file.rs +++ b/rust/kernel/fs/file.rs @@ -11,6 +11,7 @@ bindings, cred::Credential, error::{code::*, Error, Result}, + fmt, types::{ARef, AlwaysRefCounted, NotThreadSafe, Opaque}, }; use core::ptr; @@ -460,8 +461,8 @@ fn from(_: BadFdError) -> Error { } } =20 -impl core::fmt::Debug for BadFdError { - fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result { +impl fmt::Debug for BadFdError { + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { f.pad("EBADF") } } --=20 2.50.1 From nobody Sat Oct 4 19:14:35 2025 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4D4B285C83; Wed, 13 Aug 2025 15:40:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099608; cv=none; b=mCGRpsj1Ri9fLFseB0c0/fpaIvxCTr82TIPTfffQBARxsv82/FlZJWHbRV4Kaj7AXZQ+qAXBpS+/OM0CRbRhRgyC9WYgclKGfndrAMeHD5YabW7kO4Ej5Xld5Kfxbq1dYWNuIdgLEELLTAyKMjFUTcm0Z/k8b5BHO+MnVwrD068= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099608; c=relaxed/simple; bh=NMYBijI5MjCpRRYFrsF0rVf9eokObKfR9KrctSSofPM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z6bU1sjhjA5/2eeTGXL0yM7wx3/FrgxyflZaY1+QNkWrVbTg0ZkILbQYPssDEOxd2WVsCmVrMP9EamWjoYtVC17mPem56EPPZ0a31Xyhr/D5MN8V5aUb4PFgDVjR82M4hQsLN707QN7k06TSXuAE6XNw0FY0t3MZ3he5HM7w3bc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KrgTPQUh; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KrgTPQUh" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7e6696eb47bso664605885a.3; Wed, 13 Aug 2025 08:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755099605; x=1755704405; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tKQyJUeEwCiLmV9wAMTey92Pv78BxejTGsU885hQL84=; b=KrgTPQUhfgaZDyBAHked+WqXC4bLJV3Pq7YSdDrssCpJzJ12ZvWSPTIneTsS2QvuJf /ESHmWOmMQeE7B5LDST+9gIk5OkAzR2w6ltzEZWK9mo52jTLCWeC/SeFv13R2lJkEOe7 Z5TWYfrqa1NJCrCNTdI7AjyFU8oJocKMxfqVb20hd2SuUMlnsAAu+Kh76dYmh63qckuq v/WfD+H94K7spfLSJVcxnRb03I4ikrJYe5gpn7sCQSBLdNt1B8zGCNTgDN5gYMMCZPKO PkmWTtqnAxSc3ens4XnMOiH5oy6csFh9AzK6znea2kcu2+7GaGN1r+6+fGLNvd+EjH37 2BbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755099606; x=1755704406; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tKQyJUeEwCiLmV9wAMTey92Pv78BxejTGsU885hQL84=; b=QlIcSmz0rjhOBehf9gv70Or2N64qP/eCqGDEtQ6e+Xjx3DVgTq1M5zxryWdgA3to0h eRs9DcLA8VgZj3o4pvOctDrEdOdN5o1gcbQdWRV58yKWqeKtrPv75h9EKVbFSyV11ON7 ILE0R2KSqr+Bf3PTYYI7AntThO4BLtMHCulamxt5Ns8BzrblGLkqRSt6izHUHQKs3Hqo JQhi3JuCzA4wHu5ZS0eGNzI3AeUbh5V+d5etpTrPy7i7/lg67V0A079txV5dB7RcQWnj ARn5+AXzIzmn2bEZqiMm7s1EHTR9a52fGPFvLNPe4f65ykYy/Gql0e6se7//xr3oNK2p dT9A== X-Forwarded-Encrypted: i=1; AJvYcCUh9Nu5Pyy701MgPRUJcznynbcRNKBG9qzLNYHXNMu6xb5Fz6bYQ5bVP9Dw2xUjBijCPFLtk/r1BK07aCFn@vger.kernel.org, AJvYcCUn+wDOhz64qb9tuSDU8Re/29B25ukMokJomheIdmk5B+X7ZF927TEr6KL+Fnl2R0CFQHK02UwemdcVb4/FCml1@vger.kernel.org, AJvYcCV8i9b2el2mmyGBct01y9Msc3kJXfNbwYQGzoWFV30ySc0t/J7ZejZebYtnubSsEo7u+BUJrfjQcLJNBxMCepE=@vger.kernel.org, AJvYcCWL+xqAxW+FS8kOpBVxRSRv5K3bQmQNh6lXoMgU4JJIs3om0eJvUwacnFtDmoUQ5+8Z9xmv76nDo/+8eA==@vger.kernel.org, AJvYcCXQJhZlS3Uk+vdxlMjM9LKs6wA39QSVGYgF8kdYr2H2lyiD4Ch+9X5qbiAM19zTD7XvHbIpx6+ASnTih1258w==@vger.kernel.org X-Gm-Message-State: AOJu0YxI9jXlM68twsY6lH8DR3xbvyqBWSQeOKtL6ej7wnxjVRo4yGUt EFrARbPpOw2J3OthoQ489GJ8t/OJLtgPcxs+1os+g28ULO8q7ZChH26n X-Gm-Gg: ASbGncu8y8JOWQDU9LGBE/C1IJSoVGvCzZLvaZpGtS/ho3rW8ygX1UCnANBqJwD58NZ uI3XZJX1nCrifohNXmgeYrHxeFiOWyCGbPVCak6ERTJhdZbzydIE17vIr/liajoTeneG4istsda dJid+tb4LroEUk9SM6yIwpzvumdSnd+DbWmHY6OO+DMwZlLXSZmnujQKfzvG9uSpZpukLZ+vXaT ZrqYosC3kH86KdHQ6wT3gzjp5PWqZmVwb6mmaPK0/mBj5ZxkeXNo7T3uwpbMlRVmU2R8Dn8Sllj CLQ7ewchzt3hhVwF5vgIVRas1whSoIvUlstuC2zhz1Cl1mPhaEik6bAPrme3Tq8vRl32V7K71b7 ImPZu44KiMzOPZvPPSVkbqMFhxhVK00tSmU6bXY3m2rom404kpBWO81ldKteICXEO4p7J+q7bT5 rD+nccyEbd2ywChFdyoWY/CmQXU9OdC10sEA== X-Google-Smtp-Source: AGHT+IG14Ou5jKogZhVRtk4/jsabABzOGdHRDYRyYwlXybd5iqYGKxAQsMBHFwVEi3/l9Z9yMLj/Cg== X-Received: by 2002:a05:620a:3707:b0:7e7:fafc:c6f with SMTP id af79cd13be357-7e86526c55bmr457281385a.22.1755099605519; Wed, 13 Aug 2025 08:40:05 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4808:6353:5c00:d445:7694:2051:518c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f728a6asm1976119385a.64.2025.08.13.08.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 08:40:05 -0700 (PDT) From: Tamir Duberstein Date: Wed, 13 Aug 2025 11:39:51 -0400 Subject: [PATCH v3 6/9] rust: kunit: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250813-core-cstr-fanout-1-v3-6-a15eca059c51@gmail.com> References: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> In-Reply-To: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Alexandre Courbot , Alexander Viro , Christian Brauner , Jan Kara Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-fsdevel@vger.kernel.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1755099590; l=2471; i=tamird@gmail.com; h=from:subject:message-id; bh=NMYBijI5MjCpRRYFrsF0rVf9eokObKfR9KrctSSofPM=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QLKIxkqmYjvgREAtIt6jqTnawH9+7pVTy/Un6pR53J21I51aGM8aOXhOurMFKVJYH2NWvrbQfzx uG07vM7LPJgM= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Signed-off-by: Tamir Duberstein --- rust/kernel/kunit.rs | 8 ++++---- scripts/rustdoc_test_gen.rs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs index 41efd87595d6..cf58a204b222 100644 --- a/rust/kernel/kunit.rs +++ b/rust/kernel/kunit.rs @@ -6,8 +6,8 @@ //! //! Reference: =20 +use crate::fmt; use crate::prelude::*; -use core::fmt; =20 #[cfg(CONFIG_PRINTK)] use crate::c_str; @@ -74,14 +74,14 @@ macro_rules! kunit_assert { // mistake (it is hidden to prevent that). // // This mimics KUnit's failed assertion format. - $crate::kunit::err(format_args!( + $crate::kunit::err($crate::prelude::fmt!( " # {}: ASSERTION FAILED at {FILE}:{LINE}\n", $name )); - $crate::kunit::err(format_args!( + $crate::kunit::err($crate::prelude::fmt!( " Expected {CONDITION} to be true, but is false\n" )); - $crate::kunit::err(format_args!( + $crate::kunit::err($crate::prelude::fmt!( " Failure not reported to KUnit since this is a non= -KUnit task\n" )); break 'out; diff --git a/scripts/rustdoc_test_gen.rs b/scripts/rustdoc_test_gen.rs index abb34ada2508..c8f9dc2ab976 100644 --- a/scripts/rustdoc_test_gen.rs +++ b/scripts/rustdoc_test_gen.rs @@ -202,7 +202,7 @@ macro_rules! assert_eq {{ // This follows the syntax for declaring test metadata in the proposed= KTAP v2 spec, which may // be used for the proposed KUnit test attributes API. Thus hopefully = this will make migration // easier later on. - ::kernel::kunit::info(format_args!(" # {kunit_name}.location: {real= _path}:{line}\n")); + ::kernel::kunit::info(fmt!(" # {kunit_name}.location: {real_path}:{= line}\n")); =20 /// The anchor where the test code body starts. #[allow(unused)] --=20 2.50.1 From nobody Sat Oct 4 19:14:35 2025 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA187285C85; Wed, 13 Aug 2025 15:40:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099610; cv=none; b=QJg3FEHFot2Lu1KlokHAslF6tMabZWgZzeDbN8Wp2uSsoWKv8z5U1kq7YFlgiMsx+9vLP+EIe30UcJsaaZp+7YLRQStCGo5SD9wc4FpdcW2r7j5AekSbbAyFxt+PB5w42qs083d7/aSkexwghhliGtP0BzUdvmGYuM8BV/dFoAA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099610; c=relaxed/simple; bh=4r4hGm+5eFeJ1YD1XNe79Rof0MXa9XpmAsMvwuuTVcY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cEwOf132+0UWXj6BWEJUIagfTUf8LD6ueU5dsCAmXNix8vAJj+OrJ99F7U46cWZsgQ/yi14P7bfUGyIMskLxptp6qIfNu5bl2GL+SN1iOHSNPRIT36Lyv7aGXhbyKu2uT5LyJ6vWCeUG+3WWUX58oFdrj+kFHMKhQnDcND/FgLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nIFFDNHK; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nIFFDNHK" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7e806613af8so781151685a.2; Wed, 13 Aug 2025 08:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755099608; x=1755704408; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dvH2/B2zmQ0D9vQHtz4nqDYlqgBbI+OptHpY/wLbPQQ=; b=nIFFDNHKx5feKut7NI8X5Jg0mYlcJVkVJOcs9I3mE5IOU9aZspDpj6A1/t3/xU20o9 gEF5O13kQHo82/9Tixtgw++4HzmSuyJkO0A+3Il87kXjgMRlRUWrN4Z267xjSXM+GxTU LbGNcrfV2hnq3rjEKd6APGy929Zofy5w8Vjdzu+LzR3tzfkQpWlhsGctjo4X87b1obco bPCSbd8zuKxsHLrFH5dHYo/UAFyzB5V+UTAqMzkRdq/SerIXzMM4yXgqOxWw1b13hbdi dcdiviryCb8GYg2WS9z/4HSXIkg6UQ0dG9pRBbFSUE0VEtQwSjjh00cdtH/ZlwB3+LmI LKgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755099608; x=1755704408; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dvH2/B2zmQ0D9vQHtz4nqDYlqgBbI+OptHpY/wLbPQQ=; b=DL6iww2vvYtE/xHvNXaEYAnkf91ugCSP4WgD8xh31HCF/onAgGkZNLD2iDQhzfOETG I+NcPiDNRgXPQjoS6VNyCfQl6015Juc8URe/0rcU9Uo0Su0UA1Pvz0SCwKilccsZraTo 2U3u+qL2mfW52/NMVyuaVXf8BIP11YsUhB8rfMfNJQ//dqUEEJiC7UPR74UYnBXuAp7S X70BkNs/dMK/6Ar65VohuSzRQ1JdaeZwdSrZIMeydBZH41FBmH7ASxiB0+gcE0zenrTS b1SuQiBC5l9uDUbUh3tTZ8fVD9OVRcJM/rpgDMn/V/tYB+6cMeBhW29jij7WmYS+SgLR UV+Q== X-Forwarded-Encrypted: i=1; AJvYcCU14gtPe2pC16Y+4jgSMyKp4X8aNvZRVubF5/Q3chr+G3Ab/YSdPk0eRCcMANmzzfFUXGOnwmPiyGIQpg==@vger.kernel.org, AJvYcCUnkn6c8ftDDWyHtER940cJ7XDLHzTSvfTVSHU8RAwHC64VW+4/DE7IR2x1WuTWoa7ERRY447+5V0k3mIKAUbqm@vger.kernel.org, AJvYcCUx7RFodvPZc5aNlH0c/7wrXcAjrUI0NqdgXQk/mdiCBesahTQG10Ig+Xj4Dpvs5FtKV2+MIRC8ualbPDQc@vger.kernel.org, AJvYcCVJ1MUBdEZSZwP/ZiK5iHzDP9fbOjPg8nsca2esnPVZDYozGmo1GUVX/05uS9HkWSycPiDAzB0Uc+Aw3ZzcrQ==@vger.kernel.org, AJvYcCWCm0DQ+D/3+agMJUMlB6gJhpKEesVvSTXmlo73186ClQ5OjfslzOQ7z8l/z9cZ1JnpS2uHYzwLXgzk0yH0gDE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4IF1SmVKcbpeXMZiFKQjMGWHLcV2irD03CO67qjFywOaEnfx7 rMFQSTwJypIUNTI1UaPfGXwEF/L++zG8HFNWPfddZJio/6oPpYcCKG7p X-Gm-Gg: ASbGnctc04VK/N8cGfoaJhyGfUoHqfWRpLPQraTgAk/5kpS/KREpBQK4C6aGH/YDe7E cbjUid/XuLyNTWSIsGeA84nl4y+hfJ1GBuZq8Eo2KzQgwvx+6Owl2Su5O8asqAJFMtLLrW7Uscd 2a1oGEUgYi8dQmgtPi4zl2RLUWzkINeja/wCF0Ewr2I0CKhSfgW4w7eNxDwa+KSQpLIi4RCRt7a 6EdhAnVWw/94fkafvCnCMgwtAZUJOlneUuT3wY6731jhPkMZBwH9urSMOl4QV29XMz9FDSv8Bt3 VVU2dIDqvUOPVYPwH9HM3Jomkc+E4G6prIXAXyPchonT5rd94Dq3RkU8xVHRgkoNm8K1ijER2Vw DNiMlYxE4JTaSq4dzhgu6J/nj4XSDZ1Nnvx3vM/LUB1agE8Zko79huy5sbp1mK0uC39HIDJYIRy yUf/495+2PAXSDRPHk8xHVUKVaR+0TDQk6RvkKdlFPXrlA X-Google-Smtp-Source: AGHT+IFQHqZ42a21nPnAfBqnqhi3SvB26bjyNrRjDQP3uTPdTZxNupm9Q0eYNC7DU+LaCe06RKPY/w== X-Received: by 2002:a05:620a:608b:b0:7e0:bd35:fd23 with SMTP id af79cd13be357-7e8652f8d3bmr366589685a.46.1755099607447; Wed, 13 Aug 2025 08:40:07 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4808:6353:5c00:d445:7694:2051:518c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f728a6asm1976119385a.64.2025.08.13.08.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 08:40:06 -0700 (PDT) From: Tamir Duberstein Date: Wed, 13 Aug 2025 11:39:52 -0400 Subject: [PATCH v3 7/9] rust: seq_file: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250813-core-cstr-fanout-1-v3-7-a15eca059c51@gmail.com> References: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> In-Reply-To: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Alexandre Courbot , Alexander Viro , Christian Brauner , Jan Kara Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-fsdevel@vger.kernel.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1755099591; l=1669; i=tamird@gmail.com; h=from:subject:message-id; bh=4r4hGm+5eFeJ1YD1XNe79Rof0MXa9XpmAsMvwuuTVcY=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QFJ0qGmLAvVhf4afCxnQAsgT2wKvjrpnkv9dk50qzD6Cg9FtpHbX+bHPMydLtqpXf3gEtgUpRyA oBpEXmc5iSAQ= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Signed-off-by: Tamir Duberstein --- rust/kernel/seq_file.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/seq_file.rs b/rust/kernel/seq_file.rs index 8f199b1a3bb1..59fbfc2473f8 100644 --- a/rust/kernel/seq_file.rs +++ b/rust/kernel/seq_file.rs @@ -4,7 +4,7 @@ //! //! C header: [`include/linux/seq_file.h`](srctree/include/linux/seq_file.= h) =20 -use crate::{bindings, c_str, types::NotThreadSafe, types::Opaque}; +use crate::{bindings, c_str, fmt, types::NotThreadSafe, types::Opaque}; =20 /// A utility for generating the contents of a seq file. #[repr(transparent)] @@ -31,7 +31,7 @@ pub unsafe fn from_raw<'a>(ptr: *mut bindings::seq_file) = -> &'a SeqFile { =20 /// Used by the [`seq_print`] macro. #[inline] - pub fn call_printf(&self, args: core::fmt::Arguments<'_>) { + pub fn call_printf(&self, args: fmt::Arguments<'_>) { // SAFETY: Passing a void pointer to `Arguments` is valid for `%pA= `. unsafe { bindings::seq_printf( @@ -47,7 +47,7 @@ pub fn call_printf(&self, args: core::fmt::Arguments<'_>)= { #[macro_export] macro_rules! seq_print { ($m:expr, $($arg:tt)+) =3D> ( - $m.call_printf(format_args!($($arg)+)) + $m.call_printf($crate::prelude::fmt!($($arg)+)) ); } pub use seq_print; --=20 2.50.1 From nobody Sat Oct 4 19:14:35 2025 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91656287245; Wed, 13 Aug 2025 15:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099612; cv=none; b=jEMA/Qh1mKrB/LFyVKmynb6/4jPdbwJspP+V7GzsfdZVhb0OaBNj+/iLcIpSRizvPIGSO1qricFIxI1hHvHg6dkAEwWDBYW/Y3TuOx+9zp7HlGJSJcPXRtYwDfljadj8bpAaFVZkl/cUkKVE3H3JWuYTnaCEXccyW558MFiUxAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099612; c=relaxed/simple; bh=GRf55CBaIXfcLimWiztzt2WPB2t4kstaCplsKmlIKbc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CI0jWZJzCN0wYTIZfaTwqb9pMKuAKl4KtgS3Z6EdJ6lkdR2aZ2yIjrK5WSGBW979cj1c7hQo6FcrxBaFa5xn0k9759apdbokr1e6WIxtR7u0OhMqUkhLu23HuVjKEbMDaj1GrcVu36sWut7N845UVi4aY5051z5DyV3CLiZkLzs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nBDS44ZV; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nBDS44ZV" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-7e8248b3f1cso820957285a.0; Wed, 13 Aug 2025 08:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755099609; x=1755704409; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Txy/cJf0GBJ+o0igtkYkmxWlbfspCRXzkvSHCuYjmpk=; b=nBDS44ZVyWsqhl6ehnXII0K9hY8sk3YCRB5CDFMkTPtkEBksBjNhI0yn2dGRg0V/ig 4omm9Wun7hOyzda9IWRK2L2gKBJWRTRtCEgiMJx04ncBSHRk5DIsnVvZbNY6YhQGnnds vouz0DUOIJa3LBZkTyvEzMrNuHuCXqgbKJT3HN81MOLYqX8ofih4wUg7t19nRskSDUYk oHctLDwzYe/bXd6CHvkYE+l33vPtwPHMTufqbSkLtFd2mKlB6BYW9Fut/EA3SxJp0qBD kiO+ksa0yUmVb/wvuyt1IksetPp3GVHN5QBNJaMZ09V/eUjwnpOOWsHRX43BY5QC6MdT YIUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755099609; x=1755704409; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Txy/cJf0GBJ+o0igtkYkmxWlbfspCRXzkvSHCuYjmpk=; b=abalbJW24rkQqU/AsTwNVR8XVSomnfOX7/vcmv3VCdQ6S3sDAFZVH2PFHTVBieGO+l ZV3hQEK9i9FhPQyD3lNyi+q5v6bc2UL/AB9se16vc6OJpWQLM2AgJQuiT2jFMp9VcOil jnCO5JfrwdHu21HHKLwZ8RDqZyxS1MoziBtXH2tfJVq6aevkE8E9Scag5BSFgujiWAMz x0s2y3ooH8X8AxvSFNd54gjWea/aKZQnz18YaCk5csP7LEofhIA4dv0yuu60snKuJ7Dw 47QJKXYWUtdYh/pQx39n9T56jkFNrgEmhbvghf/KY3NaSqjhZk+sl6JjG4F4mdFRw0le AzbA== X-Forwarded-Encrypted: i=1; AJvYcCUhz0xuRzazTjPy1kDAB9zPX+moyvQrt0E/vgFo4EVOc9OrHJn0+cZe7b4E0adAbgWNVw6kMp4sWX1/LEXX@vger.kernel.org, AJvYcCVAL4x4Kx3WrhF5QQItB26/lc9QMzoYDh38lnvcewOSzct4iGUHXCfg7MwbqZI6Re4ATsZS0jMIQWvx1g==@vger.kernel.org, AJvYcCWEDu+8snZAN1SbzyOyM9SPwcr7dzQrzTU2UiCxWAt/NnDrT3SFeU8xEFYzd3mkq/wpvBaPVXe0OdrkPEdOeQ==@vger.kernel.org, AJvYcCWNIt/KKIdhXZwGdkGUrmdYlqsq/iNM7Q8tESRq1J6xkSDyPLD7P9FaQZR6DqiZ1oE+80/HI0skfV8ucOvWGbci@vger.kernel.org, AJvYcCXhLtmky4oWUXPkyYywceH4/6vnd+0eX9NpyzE4biYKohjwb5jNSChyUmkT7ILlU82Gctix+xi+P0wzBjbwPjo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4b5J2OF689Jz49lhw9vGOoALiWkenvBvlSnu8B8zwkqVsGaSp f+sebnKiGLd+6N2KVtMRWQj5fhy6Aj23UGYM07jbhApBu0olK1ftyXRh X-Gm-Gg: ASbGncvF+1Mv5etNjpkdCGMhVLSQ7LgdkYNj2zrgAco/OUtAF3VWUbOVWHsLH6xKSQR CBWfaYF3pvyJyYRvFfG7qrW/Lw2gVDzfBcEkokaQC8xoTk+ZOoBCwBS8kfjZXKykRjLzIkpr6yw MTp/aO0Ao2R38mv7eGkaRnzIrq/tTqNGSQB3ggn677hdNGRdBXRO9Fh+3nFWARSL8TTfjcJdqfP 8GoCOqf2jouMKbVTYUc6mUsJMq+F5AdeDQ57G5d52AxY72GxPHPUTMB9FEo0ZIhrnk45d0jrgQi 5mfBawCkrGA9K+lUVe+9UoOJZ2jMm934s+58mKoR1JTsGN8GZu6RtQFh206RZYKHaGaJpVdhGRz Xm2J3s6I8RIEj3dAevZDyVgur+IeuzGXTSAGe7LdcJYme5HyphK7UeOUKt1ArbA7N6anvvqsd13 Tw/nW1WuH0iX3l3itZXY1QnGZkKCYuXnyXhA== X-Google-Smtp-Source: AGHT+IFxJagWPZZZ2hzouDkHBzhG5TPmQTOcmugjvUWSzlYtPNO6sC6jEyzc3aC/S1mkWUBCIwCCGQ== X-Received: by 2002:a05:620a:4897:b0:7e8:21af:3d6f with SMTP id af79cd13be357-7e865276f4emr408733985a.17.1755099609321; Wed, 13 Aug 2025 08:40:09 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4808:6353:5c00:d445:7694:2051:518c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f728a6asm1976119385a.64.2025.08.13.08.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 08:40:08 -0700 (PDT) From: Tamir Duberstein Date: Wed, 13 Aug 2025 11:39:53 -0400 Subject: [PATCH v3 8/9] rust: sync: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250813-core-cstr-fanout-1-v3-8-a15eca059c51@gmail.com> References: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> In-Reply-To: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Alexandre Courbot , Alexander Viro , Christian Brauner , Jan Kara Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-fsdevel@vger.kernel.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1755099591; l=998; i=tamird@gmail.com; h=from:subject:message-id; bh=GRf55CBaIXfcLimWiztzt2WPB2t4kstaCplsKmlIKbc=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QOAIUsQflz2HGM4AvRq77QQJYK6O5RKw6D4n7a/7jWYfKPgD+405KYQHwXHJu4uUN1IVy1k31PV 2UmoGqrCUOQI= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Signed-off-by: Tamir Duberstein --- rust/kernel/sync/arc.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs index 63a66761d0c7..4f3c1c2ff05e 100644 --- a/rust/kernel/sync/arc.rs +++ b/rust/kernel/sync/arc.rs @@ -20,6 +20,7 @@ alloc::{AllocError, Flags, KBox}, bindings, ffi::c_void, + fmt, init::InPlaceInit, try_init, types::{ForeignOwnable, Opaque}, @@ -27,7 +28,6 @@ use core::{ alloc::Layout, borrow::{Borrow, BorrowMut}, - fmt, marker::PhantomData, mem::{ManuallyDrop, MaybeUninit}, ops::{Deref, DerefMut}, --=20 2.50.1 From nobody Sat Oct 4 19:14:35 2025 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBAA427C150; Wed, 13 Aug 2025 15:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099614; cv=none; b=E0syqDC6NfQpmtKg/7PNwHmqg2Gxc1NYcfmdBzgziR6EAA6IhVsfLOn3wbt+t9nkoIBD7kpwgroJoLuXPbJ1nVgcM3XBCeB94cAPh5tvj7FgxCUFX9QUcsAd/2cIAUAX/WV1fGkIra0szh3kYlGSPHO0J3jZPnpaze0huJIOoJc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755099614; c=relaxed/simple; bh=crPkoR00cXYcPvikGdstY+SXedz+0EWwi2X94sQLRp0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HYG1fQujCtbceRXKCevVBI91e2dRe3Q9aUsaudp7mvM26OoujGoV01CPMAAIod+uz3O93UKxOa63hCvSQnKKUiV96NDzqYEASIoztvI09+sS03sXm/3rtfByYeEHAVUWI271OeVD13gwUrP3h8UncYzNhjgn/o066X4ORPE1iCk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A6fbZ9B+; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A6fbZ9B+" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7e86faa158fso2381885a.1; Wed, 13 Aug 2025 08:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755099612; x=1755704412; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=izK/WiAPZAaZKlIcAkFE0rrz+1wIUxFG7qzyjlv/jF0=; b=A6fbZ9B+mWkTKfhgQ52jktCmGH4KGjJvnbB4e/kqpbEI9jytizRDioO5NIW26PRDkO 0z3jyQTLfU0K/ho1pRASwLJcUrefOnv3Ilg5kiCyJw1n4D9x1hBsbnUjekYB1bPO8Wlk vb23pEdMN98uFbaucwlYYcJwMyK3qFeWYklcaCPdFQx6Cz6hbqNFK7Q9nbEPKQBCCtYk A1IweCB4apnzkYaIlFvAynvTCSB/vO9j1wpXcT+gIKDouVyRygoTXaKNxSl4gprCmlcs OWYVkl+TG52qSBxp1O4WSt4Q7d1tt8CcJ1ADZXKpt0b/uIujo/8WAcYSPAW40GX+eG58 fAHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755099612; x=1755704412; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=izK/WiAPZAaZKlIcAkFE0rrz+1wIUxFG7qzyjlv/jF0=; b=odWbzkIQC8cWfRhlsMx3Rnt1lVE1XVH1egfrl+i7eZ3pnn4De8fyoXMh9lwH7lShXw 1i4oRilxPIQ20xsyT8Fa/BOyi+zuVD0RR3GCPvPgYXVVUhkIDps0c1qZcJObCA05Ozba HODaOzY1iVI+4Qv/+jq1pAUx7O5BW6sAC/ufKLNTa5JXDQC2Cd/7Gaw2OWZPulkz/GfJ jd0ZQcNcpMde9++7XyKVnB7vZBG05ycOU3NB26RGj5f+VS579p+hsKZQdy2Og6vmjQze Ii24qV5UB6Y4zqMTYw2ySdaoFFy+Tdh4kOI0QOJWZVHSfcmZxU7+860lSIsMwfsioVpQ CK9g== X-Forwarded-Encrypted: i=1; AJvYcCUa7olgqubRcAsxUTWvN8JebfnoORBL5VkOj/yx7dOZgD8ydZG6IN0WH7v9VvwrZIONhyGW7pi0p0rrKjvvrA==@vger.kernel.org, AJvYcCVvr4zF0Sj+qYeAg22TpOTFW/kQcnvYd1gC8aoBQ1CK57hahnHaQjcdxtrAG7I/Oe+znX89REc21fVqMOtpTqlV@vger.kernel.org, AJvYcCWje9a7Nj9pKb8TubUzc6x3eiE40SBTRuWNy7sRfCysZ0v5hP1e/nArRZkltxVRDT7OZIxAcXlvpoF60CBZ@vger.kernel.org, AJvYcCXPsWjASYUzPxqlTP/qfrWFBMRemf1eG9iP7ML925Ew3EMN34pK2uzSIMIfYDmiJAchbPzHoxfBXZsduA==@vger.kernel.org, AJvYcCXUsRgk2sy+jI4QYCf4UmiA98ktUjFT8zIc8bZbHOjJI+2rs+HtPRZuQSsgOdhQCkxjy5TGmZteVO4Qhk2yznU=@vger.kernel.org X-Gm-Message-State: AOJu0YxGmlOD3geTVsl487zUWceArx8epQijR/ebbatt817w/T0w/LIq GMCVO8r5RqI6Kh2b4mxWtGAtBJMticyqLgUOPeOOvM1rr/O9uREeXyfl X-Gm-Gg: ASbGncvUbbPpWbzhSfWLR8C6x6XDiqWifsnuEUngKKUYmyFatS6/S8fJyWzo0jt0zh3 VU2JMO17L/OWKo0J6GX6YpCRpM1O5j2zLbrngE6l5RKVAEB8ugEIOyKUGUgfKzVW0c3UmYQl/P+ FMZpCo5DcjZPdyj9Xxq56rM8QfHFKpozmCX3Nujk1jEWmf57SqS0cX6pgfDekqjFLruGG3/LDDL noqraXkcFngGj7gtZXEATa1i/g4Dnt19ZvEOWNUPvVMqIPmJL/2aln4q85Sk3PWXcOBQ5QFxF4b pLXNI16uWjGWKX8Ae1kzA9LJ9ttzLASkPVB0CH42M9wN7AfmM8hY6LbPV5t3ijewzgxPQsl+17E 8pDMEqnh0chIGvs2xxOlM2e0ZuywNw3E6Werz5A+vqPBIntdgRwjq6QiSOtiRAUDEimsk6QwFe9 K2fEimGH2MTIYe+i/fa37pYqTERQ4nOsUyWw== X-Google-Smtp-Source: AGHT+IHZn/g5szhfMfFQFGXYl+pBHg/EpdCIVARFA50+xJj+KXURmnbR4Sb92/OTyxkaNK5Lvur9xQ== X-Received: by 2002:a05:620a:4505:b0:7e6:8b21:fe8b with SMTP id af79cd13be357-7e86fa5af32mr11093685a.0.1755099611401; Wed, 13 Aug 2025 08:40:11 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4808:6353:5c00:d445:7694:2051:518c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f728a6asm1976119385a.64.2025.08.13.08.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 08:40:10 -0700 (PDT) From: Tamir Duberstein Date: Wed, 13 Aug 2025 11:39:54 -0400 Subject: [PATCH v3 9/9] rust: device: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250813-core-cstr-fanout-1-v3-9-a15eca059c51@gmail.com> References: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> In-Reply-To: <20250813-core-cstr-fanout-1-v3-0-a15eca059c51@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Alexandre Courbot , Alexander Viro , Christian Brauner , Jan Kara Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-fsdevel@vger.kernel.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1755099591; l=3475; i=tamird@gmail.com; h=from:subject:message-id; bh=crPkoR00cXYcPvikGdstY+SXedz+0EWwi2X94sQLRp0=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QKPx7imLLl1IyTUMbn/UU9jRwKiWRs/5JaaYbOw7kxpIJQbxaN+IToLgk64d7J03HxECB5q+Z4M nXv5TSbO1yAs= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Signed-off-by: Tamir Duberstein --- rust/kernel/device/property.rs | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/rust/kernel/device/property.rs b/rust/kernel/device/property.rs index 49ee12a906db..3a332a8c53a9 100644 --- a/rust/kernel/device/property.rs +++ b/rust/kernel/device/property.rs @@ -11,6 +11,7 @@ alloc::KVec, bindings, error::{to_result, Result}, + fmt, prelude::*, str::{CStr, CString}, types::{ARef, Opaque}, @@ -68,16 +69,16 @@ pub fn is_of_node(&self) -> bool { unsafe { bindings::is_of_node(self.as_raw()) } } =20 - /// Returns an object that implements [`Display`](core::fmt::Display) = for + /// Returns an object that implements [`Display`](fmt::Display) for /// printing the name of a node. /// /// This is an alternative to the default `Display` implementation, wh= ich /// prints the full path. - pub fn display_name(&self) -> impl core::fmt::Display + '_ { + pub fn display_name(&self) -> impl fmt::Display + '_ { struct FwNodeDisplayName<'a>(&'a FwNode); =20 - impl core::fmt::Display for FwNodeDisplayName<'_> { - fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::= Result { + impl fmt::Display for FwNodeDisplayName<'_> { + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { // SAFETY: `self` is valid by its type invariant. let name =3D unsafe { bindings::fwnode_get_name(self.0.as_= raw()) }; if name.is_null() { @@ -87,7 +88,7 @@ fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::= fmt::Result { // - `fwnode_get_name` returns null or a valid C string. // - `name` was checked to be non-null. let name =3D unsafe { CStr::from_char_ptr(name) }; - write!(f, "{name}") + fmt::Display::fmt(name, f) } } =20 @@ -351,8 +352,8 @@ pub fn is_empty(&self) -> bool { } } =20 -impl core::fmt::Debug for FwNodeReferenceArgs { - fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result { +impl fmt::Debug for FwNodeReferenceArgs { + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { write!(f, "{:?}", self.as_slice()) } } @@ -377,8 +378,8 @@ enum Node<'a> { Owned(ARef), } =20 -impl core::fmt::Display for FwNode { - fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result { +impl fmt::Display for FwNode { + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { // The logic here is the same as the one in lib/vsprintf.c // (fwnode_full_name_string). =20 @@ -413,9 +414,9 @@ fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core= ::fmt::Result { // SAFETY: `fwnode_get_name_prefix` returns null or a // valid C string. let prefix =3D unsafe { CStr::from_char_ptr(prefix) }; - write!(f, "{prefix}")?; + fmt::Display::fmt(prefix, f)?; } - write!(f, "{}", fwnode.display_name())?; + fmt::Display::fmt(&fwnode.display_name(), f)?; } =20 Ok(()) --=20 2.50.1