From nobody Sat Oct 4 21:03:17 2025 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E95C423D7D4; Tue, 12 Aug 2025 16:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755015672; cv=none; b=ts2L441+MQoWkp/XZZ7IQiqazA1RGe28UCJzSzHlbXbzKgO6pJxuEim1gPEFycMnlw68vKQYMTSM4QgYuMk9yfH6CCdx5J8X629MHpxOOLediwT45fUFuVufEraARF7rkxJdIwMxFtBpkIAdpd0Q73XFMV7lEMd1qAZv10/6d8k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755015672; c=relaxed/simple; bh=dTd1bISb07RmhclrXB/gkGh9Mk7rG+MICfls5TsJ/3I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JaONDWqxh6I5eCHXL2LY83pJ/gvzxbRt0fkCf3GwS+H0uTfhpxLmsvmO2g81VKc58iAR/NkPW/mwfqSAl38xEbIZs4EzrjE7tQNF3ct9cJ8CPA4oeZYMJEX4MYUudlkfM3re2ZfRtdjz17/eAC77rl0sQqc5IzeKFn09h1dGXXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l77unBnL; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l77unBnL" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-76bd9d723bfso4974716b3a.1; Tue, 12 Aug 2025 09:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755015670; x=1755620470; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y35mC9vn+sDOpVRQKqdCv/s3UKbQ6a8UZ50nGToUsyY=; b=l77unBnLK4KtTpH6GBCL9gtFl+iqX0UFgEQ0jHfO/CFLzty+L9giU1zTXwkHJFCjpg jjN4pA1ipjezB66SPSxcehPMCGpXj2T5IaQN/N52oogxepp2Y2XKgbDtEbAMHX2QO5AA SOJOH3Gn6RydXkvRNN0OCGwlgOSWLxhaqojfnw/TKY2jz6DF9BRvDy0sn6m7xvy/1re9 1bnCNzeCyAwCxSvoc8WlVA8LIYFSgWS1r0p/sm8ADFjLf166AsyGjZhBanmBTuDWiSc3 oMvgNYOfd1/IowYkNEG5VMduEI1MeWAklQncx3uk4g7hNj5KUs5it2/K53tJpk1guOp3 VdOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755015670; x=1755620470; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y35mC9vn+sDOpVRQKqdCv/s3UKbQ6a8UZ50nGToUsyY=; b=fWoPMH315YvTT/5sjzVtGXTAccPjN+BUMetnbL+SChJBQMmAXemPMx6/9HHbX9WuUL gc+I8YzIRqZe+hGyw7ef76l+XcQc0wANVpFp/f3nLs/OOg8PVb/dCbbNhuWfqYdmBMaC PAKiS/FKSV3vlGqZu71+qqcJRbTVC9/uDMSmMbo4asvwjL+uzI9tky6f0bAfolqj/bBO rhO/yNG2qY8bnl3AB1nKjrxISoigwZ972w/vgmPjHdXyHD6qfQBdprDGoVCnINb4Cm/G spj4aRY8nnsDyFVprImsdADBhsiddxjEhk7mCOMY23f72fkKvZeiTb92t6GrpjCaqP9W YHow== X-Forwarded-Encrypted: i=1; AJvYcCVxwr6vgMbISHLlXuZ1to3a5+WW+Y0xQgGBvbrFecK33JLedCis+GOtIcwKVN6gomjSdX5jK5FAYcjcI4IKjjuEkW0=@vger.kernel.org X-Gm-Message-State: AOJu0YymYEhrLOHAmQkGpJ/w7/gg0bvFnNkHs3Q4DleWPkME/Mr/O1vo HDCyrPyK1MHfqe2lOMXSawUrhHAUXMCyxCVSnLffV0KXoqCXemYmaUAX X-Gm-Gg: ASbGncttRbO2UWBbarFHr2zxOppdYndrUJOU+m4LgI0SpSZTvaXAFejVRkwx2Soo78i +Jbd8RZ9sTzem6UpdMU5Wp87UjYV9s0wZWaK6LjT0I0NpF3f4o+G35vQ4SnyH67LRjXJU9oMzIS 1bEje8+WBhvEyBVtCDEe1yCbimj4YE7L5kaoweFiKiomJNP4AJnWXamqhTZQ3vezHjelHFNiOGc qtrOwCNRI2KE62qihvVdsAH5yOZ5kHs661Dj/vsGmg4VHsZ+AQdoBHXW58cHWqpQL2bwEDcI8ud 4E8YriEBKesK/JkKzBkKktT8NQUbsqlgMWKno6ozKkcYsNcj4N85dRXIQ7qKZg5OoTRI1MxFI07 R9L7Go4lYLacmiW8l/oNfv234iYGdY6glD5o= X-Google-Smtp-Source: AGHT+IHIeZ0gSCTYx2RYrw+PozfYnyCRvNfs8pJlWdAxPKJFcTkd+VRt6elmqXbkfgHK0ChA9lrxDg== X-Received: by 2002:a05:6a00:399d:b0:748:e5a0:aa77 with SMTP id d2e1a72fcca58-76e1fdccfedmr173077b3a.13.1755015669114; Tue, 12 Aug 2025 09:21:09 -0700 (PDT) Received: from localhost.localdomain ([2406:5900:2:f21::2a1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bccfdf9bdsm29794035b3a.111.2025.08.12.09.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 09:21:08 -0700 (PDT) From: Ryan Chung To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyer@efficios.com Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, Ryan Chung Subject: [PATCH] trace/trace_fprobe.c: TODO: handle filter, nofilter or symbol list Date: Wed, 13 Aug 2025 01:21:01 +0900 Message-ID: <20250812162101.5981-1-seokwoo.chung130@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Resolve TODO in `__register_trace_fprobe()`:=20 parse `tf->symbol` robustly (support `sym!filter` and comma-separated lists= ), trim tokens, ignore empties, deduplicate symbols, use bulk registration = for lists, return `-EEXIST` if already registered, and preserve lockdown/tr= acepoint deferral semantics. Please note that this was my personal interpretation of what TODO required here. Welcoming any feedback.=20 Signed-off-by: Ryan Chung --- kernel/trace/trace_fprobe.c | 102 +++++++++++++++++++++++++++++++++++- 1 file changed, 100 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_fprobe.c b/kernel/trace/trace_fprobe.c index b40fa59159ac..37d4260b9012 100644 --- a/kernel/trace/trace_fprobe.c +++ b/kernel/trace/trace_fprobe.c @@ -12,6 +12,8 @@ #include #include #include +#include +#include =20 #include "trace_dynevent.h" #include "trace_probe.h" @@ -762,8 +764,104 @@ static int __register_trace_fprobe(struct trace_fprob= e *tf) return __regsiter_tracepoint_fprobe(tf); } =20 - /* TODO: handle filter, nofilter or symbol list */ - return register_fprobe(&tf->fp, tf->symbol, NULL); + /* Parse tf->symbol */ + { + char *spec, *bang, *p; + int n =3D 0, w =3D 0, j, rc; + char **syms =3D NULL; + + spec =3D kstrdup(tf->symbol, GFP_KERNEL); + if (!spec) + return -ENOMEM; + + /* If a '!' exists, treat it as single symbol + filter */ + bang =3D strchr(spec, '!'); + if (bang) { + char *sym, *flt; + + *bang =3D '\0'; + sym =3D strim(spec); + flt =3D strim(bang + 1); + + if (!*sym || !*flt) { + kfree(spec); + return -EINVAL; /* reject empty symbol/filter */ + } + + rc =3D register_fprobe(&tf->fp, sym, flt); + kfree(spec); + return rc; + } + + /* Comma list (or single symbol without '!') */ + /* First pass: count non-empty tokens */ + p =3D spec; + while (p) { + char *tok =3D strsep(&p, ","); + if (tok && *strim(tok)) + n++; + } + + if (n =3D=3D 0){ + kfree(spec); + return -EINVAL; + } + + /* Allocate array for pointers into spec (callee copies/consumes) = */ + syms =3D kcalloc(n, sizeof(*syms), GFP_KERNEL); + if (!syms) { + kfree(spec); + return -ENOMEM; + } + + /* Second pass: fill, skipping empties */ + p =3D spec; + while (p) { + char *tok =3D strsep(&p, ","); + char *s; + + if (!tok) + break; + s =3D strim(tok); + if (!*s) + continue; + syms[w++] =3D s;=20 + } + =20 + /* Dedup in-place */ + for (i =3D 0; i < w; i++){ + if (!syms[i]) + continue; + for (j =3D i + 1; j < w; j++) { + if (syms[j] && !strcmp(syms[i], syms[j])) + syms[j] =3D NULL; + } + } + + /* Compact */ + for (i =3D 0, j =3D 0; i < w; i++) { + if (syms[i]) + syms[j++] =3D syms[i]; + } + w =3D j; + + /* After dedup, ensure we still have at least one symbol */ + if (w =3D=3D 0){ + kfree(syms); + kfree(spec); + return -EINVAL; + } + + /* Register list or single symbol, using the existing bulk API */ + if (w =3D=3D 1) + rc =3D register_fprobe(&tf->fp, syms[0], NULL); + else + rc =3D register_fprobe_syms(&tf->fp, (const char **)syms, w); + + kfree(syms); + kfree(spec); + return rc; + } } =20 /* Internal unregister function - just handle fprobe and flags */ --=20 2.43.0